[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-10-25 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623997#comment-17623997 ] Stefan Miklosovic commented on CASSANDRA-17753: --- [~maedhroz] I will commit soon. >

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-10-25 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623929#comment-17623929 ] Abe Ratnofsky commented on CASSANDRA-17753: --- [~smiklosovic] thanks for taking this on -

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-10-25 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623925#comment-17623925 ] Caleb Rackliffe commented on CASSANDRA-17753: - [~smiklosovic] +1 on your logging

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-10-21 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622148#comment-17622148 ] Stefan Miklosovic commented on CASSANDRA-17753: --- I am +1 on this (1) branch as

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-10-19 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620184#comment-17620184 ] Stefan Miklosovic commented on CASSANDRA-17753: --- I looked into this. When trying it

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-10-18 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619787#comment-17619787 ] Stefan Miklosovic commented on CASSANDRA-17753: --- hi [~aratnofsky] , if you dont mind I

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-09-06 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600926#comment-17600926 ] Abe Ratnofsky commented on CASSANDRA-17753: --- [~mck] pinging this - can we move to Ready to

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-08-23 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583864#comment-17583864 ] Abe Ratnofsky commented on CASSANDRA-17753: --- [~mck] any other review feedback here, or is

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-08-17 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581089#comment-17581089 ] Abe Ratnofsky commented on CASSANDRA-17753: --- Thanks for the clarification [~mck] – this

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-08-13 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579250#comment-17579250 ] Michael Semb Wever commented on CASSANDRA-17753: {quote}In -src, this file is

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-08-11 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578817#comment-17578817 ] Abe Ratnofsky commented on CASSANDRA-17753: --- [~mck] I'm trying to repro the situation

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-08-11 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578279#comment-17578279 ] Abe Ratnofsky commented on CASSANDRA-17753: --- Hey [~smiklosovic] – yes, I'll still be

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-08-10 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577862#comment-17577862 ] Stefan Miklosovic commented on CASSANDRA-17753: --- Hi [~aratnofsky] , do we still wait

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-22 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570208#comment-17570208 ] Abe Ratnofsky commented on CASSANDRA-17753: --- Good catch, I hadn't considered running this

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-21 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569458#comment-17569458 ] Brandon Williams commented on CASSANDRA-17753: -- Can we detect if there is no .git and

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-21 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569423#comment-17569423 ] Michael Semb Wever commented on CASSANDRA-17753: I'm good with the PR, and was about

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-14 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566982#comment-17566982 ] Abe Ratnofsky commented on CASSANDRA-17753: --- Updated with --verbose, let me know if you

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-14 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566977#comment-17566977 ] Michael Semb Wever commented on CASSANDRA-17753: bq. So it's only visible behind

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-14 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566975#comment-17566975 ] Abe Ratnofsky commented on CASSANDRA-17753: --- How about putting it behind a verbose flag?

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-14 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566969#comment-17566969 ] Michael Semb Wever commented on CASSANDRA-17753: bq. Often it's useful to run a soak

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-14 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566957#comment-17566957 ] Abe Ratnofsky commented on CASSANDRA-17753: --- [~mck] I'll move the Git stuff into

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-13 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566647#comment-17566647 ] Michael Semb Wever commented on CASSANDRA-17753: No objections to the git build

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-13 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566559#comment-17566559 ] Abe Ratnofsky commented on CASSANDRA-17753: --- Got a +1 from [~maedhroz], updated CHANGES

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-13 Thread Abe Ratnofsky (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566553#comment-17566553 ] Abe Ratnofsky commented on CASSANDRA-17753: --- If git isn't available the version will just

[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output

2022-07-13 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566549#comment-17566549 ] Brandon Williams commented on CASSANDRA-17753: --