[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033985#comment-15033985 ] Tomas Ramanauskas commented on CASSANDRA-7066: -- Hi, I created a new issue:

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700967#comment-14700967 ] Stefania commented on CASSANDRA-7066: - Thanks for spotting this, I hadn't noticed

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700888#comment-14700888 ] Benedict commented on CASSANDRA-7066: - I think it would be nice for clarity here

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701211#comment-14701211 ] Aleksey Yeschenko commented on CASSANDRA-7066: -- On a purely

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701222#comment-14701222 ] Benedict commented on CASSANDRA-7066: - That tag was introduced for situations

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699284#comment-14699284 ] Benedict commented on CASSANDRA-7066: - I meant just the sstables, not the txn log

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699251#comment-14699251 ] Benedict commented on CASSANDRA-7066: - Thanks. I've committed as

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699278#comment-14699278 ] Stefania commented on CASSANDRA-7066: - So if I understood correctly

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699435#comment-14699435 ] Benedict commented on CASSANDRA-7066: - [~jbellis] [~tjake]? Opinions? I don't have

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700533#comment-14700533 ] Stefania commented on CASSANDRA-7066: - I agree on stashing files with {{ignore}},

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699540#comment-14699540 ] Stefania commented on CASSANDRA-7066: - We could follow the disk failure policy as

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699547#comment-14699547 ] Benedict commented on CASSANDRA-7066: - bq. We could follow the disk failure policy

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699792#comment-14699792 ] Jonathan Ellis commented on CASSANDRA-7066: --- Assuming we apply

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699727#comment-14699727 ] Jonathan Ellis commented on CASSANDRA-7066: --- bq. we can (and probably will)

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699744#comment-14699744 ] Benedict commented on CASSANDRA-7066: - bq. So the scenario is, we crash hard AND

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699178#comment-14699178 ] Stefania commented on CASSANDRA-7066: - I've converted the boolean flag to an enum

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696634#comment-14696634 ] Benedict commented on CASSANDRA-7066: - bq. I did not switch the hard failure flag

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696395#comment-14696395 ] Stefania commented on CASSANDRA-7066: - [~benedict]: * I've incorporated your

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693042#comment-14693042 ] Benedict commented on CASSANDRA-7066: - Looking good. I've pushed a few more minor

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681487#comment-14681487 ] Stefania commented on CASSANDRA-7066: - Thanks for your quick feedback. bq. But we

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681468#comment-14681468 ] Stefania commented on CASSANDRA-7066: - Hi Benedict, thank you for your review. I

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681481#comment-14681481 ] Benedict commented on CASSANDRA-7066: - bq. Is this what you intended? Yes, this

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680266#comment-14680266 ] Benedict commented on CASSANDRA-7066: - (if we cut it too close to the line for

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680071#comment-14680071 ] Benedict commented on CASSANDRA-7066: - Sorry for the review delay. It's looking

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663280#comment-14663280 ] Stefania commented on CASSANDRA-7066: - Thanks, let's move the discussion to

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661942#comment-14661942 ] Yuki Morishita commented on CASSANDRA-7066: --- Found this while I was looking

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651591#comment-14651591 ] Aleksey Yeschenko commented on CASSANDRA-7066: -- bq. Will this cause

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651571#comment-14651571 ] Benedict commented on CASSANDRA-7066: - bq. Will this cause problems if the alpha

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651304#comment-14651304 ] Stefania commented on CASSANDRA-7066: - Thanks Benedict. Code updated as follows:

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649193#comment-14649193 ] Benedict commented on CASSANDRA-7066: - Thanks. Looks like great work as always.

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648950#comment-14648950 ] Stefania commented on CASSANDRA-7066: - [~benedict], ready for a first round of

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648158#comment-14648158 ] Nick Bailey commented on CASSANDRA-7066: bq. If copying the files manually

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648553#comment-14648553 ] Stefania commented on CASSANDRA-7066: - Yes we can add a command that will delete

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648448#comment-14648448 ] Robert Coli commented on CASSANDRA-7066: (apologies is this is sufficiently

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648509#comment-14648509 ] Benedict commented on CASSANDRA-7066: - [~rcoli]: while this patch does not remove

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647460#comment-14647460 ] Stefania commented on CASSANDRA-7066: - [~benedict] thank you for your comments.

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647469#comment-14647469 ] Benedict commented on CASSANDRA-7066: - bq. not sure what a panic error is exactly?

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646618#comment-14646618 ] Nick Bailey commented on CASSANDRA-7066: Thanks for the ping Jonathan. There

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645754#comment-14645754 ] Benedict commented on CASSANDRA-7066: - Thanks Stef. A couple of comments about

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645359#comment-14645359 ] Jonathan Ellis commented on CASSANDRA-7066: --- /cc [~nickmbailey] Simplify

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645384#comment-14645384 ] Stefania commented on CASSANDRA-7066: - Discussion on sstablelister starts at [this

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644421#comment-14644421 ] Benedict commented on CASSANDRA-7066: - [~stefania]: jake has correctly pointed out

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645489#comment-14645489 ] Stefania commented on CASSANDRA-7066: - [~benedict] first basic single log file

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645494#comment-14645494 ] Stefania commented on CASSANDRA-7066: - CI:

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645407#comment-14645407 ] Stefania commented on CASSANDRA-7066: - _nodetool refresh_ is implemented by

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645385#comment-14645385 ] Stefania commented on CASSANDRA-7066: - [~benedict]: bq. if we also log the last

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645387#comment-14645387 ] T Jake Luciani commented on CASSANDRA-7066: --- bq. There is a new tool That's

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644630#comment-14644630 ] Jonathan Ellis commented on CASSANDRA-7066: --- bq. if we lose the new file,

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644659#comment-14644659 ] Jonathan Ellis commented on CASSANDRA-7066: --- Granted, but a bug in the

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644707#comment-14644707 ] T Jake Luciani commented on CASSANDRA-7066: --- The value of the 'old way' was

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644623#comment-14644623 ] Benedict commented on CASSANDRA-7066: - bq. Is that SOL as in Now we can't tell

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644600#comment-14644600 ] T Jake Luciani commented on CASSANDRA-7066: --- In general I'm worried about

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644616#comment-14644616 ] T Jake Luciani commented on CASSANDRA-7066: --- bq. If you lose one of these

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644685#comment-14644685 ] Benedict commented on CASSANDRA-7066: - Well, a bug in the implementation could

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644607#comment-14644607 ] Benedict commented on CASSANDRA-7066: - If you lose one of these files you are SOL,

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644619#comment-14644619 ] Jonathan Ellis commented on CASSANDRA-7066: --- bq. If you lose one of these

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644635#comment-14644635 ] Benedict commented on CASSANDRA-7066: - Well, if your file system is losing files

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644718#comment-14644718 ] Benedict commented on CASSANDRA-7066: - bq. The value of the 'old way' was the

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639822#comment-14639822 ] Stefania commented on CASSANDRA-7066: - Your changes look good, I've rebased and

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638588#comment-14638588 ] Benedict commented on CASSANDRA-7066: - Thanks. It's about ready I think. I've

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634572#comment-14634572 ] Stefania commented on CASSANDRA-7066: - [~benedict] this is ready for another round

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631066#comment-14631066 ] Stefania commented on CASSANDRA-7066: - bq. Also, I'd like to propose we hide

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631119#comment-14631119 ] Stefania commented on CASSANDRA-7066: - Then I need to add a new offline method to

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631129#comment-14631129 ] Stefania commented on CASSANDRA-7066: - Sounds good. :) Simplify (and unify)

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631124#comment-14631124 ] Benedict commented on CASSANDRA-7066: - Should be. In fact we'll need a metadata

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631109#comment-14631109 ] Benedict commented on CASSANDRA-7066: - LifecycleTransaction already supports this,

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627819#comment-14627819 ] Benedict commented on CASSANDRA-7066: - Oh, one more suggestion: I'd like it if the

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627789#comment-14627789 ] Benedict commented on CASSANDRA-7066: - Sorry for the slow response on this, but

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611615#comment-14611615 ] Benedict commented on CASSANDRA-7066: - That's going to be a problem for just about

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611610#comment-14611610 ] Stefania commented on CASSANDRA-7066: - [~benedict] this has also been rebased

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611619#comment-14611619 ] Stefania commented on CASSANDRA-7066: - As you prefer, let's carry on then.

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602630#comment-14602630 ] Stefania commented on CASSANDRA-7066: - [~benedict] I've pushed a few more commits

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599340#comment-14599340 ] Benedict commented on CASSANDRA-7066: - Thanks. I've pushed

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593135#comment-14593135 ] Stefania commented on CASSANDRA-7066: - [~benedict], this is ready for another

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578747#comment-14578747 ] Benedict commented on CASSANDRA-7066: - I've pushed a few suggestions

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578796#comment-14578796 ] Benedict commented on CASSANDRA-7066: - In that query, I'm talking about the

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578818#comment-14578818 ] Stefania commented on CASSANDRA-7066: - Thank you for your review Benedict. I

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578840#comment-14578840 ] Benedict commented on CASSANDRA-7066: - bq. Regarding SSTableDeletingTask, I'll see

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578794#comment-14578794 ] Tupshin Harper commented on CASSANDRA-7066: --- Users don't care about

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575692#comment-14575692 ] Benedict commented on CASSANDRA-7066: - Hi [~stefania_alborghetti]: Sorry for

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567376#comment-14567376 ] Stefania commented on CASSANDRA-7066: - Hi [~benedict], almost done, just clearing

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557209#comment-14557209 ] Benedict commented on CASSANDRA-7066: - Hi [~stef1927]. Thanks for posting this,

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530222#comment-14530222 ] Stefania commented on CASSANDRA-7066: - I've integrated Benedict's patch plus fixed

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531914#comment-14531914 ] Stefania commented on CASSANDRA-7066: - Pull request for dtests:

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528047#comment-14528047 ] Stefania commented on CASSANDRA-7066: - Thank you for your comments, I've pushed a

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528079#comment-14528079 ] Stefania commented on CASSANDRA-7066: - Thanks, I will integrate your patch

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526389#comment-14526389 ] Stefania commented on CASSANDRA-7066: - Thanks for your feedback, [~benedict],

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526477#comment-14526477 ] Benedict commented on CASSANDRA-7066: - Sure, I'll review Simplify (and unify)

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526513#comment-14526513 ] Benedict commented on CASSANDRA-7066: - As far as level of integration goes, this

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522888#comment-14522888 ] Stefania commented on CASSANDRA-7066: - I am having doubts on whether we should

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522998#comment-14522998 ] Stefania commented on CASSANDRA-7066: - To give more context you can look at the

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523011#comment-14523011 ] Benedict commented on CASSANDRA-7066: - It looks like all of those could simply

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522990#comment-14522990 ] Benedict commented on CASSANDRA-7066: - If we're only keeping the tmp files for a

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523179#comment-14523179 ] Joshua McKenzie commented on CASSANDRA-7066: If we stick with the tmp

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523204#comment-14523204 ] Marcus Eriksson commented on CASSANDRA-7066: when running clusters you

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516574#comment-14516574 ] Stefania commented on CASSANDRA-7066: - I've started work on a branch based on

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514415#comment-14514415 ] Benedict commented on CASSANDRA-7066: - It is probably best to work from 8984-alt,

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510511#comment-14510511 ] Stefania commented on CASSANDRA-7066: - Hi [~benedict], should this be implemented

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394805#comment-14394805 ] Jonathan Ellis commented on CASSANDRA-7066: --- I like it. Simplify (and

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394656#comment-14394656 ] Jonathan Ellis commented on CASSANDRA-7066: --- bq. if we're compacting

  1   2   >