[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-17 Thread T Jake Luciani (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138399#comment-14138399 ] T Jake Luciani commented on CASSANDRA-7719: --- +1 Add PreparedStatements

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-12 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132561#comment-14132561 ] Aleksey Yeschenko commented on CASSANDRA-7719: -- Got a few nits/questions:

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-09 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127791#comment-14127791 ] Carl Yeksigian commented on CASSANDRA-7719: --- LGTM. Add PreparedStatements

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-09 Thread Mikhail Stepura (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127922#comment-14127922 ] Mikhail Stepura commented on CASSANDRA-7719: Couple of nits, * Don't use

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-09 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127935#comment-14127935 ] Benedict commented on CASSANDRA-7719: - bq. Don't use String.format in

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-09 Thread Brandon Williams (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127990#comment-14127990 ] Brandon Williams commented on CASSANDRA-7719: - bq. More important than

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-09 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127999#comment-14127999 ] Benedict commented on CASSANDRA-7719: - Only after constructing an object array and

[jira] [Commented] (CASSANDRA-7719) Add PreparedStatements related metrics

2014-09-09 Thread T Jake Luciani (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128016#comment-14128016 ] T Jake Luciani commented on CASSANDRA-7719: --- Interestingly, those lines were