[cassandra-website] branch asf-staging updated (73b75eae -> cb9d2a20)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 73b75eae generate docs for 466d6ffe new cb9d2a20 generate docs for 466d6ffe This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (73b75eae) \ N -- N -- N refs/heads/asf-staging (cb9d2a20) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (36e96091 -> 73b75eae)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 36e96091 generate docs for 466d6ffe new 73b75eae generate docs for 466d6ffe This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (36e96091) \ N -- N -- N refs/heads/asf-staging (73b75eae) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741216#comment-17741216
]
Caleb Rackliffe edited comment on CASSANDRA-18656 at 7/7/23 11:29 PM:
--
CC [~adelapena] [~mike_tr_adamson]
was (Author: maedhroz):
CC [~adelapena]
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
> Local/Startup and Shutdown
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
> builds after SSTable streaming could leave indexes in a partially built
> state, even after a restart, requiring manual operator intervention. There,
> and in CASSANDRA-13725, we made an attempt to remedy this situation, ensuring
> that indexes would at least be rebuilt on restart after this kind of failure.
> However, there are some difficulties the solution there does not address.
> Let's look at a simple example...
> Suppose an SSTable has been streamed to a node, and that node arrives in
> {{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
> make the presence of the new SSTables durable, and then we'll call
> {{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
> making it available for reads. We then notify listeners about the new
> SSTable, among them the {{SecondaryIndexManager}}, which will do a blocking
> index build for the new SSTable. Conceptually, at this point, we already have
> a problem (if a transient one), as there are live SSTables that have not been
> indexed.
> What if the 2i build fails, though? Let's assume it fails because of a
> disorderly (or orderly!) node shutdown. Some index implementations (SASI,
> SAI) might be able to rebuild incrementally, but the legacy 2i has no way of
> doing this right now. A full index rebuild on a large table could take a very
> long time (days, weeks, etc.) and is ultimately not a viable way to proceed.
> Let's say we were able to build incrementally though, and we had an SAI index
> that did exactly this on node restart. We would still have a gap in
> availability, because on startup, {{ColumnFamilyStore}} (see constructor)
> does not block on its calls to {{SecondaryIndexManager#addIndex()}}, which,
> via {{createIndex()}} actuate the index building process.
> Of course, SAI implements a notion of "queryability" that would quickly take
> the node out of rotation for queries across the cluster. Once its
> initialization task runs on restart, the indexes in question would
> immediately be marked non-queryable. SAI build incrementally, and might be
> able to block startup to do so in this case. Legacy 2i cannot reasonably do
> this though.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741218#comment-17741218
]
Caleb Rackliffe commented on CASSANDRA-18656:
-
...and the more I look at this, the more I'm afraid we actually subtly handle
{{SSTableAddedNotification}} incorrectly altogether in relation to all
secondary index building/validation. In other words, I don't think we should
ever build 2i *after* adding new SSTables to the {{Tracker}}. We may need to
address this the same way we do streaming...
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
> Local/Startup and Shutdown
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
> builds after SSTable streaming could leave indexes in a partially built
> state, even after a restart, requiring manual operator intervention. There,
> and in CASSANDRA-13725, we made an attempt to remedy this situation, ensuring
> that indexes would at least be rebuilt on restart after this kind of failure.
> However, there are some difficulties the solution there does not address.
> Let's look at a simple example...
> Suppose an SSTable has been streamed to a node, and that node arrives in
> {{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
> make the presence of the new SSTables durable, and then we'll call
> {{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
> making it available for reads. We then notify listeners about the new
> SSTable, among them the {{SecondaryIndexManager}}, which will do a blocking
> index build for the new SSTable. Conceptually, at this point, we already have
> a problem (if a transient one), as there are live SSTables that have not been
> indexed.
> What if the 2i build fails, though? Let's assume it fails because of a
> disorderly (or orderly!) node shutdown. Some index implementations (SASI,
> SAI) might be able to rebuild incrementally, but the legacy 2i has no way of
> doing this right now. A full index rebuild on a large table could take a very
> long time (days, weeks, etc.) and is ultimately not a viable way to proceed.
> Let's say we were able to build incrementally though, and we had an SAI index
> that did exactly this on node restart. We would still have a gap in
> availability, because on startup, {{ColumnFamilyStore}} (see constructor)
> does not block on its calls to {{SecondaryIndexManager#addIndex()}}, which,
> via {{createIndex()}} actuate the index building process.
> Of course, SAI implements a notion of "queryability" that would quickly take
> the node out of rotation for queries across the cluster. Once its
> initialization task runs on restart, the indexes in question would
> immediately be marked non-queryable. SAI build incrementally, and might be
> able to block startup to do so in this case. Legacy 2i cannot reasonably do
> this though.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741216#comment-17741216
]
Caleb Rackliffe commented on CASSANDRA-18656:
-
CC [~adelapena]
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
> Local/Startup and Shutdown
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
> builds after SSTable streaming could leave indexes in a partially built
> state, even after a restart, requiring manual operator intervention. There,
> and in CASSANDRA-13725, we made an attempt to remedy this situation, ensuring
> that indexes would at least be rebuilt on restart after this kind of failure.
> However, there are some difficulties the solution there does not address.
> Let's look at a simple example...
> Suppose an SSTable has been streamed to a node, and that node arrives in
> {{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
> make the presence of the new SSTables durable, and then we'll call
> {{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
> making it available for reads. We then notify listeners about the new
> SSTable, among them the {{SecondaryIndexManager}}, which will do a blocking
> index build for the new SSTable. Conceptually, at this point, we already have
> a problem (if a transient one), as there are live SSTables that have not been
> indexed.
> What if the 2i build fails, though? Let's assume it fails because of a
> disorderly (or orderly!) node shutdown. Some index implementations (SASI,
> SAI) might be able to rebuild incrementally, but the legacy 2i has no way of
> doing this right now. A full index rebuild on a large table could take a very
> long time (days, weeks, etc.) and is ultimately not a viable way to proceed.
> Let's say we were able to build incrementally though, and we had an SAI index
> that did exactly this on node restart. We would still have a gap in
> availability, because on startup, {{ColumnFamilyStore}} (see constructor)
> does not block on its calls to {{SecondaryIndexManager#addIndex()}}, which,
> via {{createIndex()}} actuate the index building process.
> Of course, SAI implements a notion of "queryability" that would quickly take
> the node out of rotation for queries across the cluster. Once its
> initialization task runs on restart, the indexes in question would
> immediately be marked non-queryable. SAI build incrementally, and might be
> able to block startup to do so in this case. Legacy 2i cannot reasonably do
> this though.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741215#comment-17741215
]
Caleb Rackliffe commented on CASSANDRA-18656:
-
One way we can address this is by making sure streamed SSTables and the indexes
attached to them both fall within the scope of the {{STREAM}} transaction.
The current SSTable streaming process is roughly:
1.) stream an SSTable
2.) commit the streaming transaction w/ the SSTable
3.) add the SSTable to the column family
4.) via listener notification as part of 3, index the new SSTable in a blocking
fashion
2 and 3 are in this order, because if 3 came before 2, the new SSTable could
participate in reads, the node could die before the transaction committed, and
the SSTable would be gone after restart. The problem is that if the node dies
while 4 is in progress, the node will come back up thinking that the streaming
operation was wholly successful, and allow startup to complete. The index in
question will be rebuilt, but that rebuild will not block startup, and the
index will be unusable while that happens.
I propose that we move 4 between 1 and 2. This way the SSTable and related
indexes are ready to query and we commit the transaction, or the transaction is
simply considered failed on restart. (i.e. On restart, it would just be as the
streaming had never occurred.) Doing this should make the system of marking the
index unbuilt and then built again irrelevant across restart as well, although
I'm not entirely sure that would roll back any of the complexity of
CASSANDRA-10130 and CASSANDRA-13725. {{SecondaryIndexManager}} currently
handles {{SSTableAddedNotification}} for more than just streaming, and we would
have to take care that we leave those cases intact (SSTable import, etc.),
although they may suffer from similar problems.
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
> Local/Startup and Shutdown
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
> builds after SSTable streaming could leave indexes in a partially built
> state, even after a restart, requiring manual operator intervention. There,
> and in CASSANDRA-13725, we made an attempt to remedy this situation, ensuring
> that indexes would at least be rebuilt on restart after this kind of failure.
> However, there are some difficulties the solution there does not address.
> Let's look at a simple example...
> Suppose an SSTable has been streamed to a node, and that node arrives in
> {{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
> make the presence of the new SSTables durable, and then we'll call
> {{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
> making it available for reads. We then notify listeners about the new
> SSTable, among them the {{SecondaryIndexManager}}, which will do a blocking
> index build for the new SSTable. Conceptually, at this point, we already have
> a problem (if a transient one), as there are live SSTables that have not been
> indexed.
> What if the 2i build fails, though? Let's assume it fails because of a
> disorderly (or orderly!) node shutdown. Some index implementations (SASI,
> SAI) might be able to rebuild incrementally, but the legacy 2i has no way of
> doing this right now. A full index rebuild on a large table could take a very
> long time (days, weeks, etc.) and is ultimately not a viable way to proceed.
> Let's say we were able to build incrementally though, and we had an SAI index
> that did exactly this on node restart. We would still have a gap in
> availability, because on startup, {{ColumnFamilyStore}} (see constructor)
> does not block on its calls to {{SecondaryIndexManager#addIndex()}}, which,
> via {{createIndex()}} actuate the index building process.
> Of course, SAI implements a notion of "queryability" that would quickly take
> the node out of rotation for queries across the cluster. Once its
> initialization task runs on restart, the indexes in question would
> immediately be marked non-queryable. SAI build incrementally, and might be
> able to block startup to do so in this case. Legacy 2i cannot reasonably do
> this though.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To
[jira] [Commented] (CASSANDRA-18653) Avoid unnecessary index builds and validations
[ https://issues.apache.org/jira/browse/CASSANDRA-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741212#comment-17741212 ] Caleb Rackliffe commented on CASSANDRA-18653: - Created CASSANDRA-18656 > Avoid unnecessary index builds and validations > -- > > Key: CASSANDRA-18653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18653 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > > In the testing of CASSANDRA-18490 it was noted that the > SSTableAddedNotification will trigger an index build that will always build > the column index components even if they already exist and are valid. > The same notification is also handled by the StorageAttachedIndexGroup that > can validate the components. This can lead to the components being validated > more than is necessary. > We should coordinate these notification handlers so there is no overlap of > responsibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18656:
Description:
Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
builds after SSTable streaming could leave indexes in a partially built state,
even after a restart, requiring manual operator intervention. There, and in
CASSANDRA-13725, we made an attempt to remedy this situation, ensuring that
indexes would at least be rebuilt on restart after this kind of failure.
However, there are some difficulties the solution there does not address.
Let's look at a simple example...
Suppose an SSTable has been streamed to a node, and that node arrives in
{{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
make the presence of the new SSTables durable, and then we'll call
{{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
making it available for reads. We then notify listeners about the new SSTable,
among them the {{SecondaryIndexManager}}, which will do a blocking index build
for the new SSTable. Conceptually, at this point, we already have a problem (if
a transient one), as there are live SSTables that have not been indexed.
What if the 2i build fails, though? Let's assume it fails because of a
disorderly (or orderly!) node shutdown. Some index implementations (SASI, SAI)
might be able to rebuild incrementally, but the legacy 2i has no way of doing
this right now. A full index rebuild on a large table could take a very long
time (days, weeks, etc.) and is ultimately not a viable way to proceed. Let's
say we were able to build incrementally though, and we had an SAI index that
did exactly this on node restart. We would still have a gap in availability,
because on startup, {{ColumnFamilyStore}} (see constructor) does not block on
its calls to {{SecondaryIndexManager#addIndex()}}, which, via {{createIndex()}}
actuate the index building process.
Of course, SAI implements a notion of "queryability" that would quickly take
the node out of rotation for queries across the cluster. Once its
initialization task runs on restart, the indexes in question would immediately
be marked non-queryable. SAI build incrementally, and might be able to block
startup to do so in this case. Legacy 2i cannot reasonably do this though.
was:
Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
builds after SSTable streaming could leave indexes in a partially built state,
even after a restart, requiring manual operator intervention. There, and in
CASSANDRA-13725, we made an attempt to remedy this situation, ensuring that
indexes would at least be rebuilt on restart after this kind of failure.
However, there are some difficulties the solution there does not address.
Let's look at a simple example...
Suppose an SSTable has been streamed to a node, and that node arrives in
{{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
make the presence of the new SSTables durable, and then we'll call
{{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
making it available for reads. We then notify listeners about the new SSTable,
among them the {{SecondaryIndexManager}}, which will do a blocking index build
for the new SSTable. Conceptually, at this point, we already have a problem (if
a transient one), as there are live SSTables that have not been indexed.
What if the 2i build fails, though? Let's assume it fails because of a
disorderly (or orderly!) node shutdown. Some index implementations (SASI, SAI)
might be able to rebuild incrementally, but the legacy 2i has no way of doing
this right now. A full index rebuild on a large table could take a very long
time (days, weeks, etc.) and is ultimately not a viable way to proceed. Let's
say we were able to build incrementally though, and we had an SAI index that
did exactly this on node restart. We would still have a gap in availability,
because on startup, {{ColumnFamilyStore}} (see constructor) does not block on
its calls to {{SecondaryIndexManager#addIndex()}}, which, via {{createIndex()}}
actuate the index building process.
Of course, SAI implements a notion of "queryability" that would quickly take
the node out of rotation for queries across the cluster. Once its
initialization task runs on restart, the indexes in question would immediately
be marked non-queryable.
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming,
[jira] [Updated] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18656:
Bug Category: Parent values: Availability(12983)Level 1 values:
Unavailable(12994)
Complexity: Normal
Discovered By: User Report
Severity: Critical
Status: Open (was: Triage Needed)
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
> Local/Startup and Shutdown
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
> builds after SSTable streaming could leave indexes in a partially built
> state, even after a restart, requiring manual operator intervention. There,
> and in CASSANDRA-13725, we made an attempt to remedy this situation, ensuring
> that indexes would at least be rebuilt on restart after this kind of failure.
> However, there are some difficulties the solution there does not address.
> Let's look at a simple example...
> Suppose an SSTable has been streamed to a node, and that node arrives in
> {{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
> make the presence of the new SSTables durable, and then we'll call
> {{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
> making it available for reads. We then notify listeners about the new
> SSTable, among them the {{SecondaryIndexManager}}, which will do a blocking
> index build for the new SSTable. Conceptually, at this point, we already have
> a problem (if a transient one), as there are live SSTables that have not been
> indexed.
> What if the 2i build fails, though? Let's assume it fails because of a
> disorderly (or orderly!) node shutdown. Some index implementations (SASI,
> SAI) might be able to rebuild incrementally, but the legacy 2i has no way of
> doing this right now. A full index rebuild on a large table could take a very
> long time (days, weeks, etc.) and is ultimately not a viable way to proceed.
> Let's say we were able to build incrementally though, and we had an SAI index
> that did exactly this on node restart. We would still have a gap in
> availability, because on startup, {{ColumnFamilyStore}} (see constructor)
> does not block on its calls to {{SecondaryIndexManager#addIndex()}}, which,
> via {{createIndex()}} actuate the index building process.
> Of course, SAI implements a notion of "queryability" that would quickly take
> the node out of rotation for queries across the cluster. Once its
> initialization task runs on restart, the indexes in question would
> immediately be marked non-queryable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18656:
Fix Version/s: 4.0.x
4.1.x
5.x
> Ensure SSTable streaming transactions do not commit before building attached
> secondary indexes
> --
>
> Key: CASSANDRA-18656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
> Local/Startup and Shutdown
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
> builds after SSTable streaming could leave indexes in a partially built
> state, even after a restart, requiring manual operator intervention. There,
> and in CASSANDRA-13725, we made an attempt to remedy this situation, ensuring
> that indexes would at least be rebuilt on restart after this kind of failure.
> However, there are some difficulties the solution there does not address.
> Let's look at a simple example...
> Suppose an SSTable has been streamed to a node, and that node arrives in
> {{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
> make the presence of the new SSTables durable, and then we'll call
> {{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
> making it available for reads. We then notify listeners about the new
> SSTable, among them the {{SecondaryIndexManager}}, which will do a blocking
> index build for the new SSTable. Conceptually, at this point, we already have
> a problem (if a transient one), as there are live SSTables that have not been
> indexed.
> What if the 2i build fails, though? Let's assume it fails because of a
> disorderly (or orderly!) node shutdown. Some index implementations (SASI,
> SAI) might be able to rebuild incrementally, but the legacy 2i has no way of
> doing this right now. A full index rebuild on a large table could take a very
> long time (days, weeks, etc.) and is ultimately not a viable way to proceed.
> Let's say we were able to build incrementally though, and we had an SAI index
> that did exactly this on node restart. We would still have a gap in
> availability, because on startup, {{ColumnFamilyStore}} (see constructor)
> does not block on its calls to {{SecondaryIndexManager#addIndex()}}, which,
> via {{createIndex()}} actuate the index building process.
> Of course, SAI implements a notion of "queryability" that would quickly take
> the node out of rotation for queries across the cluster. Once its
> initialization task runs on restart, the indexes in question would
> immediately be marked non-queryable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18656) Ensure SSTable streaming transactions do not commit before building attached secondary indexes
Caleb Rackliffe created CASSANDRA-18656:
---
Summary: Ensure SSTable streaming transactions do not commit
before building attached secondary indexes
Key: CASSANDRA-18656
URL: https://issues.apache.org/jira/browse/CASSANDRA-18656
Project: Cassandra
Issue Type: Bug
Components: Consistency/Streaming, Feature/2i Index, Feature/SAI,
Local/Startup and Shutdown
Reporter: Caleb Rackliffe
Assignee: Caleb Rackliffe
Back in 2015, we identified in CASSANDRA-10130 a case where failures in 2i
builds after SSTable streaming could leave indexes in a partially built state,
even after a restart, requiring manual operator intervention. There, and in
CASSANDRA-13725, we made an attempt to remedy this situation, ensuring that
indexes would at least be rebuilt on restart after this kind of failure.
However, there are some difficulties the solution there does not address.
Let's look at a simple example...
Suppose an SSTable has been streamed to a node, and that node arrives in
{{CassandraStreamReceiver#finished()}}. We'll call {{finishTransaction()}} to
make the presence of the new SSTables durable, and then we'll call
{{ColumnFamilyStore#addSStables()}}, which add the table to the {{Tracker}},
making it available for reads. We then notify listeners about the new SSTable,
among them the {{SecondaryIndexManager}}, which will do a blocking index build
for the new SSTable. Conceptually, at this point, we already have a problem (if
a transient one), as there are live SSTables that have not been indexed.
What if the 2i build fails, though? Let's assume it fails because of a
disorderly (or orderly!) node shutdown. Some index implementations (SASI, SAI)
might be able to rebuild incrementally, but the legacy 2i has no way of doing
this right now. A full index rebuild on a large table could take a very long
time (days, weeks, etc.) and is ultimately not a viable way to proceed. Let's
say we were able to build incrementally though, and we had an SAI index that
did exactly this on node restart. We would still have a gap in availability,
because on startup, {{ColumnFamilyStore}} (see constructor) does not block on
its calls to {{SecondaryIndexManager#addIndex()}}, which, via {{createIndex()}}
actuate the index building process.
Of course, SAI implements a notion of "queryability" that would quickly take
the node out of rotation for queries across the cluster. Once its
initialization task runs on restart, the indexes in question would immediately
be marked non-queryable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[
https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741208#comment-17741208
]
Jeremiah Jordan commented on CASSANDRA-18615:
-
Listing some names that come to mind after reading these comments:
local_table_legacy
equality_only_local_table
hidden_local_table
I like the word local being in the name since they use the LocalPartitioner.
> CREATE INDEX Modifications for Initial Release of SAI
> -
>
> Key: CASSANDRA-18615
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18615
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax, Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> After a lengthy discussion on the dev list, the community seems to have
> arrived at the following list of TODOs before we release SAI in 5.0:
> 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}}
> Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v)
> USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING
> ‘cassandra’}} as a more specific/complete way to emulate the current behavior
> of {{CREATE INDEX}}.
> 2.) Allow operators to configure, in the YAML, a.) whether an index
> implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what
> the default implementation will be, if {{USING}} isn’t required.
> 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}}
> usage. (i.e. A default is allowed, and that default will remain ‘cassandra’,
> or the legacy 2i)
> With all this in place, users should be able create SAI indexes w/ the
> simplest possible syntax, no defaults will change, and operators will have
> the ability to change defaults to favor SAI whenever they like.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18560) Incorrect IP used for gossip across DCs with prefer_local=true
[
https://issues.apache.org/jira/browse/CASSANDRA-18560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741206#comment-17741206
]
Brandon Williams commented on CASSANDRA-18560:
--
This isn't really surprising given that the fixvers on CASSANDRA-16718 include
4.1.2, but I will revert it and see about releasing.
> Incorrect IP used for gossip across DCs with prefer_local=true
> --
>
> Key: CASSANDRA-18560
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18560
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: Brad Vernon
>Assignee: Brandon Williams
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> After installing a new node using 4.0.10 we experienced a situation where the
> new node attempted to connect to the private ip of a random number of nodes
> remote DCs which are only accessible via public ip for cross dc
> communications.
> The only impact was new nodes outbound connections, inbound from pre-4.0.10
> were not affected. system.peers_v2 (below) showed that the preferred_ip and
> preferred_port as null, only those in 4.0.10 nodes dc have perferred_ip
> values as expected.
> We believe the issue originated with
> https://issues.apache.org/jira/browse/CASSANDRA-16718
> Details on cluster:
> * All nodes have public IP configured as well as private IP
> * Listen/rpc addressrs are configured for private ip, broadcast is public IP
> * prefer_local=true is enabled for all nodes
> The log that showed the connection failing:
> {code:java}
> INFO [Messaging-EventLoop-3-8] 2023-06-01 00:14:21,565 NoSpamLogger.java:92
> -
> /99.81.:7000->/44.208.:7000-URGENT_MESSAGES-[no-channel]
> failed to connectio.netty.channel.ConnectTimeoutException: connection timed
> out: /10.26.5.11:7000 at
> io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe$2.run(AbstractEpollChannel.java:576){code}
> 99 and 44 instances can only access each other using public ips.
> gossipinfo output from 4.0.10 node
> {code:java}
> /44.208.
> generation:1661113358
> heartbeat:25267691
> LOAD:25267683:1.7882044268E10
> SCHEMA:24692061:e98b918d-499f-3ccc-8dbe-5af31f685bda
> DC:13:us-east-1
> RACK:15:1a
> RELEASE_VERSION:6:4.0.5
> NET_VERSION:2:12
> HOST_ID:3:9a41e668-060d-4cfe-bb1e-013f5116422d
> RPC_READY:1407:true
> INTERNAL_ADDRESS_AND_PORT:9:10.26.5.11:7000
> NATIVE_ADDRESS_AND_PORT:4:44.208.:9042
> STATUS_WITH_PORT:1393:NORMAL,-2262036356854762881
> SSTABLE_VERSIONS:7:big-nb
> TOKENS:1392: {code}
> Peers output from 4.0.10 node:
> {code:java}
>peer | peer_port | data_center | host_id
> | native_address | native_port | preferred_ip | preferred_port |
> rack | release_version | schema_version |
> tokens+---+-+--++-+--++--+-+--+---
> 44.208. | 7000 | us-east-1 |
> 9a41e668-060d-4cfe-bb1e-013f5116422d | 44.208. |9042 |
> null | null | 1a | 4.0.5 |
> e98b918d-499f-3ccc-8dbe-5af31f685bda |{'-2262036356854762881',
> '-4197710115038136897', '-7072386316096662315', '2085255826742630980',
> '249732489387853170', '4976300208126705818', '7187184456885833289',
> '8777189009399731927'} {code}
> To solve temporarily we routed outbound traffic to the private ip to public
> using iptables which resulted in successful outbound connections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18560) Incorrect IP used for gossip across DCs with prefer_local=true
[
https://issues.apache.org/jira/browse/CASSANDRA-18560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741204#comment-17741204
]
Brad Vernon commented on CASSANDRA-18560:
-
We did an upgrade with an existing instance from 4.1.1 to 4.1.2 and the same
exact issue happened with nodes that previously had no issues connecting across
DC using the public IP assigned. Only outbound connections were affected and it
was random across the nodes not being able to use the public IP. Downgrading to
4.1.1 restored normal operations.
This seems like a much larger bug that will definitely impact clusters that
have both local private IPs and public IPs for cross dc access.
Error message for one node which should be using IP 34.248. but
instead is using 10.34.37.10 which is the private IP of the host and only
available in the local VPC.
{code:java}
WARN [Messaging-EventLoop-3-3] 2023-07-07 21:52:27,929 NoSpamLogger.java:108 -
/3.114.:7000->/34.248:7000-URGENT_MESSAGES-[no-channel]
dropping message of type ECHO_RSP whose timeout expired before reaching the
networkINFO [Messaging-EventLoop-3-3] 2023-07-07 21:52:47,391
NoSpamLogger.java:105 -
/3.114.:7000->/34.248.:7000-URGENT_MESSAGES-[no-channel]
failed to connectio.netty.channel.ConnectTimeoutException: connection timed
out: /10.34.37.10:7000 at
io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe$2.run(AbstractEpollChannel.java:576)
at io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98) at
io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:170)
at
io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
at
io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384) at
io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:829) {code}
Nodetool status showing the randomness of the cross-dc nodes picking to use the
private ip.
{code:java}
ubuntu@10.34.51.10(ap-northeast-1-cassandra-node0):~# ntool status
Datacenter: ap-northeast-1
==
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
-- Address Load Tokens Owns (effective) Host ID
Rack
UN 54.238. 4.26 GiB 8 100.0%
4affb962-7bf0-42f7-9956-fdbec1c07e5f 1d
UN 52.196. 3.71 GiB 8 100.0%
6857d4de-c497-440f-a2ff-c4d18907fa39 1c
UN 3.114. 4.28 GiB 8 100.0%
d43d2fb3-27a0-4ecd-9887-741c9fc010da 1a
Datacenter: eu-west-1
=
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
-- Address Load Tokens Owns (effective) Host ID
Rack
UN 54.229. 4.06 GiB 8 100.0%
a8c866d3-bde0-453d-8892-dbe544b7e910 1a
UN 52.18. 4.06 GiB 8 100.0%
4530631d-7e2c-455d-89ff-3ddd3e9c64b7 1b
DN 34.248. 4.06 GiB 8 100.0%
26daf7cf-5f1a-4969-a7be-c58ff36e9176 1c
Datacenter: us-east-1
=
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
-- Address Load Tokens Owns (effective) Host ID
Rack
DN 52.54. 4.06 GiB 8 100.0%
a2edd4b1-d286-441d-a0b1-5d98b88ee2f2 1c
UN 34.203.2 4.08 GiB 8 100.0%
5c64292f-df51-45f3-b3b6-ed325ea669ff 1a
UN 3.229. 4.06 GiB 8 100.0%
53a6d308-25b6-4d87-8581-3cc3fd43c165 1b
Datacenter: us-west-2
=
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
-- Address Load Tokens Owns (effective) Host ID
Rack
DN 44.233. 4.26 GiB 8 100.0%
d53ab9bf-2606-4516-a689-7e19d053d857 2b
UN 54.200. 4.26 GiB 8 100.0%
4ec7c54d-465c-489a-8aed-5ba38264cec8 2a
DN 52.27. 4.26 GiB 8 100.0%
8ae55f1a-bf5a-4ce4-892b-4812773036fa 2c {code}
> Incorrect IP used for gossip across DCs with prefer_local=true
> --
>
> Key: CASSANDRA-18560
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18560
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: Brad Vernon
>Assignee: Brandon Williams
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> After installing a new node using 4.0.10 we experienced a situation where the
> new node attempted to connect to the private ip of a random number of nodes
[jira] [Updated] (CASSANDRA-18639) Add duration to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18639:
-
Reviewers: Brandon Williams, Marcus Eriksson, Stefan Miklosovic (was:
Brandon Williams, Stefan Miklosovic)
> Add duration to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Duration
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741200#comment-17741200 ] Brandon Williams commented on CASSANDRA-15248: -- That is exactly how it works. The other ticket was actually created a week ago and work was done independently of this ticket and committed. Then this one was found and resolved as duplicate, since it had become one. I don't understand what you're bent out of shape about enough to make such false accusations of a good standing member of the community, in the end guava is upgraded, as you wanted. > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch dependabot/npm_and_yarn/site-ui/stylelint-15.10.1 created (now caf43b35)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/site-ui/stylelint-15.10.1 in repository https://gitbox.apache.org/repos/asf/cassandra-website.git at caf43b35 Bump stylelint from 13.6.1 to 15.10.1 in /site-ui No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741198#comment-17741198 ] Abhijit Sarkar commented on CASSANDRA-15248: [~e.dimitrova] You closed an issue that's 4 years old as duplicate to an identical ticket created merely hours ago. That's not how it works. I see what you did here, this looks good on a manager report because you're able to close a very old ticket without doing anything. > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18515) Optimize Initial Concurrency Selection for Range Read Algorithm During SAI Queries
[
https://issues.apache.org/jira/browse/CASSANDRA-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741197#comment-17741197
]
Caleb Rackliffe commented on CASSANDRA-18515:
-
+1
> Optimize Initial Concurrency Selection for Range Read Algorithm During SAI
> Queries
> --
>
> Key: CASSANDRA-18515
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18515
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/2i Index
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The range read algorithm relies on the Index API’s notion of estimated result
> rows to decide how many replicas to contact in parallel during its first
> round of requests. The more results expected from a replica for a token
> range, the fewer replicas the range read will initially try to contact. Like
> SASI, SAI floors that estimate to a huge negative number to make sure it’s
> selected over other indexes, and this floors the concurrency factor to 1. The
> actual formula looks like this:
> {code:java}
> // resultsPerRange, from SAI, is a giant negative number
> concurrencyFactor = Math.max(1, Math.min(ranges.rangeCount(), (int)
> Math.ceil(command.limits().count() / resultsPerRange)));
> {code}
> Although that concurrency factor is updated as actual results stream in, only
> sending a single range request to a single replica in every case for SAI is
> not ideal. For example, assume I have a 3 node cluster and a keyspace at
> RF=1, with 10 rows spread across the 3 nodes, without vnodes. Issuing a query
> that matches all 10 rows with a LIMIT of 10 will make 2 or 3 serial range
> requests from the coordinator, one to each of the 3 nodes.
> This can be fixed by allowing indexes to bypass the initial concurrency
> calculation allowing SAI queries to contact the entire ring in a single round
> of queries, or at worst the minimum number of rounds as bounded by the
> existing statutory maximum ranges per round.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18490) Add checksum validation to all index components on startup, streaming, and SSTable import
[ https://issues.apache.org/jira/browse/CASSANDRA-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741194#comment-17741194 ] Caleb Rackliffe commented on CASSANDRA-18490: - Latest few commits LGTM +1...modulo the question from my first comment above Thanks! > Add checksum validation to all index components on startup, streaming, and > SSTable import > - > > Key: CASSANDRA-18490 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18490 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Fix For: 5.x > > > The SAI code currently does not checksum validate per-column index data files > at any point. It does checksum validate per-sstable components after a full > rebuild and it checksum validates the per-column metadata on opening. > We should checksum validate all index components on startup, full rebuild and > streaming. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18639) Add duration to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18639:
---
Description:
The new additions will output metadata information for:
* Duration
For Time Window Compaction (TWC), the min and max timestamps together with
duration describe the bounds of the time window in the table.
{quote}{{Total partitions: 2430}}
{{Total rows: 8000}}
{{Total column set: 10}}
{{...}}
{{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
{{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
{{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
{quote}
The online docs in sstablemetadata.adoc will need to be updated as well.
was:
The new additions will output metadata information for:
* Partition Key Count
* Duration
Partition key count is the total number of partitions in the sstable..
For Time Window Compaction (TWC), the min and max timestamps together with
duration describe the bounds of the time window in the table.
{quote}{{Total partitions: 2430}}
{{Total rows: 8000}}
{{Total column set: 10}}
{{...}}
{{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
{{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
{{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
{quote}
The online docs in sstablemetadata.adoc will need to be updated as well.
> Add duration to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Duration
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18639) Add duration to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18639:
---
Summary: Add duration to sstablemetadata (was: Add duration and partition
key count to sstablemetadata)
> Add duration to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18582) BulkLoader withCipherSuites option is ignored
[
https://issues.apache.org/jira/browse/CASSANDRA-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741193#comment-17741193
]
Ekaterina Dimitrova commented on CASSANDRA-18582:
-
Thank you for the update, [~djatnieks]. Unfortunately, I did not manage to get
to this one today. I will do my best on Monday.
> BulkLoader withCipherSuites option is ignored
> -
>
> Key: CASSANDRA-18582
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18582
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: dan jatnieks
>Assignee: dan jatnieks
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> The {{withCipherSuites}} option of {{BulkLoader}} is being ignored. It seems
> that since CASSANDRA-16362 the {{BulkLoader.buildSSLOptions}} method no
> longer applies the cipher suite options provided by
> {{clientEncryptionOptions}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (cfcb19c3 -> 36e96091)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard cfcb19c3 generate docs for 466d6ffe new 36e96091 generate docs for 466d6ffe This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (cfcb19c3) \ N -- N -- N refs/heads/asf-staging (36e96091) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../4.2/cassandra/tools/nodetool/bootstrap.html| 9 ++- .../doc/4.2/cassandra/tools/nodetool/nodetool.html | 9 +-- .../4.2/cassandra/tools/nodetool/repair_admin.html | 86 ++--- .../trunk/cassandra/tools/nodetool/bootstrap.html | 9 ++- .../trunk/cassandra/tools/nodetool/nodetool.html | 9 +-- .../cassandra/tools/nodetool/repair_admin.html | 86 ++--- site-ui/build/ui-bundle.zip| Bin 4796900 -> 4796900 bytes 7 files changed, 104 insertions(+), 104 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741192#comment-17741192
]
Marcus Eriksson commented on CASSANDRA-18639:
-
sure, +1
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741191#comment-17741191 ] Ekaterina Dimitrova commented on CASSANDRA-15248: - Guava was updated to the latest version on the current trunk (Cassandra 5.0 to be) in another ticket - CASSANDRA-18645. > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-15248: Resolution: Duplicate Status: Resolved (was: Open) > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741190#comment-17741190
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
https://github.com/apache/cassandra/pull/2472/commits/e10142cd3b3a294d783cb67b880705602f24f24e
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741187#comment-17741187
]
Stefan Miklosovic edited comment on CASSANDRA-18639 at 7/7/23 8:40 PM:
---
Actually, there is a bug, it was there even before this change was introduced,
check this:
{code}
SSTable min local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
SSTable max local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
{code}
The year in 08/17/292278994 is just wrong.
As we are going to fix this, I would just keep the output as introduced in this
ticket and fixed the year.
Deal?
EDIT: are not these numbers just some Long.MAX_VALUE or similar?
was (Author: smiklosovic):
Actually, there is a bug, it was there even before this change was introduced,
check this:
{code}
SSTable min local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
SSTable max local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
{code}
The year in 08/17/292278994 is just wrong.
As we are going to fix this, I would just keep the output as introduced in this
ticket and fixed the year.
Deal?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741187#comment-17741187
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Actually, there is a bug, it was there even before this change was introduced,
check this:
{code}
SSTable min local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
SSTable max local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
{code}
The year in 08/17/292278994 is just wrong.
As we are going to fix this, I would just keep the output as introduced in this
ticket and fixed the year.
Deal?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18653) Avoid unnecessary index builds and validations
[ https://issues.apache.org/jira/browse/CASSANDRA-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741183#comment-17741183 ] Caleb Rackliffe commented on CASSANDRA-18653: - [~mike_tr_adamson] Just for visibility, I'm probably also about to create another Jira loosely related to CASSANDRA-10130 and index building failures after SSTable streaming. (i.e. It may impact how and where we start index builds.) I'll link it here when it's ready... > Avoid unnecessary index builds and validations > -- > > Key: CASSANDRA-18653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18653 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > > In the testing of CASSANDRA-18490 it was noted that the > SSTableAddedNotification will trigger an index build that will always build > the column index components even if they already exist and are valid. > The same notification is also handled by the StorageAttachedIndexGroup that > can validate the components. This can lead to the components being validated > more than is necessary. > We should coordinate these notification handlers so there is no overlap of > responsibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741182#comment-17741182
]
Marcus Eriksson commented on CASSANDRA-18639:
-
If we're changing the output back I think we should also revert the changes to
the other fields and just add the duration
We could probably motivate those changes though, since they are more clearly
improvements.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741177#comment-17741177
]
Brandon Williams commented on CASSANDRA-18639:
--
LGTM, I am +1 but let's wait for Marcus since he caught this problem for us.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741176#comment-17741176
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Based on this thread (1), how I got it is that we will not change the default
output unless there is JSON / YAML equivalent. Once there is, we can do
whatever we please with it.
I am fine with this compromise so I am +1 on that. The ninja is here
[https://github.com/apache/cassandra/pull/2472/files]
[~marcuse] do you want to take a look?
(1) [https://lists.apache.org/thread/72j5qfgbttjcmylhcmfq1ptboh641ns0]
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18653) Avoid unnecessary index builds and validations
[ https://issues.apache.org/jira/browse/CASSANDRA-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741174#comment-17741174 ] Caleb Rackliffe commented on CASSANDRA-18653: - The original thread that started this: https://github.com/apache/cassandra/pull/2460#discussion_r1253762041 > Avoid unnecessary index builds and validations > -- > > Key: CASSANDRA-18653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18653 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > > In the testing of CASSANDRA-18490 it was noted that the > SSTableAddedNotification will trigger an index build that will always build > the column index components even if they already exist and are valid. > The same notification is also handled by the StorageAttachedIndexGroup that > can validate the components. This can lead to the components being validated > more than is necessary. > We should coordinate these notification handlers so there is no overlap of > responsibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18653) Avoid unnecessary index builds and validations
[ https://issues.apache.org/jira/browse/CASSANDRA-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18653: Reviewers: Caleb Rackliffe > Avoid unnecessary index builds and validations > -- > > Key: CASSANDRA-18653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18653 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > > In the testing of CASSANDRA-18490 it was noted that the > SSTableAddedNotification will trigger an index build that will always build > the column index components even if they already exist and are valid. > The same notification is also handled by the StorageAttachedIndexGroup that > can validate the components. This can lead to the components being validated > more than is necessary. > We should coordinate these notification handlers so there is no overlap of > responsibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18133: --- Status: Review In Progress (was: Patch Available) > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Bring the artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > -The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel.- > EDIT: this bit has been moved to CASSANDRA-18594 > This addresses the epic's stated existing problems: > - difficult to pre-commit test jenkins and cassandra-build changes, > - CI development efforts is split between ci-cassandra and circleci, despite > ci-cassandra being our canonical and non-commercial CI, > - lacking parity of what is tested between ci-cassandra and circleci > - cassandra-builds as a separate repo (without release branches matching > in-tree) adds complexity to changing matrix values (jdks, pythons, dist) > - -mixture of jenkins dsl groovy, declarative and scripting pipeline.- > - -different pre-commit and post-commit jenkins pipelines are used.- > In addition it addresses: > - -stage jobs don't always running on the same SHA as the pipeline's run,- > - infra issues around networking, specifically git cloning additional > cassandra-builds repository, > - -a more readable Jenkinsfile- > - more UX friendly build and test scripts -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741018#comment-17741018 ] Michael Semb Wever edited comment on CASSANDRA-18133 at 7/7/23 7:23 PM: Fixes for artifacts, cqlshlib tests, and jvm-dtests pushed. CI - https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2536/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch-cqlsh-tests/2175/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest/1803/ - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/165/workflows/d9a54439-f392-4ac9-a9ab-ee9b17abaa38 This is a prerequisite for the in-tree patch (to get jenkins cqlshlib tests working): https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk was (Author: michaelsembwever): Fixes for artifacts and cqlshlib tests pushed. CI - https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2536/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch-cqlsh-tests/2175/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest/1803/ - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/165/workflows/d9a54439-f392-4ac9-a9ab-ee9b17abaa38 This is a prerequisite for the in-tree patch (to get jenkins cqlshlib tests working): https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Bring the artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > -The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel.- > EDIT: this bit has been moved to CASSANDRA-18594 > This addresses the epic's stated existing problems: > - difficult to pre-commit test jenkins and cassandra-build changes, > - CI development efforts is split between ci-cassandra and circleci, despite > ci-cassandra being our canonical and non-commercial CI, > - lacking parity of what is tested between ci-cassandra and circleci > - cassandra-builds as a separate repo (without release branches matching > in-tree) adds complexity to changing matrix values (jdks, pythons, dist) > - -mixture of jenkins dsl groovy, declarative and scripting pipeline.- > - -different pre-commit and post-commit jenkins pipelines are used.- > In addition it addresses: > - -stage jobs don't always running on the same SHA as the pipeline's run,- > - infra issues around networking, specifically git cloning additional > cassandra-builds repository, > - -a more readable Jenkinsfile- > - more UX friendly build and test scripts -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741018#comment-17741018 ] Michael Semb Wever edited comment on CASSANDRA-18133 at 7/7/23 7:23 PM: Fixes for artifacts and cqlshlib tests pushed. CI - https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2536/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch-cqlsh-tests/2175/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest/1803/ - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/165/workflows/d9a54439-f392-4ac9-a9ab-ee9b17abaa38 This is a prerequisite for the in-tree patch (to get jenkins cqlshlib tests working): https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk was (Author: michaelsembwever): Fixes for artifacts and cqlshlib tests pushed. This is a prerequisite for the in-tree patch (to get jenkins cqlshlib tests working): https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Bring the artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > -The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel.- > EDIT: this bit has been moved to CASSANDRA-18594 > This addresses the epic's stated existing problems: > - difficult to pre-commit test jenkins and cassandra-build changes, > - CI development efforts is split between ci-cassandra and circleci, despite > ci-cassandra being our canonical and non-commercial CI, > - lacking parity of what is tested between ci-cassandra and circleci > - cassandra-builds as a separate repo (without release branches matching > in-tree) adds complexity to changing matrix values (jdks, pythons, dist) > - -mixture of jenkins dsl groovy, declarative and scripting pipeline.- > - -different pre-commit and post-commit jenkins pipelines are used.- > In addition it addresses: > - -stage jobs don't always running on the same SHA as the pipeline's run,- > - infra issues around networking, specifically git cloning additional > cassandra-builds repository, > - -a more readable Jenkinsfile- > - more UX friendly build and test scripts -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18133: --- Reviewers: Brandon Williams, Josh McKenzie, Maxim Muzafarov, Stefan Miklosovic (was: Brandon Williams) > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Bring the artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > -The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel.- > EDIT: this bit has been moved to CASSANDRA-18594 > This addresses the epic's stated existing problems: > - difficult to pre-commit test jenkins and cassandra-build changes, > - CI development efforts is split between ci-cassandra and circleci, despite > ci-cassandra being our canonical and non-commercial CI, > - lacking parity of what is tested between ci-cassandra and circleci > - cassandra-builds as a separate repo (without release branches matching > in-tree) adds complexity to changing matrix values (jdks, pythons, dist) > - -mixture of jenkins dsl groovy, declarative and scripting pipeline.- > - -different pre-commit and post-commit jenkins pipelines are used.- > In addition it addresses: > - -stage jobs don't always running on the same SHA as the pipeline's run,- > - infra issues around networking, specifically git cloning additional > cassandra-builds repository, > - -a more readable Jenkinsfile- > - more UX friendly build and test scripts -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741157#comment-17741157
]
Stefan Miklosovic edited comment on CASSANDRA-18639 at 7/7/23 6:32 PM:
---
-1 on changing it back. We need to resolve this once for all on ML.
I still don't see a valid argument why we could not break it between majors if
we can do that with "normal" stuff.
was (Author: smiklosovic):
-1 on changing it back. We need to resolve this once for all on ML.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741157#comment-17741157
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
-1 on changing it back. We need to resolve this once for all on ML.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741155#comment-17741155
]
Marcus Eriksson commented on CASSANDRA-18639:
-
bq. make a new ticket to add serialization and change the output back
+1
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[
https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741143#comment-17741143
]
Brandon Williams commented on CASSANDRA-17914:
--
If you are naming the branch with a slash, that's going to be problematic (and
why my example used dashes.)
bq. Sorry, I don't have slack!
Sent you an invite if you want it!
> Argparse migration as the Python Optparse library is deprecated
> ---
>
> Key: CASSANDRA-17914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17914
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Vineet Gali
>Priority: Normal
>
> [Deprecated since version 2.7: The optparse module is deprecated and will not
> be developed further; development will continue with the argparse
> module.|https://docs.python.org/2/library/optparse.html]
> Argparse is described in [PEP 389 – argparse - New Command Line Parsing
> Module|https://peps.python.org/pep-0389/]
>
> A partial upgrade path from
> [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse]
> to
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]:
> https://docs.python.org/3/library/argparse.html#upgrading-optparse-code
> * Replace all
> [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option]
> calls with
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls.
> * Replace {{(options, args) = parser.parse_args()}} with {{args =
> parser.parse_args()}} and add additional
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls for the positional arguments. Keep in mind that what was previously
> called {{{}options{}}}, now in the
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]
> context is called {{{}args{}}}.
> * Replace
> [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args]
> by using
> [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args]
> instead of
> [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args].
> * Replace callback actions and the {{callback_*}} keyword arguments with
> {{type}} or {{action}} arguments.
> * Replace string names for {{type}} keyword arguments with the corresponding
> type objects (e.g. int, float, complex, etc).
> * Replace {{optparse.Values}} with
> [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace]
> and {{optparse.OptionError}} and {{optparse.OptionValueError}} with
> {{{}ArgumentError{}}}.
> * Replace strings with implicit arguments such as {{%default}} or {{%prog}}
> with the standard Python syntax to use dictionaries to format strings, that
> is, {{%(default)s}} and {{{}%(prog)s{}}}.
> * Replace the OptionParser constructor {{version}} argument with a call to
> {{{}parser.add_argument('--version', action='version', version=' version>'){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[
https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741142#comment-17741142
]
Vineet Gali commented on CASSANDRA-17914:
-
[~brandon.williams] I tried that and it gave me this error,
fatal: The current branch cassandra-17914/cassandra-4.1 has no upstream branch.
I'm hesitant to set the upstream as the origin/cassandra-4.1 branch just
because I'm not 100% sure that's the right thing to do.
Sorry, I don't have slack!
> Argparse migration as the Python Optparse library is deprecated
> ---
>
> Key: CASSANDRA-17914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17914
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Vineet Gali
>Priority: Normal
>
> [Deprecated since version 2.7: The optparse module is deprecated and will not
> be developed further; development will continue with the argparse
> module.|https://docs.python.org/2/library/optparse.html]
> Argparse is described in [PEP 389 – argparse - New Command Line Parsing
> Module|https://peps.python.org/pep-0389/]
>
> A partial upgrade path from
> [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse]
> to
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]:
> https://docs.python.org/3/library/argparse.html#upgrading-optparse-code
> * Replace all
> [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option]
> calls with
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls.
> * Replace {{(options, args) = parser.parse_args()}} with {{args =
> parser.parse_args()}} and add additional
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls for the positional arguments. Keep in mind that what was previously
> called {{{}options{}}}, now in the
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]
> context is called {{{}args{}}}.
> * Replace
> [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args]
> by using
> [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args]
> instead of
> [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args].
> * Replace callback actions and the {{callback_*}} keyword arguments with
> {{type}} or {{action}} arguments.
> * Replace string names for {{type}} keyword arguments with the corresponding
> type objects (e.g. int, float, complex, etc).
> * Replace {{optparse.Values}} with
> [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace]
> and {{optparse.OptionError}} and {{optparse.OptionValueError}} with
> {{{}ArgumentError{}}}.
> * Replace strings with implicit arguments such as {{%default}} or {{%prog}}
> with the standard Python syntax to use dictionaries to format strings, that
> is, {{%(default)s}} and {{{}%(prog)s{}}}.
> * Replace the OptionParser constructor {{version}} argument with a call to
> {{{}parser.add_argument('--version', action='version', version=' version>'){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[
https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741138#comment-17741138
]
Brandon Williams edited comment on CASSANDRA-17914 at 7/7/23 5:08 PM:
--
[~vgali7] typically what I do is checkout the branch I intend to patch (let's
say 4.0) and then branch that into something named after the ticket and branch
(CASSANDRA-17914-4.0) and push/pr that with my changes.
If you need further help, ping me on slack! (driftx)
was (Author: brandon.williams):
[~vgali7] typically what I do is checkout the branch I intend to patch (let's
say 4.0) and then branch that into something named after the ticket and branch
(CASSANDRA-17914-4.0) and push/pr that with my changes.
If you need further help, ping me on slack!
> Argparse migration as the Python Optparse library is deprecated
> ---
>
> Key: CASSANDRA-17914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17914
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Vineet Gali
>Priority: Normal
>
> [Deprecated since version 2.7: The optparse module is deprecated and will not
> be developed further; development will continue with the argparse
> module.|https://docs.python.org/2/library/optparse.html]
> Argparse is described in [PEP 389 – argparse - New Command Line Parsing
> Module|https://peps.python.org/pep-0389/]
>
> A partial upgrade path from
> [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse]
> to
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]:
> https://docs.python.org/3/library/argparse.html#upgrading-optparse-code
> * Replace all
> [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option]
> calls with
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls.
> * Replace {{(options, args) = parser.parse_args()}} with {{args =
> parser.parse_args()}} and add additional
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls for the positional arguments. Keep in mind that what was previously
> called {{{}options{}}}, now in the
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]
> context is called {{{}args{}}}.
> * Replace
> [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args]
> by using
> [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args]
> instead of
> [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args].
> * Replace callback actions and the {{callback_*}} keyword arguments with
> {{type}} or {{action}} arguments.
> * Replace string names for {{type}} keyword arguments with the corresponding
> type objects (e.g. int, float, complex, etc).
> * Replace {{optparse.Values}} with
> [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace]
> and {{optparse.OptionError}} and {{optparse.OptionValueError}} with
> {{{}ArgumentError{}}}.
> * Replace strings with implicit arguments such as {{%default}} or {{%prog}}
> with the standard Python syntax to use dictionaries to format strings, that
> is, {{%(default)s}} and {{{}%(prog)s{}}}.
> * Replace the OptionParser constructor {{version}} argument with a call to
> {{{}parser.add_argument('--version', action='version', version=' version>'){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[
https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741138#comment-17741138
]
Brandon Williams edited comment on CASSANDRA-17914 at 7/7/23 5:08 PM:
--
[~vgali7] typically what I do is checkout the branch I intend to patch (let's
say 4.0) and then branch that into something named after the ticket and branch
(CASSANDRA-17914-4.0) and push/pr that with my changes.
If you need further help, ping me on slack!
was (Author: brandon.williams):
[~vgali7] typically what I do is checkout the branch I intend to patch (let's
say 4.0) and then branch that into something named after the ticket and branch
(CASSANDRA-17914-4.0) and push/pr that with my changes.
> Argparse migration as the Python Optparse library is deprecated
> ---
>
> Key: CASSANDRA-17914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17914
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Vineet Gali
>Priority: Normal
>
> [Deprecated since version 2.7: The optparse module is deprecated and will not
> be developed further; development will continue with the argparse
> module.|https://docs.python.org/2/library/optparse.html]
> Argparse is described in [PEP 389 – argparse - New Command Line Parsing
> Module|https://peps.python.org/pep-0389/]
>
> A partial upgrade path from
> [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse]
> to
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]:
> https://docs.python.org/3/library/argparse.html#upgrading-optparse-code
> * Replace all
> [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option]
> calls with
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls.
> * Replace {{(options, args) = parser.parse_args()}} with {{args =
> parser.parse_args()}} and add additional
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls for the positional arguments. Keep in mind that what was previously
> called {{{}options{}}}, now in the
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]
> context is called {{{}args{}}}.
> * Replace
> [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args]
> by using
> [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args]
> instead of
> [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args].
> * Replace callback actions and the {{callback_*}} keyword arguments with
> {{type}} or {{action}} arguments.
> * Replace string names for {{type}} keyword arguments with the corresponding
> type objects (e.g. int, float, complex, etc).
> * Replace {{optparse.Values}} with
> [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace]
> and {{optparse.OptionError}} and {{optparse.OptionValueError}} with
> {{{}ArgumentError{}}}.
> * Replace strings with implicit arguments such as {{%default}} or {{%prog}}
> with the standard Python syntax to use dictionaries to format strings, that
> is, {{%(default)s}} and {{{}%(prog)s{}}}.
> * Replace the OptionParser constructor {{version}} argument with a call to
> {{{}parser.add_argument('--version', action='version', version=' version>'){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[
https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741138#comment-17741138
]
Brandon Williams commented on CASSANDRA-17914:
--
[~vgali7] typically what I do is checkout the branch I intend to patch (let's
say 4.0) and then branch that into something named after the ticket and branch
(CASSANDRA-17914-4.0) and push/pr that with my changes.
> Argparse migration as the Python Optparse library is deprecated
> ---
>
> Key: CASSANDRA-17914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17914
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Vineet Gali
>Priority: Normal
>
> [Deprecated since version 2.7: The optparse module is deprecated and will not
> be developed further; development will continue with the argparse
> module.|https://docs.python.org/2/library/optparse.html]
> Argparse is described in [PEP 389 – argparse - New Command Line Parsing
> Module|https://peps.python.org/pep-0389/]
>
> A partial upgrade path from
> [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse]
> to
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]:
> https://docs.python.org/3/library/argparse.html#upgrading-optparse-code
> * Replace all
> [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option]
> calls with
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls.
> * Replace {{(options, args) = parser.parse_args()}} with {{args =
> parser.parse_args()}} and add additional
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls for the positional arguments. Keep in mind that what was previously
> called {{{}options{}}}, now in the
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]
> context is called {{{}args{}}}.
> * Replace
> [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args]
> by using
> [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args]
> instead of
> [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args].
> * Replace callback actions and the {{callback_*}} keyword arguments with
> {{type}} or {{action}} arguments.
> * Replace string names for {{type}} keyword arguments with the corresponding
> type objects (e.g. int, float, complex, etc).
> * Replace {{optparse.Values}} with
> [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace]
> and {{optparse.OptionError}} and {{optparse.OptionValueError}} with
> {{{}ArgumentError{}}}.
> * Replace strings with implicit arguments such as {{%default}} or {{%prog}}
> with the standard Python syntax to use dictionaries to format strings, that
> is, {{%(default)s}} and {{{}%(prog)s{}}}.
> * Replace the OptionParser constructor {{version}} argument with a call to
> {{{}parser.add_argument('--version', action='version', version=' version>'){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18652) Improve vector value validation errors
[
https://issues.apache.org/jira/browse/CASSANDRA-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741137#comment-17741137
]
Andres de la Peña commented on CASSANDRA-18652:
---
Thanks for the review :)
I usually add the {{CHANGES.txt}} entry on commit to ease rebase and not show
trivial merge conflicts on the PR. Re-running
{{{}j11_cqlshlib_cython_tests{}}}:
[https://app.circleci.com/pipelines/github/adelapena/cassandra/3007/workflows/64c75a2d-ee19-436a-bc9f-7b930d2d32fe]
> Improve vector value validation errors
> --
>
> Key: CASSANDRA-18652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18652
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some of the error messages shown when trying to bind a vector column with a
> wrong value are a bit obscure. For example, if we try to write a value with
> the wrong number of dimensions:
> {code}
> createTable("CREATE TABLE %s (pk int primary key, value vector)");
> execute("INSERT INTO %s (pk, value) VALUES (0, ?)", vector(1));
> {code}
> The error is:
> {code}
> java.lang.IndexOutOfBoundsException: Attempted to read 4, but the size is 0
> {code}
> I understand that we cannot provide a lot of information about a
> non-understandable bind value, since we don't even know whether it's a vector
> or something entirely different. But we could try to improve it a bit and
> throw a {{MarshalException}} that will be translated to a
> {{InvalidRequestException}}, and provide generic messages similar to those
> used by collections:
> {code}
> InvalidRequestException: Not enough bytes to read a vector
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[
https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741136#comment-17741136
]
Vineet Gali commented on CASSANDRA-17914:
-
[~smiklosovic] I've created the files for 4.0.x and 4.1.x but I'm as to how to
properly branch from my cloned repo to submit the PR's. Is there any
documentation I can follow?
> Argparse migration as the Python Optparse library is deprecated
> ---
>
> Key: CASSANDRA-17914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17914
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Vineet Gali
>Priority: Normal
>
> [Deprecated since version 2.7: The optparse module is deprecated and will not
> be developed further; development will continue with the argparse
> module.|https://docs.python.org/2/library/optparse.html]
> Argparse is described in [PEP 389 – argparse - New Command Line Parsing
> Module|https://peps.python.org/pep-0389/]
>
> A partial upgrade path from
> [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse]
> to
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]:
> https://docs.python.org/3/library/argparse.html#upgrading-optparse-code
> * Replace all
> [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option]
> calls with
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls.
> * Replace {{(options, args) = parser.parse_args()}} with {{args =
> parser.parse_args()}} and add additional
> [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument]
> calls for the positional arguments. Keep in mind that what was previously
> called {{{}options{}}}, now in the
> [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]
> context is called {{{}args{}}}.
> * Replace
> [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args]
> by using
> [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args]
> instead of
> [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args].
> * Replace callback actions and the {{callback_*}} keyword arguments with
> {{type}} or {{action}} arguments.
> * Replace string names for {{type}} keyword arguments with the corresponding
> type objects (e.g. int, float, complex, etc).
> * Replace {{optparse.Values}} with
> [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace]
> and {{optparse.OptionError}} and {{optparse.OptionValueError}} with
> {{{}ArgumentError{}}}.
> * Replace strings with implicit arguments such as {{%default}} or {{%prog}}
> with the standard Python syntax to use dictionaries to format strings, that
> is, {{%(default)s}} and {{{}%(prog)s{}}}.
> * Replace the OptionParser constructor {{version}} argument with a call to
> {{{}parser.add_argument('--version', action='version', version=' version>'){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18652) Improve vector value validation errors
[
https://issues.apache.org/jira/browse/CASSANDRA-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741124#comment-17741124
]
Ekaterina Dimitrova commented on CASSANDRA-18652:
-
Please remember the CHANGES.txt entry on commit.
cqlshlib tests failed with J8 in your last run. Can you rerun that job, please?
Just in case...
+1 on green cqlshlib tests.
> Improve vector value validation errors
> --
>
> Key: CASSANDRA-18652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18652
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some of the error messages shown when trying to bind a vector column with a
> wrong value are a bit obscure. For example, if we try to write a value with
> the wrong number of dimensions:
> {code}
> createTable("CREATE TABLE %s (pk int primary key, value vector)");
> execute("INSERT INTO %s (pk, value) VALUES (0, ?)", vector(1));
> {code}
> The error is:
> {code}
> java.lang.IndexOutOfBoundsException: Attempted to read 4, but the size is 0
> {code}
> I understand that we cannot provide a lot of information about a
> non-understandable bind value, since we don't even know whether it's a vector
> or something entirely different. But we could try to improve it a bit and
> throw a {{MarshalException}} that will be translated to a
> {{InvalidRequestException}}, and provide generic messages similar to those
> used by collections:
> {code}
> InvalidRequestException: Not enough bytes to read a vector
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18652) Improve vector value validation errors
[
https://issues.apache.org/jira/browse/CASSANDRA-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741124#comment-17741124
]
Ekaterina Dimitrova edited comment on CASSANDRA-18652 at 7/7/23 4:23 PM:
-
[~adelapena], please remember the CHANGES.txt entry on commit.
cqlshlib tests failed with J8 in your last run. Can you rerun that job, please?
Just in case...
+1 on green cqlshlib tests.
was (Author: e.dimitrova):
Please remember the CHANGES.txt entry on commit.
cqlshlib tests failed with J8 in your last run. Can you rerun that job, please?
Just in case...
+1 on green cqlshlib tests.
> Improve vector value validation errors
> --
>
> Key: CASSANDRA-18652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18652
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some of the error messages shown when trying to bind a vector column with a
> wrong value are a bit obscure. For example, if we try to write a value with
> the wrong number of dimensions:
> {code}
> createTable("CREATE TABLE %s (pk int primary key, value vector)");
> execute("INSERT INTO %s (pk, value) VALUES (0, ?)", vector(1));
> {code}
> The error is:
> {code}
> java.lang.IndexOutOfBoundsException: Attempted to read 4, but the size is 0
> {code}
> I understand that we cannot provide a lot of information about a
> non-understandable bind value, since we don't even know whether it's a vector
> or something entirely different. But we could try to improve it a bit and
> throw a {{MarshalException}} that will be translated to a
> {{InvalidRequestException}}, and provide generic messages similar to those
> used by collections:
> {code}
> InvalidRequestException: Not enough bytes to read a vector
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18650) Upgrade owasp to 8.3.1
[ https://issues.apache.org/jira/browse/CASSANDRA-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18650: - Reviewers: Ekaterina Dimitrova (was: Brandon Williams, Ekaterina Dimitrova) > Upgrade owasp to 8.3.1 > -- > > Key: CASSANDRA-18650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18650 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.11, 4.1.3, 5.0 > > > I believe I'm fighting with an issue this upgrade solves, but also I cannot > think of any reason to not run the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18650) Upgrade owasp to 8.3.1
[ https://issues.apache.org/jira/browse/CASSANDRA-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18650: - Reviewers: Ekaterina Dimitrova, Brandon Williams Ekaterina Dimitrova, Brandon Williams (was: Brandon Williams, Ekaterina Dimitrova) Status: Review In Progress (was: Patch Available) > Upgrade owasp to 8.3.1 > -- > > Key: CASSANDRA-18650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18650 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > I believe I'm fighting with an issue this upgrade solves, but also I cannot > think of any reason to not run the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18650) Upgrade owasp to 8.3.1
[ https://issues.apache.org/jira/browse/CASSANDRA-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741117#comment-17741117 ] Brandon Williams commented on CASSANDRA-18650: -- Committed, thanks! > Upgrade owasp to 8.3.1 > -- > > Key: CASSANDRA-18650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18650 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.11, 4.1.3, 5.0 > > > I believe I'm fighting with an issue this upgrade solves, but also I cannot > think of any reason to not run the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18650) Upgrade owasp to 8.3.1
[ https://issues.apache.org/jira/browse/CASSANDRA-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18650: - Fix Version/s: 3.0.30 3.11.16 4.0.11 4.1.3 5.0 (was: 3.0.x) (was: 3.11.x) (was: 5.x) (was: 4.0.x) (was: 4.1.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra/commit/493d15fffa21e57fcaef7cfb2099cbaa3ab6bb47 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Upgrade owasp to 8.3.1 > -- > > Key: CASSANDRA-18650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18650 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.11, 4.1.3, 5.0 > > > I believe I'm fighting with an issue this upgrade solves, but also I cannot > think of any reason to not run the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18650) Upgrade owasp to 8.3.1
[ https://issues.apache.org/jira/browse/CASSANDRA-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18650: - Status: Ready to Commit (was: Review In Progress) > Upgrade owasp to 8.3.1 > -- > > Key: CASSANDRA-18650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18650 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > I believe I'm fighting with an issue this upgrade solves, but also I cannot > think of any reason to not run the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18650) Upgrade owasp to 8.3.1
[ https://issues.apache.org/jira/browse/CASSANDRA-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18650: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > Upgrade owasp to 8.3.1 > -- > > Key: CASSANDRA-18650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18650 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > I believe I'm fighting with an issue this upgrade solves, but also I cannot > think of any reason to not run the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit c5ebc2243c0f67293e3cd9cb8735ed33d017fc19 Merge: 992ad25b96 2b2732450c Author: Brandon Williams AuthorDate: Fri Jul 7 10:48:25 2023 -0500 Merge branch 'cassandra-4.1' into trunk .build/build-owasp.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (992ad25b96 -> c5ebc2243c)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 992ad25b96 Update Guava to 32.0.1-jre new 493d15fffa Upgrade to OWASP 8.3.1 new 3f09baf1c2 Merge branch 'cassandra-3.0' into cassandra-3.11 new 309e9b1295 Merge branch 'cassandra-3.11' into cassandra-4.0 new 2b2732450c Merge branch 'cassandra-4.0' into cassandra-4.1 new c5ebc2243c Merge branch 'cassandra-4.1' into trunk The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-owasp.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 2b2732450c9c2831db7eb745ce2dad42e63b8398 Merge: 78ad91313f 309e9b1295 Author: Brandon Williams AuthorDate: Fri Jul 7 10:48:05 2023 -0500 Merge branch 'cassandra-4.0' into cassandra-4.1 .build/build-owasp.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (78ad91313f -> 2b2732450c)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 78ad91313f Merge branch 'cassandra-4.0' into cassandra-4.1 new 493d15fffa Upgrade to OWASP 8.3.1 new 3f09baf1c2 Merge branch 'cassandra-3.0' into cassandra-3.11 new 309e9b1295 Merge branch 'cassandra-3.11' into cassandra-4.0 new 2b2732450c Merge branch 'cassandra-4.0' into cassandra-4.1 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-owasp.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (5326a39a1c -> 3f09baf1c2)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 5326a39a1c Merge branch 'cassandra-3.0' into cassandra-3.11 new 493d15fffa Upgrade to OWASP 8.3.1 new 3f09baf1c2 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-owasp.xml | 2 +- .build/dependency-check-suppressions.xml | 10 ++ CHANGES.txt | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 309e9b1295dd0ef2ff436fc41055e1f5a8e618a1 Merge: c10c7375c1 3f09baf1c2 Author: Brandon Williams AuthorDate: Fri Jul 7 10:45:19 2023 -0500 Merge branch 'cassandra-3.11' into cassandra-4.0 .build/build-owasp.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 3f09baf1c2e833cc3028be08ab753f6c48788210 Merge: 5326a39a1c 493d15fffa Author: Brandon Williams AuthorDate: Fri Jul 7 10:41:42 2023 -0500 Merge branch 'cassandra-3.0' into cassandra-3.11 .build/build-owasp.xml | 2 +- .build/dependency-check-suppressions.xml | 10 ++ CHANGES.txt | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --cc .build/dependency-check-suppressions.xml index bffab75a23,dead8f6120..58b38b7e62 --- a/.build/dependency-check-suppressions.xml +++ b/.build/dependency-check-suppressions.xml @@@ -117,19 -116,38 +117,29 @@@ CVE-2018-11798 CVE-2019-0205 + + ^pkg:maven/com\.thinkaurelius\.thrift/thrift-server@.*$ + CVE-2015-3254 + CVE-2016-5397 + CVE-2018-1320 + CVE-2018-11798 + CVE-2019-0205 + - - - -^pkg:maven/org\.codehaus\.jackson/jackson\-mapper\-asl@.*$ -CVE-2017-7525 -CVE-2017-15095 -CVE-2017-17485 -CVE-2018-5968 -CVE-2018-14718 -CVE-2018-1000873 -CVE-2018-7489 -CVE-2019-10172 -CVE-2019-14540 -CVE-2019-14893 -CVE-2019-16335 -CVE-2019-17267 - - + ^pkg:maven/com\.fasterxml\.jackson\.core/jackson\-databind@.*$ +CVE-2022-42003 +CVE-2022-42004 CVE-2023-35116 + CVE-2022-42003 + CVE-2022-42004 + + +^pkg:maven/com\.fasterxml\.jackson\.core/jackson\-core@.*$ +CVE-2022-45688 + + diff --cc CHANGES.txt index 2c8a444f55,fbe5e0751b..33e4983986 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,11 -1,5 +1,12 @@@ -3.0.30 +3.11.16 + * Suppress CVE-2022-45688 (CASSANDRA-18643) + * Remove unrepaired SSTables from garbage collection when only_purge_repaired_tombstones is true (CASSANDRA-14204) + * Wait for live endpoints in gossip waiting to settle (CASSANDRA-18543) + * Fix error message handling when trying to use CLUSTERING ORDER with non-clustering column (CASSANDRA-17818 + * Add keyspace and table name to exception message during ColumnSubselection deserialization (CASSANDRA-18346) + * Remove unnecessary String.format invocation in QueryProcessor when getting a prepared statement from cache (CASSANDRA-17202) +Merged from 3.0: + * Upgrade OWASP to 8.3.1 (CASSANDRA-18650) * Suppress CVE-2023-34462 (CASSANDRA-18649) * Add support for AWS Ec2 IMDSv2 (CASSANDRA-16555) * Suppress CVE-2023-35116 (CASSANDRA-18630) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Upgrade to OWASP 8.3.1
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-3.0 by this push: new 493d15fffa Upgrade to OWASP 8.3.1 493d15fffa is described below commit 493d15fffa21e57fcaef7cfb2099cbaa3ab6bb47 Author: Brandon Williams AuthorDate: Thu Jul 6 15:50:26 2023 -0500 Upgrade to OWASP 8.3.1 Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-18650 --- .build/build-owasp.xml | 2 +- .build/dependency-check-suppressions.xml | 10 ++ CHANGES.txt | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.build/build-owasp.xml b/.build/build-owasp.xml index f3174999e8..a792730fb9 100644 --- a/.build/build-owasp.xml +++ b/.build/build-owasp.xml @@ -17,7 +17,7 @@ ~ limitations under the License. --> - + diff --git a/.build/dependency-check-suppressions.xml b/.build/dependency-check-suppressions.xml index 96500422d4..dead8f6120 100644 --- a/.build/dependency-check-suppressions.xml +++ b/.build/dependency-check-suppressions.xml @@ -116,6 +116,14 @@ CVE-2018-11798 CVE-2019-0205 + +^pkg:maven/com\.thinkaurelius\.thrift/thrift-server@.*$ +CVE-2015-3254 +CVE-2016-5397 +CVE-2018-1320 +CVE-2018-11798 +CVE-2019-0205 + @@ -138,6 +146,8 @@ ^pkg:maven/com\.fasterxml\.jackson\.core/jackson\-databind@.*$ CVE-2023-35116 + CVE-2022-42003 + CVE-2022-42004 diff --git a/CHANGES.txt b/CHANGES.txt index cc2eea7a38..fbe5e0751b 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0.30 + * Upgrade OWASP to 8.3.1 (CASSANDRA-18650) * Suppress CVE-2023-34462 (CASSANDRA-18649) * Add support for AWS Ec2 IMDSv2 (CASSANDRA-16555) * Suppress CVE-2023-35116 (CASSANDRA-18630) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (c10c7375c1 -> 309e9b1295)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from c10c7375c1 Merge branch 'cassandra-3.11' into cassandra-4.0 new 493d15fffa Upgrade to OWASP 8.3.1 new 3f09baf1c2 Merge branch 'cassandra-3.0' into cassandra-3.11 new 309e9b1295 Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-owasp.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18613) Add support for vectors on UDFs
[
https://issues.apache.org/jira/browse/CASSANDRA-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741082#comment-17741082
]
Andres de la Peña commented on CASSANDRA-18613:
---
New CI round after rebasing and fixing some issues with
{{getVector}}/{{setVector}}:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/2436]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/3010/workflows/cfcbe3c8-ec11-46db-96cd-a0b5ef9f6493]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3010/workflows/92552f2b-25b0-4406-8744-bd3147306223]|
> Add support for vectors on UDFs
> ---
>
> Key: CASSANDRA-18613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18613
> Project: Cassandra
> Issue Type: New Feature
> Components: Cluster/Schema
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> CASSANDRA-18504 will add a new vector type, but [it won't be supported on
> UDFs|https://github.com/apache/cassandra/blob/5027e688da006e5d5bf9bfdf4719caddbf85986a/test/unit/org/apache/cassandra/cql3/validation/operations/CQLVectorTest.java#L248-L271].
> The goal of this ticket is to add that support.
> This will require adding a new {{o.a.c.cql3.functions.types.TypeCodec}} for
> vectors. Those codecs are mostly duplicates of the codecs on the Java driver.
> They are used for UDFs instead of the regular {{AbstractType}} to prevent
> pulling too many internal dependencies. The driver's vector codec has
> recently been added by
> [JAVA-3060|https://datastax-oss.atlassian.net/browse/JAVA-3060].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741078#comment-17741078
]
Brandon Williams commented on CASSANDRA-18639:
--
bq. Regardless of whether we eventually do that or not, I think that is too big
of a bite for this ticket in this stage. Let's just ninja it (and optionally
revert the output back to what it was for these two fields)
Alright, and make a new ticket to add serialization and change the output back?
bq. I also want to write an email to ML clarifying what we should do in cases
when we are going to change the output for majors. Not going to lie, it is
little bit irritating to hit this situation every now and then.
I totally agree, and that's why we need a serialized format so we don't run
into this situation and have the freedom to change whatever we want. We
already do this for a number of nodetool commands so it seems like the way.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741073#comment-17741073
]
Stefan Miklosovic edited comment on CASSANDRA-18639 at 7/7/23 2:58 PM:
---
Regardless of whether we eventually do that or not, I think that is too big of
a bite for this ticket in this stage. Let's just ninja it (and optionally
revert the output back to what it was for these two fields)
I also want to write an email to ML clarifying what we should do in cases when
we are going to change the output for majors. Not going to lie, it is little
bit irritating to be in this situation every now and then.
was (Author: smiklosovic):
Regardless of whether we eventually do that or not, I think that is too big of
a bite for this ticket in this stage. Let's just ninja it (and optionally
revert the output back to what it was for these two fields)
I also want to write an email to ML clarifying what we should do in cases when
we are going to change the output for majors. Not going to lie, it is little
bit irritating to hit this situation every now and then.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741073#comment-17741073
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Regardless of whether we eventually do that or not, I think that is too big of
a bite for this ticket in this stage. Let's just ninja it (and optionally
revert the output back to what it was for these two fields)
I also want to write an email to ML clarifying what we should do in cases when
we are going to change the output for majors. Not going to lie, it is little
bit irritating to hit this situation every now and then.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741070#comment-17741070
]
Brandon Williams commented on CASSANDRA-18639:
--
All the display logic stays. We would have a new method that -j invokes that
does something like "return toJSON(stats)". That's not exactly concrete but
without actually doing it that's my idea.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741067#comment-17741067
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Could you please show me concrete example? What I have in mind is this would
need to be json:
[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/SSTableMetadataViewer.java#L355-L441]
I am sorry I am so pedantic here, I want to understand you exactly. What I have
in mind is that -j would just print all statistics in JSON format, so whole
output would be changed.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741065#comment-17741065
]
Brandon Williams commented on CASSANDRA-18639:
--
bq. but we would need to completely rework how this tool prints it
No, we would add a -j flag or whatever and when present, return json.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741064#comment-17741064
]
Stefan Miklosovic edited comment on CASSANDRA-18639 at 7/7/23 2:41 PM:
---
Frankly speaking, I think we are over-thinking this. Sure, Yaml, JSON, why not,
we can add that, but we would need to completely rework how this tool prints
it. I mean ... complete overhaul. We would probably need to serialize
StatsMetadata and what about other statistics anyway?
Additionally, I need to meet just one person for who a change of the output
like suggested here (going to be introduced in {_}major{_}) is a problem. Is
not this really some kind of an urban story we are following blindly just
because ?
was (Author: smiklosovic):
Frankly speaking, I think we are over-thinking this. Sure, Yaml, JSON, why not,
we can add that, but we would need to completely rework how this tool prints
it. I mean ... complete overhaul. We would probably need to serialize
StatsMetadata and what about other statistics anyway?
Additionally, I need to meet just one person for which a change of the output
like suggested here (going to be introduced in {_}major{_}) is a problem. Is
not this really some kind of an urban story we are following blindly just
because ?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741064#comment-17741064
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Frankly speaking, I think we are over-thinking this. Sure, Yaml, JSON, why not,
we can add that, but we would need to completely rework how this tool prints
it. I mean ... complete overhaul. We would probably need to serialize
StatsMetadata and what about other statistics anyway?
Additionally, I need to meet just one person for which a change of the output
like suggested here (going to be introduced in {_}major{_}) is a problem. Is
not this really some kind of an urban story we are following blindly just
because ?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741060#comment-17741060
]
Brandon Williams edited comment on CASSANDRA-18639 at 7/7/23 2:37 PM:
--
Json, yaml, whatever will divorce the cosmetics from the data.
was (Author: brandon.williams):
Json, yaml, whatever.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741063#comment-17741063
]
Brad Schoening commented on CASSANDRA-18639:
A JSON output option could be a good idea.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741060#comment-17741060
]
Brandon Williams commented on CASSANDRA-18639:
--
Json, yaml, whatever.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741059#comment-17741059
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I dont understand what you mean by "serialized output format".
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741058#comment-17741058
]
Brandon Williams commented on CASSANDRA-18639:
--
I can understand and get behind both arguments here. My litmus test in this
situation is "can this information be obtained in another way?" and if not, we
either shouldn't change it, or... we can take this opportunity to solve the
problem and add a serialized output format, obviating the need for screen
scraping now and forever. WDYT?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18645) Upgrade guava on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741055#comment-17741055 ] Ekaterina Dimitrova edited comment on CASSANDRA-18645 at 7/7/23 2:15 PM: - Thank you for the review. CVE-2022-45688 - should be addressed in CASSANDRA-18643 CVE-2023-34462 - should be addressed in CASSANDRA-18649 I miss in my branch the commits from yesterday that suppressed them. Commtted to [https://github.com/apache/cassandra] [006ec71f63..992ad25b96|https://github.com/apache/cassandra/commit/992ad25b9608e59903dea4ec8becc00efbff5340] trunk -> trunk I added CHANGES.txt entry on commit. was (Author: e.dimitrova): CVE-2022-45688 - should be addressed in CASSANDRA-18643 CVE-2023-34462 - should be addressed in CASSANDRA-18649 I miss in my branch the commits from yesterday that suppressed them. Commtted to https://github.com/apache/cassandra [006ec71f63..992ad25b96|https://github.com/apache/cassandra/commit/992ad25b9608e59903dea4ec8becc00efbff5340] trunk -> trunk I added CHANGES.txt entry on commit. > Upgrade guava on trunk > -- > > Key: CASSANDRA-18645 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18645 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Labels: Dependency > Fix For: 5.0 > > > Recently guava added JDK17 in CI and fixed some bugs down the road. > Upgrading before the major 5.0 release is something we should do. > Also, the current version that Cassandra uses is from 2018. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18645) Upgrade guava on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741055#comment-17741055 ] Ekaterina Dimitrova commented on CASSANDRA-18645: - CVE-2022-45688 - should be addressed in CASSANDRA-18643 CVE-2023-34462 - should be addressed in CASSANDRA-18649 I miss in my branch the commits from yesterday that suppressed them. Commtted to https://github.com/apache/cassandra [006ec71f63..992ad25b96|https://github.com/apache/cassandra/commit/992ad25b9608e59903dea4ec8becc00efbff5340] trunk -> trunk I added CHANGES.txt entry on commit. > Upgrade guava on trunk > -- > > Key: CASSANDRA-18645 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18645 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Labels: Dependency > Fix For: 5.x > > > Recently guava added JDK17 in CI and fixed some bugs down the road. > Upgrading before the major 5.0 release is something we should do. > Also, the current version that Cassandra uses is from 2018. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18645) Upgrade guava on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18645: Fix Version/s: 5.0 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/992ad25b9608e59903dea4ec8becc00efbff5340 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Upgrade guava on trunk > -- > > Key: CASSANDRA-18645 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18645 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Labels: Dependency > Fix For: 5.0 > > > Recently guava added JDK17 in CI and fixed some bugs down the road. > Upgrading before the major 5.0 release is something we should do. > Also, the current version that Cassandra uses is from 2018. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Update Guava to 32.0.1-jre
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 992ad25b96 Update Guava to 32.0.1-jre 992ad25b96 is described below commit 992ad25b9608e59903dea4ec8becc00efbff5340 Author: Ekaterina Dimitrova AuthorDate: Tue Jun 13 19:08:50 2023 -0400 Update Guava to 32.0.1-jre patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi for CASSANDRA-18645 --- .build/checkstyle.xml| 2 +- .build/dependency-check-suppressions.xml | 6 -- .build/parent-pom-template.xml | 6 +- CHANGES.txt | 1 + 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/.build/checkstyle.xml b/.build/checkstyle.xml index 50bd8743c0..2998ebe428 100644 --- a/.build/checkstyle.xml +++ b/.build/checkstyle.xml @@ -107,7 +107,7 @@ - + diff --git a/.build/dependency-check-suppressions.xml b/.build/dependency-check-suppressions.xml index ae7ff368a7..d7a66cb3bf 100644 --- a/.build/dependency-check-suppressions.xml +++ b/.build/dependency-check-suppressions.xml @@ -49,12 +49,6 @@ ^pkg:maven/net\.openhft/chronicle\-wire@.*$ cpe:/a:wire:wire - - -^pkg:maven/com\.google\.guava/guava@.*$ -CVE-2020-8908 -CVE-2023-2976 - ^pkg:maven/org\.apache\.commons.*$ diff --git a/.build/parent-pom-template.xml b/.build/parent-pom-template.xml index a88764ee75..3eaa9ba3af 100644 --- a/.build/parent-pom-template.xml +++ b/.build/parent-pom-template.xml @@ -269,7 +269,7 @@ com.google.guava guava -27.0-jre +32.0.1-jre jsr305 @@ -283,10 +283,6 @@ listenablefuture com.google.guava - -failureaccess -com.google.guava - checker-qual org.checkerframework diff --git a/CHANGES.txt b/CHANGES.txt index 69b78213e1..bcfdcfee58 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 5.0 + * Upgrade Guava to 32.0.1 (CASSANDRA-18645) * Add duration and count of partition keys to sstablemetadata (CASSANDRA-18639) * Remove deprecated compaction_tombstone_warning_threshold and compaction_large_partition_warning_threshold from yaml (CASSANDRA-18626) * Enhance nodetool compactionstats with additional metrics (CASSANDRA-18305) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741043#comment-17741043
]
Brad Schoening commented on CASSANDRA-18639:
> Feels unnecessary potentially breaking existing scripts for users when its
> just a style change
Major releases are where breaking changes should go. The alternative is to
never change or improve the output of sstablemetadata.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741035#comment-17741035
]
Marcus Eriksson commented on CASSANDRA-18639:
-
bq. Since this goes to 5.0 I think we can just break this as this does not
apply to majors afaik.
Feels unnecessary potentially breaking existing scripts for users when its just
a style change
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741034#comment-17741034
]
Timothy Tu commented on CASSANDRA-18639:
Total Partitions is just the Counts all summed togethor as shown below:
Total Partitions: 24306
Size (bytes) | Count (%) Histogram
35 (35 B) | 1 ( 0)
42 (42 B) | 98 ( 0)
50 (50 B) | 24207 ( 99) OO
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741029#comment-17741029
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I ll do that as I am just on in, no worries.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741027#comment-17741027
]
Brad Schoening commented on CASSANDRA-18639:
[~timothytu] we should document these additional options:
usage: sstablemetadata [-c] [-g ] [-s] [-t ]
[-u]
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741023#comment-17741023
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
https://github.com/apache/cassandra/pull/2472/files
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741020#comment-17741020
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Since this goes to 5.0 I think we can just break this as this does not apply to
majors afaik.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741018#comment-17741018 ] Michael Semb Wever edited comment on CASSANDRA-18133 at 7/7/23 1:04 PM: Fixes for artifacts and cqlshlib tests pushed. This is a prerequisite for the in-tree patch (to get jenkins cqlshlib tests working): https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk was (Author: michaelsembwever): This is a prerequisite for the in-tree patch: https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Bring the artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > -The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel.- > EDIT: this bit has been moved to CASSANDRA-18594 > This addresses the epic's stated existing problems: > - difficult to pre-commit test jenkins and cassandra-build changes, > - CI development efforts is split between ci-cassandra and circleci, despite > ci-cassandra being our canonical and non-commercial CI, > - lacking parity of what is tested between ci-cassandra and circleci > - cassandra-builds as a separate repo (without release branches matching > in-tree) adds complexity to changing matrix values (jdks, pythons, dist) > - -mixture of jenkins dsl groovy, declarative and scripting pipeline.- > - -different pre-commit and post-commit jenkins pipelines are used.- > In addition it addresses: > - -stage jobs don't always running on the same SHA as the pipeline's run,- > - infra issues around networking, specifically git cloning additional > cassandra-builds repository, > - -a more readable Jenkinsfile- > - more UX friendly build and test scripts -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741019#comment-17741019
]
Marcus Eriksson commented on CASSANDRA-18639:
-
we should probably keep them for backwards compatibility
and, we should probably not rename the totalColumnsSet/totalRows fields if
someone parses the output of this
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741018#comment-17741018 ] Michael Semb Wever commented on CASSANDRA-18133: This is a prerequisite for the in-tree patch: https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18133_pre/trunk > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Bring the artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > -The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel.- > EDIT: this bit has been moved to CASSANDRA-18594 > This addresses the epic's stated existing problems: > - difficult to pre-commit test jenkins and cassandra-build changes, > - CI development efforts is split between ci-cassandra and circleci, despite > ci-cassandra being our canonical and non-commercial CI, > - lacking parity of what is tested between ci-cassandra and circleci > - cassandra-builds as a separate repo (without release branches matching > in-tree) adds complexity to changing matrix values (jdks, pythons, dist) > - -mixture of jenkins dsl groovy, declarative and scripting pipeline.- > - -different pre-commit and post-commit jenkins pipelines are used.- > In addition it addresses: > - -stage jobs don't always running on the same SHA as the pipeline's run,- > - infra issues around networking, specifically git cloning additional > cassandra-builds repository, > - -a more readable Jenkinsfile- > - more UX friendly build and test scripts -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741017#comment-17741017
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I would keep it there because that one is just _estimation_. Right?
{code}
/**
* @return the number of unique elements in the stream or an estimate
thereof
*/
long cardinality();
{code}
But the figures under "-s" give you always exact numbers. So in theory they
might differ.
BTW this which was already in trunk before this change seems to be just
redundant because it will be printed also when '-s' is used.
{code}
field("totalColumnsSet", stats.totalColumnsSet);
field("totalRows", stats.totalRows);
{code}
It that same what we get after "-s"? If so, should not we remove this too? Or
we keep it?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741013#comment-17741013
]
Brandon Williams commented on CASSANDRA-18639:
--
We are already printing compaction.cardinalityEstimator.cardinality() in
'estimated cardinality' too.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741011#comment-17741011
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Hah really, damn, where have we been looking?! So this can just go away and we
keep duration only. I'll fix that.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18639:
-
Fix Version/s: 5.x
(was: 5.0)
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741010#comment-17741010
]
Marcus Eriksson commented on CASSANDRA-18639:
-
yeah, we have the {{-s/--scan}} option to do slow operations like this, which
already outputs exact partition count
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
