[jira] [Commented] (CASSANDRA-3085) Race condition in sstable reference counting

2011-09-15 Thread Yang Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105212#comment-13105212
 ] 

Yang Yang commented on CASSANDRA-3085:
--

Thanks Jonathan.

but I still can't see why the old code would cause errors, could you please see 
if the following reason makes sense?



if you look at the operations of +1 and -1 by read paths and the compaction 
path, either the read path or the compaction can be seen as the following 
sequence

+1

//access the SSTableReader

-1


where for the compaction the +1 happens at creation of the SSTableReader; for 
read paths the +1 happens at acquireReference()

since every path (either compaction or reader) does one +1 and one -1, by the 
time a path finishes, the ref count will be equal to the number of live code 
paths

if the file is removed, the ref count must be 0, hence live paths count at that 
moment must be 0. if there are no future paths to run, it's all good. if there 
are , the path would access a file already removed and we have a problem. but 
this is impossible because: if  the +1 comes after compaction.release(), 
because compaction.release() comes after the view change in 
DataTracker.replace(), then reader path.acquire() comes after 
DataTracker.replace(),  but this is impossible because the reader can not see 
that SSTableReader in its view.



 Race condition in sstable reference counting
 

 Key: CASSANDRA-3085
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3085
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Critical
 Fix For: 1.0.0

 Attachments: 3085-v2.txt, 3085.txt


 DataTracker gives us an atomic View of memtable/sstables, but acquiring 
 references is not atomic.  So it is possible to acquire references to an 
 SSTableReader object that is no longer valid, as in this example:
 View V contains sstables {A, B}.  We attempt a read in thread T using this 
 View.
 Meanwhile, A and B are compacted to {C}, yielding View W.  No references 
 exist to A or B so they are cleaned up.
 Back in thread T we acquire references to A and B.  This does not cause an 
 error, but it will when we attempt to read from them next.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (CASSANDRA-3085) Race condition in sstable reference counting

2011-09-15 Thread Yang Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105212#comment-13105212
 ] 

Yang Yang edited comment on CASSANDRA-3085 at 9/15/11 8:45 AM:
---

Thanks Jonathan.

but I still can't see why the old code would cause errors, could you please see 
if the following reasoning makes sense?



if you look at the operations of +1 and -1 by read paths and the compaction 
path, either the read path or the compaction can be seen as the following 
sequence

+1

//access the SSTableReader

-1


where for the compaction the +1 happens at creation of the SSTableReader; for 
read paths the +1 happens at acquireReference()

since every path (either compaction or reader) does one +1 and one -1, by the 
time a path finishes, the ref count will be equal to the number of live code 
paths

if the file is removed, the ref count must be 0, hence live paths count at that 
moment must be 0. if there are no future paths to run, it's all good. if there 
are , the path would access a file already removed and we have a problem. but 
this is impossible because: if  the +1 comes after compaction.release(), 
because *compaction.release() comes after the view change in 
DataTracker.replace()*, then reader path +1 comes after DataTracker.replace(),  
but this is impossible because the read path can not see that SSTableReader in 
its view.



  was (Author: yangyangyyy):
Thanks Jonathan.

but I still can't see why the old code would cause errors, could you please see 
if the following reason makes sense?



if you look at the operations of +1 and -1 by read paths and the compaction 
path, either the read path or the compaction can be seen as the following 
sequence

+1

//access the SSTableReader

-1


where for the compaction the +1 happens at creation of the SSTableReader; for 
read paths the +1 happens at acquireReference()

since every path (either compaction or reader) does one +1 and one -1, by the 
time a path finishes, the ref count will be equal to the number of live code 
paths

if the file is removed, the ref count must be 0, hence live paths count at that 
moment must be 0. if there are no future paths to run, it's all good. if there 
are , the path would access a file already removed and we have a problem. but 
this is impossible because: if  the +1 comes after compaction.release(), 
because *compaction.release() comes after the view change in 
DataTracker.replace()*, then reader path +1 comes after DataTracker.replace(),  
but this is impossible because the read path can not see that SSTableReader in 
its view.


  
 Race condition in sstable reference counting
 

 Key: CASSANDRA-3085
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3085
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Critical
 Fix For: 1.0.0

 Attachments: 3085-v2.txt, 3085.txt


 DataTracker gives us an atomic View of memtable/sstables, but acquiring 
 references is not atomic.  So it is possible to acquire references to an 
 SSTableReader object that is no longer valid, as in this example:
 View V contains sstables {A, B}.  We attempt a read in thread T using this 
 View.
 Meanwhile, A and B are compacted to {C}, yielding View W.  No references 
 exist to A or B so they are cleaned up.
 Back in thread T we acquire references to A and B.  This does not cause an 
 error, but it will when we attempt to read from them next.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3201) When a mmap fails, Cassandra should exit.

2011-09-15 Thread Sylvain Lebresne (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105236#comment-13105236
 ] 

Sylvain Lebresne commented on CASSANDRA-3201:
-

lgtm, +1

 When a mmap fails, Cassandra should exit.
 -

 Key: CASSANDRA-3201
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3201
 Project: Cassandra
  Issue Type: Improvement
 Environment: Ubuntu 10.04.2/sun-java6-jdk 6.24-1build0.10.04.1
Reporter: Eldon Stegall
Priority: Minor
 Attachments: 3201.txt


 When a mmap fails, Cassandra should exit. See 
 https://wiki.apache.org/cassandra/ArchitectureInternals#line-60
 Here is an example stack trace:
 ERROR 17:11:36,258 Fatal exception in thread Thread[FlushWriter:2003,5,main]
 java.io.IOError: java.io.IOException: Map failed
 at 
 org.apache.cassandra.io.util.MmappedSegmentedFile$Builder.createSegments(MmappedSegmentedFile.java:170)
 at 
 org.apache.cassandra.io.util.MmappedSegmentedFile$Builder.complete(MmappedSegmentedFile.java:147)
 at 
 org.apache.cassandra.io.sstable.SSTableWriter.closeAndOpenReader(SSTableWriter.java:194)
 at 
 org.apache.cassandra.io.sstable.SSTableWriter.closeAndOpenReader(SSTableWriter.java:173)
 at 
 org.apache.cassandra.db.Memtable.writeSortedContents(Memtable.java:253)
 at org.apache.cassandra.db.Memtable.access$400(Memtable.java:49)
 at org.apache.cassandra.db.Memtable$3.runMayThrow(Memtable.java:270)
 at 
 org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.IOException: Map failed
 at sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:748)
 at 
 org.apache.cassandra.io.util.MmappedSegmentedFile$Builder.createSegments(MmappedSegmentedFile.java:162)
 ... 10 more
 Caused by: java.lang.OutOfMemoryError: Map failed
 at sun.nio.ch.FileChannelImpl.map0(Native Method)
 at sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:745)
 ... 11 more

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-3178) Counter shard merging is not thread safe

2011-09-15 Thread Sylvain Lebresne (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylvain Lebresne updated CASSANDRA-3178:


Attachment: 0002-Simplify-improve-shard-merging-code-v2.patch
0001-Move-shard-merging-completely-to-compaction-v2.patch

Attaching v2, rebased and that remove the use of flush_after_mins.

 Counter shard merging is not thread safe
 

 Key: CASSANDRA-3178
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3178
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.5
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
  Labels: counters
 Fix For: 0.8.6

 Attachments: 
 0001-Move-shard-merging-completely-to-compaction-v2.patch, 
 0001-Move-shard-merging-completely-to-compaction.patch, 
 0002-Simplify-improve-shard-merging-code-v2.patch, 
 0002-Simplify-improve-shard-merging-code.patch


 The first part of the counter shard merging process is done during counter 
 replication. This was done there because it requires that all replica are 
 made aware of the merging (we could only rely on nodetool repair for that but 
 that seems much too fragile, it's better as just a safety net). However this 
 part isn't thread safe as multiple threads can do the merging for the same 
 shard at the same time (which shouldn't really corrupt the counter value 
 per se, but result in an incorrect context).
 Synchronizing that part of the code would be very costly in term of 
 performance, so instance I propose to move the part of the shard merging done 
 during replication to compaction. It's a better place anyway. The only 
 downside is that it means compaction will sometime send mutations to other 
 node as a side effect, which doesn't feel very clean but is probably not a 
 big deal either.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3198) debian packaging installation problem when installing for the first time

2011-09-15 Thread Sylvain Lebresne (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105262#comment-13105262
 ] 

Sylvain Lebresne commented on CASSANDRA-3198:
-

bq. we didn't always create the cassandra user and chown in postinst

Yes, and to make it clear what my point is: while we do create the cassandra 
user since 0.6.4-2, we *never* chown in the postinst _excepted_ for people that 
upgraded *all the way* since a pre 0.6.4 release. That is, any current new 
installation (say of 0.8.5) *does not* chown in the postint and 
/var/lib/cassandra and /var/log/cassandra (the directories) are owned by root, 
not cassandra.

Now I'm perfectly fine saying that there is no point in changing things during 
upgrades and to only fix the chown in the postinst for new installs, but just 
wanted to make it clear that this has nothing to do with upgrades from some 
0.6.x versions.




 debian packaging installation problem when installing for the first time
 

 Key: CASSANDRA-3198
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3198
 Project: Cassandra
  Issue Type: Bug
  Components: Packaging
Affects Versions: 0.8.5
Reporter: Jérémy Sevellec
Assignee: Jérémy Sevellec
 Fix For: 0.8.6

 Attachments: debian-postinst-fixperms.patch, trunk-3198-v1.patch


 when installing cassandra through the debian packaging for the first time, 
 there is permission problem when starting Cassandra.
 Normally, the postinst script change owner of /var/log/cassandra and 
 /var/lib/cassandra from root to cassandra user.
 there is a problem with the test which verify if threre is a need to change 
 the owner of these directory or not.
 On a new install, the $2 parameter is not set and the the test is false and 
 the owner is not changed.
 (simply, i think replace  with || might work)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3209) CLI does not display error when it is not possible to create a keyspace when schemas in cluster do not agree.

2011-09-15 Thread Pavel Yaskevich (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105264#comment-13105264
 ] 

Pavel Yaskevich commented on CASSANDRA-3209:


Unfortunately I can't reproduce that using current cassandra-0.8 branch and 
ccm (github.com/pcmanus/ccm) tool. Created a 3 node cluster and stopped one 
node, tried to run your command `create keyspace TestKeyspace with 
placement_strategy = 'org.apache.cassandra.locator.NetworkTopologyStrategy' and 
strategy_options=[{Brisk:3, Cassandra:0}];` on one of the alive nodes and got 
the following output:

{noformat}
[default@unknown] describe cluster; 

  
Cluster Information:
   Snitch: org.apache.cassandra.locator.SimpleSnitch
   Partitioner: org.apache.cassandra.dht.RandomPartitioner
   Schema versions: 
UNREACHABLE: [127.0.0.2]
c2899390-df87-11e0--fe8ebeead9d9: [127.0.0.1, 127.0.0.3]
[default@unknown] create keyspace TestKeyspace with placement_strategy = 
'org.apache.cassandra.locator.NetworkTopologyStrategy' and 
strategy_options=[{Brisk:3, Cassandra:0}]; 
cc89d940-df87-11e0--fe8ebeead9d9
Waiting for schema agreement...
Warning: unreachable nodes 127.0.0.2... schemas agree across the cluster
{noformat}

and when I started node2 it fetched schema:

{noformat}
default@unknown] describe cluster;
Cluster Information:
   Snitch: org.apache.cassandra.locator.SimpleSnitch
   Partitioner: org.apache.cassandra.dht.RandomPartitioner
   Schema versions: 
cc89d940-df87-11e0--fe8ebeead9d9: [127.0.0.1, 127.0.0.2, 127.0.0.3]
{noformat}

Issue description states that affected version is 0.8.1 can you please test on 
the other version? Because I guess that this problem is already fixed.

 CLI does not display error when it is not possible to create a keyspace when 
 schemas in cluster do not agree.
 -

 Key: CASSANDRA-3209
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3209
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.1
 Environment: Latest brisk beta 2 deb on Ubuntu 10.10 server 64 bit.  
 (Using chef recipe to install)
Reporter: Todd Nine
Assignee: Pavel Yaskevich
  Labels: cli

 Cluster:
 3 nodes.  2 online, 1 offline
 describe cluster; displays 2 schema versions.  2 nodes are on 1 version, a 
 single node is on a different version.
 Issue this command in the CLI.
 create keyspace TestKeyspace with placement_strategy = 
 'org.apache.cassandra.locator.NetworkTopologyStrategy' and 
 strategy_options=[{Brisk:3, Cassandra:0}];
 What should happen.
 An error should be displayed when the keyspace cannot be created.
 What actually happens.
 The user is presented with null as the output.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (CASSANDRA-3212) Accomodate missing encryption_options in IncomingTcpConnection.stream

2011-09-15 Thread Jonathan Ellis (JIRA)
Accomodate missing encryption_options in IncomingTcpConnection.stream
-

 Key: CASSANDRA-3212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3212
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Trivial
 Fix For: 0.8.6




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171088 - in /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra: concurrent/DebuggableThreadPoolExecutor.java net/IncomingTcpConnection.java

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 13:18:03 2011
New Revision: 1171088

URL: http://svn.apache.org/viewvc?rev=1171088view=rev
Log:
merge r1170360 from 1.0.0

Modified:

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java?rev=1171088r1=1171087r2=1171088view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
 Thu Sep 15 13:18:03 2011
@@ -122,6 +122,10 @@ public class DebuggableThreadPoolExecuto
 {
 throw new AssertionError(e);
 }
+catch (CancellationException e)
+{
+logger.debug(Task cancelled, e);
+}
 catch (ExecutionException e)
 {
 if (Thread.getDefaultUncaughtExceptionHandler() == null)

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java?rev=1171088r1=1171087r2=1171088view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
 Thu Sep 15 13:18:03 2011
@@ -22,6 +22,7 @@ package org.apache.cassandra.net;
 
 
 import java.io.*;
+import java.net.InetAddress;
 import java.net.Socket;
 
 import org.apache.cassandra.gms.Gossiper;
@@ -41,11 +42,13 @@ public class IncomingTcpConnection exten
 private static final int CHUNK_SIZE = 1024 * 1024;
 
 private Socket socket;
+public InetAddress from;
 
 public IncomingTcpConnection(Socket socket)
 {
 assert socket != null;
 this.socket = socket;
+from = socket.getInetAddress(); // maximize chance of this not being 
nulled by disconnect
 }
 
 /**
@@ -70,8 +73,7 @@ public class IncomingTcpConnection exten
 // we should buffer
 input = new DataInputStream(new 
BufferedInputStream(socket.getInputStream(), 4096));
 version = MessagingService.getBits(header, 15, 8);
-if (logger.isDebugEnabled())
-logger.debug(Version for  + socket.getInetAddress() +  is  
+ version);
+logger.debug(Version for {} is {}, from, version);
 }
 catch (IOException e)
 {
@@ -83,7 +85,7 @@ public class IncomingTcpConnection exten
 if (version  MessagingService.version_)
 {
 // save the endpoint so gossip will reconnect to it
-Gossiper.instance.addSavedEndpoint(socket.getInetAddress());
+Gossiper.instance.addSavedEndpoint(from);
 logger.info(Received  + (isStream ? streaming  : ) + 
connection from newer protocol version. Ignorning);
 
 // streaming connections are per-session and have a fixed version. 
 we can't do anything with a new-version
@@ -99,8 +101,8 @@ public class IncomingTcpConnection exten
 else
 {
 // only set version when = to us, otherwise it's the 
responsibility of the other end to mimic us
-Gossiper.instance.setVersion(socket.getInetAddress(), version);
-logger.debug(set version for {} to {}, socket.getInetAddress(), 
version);
+Gossiper.instance.setVersion(from, version);
+logger.debug(set version for {} to {}, from, version);
 }
 
 while (true)
@@ -165,7 +167,8 @@ public class IncomingTcpConnection exten
 private void close()
 {
 // reset version here, since we set when starting an incoming socket
-Gossiper.instance.resetVersion(socket.getInetAddress());
+if (from != null)
+Gossiper.instance.resetVersion(from);
 try
 {
 socket.close();




[jira] [Updated] (CASSANDRA-3212) Accomodate missing encryption_options in IncomingTcpConnection.stream

2011-09-15 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-3212:
--

Attachment: 3212.txt

one-line fix.

 Accomodate missing encryption_options in IncomingTcpConnection.stream
 -

 Key: CASSANDRA-3212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3212
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Trivial
 Fix For: 0.8.6

 Attachments: 3212.txt




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3212) Accomodate missing encryption_options in IncomingTcpConnection.stream

2011-09-15 Thread Sylvain Lebresne (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105343#comment-13105343
 ] 

Sylvain Lebresne commented on CASSANDRA-3212:
-

+1

 Accomodate missing encryption_options in IncomingTcpConnection.stream
 -

 Key: CASSANDRA-3212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3212
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Trivial
 Fix For: 0.8.6

 Attachments: 3212.txt




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171091 - /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 13:31:50 2011
New Revision: 1171091

URL: http://svn.apache.org/viewvc?rev=1171091view=rev
Log:
Accomodate missing encryption_options in IncomingTcpConnection.stream
patch by jbellis; reviewed by slebresne for CASSANDRA-3212

Modified:

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java?rev=1171091r1=1171090r2=1171091view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
 Thu Sep 15 13:31:50 2011
@@ -182,7 +182,8 @@ public class IncomingTcpConnection exten
 
 private void stream(StreamHeader streamHeader, DataInputStream input) 
throws IOException
 {
-if (DatabaseDescriptor.getEncryptionOptions().internode_encryption == 
EncryptionOptions.InternodeEncryption.all)
+EncryptionOptions options = DatabaseDescriptor.getEncryptionOptions();
+if (options != null  options.internode_encryption == 
EncryptionOptions.InternodeEncryption.all)
 new SSLIncomingStreamReader(streamHeader, socket, input).read();
 else
 new IncomingStreamReader(streamHeader, socket).read();




svn commit: r1171095 - /cassandra/branches/cassandra-0.8/CHANGES.txt

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 13:38:31 2011
New Revision: 1171095

URL: http://svn.apache.org/viewvc?rev=1171095view=rev
Log:
add #1777 and #3187 to CHANGES

Modified:
cassandra/branches/cassandra-0.8/CHANGES.txt

Modified: cassandra/branches/cassandra-0.8/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/CHANGES.txt?rev=1171095r1=1171094r2=1171095view=diff
==
--- cassandra/branches/cassandra-0.8/CHANGES.txt (original)
+++ cassandra/branches/cassandra-0.8/CHANGES.txt Thu Sep 15 13:38:31 2011
@@ -1,4 +1,7 @@
 0.8.6
+ * revert CASSANDRA-2388
+ * change TokenRange.endpoints back to listen/broadcast address to match
+   pre-1777 behavior, and add TokenRange.rpc_endpoints instead (CASSANDRA-3187)
  * avoid trying to watch cassandra-topology.properties when loaded from jar
(CASSANDRA-3138)
  * prevent users from creating keyspaces with LocalStrategy replication
@@ -16,10 +19,10 @@
  * Avoid streaming data to nodes that already have it, on move as well as
decommission (CASSANDRA-3041)
  * Fix divide by zero error in GCInspector
- * revert CASSANDRA-2388
  * allow quoting of the ColumnFamily name in CLI `create column family`
statement (CASSANDRA-3195)
 
+
 0.8.5
  * fix NPE when encryption_options is unspecified (CASSANDRA-3007)
  * include column name in validation failure exceptions (CASSANDRA-2849)
@@ -82,6 +85,8 @@
 
 
 0.8.4
+ * change TokenRing.endpoints to be a list of rpc addresses instead of 
+   listen/broadcast addresses (CASSANDRA-1777)
  * include files-to-be-streamed in StreamInSession.getSources (CASSANDRA-2972)
  * use JAVA env var in cassandra-env.sh (CASSANDRA-2785, 2992)
  * avoid doing read for no-op replicate-on-write at CL=1 (CASSANDRA-2892)




svn commit: r1171097 - in /cassandra/branches/cassandra-1.0.0: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/cli/ test/unit/org/apache/cassandra/cli/

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 13:46:28 2011
New Revision: 1171097

URL: http://svn.apache.org/viewvc?rev=1171097view=rev
Log:
merge from 0.8

Modified:
cassandra/branches/cassandra-1.0.0/   (props changed)
cassandra/branches/cassandra-1.0.0/CHANGES.txt
cassandra/branches/cassandra-1.0.0/NEWS.txt
cassandra/branches/cassandra-1.0.0/contrib/   (props changed)

cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
   (props changed)

cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
   (props changed)

cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
   (props changed)

cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
   (props changed)

cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
   (props changed)

cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/cli/CliClient.java

cassandra/branches/cassandra-1.0.0/test/unit/org/apache/cassandra/cli/CliTest.java

Propchange: cassandra/branches/cassandra-1.0.0/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 13:46:28 2011
@@ -1,7 +1,7 @@
 
/cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291
 /cassandra/branches/cassandra-0.7:1026516-1170333
 /cassandra/branches/cassandra-0.7.0:1053690-1055654
-/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1170335
+/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1171096
 /cassandra/branches/cassandra-0.8.0:1125021-1130369
 /cassandra/branches/cassandra-0.8.1:1101014-1125018
 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689

Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1171097r1=1171096r2=1171097view=diff
==
--- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Thu Sep 15 13:46:28 2011
@@ -83,6 +83,9 @@
 
 
 0.8.6
+ * revert CASSANDRA-2388
+ * change TokenRange.endpoints back to listen/broadcast address to match
+   pre-1777 behavior, and add TokenRange.rpc_endpoints instead (CASSANDRA-3187)
  * avoid trying to watch cassandra-topology.properties when loaded from jar
(CASSANDRA-3138)
  * prevent users from creating keyspaces with LocalStrategy replication
@@ -100,7 +103,8 @@
  * Avoid streaming data to nodes that already have it, on move as well as
decommission (CASSANDRA-3041)
  * Fix divide by zero error in GCInspector
- * revert CASSANDRA-2388
+ * allow quoting of the ColumnFamily name in CLI `create column family`
+   statement (CASSANDRA-3195)
 
 
 0.8.5
@@ -163,6 +167,8 @@
 
 
 0.8.4
+ * change TokenRing.endpoints to be a list of rpc addresses instead of 
+   listen/broadcast addresses (CASSANDRA-1777)
  * include files-to-be-streamed in StreamInSession.getSources (CASSANDRA-2972)
  * use JAVA env var in cassandra-env.sh (CASSANDRA-2785, 2992)
  * avoid doing read for no-op replicate-on-write at CL=1 (CASSANDRA-2892)
@@ -253,7 +259,7 @@
  * fix re-using index CF sstable names after drop/recreate (CASSANDRA-2872)
  * prepend CF to default index names (CASSANDRA-2903)
  * fix hint replay (CASSANDRA-2928)
- * Properly synchronize merkle tree computation (CASSANDRA-2816)
+ * Properly synchronize repair's merkle tree computation (CASSANDRA-2816)
 
 
 0.8.1

Modified: cassandra/branches/cassandra-1.0.0/NEWS.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/NEWS.txt?rev=1171097r1=1171096r2=1171097view=diff
==
--- cassandra/branches/cassandra-1.0.0/NEWS.txt (original)
+++ cassandra/branches/cassandra-1.0.0/NEWS.txt Thu Sep 15 13:46:28 2011
@@ -166,7 +166,9 @@ Upgrading
 -
 - Upgrading from version 0.7.1 or later can be done with a rolling
   restart, one node at a time.  You do not need to bring down the
-  whole cluster at once.
+  whole cluster at once. 
+- After upgrading, run nodetool scrub against each node before running
+  repair, moving nodes, or adding new ones.
 - Running nodetool drain before shutting down the 0.7 node is
   recommended but not required. (Skipping this will result in
   replay of entire commitlog, so it will take longer to restart but

Propchange: cassandra/branches/cassandra-1.0.0/contrib/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 13:46:28 2011
@@ -1,7 +1,7 @@
 

svn commit: r1171099 - in /cassandra/branches/cassandra-1.0: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/cli/ test/unit/org/apache/cassandra/cli/

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 13:47:13 2011
New Revision: 1171099

URL: http://svn.apache.org/viewvc?rev=1171099view=rev
Log:
merge from 1.0.0

Modified:
cassandra/branches/cassandra-1.0/   (props changed)
cassandra/branches/cassandra-1.0/CHANGES.txt
cassandra/branches/cassandra-1.0/NEWS.txt
cassandra/branches/cassandra-1.0/contrib/   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
   (props changed)

cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/cli/CliClient.java

cassandra/branches/cassandra-1.0/test/unit/org/apache/cassandra/cli/CliTest.java

Propchange: cassandra/branches/cassandra-1.0/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 13:47:13 2011
@@ -1,11 +1,11 @@
 
/cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291
 /cassandra/branches/cassandra-0.7:1026516-1170333
 /cassandra/branches/cassandra-0.7.0:1053690-1055654
-/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1170335
+/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1171096
 /cassandra/branches/cassandra-0.8.0:1125021-1130369
 /cassandra/branches/cassandra-0.8.1:1101014-1125018
 /cassandra/branches/cassandra-1.0:1167106,1167185
-/cassandra/branches/cassandra-1.0.0:1167104-1170947
+/cassandra/branches/cassandra-1.0.0:1167104-1171098
 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020
 /cassandra/trunk:1167085-1167102,1169870

Modified: cassandra/branches/cassandra-1.0/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/CHANGES.txt?rev=1171099r1=1171098r2=1171099view=diff
==
--- cassandra/branches/cassandra-1.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0/CHANGES.txt Thu Sep 15 13:47:13 2011
@@ -87,6 +87,9 @@
 
 
 0.8.6
+ * revert CASSANDRA-2388
+ * change TokenRange.endpoints back to listen/broadcast address to match
+   pre-1777 behavior, and add TokenRange.rpc_endpoints instead (CASSANDRA-3187)
  * avoid trying to watch cassandra-topology.properties when loaded from jar
(CASSANDRA-3138)
  * prevent users from creating keyspaces with LocalStrategy replication
@@ -104,7 +107,8 @@
  * Avoid streaming data to nodes that already have it, on move as well as
decommission (CASSANDRA-3041)
  * Fix divide by zero error in GCInspector
- * revert CASSANDRA-2388
+ * allow quoting of the ColumnFamily name in CLI `create column family`
+   statement (CASSANDRA-3195)
 
 
 0.8.5
@@ -167,6 +171,8 @@
 
 
 0.8.4
+ * change TokenRing.endpoints to be a list of rpc addresses instead of 
+   listen/broadcast addresses (CASSANDRA-1777)
  * include files-to-be-streamed in StreamInSession.getSources (CASSANDRA-2972)
  * use JAVA env var in cassandra-env.sh (CASSANDRA-2785, 2992)
  * avoid doing read for no-op replicate-on-write at CL=1 (CASSANDRA-2892)
@@ -257,7 +263,7 @@
  * fix re-using index CF sstable names after drop/recreate (CASSANDRA-2872)
  * prepend CF to default index names (CASSANDRA-2903)
  * fix hint replay (CASSANDRA-2928)
- * Properly synchronize merkle tree computation (CASSANDRA-2816)
+ * Properly synchronize repair's merkle tree computation (CASSANDRA-2816)
 
 
 0.8.1

Modified: cassandra/branches/cassandra-1.0/NEWS.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/NEWS.txt?rev=1171099r1=1171098r2=1171099view=diff
==
--- cassandra/branches/cassandra-1.0/NEWS.txt (original)
+++ cassandra/branches/cassandra-1.0/NEWS.txt Thu Sep 15 13:47:13 2011
@@ -166,7 +166,9 @@ Upgrading
 -
 - Upgrading from version 0.7.1 or later can be done with a rolling
   restart, one node at a time.  You do not need to bring down the
-  whole cluster at once.
+  whole cluster at once. 
+- After upgrading, run nodetool scrub against each node before running
+  repair, moving nodes, or adding new ones.
 - Running nodetool drain before shutting down the 0.7 node is
   recommended but not required. (Skipping this will result in
   replay of entire commitlog, so it will take longer to restart but

Propchange: cassandra/branches/cassandra-1.0/contrib/

svn commit: r1171100 - in /cassandra/trunk: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/cli/ test/unit/org/apache/cassandra/cli/

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 13:48:12 2011
New Revision: 1171100

URL: http://svn.apache.org/viewvc?rev=1171100view=rev
Log:
merge from 1.0.0

Modified:
cassandra/trunk/   (props changed)
cassandra/trunk/CHANGES.txt
cassandra/trunk/NEWS.txt
cassandra/trunk/contrib/   (props changed)

cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
   (props changed)

cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
   (props changed)

cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
   (props changed)

cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
   (props changed)

cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
   (props changed)
cassandra/trunk/src/java/org/apache/cassandra/cli/CliClient.java
cassandra/trunk/test/unit/org/apache/cassandra/cli/CliTest.java

Propchange: cassandra/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 13:48:12 2011
@@ -1,11 +1,11 @@
 
/cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291
 /cassandra/branches/cassandra-0.7:1026516-1170333
 /cassandra/branches/cassandra-0.7.0:1053690-1055654
-/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1170335
+/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1171096
 /cassandra/branches/cassandra-0.8.0:1125021-1130369
 /cassandra/branches/cassandra-0.8.1:1101014-1125018
-/cassandra/branches/cassandra-1.0:1167085-1170948
-/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1170947
+/cassandra/branches/cassandra-1.0:1167085-1171099
+/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1171098
 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020
 /incubator/cassandra/branches/cassandra-0.3:774578-796573

Modified: cassandra/trunk/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/trunk/CHANGES.txt?rev=1171100r1=1171099r2=1171100view=diff
==
--- cassandra/trunk/CHANGES.txt (original)
+++ cassandra/trunk/CHANGES.txt Thu Sep 15 13:48:12 2011
@@ -87,6 +87,9 @@
 
 
 0.8.6
+ * revert CASSANDRA-2388
+ * change TokenRange.endpoints back to listen/broadcast address to match
+   pre-1777 behavior, and add TokenRange.rpc_endpoints instead (CASSANDRA-3187)
  * avoid trying to watch cassandra-topology.properties when loaded from jar
(CASSANDRA-3138)
  * prevent users from creating keyspaces with LocalStrategy replication
@@ -104,7 +107,8 @@
  * Avoid streaming data to nodes that already have it, on move as well as
decommission (CASSANDRA-3041)
  * Fix divide by zero error in GCInspector
- * revert CASSANDRA-2388
+ * allow quoting of the ColumnFamily name in CLI `create column family`
+   statement (CASSANDRA-3195)
 
 
 0.8.5
@@ -167,6 +171,8 @@
 
 
 0.8.4
+ * change TokenRing.endpoints to be a list of rpc addresses instead of 
+   listen/broadcast addresses (CASSANDRA-1777)
  * include files-to-be-streamed in StreamInSession.getSources (CASSANDRA-2972)
  * use JAVA env var in cassandra-env.sh (CASSANDRA-2785, 2992)
  * avoid doing read for no-op replicate-on-write at CL=1 (CASSANDRA-2892)
@@ -257,7 +263,7 @@
  * fix re-using index CF sstable names after drop/recreate (CASSANDRA-2872)
  * prepend CF to default index names (CASSANDRA-2903)
  * fix hint replay (CASSANDRA-2928)
- * Properly synchronize merkle tree computation (CASSANDRA-2816)
+ * Properly synchronize repair's merkle tree computation (CASSANDRA-2816)
 
 
 0.8.1

Modified: cassandra/trunk/NEWS.txt
URL: 
http://svn.apache.org/viewvc/cassandra/trunk/NEWS.txt?rev=1171100r1=1171099r2=1171100view=diff
==
--- cassandra/trunk/NEWS.txt (original)
+++ cassandra/trunk/NEWS.txt Thu Sep 15 13:48:12 2011
@@ -166,7 +166,9 @@ Upgrading
 -
 - Upgrading from version 0.7.1 or later can be done with a rolling
   restart, one node at a time.  You do not need to bring down the
-  whole cluster at once.
+  whole cluster at once. 
+- After upgrading, run nodetool scrub against each node before running
+  repair, moving nodes, or adding new ones.
 - Running nodetool drain before shutting down the 0.7 node is
   recommended but not required. (Skipping this will result in
   replay of entire commitlog, so it will take longer to restart but

Propchange: cassandra/trunk/contrib/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 13:48:12 2011
@@ -1,11 +1,11 @@
 
/cassandra/branches/cassandra-0.6/contrib:922689-1052356,1052358-1053452,1053454,1053456-1068009
 

[jira] [Created] (CASSANDRA-3213) Upgrade Thrift to 0.7.0

2011-09-15 Thread Jake Farrell (JIRA)
Upgrade Thrift to 0.7.0
---

 Key: CASSANDRA-3213
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3213
 Project: Cassandra
  Issue Type: Task
  Components: Core
Reporter: Jake Farrell
Assignee: Jake Farrell
Priority: Trivial




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-3213) Upgrade Thrift to 0.7.0

2011-09-15 Thread Jake Farrell (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell updated CASSANDRA-3213:


Attachment: v1-0003-update-build-xml.patch
v1-0002-upgrade-thrift-jar-and-license.patch
v1-0001-update-generated-thrift-code.patch

Upgrades thrift jar and generated code to latest 0.7.0 version

 Upgrade Thrift to 0.7.0
 ---

 Key: CASSANDRA-3213
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3213
 Project: Cassandra
  Issue Type: Task
  Components: Core
Reporter: Jake Farrell
Assignee: Jake Farrell
Priority: Trivial
 Attachments: v1-0001-update-generated-thrift-code.patch, 
 v1-0002-upgrade-thrift-jar-and-license.patch, v1-0003-update-build-xml.patch




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3212) Accomodate missing encryption_options in IncomingTcpConnection.stream

2011-09-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105385#comment-13105385
 ] 

Hudson commented on CASSANDRA-3212:
---

Integrated in Cassandra-0.8 #329 (See 
[https://builds.apache.org/job/Cassandra-0.8/329/])
Accomodate missing encryption_options in IncomingTcpConnection.stream
patch by jbellis; reviewed by slebresne for CASSANDRA-3212

jbellis : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1171091
Files : 
* 
/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/net/IncomingTcpConnection.java


 Accomodate missing encryption_options in IncomingTcpConnection.stream
 -

 Key: CASSANDRA-3212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3212
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.8.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Trivial
 Fix For: 0.8.6

 Attachments: 3212.txt




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171107 - in /cassandra/branches/cassandra-0.8: CHANGES.txt NEWS.txt

2011-09-15 Thread slebresne
Author: slebresne
Date: Thu Sep 15 14:24:36 2011
New Revision: 1171107

URL: http://svn.apache.org/viewvc?rev=1171107view=rev
Log:
Update changelog

Modified:
cassandra/branches/cassandra-0.8/CHANGES.txt
cassandra/branches/cassandra-0.8/NEWS.txt

Modified: cassandra/branches/cassandra-0.8/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/CHANGES.txt?rev=1171107r1=1171106r2=1171107view=diff
==
--- cassandra/branches/cassandra-0.8/CHANGES.txt (original)
+++ cassandra/branches/cassandra-0.8/CHANGES.txt Thu Sep 15 14:24:36 2011
@@ -18,9 +18,12 @@
  * Fix using read_repair_chance instead of merge_shard_change (CASSANDRA-3202)
  * Avoid streaming data to nodes that already have it, on move as well as
decommission (CASSANDRA-3041)
- * Fix divide by zero error in GCInspector
+ * Fix divide by zero error in GCInspector (CASSANDRA-3164)
  * allow quoting of the ColumnFamily name in CLI `create column family`
statement (CASSANDRA-3195)
+ * Fix rolling upgrade from 0.7 to 0.8 problem (CASANDRA-3166)
+ * Accomodate missing encryption_options in IncomingTcpConnection.stream
+   (CASSANDRA-3212)
 
 
 0.8.5

Modified: cassandra/branches/cassandra-0.8/NEWS.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/NEWS.txt?rev=1171107r1=1171106r2=1171107view=diff
==
--- cassandra/branches/cassandra-0.8/NEWS.txt (original)
+++ cassandra/branches/cassandra-0.8/NEWS.txt Thu Sep 15 14:24:36 2011
@@ -5,6 +5,7 @@ Features
 
 - describe_ring now returns both the listen_address and rpc_address
 
+
 0.8.5
 =
 




[jira] [Commented] (CASSANDRA-3213) Upgrade Thrift to 0.7.0

2011-09-15 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105405#comment-13105405
 ] 

Jonathan Ellis commented on CASSANDRA-3213:
---

Does this fix anything urgent?

If not I'd be included to put it in 1.1 instead of risking 1.0 stability during 
the freeze.

 Upgrade Thrift to 0.7.0
 ---

 Key: CASSANDRA-3213
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3213
 Project: Cassandra
  Issue Type: Task
  Components: Core
Reporter: Jake Farrell
Assignee: Jake Farrell
Priority: Trivial
 Attachments: v1-0001-update-generated-thrift-code.patch, 
 v1-0002-upgrade-thrift-jar-and-license.patch, v1-0003-update-build-xml.patch




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2280) Request specific column families using StreamIn

2011-09-15 Thread anand somani (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105408#comment-13105408
 ] 

anand somani commented on CASSANDRA-2280:
-

I noticed there was some attempt to port this to 0.8, but then comment by 
Jonathan that this will not be ported to 0.8.x. 
I suppose that means it will not be ported to 0.7.x? 
Is this because it is not possible just too many unresolvable conflicts? or 
what?

 Request specific column families using StreamIn
 ---

 Key: CASSANDRA-2280
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2280
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Stu Hood
Assignee: Jonathan Ellis
 Fix For: 1.0.0

 Attachments: 
 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 
 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 2280-v3.txt, 
 2280-v4.txt, 2280-v5.txt


 StreamIn.requestRanges only specifies a keyspace, meaning that requesting a 
 range will request it for all column families: if you have a large number of 
 CFs, this can cause quite a headache.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3213) Upgrade Thrift to 0.7.0

2011-09-15 Thread Jake Farrell (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105427#comment-13105427
 ] 

Jake Farrell commented on CASSANDRA-3213:
-

nothing urgent that i'm aware of

 Upgrade Thrift to 0.7.0
 ---

 Key: CASSANDRA-3213
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3213
 Project: Cassandra
  Issue Type: Task
  Components: Core
Reporter: Jake Farrell
Assignee: Jake Farrell
Priority: Trivial
 Attachments: v1-0001-update-generated-thrift-code.patch, 
 v1-0002-upgrade-thrift-jar-and-license.patch, v1-0003-update-build-xml.patch




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (CASSANDRA-2961) Expire dead gossip states based on time

2011-09-15 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105455#comment-13105455
 ] 

Jérémy Sevellec edited comment on CASSANDRA-2961 at 9/15/11 4:09 PM:
-

Here is a new version of the patch integrating your comments

  was (Author: jsevellec):
Here is a new version of the path integrating your comments
  
 Expire dead gossip states based on time
 ---

 Key: CASSANDRA-2961
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2961
 Project: Cassandra
  Issue Type: Improvement
Affects Versions: 1.0.0
Reporter: Brandon Williams
Assignee: Jérémy Sevellec
Priority: Minor
 Fix For: 1.0.1

 Attachments: trunk-2961-v2.patch, trunk-2961-v3.patch, 
 trunk-2961-v4.patch, trunk-2961.patch


 Currently dead states are held until aVeryLongTime, 3 days.  The problem is 
 that if a node reboots within this period, it begins a new 3 days and will 
 repopulate the ring with the dead state.  While mostly harmless, perpetuating 
 the state forever is at least wasting a small amount of bandwidth.  Instead, 
 we can expire states based on a ttl, which will require that the cluster be 
 loosely time synced; within the quarantine period of 60s.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2961) Expire dead gossip states based on time

2011-09-15 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jérémy Sevellec updated CASSANDRA-2961:
---

Attachment: trunk-2961-v4.patch

Here is a new version of the path integrating your comments

 Expire dead gossip states based on time
 ---

 Key: CASSANDRA-2961
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2961
 Project: Cassandra
  Issue Type: Improvement
Affects Versions: 1.0.0
Reporter: Brandon Williams
Assignee: Jérémy Sevellec
Priority: Minor
 Fix For: 1.0.1

 Attachments: trunk-2961-v2.patch, trunk-2961-v3.patch, 
 trunk-2961-v4.patch, trunk-2961.patch


 Currently dead states are held until aVeryLongTime, 3 days.  The problem is 
 that if a node reboots within this period, it begins a new 3 days and will 
 repopulate the ring with the dead state.  While mostly harmless, perpetuating 
 the state forever is at least wasting a small amount of bandwidth.  Instead, 
 we can expire states based on a ttl, which will require that the cluster be 
 loosely time synced; within the quarantine period of 60s.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2280) Request specific column families using StreamIn

2011-09-15 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105462#comment-13105462
 ] 

Jonathan Ellis commented on CASSANDRA-2280:
---

As mentioned above, we reverted it from 0.8.1 because of CASSANDRA-2818.  We've 
committed to maintaining drop-in-ability between minor releases, which means we 
can't release protocol changes unless protocol backwards- and 
forwards-compatibility actually works.  In this case, 2818 was a 
forwards-compatibility bug in 0.8.0 and 0.8.1 which means we'd have to say to 
upgrade to 0.8.x where x = 6, you must first upgrade to 0.8.y where 2 = y  
6.  Which is super confusing to people and honestly, my experience is that 99% 
of our users don't read NEWS before upgrading anyway so it's totally going to 
bite a lot of them.

0.7 was not affected by 2818 but it's past the point where we should be making 
protocol changes.  Any change is risky and the bar is pretty high to make 
changes to oldstable, which is what 0.7 is now.

 Request specific column families using StreamIn
 ---

 Key: CASSANDRA-2280
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2280
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Stu Hood
Assignee: Jonathan Ellis
 Fix For: 1.0.0

 Attachments: 
 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 
 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 2280-v3.txt, 
 2280-v4.txt, 2280-v5.txt


 StreamIn.requestRanges only specifies a keyspace, meaning that requesting a 
 range will request it for all column families: if you have a large number of 
 CFs, this can cause quite a headache.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171163 - in /cassandra/branches/cassandra-0.8: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/

2011-09-15 Thread slebresne
Author: slebresne
Date: Thu Sep 15 16:20:59 2011
New Revision: 1171163

URL: http://svn.apache.org/viewvc?rev=1171163view=rev
Log:
merge r1170682 from 1.0.0

Modified:
cassandra/branches/cassandra-0.8/   (props changed)
cassandra/branches/cassandra-0.8/build.xml
cassandra/branches/cassandra-0.8/contrib/   (props changed)

cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
   (props changed)

cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
   (props changed)

cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
   (props changed)

cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
   (props changed)

cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
   (props changed)

Propchange: cassandra/branches/cassandra-0.8/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 16:20:59 2011
@@ -3,6 +3,7 @@
 /cassandra/branches/cassandra-0.7.0:1053690-1055654
 /cassandra/branches/cassandra-0.8:1090934-1125013,1125041
 /cassandra/branches/cassandra-0.8.0:1125021-1130369
+/cassandra/branches/cassandra-1.0.0:1170682
 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020
 /cassandra/trunk:1129049-1129050,1129065,1151625,1152416,1153189

Modified: cassandra/branches/cassandra-0.8/build.xml
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/build.xml?rev=1171163r1=1171162r2=1171163view=diff
==
--- cassandra/branches/cassandra-0.8/build.xml (original)
+++ cassandra/branches/cassandra-0.8/build.xml Thu Sep 15 16:20:59 2011
@@ -313,7 +313,7 @@ url=${svn.entry.url}?pathrev=${svn.entry
 sequential
   artifact:mvn mavenVersion=${maven.version} fork=true 
failonerror=true
 jvmarg value=-Xmx512m/
-arg 
value=org.apache.maven.plugins:maven-gpg-plugin:1.3:sign-and-deploy-file /
+arg 
value=org.apache.maven.plugins:maven-gpg-plugin:1.4:sign-and-deploy-file /
 arg value=-DretryFailedDeploymentCount=5 /
 arg value=-Durl=${maven-repository-url} /
 arg value=-DrepositoryId=${maven-repository-id} /

Propchange: cassandra/branches/cassandra-0.8/contrib/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 16:20:59 2011
@@ -3,6 +3,7 @@
 /cassandra/branches/cassandra-0.7.0/contrib:1053690-1055654
 /cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125041
 /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369
+/cassandra/branches/cassandra-1.0.0/contrib:1170682
 /cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689
 /cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020
 /cassandra/trunk/contrib:1129049-1129050,1129065,1151625,1152416,1153189

Propchange: 
cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 16:20:59 2011
@@ -3,6 +3,7 @@
 
/cassandra/branches/cassandra-0.7.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1053690-1055654
 
/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125041
 
/cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369
+/cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1170682
 
/cassandra/tags/cassandra-0.7.0-rc3/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1051699-1053689
 
/cassandra/tags/cassandra-0.8.0-rc1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1102511-1125020
 
/cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1129049-1129050,1129065,1151625,1152416,1153189

Propchange: 
cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Sep 15 16:20:59 2011
@@ -3,6 +3,7 @@
 
/cassandra/branches/cassandra-0.7.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1053690-1055654
 
/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1090934-1125013,1125041
 
/cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1125021-1130369

[jira] [Commented] (CASSANDRA-2280) Request specific column families using StreamIn

2011-09-15 Thread anand somani (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105493#comment-13105493
 ] 

anand somani commented on CASSANDRA-2280:
-

1.0 might turn out to be late. Is it possible to have this patch on a branch 
for folks who need it to apply this patch to  0.8.2? Also what kind of tests 
(besides the repair) should be done if I apply that patch for a custom build?

 Request specific column families using StreamIn
 ---

 Key: CASSANDRA-2280
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2280
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Stu Hood
Assignee: Jonathan Ellis
 Fix For: 1.0.0

 Attachments: 
 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 
 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 2280-v3.txt, 
 2280-v4.txt, 2280-v5.txt


 StreamIn.requestRanges only specifies a keyspace, meaning that requesting a 
 range will request it for all column families: if you have a large number of 
 CFs, this can cause quite a headache.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171183 - /cassandra/tags/cassandra-1.0.0-beta1/

2011-09-15 Thread slebresne
Author: slebresne
Date: Thu Sep 15 17:23:22 2011
New Revision: 1171183

URL: http://svn.apache.org/viewvc?rev=1171183view=rev
Log:
Creating 1.0.0-beta1 tag

Added:
cassandra/tags/cassandra-1.0.0-beta1/   (props changed)
  - copied from r1170682, cassandra/branches/cassandra-1.0.0/

Propchange: cassandra/tags/cassandra-1.0.0-beta1/
--
--- svn:ignore (added)
+++ svn:ignore Thu Sep 15 17:23:22 2011
@@ -0,0 +1,8 @@
+.classpath
+.project
+.settings
+temp-testng-customsuite.xml
+build
+build.properties
+.idea
+out

Propchange: cassandra/tags/cassandra-1.0.0-beta1/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Thu Sep 15 17:23:22 2011
@@ -0,0 +1,12 @@
+/cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291
+/cassandra/branches/cassandra-0.7:1026516-1170333
+/cassandra/branches/cassandra-0.7.0:1053690-1055654
+/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1170335
+/cassandra/branches/cassandra-0.8.0:1125021-1130369
+/cassandra/branches/cassandra-0.8.1:1101014-1125018
+/cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
+/cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020
+/incubator/cassandra/branches/cassandra-0.3:774578-796573
+/incubator/cassandra/branches/cassandra-0.4:810145-834239,834349-834350
+/incubator/cassandra/branches/cassandra-0.5:72-915439
+/incubator/cassandra/branches/cassandra-0.6:911237-922688




svn commit: r1171199 - in /cassandra/site: publish/download/index.html src/settings.py

2011-09-15 Thread slebresne
Author: slebresne
Date: Thu Sep 15 17:58:32 2011
New Revision: 1171199

URL: http://svn.apache.org/viewvc?rev=1171199view=rev
Log:
Update site for 1.0.0-beta1 release

Modified:
cassandra/site/publish/download/index.html
cassandra/site/src/settings.py

Modified: cassandra/site/publish/download/index.html
URL: 
http://svn.apache.org/viewvc/cassandra/site/publish/download/index.html?rev=1171199r1=1171198r2=1171199view=diff
==
--- cassandra/site/publish/download/index.html (original)
+++ cassandra/site/publish/download/index.html Thu Sep 15 17:58:32 2011
@@ -102,6 +102,26 @@
   /ul 
 
   
+  p
+  The latest development release is 1.0.0-beta1 (released on
+  2011-09-15).
+  /p
+
+  ul
+li
+a class=filename 
href=http://www.apache.org/dyn/closer.cgi?path=/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-bin.tar.gz;apache-cassandra-1.0.0-beta1-bin.tar.gz/a
+[a 
href=http://www.apache.org/dist/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-bin.tar.gz.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-bin.tar.gz.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-bin.tar.gz.sha;SHA1/a]
+/li
+li
+a class=filename 
href=http://www.apache.org/dyn/closer.cgi?path=/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-src.tar.gz;apache-cassandra-1.0.0-beta1-src.tar.gz/a
+[a 
href=http://www.apache.org/dist/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-src.tar.gz.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-src.tar.gz.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/cassandra/1.0.0/apache-cassandra-1.0.0-beta1-src.tar.gz.sha;SHA1/a]
+/li
+  /ul
+  
 
   h3 class=hdrCQL Drivers/h3
   p

Modified: cassandra/site/src/settings.py
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/settings.py?rev=1171199r1=1171198r2=1171199view=diff
==
--- cassandra/site/src/settings.py (original)
+++ cassandra/site/src/settings.py Thu Sep 15 17:58:32 2011
@@ -97,9 +97,9 @@ class CassandraDef(object):
 oldstable_exists = True
 stable_version = '0.8.5'
 stable_release_date = '2011-09-08'
-devel_version = '0.8.0-rc1'
-devel_release_date = '2011-05-17'
-devel_exists = False
+devel_version = '1.0.0-beta1'
+devel_release_date = '2011-09-15'
+devel_exists = True
 _apache_base_url = 'http://www.apache.org'
 _svn_base_url = 'https://svn.apache.org/repos/asf'
 _apache_path = 'cassandra'




[jira] [Created] (CASSANDRA-3214) Make CFIF use rpc_endpoint prior to trying endpoint

2011-09-15 Thread Eldon Stegall (JIRA)
Make CFIF use rpc_endpoint prior to trying endpoint
---

 Key: CASSANDRA-3214
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3214
 Project: Cassandra
  Issue Type: Improvement
  Components: Hadoop
Affects Versions: 0.8.6, 1.0.0
 Environment: Hadoop 0.20 / Cassandra 0.8.5 / Ubuntu 10.04 / 
Reporter: Eldon Stegall
Priority: Minor


Following up on CASSANDRA-3187 , we probably need to attempt to use the 
rpc_endpoint address first, and then fall back to the gossip endpoint if we 
don't get what we want.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105627#comment-13105627
 ] 

Jason Harvey commented on CASSANDRA-2170:
-

Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian. I replicated the issue on a 
coordinator which only owned 1 token.

 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105629#comment-13105629
 ] 

Jason Harvey commented on CASSANDRA-2170:
-

Clarification: Debian Squeeze

 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171248 - /cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java

2011-09-15 Thread jbellis
Author: jbellis
Date: Thu Sep 15 19:54:24 2011
New Revision: 1171248

URL: http://svn.apache.org/viewvc?rev=1171248view=rev
Log:
clean up duplicate code
patch by jbellis

Modified:

cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java

Modified: 
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java?rev=1171248r1=1171247r2=1171248view=diff
==
--- 
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java
 (original)
+++ 
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java
 Thu Sep 15 19:54:24 2011
@@ -100,9 +100,7 @@ public class CommitLogSegment
 long currentPosition = -1L;
 try
 {
-currentPosition = logWriter.getFilePointer();
-assert currentPosition = Integer.MAX_VALUE;
-ReplayPosition cLogCtx = new ReplayPosition(id, (int) 
currentPosition);
+ReplayPosition cLogCtx = getContext();
 
 for (ColumnFamily columnFamily : rowMutation.getColumnFamilies())
 {




[jira] [Commented] (CASSANDRA-3025) PHP/PDO driver for Cassandra CQL

2011-09-15 Thread Mikko Koppanen (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105642#comment-13105642
 ] 

Mikko Koppanen commented on CASSANDRA-3025:
---

Hello,

pushed the code: 
http://code.google.com/a/apache-extras.org/p/cassandra-pdo/source/browse/. I 
hope there will be some real-world usage feedback to iron out possible bugs 
that are not covered by the tests.

 PHP/PDO driver for Cassandra CQL
 

 Key: CASSANDRA-3025
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3025
 Project: Cassandra
  Issue Type: New Feature
  Components: API
Reporter: Mikko Koppanen
  Labels: php
 Attachments: pdo_cassandra-0.1.0.tgz, pdo_cassandra-0.1.1.tgz, 
 pdo_cassandra-0.1.2.tgz, pdo_cassandra-0.1.3.tgz, pdo_cassandra-0.2.0.tgz, 
 pdo_cassandra-0.2.1.tgz, php_test_results_20110818_2317.txt


 Hello,
 attached is the initial version of the PDO driver for Cassandra CQL language. 
 This is a native PHP extension written in what I would call a combination of 
 C and C++, due to PHP being C. The thrift API used is the C++.
 The API looks roughly following:
 {code}
 ?php
 $db = new PDO('cassandra:host=127.0.0.1;port=9160');
 $db-exec (CREATE KEYSPACE mytest with strategy_class = 'SimpleStrategy' and 
 strategy_options:replication_factor=1;);
 $db-exec (USE mytest);
 $db-exec (CREATE COLUMNFAMILY users (
   my_key varchar PRIMARY KEY,
   full_name varchar ););
   
 $stmt = $db-prepare (INSERT INTO users (my_key, full_name) VALUES (:key, 
 :full_name););
 $stmt-execute (array (':key' = 'mikko', ':full_name' = 'Mikko K' ));
 {code}
 Currently prepared statements are emulated on the client side but I 
 understand that there is a plan to add prepared statements to Cassandra CQL 
 API as well. I will add this feature in to the extension as soon as they are 
 implemented.
 Additional documentation can be found in github 
 https://github.com/mkoppanen/php-pdo_cassandra, in the form of rendered 
 MarkDown file. Tests are currently not included in the package file and they 
 can be found in the github for now as well.
 I have created documentation in docbook format as well, but have not yet 
 rendered it.
 Comments and feedback are welcome.
 Thanks,
 Mikko

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-3201) When a mmap fails, Cassandra should exit.

2011-09-15 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-3201:
--

Attachment: 3201-v2.txt

v2 checks the exception chain in the uncaught exception handler instead of 
doing a one-off just for FC.map

 When a mmap fails, Cassandra should exit.
 -

 Key: CASSANDRA-3201
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3201
 Project: Cassandra
  Issue Type: Improvement
 Environment: Ubuntu 10.04.2/sun-java6-jdk 6.24-1build0.10.04.1
Reporter: Eldon Stegall
Priority: Minor
 Attachments: 3201-v2.txt, 3201.txt


 When a mmap fails, Cassandra should exit. See 
 https://wiki.apache.org/cassandra/ArchitectureInternals#line-60
 Here is an example stack trace:
 ERROR 17:11:36,258 Fatal exception in thread Thread[FlushWriter:2003,5,main]
 java.io.IOError: java.io.IOException: Map failed
 at 
 org.apache.cassandra.io.util.MmappedSegmentedFile$Builder.createSegments(MmappedSegmentedFile.java:170)
 at 
 org.apache.cassandra.io.util.MmappedSegmentedFile$Builder.complete(MmappedSegmentedFile.java:147)
 at 
 org.apache.cassandra.io.sstable.SSTableWriter.closeAndOpenReader(SSTableWriter.java:194)
 at 
 org.apache.cassandra.io.sstable.SSTableWriter.closeAndOpenReader(SSTableWriter.java:173)
 at 
 org.apache.cassandra.db.Memtable.writeSortedContents(Memtable.java:253)
 at org.apache.cassandra.db.Memtable.access$400(Memtable.java:49)
 at org.apache.cassandra.db.Memtable$3.runMayThrow(Memtable.java:270)
 at 
 org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.IOException: Map failed
 at sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:748)
 at 
 org.apache.cassandra.io.util.MmappedSegmentedFile$Builder.createSegments(MmappedSegmentedFile.java:162)
 ... 10 more
 Caused by: java.lang.OutOfMemoryError: Map failed
 at sun.nio.ch.FileChannelImpl.map0(Native Method)
 at sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:745)
 ... 11 more

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3085) Race condition in sstable reference counting

2011-09-15 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105646#comment-13105646
 ] 

Jonathan Ellis commented on CASSANDRA-3085:
---

bq. since every path (either compaction or reader) does one +1 and one -1

Not so -- you're missing the this sstable is compacted and is obsolete 
release done by DataTracker.

 Race condition in sstable reference counting
 

 Key: CASSANDRA-3085
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3085
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Critical
 Fix For: 1.0.0

 Attachments: 3085-v2.txt, 3085.txt


 DataTracker gives us an atomic View of memtable/sstables, but acquiring 
 references is not atomic.  So it is possible to acquire references to an 
 SSTableReader object that is no longer valid, as in this example:
 View V contains sstables {A, B}.  We attempt a read in thread T using this 
 View.
 Meanwhile, A and B are compacted to {C}, yielding View W.  No references 
 exist to A or B so they are cleaned up.
 Back in thread T we acquire references to A and B.  This does not cause an 
 error, but it will when we attempt to read from them next.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3114) After Choosing EC2Snitch you can't migrate off w/o a full cluster restart

2011-09-15 Thread Jackson Chung (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105768#comment-13105768
 ] 

Jackson Chung commented on CASSANDRA-3114:
--

I don't see how making your dc/rack names your external IP address is going to 
solve anything.

well the NPE was on 
{code}
return 
Gossiper.instance.getEndpointStateForEndpoint(endpoint).getApplicationState(ApplicationState.DC).value;
{code}

the given endpoint is not the local address; its the address from other 
nodes. For those other nodes, if they are not using the Ec2Snitch, which 
would have populated the ApplicationState.DC and ApplicationState.RACK with 
the values, getApplicationState(ApplicationState.DC) (and 
).getApplicationState(ApplicationState.RACK) for that matter) is going to be 
return null. Hence you got a NPE from that line on .value.

Defaulting the AbstractEndpointSnitch's gossiperStarting by populating the 
ApplicationState.DC,ApplicationState.RACK wll help then any snitch relying the 
gossip info to getDC and getRack.


 After Choosing EC2Snitch you can't migrate off w/o a full cluster restart
 -

 Key: CASSANDRA-3114
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3114
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.7.8, 0.8.4
Reporter: Benjamin Coverston

 Once you choose the Ec2Snitch the gossip messages will trigger this exception 
 if you try to move (for example) to the property file snitch:
 ERROR [pool-2-thread-11] 2011-08-30 16:38:06,935 Cassandra.java (line 3041) 
 Internal error processing get_slice 
 java.lang.NullPointerException 
 at org.apache.cassandra.locator.Ec2Snitch.getDatacenter(Ec2Snitch.java:84) 
 at 
 org.apache.cassandra.locator.DynamicEndpointSnitch.getDatacenter(DynamicEndpointSnitch.java:122)
  
 at 
 org.apache.cassandra.service.DatacenterReadCallback.assureSufficientLiveNodes(DatacenterReadCallback.java:77)
  
 at org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:516) 
 at org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:480) 
 at 
 org.apache.cassandra.thrift.CassandraServer.readColumnFamily(CassandraServer.java:109)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.getSlice(CassandraServer.java:263)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.multigetSliceInternal(CassandraServer.java:345)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.get_slice(CassandraServer.java:306)
  
 at 
 org.apache.cassandra.thrift.Cassandra$Processor$get_slice.process(Cassandra.java:3033)
  
 at 
 org.apache.cassandra.thrift.Cassandra$Processor.process(Cassandra.java:2889) 
 at 
 org.apache.cassandra.thrift.CustomTThreadPoolServer$WorkerProcess.run(CustomTThreadPoolServer.java:187)
  
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
  
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
  
 at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (CASSANDRA-3114) After Choosing EC2Snitch you can't migrate off w/o a full cluster restart

2011-09-15 Thread Jackson Chung (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105768#comment-13105768
 ] 

Jackson Chung edited comment on CASSANDRA-3114 at 9/15/11 11:32 PM:


I don't see how making your dc/rack names your external IP address is going to 
solve anything.

well the NPE was on 
{code}
return 
Gossiper.instance.getEndpointStateForEndpoint(endpoint).getApplicationState(ApplicationState.DC).value;
{code}

the given endpoint is not the local address; its the address from other 
nodes. For those other nodes, if they are not using the Ec2Snitch, which 
would have populated the ApplicationState.DC and ApplicationState.RACK with 
the values, getApplicationState(ApplicationState.DC) (and 
getApplicationState(ApplicationState.RACK) for that matter) is going to be 
return null. Hence you got a NPE from that line on .value.

Defaulting the AbstractEndpointSnitch's gossiperStarting by populating the 
ApplicationState.DC,ApplicationState.RACK wll help then any snitch relying the 
gossip info to getDC and getRack.


  was (Author: cywjackson):
I don't see how making your dc/rack names your external IP address is 
going to solve anything.

well the NPE was on 
{code}
return 
Gossiper.instance.getEndpointStateForEndpoint(endpoint).getApplicationState(ApplicationState.DC).value;
{code}

the given endpoint is not the local address; its the address from other 
nodes. For those other nodes, if they are not using the Ec2Snitch, which 
would have populated the ApplicationState.DC and ApplicationState.RACK with 
the values, getApplicationState(ApplicationState.DC) (and 
).getApplicationState(ApplicationState.RACK) for that matter) is going to be 
return null. Hence you got a NPE from that line on .value.

Defaulting the AbstractEndpointSnitch's gossiperStarting by populating the 
ApplicationState.DC,ApplicationState.RACK wll help then any snitch relying the 
gossip info to getDC and getRack.

  
 After Choosing EC2Snitch you can't migrate off w/o a full cluster restart
 -

 Key: CASSANDRA-3114
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3114
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.7.8, 0.8.4
Reporter: Benjamin Coverston

 Once you choose the Ec2Snitch the gossip messages will trigger this exception 
 if you try to move (for example) to the property file snitch:
 ERROR [pool-2-thread-11] 2011-08-30 16:38:06,935 Cassandra.java (line 3041) 
 Internal error processing get_slice 
 java.lang.NullPointerException 
 at org.apache.cassandra.locator.Ec2Snitch.getDatacenter(Ec2Snitch.java:84) 
 at 
 org.apache.cassandra.locator.DynamicEndpointSnitch.getDatacenter(DynamicEndpointSnitch.java:122)
  
 at 
 org.apache.cassandra.service.DatacenterReadCallback.assureSufficientLiveNodes(DatacenterReadCallback.java:77)
  
 at org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:516) 
 at org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:480) 
 at 
 org.apache.cassandra.thrift.CassandraServer.readColumnFamily(CassandraServer.java:109)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.getSlice(CassandraServer.java:263)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.multigetSliceInternal(CassandraServer.java:345)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.get_slice(CassandraServer.java:306)
  
 at 
 org.apache.cassandra.thrift.Cassandra$Processor$get_slice.process(Cassandra.java:3033)
  
 at 
 org.apache.cassandra.thrift.Cassandra$Processor.process(Cassandra.java:2889) 
 at 
 org.apache.cassandra.thrift.CustomTThreadPoolServer$WorkerProcess.run(CustomTThreadPoolServer.java:187)
  
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
  
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
  
 at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105790#comment-13105790
 ] 

Jason Harvey commented on CASSANDRA-2170:
-

I should note, the symptoms I'm seeing are basically identical to #2054

 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105627#comment-13105627
 ] 

Jason Harvey edited comment on CASSANDRA-2170 at 9/16/11 12:27 AM:
---

Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian. I replicated the issue on a 
coordinator which only owned 1 token.

The node I'm replicating it on now is at a load of 0 almost all of the time, 
except during the spikes.

  was (Author: alienth):
Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian. I replicated the issue on a 
coordinator which only owned 1 token.
  
 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105627#comment-13105627
 ] 

Jason Harvey edited comment on CASSANDRA-2170 at 9/16/11 12:27 AM:
---

Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian Squeeze. I replicated the 
issue on a coordinator which only owned 1 token.

The node I'm replicating it on now is at a load of 0 almost all of the time, 
except during the spikes.

  was (Author: alienth):
Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian. I replicated the issue on a 
coordinator which only owned 1 token.

The node I'm replicating it on now is at a load of 0 almost all of the time, 
except during the spikes.
  
 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105627#comment-13105627
 ] 

Jason Harvey edited comment on CASSANDRA-2170 at 9/16/11 12:28 AM:
---

Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian Squeeze. I replicated the 
issue on a coordinator which only owned 1 token.

The node I'm replicating it on now is at a load of 0 almost all of the time, 
except during the spikes.

The symptoms continue to appear identical to #2054

  was (Author: alienth):
Tried without jsvc, same result.

This problem is also consistent on 0.8.5 on Debian Squeeze. I replicated the 
issue on a coordinator which only owned 1 token.

The node I'm replicating it on now is at a load of 0 almost all of the time, 
except during the spikes.
  
 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Harvey updated CASSANDRA-2170:


Comment: was deleted

(was: Clarification: Debian Squeeze)

 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2170) Load spikes

2011-09-15 Thread Jason Harvey (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Harvey updated CASSANDRA-2170:


Comment: was deleted

(was: I should note, the symptoms I'm seeing are basically identical to #2054)

 Load spikes
 ---

 Key: CASSANDRA-2170
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2170
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.6.11
Reporter: Jonathan Ellis
Assignee: Brandon Williams

 as reported on CASSANDRA-2058, some users are still seeing load spikes on 
 0.6.11, even with fairly low-volume read workloads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3114) After Choosing EC2Snitch you can't migrate off w/o a full cluster restart

2011-09-15 Thread Brandon Williams (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105814#comment-13105814
 ] 

Brandon Williams commented on CASSANDRA-3114:
-

bq. Defaulting the AbstractEndpointSnitch's gossiperStarting by populating the 
ApplicationState.DC,ApplicationState.RACK wll help then any snitch relying the 
gossip info to getDC and getRack.

Yes, but setting DC to 'foo' and rack to 'bar' just creates a new DC and rack 
and breaks the replication policy and consistency guarantees.

 After Choosing EC2Snitch you can't migrate off w/o a full cluster restart
 -

 Key: CASSANDRA-3114
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3114
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.7.8, 0.8.4
Reporter: Benjamin Coverston

 Once you choose the Ec2Snitch the gossip messages will trigger this exception 
 if you try to move (for example) to the property file snitch:
 ERROR [pool-2-thread-11] 2011-08-30 16:38:06,935 Cassandra.java (line 3041) 
 Internal error processing get_slice 
 java.lang.NullPointerException 
 at org.apache.cassandra.locator.Ec2Snitch.getDatacenter(Ec2Snitch.java:84) 
 at 
 org.apache.cassandra.locator.DynamicEndpointSnitch.getDatacenter(DynamicEndpointSnitch.java:122)
  
 at 
 org.apache.cassandra.service.DatacenterReadCallback.assureSufficientLiveNodes(DatacenterReadCallback.java:77)
  
 at org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:516) 
 at org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:480) 
 at 
 org.apache.cassandra.thrift.CassandraServer.readColumnFamily(CassandraServer.java:109)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.getSlice(CassandraServer.java:263)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.multigetSliceInternal(CassandraServer.java:345)
  
 at 
 org.apache.cassandra.thrift.CassandraServer.get_slice(CassandraServer.java:306)
  
 at 
 org.apache.cassandra.thrift.Cassandra$Processor$get_slice.process(Cassandra.java:3033)
  
 at 
 org.apache.cassandra.thrift.Cassandra$Processor.process(Cassandra.java:2889) 
 at 
 org.apache.cassandra.thrift.CustomTThreadPoolServer$WorkerProcess.run(CustomTThreadPoolServer.java:187)
  
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
  
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
  
 at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1171387 - /cassandra/branches/cassandra-1.0.0/CHANGES.txt

2011-09-15 Thread jbellis
Author: jbellis
Date: Fri Sep 16 04:51:52 2011
New Revision: 1171387

URL: http://svn.apache.org/viewvc?rev=1171387view=rev
Log:
update CHANGES

Modified:
cassandra/branches/cassandra-1.0.0/CHANGES.txt

Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1171387r1=1171386r2=1171387view=diff
==
--- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Fri Sep 16 04:51:52 2011
@@ -80,6 +80,7 @@
(CASSANDRA-3181)
  * Reduce copies done for intra-host messages (CASSANDRA-1788, 3144)
  * support of compaction strategy option for stress.java (CASSANDRA-3204)
+ * make memtable throughput and column count thresholds no-ops (CASSANDRA-2449)
 
 
 0.8.6




[jira] [Updated] (CASSANDRA-3207) Log message at INFO when a global or keyspace level repair operation completes

2011-09-15 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-3207:
--

 Priority: Minor  (was: Major)
Fix Version/s: 0.8.6
 Assignee: Sylvain Lebresne

 Log message at INFO when a global or keyspace level repair operation completes
 --

 Key: CASSANDRA-3207
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3207
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.8.5
Reporter: Benjamin Coverston
Assignee: Sylvain Lebresne
Priority: Minor
  Labels: logging, repair
 Fix For: 0.8.6


 If JMX times out it's difficult to tell when repair completes.Right now we 
 log at DEBUG for each column family but we need a way to tell when the repair 
 operation completes as a whole.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (CASSANDRA-3133) nodetool netstats doesn't show streams during decommission

2011-09-15 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3133.
---

Resolution: Cannot Reproduce
  Assignee: (was: Brandon Williams)

 nodetool netstats doesn't show streams during decommission
 --

 Key: CASSANDRA-3133
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3133
 Project: Cassandra
  Issue Type: Bug
  Components: Tools
Affects Versions: 0.8.4
 Environment: debian 6.0.2.1 (squeeze), java 1.6.26 (sun, non-free 
 packages).
Reporter: Zenek Kraweznik

 nodetool netstats is now showing transferred files from demonission

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3203) Odd flush behavior

2011-09-15 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105859#comment-13105859
 ] 

Jonathan Ellis commented on CASSANDRA-3203:
---

If MeteredFlusher + getLiveSize were really doing their job right though, the 
pressure valve wouldn't be getting involved.  (However, I'm not sure it's 
entirely fair to tell it you can have 1/3 of the heap and then fill up more 
than 2/3 w/ BF + index.)

I think I'd like to hold off on further tweaking until after 1.0; the current 
fudge factor means we're erring on the side of extra safety, and I'm okay with 
that (especially since, as you noted, leveled compaction isn't very sensitive 
to initial flush size).

 Odd flush behavior
 --

 Key: CASSANDRA-3203
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3203
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.0
Reporter: Brandon Williams
Assignee: Jonathan Ellis
Priority: Critical
 Fix For: 1.0.0

 Attachments: 3203-prelim.txt, 3203-v2.txt, 3203.png


 Given the same workload against 0.8, trunk is creating more than twice the 
 amount of sstables.  Even though a uniform stress workload is being 
 generated, flush size degrades quickly:
 {noformat}
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:22,878 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@2058235391(7741
 035/110172631 serialized/live bytes, 151785 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:24,888 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@1520390052(3887
 220/72403158 serialized/live bytes, 76220 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:26,890 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@1868496516(4097
 085/76255481 serialized/live bytes, 80335 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:28,893 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@498232521(43513
 20/80922269 serialized/live bytes, 85320 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:29,895 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@1592308290(2310
 810/44514839 serialized/live bytes, 45310 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:30,897 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@775439677(22684
 80/64984390 serialized/live bytes, 44480 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:31,899 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@928217914(26741
 85/76231422 serialized/live bytes, 52435 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:32,901 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@158103119(27511
 95/77317732 serialized/live bytes, 53945 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:33,903 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@2035169258(3132
 420/88934701 serialized/live bytes, 61420 ops)
  INFO [NonPeriodicTasks:1] 2011-09-09 18:24:34,905 ColumnFamilyStore.java 
 (line 658) Enqueuing flush of Memtable-Standard1@1097314626(2979
 675/83651699 serialized/live bytes, 58425 ops)
 {noformat}
 The serialized to live size ratio appears completely out of whack.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira