[jira] [Commented] (CASSANDRA-11200) CompactionExecutor thread error brings down JVM in 3.0.3

2017-06-21 Thread Kurt Greaves (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058687#comment-16058687
 ] 

Kurt Greaves commented on CASSANDRA-11200:
--

[~blerer] Can't say I've seen the issue again and unfortunately wasn't able to 
reproduce it (although I didn't have time to try that hard). I think you're 
correct that this is safe to close, I certainly would have seen it in a later 
version if it was still a problem.

> CompactionExecutor thread error brings down JVM in 3.0.3
> 
>
> Key: CASSANDRA-11200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11200
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: debian jesse latest release, updated Feb. 20th
>Reporter: Jason Kania
>Assignee: Benjamin Lerer
>Priority: Critical
>
> When launching Cassandra 3.0.3, with java version "1.8.0_74", Cassandra 
> writes the following to the debug file before a segmentation fault occurs 
> bringing down the JVM - the problem is repeatable.
> DEBUG [CompactionExecutor:1] 2016-02-20 18:26:16,892 CompactionTask.java:146 
> - Compacting (56f677c0-d829-11e5-b23a-25dbd4d727f6) 
> [/var/lib/cassandra/data/sensordb/periodicReading/ma-367-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-368-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-371-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-370-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-369-big-Data.db:level=0, ]
> The JVM error that occurs is the following:
> \#
> \# A fatal error has been detected by the Java Runtime Environment:
> \#
> \#  SIGBUS (0x7) at pc=0x7fa8a1052150, pid=12179, tid=140361951868672
> \#
> \# JRE version: Java(TM) SE Runtime Environment (8.0_74-b02) (build 
> 1.8.0_74-b02)
> \# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.74-b02 mixed mode 
> linux-amd64 compressed oops)
> \# Problematic frame:
> \# v  ~StubRoutines::jbyte_disjoint_arraycopy
> \#
> \# Core dump written. Default location: /tmp/core or core.12179
> \#
> \# If you would like to submit a bug report, please visit:
> \#   http://bugreport.java.com/bugreport/crash.jsp
> \#
> ---  T H R E A D  ---
> Current thread (0x7fa89c56ac20):  JavaThread "CompactionExecutor:1" 
> daemon [_thread_in_Java, id=12323, 
> stack(0x7fa89043f000,0x7fa89048)]
> siginfo: si_signo: 7 (SIGBUS), si_code: 2 (BUS_ADRERR), si_addr: 
> 0x7fa838988002
> Even if all of the files associated with "ma-[NNN]*" are removed, the JVM 
> dies with the same error after the next group of "ma-[NNN]*" are eventually 
> written out and compacted.
> Though this may be strictly a JVM problem, I have seen the issue in Oracle 
> JVM 8.0_65 and 8.0_74 and I raise it in case this problem is due to JNI usage 
> of an external compression library or some direct memory usage.
> I have a core dump if that is helpful to anyone.
> Bug CASSANDRA-11201 may also be related although when the exception 
> referenced in the bug occurs, the JVM remains alive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13568) nodetool listsnapshots output is missing a newline, if there are no snapshots

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13568:
---
   Resolution: Fixed
Fix Version/s: 4.0
   3.11.1
   3.0.15
   Status: Resolved  (was: Ready to Commit)

Actually [~mshuler] gave me the go-ahead to commit now, so it's committed to 
3.0 as {{96bd3d53637d95ce268e7d4521a62bb400bc161b}} and merged up.


> nodetool listsnapshots output is missing a newline, if there are no snapshots
> -
>
> Key: CASSANDRA-13568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13568
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Arnd Hannemann
>Assignee: Arnd Hannemann
>Priority: Trivial
> Fix For: 3.0.15, 3.11.1, 4.0
>
> Attachments: 
> 0001-CASSANDRA-13568-add-newline-to-output-if-there-are-n.patch
>
>
> When there are no snapshots, the nodetool listsnaphots command output is 
> missing a newline, which gives a somewhat bad user experience:
> {code}
> root@cassandra2:~# nodetool listsnapshots
> Snapshot Details: 
> There are no snapshotsroot@cassandra2:~# 
> {code}
> I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[4/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/56c8f0c5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/56c8f0c5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/56c8f0c5

Branch: refs/heads/trunk
Commit: 56c8f0c5861a815a7b4690744402b3a1e11398f0
Parents: 903da08 96bd3d5
Author: Jeff Jirsa 
Authored: Wed Jun 21 19:15:13 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 19:15:51 2017 -0700

--
 CHANGES.txt | 5 +
 src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/56c8f0c5/CHANGES.txt
--
diff --cc CHANGES.txt
index 087f2cf,00e87bf..6f2d509
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,42 -1,8 +1,47 @@@
 -3.0.15
++3.11.1
++Merged from 3.0:
+  * Nodetool listsnapshots output is missing a newline, if there are no 
snapshots (CASSANDRA-13568)
+ 
+ 
 -3.0.14
 +3.11.0
 + * Replace string comparison with regex/number checks in MessagingService 
test (CASSANDRA-13216)
 + * Fix formatting of duration columns in CQLSH (CASSANDRA-13549)
 + * Fix the problem with duplicated rows when using paging with SASI 
(CASSANDRA-13302)
 + * Allow CONTAINS statements filtering on the partition key and it’s parts 
(CASSANDRA-13275)
 + * Fall back to even ranges calculation in clusters with vnodes when tokens 
are distributed unevenly (CASSANDRA-13229)
 + * Fix duration type validation to prevent overflow (CASSANDRA-13218)
 + * Forbid unsupported creation of SASI indexes over partition key columns 
(CASSANDRA-13228)
 + * Reject multiple values for a key in CQL grammar. (CASSANDRA-13369)
 + * UDA fails without input rows (CASSANDRA-13399)
 + * Fix compaction-stress by using daemonInitialization (CASSANDRA-13188)
 + * V5 protocol flags decoding broken (CASSANDRA-13443)
 + * Use write lock not read lock for removing sstables from compaction 
strategies. (CASSANDRA-13422)
 + * Use corePoolSize equal to maxPoolSize in JMXEnabledThreadPoolExecutors 
(CASSANDRA-13329)
 + * Avoid rebuilding SASI indexes containing no values (CASSANDRA-12962)
 + * Add charset to Analyser input stream (CASSANDRA-13151)
 + * Fix testLimitSSTables flake caused by concurrent flush (CASSANDRA-12820)
 + * cdc column addition strikes again (CASSANDRA-13382)
 + * Fix static column indexes (CASSANDRA-13277)
 + * DataOutputBuffer.asNewBuffer broken (CASSANDRA-13298)
 + * unittest CipherFactoryTest failed on MacOS (CASSANDRA-13370)
 + * Forbid SELECT restrictions and CREATE INDEX over non-frozen UDT columns 
(CASSANDRA-13247)
 + * Default logging we ship will incorrectly print "?:?" for "%F:%L" pattern 
(CASSANDRA-13317)
 + * Possible AssertionError in UnfilteredRowIteratorWithLowerBound 
(CASSANDRA-13366)
 + * Support unaligned memory access for AArch64 (CASSANDRA-13326)
 + * Improve SASI range iterator efficiency on intersection with an empty range 
(CASSANDRA-12915).
 + * Fix equality comparisons of columns using the duration type 
(CASSANDRA-13174)
 + * Obfuscate password in stress-graphs (CASSANDRA-12233)
 + * Move to FastThreadLocalThread and FastThreadLocal (CASSANDRA-13034)
 + * nodetool stopdaemon errors out (CASSANDRA-13030)
 + * Tables in system_distributed should not use gcgs of 0 (CASSANDRA-12954)
 + * Fix primary index calculation for SASI (CASSANDRA-12910)
 + * More fixes to the TokenAllocator (CASSANDRA-12990)
 + * NoReplicationTokenAllocator should work with zero replication factor 
(CASSANDRA-12983)
 + * Address message coalescing regression (CASSANDRA-12676)
 + * Delete illegal character from StandardTokenizerImpl.jflex (CASSANDRA-13417)
 + * Fix cqlsh automatic protocol downgrade regression (CASSANDRA-13307)
 + * Tracing payload not passed from QueryMessage to tracing session 
(CASSANDRA-12835)
 +Merged from 3.0:
   * Ensure int overflow doesn't occur when calculating large partition warning 
size (CASSANDRA-13172)
   * Ensure consistent view of partition columns between coordinator and 
replica in ColumnFilter (CASSANDRA-13004)
   * Failed unregistering mbean during drop keyspace (CASSANDRA-13346)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/56c8f0c5/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
--


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[1/6] cassandra git commit: Add newline to output if there are no snapshots

2017-06-21 Thread jjirsa 
Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.0 960e16b89 -> 96bd3d536
  refs/heads/cassandra-3.11 903da089f -> 56c8f0c58
  refs/heads/trunk de009a393 -> a1c6a623a


Add newline to output if there are no snapshots

Patch by Arnd Hannemann; Reviewed by Jeff Jirsa for CASSANDRA-13568


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/96bd3d53
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/96bd3d53
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/96bd3d53

Branch: refs/heads/cassandra-3.0
Commit: 96bd3d53637d95ce268e7d4521a62bb400bc161b
Parents: 960e16b
Author: Arnd Hannemann 
Authored: Thu Jun 1 10:34:52 2017 +0200
Committer: Jeff Jirsa 
Committed: Wed Jun 21 19:13:25 2017 -0700

--
 CHANGES.txt | 4 
 src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/96bd3d53/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8791ff0..00e87bf 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+3.0.15
+ * Nodetool listsnapshots output is missing a newline, if there are no 
snapshots (CASSANDRA-13568)
+
+
 3.0.14
  * Ensure int overflow doesn't occur when calculating large partition warning 
size (CASSANDRA-13172)
  * Ensure consistent view of partition columns between coordinator and replica 
in ColumnFilter (CASSANDRA-13004)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/96bd3d53/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
--
diff --git a/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java 
b/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
index ee7bf34..798fb71 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
@@ -42,7 +42,7 @@ public class ListSnapshots extends NodeToolCmd
 final Map snapshotDetails = 
probe.getSnapshotDetails();
 if (snapshotDetails.isEmpty())
 {
-System.out.printf("There are no snapshots");
+System.out.println("There are no snapshots");
 return;
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[2/6] cassandra git commit: Add newline to output if there are no snapshots

2017-06-21 Thread jjirsa 
Add newline to output if there are no snapshots

Patch by Arnd Hannemann; Reviewed by Jeff Jirsa for CASSANDRA-13568


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/96bd3d53
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/96bd3d53
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/96bd3d53

Branch: refs/heads/cassandra-3.11
Commit: 96bd3d53637d95ce268e7d4521a62bb400bc161b
Parents: 960e16b
Author: Arnd Hannemann 
Authored: Thu Jun 1 10:34:52 2017 +0200
Committer: Jeff Jirsa 
Committed: Wed Jun 21 19:13:25 2017 -0700

--
 CHANGES.txt | 4 
 src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/96bd3d53/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8791ff0..00e87bf 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+3.0.15
+ * Nodetool listsnapshots output is missing a newline, if there are no 
snapshots (CASSANDRA-13568)
+
+
 3.0.14
  * Ensure int overflow doesn't occur when calculating large partition warning 
size (CASSANDRA-13172)
  * Ensure consistent view of partition columns between coordinator and replica 
in ColumnFilter (CASSANDRA-13004)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/96bd3d53/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
--
diff --git a/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java 
b/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
index ee7bf34..798fb71 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
@@ -42,7 +42,7 @@ public class ListSnapshots extends NodeToolCmd
 final Map snapshotDetails = 
probe.getSnapshotDetails();
 if (snapshotDetails.isEmpty())
 {
-System.out.printf("There are no snapshots");
+System.out.println("There are no snapshots");
 return;
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[6/6] cassandra git commit: Merge branch 'cassandra-3.11' into trunk

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-3.11' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/a1c6a623
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/a1c6a623
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/a1c6a623

Branch: refs/heads/trunk
Commit: a1c6a623a6ac96409069e4f86fddfc2942ec59af
Parents: de009a3 56c8f0c
Author: Jeff Jirsa 
Authored: Wed Jun 21 19:16:03 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 19:16:51 2017 -0700

--
 CHANGES.txt | 5 +
 src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/a1c6a623/CHANGES.txt
--
diff --cc CHANGES.txt
index cc1bdb2,6f2d509..82a0bda
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,85 -1,8 +1,90 @@@
 +4.0
 + * Improve calculation of available disk space for compaction 
(CASSANDRA-13068)
 + * Change the accessibility of RowCacheSerializer for third party row cache 
plugins (CASSANDRA-13579)
 + * Allow sub-range repairs for a preview of repaired data (CASSANDRA-13570)
 + * NPE in IR cleanup when columnfamily has no sstables (CASSANDRA-13585)
 + * Fix Randomness of stress values (CASSANDRA-12744)
 + * Allow selecting Map values and Set elements (CASSANDRA-7396)
 + * Fast and garbage-free Streaming Histogram (CASSANDRA-13444)
 + * Update repairTime for keyspaces on completion (CASSANDRA-13539)
 + * Add configurable upper bound for validation executor threads 
(CASSANDRA-13521)
 + * Bring back maxHintTTL propery (CASSANDRA-12982)
 + * Add testing guidelines (CASSANDRA-13497)
 + * Add more repair metrics (CASSANDRA-13531)
 + * RangeStreamer should be smarter when picking endpoints for streaming 
(CASSANDRA-4650)
 + * Avoid rewrapping an exception thrown for cache load functions 
(CASSANDRA-13367)
 + * Log time elapsed for each incremental repair phase (CASSANDRA-13498)
 + * Add multiple table operation support to cassandra-stress (CASSANDRA-8780)
 + * Fix incorrect cqlsh results when selecting same columns multiple times 
(CASSANDRA-13262)
 + * Fix WriteResponseHandlerTest is sensitive to test execution order 
(CASSANDRA-13421)
 + * Improve incremental repair logging (CASSANDRA-13468)
 + * Start compaction when incremental repair finishes (CASSANDRA-13454)
 + * Add repair streaming preview (CASSANDRA-13257)
 + * Cleanup isIncremental/repairedAt usage (CASSANDRA-13430)
 + * Change protocol to allow sending key space independent of query string 
(CASSANDRA-10145)
 + * Make gc_log and gc_warn settable at runtime (CASSANDRA-12661)
 + * Take number of files in L0 in account when estimating remaining compaction 
tasks (CASSANDRA-13354)
 + * Skip building views during base table streams on range movements 
(CASSANDRA-13065)
 + * Improve error messages for +/- operations on maps and tuples 
(CASSANDRA-13197)
 + * Remove deprecated repair JMX APIs (CASSANDRA-11530)
 + * Fix version check to enable streaming keep-alive (CASSANDRA-12929)
 + * Make it possible to monitor an ideal consistency level separate from 
actual consistency level (CASSANDRA-13289)
 + * Outbound TCP connections ignore internode authenticator (CASSANDRA-13324)
 + * Upgrade junit from 4.6 to 4.12 (CASSANDRA-13360)
 + * Cleanup ParentRepairSession after repairs (CASSANDRA-13359)
 + * Upgrade snappy-java to 1.1.2.6 (CASSANDRA-13336)
 + * Incremental repair not streaming correct sstables (CASSANDRA-13328)
 + * Upgrade the jna version to 4.3.0 (CASSANDRA-13300)
 + * Add the currentTimestamp, currentDate, currentTime and currentTimeUUID 
functions (CASSANDRA-13132)
 + * Remove config option index_interval (CASSANDRA-10671)
 + * Reduce lock contention for collection types and serializers 
(CASSANDRA-13271)
 + * Make it possible to override MessagingService.Verb ids (CASSANDRA-13283)
 + * Avoid synchronized on prepareForRepair in ActiveRepairService 
(CASSANDRA-9292)
 + * Adds the ability to use uncompressed chunks in compressed files 
(CASSANDRA-10520)
 + * Don't flush sstables when streaming for incremental repair 
(CASSANDRA-13226)
 + * Remove unused method (CASSANDRA-13227)
 + * Fix minor bugs related to #9143 (CASSANDRA-13217)
 + * Output warning if user increases RF (CASSANDRA-13079)
 + * Remove pre-3.0 streaming compatibility code for 4.0 (CASSANDRA-13081)
 + * Add support for + and - operations on dates (CASSANDRA-11936)
 + * Fix consistency of incrementally repaired data (CASSANDRA-9143)
 + * Increase commitlog version (CASSANDRA-13161)
 + * Make TableMetadata immutable, optimize Schema (CASSANDRA-9425)
 + * Refactor ColumnCondition (CASSANDRA-12981)
 + * Parallelize streaming of

[3/6] cassandra git commit: Add newline to output if there are no snapshots

2017-06-21 Thread jjirsa 
Add newline to output if there are no snapshots

Patch by Arnd Hannemann; Reviewed by Jeff Jirsa for CASSANDRA-13568


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/96bd3d53
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/96bd3d53
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/96bd3d53

Branch: refs/heads/trunk
Commit: 96bd3d53637d95ce268e7d4521a62bb400bc161b
Parents: 960e16b
Author: Arnd Hannemann 
Authored: Thu Jun 1 10:34:52 2017 +0200
Committer: Jeff Jirsa 
Committed: Wed Jun 21 19:13:25 2017 -0700

--
 CHANGES.txt | 4 
 src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/96bd3d53/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8791ff0..00e87bf 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+3.0.15
+ * Nodetool listsnapshots output is missing a newline, if there are no 
snapshots (CASSANDRA-13568)
+
+
 3.0.14
  * Ensure int overflow doesn't occur when calculating large partition warning 
size (CASSANDRA-13172)
  * Ensure consistent view of partition columns between coordinator and replica 
in ColumnFilter (CASSANDRA-13004)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/96bd3d53/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
--
diff --git a/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java 
b/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
index ee7bf34..798fb71 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
@@ -42,7 +42,7 @@ public class ListSnapshots extends NodeToolCmd
 final Map snapshotDetails = 
probe.getSnapshotDetails();
 if (snapshotDetails.isEmpty())
 {
-System.out.printf("There are no snapshots");
+System.out.println("There are no snapshots");
 return;
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[5/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/56c8f0c5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/56c8f0c5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/56c8f0c5

Branch: refs/heads/cassandra-3.11
Commit: 56c8f0c5861a815a7b4690744402b3a1e11398f0
Parents: 903da08 96bd3d5
Author: Jeff Jirsa 
Authored: Wed Jun 21 19:15:13 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 19:15:51 2017 -0700

--
 CHANGES.txt | 5 +
 src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/56c8f0c5/CHANGES.txt
--
diff --cc CHANGES.txt
index 087f2cf,00e87bf..6f2d509
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,42 -1,8 +1,47 @@@
 -3.0.15
++3.11.1
++Merged from 3.0:
+  * Nodetool listsnapshots output is missing a newline, if there are no 
snapshots (CASSANDRA-13568)
+ 
+ 
 -3.0.14
 +3.11.0
 + * Replace string comparison with regex/number checks in MessagingService 
test (CASSANDRA-13216)
 + * Fix formatting of duration columns in CQLSH (CASSANDRA-13549)
 + * Fix the problem with duplicated rows when using paging with SASI 
(CASSANDRA-13302)
 + * Allow CONTAINS statements filtering on the partition key and it’s parts 
(CASSANDRA-13275)
 + * Fall back to even ranges calculation in clusters with vnodes when tokens 
are distributed unevenly (CASSANDRA-13229)
 + * Fix duration type validation to prevent overflow (CASSANDRA-13218)
 + * Forbid unsupported creation of SASI indexes over partition key columns 
(CASSANDRA-13228)
 + * Reject multiple values for a key in CQL grammar. (CASSANDRA-13369)
 + * UDA fails without input rows (CASSANDRA-13399)
 + * Fix compaction-stress by using daemonInitialization (CASSANDRA-13188)
 + * V5 protocol flags decoding broken (CASSANDRA-13443)
 + * Use write lock not read lock for removing sstables from compaction 
strategies. (CASSANDRA-13422)
 + * Use corePoolSize equal to maxPoolSize in JMXEnabledThreadPoolExecutors 
(CASSANDRA-13329)
 + * Avoid rebuilding SASI indexes containing no values (CASSANDRA-12962)
 + * Add charset to Analyser input stream (CASSANDRA-13151)
 + * Fix testLimitSSTables flake caused by concurrent flush (CASSANDRA-12820)
 + * cdc column addition strikes again (CASSANDRA-13382)
 + * Fix static column indexes (CASSANDRA-13277)
 + * DataOutputBuffer.asNewBuffer broken (CASSANDRA-13298)
 + * unittest CipherFactoryTest failed on MacOS (CASSANDRA-13370)
 + * Forbid SELECT restrictions and CREATE INDEX over non-frozen UDT columns 
(CASSANDRA-13247)
 + * Default logging we ship will incorrectly print "?:?" for "%F:%L" pattern 
(CASSANDRA-13317)
 + * Possible AssertionError in UnfilteredRowIteratorWithLowerBound 
(CASSANDRA-13366)
 + * Support unaligned memory access for AArch64 (CASSANDRA-13326)
 + * Improve SASI range iterator efficiency on intersection with an empty range 
(CASSANDRA-12915).
 + * Fix equality comparisons of columns using the duration type 
(CASSANDRA-13174)
 + * Obfuscate password in stress-graphs (CASSANDRA-12233)
 + * Move to FastThreadLocalThread and FastThreadLocal (CASSANDRA-13034)
 + * nodetool stopdaemon errors out (CASSANDRA-13030)
 + * Tables in system_distributed should not use gcgs of 0 (CASSANDRA-12954)
 + * Fix primary index calculation for SASI (CASSANDRA-12910)
 + * More fixes to the TokenAllocator (CASSANDRA-12990)
 + * NoReplicationTokenAllocator should work with zero replication factor 
(CASSANDRA-12983)
 + * Address message coalescing regression (CASSANDRA-12676)
 + * Delete illegal character from StandardTokenizerImpl.jflex (CASSANDRA-13417)
 + * Fix cqlsh automatic protocol downgrade regression (CASSANDRA-13307)
 + * Tracing payload not passed from QueryMessage to tracing session 
(CASSANDRA-12835)
 +Merged from 3.0:
   * Ensure int overflow doesn't occur when calculating large partition warning 
size (CASSANDRA-13172)
   * Ensure consistent view of partition columns between coordinator and 
replica in ColumnFilter (CASSANDRA-13004)
   * Failed unregistering mbean during drop keyspace (CASSANDRA-13346)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/56c8f0c5/src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
--


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13095) Timeouts between nodes

2017-06-21 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058605#comment-16058605
 ] 

Jeff Jirsa commented on CASSANDRA-13095:


Believe this is a dupe of CASSANDRA-13159 - you reported it first, but I 
somehow saw that patch first.
 [~d.smirnov] agree? 

> Timeouts between nodes
> --
>
> Key: CASSANDRA-13095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13095
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Danil Smirnov
>Assignee: Danil Smirnov
>Priority: Minor
> Attachments: 13095-2.1.patch
>
>
> Recently I've run into a problem with heavily loaded cluster when sometimes 
> messages between certain nodes become blocked with no reason.
> It looks like the same situation that described here 
> https://issues.apache.org/jira/browse/CASSANDRA-12676?focusedCommentId=15736166=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15736166
> Thread dump showed infinite loop here: 
> https://github.com/apache/cassandra/blob/a8a43dd32eb92406d7d8b105e08c68b3d5c7df49/src/java/org/apache/cassandra/utils/CoalescingStrategies.java#L109
> Apparently the problem is in the initial value of epoch filed in 
> TimeHorizonMovingAverageCoalescingStrategy class. When it's value is not 
> evenly divisible by BUCKET_INTERVAL, ix(epoch-1) does not point to the 
> correct bucket. As a result, sum gradually increases and, upon reaching 
> MEASURED_INTERVAL, averageGap becomes 0 and thread blocks.
> It's hard to reproduce because it takes a long time for sum to grow and when 
> no messages are send for some time, sum becomes 0 
> https://github.com/apache/cassandra/blob/a8a43dd32eb92406d7d8b105e08c68b3d5c7df49/src/java/org/apache/cassandra/utils/CoalescingStrategies.java#L301
>  and bug is no longer reproducible (until connection between nodes is 
> re-created).
> I've added a patch which should fix the problem. Don't know if it would be of 
> any help since CASSANDRA-12676 will apparently disable this behaviour. One 
> note about performance regressions though. There is a small chance it being 
> result of the bug described here, so it might be worth testing performance 
> after fixes and/or tuning the algorithm.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13568) nodetool listsnapshots output is missing a newline, if there are no snapshots

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13568:
---
Status: Ready to Commit  (was: Patch Available)

> nodetool listsnapshots output is missing a newline, if there are no snapshots
> -
>
> Key: CASSANDRA-13568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13568
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Arnd Hannemann
>Assignee: Arnd Hannemann
>Priority: Trivial
> Attachments: 
> 0001-CASSANDRA-13568-add-newline-to-output-if-there-are-n.patch
>
>
> When there are no snapshots, the nodetool listsnaphots command output is 
> missing a newline, which gives a somewhat bad user experience:
> {code}
> root@cassandra2:~# nodetool listsnapshots
> Snapshot Details: 
> There are no snapshotsroot@cassandra2:~# 
> {code}
> I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13568) nodetool listsnapshots output is missing a newline, if there are no snapshots

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13568:
---
Reviewer: Jeff Jirsa

> nodetool listsnapshots output is missing a newline, if there are no snapshots
> -
>
> Key: CASSANDRA-13568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13568
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Arnd Hannemann
>Assignee: Arnd Hannemann
>Priority: Trivial
> Attachments: 
> 0001-CASSANDRA-13568-add-newline-to-output-if-there-are-n.patch
>
>
> When there are no snapshots, the nodetool listsnaphots command output is 
> missing a newline, which gives a somewhat bad user experience:
> {code}
> root@cassandra2:~# nodetool listsnapshots
> Snapshot Details: 
> There are no snapshotsroot@cassandra2:~# 
> {code}
> I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13568) nodetool listsnapshots output is missing a newline, if there are no snapshots

2017-06-21 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058595#comment-16058595
 ] 

Jeff Jirsa commented on CASSANDRA-13568:


lgtm, will commit as soon as we bump all the versions for the recent releases.


> nodetool listsnapshots output is missing a newline, if there are no snapshots
> -
>
> Key: CASSANDRA-13568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13568
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Arnd Hannemann
>Assignee: Arnd Hannemann
>Priority: Trivial
> Attachments: 
> 0001-CASSANDRA-13568-add-newline-to-output-if-there-are-n.patch
>
>
> When there are no snapshots, the nodetool listsnaphots command output is 
> missing a newline, which gives a somewhat bad user experience:
> {code}
> root@cassandra2:~# nodetool listsnapshots
> Snapshot Details: 
> There are no snapshotsroot@cassandra2:~# 
> {code}
> I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-13568) nodetool listsnapshots output is missing a newline, if there are no snapshots

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa reassigned CASSANDRA-13568:
--

Assignee: Arnd Hannemann

> nodetool listsnapshots output is missing a newline, if there are no snapshots
> -
>
> Key: CASSANDRA-13568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13568
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Arnd Hannemann
>Assignee: Arnd Hannemann
>Priority: Trivial
> Attachments: 
> 0001-CASSANDRA-13568-add-newline-to-output-if-there-are-n.patch
>
>
> When there are no snapshots, the nodetool listsnaphots command output is 
> missing a newline, which gives a somewhat bad user experience:
> {code}
> root@cassandra2:~# nodetool listsnapshots
> Snapshot Details: 
> There are no snapshotsroot@cassandra2:~# 
> {code}
> I



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13561) Purge TTL on expiration

2017-06-21 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058582#comment-16058582
 ] 

Jeff Jirsa commented on CASSANDRA-13561:


This is being addressed in an alternate way - by adding a table option to 
instruct cassandra to ignore overlapping sstables ( see CASSANDRA-13418 ) - 
would you be OK with that approach? If so, can I close this as a duplicate?
  

> Purge TTL on expiration
> ---
>
> Key: CASSANDRA-13561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13561
> Project: Cassandra
>  Issue Type: New Feature
>Reporter: Andrew Whang
>Assignee: Andrew Whang
>Priority: Minor
> Fix For: 4.0
>
>
> Tables with mostly TTL columns tend to suffer from high droppable tombstone 
> ratio, which results in higher read latency, cpu utilization, and disk usage. 
> Expired TTL data become tombstones, and the nature of purging tombstones 
> during compaction (due to checking for overlapping SSTables) make them 
> susceptible to surviving much longer than expected. A table option to purge 
> TTL on expiration would address this issue, by preventing them from becoming 
> tombstones. A boolean purge_ttl_on_expiration table setting would allow users 
> to easily turn the feature on or off. 
> Being more aggressive with gc_grace could also address the problem of long 
> lasting tombstones, but that would affect tombstones from deletes as well. 
> Even if a purged [expired] cell is revived via repair from a node that hasn't 
> yet compacted away the cell, it would be revived as an expiring cell with the 
> same localDeletionTime, so reads should properly handle them. As well, it 
> would be purged in the next compaction. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-13561) Purge TTL on expiration

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa reassigned CASSANDRA-13561:
--

Assignee: Andrew Whang

> Purge TTL on expiration
> ---
>
> Key: CASSANDRA-13561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13561
> Project: Cassandra
>  Issue Type: New Feature
>Reporter: Andrew Whang
>Assignee: Andrew Whang
>Priority: Minor
> Fix For: 4.0
>
>
> Tables with mostly TTL columns tend to suffer from high droppable tombstone 
> ratio, which results in higher read latency, cpu utilization, and disk usage. 
> Expired TTL data become tombstones, and the nature of purging tombstones 
> during compaction (due to checking for overlapping SSTables) make them 
> susceptible to surviving much longer than expected. A table option to purge 
> TTL on expiration would address this issue, by preventing them from becoming 
> tombstones. A boolean purge_ttl_on_expiration table setting would allow users 
> to easily turn the feature on or off. 
> Being more aggressive with gc_grace could also address the problem of long 
> lasting tombstones, but that would affect tombstones from deletes as well. 
> Even if a purged [expired] cell is revived via repair from a node that hasn't 
> yet compacted away the cell, it would be revived as an expiring cell with the 
> same localDeletionTime, so reads should properly handle them. As well, it 
> would be purged in the next compaction. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-9988) Introduce leaf-only iterator

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa reassigned CASSANDRA-9988:
-

Assignee: Jay Zhuang  (was: Anthony Grasso)
Reviewer: Anthony Grasso

> Introduce leaf-only iterator
> 
>
> Key: CASSANDRA-9988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9988
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Benedict
>Assignee: Jay Zhuang
>Priority: Minor
>  Labels: patch
> Fix For: 4.0
>
> Attachments: 9988-trunk-new.txt, 9988-trunk-new-update.txt, 
> trunk-9988.txt
>
>
> In many cases we have small btrees, small enough to fit in a single leaf 
> page. In this case it _may_ be more efficient to specialise our iterator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-9989) Optimise BTree.Buider

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa reassigned CASSANDRA-9989:
-

Assignee: Jay Zhuang  (was: Anthony Grasso)
Reviewer: Anthony Grasso

> Optimise BTree.Buider
> -
>
> Key: CASSANDRA-9989
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9989
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Benedict
>Assignee: Jay Zhuang
>Priority: Minor
> Fix For: 4.x
>
> Attachments: 9989-trunk.txt
>
>
> BTree.Builder could reduce its copying, and exploit toArray more efficiently, 
> with some work. It's not very important right now because we don't make as 
> much use of its bulk-add methods as we otherwise might, however over time 
> this work will become more useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-9989) Optimise BTree.Buider

2017-06-21 Thread Nate McCall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nate McCall reassigned CASSANDRA-9989:
--

Assignee: Anthony Grasso  (was: Jay Zhuang)

> Optimise BTree.Buider
> -
>
> Key: CASSANDRA-9989
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9989
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Benedict
>Assignee: Anthony Grasso
>Priority: Minor
> Fix For: 4.x
>
> Attachments: 9989-trunk.txt
>
>
> BTree.Builder could reduce its copying, and exploit toArray more efficiently, 
> with some work. It's not very important right now because we don't make as 
> much use of its bulk-add methods as we otherwise might, however over time 
> this work will become more useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-9988) Introduce leaf-only iterator

2017-06-21 Thread Nate McCall (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058529#comment-16058529
 ] 

Nate McCall commented on CASSANDRA-9988:


We have a few spare cycles coming up. Assigning to [~Anthony Grasso] for review 
and verification.  

> Introduce leaf-only iterator
> 
>
> Key: CASSANDRA-9988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9988
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Benedict
>Assignee: Anthony Grasso
>Priority: Minor
>  Labels: patch
> Fix For: 4.0
>
> Attachments: 9988-trunk-new.txt, 9988-trunk-new-update.txt, 
> trunk-9988.txt
>
>
> In many cases we have small btrees, small enough to fit in a single leaf 
> page. In this case it _may_ be more efficient to specialise our iterator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-9989) Optimise BTree.Buider

2017-06-21 Thread Nate McCall (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058528#comment-16058528
 ] 

Nate McCall commented on CASSANDRA-9989:


We have a few spare cycles coming up. Assigning to [~Anthony Grasso] for 
review. 

> Optimise BTree.Buider
> -
>
> Key: CASSANDRA-9989
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9989
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Benedict
>Assignee: Anthony Grasso
>Priority: Minor
> Fix For: 4.x
>
> Attachments: 9989-trunk.txt
>
>
> BTree.Builder could reduce its copying, and exploit toArray more efficiently, 
> with some work. It's not very important right now because we don't make as 
> much use of its bulk-add methods as we otherwise might, however over time 
> this work will become more useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-9988) Introduce leaf-only iterator

2017-06-21 Thread Nate McCall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nate McCall reassigned CASSANDRA-9988:
--

Assignee: Anthony Grasso  (was: Jay Zhuang)

> Introduce leaf-only iterator
> 
>
> Key: CASSANDRA-9988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9988
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Benedict
>Assignee: Anthony Grasso
>Priority: Minor
>  Labels: patch
> Fix For: 4.0
>
> Attachments: 9988-trunk-new.txt, 9988-trunk-new-update.txt, 
> trunk-9988.txt
>
>
> In many cases we have small btrees, small enough to fit in a single leaf 
> page. In this case it _may_ be more efficient to specialise our iterator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13625:
---
   Resolution: Fixed
Fix Version/s: (was: 2.2.10)
   2.2.11
   Status: Resolved  (was: Ready to Commit)

Committed in {{082af0a9ba6b5dde26055fcb9ddd2085e4240381}} , merged {{-s ours}} 
through 3.0/3.11/trunk, so it's only in 2.2.11.

Thanks!


> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>Assignee: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.11
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13625:
---
Status: Ready to Commit  (was: Patch Available)

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>Assignee: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[05/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/960e16b8
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/960e16b8
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/960e16b8

Branch: refs/heads/cassandra-3.11
Commit: 960e16b892f525f8c356017f31674684c1aae611
Parents: a5a7446 082af0a
Author: Jeff Jirsa 
Authored: Wed Jun 21 17:01:34 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 17:01:34 2017 -0700

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[06/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/960e16b8
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/960e16b8
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/960e16b8

Branch: refs/heads/cassandra-3.0
Commit: 960e16b892f525f8c356017f31674684c1aae611
Parents: a5a7446 082af0a
Author: Jeff Jirsa 
Authored: Wed Jun 21 17:01:34 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 17:01:34 2017 -0700

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[04/10] cassandra git commit: Remove unused max_value_size_in_mb config setting

2017-06-21 Thread jjirsa 
Remove unused max_value_size_in_mb config setting

Fixes #124

Patch by Joaquin Casares; Reviewed by Jeff Jirsa for CASSANDRA-13625


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/082af0a9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/082af0a9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/082af0a9

Branch: refs/heads/trunk
Commit: 082af0a9ba6b5dde26055fcb9ddd2085e4240381
Parents: 83f28ce
Author: Joaquin Casares 
Authored: Tue Jun 20 18:26:26 2017 -0500
Committer: Jeff Jirsa 
Committed: Wed Jun 21 16:58:03 2017 -0700

--
 CHANGES.txt | 4 
 conf/cassandra.yaml | 5 -
 2 files changed, 4 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 56890c9..c966c92 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+2.2.11
+ * Remove unused max_value_size_in_mb config setting from yaml (CASSANDRA-13625
+
+
 2.2.10
  * Nodes started with join_ring=False should be able to serve requests when 
authentication is enabled (CASSANDRA-11381)
  * cqlsh COPY FROM: increment error count only for failures, not for attempts 
(CASSANDRA-13209)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/conf/cassandra.yaml
--
diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml
index 41c1fb1..c1c268c 100644
--- a/conf/cassandra.yaml
+++ b/conf/cassandra.yaml
@@ -885,11 +885,6 @@ enable_user_defined_functions: false
 # setting.
 windows_timer_interval: 1
 
-# Maximum size of any value in SSTables. Safety measure to detect SSTable 
corruption
-# early. Any value size larger than this threshold will result into marking an 
SSTable
-# as corrupted.
-# max_value_size_in_mb: 256
-
 # Coalescing Strategies #
 # Coalescing multiples messages turns out to significantly boost message 
processing throughput (think doubling or more).
 # On bare metal, the floor for packet processing throughput is high enough 
that many applications won't notice, but in


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[07/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/960e16b8
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/960e16b8
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/960e16b8

Branch: refs/heads/trunk
Commit: 960e16b892f525f8c356017f31674684c1aae611
Parents: a5a7446 082af0a
Author: Jeff Jirsa 
Authored: Wed Jun 21 17:01:34 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 17:01:34 2017 -0700

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[02/10] cassandra git commit: Remove unused max_value_size_in_mb config setting

2017-06-21 Thread jjirsa 
Remove unused max_value_size_in_mb config setting

Fixes #124

Patch by Joaquin Casares; Reviewed by Jeff Jirsa for CASSANDRA-13625


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/082af0a9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/082af0a9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/082af0a9

Branch: refs/heads/cassandra-3.0
Commit: 082af0a9ba6b5dde26055fcb9ddd2085e4240381
Parents: 83f28ce
Author: Joaquin Casares 
Authored: Tue Jun 20 18:26:26 2017 -0500
Committer: Jeff Jirsa 
Committed: Wed Jun 21 16:58:03 2017 -0700

--
 CHANGES.txt | 4 
 conf/cassandra.yaml | 5 -
 2 files changed, 4 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 56890c9..c966c92 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+2.2.11
+ * Remove unused max_value_size_in_mb config setting from yaml (CASSANDRA-13625
+
+
 2.2.10
  * Nodes started with join_ring=False should be able to serve requests when 
authentication is enabled (CASSANDRA-11381)
  * cqlsh COPY FROM: increment error count only for failures, not for attempts 
(CASSANDRA-13209)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/conf/cassandra.yaml
--
diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml
index 41c1fb1..c1c268c 100644
--- a/conf/cassandra.yaml
+++ b/conf/cassandra.yaml
@@ -885,11 +885,6 @@ enable_user_defined_functions: false
 # setting.
 windows_timer_interval: 1
 
-# Maximum size of any value in SSTables. Safety measure to detect SSTable 
corruption
-# early. Any value size larger than this threshold will result into marking an 
SSTable
-# as corrupted.
-# max_value_size_in_mb: 256
-
 # Coalescing Strategies #
 # Coalescing multiples messages turns out to significantly boost message 
processing throughput (think doubling or more).
 # On bare metal, the floor for packet processing throughput is high enough 
that many applications won't notice, but in


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[10/10] cassandra git commit: Merge branch 'cassandra-3.11' into trunk

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-3.11' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/de009a39
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/de009a39
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/de009a39

Branch: refs/heads/trunk
Commit: de009a39334b7cee4854c530b9852c555449b75a
Parents: cdb0167 903da08
Author: Jeff Jirsa 
Authored: Wed Jun 21 17:01:55 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 17:01:55 2017 -0700

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[03/10] cassandra git commit: Remove unused max_value_size_in_mb config setting

2017-06-21 Thread jjirsa 
Remove unused max_value_size_in_mb config setting

Fixes #124

Patch by Joaquin Casares; Reviewed by Jeff Jirsa for CASSANDRA-13625


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/082af0a9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/082af0a9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/082af0a9

Branch: refs/heads/cassandra-3.11
Commit: 082af0a9ba6b5dde26055fcb9ddd2085e4240381
Parents: 83f28ce
Author: Joaquin Casares 
Authored: Tue Jun 20 18:26:26 2017 -0500
Committer: Jeff Jirsa 
Committed: Wed Jun 21 16:58:03 2017 -0700

--
 CHANGES.txt | 4 
 conf/cassandra.yaml | 5 -
 2 files changed, 4 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 56890c9..c966c92 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+2.2.11
+ * Remove unused max_value_size_in_mb config setting from yaml (CASSANDRA-13625
+
+
 2.2.10
  * Nodes started with join_ring=False should be able to serve requests when 
authentication is enabled (CASSANDRA-11381)
  * cqlsh COPY FROM: increment error count only for failures, not for attempts 
(CASSANDRA-13209)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/conf/cassandra.yaml
--
diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml
index 41c1fb1..c1c268c 100644
--- a/conf/cassandra.yaml
+++ b/conf/cassandra.yaml
@@ -885,11 +885,6 @@ enable_user_defined_functions: false
 # setting.
 windows_timer_interval: 1
 
-# Maximum size of any value in SSTables. Safety measure to detect SSTable 
corruption
-# early. Any value size larger than this threshold will result into marking an 
SSTable
-# as corrupted.
-# max_value_size_in_mb: 256
-
 # Coalescing Strategies #
 # Coalescing multiples messages turns out to significantly boost message 
processing throughput (think doubling or more).
 # On bare metal, the floor for packet processing throughput is high enough 
that many applications won't notice, but in


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[01/10] cassandra git commit: Remove unused max_value_size_in_mb config setting

2017-06-21 Thread jjirsa 
Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.2 83f28ce3c -> 082af0a9b
  refs/heads/cassandra-3.0 a5a744693 -> 960e16b89
  refs/heads/cassandra-3.11 e8a58264e -> 903da089f
  refs/heads/trunk cdb01675e -> de009a393


Remove unused max_value_size_in_mb config setting

Fixes #124

Patch by Joaquin Casares; Reviewed by Jeff Jirsa for CASSANDRA-13625


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/082af0a9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/082af0a9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/082af0a9

Branch: refs/heads/cassandra-2.2
Commit: 082af0a9ba6b5dde26055fcb9ddd2085e4240381
Parents: 83f28ce
Author: Joaquin Casares 
Authored: Tue Jun 20 18:26:26 2017 -0500
Committer: Jeff Jirsa 
Committed: Wed Jun 21 16:58:03 2017 -0700

--
 CHANGES.txt | 4 
 conf/cassandra.yaml | 5 -
 2 files changed, 4 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 56890c9..c966c92 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,7 @@
+2.2.11
+ * Remove unused max_value_size_in_mb config setting from yaml (CASSANDRA-13625
+
+
 2.2.10
  * Nodes started with join_ring=False should be able to serve requests when 
authentication is enabled (CASSANDRA-11381)
  * cqlsh COPY FROM: increment error count only for failures, not for attempts 
(CASSANDRA-13209)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/082af0a9/conf/cassandra.yaml
--
diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml
index 41c1fb1..c1c268c 100644
--- a/conf/cassandra.yaml
+++ b/conf/cassandra.yaml
@@ -885,11 +885,6 @@ enable_user_defined_functions: false
 # setting.
 windows_timer_interval: 1
 
-# Maximum size of any value in SSTables. Safety measure to detect SSTable 
corruption
-# early. Any value size larger than this threshold will result into marking an 
SSTable
-# as corrupted.
-# max_value_size_in_mb: 256
-
 # Coalescing Strategies #
 # Coalescing multiples messages turns out to significantly boost message 
processing throughput (think doubling or more).
 # On bare metal, the floor for packet processing throughput is high enough 
that many applications won't notice, but in


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[09/10] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/903da089
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/903da089
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/903da089

Branch: refs/heads/trunk
Commit: 903da089ff825b6ac7e2b090ff5583dda14fdc18
Parents: e8a5826 960e16b
Author: Jeff Jirsa 
Authored: Wed Jun 21 17:01:46 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 17:01:46 2017 -0700

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[08/10] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2017-06-21 Thread jjirsa 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/903da089
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/903da089
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/903da089

Branch: refs/heads/cassandra-3.11
Commit: 903da089ff825b6ac7e2b090ff5583dda14fdc18
Parents: e8a5826 960e16b
Author: Jeff Jirsa 
Authored: Wed Jun 21 17:01:46 2017 -0700
Committer: Jeff Jirsa 
Committed: Wed Jun 21 17:01:46 2017 -0700

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13625:
---
Reviewer: Jeff Jirsa
  Status: Patch Available  (was: Open)

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>Assignee: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13557) allow different NUMACTL_ARGS to be passed in

2017-06-21 Thread Ariel Weisberg (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ariel Weisberg updated CASSANDRA-13557:
---
Status: Patch Available  (was: Open)

> allow different NUMACTL_ARGS to be passed in
> 
>
> Key: CASSANDRA-13557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13557
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Matt Byrd
>Assignee: Matt Byrd
>Priority: Minor
> Fix For: 4.x
>
>
> Currently in bin/cassandra the following is hardcoded:
> NUMACTL_ARGS="--interleave=all"
> Ideally users of cassandra/bin could pass in a different set of NUMACTL_ARGS 
> if they wanted to say bind the process to a socket for cpu/memory reasons, 
> rather than having to comment out/modify this line in the deployed 
> cassandra/bin. e.g as described in:
> https://tobert.github.io/pages/als-cassandra-21-tuning-guide.html
> This could be done by just having the default be set to "--interleave=all" 
> but pickup any value which has already been set for the variable NUMACTL_ARGS.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13557) allow different NUMACTL_ARGS to be passed in

2017-06-21 Thread Ariel Weisberg (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ariel Weisberg updated CASSANDRA-13557:
---
Status: Ready to Commit  (was: Patch Available)

> allow different NUMACTL_ARGS to be passed in
> 
>
> Key: CASSANDRA-13557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13557
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Matt Byrd
>Assignee: Matt Byrd
>Priority: Minor
> Fix For: 4.x
>
>
> Currently in bin/cassandra the following is hardcoded:
> NUMACTL_ARGS="--interleave=all"
> Ideally users of cassandra/bin could pass in a different set of NUMACTL_ARGS 
> if they wanted to say bind the process to a socket for cpu/memory reasons, 
> rather than having to comment out/modify this line in the deployed 
> cassandra/bin. e.g as described in:
> https://tobert.github.io/pages/als-cassandra-21-tuning-guide.html
> This could be done by just having the default be set to "--interleave=all" 
> but pickup any value which has already been set for the variable NUMACTL_ARGS.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[cassandra] Git Push Summary

2017-06-21 Thread mshuler 
Repository: cassandra
Updated Tags:  refs/tags/2.2.10-tentative [created] 83f28ce3c

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[cassandra] Git Push Summary

2017-06-21 Thread mshuler 
Repository: cassandra
Updated Tags:  refs/tags/2.1.18-tentative [created] 9369db1df

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[12/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83f28ce3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83f28ce3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83f28ce3

Branch: refs/heads/cassandra-2.2
Commit: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
Parents: c9d3b30 9369db1
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:38 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:38 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[05/19] cassandra git commit: Prepare 2.1.18 release

2017-06-21 Thread mshuler 
Prepare 2.1.18 release

- release debian/changelog
- backport RPM packaging fixes from cassandra-2.2 branch for
  CASSANDRA-13046, CASSANDRA-13434, CASSANDRA-13435, CASSANDRA-13433,
  and CASSANDRA-13493


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9369db1d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9369db1d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9369db1d

Branch: refs/heads/trunk
Commit: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
Parents: fdb8c96
Author: Michael Shuler 
Authored: Wed Jun 21 13:57:40 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:04:21 2017 -0500

--
 debian/changelog  |  4 ++--
 redhat/README.md  | 19 ++-
 redhat/cassandra  | 38 --
 redhat/cassandra.spec |  7 +--
 4 files changed, 49 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index 48ed24b..a0ee850 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.1.18) UNRELEASED; urgency=medium
+cassandra (2.1.18) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 13:59:40 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 13:57:08 -0500
 
 cassandra (2.1.17) unstable; urgency=medium
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/README.md
--
diff --git a/redhat/README.md b/redhat/README.md
index 0b2ab0d..cab42a7 100644
--- a/redhat/README.md
+++ b/redhat/README.md
@@ -7,25 +7,26 @@
 ### Step 1:
 - Build and copy sources to build tree:
 ```
-ant artifacts
-cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/
+ant artifacts -Drelease=true
 ```
 
 ### Step 2:
 - Since there is no version specified in the SPEC file, one needs to be passed 
at `rpmbuild` time (example with 4.0):
 ```
-rpmbuild --define="version 4.0" -ba redhat/cassandra.spec
+mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS}
+rpmbuild --define="version 4.0" \
+--define="revision $(date +"%Y%m%d")git$(git rev-parse --short 
HEAD)%{?dist}" \
+--define "_topdir $(pwd)/build/rpmbuild" \
+--define "_sourcedir $(pwd)/build" \
+-ba redhat/cassandra.spec
 ```
 
+Use revision value in the example above for git based snapshots. Change to 
`--define="revision 1"` for non-snapshot releases.
+
 - RPM files can be found in their respective build tree directories:
 ```
-ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/
+ls -l build/rpmbuild/{SRPMS,RPMS}/
 ```
 
 ### Hint:
 - Don't build packages as root..
-```
-# this makes your RPM_BUILD_DIR = ~/rpmbuild
-mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
-echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros
-```

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/cassandra
--
diff --git a/redhat/cassandra b/redhat/cassandra
index 3e59534..677ff8c 100644
--- a/redhat/cassandra
+++ b/redhat/cassandra
@@ -3,9 +3,23 @@
 # /etc/init.d/cassandra
 #
 # Startup script for Cassandra
-# 
-# chkconfig: 2345 20 80
+#
+# chkconfig: 2345 80 20
 # description: Starts and stops Cassandra
+# pidfile: /var/run/cassandra/cassandra.pid
+
+### BEGIN INIT INFO
+# Provides:  cassandra
+# Required-Start:$remote_fs $network $named $time
+# Required-Stop: $remote_fs $network $named $time
+# Should-Start:  ntp mdadm
+# Should-Stop:   ntp mdadm
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+# Short-Description: distributed storage system for structured data
+# Description:   Cassandra is a distributed (peer-to-peer) system for
+#the management and storage of structured data.
+### END INIT INFO
 
 . /etc/rc.d/init.d/functions
 
@@ -53,6 +67,8 @@ case "$1" in
 start)
 # Cassandra startup
 echo -n "Starting Cassandra: "
+[ -d `dirname "$pid_file"` ] || \
+install -m 755 -o $CASSANDRA_OWNR -g $CASSANDRA_OWNR -d `dirname 
$pid_file`
 su $CASSANDRA_OWNR -c "$CASSANDRA_PROG -p $pid_file" > $log_file 2>&1
 retval=$?
 [ $retval -eq 0 ] && touch $lock_file
@@ -64,16 +80,26 @@ case "$1" in
 su $CASSANDRA_OWNR -c "kill `cat $pid_file`"
 retval=$?
 [ $retval -eq 0 ] && rm -f $lock_file
-for t in `seq 40`; do $0 status > /dev/null 2>&1 && sleep 0.5 || 
break; done
+for t in `seq 40`; do
+status -p $pid_file cassandra > /dev/null 2>&1
+

[16/19] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/a5a74469
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/a5a74469
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/a5a74469

Branch: refs/heads/cassandra-3.11
Commit: a5a744693a59a32f8e77ad4f6df282bf9a1c4041
Parents: f3e38cb 83f28ce
Author: Michael Shuler 
Authored: Wed Jun 21 14:09:15 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:09:15 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[14/19] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/a5a74469
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/a5a74469
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/a5a74469

Branch: refs/heads/trunk
Commit: a5a744693a59a32f8e77ad4f6df282bf9a1c4041
Parents: f3e38cb 83f28ce
Author: Michael Shuler 
Authored: Wed Jun 21 14:09:15 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:09:15 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[06/19] cassandra git commit: Prepare 2.2.10 release

2017-06-21 Thread mshuler 
Prepare 2.2.10 release


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c9d3b30d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c9d3b30d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c9d3b30d

Branch: refs/heads/cassandra-3.0
Commit: c9d3b30dbd7d5edb3bac62e3ced1dfe03ec68029
Parents: 13e153b
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:31 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:31 2017 -0500

--
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c9d3b30d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index e561309..a291da3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.2.10) UNRELEASED; urgency=medium
+cassandra (2.2.10) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 14:02:39 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 14:07:47 -0500
 
 cassandra (2.2.9) unstable; urgency=medium
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[17/19] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2017-06-21 Thread mshuler 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e8a58264
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e8a58264
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e8a58264

Branch: refs/heads/trunk
Commit: e8a58264e4a921f11fca08ba594c07f5f6136719
Parents: 88dee7e a5a7446
Author: Michael Shuler 
Authored: Wed Jun 21 14:09:38 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:09:38 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[19/19] cassandra git commit: Merge branch 'cassandra-3.11' into trunk

2017-06-21 Thread mshuler 
Merge branch 'cassandra-3.11' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cdb01675
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cdb01675
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cdb01675

Branch: refs/heads/trunk
Commit: cdb01675e618354d9c76bc52df630b6525cd58ab
Parents: 5eca432 e8a5826
Author: Michael Shuler 
Authored: Wed Jun 21 14:09:55 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:09:55 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[10/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83f28ce3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83f28ce3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83f28ce3

Branch: refs/heads/cassandra-3.0
Commit: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
Parents: c9d3b30 9369db1
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:38 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:38 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[09/19] cassandra git commit: Prepare 2.2.10 release

2017-06-21 Thread mshuler 
Prepare 2.2.10 release


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c9d3b30d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c9d3b30d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c9d3b30d

Branch: refs/heads/cassandra-3.11
Commit: c9d3b30dbd7d5edb3bac62e3ced1dfe03ec68029
Parents: 13e153b
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:31 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:31 2017 -0500

--
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c9d3b30d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index e561309..a291da3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.2.10) UNRELEASED; urgency=medium
+cassandra (2.2.10) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 14:02:39 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 14:07:47 -0500
 
 cassandra (2.2.9) unstable; urgency=medium
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[02/19] cassandra git commit: Prepare 2.1.18 release

2017-06-21 Thread mshuler 
Prepare 2.1.18 release

- release debian/changelog
- backport RPM packaging fixes from cassandra-2.2 branch for
  CASSANDRA-13046, CASSANDRA-13434, CASSANDRA-13435, CASSANDRA-13433,
  and CASSANDRA-13493


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9369db1d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9369db1d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9369db1d

Branch: refs/heads/cassandra-3.11
Commit: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
Parents: fdb8c96
Author: Michael Shuler 
Authored: Wed Jun 21 13:57:40 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:04:21 2017 -0500

--
 debian/changelog  |  4 ++--
 redhat/README.md  | 19 ++-
 redhat/cassandra  | 38 --
 redhat/cassandra.spec |  7 +--
 4 files changed, 49 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index 48ed24b..a0ee850 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.1.18) UNRELEASED; urgency=medium
+cassandra (2.1.18) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 13:59:40 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 13:57:08 -0500
 
 cassandra (2.1.17) unstable; urgency=medium
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/README.md
--
diff --git a/redhat/README.md b/redhat/README.md
index 0b2ab0d..cab42a7 100644
--- a/redhat/README.md
+++ b/redhat/README.md
@@ -7,25 +7,26 @@
 ### Step 1:
 - Build and copy sources to build tree:
 ```
-ant artifacts
-cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/
+ant artifacts -Drelease=true
 ```
 
 ### Step 2:
 - Since there is no version specified in the SPEC file, one needs to be passed 
at `rpmbuild` time (example with 4.0):
 ```
-rpmbuild --define="version 4.0" -ba redhat/cassandra.spec
+mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS}
+rpmbuild --define="version 4.0" \
+--define="revision $(date +"%Y%m%d")git$(git rev-parse --short 
HEAD)%{?dist}" \
+--define "_topdir $(pwd)/build/rpmbuild" \
+--define "_sourcedir $(pwd)/build" \
+-ba redhat/cassandra.spec
 ```
 
+Use revision value in the example above for git based snapshots. Change to 
`--define="revision 1"` for non-snapshot releases.
+
 - RPM files can be found in their respective build tree directories:
 ```
-ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/
+ls -l build/rpmbuild/{SRPMS,RPMS}/
 ```
 
 ### Hint:
 - Don't build packages as root..
-```
-# this makes your RPM_BUILD_DIR = ~/rpmbuild
-mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
-echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros
-```

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/cassandra
--
diff --git a/redhat/cassandra b/redhat/cassandra
index 3e59534..677ff8c 100644
--- a/redhat/cassandra
+++ b/redhat/cassandra
@@ -3,9 +3,23 @@
 # /etc/init.d/cassandra
 #
 # Startup script for Cassandra
-# 
-# chkconfig: 2345 20 80
+#
+# chkconfig: 2345 80 20
 # description: Starts and stops Cassandra
+# pidfile: /var/run/cassandra/cassandra.pid
+
+### BEGIN INIT INFO
+# Provides:  cassandra
+# Required-Start:$remote_fs $network $named $time
+# Required-Stop: $remote_fs $network $named $time
+# Should-Start:  ntp mdadm
+# Should-Stop:   ntp mdadm
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+# Short-Description: distributed storage system for structured data
+# Description:   Cassandra is a distributed (peer-to-peer) system for
+#the management and storage of structured data.
+### END INIT INFO
 
 . /etc/rc.d/init.d/functions
 
@@ -53,6 +67,8 @@ case "$1" in
 start)
 # Cassandra startup
 echo -n "Starting Cassandra: "
+[ -d `dirname "$pid_file"` ] || \
+install -m 755 -o $CASSANDRA_OWNR -g $CASSANDRA_OWNR -d `dirname 
$pid_file`
 su $CASSANDRA_OWNR -c "$CASSANDRA_PROG -p $pid_file" > $log_file 2>&1
 retval=$?
 [ $retval -eq 0 ] && touch $lock_file
@@ -64,16 +80,26 @@ case "$1" in
 su $CASSANDRA_OWNR -c "kill `cat $pid_file`"
 retval=$?
 [ $retval -eq 0 ] && rm -f $lock_file
-for t in `seq 40`; do $0 status > /dev/null 2>&1 && sleep 0.5 || 
break; done
+for t in `seq 40`; do
+status -p $pid_file cassandra > /dev/null 2>&1
+

[04/19] cassandra git commit: Prepare 2.1.18 release

2017-06-21 Thread mshuler 
Prepare 2.1.18 release

- release debian/changelog
- backport RPM packaging fixes from cassandra-2.2 branch for
  CASSANDRA-13046, CASSANDRA-13434, CASSANDRA-13435, CASSANDRA-13433,
  and CASSANDRA-13493


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9369db1d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9369db1d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9369db1d

Branch: refs/heads/cassandra-3.0
Commit: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
Parents: fdb8c96
Author: Michael Shuler 
Authored: Wed Jun 21 13:57:40 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:04:21 2017 -0500

--
 debian/changelog  |  4 ++--
 redhat/README.md  | 19 ++-
 redhat/cassandra  | 38 --
 redhat/cassandra.spec |  7 +--
 4 files changed, 49 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index 48ed24b..a0ee850 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.1.18) UNRELEASED; urgency=medium
+cassandra (2.1.18) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 13:59:40 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 13:57:08 -0500
 
 cassandra (2.1.17) unstable; urgency=medium
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/README.md
--
diff --git a/redhat/README.md b/redhat/README.md
index 0b2ab0d..cab42a7 100644
--- a/redhat/README.md
+++ b/redhat/README.md
@@ -7,25 +7,26 @@
 ### Step 1:
 - Build and copy sources to build tree:
 ```
-ant artifacts
-cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/
+ant artifacts -Drelease=true
 ```
 
 ### Step 2:
 - Since there is no version specified in the SPEC file, one needs to be passed 
at `rpmbuild` time (example with 4.0):
 ```
-rpmbuild --define="version 4.0" -ba redhat/cassandra.spec
+mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS}
+rpmbuild --define="version 4.0" \
+--define="revision $(date +"%Y%m%d")git$(git rev-parse --short 
HEAD)%{?dist}" \
+--define "_topdir $(pwd)/build/rpmbuild" \
+--define "_sourcedir $(pwd)/build" \
+-ba redhat/cassandra.spec
 ```
 
+Use revision value in the example above for git based snapshots. Change to 
`--define="revision 1"` for non-snapshot releases.
+
 - RPM files can be found in their respective build tree directories:
 ```
-ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/
+ls -l build/rpmbuild/{SRPMS,RPMS}/
 ```
 
 ### Hint:
 - Don't build packages as root..
-```
-# this makes your RPM_BUILD_DIR = ~/rpmbuild
-mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
-echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros
-```

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/cassandra
--
diff --git a/redhat/cassandra b/redhat/cassandra
index 3e59534..677ff8c 100644
--- a/redhat/cassandra
+++ b/redhat/cassandra
@@ -3,9 +3,23 @@
 # /etc/init.d/cassandra
 #
 # Startup script for Cassandra
-# 
-# chkconfig: 2345 20 80
+#
+# chkconfig: 2345 80 20
 # description: Starts and stops Cassandra
+# pidfile: /var/run/cassandra/cassandra.pid
+
+### BEGIN INIT INFO
+# Provides:  cassandra
+# Required-Start:$remote_fs $network $named $time
+# Required-Stop: $remote_fs $network $named $time
+# Should-Start:  ntp mdadm
+# Should-Stop:   ntp mdadm
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+# Short-Description: distributed storage system for structured data
+# Description:   Cassandra is a distributed (peer-to-peer) system for
+#the management and storage of structured data.
+### END INIT INFO
 
 . /etc/rc.d/init.d/functions
 
@@ -53,6 +67,8 @@ case "$1" in
 start)
 # Cassandra startup
 echo -n "Starting Cassandra: "
+[ -d `dirname "$pid_file"` ] || \
+install -m 755 -o $CASSANDRA_OWNR -g $CASSANDRA_OWNR -d `dirname 
$pid_file`
 su $CASSANDRA_OWNR -c "$CASSANDRA_PROG -p $pid_file" > $log_file 2>&1
 retval=$?
 [ $retval -eq 0 ] && touch $lock_file
@@ -64,16 +80,26 @@ case "$1" in
 su $CASSANDRA_OWNR -c "kill `cat $pid_file`"
 retval=$?
 [ $retval -eq 0 ] && rm -f $lock_file
-for t in `seq 40`; do $0 status > /dev/null 2>&1 && sleep 0.5 || 
break; done
+for t in `seq 40`; do
+status -p $pid_file cassandra > /dev/null 2>&1
+

[15/19] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/a5a74469
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/a5a74469
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/a5a74469

Branch: refs/heads/cassandra-3.0
Commit: a5a744693a59a32f8e77ad4f6df282bf9a1c4041
Parents: f3e38cb 83f28ce
Author: Michael Shuler 
Authored: Wed Jun 21 14:09:15 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:09:15 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[11/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83f28ce3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83f28ce3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83f28ce3

Branch: refs/heads/cassandra-3.11
Commit: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
Parents: c9d3b30 9369db1
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:38 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:38 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[13/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

2017-06-21 Thread mshuler 
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83f28ce3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83f28ce3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83f28ce3

Branch: refs/heads/trunk
Commit: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
Parents: c9d3b30 9369db1
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:38 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:38 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[07/19] cassandra git commit: Prepare 2.2.10 release

2017-06-21 Thread mshuler 
Prepare 2.2.10 release


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c9d3b30d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c9d3b30d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c9d3b30d

Branch: refs/heads/trunk
Commit: c9d3b30dbd7d5edb3bac62e3ced1dfe03ec68029
Parents: 13e153b
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:31 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:31 2017 -0500

--
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c9d3b30d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index e561309..a291da3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.2.10) UNRELEASED; urgency=medium
+cassandra (2.2.10) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 14:02:39 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 14:07:47 -0500
 
 cassandra (2.2.9) unstable; urgency=medium
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[08/19] cassandra git commit: Prepare 2.2.10 release

2017-06-21 Thread mshuler 
Prepare 2.2.10 release


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c9d3b30d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c9d3b30d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c9d3b30d

Branch: refs/heads/cassandra-2.2
Commit: c9d3b30dbd7d5edb3bac62e3ced1dfe03ec68029
Parents: 13e153b
Author: Michael Shuler 
Authored: Wed Jun 21 14:08:31 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:08:31 2017 -0500

--
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c9d3b30d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index e561309..a291da3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.2.10) UNRELEASED; urgency=medium
+cassandra (2.2.10) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 14:02:39 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 14:07:47 -0500
 
 cassandra (2.2.9) unstable; urgency=medium
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[18/19] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2017-06-21 Thread mshuler 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e8a58264
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e8a58264
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e8a58264

Branch: refs/heads/cassandra-3.11
Commit: e8a58264e4a921f11fca08ba594c07f5f6136719
Parents: 88dee7e a5a7446
Author: Michael Shuler 
Authored: Wed Jun 21 14:09:38 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:09:38 2017 -0500

--

--



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[03/19] cassandra git commit: Prepare 2.1.18 release

2017-06-21 Thread mshuler 
Prepare 2.1.18 release

- release debian/changelog
- backport RPM packaging fixes from cassandra-2.2 branch for
  CASSANDRA-13046, CASSANDRA-13434, CASSANDRA-13435, CASSANDRA-13433,
  and CASSANDRA-13493


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9369db1d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9369db1d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9369db1d

Branch: refs/heads/cassandra-2.2
Commit: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
Parents: fdb8c96
Author: Michael Shuler 
Authored: Wed Jun 21 13:57:40 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:04:21 2017 -0500

--
 debian/changelog  |  4 ++--
 redhat/README.md  | 19 ++-
 redhat/cassandra  | 38 --
 redhat/cassandra.spec |  7 +--
 4 files changed, 49 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index 48ed24b..a0ee850 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.1.18) UNRELEASED; urgency=medium
+cassandra (2.1.18) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 13:59:40 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 13:57:08 -0500
 
 cassandra (2.1.17) unstable; urgency=medium
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/README.md
--
diff --git a/redhat/README.md b/redhat/README.md
index 0b2ab0d..cab42a7 100644
--- a/redhat/README.md
+++ b/redhat/README.md
@@ -7,25 +7,26 @@
 ### Step 1:
 - Build and copy sources to build tree:
 ```
-ant artifacts
-cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/
+ant artifacts -Drelease=true
 ```
 
 ### Step 2:
 - Since there is no version specified in the SPEC file, one needs to be passed 
at `rpmbuild` time (example with 4.0):
 ```
-rpmbuild --define="version 4.0" -ba redhat/cassandra.spec
+mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS}
+rpmbuild --define="version 4.0" \
+--define="revision $(date +"%Y%m%d")git$(git rev-parse --short 
HEAD)%{?dist}" \
+--define "_topdir $(pwd)/build/rpmbuild" \
+--define "_sourcedir $(pwd)/build" \
+-ba redhat/cassandra.spec
 ```
 
+Use revision value in the example above for git based snapshots. Change to 
`--define="revision 1"` for non-snapshot releases.
+
 - RPM files can be found in their respective build tree directories:
 ```
-ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/
+ls -l build/rpmbuild/{SRPMS,RPMS}/
 ```
 
 ### Hint:
 - Don't build packages as root..
-```
-# this makes your RPM_BUILD_DIR = ~/rpmbuild
-mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
-echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros
-```

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/cassandra
--
diff --git a/redhat/cassandra b/redhat/cassandra
index 3e59534..677ff8c 100644
--- a/redhat/cassandra
+++ b/redhat/cassandra
@@ -3,9 +3,23 @@
 # /etc/init.d/cassandra
 #
 # Startup script for Cassandra
-# 
-# chkconfig: 2345 20 80
+#
+# chkconfig: 2345 80 20
 # description: Starts and stops Cassandra
+# pidfile: /var/run/cassandra/cassandra.pid
+
+### BEGIN INIT INFO
+# Provides:  cassandra
+# Required-Start:$remote_fs $network $named $time
+# Required-Stop: $remote_fs $network $named $time
+# Should-Start:  ntp mdadm
+# Should-Stop:   ntp mdadm
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+# Short-Description: distributed storage system for structured data
+# Description:   Cassandra is a distributed (peer-to-peer) system for
+#the management and storage of structured data.
+### END INIT INFO
 
 . /etc/rc.d/init.d/functions
 
@@ -53,6 +67,8 @@ case "$1" in
 start)
 # Cassandra startup
 echo -n "Starting Cassandra: "
+[ -d `dirname "$pid_file"` ] || \
+install -m 755 -o $CASSANDRA_OWNR -g $CASSANDRA_OWNR -d `dirname 
$pid_file`
 su $CASSANDRA_OWNR -c "$CASSANDRA_PROG -p $pid_file" > $log_file 2>&1
 retval=$?
 [ $retval -eq 0 ] && touch $lock_file
@@ -64,16 +80,26 @@ case "$1" in
 su $CASSANDRA_OWNR -c "kill `cat $pid_file`"
 retval=$?
 [ $retval -eq 0 ] && rm -f $lock_file
-for t in `seq 40`; do $0 status > /dev/null 2>&1 && sleep 0.5 || 
break; done
+for t in `seq 40`; do
+status -p $pid_file cassandra > /dev/null 2>&1
+

[01/19] cassandra git commit: Prepare 2.1.18 release

2017-06-21 Thread mshuler 
Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.1 fdb8c9610 -> 9369db1df
  refs/heads/cassandra-2.2 13e153b09 -> 83f28ce3c
  refs/heads/cassandra-3.0 f3e38cb63 -> a5a744693
  refs/heads/cassandra-3.11 88dee7e9d -> e8a58264e
  refs/heads/trunk 5eca432ea -> cdb01675e


Prepare 2.1.18 release

- release debian/changelog
- backport RPM packaging fixes from cassandra-2.2 branch for
  CASSANDRA-13046, CASSANDRA-13434, CASSANDRA-13435, CASSANDRA-13433,
  and CASSANDRA-13493


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9369db1d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9369db1d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9369db1d

Branch: refs/heads/cassandra-2.1
Commit: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
Parents: fdb8c96
Author: Michael Shuler 
Authored: Wed Jun 21 13:57:40 2017 -0500
Committer: Michael Shuler 
Committed: Wed Jun 21 14:04:21 2017 -0500

--
 debian/changelog  |  4 ++--
 redhat/README.md  | 19 ++-
 redhat/cassandra  | 38 --
 redhat/cassandra.spec |  7 +--
 4 files changed, 49 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/debian/changelog
--
diff --git a/debian/changelog b/debian/changelog
index 48ed24b..a0ee850 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,8 @@
-cassandra (2.1.18) UNRELEASED; urgency=medium
+cassandra (2.1.18) unstable; urgency=medium
 
   * New release
 
- -- Michael Shuler   Tue, 21 Feb 2017 13:59:40 -0600
+ -- Michael Shuler   Wed, 21 Jun 2017 13:57:08 -0500
 
 cassandra (2.1.17) unstable; urgency=medium
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/README.md
--
diff --git a/redhat/README.md b/redhat/README.md
index 0b2ab0d..cab42a7 100644
--- a/redhat/README.md
+++ b/redhat/README.md
@@ -7,25 +7,26 @@
 ### Step 1:
 - Build and copy sources to build tree:
 ```
-ant artifacts
-cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/
+ant artifacts -Drelease=true
 ```
 
 ### Step 2:
 - Since there is no version specified in the SPEC file, one needs to be passed 
at `rpmbuild` time (example with 4.0):
 ```
-rpmbuild --define="version 4.0" -ba redhat/cassandra.spec
+mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS}
+rpmbuild --define="version 4.0" \
+--define="revision $(date +"%Y%m%d")git$(git rev-parse --short 
HEAD)%{?dist}" \
+--define "_topdir $(pwd)/build/rpmbuild" \
+--define "_sourcedir $(pwd)/build" \
+-ba redhat/cassandra.spec
 ```
 
+Use revision value in the example above for git based snapshots. Change to 
`--define="revision 1"` for non-snapshot releases.
+
 - RPM files can be found in their respective build tree directories:
 ```
-ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/
+ls -l build/rpmbuild/{SRPMS,RPMS}/
 ```
 
 ### Hint:
 - Don't build packages as root..
-```
-# this makes your RPM_BUILD_DIR = ~/rpmbuild
-mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
-echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros
-```

http://git-wip-us.apache.org/repos/asf/cassandra/blob/9369db1d/redhat/cassandra
--
diff --git a/redhat/cassandra b/redhat/cassandra
index 3e59534..677ff8c 100644
--- a/redhat/cassandra
+++ b/redhat/cassandra
@@ -3,9 +3,23 @@
 # /etc/init.d/cassandra
 #
 # Startup script for Cassandra
-# 
-# chkconfig: 2345 20 80
+#
+# chkconfig: 2345 80 20
 # description: Starts and stops Cassandra
+# pidfile: /var/run/cassandra/cassandra.pid
+
+### BEGIN INIT INFO
+# Provides:  cassandra
+# Required-Start:$remote_fs $network $named $time
+# Required-Stop: $remote_fs $network $named $time
+# Should-Start:  ntp mdadm
+# Should-Stop:   ntp mdadm
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+# Short-Description: distributed storage system for structured data
+# Description:   Cassandra is a distributed (peer-to-peer) system for
+#the management and storage of structured data.
+### END INIT INFO
 
 . /etc/rc.d/init.d/functions
 
@@ -53,6 +67,8 @@ case "$1" in
 start)
 # Cassandra startup
 echo -n "Starting Cassandra: "
+[ -d `dirname "$pid_file"` ] || \
+install -m 755 -o $CASSANDRA_OWNR -g $CASSANDRA_OWNR -d `dirname 
$pid_file`
 su $CASSANDRA_OWNR -c "$CASSANDRA_PROG -p $pid_file" > $log_file 2>&1
 retval=$?
 [ $retval -eq 0 ] && touch $lock_file
@@ -64,16 +80,26 @@ case "$1" in
 su

[jira] [Updated] (CASSANDRA-13629) Wait for batchlog replay during bootstrap

2017-06-21 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrés de la Peña updated CASSANDRA-13629:
--
Issue Type: Sub-task  (was: Bug)
Parent: CASSANDRA-13162

> Wait for batchlog replay during bootstrap
> -
>
> Key: CASSANDRA-13629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13629
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Materialized Views
>Reporter: Andrés de la Peña
>Assignee: Andrés de la Peña
>
> As part of the problem described in 
> [CASSANDRA-13162|https://issues.apache.org/jira/browse/CASSANDRA-13162], the 
> bootstrap logic won't wait for the backlogged batchlog to be fully replayed 
> before changing the new bootstrapping node to "UN" state. We should wait for 
> batchlog replay before making the node available.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Created] (CASSANDRA-13631) add header parameter size to internode messaging protocol

2017-06-21 Thread Jason Brown (JIRA) 
Jason Brown created CASSANDRA-13631:
---

 Summary: add header parameter size to internode messaging protocol
 Key: CASSANDRA-13631
 URL: https://issues.apache.org/jira/browse/CASSANDRA-13631
 Project: Cassandra
  Issue Type: Task
  Components: Streaming and Messaging
Reporter: Jason Brown
Assignee: Jason Brown
Priority: Minor


as netty is not a streaming/blocking protocol and works best when buffer sizes 
are known, I had to do a bunch of contortions in {{MessageInHandler}} (as part 
of CASSANDRA-8457) to safely read the message header parameters. If we add a 
header parameters size field to the internode messaging protocol, the header 
parsing code would be dramatically simpler (note: we'll still need the existing 
parsing to support the cluster upgrade use case). An alternative to adding a 
new field is to hijack the existing header parameter count field; that field is 
an {{int}}, so field width is not an issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-13629) Wait for batchlog replay during bootstrap

2017-06-21 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrés de la Peña reassigned CASSANDRA-13629:
-

   Assignee: Andrés de la Peña
Component/s: Materialized Views

> Wait for batchlog replay during bootstrap
> -
>
> Key: CASSANDRA-13629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13629
> Project: Cassandra
>  Issue Type: Bug
>  Components: Materialized Views
>Reporter: Andrés de la Peña
>Assignee: Andrés de la Peña
>
> As part of the problem described in 
> [CASSANDRA-13162|https://issues.apache.org/jira/browse/CASSANDRA-13162], the 
> bootstrap logic won't wait for the backlogged batchlog to be fully replayed 
> before changing the new bootstrapping node to "UN" state. We should wait for 
> batchlog replay before making the node available.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Created] (CASSANDRA-13630) support large internode messages with netty

2017-06-21 Thread Jason Brown (JIRA) 
Jason Brown created CASSANDRA-13630:
---

 Summary: support large internode messages with netty
 Key: CASSANDRA-13630
 URL: https://issues.apache.org/jira/browse/CASSANDRA-13630
 Project: Cassandra
  Issue Type: Task
  Components: Streaming and Messaging
Reporter: Jason Brown
Assignee: Jason Brown
 Fix For: 4.0


As part of CASSANDRA-8457, we decided to punt on large mesages to reduce the 
scope of that ticket. However, we still need that functionality to ship a 
correctly operating internode messaging subsystem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Created] (CASSANDRA-13629) Wait for batchlog replay during bootstrap

2017-06-21 Thread JIRA 
Andrés de la Peña created CASSANDRA-13629:
-

 Summary: Wait for batchlog replay during bootstrap
 Key: CASSANDRA-13629
 URL: https://issues.apache.org/jira/browse/CASSANDRA-13629
 Project: Cassandra
  Issue Type: Bug
Reporter: Andrés de la Peña


As part of the problem described in 
[CASSANDRA-13162|https://issues.apache.org/jira/browse/CASSANDRA-13162], the 
bootstrap logic won't wait for the backlogged batchlog to be fully replayed 
before changing the new bootstrapping node to "UN" state. We should wait for 
batchlog replay before making the node available.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Created] (CASSANDRA-13628) switch peer-to-peer networking to non-blocking I/O via netty

2017-06-21 Thread Jason Brown (JIRA) 
Jason Brown created CASSANDRA-13628:
---

 Summary: switch peer-to-peer networking to non-blocking I/O via 
netty
 Key: CASSANDRA-13628
 URL: https://issues.apache.org/jira/browse/CASSANDRA-13628
 Project: Cassandra
  Issue Type: Improvement
  Components: Core, Streaming and Messaging
Reporter: Jason Brown
Assignee: Jason Brown
 Fix For: 4.0


This is a parent ticket for linking all the work to be done for switching 
peer-to-peer networking to use non-blocking I/O via netty



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Joaquin Casares (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057787#comment-16057787
 ] 

Joaquin Casares commented on CASSANDRA-13625:
-

Sorry for that confusion, I've updated the main description. Thanks for 
pointing that out! :)

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>Assignee: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Joaquin Casares (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joaquin Casares reassigned CASSANDRA-13625:
---

Assignee: Joaquin Casares

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>Assignee: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Joaquin Casares (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joaquin Casares updated CASSANDRA-13625:

Description: 
{{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does not 
make reference of the config in any place within its codebase:

https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891

CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
Version/s marked as 3.0.7, 3.7, and 3.8.

Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
2.2.9, < 3}}.

{NOFORMAT}
~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
max_value_size_in_mb .
conf/cassandra.yaml:# max_value_size_in_mb: 256
{NOFORMAT}

  was:
{{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does not 
make reference of the config in any place within its codebase:

https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891

CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
Version/s marked as 3.0.7, 3.7, and 3.8.

Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.

{NOFORMAT}
~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
max_value_size_in_mb .
conf/cassandra.yaml:# max_value_size_in_mb: 256
{NOFORMAT}


> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>= 
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Romain Hardouin (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057768#comment-16057768
 ] 

Romain Hardouin edited comment on CASSANDRA-13625 at 6/21/17 4:17 PM:
--

Ok! I understood {{>= 2.2.9}} and not {{>= 2.2.9, < 3}}


was (Author: rha):
Ok! I understood >= 2.2.9 

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Romain Hardouin (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057768#comment-16057768
 ] 

Romain Hardouin commented on CASSANDRA-13625:
-

Ok! I understood >= 2.2.9 

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Joaquin Casares (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057755#comment-16057755
 ] 

Joaquin Casares commented on CASSANDRA-13625:
-

[~rha], I'm not for removing the setting from trunk, just from the 2.2.x 
cassandra.yaml where the setting has never been implemented.

If you were to switch to the cassandra-2.2.9 branch and run your grep script 
again, it should come back with no references.

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

cassandra git commit: Ninja fix: Re-add wrongly removed futures-2.1.6 python library

2017-06-21 Thread blerer 
Repository: cassandra
Updated Branches:
  refs/heads/trunk 67247394d -> 5eca432ea


Ninja fix: Re-add wrongly removed futures-2.1.6 python library


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5eca432e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5eca432e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5eca432e

Branch: refs/heads/trunk
Commit: 5eca432ea37f02f3abc6a41713d3a580e5c706ef
Parents: 6724739
Author: Benjamin Lerer 
Authored: Wed Jun 21 17:11:37 2017 +0200
Committer: Benjamin Lerer 
Committed: Wed Jun 21 17:11:37 2017 +0200

--
 lib/futures-2.1.6-py2.py3-none-any.zip | Bin 0 -> 16571 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/5eca432e/lib/futures-2.1.6-py2.py3-none-any.zip
--
diff --git a/lib/futures-2.1.6-py2.py3-none-any.zip 
b/lib/futures-2.1.6-py2.py3-none-any.zip
new file mode 100644
index 000..50bd78b
Binary files /dev/null and b/lib/futures-2.1.6-py2.py3-none-any.zip differ


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-9625) GraphiteReporter not reporting

2017-06-21 Thread Marcus Eriksson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-9625:
---
Resolution: Cannot Reproduce
Status: Resolved  (was: Patch Available)

Closing, please reopen if this still happens with a recent version of Cassandra

> GraphiteReporter not reporting
> --
>
> Key: CASSANDRA-9625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9625
> Project: Cassandra
>  Issue Type: Bug
> Environment: Debian Jessie, 7u79-2.5.5-1~deb8u1, Cassandra 2.1.3
>Reporter: Eric Evans
> Attachments: metrics.yaml, Screen Shot 2016-04-13 at 10.40.58 AM.png, 
> thread-dump2.log, thread-dump.log
>
>
> When upgrading from 2.1.3 to 2.1.6, the Graphite metrics reporter stops 
> working.  The usual startup is logged, and one batch of samples is sent, but 
> the reporting interval comes and goes, and no other samples are ever sent.  
> The logs are free from errors.
> Frustratingly, metrics reporting works in our smaller (staging) environment 
> on 2.1.6; We are able to reproduce this on all 6 of production nodes, but not 
> on a 3 node (otherwise identical) staging cluster (maybe it takes a certain 
> level of concurrency?).
> Attached is a thread dump, and our metrics.yaml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13215) Cassandra nodes startup time 20x more after upgarding to 3.x

2017-06-21 Thread Marcus Eriksson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-13215:

Reproduced In: 3.10, 3.9, 3.7  (was: 3.7, 3.9, 3.10)
   Status: Open  (was: Awaiting Feedback)

> Cassandra nodes startup time 20x more after upgarding to 3.x
> 
>
> Key: CASSANDRA-13215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13215
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
> Environment: Cluster setup: two datacenters (dc-main, dc-backup).
> dc-main - 9 servers, no vnodes
> dc-backup - 6 servers, vnodes
>Reporter: Viktor Kuzmin
>Assignee: Marcus Eriksson
> Attachments: simple-cache.patch
>
>
> CompactionStrategyManage.getCompactionStrategyIndex is called on each sstable 
> at startup. And this function calls StorageService.getDiskBoundaries. And 
> getDiskBoundaries calls AbstractReplicationStrategy.getAddressRanges.
> It appears that last function can be really slow. In our environment we have 
> 1545 tokens and with NetworkTopologyStrategy it can make 1545*1545 
> computations in worst case (maybe I'm wrong, but it really takes lot's of 
> cpu).
> Also this function can affect runtime later, cause it is called not only 
> during startup.
> I've tried to implement simple cache for getDiskBoundaries results and now 
> startup time is about one minute instead of 25m, but I'm not sure if it's a 
> good solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13418) Allow TWCS to ignore overlaps when dropping fully expired sstables

2017-06-21 Thread Marcus Eriksson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057490#comment-16057490
 ] 

Marcus Eriksson commented on CASSANDRA-13418:
-

Had a (too?) quick read-through

Would it be possible to move all (or at least most) logic to the TWCS-classes 
as that is the only place it is used? Perhaps just adding a boolean to 
getFullyExpiredSSTables() that states whether we are aggressive or not? Also 
making the CompactionParams.Option.UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION a 
TWCS-only option would make sense right?

> Allow TWCS to ignore overlaps when dropping fully expired sstables
> --
>
> Key: CASSANDRA-13418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13418
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Corentin Chary
>  Labels: twcs
> Attachments: twcs-cleanup.png
>
>
> http://thelastpickle.com/blog/2016/12/08/TWCS-part1.html explains it well. If 
> you really want read-repairs you're going to have sstables blocking the 
> expiration of other fully expired SSTables because they overlap.
> You can set unchecked_tombstone_compaction = true or tombstone_threshold to a 
> very low value and that will purge the blockers of old data that should 
> already have expired, thus removing the overlaps and allowing the other 
> SSTables to expire.
> The thing is that this is rather CPU intensive and not optimal. If you have 
> time series, you might not care if all your data doesn't exactly expire at 
> the right time, or if data re-appears for some time, as long as it gets 
> deleted as soon as it can. And in this situation I believe it would be really 
> beneficial to allow users to simply ignore overlapping SSTables when looking 
> for fully expired ones.
> To the question: why would you need read-repairs ?
> - Full repairs basically take longer than the TTL of the data on my dataset, 
> so this isn't really effective.
> - Even with a 10% chances of doing a repair, we found out that this would be 
> enough to greatly reduce entropy of the most used data (and if you have 
> timeseries, you're likely to have a dashboard doing the same important 
> queries over and over again).
> - LOCAL_QUORUM is too expensive (need >3 replicas), QUORUM is too slow.
> I'll try to come up with a patch demonstrating how this would work, try it on 
> our system and report the effects.
> cc: [~adejanovski], [~rgerard] as I know you worked on similar issues already.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Created] (CASSANDRA-13627) Index queries are rejected on COMPACT tables

2017-06-21 Thread Benjamin Lerer (JIRA) 
Benjamin Lerer created CASSANDRA-13627:
--

 Summary: Index queries are rejected on COMPACT tables
 Key: CASSANDRA-13627
 URL: https://issues.apache.org/jira/browse/CASSANDRA-13627
 Project: Cassandra
  Issue Type: Bug
Reporter: Benjamin Lerer
Assignee: Benjamin Lerer


Since {{3.0}}, {{compact}} tables are using under the hood {{static}} columns. 
Due to that {{SELECT}} queries using secondary indexes get rejected with the 
following error:
{{Queries using 2ndary indexes don't support selecting only static columns}}.

This problem can be reproduced using the following unit test:
{code}@Test
public void testIndicesOnCompactTable() throws Throwable
{
createTable("CREATE TABLE %s (pk int PRIMARY KEY, v int) WITH COMPACT 
STORAGE");
createIndex("CREATE INDEX ON %s(v)");

execute("INSERT INTO %S (pk, v) VALUES (?, ?)", 1, 1);
execute("INSERT INTO %S (pk, v) VALUES (?, ?)", 2, 1);
execute("INSERT INTO %S (pk, v) VALUES (?, ?)", 3, 3);

assertRows(execute("SELECT pk, v FROM %s WHERE v = 1"),
   row(1, 1),
   row(2, 1));

}{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-13418) Allow TWCS to ignore overlaps when dropping fully expired sstables

2017-06-21 Thread Corentin Chary (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057392#comment-16057392
 ] 

Corentin Chary edited comment on CASSANDRA-13418 at 6/21/17 12:21 PM:
--

Latest version of the patch works as it should: 
https://github.com/criteo-forks/cassandra/commit/da4a5c17448dab64aeb4295bb7401afbea9edf51

!twcs-cleanup.png!


was (Author: iksaif):
Latest version of the patch works as it should: 
https://github.com/criteo-forks/cassandra/commit/da4a5c17448dab64aeb4295bb7401afbea9edf51

!twcs-cleanup.png|thumbnail!

> Allow TWCS to ignore overlaps when dropping fully expired sstables
> --
>
> Key: CASSANDRA-13418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13418
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Corentin Chary
>  Labels: twcs
> Attachments: twcs-cleanup.png
>
>
> http://thelastpickle.com/blog/2016/12/08/TWCS-part1.html explains it well. If 
> you really want read-repairs you're going to have sstables blocking the 
> expiration of other fully expired SSTables because they overlap.
> You can set unchecked_tombstone_compaction = true or tombstone_threshold to a 
> very low value and that will purge the blockers of old data that should 
> already have expired, thus removing the overlaps and allowing the other 
> SSTables to expire.
> The thing is that this is rather CPU intensive and not optimal. If you have 
> time series, you might not care if all your data doesn't exactly expire at 
> the right time, or if data re-appears for some time, as long as it gets 
> deleted as soon as it can. And in this situation I believe it would be really 
> beneficial to allow users to simply ignore overlapping SSTables when looking 
> for fully expired ones.
> To the question: why would you need read-repairs ?
> - Full repairs basically take longer than the TTL of the data on my dataset, 
> so this isn't really effective.
> - Even with a 10% chances of doing a repair, we found out that this would be 
> enough to greatly reduce entropy of the most used data (and if you have 
> timeseries, you're likely to have a dashboard doing the same important 
> queries over and over again).
> - LOCAL_QUORUM is too expensive (need >3 replicas), QUORUM is too slow.
> I'll try to come up with a patch demonstrating how this would work, try it on 
> our system and report the effects.
> cc: [~adejanovski], [~rgerard] as I know you worked on similar issues already.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13418) Allow TWCS to ignore overlaps when dropping fully expired sstables

2017-06-21 Thread Corentin Chary (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057392#comment-16057392
 ] 

Corentin Chary commented on CASSANDRA-13418:


Latest version of the patch works as it should: 
https://github.com/criteo-forks/cassandra/commit/da4a5c17448dab64aeb4295bb7401afbea9edf51

!twcs-cleanup.png|thumbnail!

> Allow TWCS to ignore overlaps when dropping fully expired sstables
> --
>
> Key: CASSANDRA-13418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13418
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Corentin Chary
>  Labels: twcs
> Attachments: twcs-cleanup.png
>
>
> http://thelastpickle.com/blog/2016/12/08/TWCS-part1.html explains it well. If 
> you really want read-repairs you're going to have sstables blocking the 
> expiration of other fully expired SSTables because they overlap.
> You can set unchecked_tombstone_compaction = true or tombstone_threshold to a 
> very low value and that will purge the blockers of old data that should 
> already have expired, thus removing the overlaps and allowing the other 
> SSTables to expire.
> The thing is that this is rather CPU intensive and not optimal. If you have 
> time series, you might not care if all your data doesn't exactly expire at 
> the right time, or if data re-appears for some time, as long as it gets 
> deleted as soon as it can. And in this situation I believe it would be really 
> beneficial to allow users to simply ignore overlapping SSTables when looking 
> for fully expired ones.
> To the question: why would you need read-repairs ?
> - Full repairs basically take longer than the TTL of the data on my dataset, 
> so this isn't really effective.
> - Even with a 10% chances of doing a repair, we found out that this would be 
> enough to greatly reduce entropy of the most used data (and if you have 
> timeseries, you're likely to have a dashboard doing the same important 
> queries over and over again).
> - LOCAL_QUORUM is too expensive (need >3 replicas), QUORUM is too slow.
> I'll try to come up with a patch demonstrating how this would work, try it on 
> our system and report the effects.
> cc: [~adejanovski], [~rgerard] as I know you worked on similar issues already.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13418) Allow TWCS to ignore overlaps when dropping fully expired sstables

2017-06-21 Thread Corentin Chary (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Corentin Chary updated CASSANDRA-13418:
---
Attachment: twcs-cleanup.png

> Allow TWCS to ignore overlaps when dropping fully expired sstables
> --
>
> Key: CASSANDRA-13418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13418
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Corentin Chary
>  Labels: twcs
> Attachments: twcs-cleanup.png
>
>
> http://thelastpickle.com/blog/2016/12/08/TWCS-part1.html explains it well. If 
> you really want read-repairs you're going to have sstables blocking the 
> expiration of other fully expired SSTables because they overlap.
> You can set unchecked_tombstone_compaction = true or tombstone_threshold to a 
> very low value and that will purge the blockers of old data that should 
> already have expired, thus removing the overlaps and allowing the other 
> SSTables to expire.
> The thing is that this is rather CPU intensive and not optimal. If you have 
> time series, you might not care if all your data doesn't exactly expire at 
> the right time, or if data re-appears for some time, as long as it gets 
> deleted as soon as it can. And in this situation I believe it would be really 
> beneficial to allow users to simply ignore overlapping SSTables when looking 
> for fully expired ones.
> To the question: why would you need read-repairs ?
> - Full repairs basically take longer than the TTL of the data on my dataset, 
> so this isn't really effective.
> - Even with a 10% chances of doing a repair, we found out that this would be 
> enough to greatly reduce entropy of the most used data (and if you have 
> timeseries, you're likely to have a dashboard doing the same important 
> queries over and over again).
> - LOCAL_QUORUM is too expensive (need >3 replicas), QUORUM is too slow.
> I'll try to come up with a patch demonstrating how this would work, try it on 
> our system and report the effects.
> cc: [~adejanovski], [~rgerard] as I know you worked on similar issues already.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13087) Not enough bytes exception during compaction

2017-06-21 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057354#comment-16057354
 ] 

Benjamin Lerer commented on CASSANDRA-13087:


[~fabrice.facorat] Thanks for the information. I will review the patch.

> Not enough bytes exception during compaction
> 
>
> Key: CASSANDRA-13087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13087
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: Ubuntu 14.04.3 LTS, Cassandra 2.1.14
>Reporter: FACORAT
>Assignee: Cyril Scetbon
> Attachments: CASSANDRA-13087.patch
>
>
> After a repair we have compaction exceptions on some nodes and its spreading
> {noformat}
> ERROR [CompactionExecutor:14065] 2016-12-30 14:45:07,245 
> CassandraDaemon.java:229 - Exception in thread 
> Thread[CompactionExecutor:14065,1,main]
> java.lang.IllegalArgumentException: Not enough bytes. Offset: 5. Length: 
> 20275. Buffer size: 12594
> at 
> org.apache.cassandra.db.composites.AbstractCType.checkRemaining(AbstractCType.java:378)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCompoundCellNameType.fromByteBuffer(AbstractCompoundCellNameType.java:100)
>  ~[apache-cassandra-2.1.14.ja
> r:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:398)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:382)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.OnDiskAtom$Serializer.deserializeFromSSTable(OnDiskAtom.java:75)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:52) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:46) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.io.sstable.SSTableIdentityIterator.hasNext(SSTableIdentityIterator.java:171)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.MergeIterator$OneToOne.computeNext(MergeIterator.java:202)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.Iterators$7.computeNext(Iterators.java:645) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.db.ColumnIndex$Builder.buildForCompaction(ColumnIndex.java:166)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.LazilyCompactedRow.write(LazilyCompactedRow.java:121)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:193) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.append(SSTableRewriter.java:127)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:197)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:73)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:264)
>  ~[apache-cassandra-2.1.14.jar:2
> .1.14]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_60]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_60]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_60]
> at 
>

[jira] [Updated] (CASSANDRA-13087) Not enough bytes exception during compaction

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-13087:
---
Reviewer: Benjamin Lerer
  Status: Patch Available  (was: Open)

> Not enough bytes exception during compaction
> 
>
> Key: CASSANDRA-13087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13087
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: Ubuntu 14.04.3 LTS, Cassandra 2.1.14
>Reporter: FACORAT
>Assignee: Cyril Scetbon
> Attachments: CASSANDRA-13087.patch
>
>
> After a repair we have compaction exceptions on some nodes and its spreading
> {noformat}
> ERROR [CompactionExecutor:14065] 2016-12-30 14:45:07,245 
> CassandraDaemon.java:229 - Exception in thread 
> Thread[CompactionExecutor:14065,1,main]
> java.lang.IllegalArgumentException: Not enough bytes. Offset: 5. Length: 
> 20275. Buffer size: 12594
> at 
> org.apache.cassandra.db.composites.AbstractCType.checkRemaining(AbstractCType.java:378)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCompoundCellNameType.fromByteBuffer(AbstractCompoundCellNameType.java:100)
>  ~[apache-cassandra-2.1.14.ja
> r:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:398)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:382)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.OnDiskAtom$Serializer.deserializeFromSSTable(OnDiskAtom.java:75)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:52) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:46) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.io.sstable.SSTableIdentityIterator.hasNext(SSTableIdentityIterator.java:171)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.MergeIterator$OneToOne.computeNext(MergeIterator.java:202)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.Iterators$7.computeNext(Iterators.java:645) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.db.ColumnIndex$Builder.buildForCompaction(ColumnIndex.java:166)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.LazilyCompactedRow.write(LazilyCompactedRow.java:121)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:193) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.append(SSTableRewriter.java:127)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:197)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:73)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:264)
>  ~[apache-cassandra-2.1.14.jar:2
> .1.14]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_60]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_60]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_60]
> at 
>

[jira] [Assigned] (CASSANDRA-13087) Not enough bytes exception during compaction

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer reassigned CASSANDRA-13087:
--

Assignee: Cyril Scetbon

> Not enough bytes exception during compaction
> 
>
> Key: CASSANDRA-13087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13087
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: Ubuntu 14.04.3 LTS, Cassandra 2.1.14
>Reporter: FACORAT
>Assignee: Cyril Scetbon
> Attachments: CASSANDRA-13087.patch
>
>
> After a repair we have compaction exceptions on some nodes and its spreading
> {noformat}
> ERROR [CompactionExecutor:14065] 2016-12-30 14:45:07,245 
> CassandraDaemon.java:229 - Exception in thread 
> Thread[CompactionExecutor:14065,1,main]
> java.lang.IllegalArgumentException: Not enough bytes. Offset: 5. Length: 
> 20275. Buffer size: 12594
> at 
> org.apache.cassandra.db.composites.AbstractCType.checkRemaining(AbstractCType.java:378)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCompoundCellNameType.fromByteBuffer(AbstractCompoundCellNameType.java:100)
>  ~[apache-cassandra-2.1.14.ja
> r:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:398)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:382)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.OnDiskAtom$Serializer.deserializeFromSSTable(OnDiskAtom.java:75)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:52) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:46) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.io.sstable.SSTableIdentityIterator.hasNext(SSTableIdentityIterator.java:171)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.MergeIterator$OneToOne.computeNext(MergeIterator.java:202)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.Iterators$7.computeNext(Iterators.java:645) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.db.ColumnIndex$Builder.buildForCompaction(ColumnIndex.java:166)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.LazilyCompactedRow.write(LazilyCompactedRow.java:121)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:193) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.append(SSTableRewriter.java:127)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:197)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:73)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:264)
>  ~[apache-cassandra-2.1.14.jar:2
> .1.14]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_60]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_60]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_60]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_60]
>

[jira] [Commented] (CASSANDRA-13618) CassandraRoleManager setup task improvement

2017-06-21 Thread Sam Tunnicliffe (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057332#comment-16057332
 ] 

Sam Tunnicliffe commented on CASSANDRA-13618:
-

Thanks, the changes LGTM. The dtest results still look a bit dodgy though, 
particularly the 3.11 run. How stable are those dev branch jobs now? There seem 
to be several tests failing/erroring which aren't showing as flaky on the 
mainline branch jobs.

> CassandraRoleManager setup task improvement
> ---
>
> Key: CASSANDRA-13618
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13618
> Project: Cassandra
>  Issue Type: Bug
>  Components: Auth
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> {{CassandraRoleManager}} blocks some functionality during setup, using a 
> delay added in CASSANDRA-9761 . Unfortunately, this setup is scheduled for 
> 10s after startup, and may not be necessary, meaning immediately after 
> startup some auth related queries may not behave as intended. We can skip 
> this delay without any additional risk.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13087) Not enough bytes exception during compaction

2017-06-21 Thread FACORAT (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057323#comment-16057323
 ] 

FACORAT commented on CASSANDRA-13087:
-

We fix the issues with attached patch.
scrubbing the sstables at the origin won't help as Cassandra and nodetool scrub 
will happily accept orphaned partition keys (i.e partition keys with not 
liveness information and no cells)

[
{"key": "pk_1", "cells": []}

]

However the serialization during streaming will incorrectly handle this use 
case and produce and badly formed sstable.

Only attached patch allow to fix serialization bug for streamed sstables

> Not enough bytes exception during compaction
> 
>
> Key: CASSANDRA-13087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13087
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: Ubuntu 14.04.3 LTS, Cassandra 2.1.14
>Reporter: FACORAT
> Attachments: CASSANDRA-13087.patch
>
>
> After a repair we have compaction exceptions on some nodes and its spreading
> {noformat}
> ERROR [CompactionExecutor:14065] 2016-12-30 14:45:07,245 
> CassandraDaemon.java:229 - Exception in thread 
> Thread[CompactionExecutor:14065,1,main]
> java.lang.IllegalArgumentException: Not enough bytes. Offset: 5. Length: 
> 20275. Buffer size: 12594
> at 
> org.apache.cassandra.db.composites.AbstractCType.checkRemaining(AbstractCType.java:378)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCompoundCellNameType.fromByteBuffer(AbstractCompoundCellNameType.java:100)
>  ~[apache-cassandra-2.1.14.ja
> r:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:398)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:382)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.OnDiskAtom$Serializer.deserializeFromSSTable(OnDiskAtom.java:75)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:52) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:46) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.io.sstable.SSTableIdentityIterator.hasNext(SSTableIdentityIterator.java:171)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.MergeIterator$OneToOne.computeNext(MergeIterator.java:202)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.Iterators$7.computeNext(Iterators.java:645) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.db.ColumnIndex$Builder.buildForCompaction(ColumnIndex.java:166)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.LazilyCompactedRow.write(LazilyCompactedRow.java:121)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:193) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.append(SSTableRewriter.java:127)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:197)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:73)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:264)
>  ~[apache-cassandra-2.1.14.jar:2
> .1.14]
> at 
>

[jira] [Assigned] (CASSANDRA-13215) Cassandra nodes startup time 20x more after upgarding to 3.x

2017-06-21 Thread Marcus Eriksson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson reassigned CASSANDRA-13215:
---

Assignee: Marcus Eriksson

> Cassandra nodes startup time 20x more after upgarding to 3.x
> 
>
> Key: CASSANDRA-13215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13215
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
> Environment: Cluster setup: two datacenters (dc-main, dc-backup).
> dc-main - 9 servers, no vnodes
> dc-backup - 6 servers, vnodes
>Reporter: Viktor Kuzmin
>Assignee: Marcus Eriksson
> Attachments: simple-cache.patch
>
>
> CompactionStrategyManage.getCompactionStrategyIndex is called on each sstable 
> at startup. And this function calls StorageService.getDiskBoundaries. And 
> getDiskBoundaries calls AbstractReplicationStrategy.getAddressRanges.
> It appears that last function can be really slow. In our environment we have 
> 1545 tokens and with NetworkTopologyStrategy it can make 1545*1545 
> computations in worst case (maybe I'm wrong, but it really takes lot's of 
> cpu).
> Also this function can affect runtime later, cause it is called not only 
> during startup.
> I've tried to implement simple cache for getDiskBoundaries results and now 
> startup time is about one minute instead of 25m, but I'm not sure if it's a 
> good solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13215) Cassandra nodes startup time 20x more after upgarding to 3.x

2017-06-21 Thread Viktor Kuzmin (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057322#comment-16057322
 ] 

Viktor Kuzmin commented on CASSANDRA-13215:
---

Marcus Eriksson, It would be great if you'll be able to pick this up.

> Cassandra nodes startup time 20x more after upgarding to 3.x
> 
>
> Key: CASSANDRA-13215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13215
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
> Environment: Cluster setup: two datacenters (dc-main, dc-backup).
> dc-main - 9 servers, no vnodes
> dc-backup - 6 servers, vnodes
>Reporter: Viktor Kuzmin
> Attachments: simple-cache.patch
>
>
> CompactionStrategyManage.getCompactionStrategyIndex is called on each sstable 
> at startup. And this function calls StorageService.getDiskBoundaries. And 
> getDiskBoundaries calls AbstractReplicationStrategy.getAddressRanges.
> It appears that last function can be really slow. In our environment we have 
> 1545 tokens and with NetworkTopologyStrategy it can make 1545*1545 
> computations in worst case (maybe I'm wrong, but it really takes lot's of 
> cpu).
> Also this function can affect runtime later, cause it is called not only 
> during startup.
> I've tried to implement simple cache for getDiskBoundaries results and now 
> startup time is about one minute instead of 25m, but I'm not sure if it's a 
> good solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13603) Change repair midpoint logging from CASSANDRA-13052

2017-06-21 Thread Stefan Podkowinski (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057292#comment-16057292
 ] 

Stefan Podkowinski commented on CASSANDRA-13603:


We should continue to check the midpoint return value. Even if it's just for 
troubleshooting similar problems in the future. 

Throwing an AssertionError instead of just logging an error message is probably 
not a good idea in 2.2. See my comment from before the patch:

{quote}Unfortunately we can't throw here to abort the validation process, as 
the code is executed in it's own thread with the caller waiting for a condition 
to be signaled after completion and without an option to indicate an error (2.x 
only).
{quote}

But 3.0+ should be able to deal with failed SyncTasks, as those are now handled 
as futures. SyncTask.run is currently missing any exception handling, but that 
could be changed.

> Change repair midpoint logging from  CASSANDRA-13052
> 
>
> Key: CASSANDRA-13603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13603
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Trivial
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> In CASSANDRA-13052 , we changed the way we handle repairs on small ranges to 
> make them more sane in general, but {{MerkleTree.differenceHelper}} now 
> erroneously logs at error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13601) Changes requested to the cassandra's debian + rpm installers packages

2017-06-21 Thread Amitkumar Ghatwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057239#comment-16057239
 ] 

Amitkumar Ghatwal commented on CASSANDRA-13601:
---

[~mshuler] - Have added a PR #125 - "parses the architecture and bumps the 
stack only on the desired architecture " . Let me know ur inputs ?

> Changes requested to the cassandra's debian + rpm installers packages
> -
>
> Key: CASSANDRA-13601
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13601
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Packaging
> Environment: ~$ lscpu
> Architecture:  ppc64le
> Byte Order:Little Endian
>Reporter: Amitkumar Ghatwal
>Priority: Minor
>  Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: ppc64le_unaligned_memory_access.patch
>
>
> Hi All,
> Thanks [~mshuler] for helping in installing cassandra using arch independent 
> installers  for debian + rpm packages from here : 
> http://cassandra.apache.org/download/
> For my architecture - " ppc64le" , the installation process from debian + rpm 
> wasn't straightforward. And needed below configuration level changes.
> For Ubuntu- Cassandra 3.10 release - below changes were needed
> 1) echo "deb [arch=amd64] http://www.apache.org/dist/cassandra/debian 310x 
> main" | sudo tee -a /etc/apt/sources.list.d/cassandra.sources.list 
> 2) sed -i -e s/Xss256/Xss512/g /etc/cassandra/jvm.options
> 3) Removing jna-4.0.0.jar and replacing it with latest jna-4.4.0.jar in 
> (/usr/share/cassandra/lib)- Downloaded from here . 
> 4) Restart cassandra service
> For RHEL - Cassandra 3.0.13 release - below changes were needed
> 1) sed -i -e s/Xss256/Xss512/g /etc/cassandra/default.conf/cassandra-env.sh
> 3) Removing jna-4.0.0.jar and replacing it with latest jna-4.4.0.jar in 
> (/usr/share/cassandra/lib)- Downloaded from here . 
> 4) Restart cassandra service
> Could you please help in introducing above changes so that cassandra can be 
> installed from the debian + rpm pcakages and will indeed become architecture 
> independent.
> Regards,
> Amit



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13601) Changes requested to the cassandra's debian + rpm installers packages

2017-06-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057235#comment-16057235
 ] 

ASF GitHub Bot commented on CASSANDRA-13601:


GitHub user ghatwala opened a pull request:

https://github.com/apache/cassandra/pull/125

Increasing stack size for specific platform

As per discussions in JIRA : 
https://issues.apache.org/jira/browse/CASSANDRA-13601 and 
https://issues.apache.org/jira/browse/CASSANDRA-13345 , adding a check to 
increasing the stack size only if architecture type is ppc64le.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ghatwala/cassandra 
CheckArch_and_Stack_Size_Change

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit 073221cb50a8ed0917b71e0034310b8f8e89ac1b
Author: ghatwala 
Date:   2017-06-21T09:23:40Z

Increasing stack size for specific platform

As per discussions in JIRA : 
https://issues.apache.org/jira/browse/CASSANDRA-13601 and 
https://issues.apache.org/jira/browse/CASSANDRA-13345 , adding a check to 
increasing the stack size only if architecture type is ppc64le.




> Changes requested to the cassandra's debian + rpm installers packages
> -
>
> Key: CASSANDRA-13601
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13601
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Packaging
> Environment: ~$ lscpu
> Architecture:  ppc64le
> Byte Order:Little Endian
>Reporter: Amitkumar Ghatwal
>Priority: Minor
>  Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: ppc64le_unaligned_memory_access.patch
>
>
> Hi All,
> Thanks [~mshuler] for helping in installing cassandra using arch independent 
> installers  for debian + rpm packages from here : 
> http://cassandra.apache.org/download/
> For my architecture - " ppc64le" , the installation process from debian + rpm 
> wasn't straightforward. And needed below configuration level changes.
> For Ubuntu- Cassandra 3.10 release - below changes were needed
> 1) echo "deb [arch=amd64] http://www.apache.org/dist/cassandra/debian 310x 
> main" | sudo tee -a /etc/apt/sources.list.d/cassandra.sources.list 
> 2) sed -i -e s/Xss256/Xss512/g /etc/cassandra/jvm.options
> 3) Removing jna-4.0.0.jar and replacing it with latest jna-4.4.0.jar in 
> (/usr/share/cassandra/lib)- Downloaded from here . 
> 4) Restart cassandra service
> For RHEL - Cassandra 3.0.13 release - below changes were needed
> 1) sed -i -e s/Xss256/Xss512/g /etc/cassandra/default.conf/cassandra-env.sh
> 3) Removing jna-4.0.0.jar and replacing it with latest jna-4.4.0.jar in 
> (/usr/share/cassandra/lib)- Downloaded from here . 
> 4) Restart cassandra service
> Could you please help in introducing above changes so that cassandra can be 
> installed from the debian + rpm pcakages and will indeed become architecture 
> independent.
> Regards,
> Amit



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9

2017-06-21 Thread Romain Hardouin (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057223#comment-16057223
 ] 

Romain Hardouin commented on CASSANDRA-13625:
-

Hi, I don't understand why do you want to remove this setting, it's still used 
in trunk:

{code}
$ grep -IRn getMaxValueSize
test/unit/org/apache/cassandra/db/compaction/BlacklistingCompactionsTest.java:86:
maxValueSize = DatabaseDescriptor.getMaxValueSize();
test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java:84:
maxValueSize = DatabaseDescriptor.getMaxValueSize();
test/unit/org/apache/cassandra/io/sstable/SSTableCorruptionDetectionTest.java:91:
maxValueSize = DatabaseDescriptor.getMaxValueSize();
src/java/org/apache/cassandra/db/ClusteringPrefix.java:377: 
   : (isEmpty(header, offset) ? ByteBufferUtil.EMPTY_BYTE_BUFFER : 
types.get(offset).readValue(in, DatabaseDescriptor.getMaxValueSize()));
src/java/org/apache/cassandra/db/ClusteringPrefix.java:531: 
 : (Serializer.isEmpty(nextHeader, i) ? ByteBufferUtil.EMPTY_BYTE_BUFFER : 
serializationHeader.clusteringTypes().get(i).readValue(in, 
DatabaseDescriptor.getMaxValueSize()));
src/java/org/apache/cassandra/db/rows/Cell.java:246:value = 
header.getType(column).readValue(in, DatabaseDescriptor.getMaxValueSize());
src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java:1056:  
  DecoratedKey key = 
metadata.partitioner.decorateKey(metadata.partitionKeyType.readValue(in, 
DatabaseDescriptor.getMaxValueSize()));
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:1054:public 
static int getMaxValueSize()
{code}

{{getMaxValueSize()}} occurrences: 
https://github.com/apache/cassandra/search?q=getMaxValueSize

> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Joaquin Casares
>  Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does 
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix 
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r 
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-12561) LCS compaction going into infinite loop due to non-existent sstables

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer reassigned CASSANDRA-12561:
--

Assignee: Benjamin Lerer  (was: Alex Petrov)

> LCS compaction going into infinite loop due to non-existent sstables
> 
>
> Key: CASSANDRA-12561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12561
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Nimi Wariboko Jr.
>Assignee: Benjamin Lerer
>  Labels: lcs
>
> I believe this is related/similar to CASSANDRA-11373, but I'm running 3.5 and 
> I still have this issue.
> AFAICT, this happens when getCompactionCandidates in LeveledManifest.java 
> returns a candidate that does not exist on disk. 
> Eventually, all the compaction threads back up, garbage collections start 
> taking an upwards of 20 seconds and messages start being dropped.
> To get around this, I patched my instance with the following code in 
> LeveledManifest.java
> {code:java}
> Set removeCandidates = new HashSet<>();
> for (SSTableReader sstable : candidates)
> {
> if (!(new java.io.File(sstable.getFilename())).exists()) {
> removeCandidates.add(sstable);
> logger.warn("Not compating candidate {} because it does 
> not exist ({}).", sstable.getFilename(), sstable.openReason);
> }
> }
> candidates.removeAll(removeCandidates);
> if (candidates.size() < 2)
> return Collections.emptyList();
> else
> return candidates;
> {code}
> This just removes any candidate that doesn't exist on disk - however I'm not 
> sure what the side effects of this are.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13087) Not enough bytes exception during compaction

2017-06-21 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057189#comment-16057189
 ] 

Benjamin Lerer commented on CASSANDRA-13087:


[~fabrice.facorat] do you still have that problem or can it be closed? 

> Not enough bytes exception during compaction
> 
>
> Key: CASSANDRA-13087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13087
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: Ubuntu 14.04.3 LTS, Cassandra 2.1.14
>Reporter: FACORAT
> Attachments: CASSANDRA-13087.patch
>
>
> After a repair we have compaction exceptions on some nodes and its spreading
> {noformat}
> ERROR [CompactionExecutor:14065] 2016-12-30 14:45:07,245 
> CassandraDaemon.java:229 - Exception in thread 
> Thread[CompactionExecutor:14065,1,main]
> java.lang.IllegalArgumentException: Not enough bytes. Offset: 5. Length: 
> 20275. Buffer size: 12594
> at 
> org.apache.cassandra.db.composites.AbstractCType.checkRemaining(AbstractCType.java:378)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCompoundCellNameType.fromByteBuffer(AbstractCompoundCellNameType.java:100)
>  ~[apache-cassandra-2.1.14.ja
> r:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:398)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:382)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.OnDiskAtom$Serializer.deserializeFromSSTable(OnDiskAtom.java:75)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:52) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:46) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.io.sstable.SSTableIdentityIterator.hasNext(SSTableIdentityIterator.java:171)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.MergeIterator$OneToOne.computeNext(MergeIterator.java:202)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.Iterators$7.computeNext(Iterators.java:645) 
> ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
>  ~[guava-16.0.jar:na]
> at 
> com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) 
> ~[guava-16.0.jar:na]
> at 
> org.apache.cassandra.db.ColumnIndex$Builder.buildForCompaction(ColumnIndex.java:166)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.LazilyCompactedRow.write(LazilyCompactedRow.java:121)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:193) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.append(SSTableRewriter.java:127)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:197)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:73)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
>  ~[apache-cassandra-2.1.14.jar:2.1.14]
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:264)
>  ~[apache-cassandra-2.1.14.jar:2
> .1.14]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_60]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_60]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_60]
> at 
>

[jira] [Resolved] (CASSANDRA-11916) Exception In Compaction Executor - java.lang.IllegalArgumentException: null

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer resolved CASSANDRA-11916.

   Resolution: Duplicate
Fix Version/s: (was: 3.0.x)

> Exception In Compaction Executor - java.lang.IllegalArgumentException: null
> ---
>
> Key: CASSANDRA-11916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11916
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Bhuvan Rawal
>Assignee: Benjamin Lerer
>Priority: Critical
>
> We are using Cassandra 3.0.3 with Level ordered compaction strategy with 
> default compression. While doing some load tests, I can observe these 
> messages after near fixed intervals of 15-20 seconds each on just one node 
> amongst 6 node cluster: 
> ERROR [CompactionExecutor:23] 2016-05-29 01:29:42,643 
> CassandraDaemon.java:195 - Exception in thread 
> Thread[CompactionExecutor:23,1,main]
> java.lang.IllegalArgumentException: null
>   at java.nio.Buffer.position(Buffer.java:244) ~[na:1.8.0_45]
>   at 
> org.apache.cassandra.io.compress.LZ4Compressor.uncompress(LZ4Compressor.java:114)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.compress.CompressedRandomAccessReader.reBufferMmap(CompressedRandomAccessReader.java:183)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.util.RandomAccessReader.reBuffer(RandomAccessReader.java:111)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.util.RandomAccessReader.seek(RandomAccessReader.java:302)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.seekToCurrentRangeStart(BigTableScanner.java:181)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.access$200(BigTableScanner.java:51)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner$KeyScanningIterator.computeNext(BigTableScanner.java:280)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner$KeyScanningIterator.computeNext(BigTableScanner.java:260)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.hasNext(BigTableScanner.java:240)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:369)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:189)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:158)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$2.hasNext(UnfilteredPartitionIterators.java:150)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.transform.BasePartitions.hasNext(BasePartitions.java:72)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionIterator.hasNext(CompactionIterator.java:226)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:177)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:78)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:263)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_45]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_45]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_45]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_45]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]



--
This message was sent by

[jira] [Resolved] (CASSANDRA-11200) CompactionExecutor thread error brings down JVM in 3.0.3

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer resolved CASSANDRA-11200.

Resolution: Cannot Reproduce

> CompactionExecutor thread error brings down JVM in 3.0.3
> 
>
> Key: CASSANDRA-11200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11200
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: debian jesse latest release, updated Feb. 20th
>Reporter: Jason Kania
>Assignee: Benjamin Lerer
>Priority: Critical
>
> When launching Cassandra 3.0.3, with java version "1.8.0_74", Cassandra 
> writes the following to the debug file before a segmentation fault occurs 
> bringing down the JVM - the problem is repeatable.
> DEBUG [CompactionExecutor:1] 2016-02-20 18:26:16,892 CompactionTask.java:146 
> - Compacting (56f677c0-d829-11e5-b23a-25dbd4d727f6) 
> [/var/lib/cassandra/data/sensordb/periodicReading/ma-367-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-368-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-371-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-370-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-369-big-Data.db:level=0, ]
> The JVM error that occurs is the following:
> \#
> \# A fatal error has been detected by the Java Runtime Environment:
> \#
> \#  SIGBUS (0x7) at pc=0x7fa8a1052150, pid=12179, tid=140361951868672
> \#
> \# JRE version: Java(TM) SE Runtime Environment (8.0_74-b02) (build 
> 1.8.0_74-b02)
> \# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.74-b02 mixed mode 
> linux-amd64 compressed oops)
> \# Problematic frame:
> \# v  ~StubRoutines::jbyte_disjoint_arraycopy
> \#
> \# Core dump written. Default location: /tmp/core or core.12179
> \#
> \# If you would like to submit a bug report, please visit:
> \#   http://bugreport.java.com/bugreport/crash.jsp
> \#
> ---  T H R E A D  ---
> Current thread (0x7fa89c56ac20):  JavaThread "CompactionExecutor:1" 
> daemon [_thread_in_Java, id=12323, 
> stack(0x7fa89043f000,0x7fa89048)]
> siginfo: si_signo: 7 (SIGBUS), si_code: 2 (BUS_ADRERR), si_addr: 
> 0x7fa838988002
> Even if all of the files associated with "ma-[NNN]*" are removed, the JVM 
> dies with the same error after the next group of "ma-[NNN]*" are eventually 
> written out and compacted.
> Though this may be strictly a JVM problem, I have seen the issue in Oracle 
> JVM 8.0_65 and 8.0_74 and I raise it in case this problem is due to JNI usage 
> of an external compression library or some direct memory usage.
> I have a core dump if that is helpful to anyone.
> Bug CASSANDRA-11201 may also be related although when the exception 
> referenced in the bug occurs, the JVM remains alive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-11200) CompactionExecutor thread error brings down JVM in 3.0.3

2017-06-21 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057184#comment-16057184
 ] 

Benjamin Lerer commented on CASSANDRA-11200:


After futher investigation, it seems that my previous theory is probably wrong
It seems that CASSANDRA-11201 and CASSANDRA-11916 are similar issues on 3.0.3. 
That would tend to indicate a problem introduced in this release.

As:
# A {{SIGBUS}}  Linux signal can be trigger when a mapped file has been 
truncated and the code read past it's current end.
# The {{IllegalArgumentException}} was triggered because the LZ4 library code 
has been able to read more bytes than what the {{MappedByteBuffer}} seems to 
contains.

I believe that we effectively had a problem in 3.0.3 where a race condition was 
modifying the file being read by the compaction.

According to the user feedbacks on CASSANDRA-11201 and CASSANDRA-11916 this 
problem seems to have been fixed in some of the following releases. The problem 
was officially gone in {{3.0.7}}.

I could not find out which ticket did fix the problem but I think it is safe to 
close this ticket as {{CANNOT REPRODUCE}}.
If anybody hit that problem again, he/she should feel free to reopen this 
ticket.


> CompactionExecutor thread error brings down JVM in 3.0.3
> 
>
> Key: CASSANDRA-11200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11200
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: debian jesse latest release, updated Feb. 20th
>Reporter: Jason Kania
>Assignee: Benjamin Lerer
>Priority: Critical
>
> When launching Cassandra 3.0.3, with java version "1.8.0_74", Cassandra 
> writes the following to the debug file before a segmentation fault occurs 
> bringing down the JVM - the problem is repeatable.
> DEBUG [CompactionExecutor:1] 2016-02-20 18:26:16,892 CompactionTask.java:146 
> - Compacting (56f677c0-d829-11e5-b23a-25dbd4d727f6) 
> [/var/lib/cassandra/data/sensordb/periodicReading/ma-367-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-368-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-371-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-370-big-Data.db:level=0, 
> /var/lib/cassandra/data/sensordb/periodicReading/ma-369-big-Data.db:level=0, ]
> The JVM error that occurs is the following:
> \#
> \# A fatal error has been detected by the Java Runtime Environment:
> \#
> \#  SIGBUS (0x7) at pc=0x7fa8a1052150, pid=12179, tid=140361951868672
> \#
> \# JRE version: Java(TM) SE Runtime Environment (8.0_74-b02) (build 
> 1.8.0_74-b02)
> \# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.74-b02 mixed mode 
> linux-amd64 compressed oops)
> \# Problematic frame:
> \# v  ~StubRoutines::jbyte_disjoint_arraycopy
> \#
> \# Core dump written. Default location: /tmp/core or core.12179
> \#
> \# If you would like to submit a bug report, please visit:
> \#   http://bugreport.java.com/bugreport/crash.jsp
> \#
> ---  T H R E A D  ---
> Current thread (0x7fa89c56ac20):  JavaThread "CompactionExecutor:1" 
> daemon [_thread_in_Java, id=12323, 
> stack(0x7fa89043f000,0x7fa89048)]
> siginfo: si_signo: 7 (SIGBUS), si_code: 2 (BUS_ADRERR), si_addr: 
> 0x7fa838988002
> Even if all of the files associated with "ma-[NNN]*" are removed, the JVM 
> dies with the same error after the next group of "ma-[NNN]*" are eventually 
> written out and compacted.
> Though this may be strictly a JVM problem, I have seen the issue in Oracle 
> JVM 8.0_65 and 8.0_74 and I raise it in case this problem is due to JNI usage 
> of an external compression library or some direct memory usage.
> I have a core dump if that is helpful to anyone.
> Bug CASSANDRA-11201 may also be related although when the exception 
> referenced in the bug occurs, the JVM remains alive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13215) Cassandra nodes startup time 20x more after upgarding to 3.x

2017-06-21 Thread Marcus Eriksson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057183#comment-16057183
 ] 

Marcus Eriksson commented on CASSANDRA-13215:
-

[~kvaster] let me know if you want me to pick this up

> Cassandra nodes startup time 20x more after upgarding to 3.x
> 
>
> Key: CASSANDRA-13215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13215
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
> Environment: Cluster setup: two datacenters (dc-main, dc-backup).
> dc-main - 9 servers, no vnodes
> dc-backup - 6 servers, vnodes
>Reporter: Viktor Kuzmin
> Attachments: simple-cache.patch
>
>
> CompactionStrategyManage.getCompactionStrategyIndex is called on each sstable 
> at startup. And this function calls StorageService.getDiskBoundaries. And 
> getDiskBoundaries calls AbstractReplicationStrategy.getAddressRanges.
> It appears that last function can be really slow. In our environment we have 
> 1545 tokens and with NetworkTopologyStrategy it can make 1545*1545 
> computations in worst case (maybe I'm wrong, but it really takes lot's of 
> cpu).
> Also this function can affect runtime later, cause it is called not only 
> during startup.
> I've tried to implement simple cache for getDiskBoundaries results and now 
> startup time is about one minute instead of 25m, but I'm not sure if it's a 
> good solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Reopened] (CASSANDRA-11916) Exception In Compaction Executor - java.lang.IllegalArgumentException: null

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer reopened CASSANDRA-11916:


> Exception In Compaction Executor - java.lang.IllegalArgumentException: null
> ---
>
> Key: CASSANDRA-11916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11916
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Bhuvan Rawal
>Assignee: Benjamin Lerer
>Priority: Critical
> Fix For: 3.0.x
>
>
> We are using Cassandra 3.0.3 with Level ordered compaction strategy with 
> default compression. While doing some load tests, I can observe these 
> messages after near fixed intervals of 15-20 seconds each on just one node 
> amongst 6 node cluster: 
> ERROR [CompactionExecutor:23] 2016-05-29 01:29:42,643 
> CassandraDaemon.java:195 - Exception in thread 
> Thread[CompactionExecutor:23,1,main]
> java.lang.IllegalArgumentException: null
>   at java.nio.Buffer.position(Buffer.java:244) ~[na:1.8.0_45]
>   at 
> org.apache.cassandra.io.compress.LZ4Compressor.uncompress(LZ4Compressor.java:114)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.compress.CompressedRandomAccessReader.reBufferMmap(CompressedRandomAccessReader.java:183)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.util.RandomAccessReader.reBuffer(RandomAccessReader.java:111)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.util.RandomAccessReader.seek(RandomAccessReader.java:302)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.seekToCurrentRangeStart(BigTableScanner.java:181)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.access$200(BigTableScanner.java:51)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner$KeyScanningIterator.computeNext(BigTableScanner.java:280)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner$KeyScanningIterator.computeNext(BigTableScanner.java:260)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.hasNext(BigTableScanner.java:240)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:369)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:189)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:158)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$2.hasNext(UnfilteredPartitionIterators.java:150)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.transform.BasePartitions.hasNext(BasePartitions.java:72)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionIterator.hasNext(CompactionIterator.java:226)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:177)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:78)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:263)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_45]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_45]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_45]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_45]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (CASSANDRA-13068) Fully expired sstable not dropped when running out of disk space

2017-06-21 Thread Marcus Eriksson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057182#comment-16057182
 ] 

Marcus Eriksson edited comment on CASSANDRA-13068 at 6/21/17 8:38 AM:
--

I just realised that this breaks the public API on {{CompactionTask}} (someone 
might have overridden the {{checkAvailableDiskSpace()}} or 
{{reduceScopeForLimitedSpace()}}, this patch would break that for them

Committed to trunk (4.0) only, thanks!


was (Author: krummas):
I just realised that this breaks the public API on {{CompactionTask}} (someone 
might have overridden the {{checkAvailableDiskSpace()}} or 
{{reduceScopeForLimitedSpace()}, this patch would break that for them

Committed to trunk (4.0) only, thanks!

> Fully expired sstable not dropped when running out of disk space
> 
>
> Key: CASSANDRA-13068
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13068
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Marcus Eriksson
>Assignee: Lerh Chuan Low
>  Labels: lhf
> Fix For: 4.0
>
>
> If a fully expired sstable is larger than the remaining disk space we won't 
> run the compaction that can drop the sstable (ie, in our disk space check 
> should not include the fully expired sstables)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Resolved] (CASSANDRA-11201) Compaction memory fault in 3.0.3

2017-06-21 Thread Benjamin Lerer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer resolved CASSANDRA-11201.

Resolution: Duplicate

> Compaction memory fault in 3.0.3
> 
>
> Key: CASSANDRA-11201
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11201
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
> Environment: debian jesse latest release, updated Feb. 20th
>Reporter: Jason Kania
>Assignee: Benjamin Lerer
>
> I have been encountering the following errors periodically on the system:
> ERROR [CompactionExecutor:6] 2016-02-20 16:54:09,069 CassandraDaemon.java:195 
> - Exception in thread Thread[CompactionExecutor:6,1,main]
> java.lang.InternalError: a fault occurred in a recent unsafe memory access 
> operation in compiled Java code
> at 
> org.apache.cassandra.utils.ByteBufferUtil.readShortLength(ByteBufferUtil.java:366)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.ByteBufferUtil.readWithShortLength(ByteBufferUtil.java:376)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.seekToCurrentRangeStart(BigTableScanner.java:175)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.access$200(BigTableScanner.java:51)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner$KeyScanningIterator.computeNext(BigTableScanner.java:280)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner$KeyScanningIterator.computeNext(BigTableScanner.java:260)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableScanner.hasNext(BigTableScanner.java:240)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:369)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:189)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:158)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$2.hasNext(UnfilteredPartitionIterators.java:150)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.transform.BasePartitions.hasNext(BasePartitions.java:72)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.compaction.CompactionIterator.hasNext(CompactionIterator.java:226)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:177)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:78)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:263)
>  ~[apache-cassandra-3.0.3.jar:3.0.3]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_65]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_65]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_65]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_65]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_65]
> This problem persisted after several reboots and even when most other 
> applications on the system were terminated to provide more memory 
> availability.
> The problem also occurs when running 'nodetool compact'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13068) Fully expired sstable not dropped when running out of disk space

2017-06-21 Thread Marcus Eriksson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-13068:

   Resolution: Fixed
Fix Version/s: (was: 3.11.x)
   (was: 4.x)
   (was: 3.0.x)
   4.0
   Status: Resolved  (was: Patch Available)

I just realised that this breaks the public API on {{CompactionTask}} (someone 
might have overridden the {{checkAvailableDiskSpace()}} or 
{{reduceScopeForLimitedSpace()}, this patch would break that for them

Committed to trunk (4.0) only, thanks!

> Fully expired sstable not dropped when running out of disk space
> 
>
> Key: CASSANDRA-13068
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13068
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Marcus Eriksson
>Assignee: Lerh Chuan Low
>  Labels: lhf
> Fix For: 4.0
>
>
> If a fully expired sstable is larger than the remaining disk space we won't 
> run the compaction that can drop the sstable (ie, in our disk space check 
> should not include the fully expired sstables)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

cassandra git commit: Improve calculation of available disk space for compaction

2017-06-21 Thread marcuse 
Repository: cassandra
Updated Branches:
  refs/heads/trunk f21202e83 -> 67247394d


Improve calculation of available disk space for compaction

Patch by Krishna Dattu Koneru and Lerh Chuan Low; reviewed by marcuse for 
CASSANDRA-13068


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/67247394
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/67247394
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/67247394

Branch: refs/heads/trunk
Commit: 67247394d846cf3463d5441b836a47611ec28656
Parents: f21202e
Author: Krishna Koneru 
Authored: Thu Jun 8 10:04:17 2017 +1000
Committer: Marcus Eriksson 
Committed: Wed Jun 21 10:34:16 2017 +0200

--
 CHANGES.txt |   1 +
 .../cassandra/db/compaction/CompactionTask.java | 117 ++
 .../db/compaction/CompactionsBytemanTest.java   | 122 +++
 3 files changed, 188 insertions(+), 52 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/67247394/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 0968de9..cc1bdb2 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0
+ * Improve calculation of available disk space for compaction (CASSANDRA-13068)
  * Change the accessibility of RowCacheSerializer for third party row cache 
plugins (CASSANDRA-13579)
  * Allow sub-range repairs for a preview of repaired data (CASSANDRA-13570)
  * NPE in IR cleanup when columnfamily has no sstables (CASSANDRA-13585)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/67247394/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java 
b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 789de1e..3d3cd3d 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@ -86,7 +86,7 @@ public class CompactionTask extends AbstractCompactionTask
 return transaction.originals().size();
 }
 
-public boolean reduceScopeForLimitedSpace(long expectedSize)
+public boolean reduceScopeForLimitedSpace(Set 
nonExpiredSSTables, long expectedSize)
 {
 if (partialCompactionsAcceptable() && transaction.originals().size() > 
1)
 {
@@ -97,7 +97,7 @@ public class CompactionTask extends AbstractCompactionTask
 
 // Note that we have removed files that are still marked as 
compacting.
 // This suboptimal but ok since the caller will unmark all the 
sstables at the end.
-SSTableReader removedSSTable = 
cfs.getMaxSizeFile(transaction.originals());
+SSTableReader removedSSTable = 
cfs.getMaxSizeFile(nonExpiredSSTables);
 transaction.cancel(removedSSTable);
 return true;
 }
@@ -125,44 +125,46 @@ public class CompactionTask extends AbstractCompactionTask
 if (DatabaseDescriptor.isSnapshotBeforeCompaction())
 cfs.snapshotWithoutFlush(System.currentTimeMillis() + "-compact-" 
+ cfs.name);
 
-// note that we need to do a rough estimate early if we can fit the 
compaction on disk - this is pessimistic, but
-// since we might remove sstables from the compaction in 
checkAvailableDiskSpace it needs to be done here
+try (CompactionController controller = 
getCompactionController(transaction.originals()))
+{
 
-checkAvailableDiskSpace();
+final Set fullyExpiredSSTables = 
controller.getFullyExpiredSSTables();
 
-// sanity check: all sstables must belong to the same cfs
-assert !Iterables.any(transaction.originals(), new 
Predicate()
-{
-@Override
-public boolean apply(SSTableReader sstable)
+// select SSTables to compact based on available disk space.
+
buildCompactionCandidatesForAvailableDiskSpace(fullyExpiredSSTables);
+
+// sanity check: all sstables must belong to the same cfs
+assert !Iterables.any(transaction.originals(), new 
Predicate()
 {
-return !sstable.descriptor.cfname.equals(cfs.name);
-}
-});
+@Override
+public boolean apply(SSTableReader sstable)
+{
+return !sstable.descriptor.cfname.equals(cfs.name);
+}
+});
 
-UUID taskId = transaction.opId();
+UUID taskId = transaction.opId();
 
-// new sstables from flush can be added during a compaction, but only 
the

[jira] [Comment Edited] (CASSANDRA-13547) Filtered materialized views missing data

2017-06-21 Thread Krishna Dattu Koneru (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040527#comment-16040527
 ] 

Krishna Dattu Koneru edited comment on CASSANDRA-13547 at 6/21/17 6:22 AM:
---


{code}
cqlsh> UPDATE test.table1 SET enabled = TRUE WHERE id = 1 AND name = 'One';

cqlsh> SELECT * FROM test.table1;

 id | name | enabled | foo
+--+-+-
  1 |  One |True | Bar

(1 rows)
{code}
{code:title=Problem 1 - Missing Updates|borderStyle=solid}

cqlsh> SELECT * FROM test.table1_mv1;

 name | id | foo
--++-

(0 rows)
{code}

Logic in ViewUpdateGenerator.java does not update the view row if updated 
column is not denormalized in the view.
in the above case,{{enabled}} is not denormalized and so update has not 
propagated to the view.View metadata only has pk columns + columns in select 
statement of create view.
Now that filtering on non-pk columns is supported , we have to make sure that 
all non-primary key columns that have filters are denormalized.
(delete does not do this check because it does not have to. This is the reason 
row delete worked when {{enabled}} is set to false.)

{code:title=Problem 2 - incorrect non-pk tombstones|borderStyle=solid}
cqlsh> SELECT * FROM test.table1_mv2;

 name | id | enabled | foo
--++-+--
  One |  1 |True | null

(1 rows)
{code}

This happens because of the way liveliness/deletion info  is computed in the 
view. 
{{computeTimestampForEntryDeletion())}} method takes the biggest timestamp of 
all the columns (including non-pk) in the row and uses it in Deletion info when 
deleting.

But,when inserting/updating, {{computeLivenessInfoForEntry()}} uses the biggest 
timestamp of the primary keys for liveliness info.
This causes non-pk columns to be treated as deleted because view tombstones 
have higher timestamp than live cell from base row.


I have uploaded a [patch for 3.11 | 
https://github.com/apache/cassandra/compare/cassandra-3.11...krishna-koneru:cassandra-3.11-13547]branch
 which fixes above two issues.

I will make patches for other branches if this patch looks okay.
Comments appreciated !


was (Author: krishna.koneru):
I have uploaded a patch (with unittest) for problem 1 in above comment @ 
https://github.com/apache/cassandra/compare/cassandra-3.11...krishna-koneru:cassandra-3.11-13547

below problem addressed by this patch  (from the description)
{code}
cqlsh> UPDATE test.table1 SET enabled = TRUE WHERE id = 1 AND name = 'One';
cqlsh> SELECT * FROM test.table1;

 id | name | enabled | foo
+--+-+-
  1 |  One |True | Bar

(1 rows)
cqlsh> SELECT * FROM test.table1_mv1;

 name | id | foo
--++-
{code}

This happens because view metadata does not have column "enabled" .
The decision "should this base table update, update view as well?" is made by 
looking at view metadata (among other things).
Due to this, some updates to base table do not result in updates to MV even if 
update qualifies .

This patch disallows usage of any non PK columns in WHERE clause if they are 
not in SELECT list.

Comments are appreciated !


> Filtered materialized views missing data
> 
>
> Key: CASSANDRA-13547
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13547
> Project: Cassandra
>  Issue Type: Bug
>  Components: Materialized Views
> Environment: Official Cassandra 3.10 Docker image (ID 154b919bf8ce).
>Reporter: Craig Nicholson
>Assignee: Krishna Dattu Koneru
>Priority: Blocker
>  Labels: materializedviews
> Fix For: 3.11.x
>
>
> When creating a materialized view against a base table the materialized view 
> does not always reflect the correct data.
> Using the following test schema:
> {code:title=Schema|language=sql}
> DROP KEYSPACE IF EXISTS test;
> CREATE KEYSPACE test
>   WITH REPLICATION = { 
>'class' : 'SimpleStrategy', 
>'replication_factor' : 1 
>   };
> CREATE TABLE test.table1 (
> id int,
> name text,
> enabled boolean,
> foo text,
> PRIMARY KEY (id, name));
> CREATE MATERIALIZED VIEW test.table1_mv1 AS SELECT id, name, foo
> FROM test.table1
> WHERE id IS NOT NULL 
> AND name IS NOT NULL 
> AND enabled = TRUE
> PRIMARY KEY ((name), id);
> CREATE MATERIALIZED VIEW test.table1_mv2 AS SELECT id, name, foo, enabled
> FROM test.table1
> WHERE id IS NOT NULL 
> AND name IS NOT NULL 
> AND enabled = TRUE
> PRIMARY KEY ((name), id);
> {code}
> When I insert a row into the base table the materialized views are updated 
> appropriately. (+)
>

  1   2   >