[jira] [Assigned] (CASSANDRA-14834) Avoid keeping StreamingTombstoneHistogramBuilder.Spool in memory during the whole compaction
[
https://issues.apache.org/jira/browse/CASSANDRA-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson reassigned CASSANDRA-14834:
---
Assignee: (was: Marcus Eriksson)
> Avoid keeping StreamingTombstoneHistogramBuilder.Spool in memory during the
> whole compaction
>
>
> Key: CASSANDRA-14834
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14834
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Marcus Eriksson
>Priority: Low
> Fix For: 4.0, 4.0-beta
>
>
> Since CASSANDRA-13444 {{StreamingTombstoneHistogramBuilder.Spool}} is
> allocated to keep around an array with 131072 * 2 * 2 integers *per written
> sstable* during the whole compaction. With LCS at times creating 1000s of
> sstables during a compaction it kills the node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13325) Bring back the accepted encryption protocols list as configurable option
[
https://issues.apache.org/jira/browse/CASSANDRA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-13325:
--
Fix Version/s: (was: 4.0-beta)
4.0-beta4
Source Control Link:
https://github.com/apache/cassandra/commit/919a8964a83511d96766c3e53ba603e77bca626c
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Bring back the accepted encryption protocols list as configurable option
>
>
> Key: CASSANDRA-13325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13325
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Nachiket Patil
>Assignee: Jon Meredith
>Priority: Low
> Fix For: 4.0-beta4
>
> Attachments: trunk.diff
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With CASSANDRA-10508, the hard coded list of accepted encryption protocols
> was eliminated. For some use cases, it is necessary to restrict the
> encryption protocols used for communication between client and server.
> Default JVM way of negotiations allows the best encryption protocol that
> client can use.
> e.g. I have set Cassandra to use encryption. Ideally client and server
> negotiate to use best protocol (TLSv1.2). But a malicious client might force
> TLSv1.0 which is susceptible to POODLE attacks.
> At the moment only way to restrict the encryption protocol is using the
> {{jdk.tls.client.protocols}} systems property. If I dont have enough access
> to modify this property, I dont have any way of restricting the encryption
> protocols.
> I am proposing bring back the accepted_protocols property but make it
> configurable. If not specified, let the JVM take care of the TLS negotiations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Bring back the accepted encryption protocols list as configurable option
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 919a896 Bring back the accepted encryption protocols list as
configurable option
919a896 is described below
commit 919a8964a83511d96766c3e53ba603e77bca626c
Author: Jon Meredith
AuthorDate: Wed Dec 2 15:33:36 2020 -0800
Bring back the accepted encryption protocols list as configurable option
patch by Jon Meredith; reviewed by Berenguer Blasi, David Capwell, Dinesh
Joshi for CASSANDRA-13325
---
CHANGES.txt| 1 +
.../cassandra/config/DatabaseDescriptor.java | 10 +-
.../apache/cassandra/config/EncryptionOptions.java | 176
.../apache/cassandra/db/virtual/SettingsTable.java | 5 +-
.../org/apache/cassandra/security/SSLFactory.java | 181 -
.../org/apache/cassandra/tools/BulkLoader.java | 2 +-
.../test/AbstractEncryptionOptionsImpl.java| 75 -
.../test/InternodeEncryptionOptionsTest.java | 86 ++
.../test/NativeTransportEncryptionOptionsTest.java | 93 ++-
.../cassandra/config/EncryptionOptionsTest.java| 12 +-
.../cassandra/db/virtual/SettingsTableTest.java| 17 +-
.../apache/cassandra/security/SSLFactoryTest.java | 21 +--
.../cassandra/stress/util/JavaDriverClient.java| 2 +-
13 files changed, 557 insertions(+), 124 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index b539e2b..172ebcc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -16,6 +16,7 @@
* TLS connections to the storage port on a node without server encryption
configured causes java.io.IOException accessing missing keystore
(CASSANDRA-16144)
* Internode messaging catches OOMs and does not rethrow (CASSANDRA-15214)
* When a table attempts to clean up metrics, it was cleaning up all global
table metrics (CASSANDRA-16095)
+ * Bring back the accepted encryption protocols list as configurable option
(CASSANDRA-13325)
Merged from 3.11:
* SASI's `max_compaction_flush_memory_in_mb` settings over 100GB revert to
default of 1GB (CASSANDRA-16071)
Merged from 3.0:
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index 9f659fd..daac364 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -360,7 +360,7 @@ public class DatabaseDescriptor
applyEncryptionContext();
-applySslContextHotReload();
+applySslContext();
}
private static void applySimpleConfig()
@@ -988,15 +988,17 @@ public class DatabaseDescriptor
encryptionContext = new
EncryptionContext(conf.transparent_data_encryption_options);
}
-public static void applySslContextHotReload()
+public static void applySslContext()
{
try
{
+SSLFactory.validateSslContext("Internode messaging",
conf.server_encryption_options, true, true);
+SSLFactory.validateSslContext("Native transport",
conf.client_encryption_options,
conf.client_encryption_options.require_client_auth, true);
SSLFactory.initHotReloading(conf.server_encryption_options,
conf.client_encryption_options, false);
}
-catch(IOException e)
+catch (IOException e)
{
-throw new ConfigurationException("Failed to initialize SSL hot
reloading", e);
+throw new ConfigurationException("Failed to initialize SSL", e);
}
}
diff --git a/src/java/org/apache/cassandra/config/EncryptionOptions.java
b/src/java/org/apache/cassandra/config/EncryptionOptions.java
index 26bf458..fad6190 100644
--- a/src/java/org/apache/cassandra/config/EncryptionOptions.java
+++ b/src/java/org/apache/cassandra/config/EncryptionOptions.java
@@ -21,6 +21,7 @@ import java.io.File;
import java.util.List;
import java.util.Objects;
+import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
import org.slf4j.Logger;
@@ -55,7 +56,8 @@ public class EncryptionOptions
public final String truststore;
public final String truststore_password;
public final List cipher_suites;
-public final String protocol;
+protected String protocol;
+protected List accepted_protocols;
public final String algorithm;
public final String store_type;
public final boolean require_client_auth;
@@ -79,8 +81,9 @@ public class EncryptionOptions
keystore_password = "cassandra";
truststore = "conf/.truststore";
truststore_password = "cassandra";
-cipher_suites = ImmutableList.of();
-protocol = "TLS";
+cipher_suites = null;
+protocol = null;
+accepted_protocols
[jira] [Commented] (CASSANDRA-13325) Bring back the accepted encryption protocols list as configurable option
[
https://issues.apache.org/jira/browse/CASSANDRA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242813#comment-17242813
]
David Capwell commented on CASSANDRA-13325:
---
Starting commit
CI Results (pending):
||Branch||Source||Circle CI||Jenkins||
|trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-13325-trunk-4DE5A387-1A32-4B6E-A4D0-5A7CAA3F3339]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-13325-trunk-4DE5A387-1A32-4B6E-A4D0-5A7CAA3F3339]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/242/]|
> Bring back the accepted encryption protocols list as configurable option
>
>
> Key: CASSANDRA-13325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13325
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Nachiket Patil
>Assignee: Jon Meredith
>Priority: Low
> Fix For: 4.0-beta
>
> Attachments: trunk.diff
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With CASSANDRA-10508, the hard coded list of accepted encryption protocols
> was eliminated. For some use cases, it is necessary to restrict the
> encryption protocols used for communication between client and server.
> Default JVM way of negotiations allows the best encryption protocol that
> client can use.
> e.g. I have set Cassandra to use encryption. Ideally client and server
> negotiate to use best protocol (TLSv1.2). But a malicious client might force
> TLSv1.0 which is susceptible to POODLE attacks.
> At the moment only way to restrict the encryption protocol is using the
> {{jdk.tls.client.protocols}} systems property. If I dont have enough access
> to modify this property, I dont have any way of restricting the encryption
> protocols.
> I am proposing bring back the accepted_protocols property but make it
> configurable. If not specified, let the JVM take care of the TLS negotiations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13325) Bring back the accepted encryption protocols list as configurable option
[
https://issues.apache.org/jira/browse/CASSANDRA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-13325:
--
Status: Ready to Commit (was: Review In Progress)
+1
> Bring back the accepted encryption protocols list as configurable option
>
>
> Key: CASSANDRA-13325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13325
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Nachiket Patil
>Assignee: Jon Meredith
>Priority: Low
> Fix For: 4.0-beta
>
> Attachments: trunk.diff
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With CASSANDRA-10508, the hard coded list of accepted encryption protocols
> was eliminated. For some use cases, it is necessary to restrict the
> encryption protocols used for communication between client and server.
> Default JVM way of negotiations allows the best encryption protocol that
> client can use.
> e.g. I have set Cassandra to use encryption. Ideally client and server
> negotiate to use best protocol (TLSv1.2). But a malicious client might force
> TLSv1.0 which is susceptible to POODLE attacks.
> At the moment only way to restrict the encryption protocol is using the
> {{jdk.tls.client.protocols}} systems property. If I dont have enough access
> to modify this property, I dont have any way of restricting the encryption
> protocols.
> I am proposing bring back the accepted_protocols property but make it
> configurable. If not specified, let the JVM take care of the TLS negotiations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13325) Bring back the accepted encryption protocols list as configurable option
[
https://issues.apache.org/jira/browse/CASSANDRA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-13325:
--
Status: Review In Progress (was: Patch Available)
> Bring back the accepted encryption protocols list as configurable option
>
>
> Key: CASSANDRA-13325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13325
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Nachiket Patil
>Assignee: Jon Meredith
>Priority: Low
> Fix For: 4.0-beta
>
> Attachments: trunk.diff
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With CASSANDRA-10508, the hard coded list of accepted encryption protocols
> was eliminated. For some use cases, it is necessary to restrict the
> encryption protocols used for communication between client and server.
> Default JVM way of negotiations allows the best encryption protocol that
> client can use.
> e.g. I have set Cassandra to use encryption. Ideally client and server
> negotiate to use best protocol (TLSv1.2). But a malicious client might force
> TLSv1.0 which is susceptible to POODLE attacks.
> At the moment only way to restrict the encryption protocol is using the
> {{jdk.tls.client.protocols}} systems property. If I dont have enough access
> to modify this property, I dont have any way of restricting the encryption
> protocols.
> I am proposing bring back the accepted_protocols property but make it
> configurable. If not specified, let the JVM take care of the TLS negotiations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13325) Bring back the accepted encryption protocols list as configurable option
[
https://issues.apache.org/jira/browse/CASSANDRA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-13325:
--
Reviewers: Berenguer Blasi, David Capwell, Dinesh Joshi (was: Berenguer
Blasi)
> Bring back the accepted encryption protocols list as configurable option
>
>
> Key: CASSANDRA-13325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13325
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Nachiket Patil
>Assignee: Jon Meredith
>Priority: Low
> Fix For: 4.0-beta
>
> Attachments: trunk.diff
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With CASSANDRA-10508, the hard coded list of accepted encryption protocols
> was eliminated. For some use cases, it is necessary to restrict the
> encryption protocols used for communication between client and server.
> Default JVM way of negotiations allows the best encryption protocol that
> client can use.
> e.g. I have set Cassandra to use encryption. Ideally client and server
> negotiate to use best protocol (TLSv1.2). But a malicious client might force
> TLSv1.0 which is susceptible to POODLE attacks.
> At the moment only way to restrict the encryption protocol is using the
> {{jdk.tls.client.protocols}} systems property. If I dont have enough access
> to modify this property, I dont have any way of restricting the encryption
> protocols.
> I am proposing bring back the accepted_protocols property but make it
> configurable. If not specified, let the JVM take care of the TLS negotiations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16095) When a table attempts to clean up metrics, it was cleaning up all global table metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-16095:
--
Fix Version/s: (was: 4.0-beta)
4.0-beta4
Source Control Link:
https://github.com/apache/cassandra/commit/c636d623a45daf69bdf4a1f6634524d7a1568b64
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> When a table attempts to clean up metrics, it was cleaning up all global
> table metrics
> --
>
> Key: CASSANDRA-16095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16095
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Altan Özlü
>Assignee: David Capwell
>Priority: Urgent
> Fix For: 4.0-beta4
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> when i use
> {code:java}
> bin/nodetool tablestats {code}
> i get this error
> {code:java}
> error:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> -- StackTrace --
> javax.management.InstanceNotFoundException:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> {code}
> if i restart the node and check it works but if i write something then i get
> the error again
> * Cassandra 4.0-beta1
> * Ubuntu 20
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: When a table attempts to clean up metrics, it was cleaning up all global table metrics
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 876ac8c When a table attempts to clean up metrics, it was cleaning up
all global table metrics
876ac8c is described below
commit 876ac8c6111697c8105899889bf794438110bc74
Author: David Capwell
AuthorDate: Wed Dec 2 13:35:56 2020 -0800
When a table attempts to clean up metrics, it was cleaning up all global
table metrics
patch by David Capwell; reviewed by Jon Meredith, Jordan West, Yifan Cai
for CASSANDRA-16095
---
CHANGES.txt| 1 +
.../config/CassandraRelevantProperties.java| 71 +-
.../org/apache/cassandra/db/ColumnFamilyStore.java | 22 +-
.../org/apache/cassandra/metrics/TableMetrics.java | 78 +++---
.../org/apache/cassandra/utils/MBeanWrapper.java | 95 +++
.../distributed/impl/AbstractCluster.java | 8 +
.../cassandra/distributed/impl/Instance.java | 9 +-
.../distributed/test/metric/TableMetricTest.java | 272 +
8 files changed, 463 insertions(+), 93 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 7458801..b539e2b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -15,6 +15,7 @@
* Throw BufferOverflowException from DataOutputBuffer for better visibility
(CASSANDRA-16214)
* TLS connections to the storage port on a node without server encryption
configured causes java.io.IOException accessing missing keystore
(CASSANDRA-16144)
* Internode messaging catches OOMs and does not rethrow (CASSANDRA-15214)
+ * When a table attempts to clean up metrics, it was cleaning up all global
table metrics (CASSANDRA-16095)
Merged from 3.11:
* SASI's `max_compaction_flush_memory_in_mb` settings over 100GB revert to
default of 1GB (CASSANDRA-16071)
Merged from 3.0:
diff --git
a/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
b/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
index 7402aa1..5d918a8 100644
--- a/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
+++ b/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
@@ -163,7 +163,10 @@ public enum CassandraRelevantProperties
ORG_APACHE_CASSANDRA_DB_VIRTUAL_SYSTEM_PROPERTIES_TABLE_TEST("org.apache.cassandra.db.virtual.SystemPropertiesTableTest"),
/** This property indicates whether disable_mbean_registration is true */
-
IS_DISABLED_MBEAN_REGISTRATION("org.apache.cassandra.disable_mbean_registration");
+
IS_DISABLED_MBEAN_REGISTRATION("org.apache.cassandra.disable_mbean_registration"),
+
+/** what class to use for mbean registeration */
+MBEAN_REGISTRATION_CLASS("org.apache.cassandra.mbean_registration_class");
CassandraRelevantProperties(String key, String defaultVal)
{
@@ -197,6 +200,28 @@ public enum CassandraRelevantProperties
}
/**
+ * Gets the value of a system property as a String.
+ * @return system property String value if it exists, overrideDefaultValue
otherwise.
+ */
+public String getString(String overrideDefaultValue)
+{
+String value = System.getProperty(key);
+if (value == null)
+return overrideDefaultValue;
+
+return STRING_CONVERTER.convert(value);
+}
+
+/**
+ * Sets the value into system properties.
+ * @param value to set
+ */
+public void setString(String value)
+{
+System.setProperty(key, value);
+}
+
+/**
* Gets the value of a system property as a boolean.
* @return system property boolean value if it exists, false otherwise().
*/
@@ -208,6 +233,28 @@ public enum CassandraRelevantProperties
}
/**
+ * Gets the value of a system property as a boolean.
+ * @return system property boolean value if it exists,
overrideDefaultValue otherwise.
+ */
+public boolean getBoolean(boolean overrideDefaultValue)
+{
+String value = System.getProperty(key);
+if (value == null)
+return overrideDefaultValue;
+
+return BOOLEAN_CONVERTER.convert(value);
+}
+
+/**
+ * Sets the value into system properties.
+ * @param value to set
+ */
+public void setBoolean(boolean value)
+{
+System.setProperty(key, Boolean.toString(value));
+}
+
+/**
* Gets the value of a system property as a int.
* @return system property int value if it exists, defaultValue otherwise.
*/
@@ -218,6 +265,28 @@ public enum CassandraRelevantProperties
return INTEGER_CONVERTER.convert(value == null ? defaultVal : value);
}
+/**
+ * Gets the value of a system property as a int.
+ * @return system property int value if it exists, overrideDefaultValue
otherwise.
+ */
+public int getInt(int
[jira] [Comment Edited] (CASSANDRA-16261) Prevent unbounded number of flushing tasks
[
https://issues.apache.org/jira/browse/CASSANDRA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242762#comment-17242762
]
Caleb Rackliffe edited comment on CASSANDRA-16261 at 12/2/20, 11:12 PM:
bq. And, at least since 3.11, we could add a description of the property in the
documentation for cassandra-env.sh, which already contains definitions of other
properties, WDYT?
+100 to this
Further, we should make sure the documentation clearly explains when you would
want/need to raise/lower the value of {{max_pending_flushing_tasks}} in
response to a metric or set of metrics.
was (Author: maedhroz):
bq. And, at least since 3.11, we could add a description of the property in the
documentation for cassandra-env.sh, which already contains definitions of other
properties, WDYT?
+100 to this
> Prevent unbounded number of flushing tasks
> --
>
> Key: CASSANDRA-16261
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16261
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta4
>
>
> The cleaner thread is not prevented from queueing an unbounded number of
> flushing tasks for memtables that are almost empty.
> This patch adds a mechanism to track the number of pending flushing
> tasks in the memtable cleaner. Above the maximum number (2x the flushing
> threads by default), only memtables using at least MCT memory will be
> flushed, where MCT stands for Memory Cleanup Threshold.
> This patch also fixes a possible problem tracking the memory marked as
> "reclaiming" in the memtable allocators and pool. Writes that complete
> only after a memtable has been scheduled for flushing, did not report
> their memory as reclaiming. Normally this should be a small value of no
> consequence, but if the flushing tasks are blocked for a long period,
> and there is a sufficient number of writes, or these writes use
> a sufficiently large quantity of memory, this would cause the memtable
> cleaning algorithm to schedule repeated flushing tasks because the used
> memory is always > reclaiming memory + MCT.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16261) Prevent unbounded number of flushing tasks
[ https://issues.apache.org/jira/browse/CASSANDRA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16261: Description: The cleaner thread is not prevented from queueing an unbounded number of flushing tasks for memtables that are almost empty. This patch adds a mechanism to track the number of pending flushing tasks in the memtable cleaner. Above the maximum number (2x the flushing threads by default), only memtables using at least MCT memory will be flushed, where MCT stands for Memory Cleanup Threshold. This patch also fixes a possible problem tracking the memory marked as "reclaiming" in the memtable allocators and pool. Writes that complete only after a memtable has been scheduled for flushing, did not report their memory as reclaiming. Normally this should be a small value of no consequence, but if the flushing tasks are blocked for a long period, and there is a sufficient number of writes, or these writes use a sufficiently large quantity of memory, this would cause the memtable cleaning algorithm to schedule repeated flushing tasks because the used memory is always > reclaiming memory + MCT. was:The cleaner thread is not prevented from queueing an unbounded number of flushing tasks for memtables that are almost empty. > Prevent unbounded number of flushing tasks > -- > > Key: CASSANDRA-16261 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16261 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta4 > > > The cleaner thread is not prevented from queueing an unbounded number of > flushing tasks for memtables that are almost empty. > This patch adds a mechanism to track the number of pending flushing > tasks in the memtable cleaner. Above the maximum number (2x the flushing > threads by default), only memtables using at least MCT memory will be > flushed, where MCT stands for Memory Cleanup Threshold. > This patch also fixes a possible problem tracking the memory marked as > "reclaiming" in the memtable allocators and pool. Writes that complete > only after a memtable has been scheduled for flushing, did not report > their memory as reclaiming. Normally this should be a small value of no > consequence, but if the flushing tasks are blocked for a long period, > and there is a sufficient number of writes, or these writes use > a sufficiently large quantity of memory, this would cause the memtable > cleaning algorithm to schedule repeated flushing tasks because the used > memory is always > reclaiming memory + MCT. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16261) Prevent unbounded number of flushing tasks
[ https://issues.apache.org/jira/browse/CASSANDRA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242788#comment-17242788 ] Ekaterina Dimitrova commented on CASSANDRA-16261: - Thanks [~maedhroz] Actually I finished today 3.0, 3.11 and 4.0 and after looking at the implementation of CompletableFuture functions, I don't find it worth it too. Also, 2.2 should be out of support the moment 4.0 is out. But I will be happy to review CASSANDRA-16300 to fix the build (not related to this patch but this patch led to that discovery from [~adelapena]) With that said: I think all concerns of [~adelapena] are addressed in the PRs. I didn't squash intentionally so it is clear what is review feedback, etc. Looking forward to your review [~maedhroz]. Thank you! > Prevent unbounded number of flushing tasks > -- > > Key: CASSANDRA-16261 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16261 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta4 > > > The cleaner thread is not prevented from queueing an unbounded number of > flushing tasks for memtables that are almost empty. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16261) Prevent unbounded number of flushing tasks
[ https://issues.apache.org/jira/browse/CASSANDRA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242777#comment-17242777 ] Caleb Rackliffe commented on CASSANDRA-16261: - I started reviewing the 2.2 branch, but if we're going to need 2.2 to be JDK 1.7 compatible, I'd lean toward not fixing it there at all. Neither having a different implementation between 2.2 and 3.0+ nor changing 3.0+ to avoid 1.8 features seems ideal. > Prevent unbounded number of flushing tasks > -- > > Key: CASSANDRA-16261 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16261 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta4 > > > The cleaner thread is not prevented from queueing an unbounded number of > flushing tasks for memtables that are almost empty. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16115) New Cassandra website design, content and layout to work with Antora
[ https://issues.apache.org/jira/browse/CASSANDRA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242769#comment-17242769 ] Melissa Logan commented on CASSANDRA-16115: --- Following up with the latest: the two dev teams have been meeting to explore which direction to go and will be moving forward with Antora for the main site. Front-end dev began week of Nov. 9 and has continued to present; and all sub-page designs will be complete this week. The content is complete with the exception of case studies and resources pages, which will be gathered up until the publish date. We should have an idea of updated go-live date likely next week. > New Cassandra website design, content and layout to work with Antora > > > Key: CASSANDRA-16115 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16115 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Melissa Logan >Assignee: Melissa Logan >Priority: Normal > Fix For: 4.0.x > > Attachments: Screen Shot 2020-09-03 at 09.48.53.png > > > This task is related to CASSANDRA-16066 (Update and rework the > cassandra-website material to work with Antora). The goal is to update the > front-end of the C* website (design, IA and content) to work with Antora to > help modernize the website as discussed on the [mailing > list|https://www.mail-archive.com/dev@cassandra.apache.org/msg15537.html]. > *Design Concepts:* A minimum of two homepage design concepts will be created > and shared for input, which will help standardize a brand palette for C* and > a design language for the site. This may include custom iconography and > graphics. The chosen design language will be used to develop the remaining > templates. > *Template Design*: It's estimated that 7 template designs will be needed > including the creation of several new pages: > * Homepage template > * Toplevel template - e.g. Community. > * General template - Mostly textual with some images, e.g. Intro, Quickstart > * “Library” template - A library of assets (links, downloads, logos etc) > that are sortable by metadata, e.g Resources, or Kafka's Powered By page). > * Blog landing template > * Blog single template > * Docs template > *Website Content:* Along with new design will be a need for new or updated > content to fit the new page layouts. The intention is to use as much as > possible from existing content, and augment with new content where needed. > *Template Development:* This includes the frontend development, such as any > HTML markup to achieve designs. HTML would be crafted so as to preserve any > backend/API calls, such that content is pulled in as designed. The majority > of the frontend work would come in the form of crafting CSS to bring the > designs to life, plus any minor Javascript to add subtle delights to key > pages. > *Style Guide*: Once all is complete, a Style Guide be added to GitHub for > contributors. > The [cassandra-website|https://github.com/apache/cassandra-website] > repository would need to be modified. Specific changes to be determined. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16261) Prevent unbounded number of flushing tasks
[ https://issues.apache.org/jira/browse/CASSANDRA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242762#comment-17242762 ] Caleb Rackliffe commented on CASSANDRA-16261: - bq. And, at least since 3.11, we could add a description of the property in the documentation for cassandra-env.sh, which already contains definitions of other properties, WDYT? +100 to this > Prevent unbounded number of flushing tasks > -- > > Key: CASSANDRA-16261 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16261 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta4 > > > The cleaner thread is not prevented from queueing an unbounded number of > flushing tasks for memtables that are almost empty. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16095) When a table attempts to clean up metrics, it was cleaning up all global table metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242756#comment-17242756
]
David Capwell commented on CASSANDRA-16095:
---
Starting commit
CI Results (pending):
||Branch||Source||Circle CI||Jenkins||
|trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-16095-trunk-9DDF4ED4-D56E-4FB0-AB89-B42A3B1CC1BC]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-16095-trunk-9DDF4ED4-D56E-4FB0-AB89-B42A3B1CC1BC]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/240/]|
> When a table attempts to clean up metrics, it was cleaning up all global
> table metrics
> --
>
> Key: CASSANDRA-16095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16095
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Altan Özlü
>Assignee: David Capwell
>Priority: Urgent
> Fix For: 4.0-beta
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> when i use
> {code:java}
> bin/nodetool tablestats {code}
> i get this error
> {code:java}
> error:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> -- StackTrace --
> javax.management.InstanceNotFoundException:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> {code}
> if i restart the node and check it works but if i write something then i get
> the error again
> * Cassandra 4.0-beta1
> * Ubuntu 20
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16078) Performance regression for queries accessing multiple rows
[
https://issues.apache.org/jira/browse/CASSANDRA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242752#comment-17242752
]
David Capwell commented on CASSANDRA-16078:
---
used tlp-stress but can't share the test code, though can explain it enough to
reproduce.
// create
{code}
CREATE TABLE IF NOT EXISTS clusteringslicing (
key text,
column1 bigint,
value blob,
PRIMARY KEY(key, column1)
) WITH CLUSTERING ORDER BY (column1 DESC)
{code}
// select
{code}
SELECT key, column1
FROM clusteringslicing
WHERE key = ?
AND column1 >= ?
AND column1 <= ?
LIMIT ?
{code}
// test configs
{code}
limit == 100
max_blob_length=102400
rows_per_partition=1000
use_range_tombstones=false
LeveledCompactionStrategy
num_partitions=1000
duration="60m"
delete_rate=0.11
read_rate=0.11
{code}
when selecting the clustering key bounds, the test uses a uniform distribution
between 0 and rows_per_partition
Hope this helps!
Its been a while since I ran the test, if desired I can rerun again to see if
anything has changed.
> Performance regression for queries accessing multiple rows
> --
>
> Key: CASSANDRA-16078
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16078
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: image.png
>
>
> This is spin off from CASSANDRA-16036.
> In testing 4.0 relative to 3.0* I found that queries which accessed multiple
> rows to have a noticeable performance decrease; two queries were used in the
> test (more may be impacted, others might not): query partition (table has
> clustering keys) with LIMIT, and query clustering keys using IN clause.
> In the below graphs the green line is 3.0 and the other lines are 4.0 (with
> and without chunk cache)
> Partition with LIMIT
> !https://issues.apache.org/jira/secure/attachment/13009751/clustering-slice_latency_selects_baseline.png!
> !https://issues.apache.org/jira/secure/attachment/13009750/clustering-slice_latency_under90_selects_baseline.png!
> Cluster with IN clause
> !https://issues.apache.org/jira/secure/attachment/13009749/clustering-in-clause_latency_selects_baseline.png!
> !https://issues.apache.org/jira/secure/attachment/13009748/clustering-in-clause_latency_under90_selects_baseline.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16095) When a table attempts to clean up metrics, it was cleaning up all global table metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-16095:
--
Status: Ready to Commit (was: Review In Progress)
> When a table attempts to clean up metrics, it was cleaning up all global
> table metrics
> --
>
> Key: CASSANDRA-16095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16095
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Altan Özlü
>Assignee: David Capwell
>Priority: Urgent
> Fix For: 4.0-beta
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> when i use
> {code:java}
> bin/nodetool tablestats {code}
> i get this error
> {code:java}
> error:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> -- StackTrace --
> javax.management.InstanceNotFoundException:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> {code}
> if i restart the node and check it works but if i write something then i get
> the error again
> * Cassandra 4.0-beta1
> * Ubuntu 20
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16095) When a table attempts to clean up metrics, it was cleaning up all global table metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-16095:
--
Reviewers: Jon Meredith, Jordan West, Yifan Cai (was: Jon Meredith, Yifan
Cai)
> When a table attempts to clean up metrics, it was cleaning up all global
> table metrics
> --
>
> Key: CASSANDRA-16095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16095
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Altan Özlü
>Assignee: David Capwell
>Priority: Urgent
> Fix For: 4.0-beta
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> when i use
> {code:java}
> bin/nodetool tablestats {code}
> i get this error
> {code:java}
> error:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> -- StackTrace --
> javax.management.InstanceNotFoundException:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> {code}
> if i restart the node and check it works but if i write something then i get
> the error again
> * Cassandra 4.0-beta1
> * Ubuntu 20
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-16205:
---
Reviewers: Ekaterina Dimitrova, Paulo Motta (was: Paulo Motta)
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242722#comment-17242722
]
Michael Semb Wever commented on CASSANDRA-16205:
Thanks [~paulo], appreciate and have enjoyed the process
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16284) Too defensive check when picking sstables for preview repair
[ https://issues.apache.org/jira/browse/CASSANDRA-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242710#comment-17242710 ] Adam Holmberg commented on CASSANDRA-16284: --- Got it. Thanks. > Too defensive check when picking sstables for preview repair > > > Key: CASSANDRA-16284 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16284 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta4 > > > We fail starting any preview repair if any sstable is marked pending but the > session not being finalized. The current check does not care if the range we > are previewing intersects with the sstable marked pending - this means that > we abort too many preview repairs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14834) Avoid keeping StreamingTombstoneHistogramBuilder.Spool in memory during the whole compaction
[
https://issues.apache.org/jira/browse/CASSANDRA-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242683#comment-17242683
]
Adam Holmberg commented on CASSANDRA-14834:
---
[~marcuse] I was thinking of taking a look at this, but I see you're assigned.
Do you have something in mind already? Intend to work on this?
> Avoid keeping StreamingTombstoneHistogramBuilder.Spool in memory during the
> whole compaction
>
>
> Key: CASSANDRA-14834
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14834
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Low
> Fix For: 4.0, 4.0-beta
>
>
> Since CASSANDRA-13444 {{StreamingTombstoneHistogramBuilder.Spool}} is
> allocated to keep around an array with 131072 * 2 * 2 integers *per written
> sstable* during the whole compaction. With LCS at times creating 1000s of
> sstables during a compaction it kills the node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16095) When a table attempts to clean up metrics, it was cleaning up all global table metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242679#comment-17242679
]
Jordan West commented on CASSANDRA-16095:
-
+1 LGTM
> When a table attempts to clean up metrics, it was cleaning up all global
> table metrics
> --
>
> Key: CASSANDRA-16095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16095
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Altan Özlü
>Assignee: David Capwell
>Priority: Urgent
> Fix For: 4.0-beta
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> when i use
> {code:java}
> bin/nodetool tablestats {code}
> i get this error
> {code:java}
> error:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> -- StackTrace --
> javax.management.InstanceNotFoundException:
> org.apache.cassandra.metrics:type=Table,keyspace=,scope=feed,name=WriteLatency
> {code}
> if i restart the node and check it works but if i write something then i get
> the error again
> * Cassandra 4.0-beta1
> * Ubuntu 20
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16284) Too defensive check when picking sstables for preview repair
[ https://issues.apache.org/jira/browse/CASSANDRA-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242673#comment-17242673 ] Marcus Eriksson commented on CASSANDRA-16284: - hey, thanks for the review, iirc the sleep was there because in some early version of in-jvm dtests we didn't wait for the schema to fully propagate > Too defensive check when picking sstables for preview repair > > > Key: CASSANDRA-16284 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16284 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta4 > > > We fail starting any preview repair if any sstable is marked pending but the > session not being finalized. The current check does not care if the range we > are previewing intersects with the sstable marked pending - this means that > we abort too many preview repairs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16284) Too defensive check when picking sstables for preview repair
[ https://issues.apache.org/jira/browse/CASSANDRA-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-16284: -- Reviewers: Adam Holmberg > Too defensive check when picking sstables for preview repair > > > Key: CASSANDRA-16284 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16284 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta4 > > > We fail starting any preview repair if any sstable is marked pending but the > session not being finalized. The current check does not care if the range we > are previewing intersects with the sstable marked pending - this means that > we abort too many preview repairs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16284) Too defensive check when picking sstables for preview repair
[ https://issues.apache.org/jira/browse/CASSANDRA-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242649#comment-17242649 ] Adam Holmberg commented on CASSANDRA-16284: --- Reviewed; +1 patch (non-committer). Nice test. The one question I had was on an apparently unrelated change [removing the sleep|https://github.com/aholmberg/cassandra/pull/19/commits/7116fdac97f61be92109269bcf48e28c82345c38#diff-d59b698a42b1c23cd6e27f5ddcb5b112ad80a9c53a61e4561a421e55ebd2L295]. It's not totally clear why it was there in the first place. Do you know why, or if something changed? > Too defensive check when picking sstables for preview repair > > > Key: CASSANDRA-16284 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16284 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta4 > > > We fail starting any preview repair if any sstable is marked pending but the > session not being finalized. The current check does not care if the range we > are previewing intersects with the sstable marked pending - this means that > we abort too many preview repairs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242586#comment-17242586 ] Brandon Williams commented on CASSANDRA-16225: -- Ninja'd the fix and correct changes entry in https://github.com/apache/cassandra/commit/2bcbd92a25c420b30cc8cc0eb8b266d9889ea973 > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta, 4.0-beta4, 3.0.24, 3.11.10 > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 7bdecd217606ca258cb77b8231d459b8b8f438f4 Merge: d9e2ed0 80a8deb Author: Brandon Williams AuthorDate: Wed Dec 2 12:15:25 2020 -0600 Merge branch 'cassandra-3.11' into trunk CHANGES.txt| 1 + src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index ce649c8,fb9921b..7458801 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,23 -1,8 +1,24 @@@ -3.11.10 - * Rate limit validation compactions using compaction_throughput_mb_per_sec (CASSANDRA-16161) +4.0-beta4 + * Remove Windows scripts (CASSANDRA-16171) + * Improve checksumming and compression in protocol V5 (CASSANDRA-15299) + * Optimised repair streaming improvements (CASSANDRA-16274) + * Update jctools dependency to 3.1.0 (CASSANDRA-16255) + * 'SSLEngine closed already' exception on failed outbound connection (CASSANDRA-16277) + * Drain and/or shutdown might throw because of slow messaging service shutdown (CASSANDRA-16276) + * Upgrade JNA to 5.6.0, dropping support for <=glibc-2.6 systems (CASSANDRA-16212) + * Add saved Host IDs to TokenMetadata at startup (CASSANDRA-16246) + * Ensure that CacheMetrics.requests is picked up by the metric reporter (CASSANDRA-16228) + * Add a ratelimiter to snapshot creation and deletion (CASSANDRA-13019) + * Produce consistent tombstone for reads to avoid digest mistmatch (CASSANDRA-15369) + * Fix SSTableloader issue when restoring a table named backups (CASSANDRA-16235) + * Invalid serialized size for responses caused by increasing message time by 1ms which caused extra bytes in size calculation (CASSANDRA-16103) + * Throw BufferOverflowException from DataOutputBuffer for better visibility (CASSANDRA-16214) + * TLS connections to the storage port on a node without server encryption configured causes java.io.IOException accessing missing keystore (CASSANDRA-16144) + * Internode messaging catches OOMs and does not rethrow (CASSANDRA-15214) +Merged from 3.11: * SASI's `max_compaction_flush_memory_in_mb` settings over 100GB revert to default of 1GB (CASSANDRA-16071) Merged from 3.0: + * Synchronize transaction logs for JBOD (CASSANDRA-16225) * Fix the counting of cells per partition (CASSANDRA-16259) * Fix serial read/non-applying CAS linearizability (CASSANDRA-12126) * Avoid potential NPE in JVMStabilityInspector (CASSANDRA-16294) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (e94459c -> 80a8deb)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from e94459c Merge branch cassandra-3.0 into cassandra-3.11 new 2bcbd92 Ninja fix CASSANDRA-16225 and update changes. new 80a8deb Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (d9e2ed0 -> 7bdecd2)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from d9e2ed0 Remove windows scripts and their references new 2bcbd92 Ninja fix CASSANDRA-16225 and update changes. new 80a8deb Merge branch 'cassandra-3.0' into cassandra-3.11 new 7bdecd2 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 80a8deb81c7c943922f1e979c80233a54b37cb7c Merge: e94459c 2bcbd92 Author: Brandon Williams AuthorDate: Wed Dec 2 12:15:19 2020 -0600 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt| 1 + src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 5020f99,1955168..fb9921b --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,7 -1,5 +1,8 @@@ -3.0.24: +3.11.10 + * Rate limit validation compactions using compaction_throughput_mb_per_sec (CASSANDRA-16161) + * SASI's `max_compaction_flush_memory_in_mb` settings over 100GB revert to default of 1GB (CASSANDRA-16071) +Merged from 3.0: + * Synchronize transaction logs for JBOD (CASSANDRA-16225) * Fix the counting of cells per partition (CASSANDRA-16259) * Fix serial read/non-applying CAS linearizability (CASSANDRA-12126) * Avoid potential NPE in JVMStabilityInspector (CASSANDRA-16294) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Ninja fix CASSANDRA-16225 and update changes.
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 2bcbd92 Ninja fix CASSANDRA-16225 and update changes.
2bcbd92 is described below
commit 2bcbd92a25c420b30cc8cc0eb8b266d9889ea973
Author: Brandon Williams
AuthorDate: Wed Dec 2 12:13:40 2020 -0600
Ninja fix CASSANDRA-16225 and update changes.
---
CHANGES.txt| 1 +
src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index bb968e8..1955168 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.24:
+ * Synchronize transaction logs for JBOD (CASSANDRA-16225)
* Fix the counting of cells per partition (CASSANDRA-16259)
* Fix serial read/non-applying CAS linearizability (CASSANDRA-12126)
* Avoid potential NPE in JVMStabilityInspector (CASSANDRA-16294)
diff --git a/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java
b/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java
index 5d858a9..da92fa2 100644
--- a/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java
+++ b/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java
@@ -151,7 +151,10 @@ class LogTransaction extends
Transactional.AbstractTransactional implements Tran
*/
void untrackNew(SSTable table)
{
-txnFile.remove(table);
+synchronized (lock)
+{
+txnFile.remove(table);
+}
}
/**
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14793) Improve system table handling when losing a disk when using JBOD
[ https://issues.apache.org/jira/browse/CASSANDRA-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-14793: -- Reviewers: Andres de la Peña, Marcus Eriksson, Andres de la Peña (was: Andres de la Peña, Marcus Eriksson) Andres de la Peña, Marcus Eriksson, Andres de la Peña (was: Andres de la Peña, Marcus Eriksson) Status: Review In Progress (was: Patch Available) > Improve system table handling when losing a disk when using JBOD > > > Key: CASSANDRA-14793 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14793 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Marcus Eriksson >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We should improve the way we handle disk failures when losing a disk in a > JBOD setup > One way could be to pin the system tables to a special data directory. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16171) Remove Windows scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-16171: -- Fix Version/s: (was: 4.0-rc) 4.0-beta4 Source Control Link: https://github.com/apache/cassandra/commit/d9e2ed00afd8fae4bcbec02a4b323e55e4f43d88 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Remove Windows scripts > -- > > Key: CASSANDRA-16171 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16171 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Yuki Morishita >Assignee: Yuki Morishita >Priority: Normal > Fix For: 4.0-beta4 > > Time Spent: 10m > Remaining Estimate: 0h > > As per the email thread in cassandra-dev mailing list[1], remove windows > scripts from Cassandra 4.0 onwards, due to the lack of maintenance and tests. > 1: https://www.mail-archive.com/dev@cassandra.apache.org/msg15583.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16171) Remove Windows scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242507#comment-17242507 ] Andres de la Peña commented on CASSANDRA-16171: --- Committed to trunk as [d9e2ed00afd8fae4bcbec02a4b323e55e4f43d88|https://github.com/apache/cassandra/commit/d9e2ed00afd8fae4bcbec02a4b323e55e4f43d88]. > Remove Windows scripts > -- > > Key: CASSANDRA-16171 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16171 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Yuki Morishita >Assignee: Yuki Morishita >Priority: Normal > Fix For: 4.0-rc > > Time Spent: 10m > Remaining Estimate: 0h > > As per the email thread in cassandra-dev mailing list[1], remove windows > scripts from Cassandra 4.0 onwards, due to the lack of maintenance and tests. > 1: https://www.mail-archive.com/dev@cassandra.apache.org/msg15583.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Remove windows scripts and their references
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new d9e2ed0 Remove windows scripts and their references d9e2ed0 is described below commit d9e2ed00afd8fae4bcbec02a4b323e55e4f43d88 Author: Yuki Morishita AuthorDate: Wed Dec 2 16:43:45 2020 + Remove windows scripts and their references patch by Yuki Morishita; reviewed by Berenguer Blasi and Andrés de la Peña for CASSANDRA-16171 --- CHANGES.txt | 1 + NEWS.txt | 9 +- README.asc | 8 - bin/cassandra.bat| 184 -- bin/cassandra.in.bat | 74 -- bin/cassandra.ps1| 390 - bin/cqlsh.bat| 34 --- bin/debug-cql.bat| 39 --- bin/nodetool.bat | 38 --- bin/source-conf.ps1 | 57 - bin/sstableloader.bat| 41 --- bin/sstablescrub.bat | 41 --- bin/sstableupgrade.bat | 41 --- bin/sstableutil.bat | 41 --- bin/sstableverify.bat| 48 bin/stop-server.bat | 55 bin/stop-server.ps1 | 193 -- build.xml| 12 +- conf/cassandra-env.ps1 | 469 --- doc/source/operating/security.rst| 4 +- pylib/cqlshlib/test/run_cqlsh.py | 2 - redhat/cassandra.spec| 6 +- tools/bin/auditlogviewer.bat | 41 --- tools/bin/cassandra-stress.bat | 22 -- tools/bin/cassandra.in.bat | 45 tools/bin/fqltool.bat| 36 --- tools/bin/jmxtool.bat| 36 --- tools/bin/sstabledump.bat| 48 tools/bin/sstableexpiredblockers.bat | 23 -- tools/bin/sstablelevelreset.bat | 46 tools/bin/sstablemetadata.bat| 23 -- tools/bin/sstableofflinerelevel.bat | 49 tools/bin/sstablerepairedset.bat | 46 tools/bin/sstablesplit.bat | 41 --- 34 files changed, 15 insertions(+), 2228 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index a51d471..ce649c8 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.0-beta4 + * Remove Windows scripts (CASSANDRA-16171) * Improve checksumming and compression in protocol V5 (CASSANDRA-15299) * Optimised repair streaming improvements (CASSANDRA-16274) * Update jctools dependency to 3.1.0 (CASSANDRA-16255) diff --git a/NEWS.txt b/NEWS.txt index d02f2f0..987a6b6 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -258,7 +258,6 @@ Upgrading If it is not defined, or not equal to the numbers of tokens defined in initial_tokens, the node will not start. See CASSANDRA-14477 for details. - Deprecation --- @@ -266,7 +265,6 @@ Deprecation deprecated in favor of org.apache.cassandra.db:type=DisallowedDirectories and will be removed in a subsequent major version. - Materialized Views --- - Following a discussion regarding concerns about the design and safety of Materialized Views, the C* development @@ -278,6 +276,13 @@ Materialized Views to be NOT NULL, and no base primary key columns get automatically included in view definition. You have to specify them explicitly now. +Windows Support Removed +--- +- Due to the lack of maintenance and testing, Windows support is removed from this version onward. The developers + who use Windows 10 still can run Apache Cassandra locally using WSL2 (Windows Subsystem for Linux version 2), + Docker for Windows, or virtualization platform like Hyper-V and VirtualBox. + + 3.11.10 == diff --git a/README.asc b/README.asc index b7ec492..194b1ee 100644 --- a/README.asc +++ b/README.asc @@ -30,14 +30,6 @@ Cassandra to remain in the foreground and log to standard out; it can be stopped $ bin/cassandra -f - -Note for Windows users: to install Cassandra as a service, download -http://commons.apache.org/daemon/procrun.html[Procrun], set the -PRUNSRV environment variable to the full path of prunsrv (e.g., -C:\procrun\prunsrv.exe), and run "bin\cassandra.bat install". -Similarly, "uninstall" will remove the service. - - Now let's try to read and write some data using the Cassandra Query Language: $ bin/cqlsh diff --git a/bin/cassandra.bat b/bin/cassandra.bat deleted file mode 100644 index 24889d8..000 --- a/bin/cassandra.bat +++ /dev/null @@ -1,184 +0,0 @@ -@REM -@REM Licensed to the Apache Software Foundation (ASF) under one or more -@REM contributor license agreements. See the NOTICE file distributed with -@REM this work for additional information regarding
[jira] [Updated] (CASSANDRA-16136) Provide access to metrics from in-jvm dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-16136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-16136: Change Category: Quality Assurance Complexity: Normal Component/s: Test/dtest/java Reviewers: Benedict Elliott Smith Status: Open (was: Triage Needed) > Provide access to metrics from in-jvm dtests > > > Key: CASSANDRA-16136 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16136 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest/java >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > > Current implementation requires of in-jvm dtests requires using > callOnInstance in order to get metrics out of the in-jvm test node. Since > many dtests require to check metrics, we need a version-agnostic mechanism > that allows us to query the value of the metric by its published name instead > of peeking into internals. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15897) Dropping compact storage with 2.1-sstables on disk make them unreadable
[ https://issues.apache.org/jira/browse/CASSANDRA-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-15897: Authors: Sylvain Lebresne (was: Ekaterina Dimitrova) > Dropping compact storage with 2.1-sstables on disk make them unreadable > --- > > Key: CASSANDRA-15897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15897 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Marcus Eriksson >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 4.0-beta > > > Test reproducing: > https://github.com/krummas/cassandra/commits/marcuse/dropcompactstorage -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16240) Having issues creating a table with name profiles
[ https://issues.apache.org/jira/browse/CASSANDRA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg reassigned CASSANDRA-16240: - Assignee: Adam Holmberg > Having issues creating a table with name profiles > - > > Key: CASSANDRA-16240 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16240 > Project: Cassandra > Issue Type: Bug >Reporter: Anuj Kulkarni >Assignee: Adam Holmberg >Priority: Normal > Attachments: image-2020-11-02-12-13-16-999.png > > > Whenever I try to create a table with name profiles, it always gets created > with additional quotes surrounding it. Attaching the screenshot. > I am on Cassandra 3.7 > I tried creating the table in another keyspace. I also tried creating new > virtual machines with the same AMI and same Cassandra version, but to no > avail. > If I try to create a table with any other name, there are no issues at all. > It's just with the name profiles. > I am on Ubuntu 18.04 by the way. > !image-2020-11-02-12-13-16-999.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15897) Dropping compact storage with 2.1-sstables on disk make them unreadable
[ https://issues.apache.org/jira/browse/CASSANDRA-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-15897: --- Assignee: Ekaterina Dimitrova (was: Sylvain Lebresne) > Dropping compact storage with 2.1-sstables on disk make them unreadable > --- > > Key: CASSANDRA-15897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15897 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Marcus Eriksson >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 4.0-beta > > > Test reproducing: > https://github.com/krummas/cassandra/commits/marcuse/dropcompactstorage -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16240) Having issues creating a table with name profiles
[ https://issues.apache.org/jira/browse/CASSANDRA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-16240: -- Resolution: Not A Problem Status: Resolved (was: Triage Needed) > Having issues creating a table with name profiles > - > > Key: CASSANDRA-16240 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16240 > Project: Cassandra > Issue Type: Bug >Reporter: Anuj Kulkarni >Assignee: Adam Holmberg >Priority: Normal > Attachments: image-2020-11-02-12-13-16-999.png > > > Whenever I try to create a table with name profiles, it always gets created > with additional quotes surrounding it. Attaching the screenshot. > I am on Cassandra 3.7 > I tried creating the table in another keyspace. I also tried creating new > virtual machines with the same AMI and same Cassandra version, but to no > avail. > If I try to create a table with any other name, there are no issues at all. > It's just with the name profiles. > I am on Ubuntu 18.04 by the way. > !image-2020-11-02-12-13-16-999.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16240) Having issues creating a table with name profiles
[ https://issues.apache.org/jira/browse/CASSANDRA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242451#comment-17242451 ] Adam Holmberg commented on CASSANDRA-16240: --- That explains the difference. Thanks. Here's the Python driver ticket: https://datastax-oss.atlassian.net/browse/PYTHON-1270 Going to resolve this one. Thanks for bringing it up. > Having issues creating a table with name profiles > - > > Key: CASSANDRA-16240 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16240 > Project: Cassandra > Issue Type: Bug >Reporter: Anuj Kulkarni >Priority: Normal > Attachments: image-2020-11-02-12-13-16-999.png > > > Whenever I try to create a table with name profiles, it always gets created > with additional quotes surrounding it. Attaching the screenshot. > I am on Cassandra 3.7 > I tried creating the table in another keyspace. I also tried creating new > virtual machines with the same AMI and same Cassandra version, but to no > avail. > If I try to create a table with any other name, there are no issues at all. > It's just with the name profiles. > I am on Ubuntu 18.04 by the way. > !image-2020-11-02-12-13-16-999.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16078) Performance regression for queries accessing multiple rows
[ https://issues.apache.org/jira/browse/CASSANDRA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242434#comment-17242434 ] Ekaterina Dimitrova commented on CASSANDRA-16078: - Hey [~dcapwell], can you, please, share your test to reproduce the issue? I am not sure which benchmark you are talking about. > Performance regression for queries accessing multiple rows > -- > > Key: CASSANDRA-16078 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16078 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Coordination >Reporter: David Capwell >Priority: Normal > Fix For: 4.0-beta > > Attachments: image.png > > > This is spin off from CASSANDRA-16036. > In testing 4.0 relative to 3.0* I found that queries which accessed multiple > rows to have a noticeable performance decrease; two queries were used in the > test (more may be impacted, others might not): query partition (table has > clustering keys) with LIMIT, and query clustering keys using IN clause. > In the below graphs the green line is 3.0 and the other lines are 4.0 (with > and without chunk cache) > Partition with LIMIT > !https://issues.apache.org/jira/secure/attachment/13009751/clustering-slice_latency_selects_baseline.png! > !https://issues.apache.org/jira/secure/attachment/13009750/clustering-slice_latency_under90_selects_baseline.png! > Cluster with IN clause > !https://issues.apache.org/jira/secure/attachment/13009749/clustering-in-clause_latency_selects_baseline.png! > !https://issues.apache.org/jira/secure/attachment/13009748/clustering-in-clause_latency_under90_selects_baseline.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16303) ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory
[ https://issues.apache.org/jira/browse/CASSANDRA-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16303: --- Since Version: 4.0-alpha1 > ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory > - > > Key: CASSANDRA-16303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16303 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Adrian Cole >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-beta > > > If you look at the pom for cassandra-all 4.0.0-beta-3, you'll notice that > concurrent-trees is in dependencyManagement, but not dependencies. This might > be going unnoticed as sasi is disabled by default now, but it can lead to a > ClassNotFoundException. I presume this was accidental -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16303) ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory
[ https://issues.apache.org/jira/browse/CASSANDRA-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242402#comment-17242402 ] Michael Semb Wever edited comment on CASSANDRA-16303 at 12/2/20, 2:45 PM: -- git bisect shows e8b8a90336dfd7d8b3fe06d06fe6970ab3be5fa1 was the last commit to have it, and [4881d9c308ccd6b5ca70925bf6ebedb70e7705fc|https://github.com/apache/cassandra/commit/4881d9c308ccd6b5ca70925bf6ebedb70e7705fc#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021L639] removed the dependency from the all-pom. This looks to have happened because it was originally incorrectly [added|https://github.com/apache/cassandra/commit/72790dc8e34826b39ac696b03025ae6b7b6beb2b#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021R572] in the thrift-pom. was (Author: michaelsembwever): git bisect shows e8b8a90336dfd7d8b3fe06d06fe6970ab3be5fa1 was the last commit to have it, and [4881d9c308ccd6b5ca70925bf6ebedb70e7705fc|https://github.com/apache/cassandra/commit/4881d9c308ccd6b5ca70925bf6ebedb70e7705fc#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021L639] removed the dependency from the all-pom. This looks to have happened because it was originally incorrectly added in the thrift-pom. > ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory > - > > Key: CASSANDRA-16303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16303 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Adrian Cole >Priority: Normal > Fix For: 4.0-beta > > > If you look at the pom for cassandra-all 4.0.0-beta-3, you'll notice that > concurrent-trees is in dependencyManagement, but not dependencies. This might > be going unnoticed as sasi is disabled by default now, but it can lead to a > ClassNotFoundException. I presume this was accidental -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16303) ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory
[ https://issues.apache.org/jira/browse/CASSANDRA-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever reassigned CASSANDRA-16303: -- Assignee: Michael Semb Wever > ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory > - > > Key: CASSANDRA-16303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16303 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Adrian Cole >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-beta > > > If you look at the pom for cassandra-all 4.0.0-beta-3, you'll notice that > concurrent-trees is in dependencyManagement, but not dependencies. This might > be going unnoticed as sasi is disabled by default now, but it can lead to a > ClassNotFoundException. I presume this was accidental -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16303) ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory
[ https://issues.apache.org/jira/browse/CASSANDRA-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242402#comment-17242402 ] Michael Semb Wever commented on CASSANDRA-16303: git bisect shows e8b8a90336dfd7d8b3fe06d06fe6970ab3be5fa1 was the last commit to have it, and [4881d9c308ccd6b5ca70925bf6ebedb70e7705fc|https://github.com/apache/cassandra/commit/4881d9c308ccd6b5ca70925bf6ebedb70e7705fc#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021L639] removed the dependency from the all-pom. This looks to have happened because it was originally incorrectly added in the thrift-pom. > ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory > - > > Key: CASSANDRA-16303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16303 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Adrian Cole >Priority: Normal > Fix For: 4.0-beta > > > If you look at the pom for cassandra-all 4.0.0-beta-3, you'll notice that > concurrent-trees is in dependencyManagement, but not dependencies. This might > be going unnoticed as sasi is disabled by default now, but it can lead to a > ClassNotFoundException. I presume this was accidental -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16308: Reviewers: Paulo Motta > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Krishna Vadali >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242382#comment-17242382
]
Benjamin Lerer commented on CASSANDRA-16259:
Thanks a lot [~Bereng] and [~jasonstack] for the review :-)
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta4, 2.2.20, 3.0.24, 3.11.10
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
> at
>
[jira] [Updated] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16259:
---
Fix Version/s: (was: 4.0-beta)
(was: 3.11.x)
(was: 3.0.x)
(was: 2.2.x)
3.11.10
3.0.24
2.2.20
4.0-beta4
Since Version: 2.2.0
Source Control Link:
https://github.com/apache/cassandra/commit/e96b60bd9f814ee1a911e8820b7e255d23e2f24e
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
The fix for the histogram merge of the table metrics was committed into
cassandra-2.2 at e96b60bd9f814ee1a911e8820b7e255d23e2f24e and merged int
cassandra-3.0, cassandra-3.11 and trung
The fix for the counting of partition cells was committed into cassandra-3.0 at
6baeb9247b9156c08305326a77d8c27510d6cb40 and merged into cassandra-3.11 and
trunk
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta4, 2.2.20, 3.0.24, 3.11.10
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
>
[jira] [Updated] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16259:
---
Status: Ready to Commit (was: Review In Progress)
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
> at
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
> at
>
[cassandra] branch trunk updated (90b2f3e -> 39d2974)
This is an automated email from the ASF dual-hosted git repository. blerer pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 90b2f3e CASSANDRA-16274 followup 2 - reduce iterations in OptimiseStreamsRepairTest to make it pass in low resource CI add e96b60b Fix the histogram merge of the table metrics add d3770b4 Merge branch cassandra-2.2 into cassandra-3.0 add 6baeb92 Fix the counting of cells per partition add e94459c Merge branch cassandra-3.0 into cassandra-3.11 new 39d2974 Merge branch cassandra-3.11 into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 3 + .../cassandra/db/transform/BaseIterator.java | 29 - .../org/apache/cassandra/metrics/TableMetrics.java | 50 - .../cassandra/db/ColumnFamilyMetricTest.java | 124 ++--- 4 files changed, 157 insertions(+), 49 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch cassandra-3.11 into trunk
This is an automated email from the ASF dual-hosted git repository. blerer pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 39d297437983003b8886a3b711ed7f25ea6777f4 Merge: 90b2f3e e94459c Author: Benjamin Lerer AuthorDate: Wed Dec 2 14:47:18 2020 +0100 Merge branch cassandra-3.11 into trunk CHANGES.txt| 3 + .../cassandra/db/transform/BaseIterator.java | 29 - .../org/apache/cassandra/metrics/TableMetrics.java | 50 - .../cassandra/db/ColumnFamilyMetricTest.java | 124 ++--- 4 files changed, 157 insertions(+), 49 deletions(-) diff --cc CHANGES.txt index 6e96738,5020f99..a51d471 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,58 -1,20 +1,61 @@@ -3.11.10 - * Rate limit validation compactions using compaction_throughput_mb_per_sec (CASSANDRA-16161) +4.0-beta4 + * Improve checksumming and compression in protocol V5 (CASSANDRA-15299) + * Optimised repair streaming improvements (CASSANDRA-16274) + * Update jctools dependency to 3.1.0 (CASSANDRA-16255) + * 'SSLEngine closed already' exception on failed outbound connection (CASSANDRA-16277) + * Drain and/or shutdown might throw because of slow messaging service shutdown (CASSANDRA-16276) + * Upgrade JNA to 5.6.0, dropping support for <=glibc-2.6 systems (CASSANDRA-16212) + * Add saved Host IDs to TokenMetadata at startup (CASSANDRA-16246) + * Ensure that CacheMetrics.requests is picked up by the metric reporter (CASSANDRA-16228) + * Add a ratelimiter to snapshot creation and deletion (CASSANDRA-13019) + * Produce consistent tombstone for reads to avoid digest mistmatch (CASSANDRA-15369) + * Fix SSTableloader issue when restoring a table named backups (CASSANDRA-16235) + * Invalid serialized size for responses caused by increasing message time by 1ms which caused extra bytes in size calculation (CASSANDRA-16103) + * Throw BufferOverflowException from DataOutputBuffer for better visibility (CASSANDRA-16214) + * TLS connections to the storage port on a node without server encryption configured causes java.io.IOException accessing missing keystore (CASSANDRA-16144) + * Internode messaging catches OOMs and does not rethrow (CASSANDRA-15214) +Merged from 3.11: * SASI's `max_compaction_flush_memory_in_mb` settings over 100GB revert to default of 1GB (CASSANDRA-16071) Merged from 3.0: + * Fix the counting of cells per partition (CASSANDRA-16259) * Fix serial read/non-applying CAS linearizability (CASSANDRA-12126) * Avoid potential NPE in JVMStabilityInspector (CASSANDRA-16294) * Improved check of num_tokens against the length of initial_token (CASSANDRA-14477) * Fix a race condition on ColumnFamilyStore and TableMetrics (CASSANDRA-16228) * Remove the SEPExecutor blocking behavior (CASSANDRA-16186) - * Fix invalid cell value skipping when reading from disk (CASSANDRA-16223) + * Wait for schema agreement when bootstrapping (CASSANDRA-15158) * Prevent invoking enable/disable gossip when not in NORMAL (CASSANDRA-16146) + * Raise Dynamic Snitch Default Badness Threshold to 1.0 (CASSANDRA-16285) + Merged from 2.2: + * Fix the histogram merge of the table metrics (CASSANDRA-16259) -3.11.9 - * Synchronize Keyspace instance store/clear (CASSANDRA-16210) +4.0-beta3 + * Segregate Network and Chunk Cache BufferPools and Recirculate Partially Freed Chunks (CASSANDRA-15229) + * Fail truncation requests when they fail on a replica (CASSANDRA-16208) + * Move compact storage validation earlier in startup process (CASSANDRA-16063) + * Fix ByteBufferAccessor cast exceptions are thrown when trying to query a virtual table (CASSANDRA-16155) + * Consolidate node liveness check for forced repair (CASSANDRA-16113) + * Use unsigned short in ValueAccessor.sliceWithShortLength (CASSANDRA-16147) + * Abort repairs when getting a truncation request (CASSANDRA-15854) + * Remove bad assert when getting active compactions for an sstable (CASSANDRA-15457) + * Avoid failing compactions with very large partitions (CASSANDRA-15164) + * Prevent NPE in StreamMessage in type lookup (CASSANDRA-16131) + * Avoid invalid state transition exception during incremental repair (CASSANDRA-16067) + * Allow zero padding in timestamp serialization (CASSANDRA-16105) + * Add byte array backed cells (CASSANDRA-15393) + * Correctly handle pending ranges with adjacent range movements (CASSANDRA-14801) + * Avoid adding locahost when streaming trivial ranges (CASSANDRA-16099) + * Add nodetool getfullquerylog (CASSANDRA-15988) + * Fix yaml format and alignment in tpstats (CASSANDRA-11402) + * Avoid trying to keep track of RTs for endpoints we won't write to during read repair (CASSANDRA-16084) + * When compaction gets interrupted, the exception should include the compactionId (CASSANDRA-15954) + * Make Table/Keyspace Metric Names Consistent With Each Other (CASSANDRA-15909) + * Mutating
[cassandra] branch cassandra-3.0 updated (de85f43 -> 6baeb92)
This is an automated email from the ASF dual-hosted git repository. blerer pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from de85f43 Merge branch 'cassandra-2.2' into cassandra-3.0 add e96b60b Fix the histogram merge of the table metrics add d3770b4 Merge branch cassandra-2.2 into cassandra-3.0 add 6baeb92 Fix the counting of cells per partition No new revisions were added by this update. Summary of changes: CHANGES.txt| 3 + .../cassandra/db/transform/BaseIterator.java | 30 - .../org/apache/cassandra/metrics/TableMetrics.java | 44 +++ .../cassandra/db/ColumnFamilyMetricTest.java | 132 + 4 files changed, 160 insertions(+), 49 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (3f11261 -> e94459c)
This is an automated email from the ASF dual-hosted git repository. blerer pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 3f11261 Merge branch 'cassandra-3.0' into cassandra-3.11 add e96b60b Fix the histogram merge of the table metrics add d3770b4 Merge branch cassandra-2.2 into cassandra-3.0 add 6baeb92 Fix the counting of cells per partition add e94459c Merge branch cassandra-3.0 into cassandra-3.11 No new revisions were added by this update. Summary of changes: CHANGES.txt| 3 + .../cassandra/db/transform/BaseIterator.java | 30 - .../org/apache/cassandra/metrics/TableMetrics.java | 45 --- .../cassandra/db/ColumnFamilyMetricTest.java | 132 + 4 files changed, 159 insertions(+), 51 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated (466c65a -> e96b60b)
This is an automated email from the ASF dual-hosted git repository. blerer pushed a change to branch cassandra-2.2 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 466c65a Update to latest docker image for CircleCI add e96b60b Fix the histogram merge of the table metrics No new revisions were added by this update. Summary of changes: CHANGES.txt| 2 +- .../cassandra/metrics/ColumnFamilyMetrics.java | 43 +++--- .../cassandra/db/ColumnFamilyMetricTest.java | 170 + 3 files changed, 162 insertions(+), 53 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242374#comment-17242374 ] Krishna Vadali commented on CASSANDRA-16308: I will pick this up. > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Krishna Vadali >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Vadali reassigned CASSANDRA-16308: -- Assignee: Krishna Vadali > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Krishna Vadali >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16308: Change Category: Operability Complexity: Low Hanging Fruit Priority: Low (was: Normal) Status: Open (was: Triage Needed) > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
Paulo Motta created CASSANDRA-16308: --- Summary: Add droppable tombstone metrics to nodetool tablestats Key: CASSANDRA-16308 URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 Project: Cassandra Issue Type: Improvement Components: Tool/nodetool Reporter: Paulo Motta This is a useful metric to troubleshoot tombstone cleanup problems and is not currently exposed on table stats. While we're at it we should add the JMX metric to the table metrics documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242356#comment-17242356
]
Paulo Motta commented on CASSANDRA-16205:
-
Great job, LGTM! Thanks for bearing with my nitpicking in a constructive way ;-)
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-16205:
Status: Ready to Commit (was: Review In Progress)
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: CASSANDRA-16274 followup 2 - reduce iterations in OptimiseStreamsRepairTest to make it pass in low resource CI
This is an automated email from the ASF dual-hosted git repository.
marcuse pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 90b2f3e CASSANDRA-16274 followup 2 - reduce iterations in
OptimiseStreamsRepairTest to make it pass in low resource CI
90b2f3e is described below
commit 90b2f3e068a95e4fd70ec19d0dff60abcf10efc8
Author: Marcus Eriksson
AuthorDate: Wed Dec 2 13:18:04 2020 +0100
CASSANDRA-16274 followup 2 - reduce iterations in OptimiseStreamsRepairTest
to make it pass in low resource CI
---
.../cassandra/distributed/test/OptimiseStreamsRepairTest.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/OptimiseStreamsRepairTest.java
b/test/distributed/org/apache/cassandra/distributed/test/OptimiseStreamsRepairTest.java
index 8a1c1d7..96ae1dc 100644
---
a/test/distributed/org/apache/cassandra/distributed/test/OptimiseStreamsRepairTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/OptimiseStreamsRepairTest.java
@@ -72,7 +72,7 @@ public class OptimiseStreamsRepairTest extends TestBaseImpl
.start()))
{
cluster.schemaChange("create table " + KEYSPACE + ".tbl (id int
primary key, t int) with compaction={'class': 'SizeTieredCompactionStrategy'}");
-for (int i = 0; i < 10; i++)
+for (int i = 0; i < 1; i++)
cluster.coordinator(1).execute("INSERT INTO " + KEYSPACE +
".tbl (id, t) values (?,?)", ConsistencyLevel.ALL, i, i);
cluster.forEach((i) -> i.flush(KEYSPACE));
@@ -82,7 +82,7 @@ public class OptimiseStreamsRepairTest extends TestBaseImpl
cluster.coordinator(1).execute("INSERT INTO "+KEYSPACE+".tbl
(id, t) values (?,?)", ConsistencyLevel.QUORUM, i, i * 2 + 2);
cluster.get(2).startup();
-Thread.sleep(1);
+Thread.sleep(1000);
cluster.forEach(c -> c.flush(KEYSPACE));
cluster.forEach(c -> c.forceCompact(KEYSPACE, "tbl"));
@@ -171,12 +171,12 @@ public class OptimiseStreamsRepairTest extends
TestBaseImpl
.start()))
{
cluster.schemaChange("create table " + KEYSPACE + ".tbl (id int
primary key, t int) with compaction={'class': 'SizeTieredCompactionStrategy'}");
-for (int i = 0; i < 10_000; i++)
+for (int i = 0; i < 1000; i++)
cluster.coordinator(1).execute("INSERT INTO " + KEYSPACE +
".tbl (id, t) values (?,?)", ConsistencyLevel.ALL, i, i);
cluster.forEach((i) -> i.flush(KEYSPACE));
Random r = new Random();
-for (int i = 0; i < 2; i++)
+for (int i = 0; i < 500; i++)
for (int j = 1; j <= 3; j++)
cluster.get(j).executeInternal("INSERT INTO
"+KEYSPACE+".tbl (id, t) values (?,?)", r.nextInt(), i * 2 + 2);
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16240) Having issues creating a table with name profiles
[ https://issues.apache.org/jira/browse/CASSANDRA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242298#comment-17242298 ] Anuj Kulkarni commented on CASSANDRA-16240: --- Well, I guess I know the answer why I am observing different behaviours on two environments. The environment with the issue: [GCC 7.5.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import cassandra >>> print cassandra.__version__ 3.21.0 >>> The environment not facing the issue: [GCC 7.5.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import cassandra >>> print cassandra.__version__ 3.18.0 >>> > Having issues creating a table with name profiles > - > > Key: CASSANDRA-16240 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16240 > Project: Cassandra > Issue Type: Bug >Reporter: Anuj Kulkarni >Priority: Normal > Attachments: image-2020-11-02-12-13-16-999.png > > > Whenever I try to create a table with name profiles, it always gets created > with additional quotes surrounding it. Attaching the screenshot. > I am on Cassandra 3.7 > I tried creating the table in another keyspace. I also tried creating new > virtual machines with the same AMI and same Cassandra version, but to no > avail. > If I try to create a table with any other name, there are no issues at all. > It's just with the name profiles. > I am on Ubuntu 18.04 by the way. > !image-2020-11-02-12-13-16-999.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16305) Remove duplicate code used by CQLTester and SchemaLoader
[
https://issues.apache.org/jira/browse/CASSANDRA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16305:
---
Fix Version/s: (was: 4.x)
4.0-beta4
Source Control Link:
https://github.com/apache/cassandra/commit/c7d098c7ac9f4a7f8db73b71061375bfbf70be30
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed into trunk at CASSANDRA-16305
> Remove duplicate code used by CQLTester and SchemaLoader
>
>
> Key: CASSANDRA-16305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16305
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta4
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> While digging into the cause behind CASSANDRA-16302, we discovered that there
> is some duplicate code in {{SchemaLoader}} and {{CQLTester}}. Over time that
> code has evolved slightly differently in both classes leading to some
> different behavior.
> Having the same code being used by both class will ensure that if the code
> needs to be change the behavior will be correct same one for both classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Remove duplicated code from CQLTester and SchemaLoader
This is an automated email from the ASF dual-hosted git repository.
blerer pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new c7d098c Remove duplicated code from CQLTester and SchemaLoader
c7d098c is described below
commit c7d098c7ac9f4a7f8db73b71061375bfbf70be30
Author: Benjamin Lerer
AuthorDate: Fri Nov 27 17:39:00 2020 +0100
Remove duplicated code from CQLTester and SchemaLoader
patch by Benjamin Lerer; reviewed by Berenguer Blasi for CASSANDRA-16305
---
.../apache/cassandra/db/commitlog/CommitLog.java | 3 +
.../org/apache/cassandra/io/util/FileUtils.java| 20 ++-
test/unit/org/apache/cassandra/SchemaLoader.java | 52 +-
.../unit/org/apache/cassandra/ServerTestUtils.java | 192 +
test/unit/org/apache/cassandra/cql3/CQLTester.java | 185 +---
.../cassandra/locator/AlibabaCloudSnitchTest.java | 19 +-
.../cassandra/locator/CloudstackSnitchTest.java| 7 +-
.../apache/cassandra/locator/EC2SnitchTest.java| 7 +-
.../cassandra/locator/GoogleCloudSnitchTest.java | 7 +-
.../service/StorageServiceServerTest.java | 25 ++-
10 files changed, 294 insertions(+), 223 deletions(-)
diff --git a/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
b/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
index 14b1a3a..1492ccf 100644
--- a/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
+++ b/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
@@ -454,6 +454,9 @@ public class CommitLog implements CommitLogMBean
@VisibleForTesting
synchronized public void stopUnsafe(boolean deleteSegments)
{
+if (!started)
+return;
+
started = false;
executor.shutdown();
try
diff --git a/src/java/org/apache/cassandra/io/util/FileUtils.java
b/src/java/org/apache/cassandra/io/util/FileUtils.java
index bcd848a..f506140 100644
--- a/src/java/org/apache/cassandra/io/util/FileUtils.java
+++ b/src/java/org/apache/cassandra/io/util/FileUtils.java
@@ -591,21 +591,33 @@ public final class FileUtils
/**
- * Deletes all files and subdirectories under "dir".
+ * Deletes the specified directory after having deleted its content.
+ *
* @param dir Directory to be deleted
* @throws FSWriteError if any part of the tree cannot be deleted
*/
public static void deleteRecursive(File dir)
{
+deleteChildrenRecursive(dir);
+
+// The directory is now empty so now it can be smoked
+deleteWithConfirm(dir);
+}
+
+/**
+ * Deletes all files and subdirectories under "dir".
+ *
+ * @param dir Directory to be deleted
+ * @throws FSWriteError if any part of the tree cannot be deleted
+ */
+public static void deleteChildrenRecursive(File dir)
+{
if (dir.isDirectory())
{
String[] children = dir.list();
for (String child : children)
deleteRecursive(new File(dir, child));
}
-
-// The directory is now empty so now it can be smoked
-deleteWithConfirm(dir);
}
/**
diff --git a/test/unit/org/apache/cassandra/SchemaLoader.java
b/test/unit/org/apache/cassandra/SchemaLoader.java
index 760d7ba..001e155 100644
--- a/test/unit/org/apache/cassandra/SchemaLoader.java
+++ b/test/unit/org/apache/cassandra/SchemaLoader.java
@@ -73,7 +73,8 @@ public class SchemaLoader
public static void prepareServer()
{
- CQLTester.prepareServer();
+ServerTestUtils.daemonInitialization();
+ServerTestUtils.prepareServer();
}
public static void startGossiper()
@@ -727,47 +728,7 @@ public static TableMetadata.Builder
clusteringSASICFMD(String ksName, String cfN
public static void cleanupAndLeaveDirs() throws IOException
{
-// We need to stop and unmap all CLS instances prior to cleanup() or
we'll get failures on Windows.
-CommitLog.instance.stopUnsafe(true);
-mkdirs();
-cleanup();
-mkdirs();
-CommitLog.instance.restartUnsafe();
-}
-
-public static void cleanup()
-{
-// clean up commitlog
-String[] directoryNames = { DatabaseDescriptor.getCommitLogLocation(),
};
-for (String dirName : directoryNames)
-{
-File dir = new File(dirName);
-if (!dir.exists())
-throw new RuntimeException("No such directory: " +
dir.getAbsolutePath());
-
-// Leave the folder around as Windows will complain about
directory deletion w/handles open to children files
-String[] children = dir.list();
-for (String child : children)
-FileUtils.deleteRecursive(new File(dir, child));
-}
-
-cleanupSavedCaches();
-
-// clean up data directory which are stored as data
[jira] [Updated] (CASSANDRA-16143) Streaming fails when s SSTable writer finish() exceeds internode_tcp_user_timeout
[
https://issues.apache.org/jira/browse/CASSANDRA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16143:
---
Reviewers: Adam Holmberg, Benjamin Lerer, Berenguer Blasi (was: Adam
Holmberg, Berenguer Blasi)
> Streaming fails when s SSTable writer finish() exceeds
> internode_tcp_user_timeout
> -
>
> Key: CASSANDRA-16143
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16143
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Jon Meredith
>Assignee: Yifan Cai
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> tl;dr The internode TCP user timeout that provides more responsive detection
> of dead nodes for internode message will cause streaming to fail if system
> calls to fsync/fdatasync exceed the timeout (default 30s).
> To workaround, explicitly set internode_tcp_user_timeout to longer than
> fsync/fdatasync, or to zero to revert to the operating system default.
> Details:
> While bootstrapping a replacement 4.0beta3 node in an existing cluster,
> bootstrap streaming repeatedly failed with the streaming follower logging
> {code:java}
> ERROR 2020-09-10T14:29:34,711 [NettyStreaming-Outbound-1.1.1.1.7000:1]
> org.apache.cassandra.streaming.StreamSession:693 - [Stream
> #7cb67c00-f3ac-11ea-b940-f7836f164528] Streaming error occurred on session
> with peer 1.1.1.1:7000
> org.apache.cassandra.net.AsyncChannelOutputPlus$FlushException: The channel
> this output stream was writing to has been closed
>at
> org.apache.cassandra.net.AsyncChannelOutputPlus.propagateFailedFlush(AsyncChannelOutputPlus.java:200)
>at
> org.apache.cassandra.net.AsyncChannelOutputPlus.waitUntilFlushed(AsyncChannelOutputPlus.java:158)
>at
> org.apache.cassandra.net.AsyncChannelOutputPlus.waitForSpace(AsyncChannelOutputPlus.java:140)
>at
> org.apache.cassandra.net.AsyncChannelOutputPlus.beginFlush(AsyncChannelOutputPlus.java:97)
>at
> org.apache.cassandra.net.AsyncStreamingOutputPlus.lambda$writeToChannel$0(AsyncStreamingOutputPlus.java:142)
>at
> org.apache.cassandra.db.streaming.CassandraCompressedStreamWriter.lambda$write$0(CassandraCompressedStreamWriter.java:90)
>at
> org.apache.cassandra.net.AsyncStreamingOutputPlus.writeToChannel(AsyncStreamingOutputPlus.java:138)
>at
> org.apache.cassandra.db.streaming.CassandraCompressedStreamWriter.write(CassandraCompressedStreamWriter.java:89)
>at
> org.apache.cassandra.db.streaming.CassandraOutgoingFile.write(CassandraOutgoingFile.java:180)
>at
> org.apache.cassandra.streaming.messages.OutgoingStreamMessage.serialize(OutgoingStreamMessage.java:87)
>at
> org.apache.cassandra.streaming.messages.OutgoingStreamMessage$1.serialize(OutgoingStreamMessage.java:45)
>at
> org.apache.cassandra.streaming.messages.OutgoingStreamMessage$1.serialize(OutgoingStreamMessage.java:34)
>at
> org.apache.cassandra.streaming.messages.StreamMessage.serialize(StreamMessage.java:40)
>at
> org.apache.cassandra.streaming.async.NettyStreamingMessageSender$FileStreamTask.run(NettyStreamingMessageSender.java:347)
>at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
>at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
>at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> [?:?]
>at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> [?:?]
>at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> [netty-all-4.1.50.Final.jar:4.1.50.Final]
>at java.lang.Thread.run(Thread.java:834) [?:?]
>Suppressed: java.nio.channels.ClosedChannelException
>at
> org.apache.cassandra.net.AsyncStreamingOutputPlus.doFlush(AsyncStreamingOutputPlus.java:78)
>at
> org.apache.cassandra.net.AsyncChannelOutputPlus.flush(AsyncChannelOutputPlus.java:229)
>at
> org.apache.cassandra.net.AsyncChannelOutputPlus.close(AsyncChannelOutputPlus.java:248)
>at
> org.apache.cassandra.streaming.async.NettyStreamingMessageSender$FileStreamTask.run(NettyStreamingMessageSender.java:348)
>at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
>at java.util.concurrent.FutureTask.run(FutureTask.java:264)
> [?:?]
>at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> [?:?]
>at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> [?:?]
>
[jira] [Assigned] (CASSANDRA-16296) Join new node to cluster failing on C* version 4
[
https://issues.apache.org/jira/browse/CASSANDRA-16296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer reassigned CASSANDRA-16296:
--
Assignee: Benjamin Lerer
> Join new node to cluster failing on C* version 4
>
>
> Key: CASSANDRA-16296
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16296
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Yakir Gibraltar
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Hi, i'm using cassandra 4.0-beta3,
> Join new node failing,
> Current status:
> {code}
> [root@rc801 ~]# nodetool status
> Datacenter: V4CH
>
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> -- Address LoadTokens Owns (effective) Host ID
>Rack
> UN 1.1.1.1 356.55 KiB 128 ?
> 92ae4c39-edb3-4e67-8623-b49fd8301b66 RAC1
> UN 2.2.2.2 424.36 KiB 128 ?
> d80647a8-32b2-4a8f-8022-f5ae3ce8fbb2 RAC1
> Datacenter: V4NJ
>
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> -- Address LoadTokens Owns (effective) Host ID
>Rack
> UN 3.3.3.3 322.97 KiB 128 ?
> 0106ce0b-18be-4321-8247-843076ff42e6 RAC1
> UN 4.4.4.4 297.6 KiB 128 ?
> d81e2b7d-9221-4b1b-86c8-e8956e3eec07 RAC1
> UN 5.5.5.5 324.75 KiB 128 ?
> 5dfbaf14-8310-4d64-b61a-9da0a7a8a620 RAC1
> {code}
> Error on new host (7.7.7.7):
> {code}
> INFO [main] 2020-11-22 09:27:36,592 RangeStreamer.java:323 - Bootstrap:
> range Full(/7.7.7.7:7000,(-7734271291904743823,-7725025391901227341]) exists
> on Full(/1.1.1.1:7000,(-7734271291904743823,-7725025391901227341]) for
> keyspace system_traces
> ERROR [main] 2020-11-22 09:27:36,609 CassandraDaemon.java:817 - Exception
> encountered during startup
> java.lang.IllegalStateException: Multiple strict sources found for
> Full(/7.7.7.7:7000,(9208454697546654053,-9212763148842799409]), sources:
> [Full(/2.2.2.2:7000,(9189373804905478622,-9212763148842799409]),
> Full(/1.1.1.1:7000,(9189373804905478622,-9212763148842799409])]
> at
> org.apache.cassandra.dht.RangeStreamer.calculateRangesToFetchWithPreferredEndpoints(RangeStreamer.java:517)
> at
> org.apache.cassandra.dht.RangeStreamer.calculateRangesToFetchWithPreferredEndpoints(RangeStreamer.java:383)
> at
> org.apache.cassandra.dht.RangeStreamer.addRanges(RangeStreamer.java:320)
> at
> org.apache.cassandra.dht.BootStrapper.bootstrap(BootStrapper.java:81)
> at
> org.apache.cassandra.service.StorageService.startBootstrap(StorageService.java:1635)
> at
> org.apache.cassandra.service.StorageService.bootstrap(StorageService.java:1612)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:931)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:892)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:699)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:635)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:407)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> INFO [StorageServiceShutdownHook] 2020-11-22 09:27:36,616
> HintsService.java:220 - Paused hints dispatch
> WARN [StorageServiceShutdownHook] 2020-11-22 09:27:36,617 Gossiper.java:1849
> - No local state, state is in silent shutdown, or node hasn't joined, not
> announcing shutdown
> INFO [StorageServiceShutdownHook] 2020-11-22 09:27:36,617
> MessagingService.java:441 - Waiting for messaging service to quiesce
> {code}
> Errors on seed node:
> {code}
> INFO [Messaging-EventLoop-3-37] 2020-11-22 09:26:54,121
> InboundConnectionInitiator.java:459 -
> /7.7.7.7:7000(/7.7.7.7:45490)->/1.1.1.1:7000-URGENT_MESSAGES-f412b9ba
> messaging connection established, version = 12, framing = LZ4, encryption =
> disabled
> INFO [Messaging-EventLoop-3-40] 2020-11-22 09:26:54,157
> OutboundConnection.java:1151 -
> /1.1.1.1:7000(/1.1.1.1:38678)->/7.7.7.7:7000-URGENT_MESSAGES-3b23f639
> successfully connected, version = 12, framing = LZ4, encryption = disabled
> INFO [GossipStage:1] 2020-11-22 09:26:56,109 Gossiper.java:1248 - Node
> /7.7.7.7:7000 is now part of the cluster
> INFO [GossipStage:1] 2020-11-22 09:26:56,147 Gossiper.java:1206 -
> InetAddress /7.7.7.7:7000 is now UP
> INFO [Messaging-EventLoop-3-1] 2020-11-22 09:26:57,378
[jira] [Assigned] (CASSANDRA-15134) SASI index files not included in snapshots
[
https://issues.apache.org/jira/browse/CASSANDRA-15134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic reassigned CASSANDRA-15134:
-
Assignee: Stefan Miklosovic (was: Vincent White)
> SASI index files not included in snapshots
> --
>
> Key: CASSANDRA-15134
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15134
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SASI
>Reporter: Vincent White
>Assignee: Stefan Miklosovic
>Priority: Normal
>
> Newly written SASI index files are not being included in snapshots. This is
> because the SASI index files are not added to the components
> ({{org.apache.cassandra.io.sstable.SSTable#components}}) list of newly
> written sstables.
> Although I don't believe anything except snapshots ever tries to reference
> the SASI index files from this location, on startup Cassandra does add the
> SASI index files (if they are found on disk) of existing sstables in their
> components list. In that case sstables that existed on startup with SASI
> index files will have their SASI index files included in any snapshots.
>
> This patch updates the components list of newly written sstable once the
> index is built.
> ||3.11||Trunk||
> |[PoC|https://github.com/vincewhite/cassandra/commit/a641298ad03250d3e4c195e05a93aad56dff8ca7]|[PoC|https://github.com/vincewhite/cassandra/commit/1cfe46688380838e7106f14446658988cfe68137]|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242165#comment-17242165
]
Michael Semb Wever edited comment on CASSANDRA-16205 at 12/2/20, 8:50 AM:
--
Finalised patch is available here:
https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_16205
CI run for it is here:
https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/239/pipeline
was (Author: michaelsembwever):
Finalised patch is available here:
https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_16205
CI run for it is here:
https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/238/pipeline
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242165#comment-17242165
]
Michael Semb Wever commented on CASSANDRA-16205:
Finalised patch is available here:
https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_16205
CI run for it is here:
https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/238/pipeline
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16296) Join new node to cluster failing on C* version 4
[
https://issues.apache.org/jira/browse/CASSANDRA-16296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16296:
---
Resolution: (was: Not A Problem)
Status: Open (was: Resolved)
> Join new node to cluster failing on C* version 4
>
>
> Key: CASSANDRA-16296
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16296
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Yakir Gibraltar
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Hi, i'm using cassandra 4.0-beta3,
> Join new node failing,
> Current status:
> {code}
> [root@rc801 ~]# nodetool status
> Datacenter: V4CH
>
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> -- Address LoadTokens Owns (effective) Host ID
>Rack
> UN 1.1.1.1 356.55 KiB 128 ?
> 92ae4c39-edb3-4e67-8623-b49fd8301b66 RAC1
> UN 2.2.2.2 424.36 KiB 128 ?
> d80647a8-32b2-4a8f-8022-f5ae3ce8fbb2 RAC1
> Datacenter: V4NJ
>
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> -- Address LoadTokens Owns (effective) Host ID
>Rack
> UN 3.3.3.3 322.97 KiB 128 ?
> 0106ce0b-18be-4321-8247-843076ff42e6 RAC1
> UN 4.4.4.4 297.6 KiB 128 ?
> d81e2b7d-9221-4b1b-86c8-e8956e3eec07 RAC1
> UN 5.5.5.5 324.75 KiB 128 ?
> 5dfbaf14-8310-4d64-b61a-9da0a7a8a620 RAC1
> {code}
> Error on new host (7.7.7.7):
> {code}
> INFO [main] 2020-11-22 09:27:36,592 RangeStreamer.java:323 - Bootstrap:
> range Full(/7.7.7.7:7000,(-7734271291904743823,-7725025391901227341]) exists
> on Full(/1.1.1.1:7000,(-7734271291904743823,-7725025391901227341]) for
> keyspace system_traces
> ERROR [main] 2020-11-22 09:27:36,609 CassandraDaemon.java:817 - Exception
> encountered during startup
> java.lang.IllegalStateException: Multiple strict sources found for
> Full(/7.7.7.7:7000,(9208454697546654053,-9212763148842799409]), sources:
> [Full(/2.2.2.2:7000,(9189373804905478622,-9212763148842799409]),
> Full(/1.1.1.1:7000,(9189373804905478622,-9212763148842799409])]
> at
> org.apache.cassandra.dht.RangeStreamer.calculateRangesToFetchWithPreferredEndpoints(RangeStreamer.java:517)
> at
> org.apache.cassandra.dht.RangeStreamer.calculateRangesToFetchWithPreferredEndpoints(RangeStreamer.java:383)
> at
> org.apache.cassandra.dht.RangeStreamer.addRanges(RangeStreamer.java:320)
> at
> org.apache.cassandra.dht.BootStrapper.bootstrap(BootStrapper.java:81)
> at
> org.apache.cassandra.service.StorageService.startBootstrap(StorageService.java:1635)
> at
> org.apache.cassandra.service.StorageService.bootstrap(StorageService.java:1612)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:931)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:892)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:699)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:635)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:407)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> INFO [StorageServiceShutdownHook] 2020-11-22 09:27:36,616
> HintsService.java:220 - Paused hints dispatch
> WARN [StorageServiceShutdownHook] 2020-11-22 09:27:36,617 Gossiper.java:1849
> - No local state, state is in silent shutdown, or node hasn't joined, not
> announcing shutdown
> INFO [StorageServiceShutdownHook] 2020-11-22 09:27:36,617
> MessagingService.java:441 - Waiting for messaging service to quiesce
> {code}
> Errors on seed node:
> {code}
> INFO [Messaging-EventLoop-3-37] 2020-11-22 09:26:54,121
> InboundConnectionInitiator.java:459 -
> /7.7.7.7:7000(/7.7.7.7:45490)->/1.1.1.1:7000-URGENT_MESSAGES-f412b9ba
> messaging connection established, version = 12, framing = LZ4, encryption =
> disabled
> INFO [Messaging-EventLoop-3-40] 2020-11-22 09:26:54,157
> OutboundConnection.java:1151 -
> /1.1.1.1:7000(/1.1.1.1:38678)->/7.7.7.7:7000-URGENT_MESSAGES-3b23f639
> successfully connected, version = 12, framing = LZ4, encryption = disabled
> INFO [GossipStage:1] 2020-11-22 09:26:56,109 Gossiper.java:1248 - Node
> /7.7.7.7:7000 is now part of the cluster
> INFO [GossipStage:1] 2020-11-22 09:26:56,147 Gossiper.java:1206 -
> InetAddress /7.7.7.7:7000 is now UP
> INFO [Messaging-EventLoop-3-1] 2020-11-22
[jira] [Updated] (CASSANDRA-16296) Join new node to cluster failing on C* version 4
[
https://issues.apache.org/jira/browse/CASSANDRA-16296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16296:
---
Resolution: Not A Problem
Status: Resolved (was: Open)
> Join new node to cluster failing on C* version 4
>
>
> Key: CASSANDRA-16296
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16296
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Yakir Gibraltar
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Hi, i'm using cassandra 4.0-beta3,
> Join new node failing,
> Current status:
> {code}
> [root@rc801 ~]# nodetool status
> Datacenter: V4CH
>
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> -- Address LoadTokens Owns (effective) Host ID
>Rack
> UN 1.1.1.1 356.55 KiB 128 ?
> 92ae4c39-edb3-4e67-8623-b49fd8301b66 RAC1
> UN 2.2.2.2 424.36 KiB 128 ?
> d80647a8-32b2-4a8f-8022-f5ae3ce8fbb2 RAC1
> Datacenter: V4NJ
>
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> -- Address LoadTokens Owns (effective) Host ID
>Rack
> UN 3.3.3.3 322.97 KiB 128 ?
> 0106ce0b-18be-4321-8247-843076ff42e6 RAC1
> UN 4.4.4.4 297.6 KiB 128 ?
> d81e2b7d-9221-4b1b-86c8-e8956e3eec07 RAC1
> UN 5.5.5.5 324.75 KiB 128 ?
> 5dfbaf14-8310-4d64-b61a-9da0a7a8a620 RAC1
> {code}
> Error on new host (7.7.7.7):
> {code}
> INFO [main] 2020-11-22 09:27:36,592 RangeStreamer.java:323 - Bootstrap:
> range Full(/7.7.7.7:7000,(-7734271291904743823,-7725025391901227341]) exists
> on Full(/1.1.1.1:7000,(-7734271291904743823,-7725025391901227341]) for
> keyspace system_traces
> ERROR [main] 2020-11-22 09:27:36,609 CassandraDaemon.java:817 - Exception
> encountered during startup
> java.lang.IllegalStateException: Multiple strict sources found for
> Full(/7.7.7.7:7000,(9208454697546654053,-9212763148842799409]), sources:
> [Full(/2.2.2.2:7000,(9189373804905478622,-9212763148842799409]),
> Full(/1.1.1.1:7000,(9189373804905478622,-9212763148842799409])]
> at
> org.apache.cassandra.dht.RangeStreamer.calculateRangesToFetchWithPreferredEndpoints(RangeStreamer.java:517)
> at
> org.apache.cassandra.dht.RangeStreamer.calculateRangesToFetchWithPreferredEndpoints(RangeStreamer.java:383)
> at
> org.apache.cassandra.dht.RangeStreamer.addRanges(RangeStreamer.java:320)
> at
> org.apache.cassandra.dht.BootStrapper.bootstrap(BootStrapper.java:81)
> at
> org.apache.cassandra.service.StorageService.startBootstrap(StorageService.java:1635)
> at
> org.apache.cassandra.service.StorageService.bootstrap(StorageService.java:1612)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:931)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:892)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:699)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:635)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:407)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> INFO [StorageServiceShutdownHook] 2020-11-22 09:27:36,616
> HintsService.java:220 - Paused hints dispatch
> WARN [StorageServiceShutdownHook] 2020-11-22 09:27:36,617 Gossiper.java:1849
> - No local state, state is in silent shutdown, or node hasn't joined, not
> announcing shutdown
> INFO [StorageServiceShutdownHook] 2020-11-22 09:27:36,617
> MessagingService.java:441 - Waiting for messaging service to quiesce
> {code}
> Errors on seed node:
> {code}
> INFO [Messaging-EventLoop-3-37] 2020-11-22 09:26:54,121
> InboundConnectionInitiator.java:459 -
> /7.7.7.7:7000(/7.7.7.7:45490)->/1.1.1.1:7000-URGENT_MESSAGES-f412b9ba
> messaging connection established, version = 12, framing = LZ4, encryption =
> disabled
> INFO [Messaging-EventLoop-3-40] 2020-11-22 09:26:54,157
> OutboundConnection.java:1151 -
> /1.1.1.1:7000(/1.1.1.1:38678)->/7.7.7.7:7000-URGENT_MESSAGES-3b23f639
> successfully connected, version = 12, framing = LZ4, encryption = disabled
> INFO [GossipStage:1] 2020-11-22 09:26:56,109 Gossiper.java:1248 - Node
> /7.7.7.7:7000 is now part of the cluster
> INFO [GossipStage:1] 2020-11-22 09:26:56,147 Gossiper.java:1206 -
> InetAddress /7.7.7.7:7000 is now UP
> INFO [Messaging-EventLoop-3-1] 2020-11-22 09:26:57,378
>
