[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381002#comment-17381002
]
Berenguer Blasi commented on CASSANDRA-16621:
-
{quote}spinAssertEquals when possible, and reserve the direct call to
Awaitility for those cases in which more flexibility is required?{quote}
+1. I wouldn't replace all spinAssert calls just it's implementation to use
Awaitility. And you can call that one directly when needed
{quote}I wonder whether it would be too low{quote}
A thread.yield is probably less that that. But moving to 100ms would might even
make more sense to avoid spinning the CPU on yields. I wonder what Awaitility
does under the covers though..
> Replace spinAsserts code with Awaitility code
> -
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14570) Improper default value of cdc_total_space_in_mb
[ https://issues.apache.org/jira/browse/CASSANDRA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie reassigned CASSANDRA-14570: - Assignee: Shichao An (was: Josh McKenzie) > Improper default value of cdc_total_space_in_mb > --- > > Key: CASSANDRA-14570 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14570 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Shichao An >Assignee: Shichao An >Priority: Low > Labels: CDC > > The code for calculating cdc_total_space_in_mb in DatabaseDescriptor.java > does not reflect the latest architecture introduced by CASSANDRA-12148. > In short, cdc_total_space_in_mb should be equal or greater than > commitlog_total_space_in_mb; otherwise, the writes will fail when on-disk > commit logs size reaches the value of cdc_total_space_in_mb. For example, If > cdc_total_space_in_mb is 4096 and commitlog_total_space_in_mb is 8192, when > we enabled the cdc_enabled flag (even if we didn't enable cdc=true on any > table), when total size of commit logs reaches 4096 MB, there is the same of > amount of hard links in cdc_raw directory, that is, 4096 MB of cdc logs. > Then, if a table has cdc=true, the writes will fail in that table because the > CommitLogSegmentManagerCDC will be unable to process new CDC segments. (See > allocate and processNewSegment in CommitLogSegmentManagerCDC class) > > I will attach patches later. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16799) Add an upgrade test with multi-dc writes
[ https://issues.apache.org/jira/browse/CASSANDRA-16799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-16799: Assignee: Brandon Williams > Add an upgrade test with multi-dc writes > > > Key: CASSANDRA-16799 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16799 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0.x > > > This is to prevent regressions of CASSANDRA-16797 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break
[ https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380869#comment-17380869 ] Sumanth Pasupuleti commented on CASSANDRA-16467: Updated PRs (after rebase) *3.0.x* [Patch|https://github.com/apache/cassandra/compare/cassandra-3.0...sumanth-pasupuleti:bugfix/30_speculative_retry_params_case] UTs and Dtests passing except for three DTests that seem unrelated to me (test_sstableverify, test_simple_rebuild and test_closing_connections) [Circle CI run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/79/workflows/b6f2cd11-d08d-46ef-acf8-6fd0ccf0d61e] 3.11.x [Patch|https://github.com/apache/cassandra/compare/cassandra-3.11...sumanth-pasupuleti:bugfix/311_speculative_retry_params_case] UTs and Dtests passing except for three DTests that seem unrelated to me (test_sstableverify, test_view_metadata_cleanup and test_closing_connections) [Circle CI run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/81/workflows/6c45519e-1120-4fa5-8a72-3e465a5467cb] > speculative retry should allow more friendly params, allowing upgrade from > 2.x not to break > --- > > Key: CASSANDRA-16467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16467 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have > added case sensitivity. As as result of this, one of our internal > applications suffered an issue during > C* upgrade from 2.x to 3.0. > This ticket is to propose making 3.0 and 3.11 speculative_retry params case > insensitive as well (essentially a slightly modified backport of > CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break
[ https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380869#comment-17380869 ] Sumanth Pasupuleti edited comment on CASSANDRA-16467 at 7/14/21, 9:18 PM: -- Updated PRs (after rebase) 3.0.x [Patch|https://github.com/apache/cassandra/compare/cassandra-3.0...sumanth-pasupuleti:bugfix/30_speculative_retry_params_case] UTs and Dtests passing except for three DTests that seem unrelated to me (test_sstableverify, test_simple_rebuild and test_closing_connections) [Circle CI run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/79/workflows/b6f2cd11-d08d-46ef-acf8-6fd0ccf0d61e] 3.11.x [Patch|https://github.com/apache/cassandra/compare/cassandra-3.11...sumanth-pasupuleti:bugfix/311_speculative_retry_params_case] UTs and Dtests passing except for three DTests that seem unrelated to me (test_sstableverify, test_view_metadata_cleanup and test_closing_connections) [Circle CI run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/81/workflows/6c45519e-1120-4fa5-8a72-3e465a5467cb] was (Author: sumanth.pasupuleti): Updated PRs (after rebase) *3.0.x* [Patch|https://github.com/apache/cassandra/compare/cassandra-3.0...sumanth-pasupuleti:bugfix/30_speculative_retry_params_case] UTs and Dtests passing except for three DTests that seem unrelated to me (test_sstableverify, test_simple_rebuild and test_closing_connections) [Circle CI run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/79/workflows/b6f2cd11-d08d-46ef-acf8-6fd0ccf0d61e] 3.11.x [Patch|https://github.com/apache/cassandra/compare/cassandra-3.11...sumanth-pasupuleti:bugfix/311_speculative_retry_params_case] UTs and Dtests passing except for three DTests that seem unrelated to me (test_sstableverify, test_view_metadata_cleanup and test_closing_connections) [Circle CI run|https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/81/workflows/6c45519e-1120-4fa5-8a72-3e465a5467cb] > speculative retry should allow more friendly params, allowing upgrade from > 2.x not to break > --- > > Key: CASSANDRA-16467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16467 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have > added case sensitivity. As as result of this, one of our internal > applications suffered an issue during > C* upgrade from 2.x to 3.0. > This ticket is to propose making 3.0 and 3.11 speculative_retry params case > insensitive as well (essentially a slightly modified backport of > CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14906) FastByteOperations.UnsafeOperations fails to handle read only byte buffers correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Sorokoumov updated CASSANDRA-14906: - Status: Open (was: Patch Available) > FastByteOperations.UnsafeOperations fails to handle read only byte buffers > correctly > > > Key: CASSANDRA-14906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14906 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Aleksandr Sorokoumov >Assignee: Aleksandr Sorokoumov >Priority: Low > Fix For: 4.x > > Attachments: 14906-dtest.png, 14906-testall.png > > > If a buffer is read only it reports having no array, though it may well be > backed by an array. Code in UnsafeOperation works under the impression that a > buffer for which hasArray() == false is necessarily a direct buffer. Which is > not the case. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16736) CQL shell should prefer newer TLS version by default
[ https://issues.apache.org/jira/browse/CASSANDRA-16736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16736: Description: This is a follow up to CASSANDRA-16695 where a patch was committed to 3.0, 3.11, 4.0 and trunk. As part of it we saw that CQL shell python DTests are failing due to config issues for version 2.2. As part of the current ticket we need to produce a fix to be able to run the CQL shell tests and verify and apply the patch from CASSANDRA-16695 to Cassandra 2.2 was: This is a follow up to CASSANDRA-16695 where a patch was committed to 3.0, 3.11, 4.0 and trunk. As part of it we saw that CQL shell python DTests are failing due to config issues for version 2.2. As part of this ticket we need to produce a fix to be able to run the CQL shell tests and verify and apply the patch from CASSANDRA-16695 to Cassandra 2.2 > CQL shell should prefer newer TLS version by default > > > Key: CASSANDRA-16736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16736 > Project: Cassandra > Issue Type: Improvement > Components: Tool/cqlsh >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 2.2.x > > > This is a follow up to CASSANDRA-16695 where a patch was committed to 3.0, > 3.11, 4.0 and trunk. > As part of it we saw that CQL shell python DTests are failing due to config > issues for version 2.2. > As part of the current ticket we need to produce a fix to be able to run the > CQL shell tests and verify and apply the patch from CASSANDRA-16695 to > Cassandra 2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16736) CQL shell should prefer newer TLS version by default
[ https://issues.apache.org/jira/browse/CASSANDRA-16736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16736: Description: This is a follow up to CASSANDRA-16695 where a patch was committed to 3.0, 3.11, 4.0 and trunk. As part of it we saw that CQL shell python DTests are failing due to config issues for version 2.2. As part of this ticket we need to produce a fix to be able to run the CQL shell tests and verify and apply the patch from CASSANDRA-16695 to Cassandra 2.2 was: This is a follow up to CASSANDRA-16695 where a patch was committed to 3.0, 3.11, 4.0 and trunk. As part of it we saw that CQL shell python DTests are failing dues to config issues for version 2.2. As part of this ticket we need to produce a fix to be able to run the CQL shell tests and verify and apply the patch from CASSANDRA-16695 to Cassandra 2.2 > CQL shell should prefer newer TLS version by default > > > Key: CASSANDRA-16736 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16736 > Project: Cassandra > Issue Type: Improvement > Components: Tool/cqlsh >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 2.2.x > > > This is a follow up to CASSANDRA-16695 where a patch was committed to 3.0, > 3.11, 4.0 and trunk. > As part of it we saw that CQL shell python DTests are failing due to config > issues for version 2.2. > As part of this ticket we need to produce a fix to be able to run the CQL > shell tests and verify and apply the patch from CASSANDRA-16695 to Cassandra > 2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break
[ https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380855#comment-17380855 ] Sumanth Pasupuleti commented on CASSANDRA-16467: Thanks for the review [~azotcsit], [~maedhroz] and [~e.dimitrova]. I have rebased; CI runs are in progress - will update the ticket once the runs complete. > speculative retry should allow more friendly params, allowing upgrade from > 2.x not to break > --- > > Key: CASSANDRA-16467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16467 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have > added case sensitivity. As as result of this, one of our internal > applications suffered an issue during > C* upgrade from 2.x to 3.0. > This ticket is to propose making 3.0 and 3.11 speculative_retry params case > insensitive as well (essentially a slightly modified backport of > CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break
[ https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380853#comment-17380853 ] Caleb Rackliffe commented on CASSANDRA-16467: - bq. do you mind to rebase and submit new CI run? [~sumanth.pasupuleti] I'll commit as soon as this is done. Thanks again! > speculative retry should allow more friendly params, allowing upgrade from > 2.x not to break > --- > > Key: CASSANDRA-16467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16467 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have > added case sensitivity. As as result of this, one of our internal > applications suffered an issue during > C* upgrade from 2.x to 3.0. > This ticket is to propose making 3.0 and 3.11 speculative_retry params case > insensitive as well (essentially a slightly modified backport of > CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13464) Failed to create Materialized view with a specific token range
[
https://issues.apache.org/jira/browse/CASSANDRA-13464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380825#comment-17380825
]
Brandon Williams commented on CASSANDRA-13464:
--
This looks good to me. [~blerer] or [~jasonstack] how do this look to you?
> Failed to create Materialized view with a specific token range
> --
>
> Key: CASSANDRA-13464
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13464
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Materialized Views
>Reporter: Natsumi Kojima
>Assignee: Krishna Dattu Koneru
>Priority: Low
> Labels: materializedviews
>
> Failed to create Materialized view with a specific token range.
> Example :
> {code:java}
> $ ccm create "MaterializedView" -v 3.0.13
> $ ccm populate -n 3
> $ ccm start
> $ ccm status
> Cluster: 'MaterializedView'
> ---
> node1: UP
> node3: UP
> node2: UP
> $ccm node1 cqlsh
> Connected to MaterializedView at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 3.0.13 | CQL spec 3.4.0 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE test WITH replication = {'class':'SimpleStrategy',
> 'replication_factor':3};
> cqlsh> CREATE TABLE test.test ( id text PRIMARY KEY , value1 text , value2
> text, value3 text);
> $ccm node1 ring test
> Datacenter: datacenter1
> ==
> AddressRackStatus State LoadOwns
> Token
>
> 3074457345618258602
> 127.0.0.1 rack1 Up Normal 64.86 KB100.00%
> -9223372036854775808
> 127.0.0.2 rack1 Up Normal 86.49 KB100.00%
> -3074457345618258603
> 127.0.0.3 rack1 Up Normal 89.04 KB100.00%
> 3074457345618258602
> $ ccm node1 cqlsh
> cqlsh> INSERT INTO test.test (id, value1 , value2, value3 ) VALUES ('aaa',
> 'aaa', 'aaa' ,'aaa');
> cqlsh> INSERT INTO test.test (id, value1 , value2, value3 ) VALUES ('bbb',
> 'bbb', 'bbb' ,'bbb');
> cqlsh> SELECT token(id),id,value1 FROM test.test;
> system.token(id) | id | value1
> --+-+
> -4737872923231490581 | aaa |aaa
> -3071845237020185195 | bbb |bbb
> (2 rows)
> cqlsh> CREATE MATERIALIZED VIEW test.test_view AS SELECT value1, id FROM
> test.test WHERE id IS NOT NULL AND value1 IS NOT NULL AND TOKEN(id) >
> -9223372036854775808 AND TOKEN(id) < -3074457345618258603 PRIMARY KEY(value1,
> id) WITH CLUSTERING ORDER BY (id ASC);
> ServerError: java.lang.ClassCastException:
> org.apache.cassandra.cql3.TokenRelation cannot be cast to
> org.apache.cassandra.cql3.SingleColumnRelation
> {code}
> Stacktrace :
> {code:java}
> INFO [MigrationStage:1] 2017-04-19 18:32:48,131 ColumnFamilyStore.java:389 -
> Initializing test.test
> WARN [SharedPool-Worker-1] 2017-04-19 18:44:07,263 FBUtilities.java:337 -
> Trigger directory doesn't exist, please create it and try again.
> ERROR [SharedPool-Worker-1] 2017-04-19 18:46:10,072 QueryMessage.java:128 -
> Unexpected error during query
> java.lang.ClassCastException: org.apache.cassandra.cql3.TokenRelation cannot
> be cast to org.apache.cassandra.cql3.SingleColumnRelation
> at
> org.apache.cassandra.db.view.View.relationsToWhereClause(View.java:275)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.statements.CreateViewStatement.announceMigration(CreateViewStatement.java:219)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.statements.SchemaAlteringStatement.execute(SchemaAlteringStatement.java:93)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:206)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:237)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:222)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:115)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:513)
> [apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:407)
> [apache-cassandra-3.0.13.jar:3.0.13]
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357)
>
[jira] [Commented] (CASSANDRA-16761) New Cassandra Website and Documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380803#comment-17380803 ] Michael Semb Wever commented on CASSANDRA-16761: Site review happening on cassandra.staged.apache.org being collected in https://docs.google.com/document/d/17IKnHKB_3kUV96EjZe6TWtInMfsMBdF2pyLSQTdSFpI/edit# > New Cassandra Website and Documentation > --- > > Key: CASSANDRA-16761 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16761 > Project: Cassandra > Issue Type: Epic > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Anthony Grasso >Priority: High > Fix For: 4.0.x > > > This epic captures the work associated with the development of the new > Cassandra website and documentation. > Work to create the new website and documentation will be broken up as follows: > * Proof of concept - CASSANDRA-16029 > * Website concept and design - CASSANDRA-16115 > * Develop tooling to render new website and documentation - CASSANDRA-16066 > * Create website content that will be rendered by new tooling - > CASSANDRA-16762 > * Create Cassandra documentation content that will be rendered by new > tooling - CASSANDRA-16763 > It is expected that the new website and documentation will be in asciidoc > format and rendered using Antora. > Antora is purpose built for rendering versioned documentation to HTML. In > addition it allows rendering customisations via Java Script which may be > useful when rending the website. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16761) New Cassandra Website and Documentation
[
https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380763#comment-17380763
]
Michael Semb Wever edited comment on CASSANDRA-16761 at 7/14/21, 5:38 PM:
--
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
{code}
was (Author: michaelsembwever):
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
{code}
> New Cassandra Website and Documentation
> ---
>
> Key: CASSANDRA-16761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16761
> Project: Cassandra
> Issue Type: Epic
> Components: Documentation/Website
>Reporter: Anthony Grasso
>Assignee: Anthony Grasso
>Priority: High
> Fix For: 4.0.x
>
>
> This epic captures the work associated with the development of the new
> Cassandra website and documentation.
> Work to create the new website and documentation will be broken up as follows:
> * Proof of concept - CASSANDRA-16029
> * Website concept and design - CASSANDRA-16115
> * Develop tooling to render new website and documentation - CASSANDRA-16066
> * Create website content that will be rendered by new tooling -
> CASSANDRA-16762
> * Create Cassandra documentation content that will be rendered by new
> tooling - CASSANDRA-16763
> It is expected that the new website and documentation will be in asciidoc
> format and rendered using Antora.
> Antora is purpose built for rendering versioned documentation to HTML. In
> addition it allows rendering customisations via Java Script which may be
> useful when rending the website.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16761) New Cassandra Website and Documentation
[
https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380763#comment-17380763
]
Michael Semb Wever edited comment on CASSANDRA-16761 at 7/14/21, 5:37 PM:
--
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
{code}
was (Author: michaelsembwever):
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
{code}
> New Cassandra Website and Documentation
> ---
>
> Key: CASSANDRA-16761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16761
> Project: Cassandra
> Issue Type: Epic
> Components: Documentation/Website
>Reporter: Anthony Grasso
>Assignee: Anthony Grasso
>Priority: High
> Fix For: 4.0.x
>
>
> This epic captures the work associated with the development of the new
> Cassandra website and documentation.
> Work to create the new website and documentation will be broken up as follows:
> * Proof of concept - CASSANDRA-16029
> * Website concept and design - CASSANDRA-16115
> * Develop tooling to render new website and documentation - CASSANDRA-16066
> * Create website content that will be rendered by new tooling -
> CASSANDRA-16762
> * Create Cassandra documentation content that will be rendered by new
> tooling - CASSANDRA-16763
> It is expected that the new website and documentation will be in asciidoc
> format and rendered using Antora.
> Antora is purpose built for rendering versioned documentation to HTML. In
> addition it allows rendering customisations via Java Script which may be
> useful when rending the website.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16761) New Cassandra Website and Documentation
[
https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380763#comment-17380763
]
Michael Semb Wever edited comment on CASSANDRA-16761 at 7/14/21, 5:36 PM:
--
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
{code}
was (Author: michaelsembwever):
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
> New Cassandra Website and Documentation
> ---
>
> Key: CASSANDRA-16761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16761
> Project: Cassandra
> Issue Type: Epic
> Components: Documentation/Website
>Reporter: Anthony Grasso
>Assignee: Anthony Grasso
>Priority: High
> Fix For: 4.0.x
>
>
> This epic captures the work associated with the development of the new
> Cassandra website and documentation.
> Work to create the new website and documentation will be broken up as follows:
> * Proof of concept - CASSANDRA-16029
> * Website concept and design - CASSANDRA-16115
> * Develop tooling to render new website and documentation - CASSANDRA-16066
> * Create website content that will be rendered by new tooling -
> CASSANDRA-16762
> * Create Cassandra documentation content that will be rendered by new
> tooling - CASSANDRA-16763
> It is expected that the new website and documentation will be in asciidoc
> format and rendered using Antora.
> Antora is purpose built for rendering versioned documentation to HTML. In
> addition it allows rendering customisations via Java Script which may be
> useful when rending the website.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16761) New Cassandra Website and Documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380763#comment-17380763 ] Michael Semb Wever commented on CASSANDRA-16761: the antora built version of the new website design is on staging: https://cassandra.staged.apache.org/ > New Cassandra Website and Documentation > --- > > Key: CASSANDRA-16761 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16761 > Project: Cassandra > Issue Type: Epic > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Anthony Grasso >Priority: High > Fix For: 4.0.x > > > This epic captures the work associated with the development of the new > Cassandra website and documentation. > Work to create the new website and documentation will be broken up as follows: > * Proof of concept - CASSANDRA-16029 > * Website concept and design - CASSANDRA-16115 > * Develop tooling to render new website and documentation - CASSANDRA-16066 > * Create website content that will be rendered by new tooling - > CASSANDRA-16762 > * Create Cassandra documentation content that will be rendered by new > tooling - CASSANDRA-16763 > It is expected that the new website and documentation will be in asciidoc > format and rendered using Antora. > Antora is purpose built for rendering versioned documentation to HTML. In > addition it allows rendering customisations via Java Script which may be > useful when rending the website. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (36b91d8 -> efa16fb)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git. discard 36b91d8 fix .htaccess (don't redirect /doc/latest/ ) new efa16fb fix .htaccess don't redirect /doc/latest/ and /_/ redirects This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (36b91d8) \ N -- N -- N refs/heads/asf-staging (efa16fb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/.htaccess | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] 01/01: fix .htaccess don't redirect /doc/latest/ and /_/ redirects
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git
commit efa16fb00fbb1b457dbb52d591f3d794dd358e56
Author: mck
AuthorDate: Wed Jul 14 18:56:16 2021 +0200
fix .htaccess
don't redirect /doc/latest/
and /_/ redirects
---
content/.htaccess | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/content/.htaccess b/content/.htaccess
index 2417a9a..e3d4c8e 100755
--- a/content/.htaccess
+++ b/content/.htaccess
@@ -3,11 +3,11 @@ RewriteEngine On
RewriteCond %{HTTPS} !=on
RewriteRule ^/?(.*) https://%{SERVER_NAME}/$1 [R,L]
-RedirectMatch 301 "/$" "/_/index.html"
+RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
-RewriteRule ^(.*)/$ /_$1.html [R=301,L]
+RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15141) Faster token ownership calculation for NetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-15141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380748#comment-17380748
]
Brandon Williams commented on CASSANDRA-15141:
--
If there is still interest in this it needs a minor rebase. There's likely
some path from the Gossiper calling getAddressReplicas() that I can't think of
off the top of my head, so this seems reasonable.
> Faster token ownership calculation for NetworkTopologyStrategy
> --
>
> Key: CASSANDRA-15141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15141
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Gossip, Cluster/Membership
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Normal
>
> This function
> [{{getAddressReplicas()}}|https://github.com/apache/cassandra/blob/7df67eff2d66dba4bed2b4f6aeabf05144d9b057/src/java/org/apache/cassandra/service/StorageService.java#L3002]
> during removenode and decommission is slow for large vnode cluster with
> NetworkTopologyStrategy. As it needs to build whole replications map for
> every token range.
> In one of our cluster (> 1k nodes), it takes about 20 seconds for each
> NetworkTopologyStrategy keyspace, so the total time to process a removenode
> message takes at least 80 seconds (20 * 4: 3 system keyspaces, 1 user
> keyspace). It blocks the heartbeat propagation and causes false down node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15141) Faster token ownership calculation for NetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-15141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-15141:
-
Status: Open (was: Patch Available)
> Faster token ownership calculation for NetworkTopologyStrategy
> --
>
> Key: CASSANDRA-15141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15141
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Gossip, Cluster/Membership
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Normal
>
> This function
> [{{getAddressReplicas()}}|https://github.com/apache/cassandra/blob/7df67eff2d66dba4bed2b4f6aeabf05144d9b057/src/java/org/apache/cassandra/service/StorageService.java#L3002]
> during removenode and decommission is slow for large vnode cluster with
> NetworkTopologyStrategy. As it needs to build whole replications map for
> every token range.
> In one of our cluster (> 1k nodes), it takes about 20 seconds for each
> NetworkTopologyStrategy keyspace, so the total time to process a removenode
> message takes at least 80 seconds (20 * 4: 3 system keyspaces, 1 user
> keyspace). It blocks the heartbeat propagation and causes false down node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14570) Improper default value of cdc_total_space_in_mb
[ https://issues.apache.org/jira/browse/CASSANDRA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380747#comment-17380747 ] Josh McKenzie commented on CASSANDRA-14570: --- I believe this is superseded by CASSANDRA-15688. > Improper default value of cdc_total_space_in_mb > --- > > Key: CASSANDRA-14570 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14570 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Shichao An >Assignee: Josh McKenzie >Priority: Low > Labels: CDC > > The code for calculating cdc_total_space_in_mb in DatabaseDescriptor.java > does not reflect the latest architecture introduced by CASSANDRA-12148. > In short, cdc_total_space_in_mb should be equal or greater than > commitlog_total_space_in_mb; otherwise, the writes will fail when on-disk > commit logs size reaches the value of cdc_total_space_in_mb. For example, If > cdc_total_space_in_mb is 4096 and commitlog_total_space_in_mb is 8192, when > we enabled the cdc_enabled flag (even if we didn't enable cdc=true on any > table), when total size of commit logs reaches 4096 MB, there is the same of > amount of hard links in cdc_raw directory, that is, 4096 MB of cdc logs. > Then, if a table has cdc=true, the writes will fail in that table because the > CommitLogSegmentManagerCDC will be unable to process new CDC segments. (See > allocate and processNewSegment in CommitLogSegmentManagerCDC class) > > I will attach patches later. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated: fix .htaccess (don't redirect /doc/latest/ )
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git
The following commit(s) were added to refs/heads/asf-staging by this push:
new 36b91d8 fix .htaccess (don't redirect /doc/latest/ )
36b91d8 is described below
commit 36b91d8c96599c6a6af12a125de93969e99e0c3d
Author: mck
AuthorDate: Wed Jul 14 18:56:16 2021 +0200
fix .htaccess (don't redirect /doc/latest/ )
---
content/.htaccess | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/content/.htaccess b/content/.htaccess
index 2417a9a..380d7a6 100755
--- a/content/.htaccess
+++ b/content/.htaccess
@@ -3,7 +3,7 @@ RewriteEngine On
RewriteCond %{HTTPS} !=on
RewriteRule ^/?(.*) https://%{SERVER_NAME}/$1 [R,L]
-RedirectMatch 301 "/$" "/_/index.html"
+RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14570) Improper default value of cdc_total_space_in_mb
[ https://issues.apache.org/jira/browse/CASSANDRA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie reassigned CASSANDRA-14570: - Assignee: Josh McKenzie (was: Shichao An) > Improper default value of cdc_total_space_in_mb > --- > > Key: CASSANDRA-14570 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14570 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Shichao An >Assignee: Josh McKenzie >Priority: Low > Labels: CDC > > The code for calculating cdc_total_space_in_mb in DatabaseDescriptor.java > does not reflect the latest architecture introduced by CASSANDRA-12148. > In short, cdc_total_space_in_mb should be equal or greater than > commitlog_total_space_in_mb; otherwise, the writes will fail when on-disk > commit logs size reaches the value of cdc_total_space_in_mb. For example, If > cdc_total_space_in_mb is 4096 and commitlog_total_space_in_mb is 8192, when > we enabled the cdc_enabled flag (even if we didn't enable cdc=true on any > table), when total size of commit logs reaches 4096 MB, there is the same of > amount of hard links in cdc_raw directory, that is, 4096 MB of cdc logs. > Then, if a table has cdc=true, the writes will fail in that table because the > CommitLogSegmentManagerCDC will be unable to process new CDC segments. (See > allocate and processNewSegment in CommitLogSegmentManagerCDC class) > > I will attach patches later. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16802) WEBSITE - July 2021 updates
[ https://issues.apache.org/jira/browse/CASSANDRA-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380741#comment-17380741 ] Diogenese Topper commented on CASSANDRA-16802: -- (y) Assets attached > WEBSITE - July 2021 updates > --- > > Key: CASSANDRA-16802 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16802 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: 4.0-rc3, 4.0 > > Attachments: cassandra-updates.zip > > > HTML updates to be made to the website that include: > * Added blog - Apache Cassandra 4.0 is Here, approved by PMC on private > mailing list > * Added card for the new blog to blog index > * Replaced homepage World Party promo with 4.0 announcement and blog link > * Updated homepage community spotlight > * Added Backblaze logo to homepage logos list > * Added missing tag in Apache Cassandra Changelog 8 June 2021 blog and > Cassandra and Kubernetes SIG Update 2 blog > * Added tag and link back to blog index on World Party, Speakers > Announced for April 28 Cassandra 4.0 World Party, and Join Cassandra GSoC > 2021 blogs > * Added cassandra-case-studies directory with the Backblaze case study > * Added Backblaze to case studies index > * Added Backblaze logo to img/companies directory > * Added updates to Ecosystem webpage based on requests received to email sent > to user list/dev lists including: > - Apache Drill to Connectors > - Digitalis to Professional Support > - Nifi to Tools > - Netflix Data Explorer to Tools > - Changed Stratio to Cassandra Lucene Index per request on ML -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16802) WEBSITE - July 2021 updates
[ https://issues.apache.org/jira/browse/CASSANDRA-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-16802: - Attachment: cassandra-updates.zip Description: HTML updates to be made to the website that include: * Added blog - Apache Cassandra 4.0 is Here, approved by PMC on private mailing list * Added card for the new blog to blog index * Replaced homepage World Party promo with 4.0 announcement and blog link * Updated homepage community spotlight * Added Backblaze logo to homepage logos list * Added missing tag in Apache Cassandra Changelog 8 June 2021 blog and Cassandra and Kubernetes SIG Update 2 blog * Added tag and link back to blog index on World Party, Speakers Announced for April 28 Cassandra 4.0 World Party, and Join Cassandra GSoC 2021 blogs * Added cassandra-case-studies directory with the Backblaze case study * Added Backblaze to case studies index * Added Backblaze logo to img/companies directory * Added updates to Ecosystem webpage based on requests received to email sent to user list/dev lists including: - Apache Drill to Connectors - Digitalis to Professional Support - Nifi to Tools - Netflix Data Explorer to Tools - Changed Stratio to Cassandra Lucene Index per request on ML was: HTML updates to be made to the website that include: * Added blog - Apache Cassandra 4.0 is Here, approved by PMC on private mailing list * Added card for the new blog to blog index * Replaced homepage World Party promo with 4.0 announcement and blog link * Updated homepage community spotlight * Added missing tag in Apache Cassandra Changelog 8 June 2021 blog and Cassandra and Kubernetes SIG Update 2 blog * Added tag and link back to blog index on World Party, Speakers Announced for April 28 Cassandra 4.0 World Party, and Join Cassandra GSoC 2021 blogs * Added updates to Ecosystem webpage based on requests received to email sent to user list/dev lists including: - Apache Drill to Connectors - Digitalis to Professional Support - Nifi to Tools - Netflix Data Explorer to Tools - Changed Stratio to Cassandra Lucene Index per request on ML - Added cassandra-case-studies directory with Backblaze case study inside - Added Backblaze to case studies index > WEBSITE - July 2021 updates > --- > > Key: CASSANDRA-16802 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16802 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: 4.0-rc3, 4.0 > > Attachments: cassandra-updates.zip > > > HTML updates to be made to the website that include: > * Added blog - Apache Cassandra 4.0 is Here, approved by PMC on private > mailing list > * Added card for the new blog to blog index > * Replaced homepage World Party promo with 4.0 announcement and blog link > * Updated homepage community spotlight > * Added Backblaze logo to homepage logos list > * Added missing tag in Apache Cassandra Changelog 8 June 2021 blog and > Cassandra and Kubernetes SIG Update 2 blog > * Added tag and link back to blog index on World Party, Speakers > Announced for April 28 Cassandra 4.0 World Party, and Join Cassandra GSoC > 2021 blogs > * Added cassandra-case-studies directory with the Backblaze case study > * Added Backblaze to case studies index > * Added Backblaze logo to img/companies directory > * Added updates to Ecosystem webpage based on requests received to email sent > to user list/dev lists including: > - Apache Drill to Connectors > - Digitalis to Professional Support > - Nifi to Tools > - Netflix Data Explorer to Tools > - Changed Stratio to Cassandra Lucene Index per request on ML -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16104) Wrong warning about data volumes capacity
[
https://issues.apache.org/jira/browse/CASSANDRA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380715#comment-17380715
]
Dmitrii Saprykin commented on CASSANDRA-16104:
--
[~adelapena] Thank you for review and help with request.
I have doubts if it is worth to add extra tests.
* For version 3.0: there is no API for changing concurrent_compactors so test
fetching non default static configuration value should work;
* For version >3.0: it seems we will be testing setConcurrentCompactors which
already exists and tested in CASSANDRA-12248
([https://github.com/DikangGu/cassandra/commit/3a79a027c7db2b8007a8ae4e19002c3edbf63d8e)]
IMHO minimal impact is preferable.
> Wrong warning about data volumes capacity
> -
>
> Key: CASSANDRA-16104
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16104
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Dmitrii Saprykin
>Assignee: Dmitrii Saprykin
>Priority: Normal
>
> I see the following warning trying to run *nodetool upgradesstables*
> {noformat}
> WARN 16:09:24 Only 34988 MB free across all data volumes. Consider adding
> more capacity to your cluster or removing obsolete snapshots
> {noformat}
> This warning is wrong because the wrong storage device capacity gets tested.
> All my cassandra data paths are subdirectories of */data* mount point which
> has enough of space:
> {noformat}
> $ df -h /data
> Filesystem Size Used Avail Mounted on
> . 1.2T 200G 1T /data
> {noformat}
> However what Warning reports is a OS mount which has nothing to do with
> Cassandra configuration:
> {noformat}
> df -h /
> Filesystem Size Used Avail Use% Mounted on
> 40G 5.7G 35G 15% /
> {noformat}
> I see this error running Cassandra 3.0.22
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380702#comment-17380702
]
Andres de la Peña commented on CASSANDRA-16621:
---
This doesn't change that we still have to decide whether to use
{{spinAssertEquals}} or {{Awaitility}}, but it's nice to use the same
implementation for both methods. I guess that the criteria would be using
{{spinAssertEquals}} when possible, and reserve the direct call to
{{Awaitility}} for those cases in which more flexibility is required?
Regarding the poll interval, even though 1ms is probably the most similar thing
to the original implementation, I wonder whether it would be too low. Perhaps
we could use Awaitility's default interval of 100ms and then add an optimistic
poll delay of zero?
> Replace spinAsserts code with Awaitility code
> -
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14608) Confirm correctness of windows scripts post-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-14608: -- Fix Version/s: (was: 4.0.x) 4.0 > Confirm correctness of windows scripts post-9608 > > > Key: CASSANDRA-14608 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14608 > Project: Cassandra > Issue Type: Task > Environment: Windows >Reporter: Jason Brown >Priority: Urgent > Fix For: 4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In CASSANDRA-9608, we chose to defer making all the changes to Windows > scripts. This ticket is to ensure that we do that work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15663) DESCRIBE KEYSPACE does not properly quote table names
[
https://issues.apache.org/jira/browse/CASSANDRA-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-15663:
--
Fix Version/s: (was: 4.0.x)
(was: 3.11.x)
(was: 4.x)
4.0
3.11.11
> DESCRIBE KEYSPACE does not properly quote table names
> -
>
> Key: CASSANDRA-15663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15663
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Syntax
>Reporter: Oskar Liljeblad
>Assignee: Aleksandr Sorokoumov
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.11.11, 4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> How to reproduce (3.11.6) - cqlsh:
> {code}
> CREATE KEYSPACE test1 WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': '1'} AND durable_writes = true;
> CREATE TABLE test1."default" (id text PRIMARY KEY, data text, etag text);
> DESCRIBE KEYSPACE test1;
> {code}
> Output will be:
> {code}
> CREATE TABLE test1.default (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> Output should be:
> {code}
> CREATE TABLE test1."default" (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> If you try to run {{CREATE TABLE test1.default [..]}} you will get an error
> SyntaxException: line 1:19 no viable alternative at input 'default' (CREATE
> TABLE test1.[default]...)
> Oskar Liljeblad
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break
[ https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380680#comment-17380680 ] Ekaterina Dimitrova commented on CASSANDRA-16467: - The change moving from _toUpperCase_ to _toLowerCase_ was done as part of b31845c4a7982358a7c5bfd9bcf572fda6c1bfa9 (CASSANDRA-9712). I didn't find any reason for it, I suspect it was a mistake. About [~azotcsit]'s question around the "99p". I think the reason is that we fix here a bug/regression and that part was new in 4.0 ([~maedhroz] and [~sumanth.pasupuleti], please, correct me if I am wrong). 3.0 and 3.11 are only bug fixes. [~sumanth.pasupuleti], do you mind to rebase and submit new CI run? +1 on green CI, thank you! > speculative retry should allow more friendly params, allowing upgrade from > 2.x not to break > --- > > Key: CASSANDRA-16467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16467 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have > added case sensitivity. As as result of this, one of our internal > applications suffered an issue during > C* upgrade from 2.x to 3.0. > This ticket is to propose making 3.0 and 3.11 speculative_retry params case > insensitive as well (essentially a slightly modified backport of > CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380674#comment-17380674
]
Brandon Williams commented on CASSANDRA-14900:
--
Committed, thank you!
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.25, 3.11.11
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14900:
-
Fix Version/s: (was: 3.11.x)
(was: 3.0.x)
3.11.11
3.0.25
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/3d59557aceaaaedd8eafc4783394330d55a7fb4e
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.25, 3.11.11
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14900:
-
Status: Ready to Commit (was: Review In Progress)
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.x, 3.11.x
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (b7454f7 -> fdc2a4a)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from b7454f7 Merge branch 'cassandra-3.11' into cassandra-4.0 new 3d59557 don't log DigestMismatchException at DEBUG new 00af9a6 Merge branch 'cassandra-3.0' into cassandra-3.11 new fdc2a4a Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit fdc2a4aa6c9314addf136f956d4a6cde4e27be67 Merge: b7454f7 00af9a6 Author: Brandon Williams AuthorDate: Wed Jul 14 10:01:57 2021 -0500 Merge branch 'cassandra-3.11' into cassandra-4.0 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (f08fdcf -> d78d2dd)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from f08fdcf Merge branch 'cassandra-4.0' into trunk new 3d59557 don't log DigestMismatchException at DEBUG new 00af9a6 Merge branch 'cassandra-3.0' into cassandra-3.11 new fdc2a4a Merge branch 'cassandra-3.11' into cassandra-4.0 new d78d2dd Merge branch 'cassandra-4.0' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d78d2ddcb04a982312c2c28960e9b3a23db52b95 Merge: f08fdcf fdc2a4a Author: Brandon Williams AuthorDate: Wed Jul 14 10:02:04 2021 -0500 Merge branch 'cassandra-4.0' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 00af9a6d3a619037b822d14a03b3a85fcfd7ca12
Merge: 9b99eac 3d59557
Author: Brandon Williams
AuthorDate: Wed Jul 14 10:00:37 2021 -0500
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt | 1 +
src/java/org/apache/cassandra/service/ReadCallback.java | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --cc CHANGES.txt
index 526d8a2,0c263e8..3548a03
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,17 -1,6 +1,18 @@@
-3.0.25:
+3.11.11
+ * Make cqlsh use the same set of reserved keywords than the server uses
(CASSANDRA-15663)
+ * Optimize bytes skipping when reading SSTable files (CASSANDRA-14415)
+ * Enable tombstone compactions when unchecked_tombstone_compaction is set in
TWCS (CASSANDRA-14496)
+ * Read only the required SSTables for single partition queries
(CASSANDRA-16737)
+ * Fix LeveledCompactionStrategy compacts last level throw an
ArrayIndexOutOfBoundsException (CASSANDRA-15669)
+ * Maps $CASSANDRA_LOG_DIR to cassandra.logdir java property when executing
nodetool (CASSANDRA-16199)
+ * Nodetool garbagecollect should retain SSTableLevel for LCS
(CASSANDRA-16634)
+ * Ignore stale acks received in the shadow round (CASSANDRA-16588)
+ * Add autocomplete and error messages for provide_overlapping_tombstones
(CASSANDRA-16350)
+ * Add StorageServiceMBean.getKeyspaceReplicationInfo(keyspaceName)
(CASSANDRA-16447)
+ * Make sure sstables with moved starts are removed correctly in
LeveledGenerations (CASSANDRA-16552)
+ * Upgrade jackson-databind to 2.9.10.8 (CASSANDRA-16462)
+Merged from 3.0:
+ * Push digest mismatch exceptions to trace (CASSANDRA-14900)
- * Support long names in nodetool output (CASSANDRA-14162)
* Handle correctly the exceptions thrown by custom QueryHandler constructors
(CASSANDRA-16703)
* Adding columns via ALTER TABLE can generate corrupt sstables
(CASSANDRA-16735)
* Add flag to disable ALTER...DROP COMPACT STORAGE statements
(CASSANDRA-16733)
diff --cc src/java/org/apache/cassandra/service/ReadCallback.java
index b312852,837ab5e..46023df
--- a/src/java/org/apache/cassandra/service/ReadCallback.java
+++ b/src/java/org/apache/cassandra/service/ReadCallback.java
@@@ -240,12 -235,10 +240,10 @@@ public class ReadCallback implements IA
if (traceState != null)
traceState.trace("Digest mismatch: {}", e.toString());
- if (logger.isDebugEnabled())
- logger.debug("Digest mismatch:", e);
ReadRepairMetrics.repairedBackground.mark();
-
-final DataResolver repairResolver = new
DataResolver(keyspace, command, consistencyLevel, endpoints.size());
+
+final DataResolver repairResolver = new
DataResolver(keyspace, command, consistencyLevel, endpoints.size(),
queryStartNanoTime);
AsyncRepairCallback repairHandler = new
AsyncRepairCallback(repairResolver, endpoints.size());
for (InetAddress endpoint : endpoints)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (9b99eac -> 00af9a6)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 9b99eac Merge branch 'cassandra-3.0' into cassandra-3.11 new 3d59557 don't log DigestMismatchException at DEBUG new 00af9a6 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/service/ReadCallback.java | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: don't log DigestMismatchException at DEBUG
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 3d59557 don't log DigestMismatchException at DEBUG
3d59557 is described below
commit 3d59557aceaaaedd8eafc4783394330d55a7fb4e
Author: Robert Stupp
AuthorDate: Tue Nov 14 09:41:09 2017 +0100
don't log DigestMismatchException at DEBUG
patch by Robert Stupp and Aleksandr Soromoukov, reviewed by edimitrova
and brandonwilliams for CASSANDRA-14900
---
CHANGES.txt | 1 +
src/java/org/apache/cassandra/service/ReadCallback.java | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index a0bd1cf..0c263e8 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.25:
+ * Push digest mismatch exceptions to trace (CASSANDRA-14900)
* Support long names in nodetool output (CASSANDRA-14162)
* Handle correctly the exceptions thrown by custom QueryHandler constructors
(CASSANDRA-16703)
* Adding columns via ALTER TABLE can generate corrupt sstables
(CASSANDRA-16735)
diff --git a/src/java/org/apache/cassandra/service/ReadCallback.java
b/src/java/org/apache/cassandra/service/ReadCallback.java
index 71eb0bc..837ab5e 100644
--- a/src/java/org/apache/cassandra/service/ReadCallback.java
+++ b/src/java/org/apache/cassandra/service/ReadCallback.java
@@ -235,9 +235,7 @@ public class ReadCallback implements
IAsyncCallbackWithFailure
if (traceState != null)
traceState.trace("Digest mismatch: {}", e.toString());
-if (logger.isDebugEnabled())
-logger.debug("Digest mismatch:", e);
-
+
ReadRepairMetrics.repairedBackground.mark();
final DataResolver repairResolver = new DataResolver(keyspace,
command, consistencyLevel, endpoints.size());
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (43a6e5c -> f08fdcf)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 43a6e5c Merge branch 'cassandra-4.0' into trunk add 15c22fa Backport CASSANDRA-7950 (Support long names in nodetool output) new 9b99eac Merge branch 'cassandra-3.0' into cassandra-3.11 new b7454f7 Merge branch 'cassandra-3.11' into cassandra-4.0 new f08fdcf Merge branch 'cassandra-4.0' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (75f6167 -> b7454f7)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 75f6167 Merge branch 'cassandra-4.0.0' into cassandra-4.0 add 15c22fa Backport CASSANDRA-7950 (Support long names in nodetool output) new 9b99eac Merge branch 'cassandra-3.0' into cassandra-3.11 new b7454f7 Merge branch 'cassandra-3.11' into cassandra-4.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit f08fdcf84f0910d4e15acb51ae787a3aaad8c84e Merge: 43a6e5c b7454f7 Author: Brandon Williams AuthorDate: Wed Jul 14 09:54:05 2021 -0500 Merge branch 'cassandra-4.0' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 9b99eac183566defe6c38640140793bcc4c3a135 Merge: 2a8e018 15c22fa Author: Brandon Williams AuthorDate: Wed Jul 14 09:53:47 2021 -0500 Merge branch 'cassandra-3.0' into cassandra-3.11 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit b7454f7ef25259d183ec72f55f133ac4c60011e7 Merge: 75f6167 9b99eac Author: Brandon Williams AuthorDate: Wed Jul 14 09:53:58 2021 -0500 Merge branch 'cassandra-3.11' into cassandra-4.0 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (2a8e018 -> 9b99eac)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 2a8e018 Make cqlsh use the same set of reserved keywords than the server uses add 15c22fa Backport CASSANDRA-7950 (Support long names in nodetool output) new 9b99eac Merge branch 'cassandra-3.0' into cassandra-3.11 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14900:
-
Reviewers: Brandon Williams, Ekaterina Dimitrova (was:
Ekaterina Dimitrova)
Test and Documentation Plan: run CI
Status: Review In Progress (was: Needs Reviewer)
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.x, 3.11.x
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380647#comment-17380647
]
Brandon Williams commented on CASSANDRA-14900:
--
+1
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.x, 3.11.x
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16799) Add an upgrade test with multi-dc writes
[ https://issues.apache.org/jira/browse/CASSANDRA-16799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16799: - Change Category: Quality Assurance Complexity: Normal Component/s: Messaging/Internode Fix Version/s: 4.0.x Status: Open (was: Triage Needed) > Add an upgrade test with multi-dc writes > > > Key: CASSANDRA-16799 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16799 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0.x > > > This is to prevent regressions of CASSANDRA-16797 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16677) Fix flaky ConnectionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380627#comment-17380627 ] Josh McKenzie commented on CASSANDRA-16677: --- I believe the last run of the numbers showed something like 13% of flaky tests being actual product defects. I'm personally not very comfortable marking things as flaky unless we have a strong understanding of why the tests are flaking out, and at that point we probably know more than enough to fix them anyway. > Fix flaky ConnectionTest > > > Key: CASSANDRA-16677 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16677 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessageDeliveryOnReconnect_compression/ > https://app.circleci.com/pipelines/github/adelapena/cassandra/460/workflows/cf7dcec6-612c-45d1-8471-623bde481dca/jobs/4069 > https://app.circleci.com/pipelines/github/adelapena/cassandra/460/workflows/b750cd38-0263-4b5e-9bb8-a8be98214378/jobs/4065 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15438) MerkleTrees variables renaming tree -> trees
[ https://issues.apache.org/jira/browse/CASSANDRA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15438: - Summary: MerkleTrees variables renaming tree -> trees (was: MerkleTrees viriables renaming tree -> trees) > MerkleTrees variables renaming tree -> trees > > > Key: CASSANDRA-15438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15438 > Project: Cassandra > Issue Type: Improvement >Reporter: xiangwang >Assignee: xiangwang >Priority: Normal > Attachments: 0001-Rename-MerkleTrees-tree-to-MerkleTrees-trees.patch > > > It's confusing that the virable tree is sometimes MerkleTrees instead of > MerkleTree. > I'd like to rename "MerkleTrees tree" to "MerkleTrees trees" to make the code > easier to read. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12922) Bloom filter miss counts are not measured correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380575#comment-17380575
]
Aleksei Zotov commented on CASSANDRA-12922:
---
Sounds reasonable, I'll move the index file check to the beginning of
{{getPosition}} method with a corresponding comment.
> Bloom filter miss counts are not measured correctly
> ---
>
> Key: CASSANDRA-12922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12922
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Branimir Lambov
>Assignee: Aleksei Zotov
>Priority: Normal
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Attachments: 12922-trunk.txt
>
>
> Bloom filter hits and misses are evaluated incorrectly in
> {{BigTableReader.getPosition}}: we properly record hits, but not misses. In
> particular, if we don't find a match for a key in the index, which is where
> almost all non-matches will be rejected, [we don't record a bloom filter
> false
> positive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableReader.java#L228].
> This leads to very misleading output from e.g. {{nodetool tablestats}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16104) Wrong warning about data volumes capacity
[
https://issues.apache.org/jira/browse/CASSANDRA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380576#comment-17380576
]
Andres de la Peña edited comment on CASSANDRA-16104 at 7/14/21, 1:05 PM:
-
[~saprykin] Thanks for the patch, and sorry for the delayed review.
Getting concurrent compactors through JMX when validating the {{-j/--jobs}}
option makes sense to me. Indeed, there is [a TODO
comment|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/tools/NodeProbe.java#L302]
about this in 3.11, dating back to CASSANDRA-9054. I have rebased the patch
and created versions for 3.11, 4.0 and trunk, and CI is running:
||patch||CI||
|[3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...adelapena:16104-3.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/661/workflows/3e91ee7c-eb67-416b-af65-3e0314e5d359]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...adelapena:16104-3.11]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/664/workflows/2fe0f649-b846-47e4-8a42-74c04aef75c4]|
|[4.0|https://github.com/apache/cassandra/compare/cassandra-4.0...adelapena:16104-4.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/663/workflows/e58e0821-b6a7-4b18-923d-f0eddf743734]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/663/workflows/be12b427-30ed-429b-9a4e-ca0ec1a5e53a]|
|[trunk|https://github.com/apache/cassandra/compare/trunk...adelapena:16104-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/662/workflows/bf7ad882-b6f7-4c13-a534-0e64b740c748]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/662/workflows/b1ff8a2f-b268-407f-98ef-cb13b10fc575]|
>From 3.11 and beyond we don't need to add the mbean methods since they already
>exist since CASSANDRA-12248, so we only need to use them from {{NodeProbe}} to
>get rid of all the dependencies from {{DatabaseDescriptor}}.
I wonder whether it's worth adding a dtest setting a couple of nodes with
different values for {{concurrent_compactors}} and call them with nodetool to
verify that the {{-j/--jobs}} option issues the warning depending on the
connected node. I think it should be a Python dtest since, if I'm right, Java
dtests use an internal probe that doesn't use JMX.
was (Author: adelapena):
[~saprykin] Thanks for the patch, and sorry for the delayed review.
Getting concurrent compactors through JMX when validating the {{-j/--jobs}}
option makes sense to me. Indeed, there is [a TODO
comment|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/tools/NodeProbe.java#L302]
about this in 3.11, dating back to CASSANDRA-9054. I have rebased the patch
and created versions for 3.11, 4.0 and trunk, and CI is running:
||patch||CI||
|[3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...adelapena:16104-3.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/661/workflows/3e91ee7c-eb67-416b-af65-3e0314e5d359]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...adelapena:16104-3.11]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/664/workflows/2fe0f649-b846-47e4-8a42-74c04aef75c4]|
|[4.0|https://github.com/apache/cassandra/compare/cassandra-4.0...adelapena:16104-4.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/663/workflows/e58e0821-b6a7-4b18-923d-f0eddf743734]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/663/workflows/be12b427-30ed-429b-9a4e-ca0ec1a5e53a]|
|[trunk|https://github.com/apache/cassandra/compare/cassandra-trunk...adelapena:16104-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/662/workflows/bf7ad882-b6f7-4c13-a534-0e64b740c748]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/662/workflows/b1ff8a2f-b268-407f-98ef-cb13b10fc575]|
>From 3.11 and beyond we don't need to add the mbean methods since they already
>exist since CASSANDRA-12248, so we only need to use them from {{NodeProbe}} to
>get rid of all the dependencies from {{DatabaseDescriptor}}.
I wonder whether it's worth adding a dtest setting a couple of nodes with
different values for {{concurrent_compactors}} and call them with nodetool to
verify that the {{-j/--jobs}} option issues the warning depending on the
connected node. I think it should be a Python dtest since, if I'm right, Java
dtests use an internal probe that doesn't use JMX.
> Wrong warning about data volumes capacity
> -
>
> Key: CASSANDRA-16104
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16104
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Dmitrii Saprykin
>Assignee: Dmitrii Saprykin
>
[jira] [Updated] (CASSANDRA-16104) Wrong warning about data volumes capacity
[
https://issues.apache.org/jira/browse/CASSANDRA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16104:
--
Reviewers: Andres de la Peña, Andres de la Peña (was: Andres de la Peña)
Andres de la Peña, Andres de la Peña (was: Andres de la Peña)
Status: Review In Progress (was: Patch Available)
> Wrong warning about data volumes capacity
> -
>
> Key: CASSANDRA-16104
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16104
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Dmitrii Saprykin
>Assignee: Dmitrii Saprykin
>Priority: Normal
>
> I see the following warning trying to run *nodetool upgradesstables*
> {noformat}
> WARN 16:09:24 Only 34988 MB free across all data volumes. Consider adding
> more capacity to your cluster or removing obsolete snapshots
> {noformat}
> This warning is wrong because the wrong storage device capacity gets tested.
> All my cassandra data paths are subdirectories of */data* mount point which
> has enough of space:
> {noformat}
> $ df -h /data
> Filesystem Size Used Avail Mounted on
> . 1.2T 200G 1T /data
> {noformat}
> However what Warning reports is a OS mount which has nothing to do with
> Cassandra configuration:
> {noformat}
> df -h /
> Filesystem Size Used Avail Use% Mounted on
> 40G 5.7G 35G 15% /
> {noformat}
> I see this error running Cassandra 3.0.22
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16104) Wrong warning about data volumes capacity
[
https://issues.apache.org/jira/browse/CASSANDRA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380576#comment-17380576
]
Andres de la Peña commented on CASSANDRA-16104:
---
[~saprykin] Thanks for the patch, and sorry for the delayed review.
Getting concurrent compactors through JMX when validating the {{-j/--jobs}}
option makes sense to me. Indeed, there is [a TODO
comment|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/tools/NodeProbe.java#L302]
about this in 3.11, dating back to CASSANDRA-9054. I have rebased the patch
and created versions for 3.11, 4.0 and trunk, and CI is running:
||patch||CI||
|[3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...adelapena:16104-3.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/661/workflows/3e91ee7c-eb67-416b-af65-3e0314e5d359]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...adelapena:16104-3.11]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/664/workflows/2fe0f649-b846-47e4-8a42-74c04aef75c4]|
|[4.0|https://github.com/apache/cassandra/compare/cassandra-4.0...adelapena:16104-4.0]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/663/workflows/e58e0821-b6a7-4b18-923d-f0eddf743734]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/663/workflows/be12b427-30ed-429b-9a4e-ca0ec1a5e53a]|
|[trunk|https://github.com/apache/cassandra/compare/cassandra-trunk...adelapena:16104-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/662/workflows/bf7ad882-b6f7-4c13-a534-0e64b740c748]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/662/workflows/b1ff8a2f-b268-407f-98ef-cb13b10fc575]|
>From 3.11 and beyond we don't need to add the mbean methods since they already
>exist since CASSANDRA-12248, so we only need to use them from {{NodeProbe}} to
>get rid of all the dependencies from {{DatabaseDescriptor}}.
I wonder whether it's worth adding a dtest setting a couple of nodes with
different values for {{concurrent_compactors}} and call them with nodetool to
verify that the {{-j/--jobs}} option issues the warning depending on the
connected node. I think it should be a Python dtest since, if I'm right, Java
dtests use an internal probe that doesn't use JMX.
> Wrong warning about data volumes capacity
> -
>
> Key: CASSANDRA-16104
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16104
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Dmitrii Saprykin
>Assignee: Dmitrii Saprykin
>Priority: Normal
>
> I see the following warning trying to run *nodetool upgradesstables*
> {noformat}
> WARN 16:09:24 Only 34988 MB free across all data volumes. Consider adding
> more capacity to your cluster or removing obsolete snapshots
> {noformat}
> This warning is wrong because the wrong storage device capacity gets tested.
> All my cassandra data paths are subdirectories of */data* mount point which
> has enough of space:
> {noformat}
> $ df -h /data
> Filesystem Size Used Avail Mounted on
> . 1.2T 200G 1T /data
> {noformat}
> However what Warning reports is a OS mount which has nothing to do with
> Cassandra configuration:
> {noformat}
> df -h /
> Filesystem Size Used Avail Use% Mounted on
> 40G 5.7G 35G 15% /
> {noformat}
> I see this error running Cassandra 3.0.22
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13464) Failed to create Materialized view with a specific token range
[
https://issues.apache.org/jira/browse/CASSANDRA-13464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-13464:
---
Reviewers: Benjamin Lerer, Zhao Yang (was: Zhao Yang)
> Failed to create Materialized view with a specific token range
> --
>
> Key: CASSANDRA-13464
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13464
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Materialized Views
>Reporter: Natsumi Kojima
>Assignee: Krishna Dattu Koneru
>Priority: Low
> Labels: materializedviews
>
> Failed to create Materialized view with a specific token range.
> Example :
> {code:java}
> $ ccm create "MaterializedView" -v 3.0.13
> $ ccm populate -n 3
> $ ccm start
> $ ccm status
> Cluster: 'MaterializedView'
> ---
> node1: UP
> node3: UP
> node2: UP
> $ccm node1 cqlsh
> Connected to MaterializedView at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 3.0.13 | CQL spec 3.4.0 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE test WITH replication = {'class':'SimpleStrategy',
> 'replication_factor':3};
> cqlsh> CREATE TABLE test.test ( id text PRIMARY KEY , value1 text , value2
> text, value3 text);
> $ccm node1 ring test
> Datacenter: datacenter1
> ==
> AddressRackStatus State LoadOwns
> Token
>
> 3074457345618258602
> 127.0.0.1 rack1 Up Normal 64.86 KB100.00%
> -9223372036854775808
> 127.0.0.2 rack1 Up Normal 86.49 KB100.00%
> -3074457345618258603
> 127.0.0.3 rack1 Up Normal 89.04 KB100.00%
> 3074457345618258602
> $ ccm node1 cqlsh
> cqlsh> INSERT INTO test.test (id, value1 , value2, value3 ) VALUES ('aaa',
> 'aaa', 'aaa' ,'aaa');
> cqlsh> INSERT INTO test.test (id, value1 , value2, value3 ) VALUES ('bbb',
> 'bbb', 'bbb' ,'bbb');
> cqlsh> SELECT token(id),id,value1 FROM test.test;
> system.token(id) | id | value1
> --+-+
> -4737872923231490581 | aaa |aaa
> -3071845237020185195 | bbb |bbb
> (2 rows)
> cqlsh> CREATE MATERIALIZED VIEW test.test_view AS SELECT value1, id FROM
> test.test WHERE id IS NOT NULL AND value1 IS NOT NULL AND TOKEN(id) >
> -9223372036854775808 AND TOKEN(id) < -3074457345618258603 PRIMARY KEY(value1,
> id) WITH CLUSTERING ORDER BY (id ASC);
> ServerError: java.lang.ClassCastException:
> org.apache.cassandra.cql3.TokenRelation cannot be cast to
> org.apache.cassandra.cql3.SingleColumnRelation
> {code}
> Stacktrace :
> {code:java}
> INFO [MigrationStage:1] 2017-04-19 18:32:48,131 ColumnFamilyStore.java:389 -
> Initializing test.test
> WARN [SharedPool-Worker-1] 2017-04-19 18:44:07,263 FBUtilities.java:337 -
> Trigger directory doesn't exist, please create it and try again.
> ERROR [SharedPool-Worker-1] 2017-04-19 18:46:10,072 QueryMessage.java:128 -
> Unexpected error during query
> java.lang.ClassCastException: org.apache.cassandra.cql3.TokenRelation cannot
> be cast to org.apache.cassandra.cql3.SingleColumnRelation
> at
> org.apache.cassandra.db.view.View.relationsToWhereClause(View.java:275)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.statements.CreateViewStatement.announceMigration(CreateViewStatement.java:219)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.statements.SchemaAlteringStatement.execute(SchemaAlteringStatement.java:93)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:206)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:237)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:222)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:115)
> ~[apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:513)
> [apache-cassandra-3.0.13.jar:3.0.13]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:407)
> [apache-cassandra-3.0.13.jar:3.0.13]
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357)
> [netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
>
[jira] [Updated] (CASSANDRA-15438) MerkleTrees viriables renaming tree -> trees
[ https://issues.apache.org/jira/browse/CASSANDRA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-15438: --- Status: In Progress (was: Patch Available) > MerkleTrees viriables renaming tree -> trees > > > Key: CASSANDRA-15438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15438 > Project: Cassandra > Issue Type: Improvement >Reporter: xiangwang >Assignee: xiangwang >Priority: Normal > Attachments: 0001-Rename-MerkleTrees-tree-to-MerkleTrees-trees.patch > > > It's confusing that the virable tree is sometimes MerkleTrees instead of > MerkleTree. > I'd like to rename "MerkleTrees tree" to "MerkleTrees trees" to make the code > easier to read. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15438) MerkleTrees viriables renaming tree -> trees
[
https://issues.apache.org/jira/browse/CASSANDRA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380558#comment-17380558
]
Benjamin Lerer commented on CASSANDRA-15438:
[~azotcsit] To be honnest, I do not think that we have a clear rule about
refactorings outside the fact that they should be done in trunk. I might have
missed some discussions through. In this case the change is pretty harmless and
perfectly valid so I do not mind committing it.
[~xiangwang] are you still interested in getting your patch in? If yes are you
willing to rebase it?
I will move the patch back to {{Open}} feel free to move it back to {{Patch
Available}} after rebase.
> MerkleTrees viriables renaming tree -> trees
>
>
> Key: CASSANDRA-15438
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15438
> Project: Cassandra
> Issue Type: Improvement
>Reporter: xiangwang
>Assignee: xiangwang
>Priority: Normal
> Attachments: 0001-Rename-MerkleTrees-tree-to-MerkleTrees-trees.patch
>
>
> It's confusing that the virable tree is sometimes MerkleTrees instead of
> MerkleTree.
> I'd like to rename "MerkleTrees tree" to "MerkleTrees trees" to make the code
> easier to read.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14570) Improper default value of cdc_total_space_in_mb
[ https://issues.apache.org/jira/browse/CASSANDRA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380554#comment-17380554 ] Benjamin Lerer commented on CASSANDRA-14570: [~shichao.an], [~JoshuaMcKenzie] it is not clear to me what is the status of this ticket. Are some change required or is the patch complete? > Improper default value of cdc_total_space_in_mb > --- > > Key: CASSANDRA-14570 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14570 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Shichao An >Assignee: Shichao An >Priority: Low > Labels: CDC > > The code for calculating cdc_total_space_in_mb in DatabaseDescriptor.java > does not reflect the latest architecture introduced by CASSANDRA-12148. > In short, cdc_total_space_in_mb should be equal or greater than > commitlog_total_space_in_mb; otherwise, the writes will fail when on-disk > commit logs size reaches the value of cdc_total_space_in_mb. For example, If > cdc_total_space_in_mb is 4096 and commitlog_total_space_in_mb is 8192, when > we enabled the cdc_enabled flag (even if we didn't enable cdc=true on any > table), when total size of commit logs reaches 4096 MB, there is the same of > amount of hard links in cdc_raw directory, that is, 4096 MB of cdc logs. > Then, if a table has cdc=true, the writes will fail in that table because the > CommitLogSegmentManagerCDC will be unable to process new CDC segments. (See > allocate and processNewSegment in CommitLogSegmentManagerCDC class) > > I will attach patches later. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16803) Trunk (4.1) jvm-dtest-upgrade failing MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck
[
https://issues.apache.org/jira/browse/CASSANDRA-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380553#comment-17380553
]
Michael Semb Wever commented on CASSANDRA-16803:
I'm not convinced the {{ClassNotFoundException: com.vdurmont.semver4j.Semver}}
is the underlying cause here.
> Trunk (4.1) jvm-dtest-upgrade failing
> MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck
>
>
> Key: CASSANDRA-16803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16803
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> Caused by CASSANDRA-16649
> Reproducible locally. Oddly enough can be reproduced on cassandra-4.0 branch
> as well, though CI is not failing.
> fyi [~ifesdjeen]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16803) Trunk (4.1) jvm-dtest-upgrade failing MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck
[ https://issues.apache.org/jira/browse/CASSANDRA-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16803: --- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: DTest Severity: Normal Status: Open (was: Triage Needed) > Trunk (4.1) jvm-dtest-upgrade failing > MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck > > > Key: CASSANDRA-16803 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16803 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > Caused by CASSANDRA-16649 > Reproducible locally. Oddly enough can be reproduced on cassandra-4.0 branch > as well, though CI is not failing. > fyi [~ifesdjeen] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16803) Trunk (4.1) jvm-dtest-upgrade failing MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck
Michael Semb Wever created CASSANDRA-16803: -- Summary: Trunk (4.1) jvm-dtest-upgrade failing MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck Key: CASSANDRA-16803 URL: https://issues.apache.org/jira/browse/CASSANDRA-16803 Project: Cassandra Issue Type: Bug Components: Test/dtest/java Reporter: Michael Semb Wever Assignee: Michael Semb Wever Caused by CASSANDRA-16649 Reproducible locally. Oddly enough can be reproduced on cassandra-4.0 branch as well, though CI is not failing. fyi [~ifesdjeen] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16404) Provide a nodetool way of invalidating auth caches
[
https://issues.apache.org/jira/browse/CASSANDRA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380539#comment-17380539
]
Sam Tunnicliffe commented on CASSANDRA-16404:
-
Yep, I completely recognise your points here [~blerer], but I suppose my
general counter argument would be if not now, when?
{quote}I also want to raise the fact that so far the Virtual Tables that we
expose do not support updates. The mechanism is there but has not really been
used (TRUNCATE is not supported at at).
{quote}
This is a brand new, low risk feature which is not blocking a release and nor
is it particularly urgent. That seems to me to make it an ideal way to explore
& flesh out that area.
{quote}Will it not make sense to support both approach until Virtual Tables
provide the same level of functionalities that JMX and NodeTool or an extended
version?
{quote}
That is quite an ambitious goal. My concern is that if we take the approach of
splitting each task like this into distinct tickets, then pragmatism will get
the better of us as it has in the past. That is, the desire for something that
"does the job" today trumps the better/newer, but ultimately redundant, stuff.
i.e. if there's a way to acheive this through nodetool/JMX, the incentive to
build the VT version largely disappears.
All that said, like I said before I do appreciate that a lot of work has
already gone into this ticket so it's absolutely my bad for not bringing
forward this suggestion earlier. Aside from the syntactic stuff I mentioned in
my previous comment, this generally LGTM, so I certainly wouldn't dig my heels
in over it should we choose to stick with the current approach.
> Provide a nodetool way of invalidating auth caches
> --
>
> Key: CASSANDRA-16404
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16404
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Authorization
>Reporter: Sumanth Pasupuleti
>Assignee: Aleksei Zotov
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We currently have nodetool commands to invalidate certain caches like
> KeyCache, RowCache and CounterCache.
> Being able to invalidate auth caches as well can come in handy in situations
> where, critical backend auth changes may need to be in effect right away for
> all the connections, especially in configurations where cache validity is
> chosen to be for a longer duration. An example can be that an authenticated
> user "User1" is no longer authorized to access a table resource "table1" and
> it is vital that this change is reflected right away, without having to wait
> for cache expiry/refresh to trigger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-12922) Bloom filter miss counts are not measured correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380536#comment-17380536
]
Branimir Lambov edited comment on CASSANDRA-12922 at 7/14/21, 12:04 PM:
To be honest, I did not realize there's a "there is no index file" exit path;
an index is required for normal operation. (The only place we can do without
one is in {{Scrubber}} which does not rely on {{getPosition}}.)
You are right that for the bloom filter not having an index file should not
matter, but if such a scenario is to be realized, it would be due to a problem
with the index rather than one with the precision of the bloom filter; the
relevant data may actually be present. Instead of adding a false positive, I
would thus prefer to move the {{ifile == null}} check to the beginning of the
method and leave it outside the coverage of the bloom filter tracker.
was (Author: blambov):
To be honest, I did not realize there's a "there is no index file" exit path;
an index is required for normal operation. (The only place we can do without
one is in {{Scrubber}} which does not rely on {{getPosition}}.)
You are right that for the bloom filter not having an index file should not
matter, but if such a scenario is to be realized, it would be due to a problem
with the index rather than one with the precision of the bloom filter; the
relevant data may actually be present. Instead of adding a false positive, I
would thus prefer to move the `ifile == null` check to the beginning of the
method and leave it outside the coverage of the bloom filter tracker.
> Bloom filter miss counts are not measured correctly
> ---
>
> Key: CASSANDRA-12922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12922
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Branimir Lambov
>Assignee: Aleksei Zotov
>Priority: Normal
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Attachments: 12922-trunk.txt
>
>
> Bloom filter hits and misses are evaluated incorrectly in
> {{BigTableReader.getPosition}}: we properly record hits, but not misses. In
> particular, if we don't find a match for a key in the index, which is where
> almost all non-matches will be rejected, [we don't record a bloom filter
> false
> positive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableReader.java#L228].
> This leads to very misleading output from e.g. {{nodetool tablestats}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12922) Bloom filter miss counts are not measured correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380536#comment-17380536
]
Branimir Lambov commented on CASSANDRA-12922:
-
To be honest, I did not realize there's a "there is no index file" exit path;
an index is required for normal operation. (The only place we can do without
one is in {{Scrubber}} which does not rely on {{getPosition}}.)
You are right that for the bloom filter not having an index file should not
matter, but if such a scenario is to be realized, it would be due to a problem
with the index rather than one with the precision of the bloom filter; the
relevant data may actually be present. Instead of adding a false positive, I
would thus prefer to move the `ifile == null` check to the beginning of the
method and leave it outside the coverage of the bloom filter tracker.
> Bloom filter miss counts are not measured correctly
> ---
>
> Key: CASSANDRA-12922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12922
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Branimir Lambov
>Assignee: Aleksei Zotov
>Priority: Normal
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Attachments: 12922-trunk.txt
>
>
> Bloom filter hits and misses are evaluated incorrectly in
> {{BigTableReader.getPosition}}: we properly record hits, but not misses. In
> particular, if we don't find a match for a key in the index, which is where
> almost all non-matches will be rejected, [we don't record a bloom filter
> false
> positive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableReader.java#L228].
> This leads to very misleading output from e.g. {{nodetool tablestats}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16404) Provide a nodetool way of invalidating auth caches
[ https://issues.apache.org/jira/browse/CASSANDRA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380512#comment-17380512 ] Benjamin Lerer edited comment on CASSANDRA-16404 at 7/14/21, 11:34 AM: --- I agree that we would like to move away from JMX and Nodetool. Nevertheless, we never had some clear discussion around it and I imagine that they will still be there for several releases and I wonder if having an hybride between the 2 approach is necessarily a good thing. I also want to raise the fact that so far the Virtual Tables that we expose do not support updates. The mechanism is there but has not really been used (TRUNCATE is not supported at at). Now, I really love your suggestion [~samt]. Will it not make sense to support both approach until Virtual Tables provide the same level of functionalities that JMX and NodeTool or an extended version? If yes, my suggestion would be to split the task in 2 (or more if some extra changes are needed in the Virtual Table framework). Finish the current patch and open a new ticket to provide the same functionality through some Virtual Tables. [~samt] What is your opinion? was (Author: blerer): I agree that we would like to move away from JMX and Nodetool. Nevertheless, We never had some clear discussion around it and I imagine that they will still be there for several releases and I am wonder if having an hybride between the 2 approach is necessarily a good approach. I also want to raise the fact that so far the Virtual Tables that we expose do not support updates. The mechanism is there but has not really been used (TRUNCATE is not supported at at). Now, I really love your suggestion [~samt]. Will it not make sense to support both approach until Virtual Tables provide the same level of functionalities that JMX and NodeTool or an extended version? If yes, my suggestion would be to split the task in 2 (or more if some extra changes are needed in the Virtual Table framework). Finish the current patch and open a new ticket to provide the same functionality through some Virtual Tables. [~samt] What is your opinion? > Provide a nodetool way of invalidating auth caches > -- > > Key: CASSANDRA-16404 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16404 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Sumanth Pasupuleti >Assignee: Aleksei Zotov >Priority: Normal > Fix For: 4.x > > Time Spent: 50m > Remaining Estimate: 0h > > We currently have nodetool commands to invalidate certain caches like > KeyCache, RowCache and CounterCache. > Being able to invalidate auth caches as well can come in handy in situations > where, critical backend auth changes may need to be in effect right away for > all the connections, especially in configurations where cache validity is > chosen to be for a longer duration. An example can be that an authenticated > user "User1" is no longer authorized to access a table resource "table1" and > it is vital that this change is reflected right away, without having to wait > for cache expiry/refresh to trigger. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16404) Provide a nodetool way of invalidating auth caches
[ https://issues.apache.org/jira/browse/CASSANDRA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380512#comment-17380512 ] Benjamin Lerer commented on CASSANDRA-16404: I agree that we would like to move away from JMX and Nodetool. Nevertheless, We never had some clear discussion around it and I imagine that they will still be there for several releases and I am wonder if having an hybride between the 2 approach is necessarily a good approach. I also want to raise the fact that so far the Virtual Tables that we expose do not support updates. The mechanism is there but has not really been used (TRUNCATE is not supported at at). Now, I really love your suggestion [~samt]. Will it not make sense to support both approach until Virtual Tables provide the same level of functionalities that JMX and NodeTool or an extended version? If yes, my suggestion would be to split the task in 2 (or more if some extra changes are needed in the Virtual Table framework). Finish the current patch and open a new ticket to provide the same functionality through some Virtual Tables. [~samt] What is your opinion? > Provide a nodetool way of invalidating auth caches > -- > > Key: CASSANDRA-16404 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16404 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Sumanth Pasupuleti >Assignee: Aleksei Zotov >Priority: Normal > Fix For: 4.x > > Time Spent: 50m > Remaining Estimate: 0h > > We currently have nodetool commands to invalidate certain caches like > KeyCache, RowCache and CounterCache. > Being able to invalidate auth caches as well can come in handy in situations > where, critical backend auth changes may need to be in effect right away for > all the connections, especially in configurations where cache validity is > chosen to be for a longer duration. An example can be that an authenticated > user "User1" is no longer authorized to access a table resource "table1" and > it is vital that this change is reflected right away, without having to wait > for cache expiry/refresh to trigger. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12922) Bloom filter miss counts are not measured correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksei Zotov updated CASSANDRA-12922:
--
Fix Version/s: 4.0.x
3.11.x
3.0.x
> Bloom filter miss counts are not measured correctly
> ---
>
> Key: CASSANDRA-12922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12922
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Branimir Lambov
>Assignee: Aleksei Zotov
>Priority: Normal
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Attachments: 12922-trunk.txt
>
>
> Bloom filter hits and misses are evaluated incorrectly in
> {{BigTableReader.getPosition}}: we properly record hits, but not misses. In
> particular, if we don't find a match for a key in the index, which is where
> almost all non-matches will be rejected, [we don't record a bloom filter
> false
> positive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableReader.java#L228].
> This leads to very misleading output from e.g. {{nodetool tablestats}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-12922) Bloom filter miss counts are not measured correctly
[
https://issues.apache.org/jira/browse/CASSANDRA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer reassigned CASSANDRA-12922:
--
Assignee: Aleksei Zotov (was: Benjamin Lerer)
> Bloom filter miss counts are not measured correctly
> ---
>
> Key: CASSANDRA-12922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12922
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Branimir Lambov
>Assignee: Aleksei Zotov
>Priority: Normal
> Labels: lhf
> Fix For: 4.x
>
> Attachments: 12922-trunk.txt
>
>
> Bloom filter hits and misses are evaluated incorrectly in
> {{BigTableReader.getPosition}}: we properly record hits, but not misses. In
> particular, if we don't find a match for a key in the index, which is where
> almost all non-matches will be rejected, [we don't record a bloom filter
> false
> positive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableReader.java#L228].
> This leads to very misleading output from e.g. {{nodetool tablestats}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380437#comment-17380437
]
Benjamin Lerer commented on CASSANDRA-15210:
Thank you [~aprudhomme]. :-) Sorry for the delay, your patch fall through the
cracks. We are working on avoiding this kind of problem in the future.
I will put your patch back in progress so that it reflects more accurately its
status.
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-15210:
---
Status: In Progress (was: Patch Available)
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16467) speculative retry should allow more friendly params, allowing upgrade from 2.x not to break
[ https://issues.apache.org/jira/browse/CASSANDRA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16467: --- Reviewers: Caleb Rackliffe, Ekaterina Dimitrova (was: Caleb Rackliffe) > speculative retry should allow more friendly params, allowing upgrade from > 2.x not to break > --- > > Key: CASSANDRA-16467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16467 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 2.x speculative retry params are case insensitive, while 3.0 and 3.11 have > added case sensitivity. As as result of this, one of our internal > applications suffered an issue during > C* upgrade from 2.x to 3.0. > This ticket is to propose making 3.0 and 3.11 speculative_retry params case > insensitive as well (essentially a slightly modified backport of > CASSANDRA-13876, but not to allow something like "99p" which 4.0 allows) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16404) Provide a nodetool way of invalidating auth caches
[ https://issues.apache.org/jira/browse/CASSANDRA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380401#comment-17380401 ] Sam Tunnicliffe commented on CASSANDRA-16404: - Thanks [~azotcsit], and apologies again for dropping in that suggestion so late. > Provide a nodetool way of invalidating auth caches > -- > > Key: CASSANDRA-16404 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16404 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Sumanth Pasupuleti >Assignee: Aleksei Zotov >Priority: Normal > Fix For: 4.x > > Time Spent: 50m > Remaining Estimate: 0h > > We currently have nodetool commands to invalidate certain caches like > KeyCache, RowCache and CounterCache. > Being able to invalidate auth caches as well can come in handy in situations > where, critical backend auth changes may need to be in effect right away for > all the connections, especially in configurations where cache validity is > chosen to be for a longer duration. An example can be that an authenticated > user "User1" is no longer authorized to access a table resource "table1" and > it is vital that this change is reflected right away, without having to wait > for cache expiry/refresh to trigger. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (e1a2f57 -> 43a6e5c)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from e1a2f57 Merge branch 'cassandra-4.0' into trunk add 924bf92 Prepare debian changelog for 4.0.0 new 75f6167 Merge branch 'cassandra-4.0.0' into cassandra-4.0 new 43a6e5c Merge branch 'cassandra-4.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 updated (43b7503 -> 924bf92)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-4.0.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 43b7503 Correct fwd to/from messages for backward compatibility add 924bf92 Prepare debian changelog for 4.0.0 No new revisions were added by this update. Summary of changes: debian/changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0.0' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 75f6167ca33f18b9df1d7c24f097cf5bb6306dc2 Merge: e0aa365 924bf92 Author: Mick Semb Wever AuthorDate: Wed Jul 14 08:51:10 2021 +0200 Merge branch 'cassandra-4.0.0' into cassandra-4.0 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (e0aa365 -> 75f6167)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from e0aa365 Merge branch 'cassandra-4.0.0' into cassandra-4.0 add 924bf92 Prepare debian changelog for 4.0.0 new 75f6167 Merge branch 'cassandra-4.0.0' into cassandra-4.0 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 43a6e5cabdb9f3b6be965100cbbd765b378eede0 Merge: e1a2f57 75f6167 Author: Mick Semb Wever AuthorDate: Wed Jul 14 08:51:21 2021 +0200 Merge branch 'cassandra-4.0' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
