[jira] [Commented] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620011#comment-17620011 ] Erick Ramirez commented on CASSANDRA-17924: --- I’ve completed final verification in staging and [published to production|https://github.com/apache/cassandra-website#merging-asf-staging-to-asf-site]: {noformat} $ git branch * trunk $ git fetch origin $ git checkout asf-site Branch ‘asf-site’ set up to track remote branch ‘asf-site’ from ‘origin’. Switched to a new branch ‘asf-site’ $ git branch * asf-site trunk $ git reset --hard origin/asf-staging HEAD is now at d09b1fdd generate docs for 4e929444 $ git push -f origin asf-site Username for ‘https://github.com’: erickramirezau Password for ‘https://erickramire...@github.com’: Total 0 (delta 0), reused 0 (delta 0) To https://github.com/apache/cassandra-website.git + 2242cf98...d09b1fdd asf-site -> asf-site (forced update){noformat} The updated page is now live on the site -- https://cassandra.apache.org/_/development/code_style.html. > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > Attachments: c17924-01-development-code_style.png > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620010#comment-17620010 ] Erick Ramirez commented on CASSANDRA-17924: --- The build completed in 14 minutes and the page is now in staging – https://cassandra.staged.apache.org/_/development/code_style.html. > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > Attachments: c17924-01-development-code_style.png > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17873: Authors: (was: Benedict Elliott Smith, Berenguer Blasi) Reviewers: Benedict Elliott Smith, Berenguer Blasi > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1762#comment-1762 ] Berenguer Blasi commented on CASSANDRA-17873: - Am I seeing some new flaky failures like the compression opttions or the UUID restart one? wdyt [~e.dimitrova]? > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (e2cf783a3 -> d09b1fddb)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard e2cf783a3 generate docs for e5cbbab6 add 4e929 DOC - Add doc on checkstyle in CASSANDRA-17876 for contributors new d09b1fddb generate docs for 4e929444 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e2cf783a3) \ N -- N -- N refs/heads/asf-staging (d09b1fddb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/_/development/code_style.html | 16 content/_/development/index.html | 16 content/search-index.js| 2 +- .../modules/ROOT/pages/development/code_style.adoc | 11 +++ site-ui/build/ui-bundle.zip| Bin 4746711 -> 4746711 bytes 5 files changed, 44 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17964) Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
[ https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619997#comment-17619997 ] Berenguer Blasi edited comment on CASSANDRA-17964 at 10/19/22 4:48 AM: --- If IIUC you used those regexp to _fix_ the current problem. But I added an offending test file and checkstyle doesn't complain. So while fixing the current problem is valuable this PR doesn't prevent it from happening again. Why not use the regexp ".\*Test.\*[^.]\.java" and rename any offending files? That would fix the problem and prevent it the future imo. Or am I missing sthg? was (Author: bereng): If IIUC you used those regexp to _fix_ the current problem. But I added an offending test file and checkstyle doesn't complain. So while fixing the current problem is valuable this PR doesn't prevent it from happening again. Why not use the regexp ".*Test.*[^.]\.java" and rename any offending files? That would fix the problem and prevent it the future imo. Or am I missing sthg? > Some tests are never executed due to naming violation - fix it and add > checkstyle where applicable > -- > > Key: CASSANDRA-17964 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17964 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Ruslan Fomkin >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java] > doesn't follow naming convention to be run as unit tests and, thus, is never > run. > The rule in build expects names as `*Test`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17964) Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
[ https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619997#comment-17619997 ] Berenguer Blasi commented on CASSANDRA-17964: - If IIUC you used those regexp to _fix_ the current problem. But I added an offending test file and checkstyle doesn't complain. So while fixing the current problem is valuable this PR doesn't prevent it from happening again. Why not use the regexp ".*Test.*[^.]\.java" and rename any offending files? That would fix the problem and prevent it the future imo. Or am I missing sthg? > Some tests are never executed due to naming violation - fix it and add > checkstyle where applicable > -- > > Key: CASSANDRA-17964 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17964 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Ruslan Fomkin >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java] > doesn't follow naming convention to be run as unit tests and, thus, is never > run. > The rule in build expects names as `*Test`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619988#comment-17619988 ] Erick Ramirez commented on CASSANDRA-17924: --- The website content is getting built in staging: ||Branch||PR||Commit||Build|| |{{trunk}}|[#174|https://github.com/apache/cassandra-website/pull/174]|[4e92944|https://github.com/apache/cassandra-website/commit/4e9292f1ca280a42318a159676d33b0cf871]|[#660|https://ci-cassandra.apache.org/job/cassandra-website/660/]| > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > Attachments: c17924-01-development-code_style.png > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (bcc156d72 -> e2cf783a3)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard bcc156d72 generate docs for e5cbbab6 new e2cf783a3 generate docs for e5cbbab6 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (bcc156d72) \ N -- N -- N refs/heads/asf-staging (e2cf783a3) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4746711 -> 4746711 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17972) nodetool resetlocalschema does not sync schema
[ https://issues.apache.org/jira/browse/CASSANDRA-17972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619983#comment-17619983 ] Cameron Zemek commented on CASSANDRA-17972: --- Also reproduced this on 4.0.6 > nodetool resetlocalschema does not sync schema > -- > > Key: CASSANDRA-17972 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17972 > Project: Cassandra > Issue Type: Bug >Reporter: Cameron Zemek >Priority: Normal > > Steps to reproduce: > {code:java} > $ ccm create -n 2 -v 3.11.13 -s resettest > $ ccm node1 cqlsh -e "CREATE KEYSPACE test WITH replication = > {'class':'NetworkTopologyStrategy', 'datacenter1': 2}" > $ ccm node1 cqlsh -e "CREATE TABLE test.messages(id int primary key, message > text)" > $ ccm node1 nodetool describecluster > Cluster Information: > Name: resettest > Snitch: org.apache.cassandra.locator.SimpleSnitch > DynamicEndPointSnitch: enabled > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > 5172094b-dee2-3967-b5f0-dfd81d572a74: [127.0.0.1, 127.0.0.2] > $ ccm node2 nodetool resetlocalschema > $ ccm node2 cqlsh -e 'describe full schema' > $ find ~/.ccm/resettest/node2/data0/system_schema/ -maxdepth 2 -type f > $ ccm node2 nodetool describecluster > Cluster Information: > Name: resettest > Snitch: org.apache.cassandra.locator.SimpleSnitch > DynamicEndPointSnitch: enabled > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > 5172094b-dee2-3967-b5f0-dfd81d572a74: [127.0.0.1] > 59adb24e-f3cd-3e02-97f0-5b395827453f: [127.0.0.2] > $ ccm node2 stop > $ ccm node2 start > $ ccm node2 nodetool describecluster > Cluster Information: > Name: jpmctest > Snitch: org.apache.cassandra.locator.SimpleSnitch > DynamicEndPointSnitch: enabled > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > 5172094b-dee2-3967-b5f0-dfd81d572a74: [127.0.0.1, 127.0.0.2] > {code} > Its not resyncing the schema until after restarting the node. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17924: -- Source Control Link: https://github.com/apache/cassandra-website/commit/4e9292f1ca280a42318a159676d33b0cf871 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed: ||Branch||PR||Commit|| |{{trunk}}|[#174|https://github.com/apache/cassandra-website/pull/174]|[4e92944|https://github.com/apache/cassandra-website/commit/4e9292f1ca280a42318a159676d33b0cf871]| > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > Attachments: c17924-01-development-code_style.png > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch trunk updated: DOC - Add doc on checkstyle in CASSANDRA-17876 for contributors
This is an automated email from the ASF dual-hosted git repository. erickramirezau pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-website.git The following commit(s) were added to refs/heads/trunk by this push: new 4e929 DOC - Add doc on checkstyle in CASSANDRA-17876 for contributors 4e929 is described below commit 4e9292f1ca280a42318a159676d33b0cf871 Author: Stefan Miklosovic AuthorDate: Mon Sep 26 21:18:41 2022 +0200 DOC - Add doc on checkstyle in CASSANDRA-17876 for contributors patch by Stefan Miklosovic; reviewed by Erick Ramirez for CASSANDRA-17924 --- .../source/modules/ROOT/pages/development/code_style.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/site-content/source/modules/ROOT/pages/development/code_style.adoc b/site-content/source/modules/ROOT/pages/development/code_style.adoc index 3e18e8ebd..2e9e97077 100644 --- a/site-content/source/modules/ROOT/pages/development/code_style.adoc +++ b/site-content/source/modules/ROOT/pages/development/code_style.adoc @@ -7,6 +7,17 @@ coding conventions] for anything not expressly outlined in this document. Note that the project has a variety of styles that have accumulated in different subsystems. Where possible a balance should be struck between these guidelines and the style of the code that is being modified as part of a patch. Patches should also limit their scope to the minimum necessary for safely addressing the concerns of the patch. +== Checkstyle + +Cassandra uses https://checkstyle.sourceforge.io/[Checkstyle] project for enforcing various checkstyle policies the project follows. Checkstyle is part of the build from Cassandra 4.1 included. +You can consult the checkstyle configuration file called `checkstyle.xml` for the source code in `src` directory and `checkstyle_test.xml` for all code in `test` directory. +The configuration files are located in the root of the Cassandra repository. Checkstyle can be executed independently for the main source code as well as for the tests by executing `ant checkstyle` and `ant checkstyle-test` respectively. + +The checkstyle target is executed by default when e.g. `build` or `jar` targets are executed. There is a flag you can use for _not_ enforcing checkstyle. This is particularly handy upon development. +For example, by default, the checkstyle target checks that your changes in Java code do not include imports which are not used. +However, while you develop, you do not want this check to be enforced because you are not interested in it while you develop as your code tends to be in the in-progress state. +You can turn whole checkstyle off by specifying `-Dno-checkstyle=true` on the command line, for example like this: `ant build -Dno-checkstyle=true`. + == Naming and Clear Semantics Class, Method and Variable Naming - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17924: -- Status: Ready to Commit (was: Review In Progress) I've staged the PR and verified that it is ready to commit. !c17924-01-development-code_style.png|width=300! > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > Attachments: c17924-01-development-code_style.png > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17924: -- Attachment: c17924-01-development-code_style.png > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > Attachments: c17924-01-development-code_style.png > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17924) WEBSITE - Add doc about checkstyle for contributors
[ https://issues.apache.org/jira/browse/CASSANDRA-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17924: -- Status: Review In Progress (was: Patch Available) > WEBSITE - Add doc about checkstyle for contributors > --- > > Key: CASSANDRA-17924 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17924 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: NA > > > Add doc about checkstyle and its properties into code_style for > CASSANDRA-17876. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17972) nodetool resetlocalschema does not sync schema
Cameron Zemek created CASSANDRA-17972: - Summary: nodetool resetlocalschema does not sync schema Key: CASSANDRA-17972 URL: https://issues.apache.org/jira/browse/CASSANDRA-17972 Project: Cassandra Issue Type: Bug Reporter: Cameron Zemek Steps to reproduce: {code:java} $ ccm create -n 2 -v 3.11.13 -s resettest $ ccm node1 cqlsh -e "CREATE KEYSPACE test WITH replication = {'class':'NetworkTopologyStrategy', 'datacenter1': 2}" $ ccm node1 cqlsh -e "CREATE TABLE test.messages(id int primary key, message text)" $ ccm node1 nodetool describecluster Cluster Information: Name: resettest Snitch: org.apache.cassandra.locator.SimpleSnitch DynamicEndPointSnitch: enabled Partitioner: org.apache.cassandra.dht.Murmur3Partitioner Schema versions: 5172094b-dee2-3967-b5f0-dfd81d572a74: [127.0.0.1, 127.0.0.2] $ ccm node2 nodetool resetlocalschema $ ccm node2 cqlsh -e 'describe full schema' $ find ~/.ccm/resettest/node2/data0/system_schema/ -maxdepth 2 -type f $ ccm node2 nodetool describecluster Cluster Information: Name: resettest Snitch: org.apache.cassandra.locator.SimpleSnitch DynamicEndPointSnitch: enabled Partitioner: org.apache.cassandra.dht.Murmur3Partitioner Schema versions: 5172094b-dee2-3967-b5f0-dfd81d572a74: [127.0.0.1] 59adb24e-f3cd-3e02-97f0-5b395827453f: [127.0.0.2] $ ccm node2 stop $ ccm node2 start $ ccm node2 nodetool describecluster Cluster Information: Name: jpmctest Snitch: org.apache.cassandra.locator.SimpleSnitch DynamicEndPointSnitch: enabled Partitioner: org.apache.cassandra.dht.Murmur3Partitioner Schema versions: 5172094b-dee2-3967-b5f0-dfd81d572a74: [127.0.0.1, 127.0.0.2] {code} Its not resyncing the schema until after restarting the node. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-harry] branch dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.13.4.1 created (now eef14e8)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.13.4.1 in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git at eef14e8 Bump jackson-databind from 2.11.3 to 2.13.4.1 No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] (CASSANDRA-17698) sstabledump errors when dumping data from index
[ https://issues.apache.org/jira/browse/CASSANDRA-17698 ] maxwellguo deleted comment on CASSANDRA-17698: was (Author: maxwellguo): new question ,I found that the ci is still in holding status now after I have push the code and start ci test . Do you know the reason ? [~smiklosovic] Does this mean I should increase my ci environment configuration ? :( > sstabledump errors when dumping data from index > --- > > Key: CASSANDRA-17698 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17698 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Stefan Miklosovic >Assignee: maxwellguo >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > {code:java} > cqlsh> CREATE KEYSPACE ks1 WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': 1}; > cqlsh> CREATE TABLE ks1.tb1 ( id text, name text, primary key (id)); > cqlsh> CREATE INDEX IF NOT EXISTS ON ks1.tb1(name); > cqlsh> INSERT INTO ks1.tb1 (id, name ) VALUES ( '1', 'Joe'); > cqlsh> exit > ./bin/nodetool flush > ./tools/bin/sstabledump > data/data/ks1/tb1-1c3c5f10ee4711ecab82eda2f44200b3/.tb1_name_idx/nb-1-big-Data.db > > [ > { > "partition" : { > "key" : [ "Joe" ], > "position" : 0 > }, > "rows" : [ > { > "type" : "row", > "position" : 17, > "clustering" : [ ] } ] } ]Exception in thread "main" > java.lang.UnsupportedOperationException > at > org.apache.cassandra.db.marshal.PartitionerDefinedOrder.toJSONString(PartitionerDefinedOrder.java:87) > at > org.apache.cassandra.db.marshal.AbstractType.toJSONString(AbstractType.java:187) > at > org.apache.cassandra.tools.JsonTransformer.serializeClustering(JsonTransformer.java:372) > at > org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:269) > at > org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:235) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) > at java.util.Iterator.forEachRemaining(Iterator.java:116) > at > java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:113) > at > org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:214) {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17698) sstabledump errors when dumping data from index
[ https://issues.apache.org/jira/browse/CASSANDRA-17698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619945#comment-17619945 ] maxwellguo commented on CASSANDRA-17698: new question ,I found that the ci is still in holding status now after I have push the code and start ci test . Do you know the reason ? [~smiklosovic] Does this mean I should increase my ci environment configuration ? :( > sstabledump errors when dumping data from index > --- > > Key: CASSANDRA-17698 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17698 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Stefan Miklosovic >Assignee: maxwellguo >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > {code:java} > cqlsh> CREATE KEYSPACE ks1 WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': 1}; > cqlsh> CREATE TABLE ks1.tb1 ( id text, name text, primary key (id)); > cqlsh> CREATE INDEX IF NOT EXISTS ON ks1.tb1(name); > cqlsh> INSERT INTO ks1.tb1 (id, name ) VALUES ( '1', 'Joe'); > cqlsh> exit > ./bin/nodetool flush > ./tools/bin/sstabledump > data/data/ks1/tb1-1c3c5f10ee4711ecab82eda2f44200b3/.tb1_name_idx/nb-1-big-Data.db > > [ > { > "partition" : { > "key" : [ "Joe" ], > "position" : 0 > }, > "rows" : [ > { > "type" : "row", > "position" : 17, > "clustering" : [ ] } ] } ]Exception in thread "main" > java.lang.UnsupportedOperationException > at > org.apache.cassandra.db.marshal.PartitionerDefinedOrder.toJSONString(PartitionerDefinedOrder.java:87) > at > org.apache.cassandra.db.marshal.AbstractType.toJSONString(AbstractType.java:187) > at > org.apache.cassandra.tools.JsonTransformer.serializeClustering(JsonTransformer.java:372) > at > org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:269) > at > org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:235) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) > at java.util.Iterator.forEachRemaining(Iterator.java:116) > at > java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:113) > at > org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:214) {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17698) sstabledump errors when dumping data from index
[ https://issues.apache.org/jira/browse/CASSANDRA-17698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619944#comment-17619944 ] maxwellguo commented on CASSANDRA-17698: hi [~smiklosovic],OK, I‘m going to see which version this bug first appeared, and thank you for your reply(y) > sstabledump errors when dumping data from index > --- > > Key: CASSANDRA-17698 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17698 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Stefan Miklosovic >Assignee: maxwellguo >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > {code:java} > cqlsh> CREATE KEYSPACE ks1 WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': 1}; > cqlsh> CREATE TABLE ks1.tb1 ( id text, name text, primary key (id)); > cqlsh> CREATE INDEX IF NOT EXISTS ON ks1.tb1(name); > cqlsh> INSERT INTO ks1.tb1 (id, name ) VALUES ( '1', 'Joe'); > cqlsh> exit > ./bin/nodetool flush > ./tools/bin/sstabledump > data/data/ks1/tb1-1c3c5f10ee4711ecab82eda2f44200b3/.tb1_name_idx/nb-1-big-Data.db > > [ > { > "partition" : { > "key" : [ "Joe" ], > "position" : 0 > }, > "rows" : [ > { > "type" : "row", > "position" : 17, > "clustering" : [ ] } ] } ]Exception in thread "main" > java.lang.UnsupportedOperationException > at > org.apache.cassandra.db.marshal.PartitionerDefinedOrder.toJSONString(PartitionerDefinedOrder.java:87) > at > org.apache.cassandra.db.marshal.AbstractType.toJSONString(AbstractType.java:187) > at > org.apache.cassandra.tools.JsonTransformer.serializeClustering(JsonTransformer.java:372) > at > org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:269) > at > org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:235) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) > at java.util.Iterator.forEachRemaining(Iterator.java:116) > at > java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:113) > at > org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:214) {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619943#comment-17619943 ] Ekaterina Dimitrova commented on CASSANDRA-17950: - Thanks, I left a few comments on the PR I believe we also need 3.11, 4.0 and 4.1 branches. We normally start from the lowest and propagate up to trunk. I will make one more pass tomorrow morning to verify what you call in the jobs. The first review was focused on the more high-level stuff. As soon as those are in place the rest is easy. {quote}(taking away the unrelated commit) {quote} +1 on pulling this in a separate ticket > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17950: Fix Version/s: (was: 3.0.x) > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17950: Fix Version/s: 3.0.x 3.11.x 4.0.x 4.1.x 4.x > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-diff] branch dependabot/maven/api-server/com.fasterxml.jackson.core-jackson-databind-2.13.4.1 created (now 92890d1)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/api-server/com.fasterxml.jackson.core-jackson-databind-2.13.4.1 in repository https://gitbox.apache.org/repos/asf/cassandra-diff.git at 92890d1 Bump jackson-databind from 2.9.9.2 to 2.13.4.1 in /api-server No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619912#comment-17619912 ] Brandon Williams commented on CASSANDRA-17939: -- That fix looks good, but unfortunately appears to unveil other bashisms: {quote} $ .circleci/generate.sh -m Generating new config.yml file with middle resources from config-2_1.yml patching file .circleci/config-2_1.yml.MIDRES (read from .circleci/config-2_1.yml) Detecting new or modified tests with git diff --diff-filter=AMR cassandra-4.0...HEAD: .circleci/generate.sh: 251: [[: not found .circleci/generate.sh: 257: [[: not found .circleci/generate.sh: 260: [[: not found .circleci/generate.sh: 263: [[: not found .circleci/generate.sh: 266: [[: not found .circleci/generate.sh: 272: [[: not found .circleci/generate.sh: 276: [[: not found .circleci/generate.sh: 282: [[: not found .circleci/generate.sh: 285: [[: not found {quote} > CircleCI: Automatically detect and repeat new or modified JUnit tests > - > > Key: CASSANDRA-17939 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17939 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-rc, 4.2 > > Time Spent: 50m > Remaining Estimate: 0h > > The purpose of this ticket is adding a new CircleCI job that automatically > detects new or modified test classes and runs them repeatedly. That way we > wouldn't need to manually specify those tests with {{.circleci/generate.sh}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17930) Ensure CircleCI and ASF Jenkins CI are aligned
[ https://issues.apache.org/jira/browse/CASSANDRA-17930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619900#comment-17619900 ] Ekaterina Dimitrova edited comment on CASSANDRA-17930 at 10/19/22 12:28 AM: {quote}May end up needing a CI epic to roll all this up under; seem to be quite a few moving parts. {quote} Might be not a bad idea so we can have a consolidated view and visibility, just we need people to work on all this after that :D Hopefully one epic will get people's attention and more people will join the effort. There are plenty of small and big stuff, room for everyone to chime in around our CI and Infra ;) was (Author: e.dimitrova): {quote}May end up needing a CI epic to roll all this up under; seem to be quite a few moving parts. {quote} Might be not a bad idea so we can have a consolidated view and visibility, just we need people to work on all this after that :D Hopefully one epic will get people attention and more people will join the efforts. There plenty of small and big stuff, room for everyone to chime in around our CI and Infra ;) > Ensure CircleCI and ASF Jenkins CI are aligned > -- > > Key: CASSANDRA-17930 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17930 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed in this > [thread|https://lists.apache.org/list.html?d...@cassandra.apache.org] the > Cassandra community wants to see CircleCI and ASF CI being aligned - running > the same tests, configurations, all tests. > A few examples of discrepancies we already noticed: > * utests_system_keyspace_directory run only in CircleCI - CASSANDRA-17145 > * dtest-large run only in Jenkins > * simulator tests run only in CircleCI > * In a quick skim I think I didn't see > [these|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L84-L89] > runs too in CircleCI - dtest-offheap, dtest-large, dtest-large-novnode > * packaging is also only tested in Jenkins as far as I recall > And these are only a few examples on top of my mind. I am sure we will find > more. We also need to verify the way we call those tests is correct and > matches in both CIs. (I was looking to solve similar discrepancy in > CASSANDRA-17912) > Some info on our tests suites here - > [https://cassandra.apache.org/_/development/testing.html,] > [cassandra-builds repo|https://github.com/apache/cassandra-builds] where our > test images reside and the Jenkins build scripts, which I already referred > to. > CircleCI info can be found in the readme which resides in the in-tree folder > dedicated to configuration and scripts for Circle CI - > [https://github.com/apache/cassandra/tree/trunk/.circleci] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17930) Ensure CircleCI and ASF Jenkins CI are aligned
[ https://issues.apache.org/jira/browse/CASSANDRA-17930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619900#comment-17619900 ] Ekaterina Dimitrova commented on CASSANDRA-17930: - {quote}May end up needing a CI epic to roll all this up under; seem to be quite a few moving parts. {quote} Might be not a bad idea so we can have a consolidated view and visibility, just we need people to work on all this after that :D Hopefully one epic will get people attention and more people will join the efforts. There plenty of small and big stuff, room for everyone to chime in around our CI and Infra ;) > Ensure CircleCI and ASF Jenkins CI are aligned > -- > > Key: CASSANDRA-17930 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17930 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed in this > [thread|https://lists.apache.org/list.html?d...@cassandra.apache.org] the > Cassandra community wants to see CircleCI and ASF CI being aligned - running > the same tests, configurations, all tests. > A few examples of discrepancies we already noticed: > * utests_system_keyspace_directory run only in CircleCI - CASSANDRA-17145 > * dtest-large run only in Jenkins > * simulator tests run only in CircleCI > * In a quick skim I think I didn't see > [these|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L84-L89] > runs too in CircleCI - dtest-offheap, dtest-large, dtest-large-novnode > * packaging is also only tested in Jenkins as far as I recall > And these are only a few examples on top of my mind. I am sure we will find > more. We also need to verify the way we call those tests is correct and > matches in both CIs. (I was looking to solve similar discrepancy in > CASSANDRA-17912) > Some info on our tests suites here - > [https://cassandra.apache.org/_/development/testing.html,] > [cassandra-builds repo|https://github.com/apache/cassandra-builds] where our > test images reside and the Jenkins build scripts, which I already referred > to. > CircleCI info can be found in the readme which resides in the in-tree folder > dedicated to configuration and scripts for Circle CI - > [https://github.com/apache/cassandra/tree/trunk/.circleci] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619899#comment-17619899 ] Ekaterina Dimitrova commented on CASSANDRA-17939: - Thank you for the very quick patch [~adelapena]. I can confirm those were marked in my IntelliJ with warnings "In POSIX sh, here-strings are undefined" I think we might need further updates - I am getting also "In POSIX sh, [[ ]] is undefined" on lines 211, 258, 264, 267, 270, 273, 276, 282, 286, 292, 295 (Mentioning explicitly with lines, etc as I know you mentioned your version of IDE did not show you anything. Hope this helps :) ) > CircleCI: Automatically detect and repeat new or modified JUnit tests > - > > Key: CASSANDRA-17939 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17939 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-rc, 4.2 > > Time Spent: 50m > Remaining Estimate: 0h > > The purpose of this ticket is adding a new CircleCI job that automatically > detects new or modified test classes and runs them repeatedly. That way we > wouldn't need to manually specify those tests with {{.circleci/generate.sh}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619890#comment-17619890 ] Andres de la Peña commented on CASSANDRA-17939: --- [~brandon.williams] thanks for finding that. As an alternative to use bash in the shebang, we can avoid the bashsim by using pipes instead of the here string: ||Patch|| |[3.0|https://github.com/adelapena/cassandra/tree/17939-3.0-hotfix]| |[3.11|https://github.com/adelapena/cassandra/tree/17939-3.11-hotfix]| |[4.0|https://github.com/adelapena/cassandra/tree/17939-4.0-hotfix]| |[4.1|https://github.com/adelapena/cassandra/tree/17939-4.1-hotfix]| |[trunk|https://github.com/adelapena/cassandra/tree/17939-trunk-hotfix]| > CircleCI: Automatically detect and repeat new or modified JUnit tests > - > > Key: CASSANDRA-17939 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17939 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-rc, 4.2 > > Time Spent: 50m > Remaining Estimate: 0h > > The purpose of this ticket is adding a new CircleCI job that automatically > detects new or modified test classes and runs them repeatedly. That way we > wouldn't need to manually specify those tests with {{.circleci/generate.sh}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619886#comment-17619886 ] Ekaterina Dimitrova commented on CASSANDRA-17928: - {quote}This was one of the tickets excepted on the ML with a waiver, given that it was fixed in the next release, so blocking RC on this. {quote} You are right as usual :) Thanks! > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-rc > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17967) Guardrail: allow_filtering_custom_error_message
[ https://issues.apache.org/jira/browse/CASSANDRA-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619884#comment-17619884 ] Ekaterina Dimitrova edited comment on CASSANDRA-17967 at 10/18/22 10:51 PM: [~oramad] reached out to me while I was away and I told him I think I saw already a guardrail for this but I did not have access to computer, etc at this point. I think he was looking for this functionality in 4.1(also stated in the description). So we have a few things going on here: * 4.1 is already in feature freeze, so we cannot add it there, unfortunately. But we can look into what we have in trunk - 5.0 * trunk already has added [allow_filtering_enabled|https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L1813-L1814] as part of CASSANDRA-17370. That is the one [~jmckenzie], [~smiklosovic] and I had in mind * I guess we can keep this ticket for any further enhancements (if we plan on any) and update the description, and get the ticket out of triage of course [~oramad], this is your ticket, let me know what you think :) was (Author: e.dimitrova): [~oramad] reached out to me while I was away and I told him I think I saw already a guardrail for this but I did not have access to computer, etc at this point. I think he was looking for this functionality in 4.1(also stated in the description). So we have a few things going on here: * 4.1 is already in feature freeze, so we cannot add it there, unfortunately. But we can look into what we have in trunk - 5.0 * trunk already has added [allow_filtering_enabled|https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L1813-L1814] as part of CASSANDRA-17370. That is the one [~jmckenzie], [~smiklosovic] and I had in mind * I guess we can keep this ticket for any further enhancements if we plan on any and update the description and get it out of triage of course [~oramad], this is your ticket, let me know what you think :-) > Guardrail: allow_filtering_custom_error_message > --- > > Key: CASSANDRA-17967 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17967 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails >Reporter: Sarma Pydipally >Priority: Normal > > in Apache Cassandra Release Version 4.1 : > with "allow_filtering_enabled: false" option under guardrails : > regular users cannot run queries with allow filtering clause in SELECT > commands. Users get following error message : > :1:InvalidRequest: Error from server: code=2200 [Invalid query] > message="Guardrail allow_filtering violated: Querying with ALLOW FILTERING is > not allowed" > I propose for a new parameter in conf file : something like : > allow_filtering_custom_error_message and allow cluster operators to configure > custom message > so if someone runs a SELECT command along with "ALLOW FILTERING" > it should print ERROR : InvalidRequest:code=2202:message="STOP using > allow_filtering clause" > so this will allow the operators to stop users from running allow filtering > as well as give them to configure a custom error message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17967) Guardrail: allow_filtering_custom_error_message
[ https://issues.apache.org/jira/browse/CASSANDRA-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619884#comment-17619884 ] Ekaterina Dimitrova edited comment on CASSANDRA-17967 at 10/18/22 10:50 PM: [~oramad] reached out to me while I was away and I told him I think I saw already a guardrail for this but I did not have access to computer, etc at this point. I think he was looking for this functionality in 4.1(also stated in the description). So we have a few things going on here: * 4.1 is already in feature freeze, so we cannot add it there, unfortunately. But we can look into what we have in trunk - 5.0 * trunk already has added [allow_filtering_enabled|https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L1813-L1814] as part of CASSANDRA-17370. That is the one [~jmckenzie], [~smiklosovic] and I had in mind * I guess we can keep this ticket for any further enhancements if we plan on any and update the description and get it out of triage of course [~oramad], this is your ticket, let me know what you think :-) was (Author: e.dimitrova): [~oramad] reached out to me while I was away and I told him I think I saw already a guardrail for this but I did not have access to computer, etc at this point. I think he was looking for this functionality in 4.1(also stated in the description). So we have a few things going on here: * 4.1 is already in feature freeze, so we cannot add it there, unfortunately. But we can look into what we have in trunk - 5.0 * trunk already has added allow_filtering_enabled as part of CASSANDRA-17370. That is the one [~jmckenzie], [~smiklosovic] and I had in mind * I guess we can keep this ticket for any further enhancements if we plan on any and update the description and get it out of triage of course [~oramad], this is your ticket, let me know what you think :-) > Guardrail: allow_filtering_custom_error_message > --- > > Key: CASSANDRA-17967 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17967 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails >Reporter: Sarma Pydipally >Priority: Normal > > in Apache Cassandra Release Version 4.1 : > with "allow_filtering_enabled: false" option under guardrails : > regular users cannot run queries with allow filtering clause in SELECT > commands. Users get following error message : > :1:InvalidRequest: Error from server: code=2200 [Invalid query] > message="Guardrail allow_filtering violated: Querying with ALLOW FILTERING is > not allowed" > I propose for a new parameter in conf file : something like : > allow_filtering_custom_error_message and allow cluster operators to configure > custom message > so if someone runs a SELECT command along with "ALLOW FILTERING" > it should print ERROR : InvalidRequest:code=2202:message="STOP using > allow_filtering clause" > so this will allow the operators to stop users from running allow filtering > as well as give them to configure a custom error message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17967) Guardrail: allow_filtering_custom_error_message
[ https://issues.apache.org/jira/browse/CASSANDRA-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619884#comment-17619884 ] Ekaterina Dimitrova commented on CASSANDRA-17967: - [~oramad] reached out to me while I was away and I told him I think I saw already a guardrail for this but I did not have access to computer, etc at this point. I think he was looking for this functionality in 4.1(also stated in the description). So we have a few things going on here: * 4.1 is already in feature freeze, so we cannot add it there, unfortunately. But we can look into what we have in trunk - 5.0 * trunk already has added allow_filtering_enabled as part of CASSANDRA-17370. That is the one [~jmckenzie], [~smiklosovic] and I had in mind * I guess we can keep this ticket for any further enhancements if we plan on any and update the description and get it out of triage of course [~oramad], this is your ticket, let me know what you think :-) > Guardrail: allow_filtering_custom_error_message > --- > > Key: CASSANDRA-17967 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17967 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails >Reporter: Sarma Pydipally >Priority: Normal > > in Apache Cassandra Release Version 4.1 : > with "allow_filtering_enabled: false" option under guardrails : > regular users cannot run queries with allow filtering clause in SELECT > commands. Users get following error message : > :1:InvalidRequest: Error from server: code=2200 [Invalid query] > message="Guardrail allow_filtering violated: Querying with ALLOW FILTERING is > not allowed" > I propose for a new parameter in conf file : something like : > allow_filtering_custom_error_message and allow cluster operators to configure > custom message > so if someone runs a SELECT command along with "ALLOW FILTERING" > it should print ERROR : InvalidRequest:code=2202:message="STOP using > allow_filtering clause" > so this will allow the operators to stop users from running allow filtering > as well as give them to configure a custom error message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619880#comment-17619880 ] Brandon Williams commented on CASSANDRA-17939: -- Note: this introduced some bash-dependent syntax: {quote} $ .circleci/generate.sh -m Generating new config.yml file with middle resources from config-2_1.yml patching file .circleci/config-2_1.yml.MIDRES (read from .circleci/config-2_1.yml) .circleci/generate.sh: 209: Syntax error: redirection unexpected {quote} This is perfectly fine but the shebang in generate.sh points to /bin/sh, which may not be bash on all systems. > CircleCI: Automatically detect and repeat new or modified JUnit tests > - > > Key: CASSANDRA-17939 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17939 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-rc, 4.2 > > Time Spent: 50m > Remaining Estimate: 0h > > The purpose of this ticket is adding a new CircleCI job that automatically > detects new or modified test classes and runs them repeatedly. That way we > wouldn't need to manually specify those tests with {{.circleci/generate.sh}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17928: - Discovered By: Unit Test (was: DTest) > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-rc > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17928: - Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: DTest Severity: Normal Status: Open (was: Triage Needed) > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-rc > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619817#comment-17619817 ] Brandon Williams commented on CASSANDRA-17928: -- bq. Whether this is a beta/rc blocker I don't know. This was one of the tickets excepted on the ML with a waiver, given that it was fixed in the next release, so blocking RC on this. > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-rc > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17928: - Fix Version/s: 4.1-rc (was: 4.1-beta) > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-rc > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17967) Guardrail: allow_filtering_custom_error_message
[ https://issues.apache.org/jira/browse/CASSANDRA-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619809#comment-17619809 ] Stefan Miklosovic commented on CASSANDRA-17967: --- +1 to what [~jmckenzie] says. This might be also used for upcoming password guardrail (if we happen to implement it) to put there some emails to security folks etc or something custom completely (links to docs about password policies etc). > Guardrail: allow_filtering_custom_error_message > --- > > Key: CASSANDRA-17967 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17967 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails >Reporter: Sarma Pydipally >Priority: Normal > > in Apache Cassandra Release Version 4.1 : > with "allow_filtering_enabled: false" option under guardrails : > regular users cannot run queries with allow filtering clause in SELECT > commands. Users get following error message : > :1:InvalidRequest: Error from server: code=2200 [Invalid query] > message="Guardrail allow_filtering violated: Querying with ALLOW FILTERING is > not allowed" > I propose for a new parameter in conf file : something like : > allow_filtering_custom_error_message and allow cluster operators to configure > custom message > so if someone runs a SELECT command along with "ALLOW FILTERING" > it should print ERROR : InvalidRequest:code=2202:message="STOP using > allow_filtering clause" > so this will allow the operators to stop users from running allow filtering > as well as give them to configure a custom error message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17967) Guardrail: allow_filtering_custom_error_message
[ https://issues.apache.org/jira/browse/CASSANDRA-17967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619807#comment-17619807 ] Josh McKenzie commented on CASSANDRA-17967: --- I think the question you're really pointing to is: Should we augment the Guardrails framework to allow operators to specify custom error messages? [~adelapena] - have you given this any thought? My initial reaction is that yeah, this is probably pretty useful. Being able to have an error message that says something like "Feature X is disabled because it causes problems Y. Email with your cluster name and use-case if you would like to apply for a specific exception" or something could be pretty useful. > Guardrail: allow_filtering_custom_error_message > --- > > Key: CASSANDRA-17967 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17967 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails >Reporter: Sarma Pydipally >Priority: Normal > > in Apache Cassandra Release Version 4.1 : > with "allow_filtering_enabled: false" option under guardrails : > regular users cannot run queries with allow filtering clause in SELECT > commands. Users get following error message : > :1:InvalidRequest: Error from server: code=2200 [Invalid query] > message="Guardrail allow_filtering violated: Querying with ALLOW FILTERING is > not allowed" > I propose for a new parameter in conf file : something like : > allow_filtering_custom_error_message and allow cluster operators to configure > custom message > so if someone runs a SELECT command along with "ALLOW FILTERING" > it should print ERROR : InvalidRequest:code=2202:message="STOP using > allow_filtering clause" > so this will allow the operators to stop users from running allow filtering > as well as give them to configure a custom error message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16357) Add Unavailables metric for CASWrite
[ https://issues.apache.org/jira/browse/CASSANDRA-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619806#comment-17619806 ] David Capwell commented on CASSANDRA-16357: --- +1 > Add Unavailables metric for CASWrite > > > Key: CASSANDRA-16357 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16357 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Adelina Vidovici >Assignee: Natnael Adere >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > "Unavailables" is a metric that is available for all types of operations: > * CASRead, Read, CASWrite, Write > In the documentation, the Unavailables for CASWrite and it should be added. > [https://cassandra.apache.org/doc/latest/operating/metrics.html] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16357) Add Unavailables metric for CASWrite
[ https://issues.apache.org/jira/browse/CASSANDRA-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16357: -- Reviewers: David Capwell Status: Review In Progress (was: Patch Available) > Add Unavailables metric for CASWrite > > > Key: CASSANDRA-16357 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16357 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Adelina Vidovici >Assignee: Natnael Adere >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > "Unavailables" is a metric that is available for all types of operations: > * CASRead, Read, CASWrite, Write > In the documentation, the Unavailables for CASWrite and it should be added. > [https://cassandra.apache.org/doc/latest/operating/metrics.html] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17912) Fix CircleCI config for running Python upgrade tests on 3.0 and 3.11
[ https://issues.apache.org/jira/browse/CASSANDRA-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17912: Reviewers: Michael Semb Wever (was: Ekaterina Dimitrova, Michael Semb Wever) > Fix CircleCI config for running Python upgrade tests on 3.0 and 3.11 > > > Key: CASSANDRA-17912 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17912 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > It was noticed that Circle CI pushes to run irrelevant for 3.0 and 3.11 > Python upgrade tests. Those are properly skipped in Jenkins. > Example runs: > [CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231/jobs/15293] > - 3.0 run > [Jenkins|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/] > - while typing this I actually noticed [one > test|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/testReport/junit/dtest-upgrade.upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD/test_parallel_upgrade_with_internode_ssl/] > only looking suspicious in Jenkins as it ends the upgrade in 3.11 when we > test 3.0... > This is good to be fixed for two reasons - reduce the noise so we do not miss > legit failures and we should not spend resources to try to run those tests. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17912) Fix CircleCI config for running Python upgrade tests on 3.0 and 3.11
[ https://issues.apache.org/jira/browse/CASSANDRA-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17912: Reviewers: Michael Semb Wever, Ekaterina Dimitrova Michael Semb Wever, Ekaterina Dimitrova (was: Ekaterina Dimitrova, Michael Semb Wever) Status: Review In Progress (was: Patch Available) > Fix CircleCI config for running Python upgrade tests on 3.0 and 3.11 > > > Key: CASSANDRA-17912 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17912 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > It was noticed that Circle CI pushes to run irrelevant for 3.0 and 3.11 > Python upgrade tests. Those are properly skipped in Jenkins. > Example runs: > [CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231/jobs/15293] > - 3.0 run > [Jenkins|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/] > - while typing this I actually noticed [one > test|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/testReport/junit/dtest-upgrade.upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD/test_parallel_upgrade_with_internode_ssl/] > only looking suspicious in Jenkins as it ends the upgrade in 3.11 when we > test 3.0... > This is good to be fixed for two reasons - reduce the noise so we do not miss > legit failures and we should not spend resources to try to run those tests. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17921) Harden JMX by resolving beanshooter issues
[ https://issues.apache.org/jira/browse/CASSANDRA-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17921: --- Fix Version/s: 3.0.28 3.11.14 4.0.7 4.1-beta2 4.1 4.2 (was: 3.0.x) (was: 4.x) (was: 3.11.x) (was: 4.0.x) (was: 4.1.x) Since Version: 3.0 alpha 1 Source Control Link: https://github.com/apache/cassandra/commit/b2660bcf78ccf08a3a0ae39a8c9ffb397efef9ff Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [b2660bcf78ccf08a3a0ae39a8c9ffb397efef9ff|https://github.com/apache/cassandra/commit/b2660bcf78ccf08a3a0ae39a8c9ffb397efef9ff]. > Harden JMX by resolving beanshooter issues > -- > > Key: CASSANDRA-17921 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17921 > Project: Cassandra > Issue Type: Bug > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-beta2, 4.1, 4.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (6b0cd7db04 -> 95d0a936f9)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 6b0cd7db04 Merge branch 'cassandra-3.0' into cassandra-3.11 new b2660bcf78 Fix JMX security vulnerabilities new 95d0a936f9 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit fbb3079144851e704a7912b8630f72c9345e0bb5 Merge: 0aa4ef1a8e 9a24fa81e5 Author: Mick Semb Wever AuthorDate: Tue Oct 18 22:54:11 2022 +0200 Merge branch 'cassandra-4.0' into cassandra-4.1 * cassandra-4.0: Fix JMX security vulnerabilities CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index d5a1ce2416,19fe614a29..ed8ea6eea5 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -7,46 -5,22 +7,47 @@@ Merged from 4.0 Merged from 3.11: * Suppress CVE-2022-42003 and CVE-2022-42004 (CASSANDRA-17966) * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) - * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) - * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) Merged from 3.0: + * Harden JMX by resolving beanshooter issues (CASSANDRA-17921) * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) - * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) - * Fix resetting schema (CASSANDRA-17819) -4.0.6 +4.1-beta1 + * We should not emit deprecation warning on startup for `key_cache_save_period`, `row_cache_save_period`, `counter_cache_save_period` (CASSANDRA-17904) + * upsert with adder support is not consistent with numbers and strings in LWT (CASSANDRA-17857) + * Fix race and return after failing connections (CASSANDRA-17618) + * Speculative execution threshold unit mismatch (CASSANDRA-17877) + * Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle (CASSANDRA-17677) + * Fix a race condition where a keyspace can be oopened while it is being removed (CASSANDRA-17658) + * DatabaseDescriptor will set the default failure detector during client initialization (CASSANDRA-17782) + * Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool (CASSANDRA-17740) + * Improve JMX methods signatures, fix JMX and config backward compatibility (CASSANDRA-17725) + * Fix sstable_preemptive_open_interval disabled value. sstable_preemptive_open_interval = null backward compatible with + sstable_preemptive_open_interval_in_mb = -1 (CASSANDRA-17737) + * Remove usages of Path#toFile() in the snapshot apparatus (CASSANDRA-17769) + * Fix Settings Virtual Table to update paxos_variant after startup and rename enable_uuid_sstable_identifiers to + uuid_sstable_identifiers_enabled as per our config naming conventions (CASSANDRA-17738) + * index_summary_resize_interval_in_minutes = -1 is equivalent to index_summary_resize_interval being set to null or + disabled. JMX MBean IndexSummaryManager, setResizeIntervalInMinutes method still takes resizeIntervalInMinutes = -1 for disabled (CASSANDRA-17735) + * min_tracked_partition_size_bytes parameter from 4.1 alpha1 was renamed to min_tracked_partition_size (CASSANDRA-17733) + * Remove commons-lang dependency during build runtime (CASSANDRA-17724) + * Relax synchronization on StreamSession#onError() to avoid deadlock (CASSANDRA-17706) + * Fix AbstractCell#toString throws MarshalException for cell in collection (CASSANDRA-17695) + * Add new vtable output option to compactionstats (CASSANDRA-17683) + * Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog (CASSANDRA-17587) + * Fix widening to long in getBatchSizeFailThreshold (CASSANDRA-17650) + * Fix widening from mebibytes to bytes in IntMebibytesBound (CASSANDRA-17716) + * Revert breaking change in nodetool clientstats and expose cient options through nodetool clientstats --client-options. (CASSANDRA-17715) + * Fix missed nowInSec values in QueryProcessor (CASSANDRA-17458) + * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Builder class and deprecate it in favor of withBufferSizeInMiB(int size) (CASSANDRA-17675) + * Remove expired snapshots of dropped tables after restart (CASSANDRA-17619) +Merged from 4.0: + * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895) + * Fix repair failure on assertion if two peers have overlapping mismatching ranges (CASSANDRA-17900) + * Better handle null state in Gossip schema migration to avoid NPE (CASSANDRA-17864) + * HintedHandoffAddRemoveNodesTest now accounts for the fact that StorageMetrics.totalHints is not updated synchronously w/ writes (CASSANDRA-16679) + * Avoid getting hanging repairs due to repair message timeouts (CASSANDRA-17613) + * Prevent infinite loop in repair coordinator on FailSession (CASSANDRA-17834) * Fix
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit b0ae3de1c91fbdb8bb50a129d0114ea3b9fea2df Merge: a62f618b08 fbb3079144 Author: Mick Semb Wever AuthorDate: Tue Oct 18 22:56:53 2022 +0200 Merge branch 'cassandra-4.1' into trunk * cassandra-4.1: Fix JMX security vulnerabilities CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 96e3702566,ed8ea6eea5..f040d17477 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -124,8 -69,6 +124,9 @@@ Merged from 3.11 * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) Merged from 3.0: ++ * Harden JMX by resolving beanshooter issues (CASSANDRA-17921) + * Suppress CVE-2019-2684 (CASSANDRA-17965) + * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Improve libjemalloc resolution in bin/cassandra (CASSANDRA-15767) * Fix restarting of services on gossipping-only member (CASSANDRA-17752) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) diff --cc ide/idea/workspace.xml index 321edd8024,8851d7e283..a89921cc77 --- a/ide/idea/workspace.xml +++ b/ide/idea/workspace.xml @@@ -187,7 -187,7 +187,7 @@@ - ++ - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Fix JMX security vulnerabilities
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-3.0 by this push: new b2660bcf78 Fix JMX security vulnerabilities b2660bcf78 is described below commit b2660bcf78ccf08a3a0ae39a8c9ffb397efef9ff Author: Abe Ratnofsky AuthorDate: Tue Aug 30 15:23:26 2022 -0700 Fix JMX security vulnerabilities patch by Abe Ratnofsky; reviewed by Jon Meredith, Mick Semb Wever, Sam Tunnicliffe for CASSANDRA-17921 --- CHANGES.txt| 1 + conf/cassandra-env.sh | 4 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 170 + .../apache/cassandra/service/CassandraDaemon.java | 28 5 files changed, 204 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 7dd28c8a84..799d0b11d9 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0.28 + * Harden JMX by resolving beanshooter issues (CASSANDRA-17921) * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) diff --git a/conf/cassandra-env.sh b/conf/cassandra-env.sh index 016e592a9f..a5ac96c6c5 100644 --- a/conf/cassandra-env.sh +++ b/conf/cassandra-env.sh @@ -294,6 +294,10 @@ if [ "x$LOCAL_JMX" = "x" ]; then LOCAL_JMX=yes fi +## Cassandra also ships with a helper for protecting against security gaps in a default JMX configuration. To use it, +## uncomment line below. +#JVM_OPTS="$JVM_OPTS -Dcassandra.jmx.authorizer=org.apache.cassandra.auth.jmx.AuthorizationProxy" + # Specifies the default port over which Cassandra will be available for # JMX connections. # For security reasons, you should not expose this port to the internet. Firewall it if needed. diff --git a/ide/idea/workspace.xml b/ide/idea/workspace.xml index 4a7a5c9028..a3fda6ac5d 100644 --- a/ide/idea/workspace.xml +++ b/ide/idea/workspace.xml @@ -188,7 +188,7 @@ - diff --git a/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java b/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java new file mode 100644 index 00..65f7d20202 --- /dev/null +++ b/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.auth.jmx; + +import java.lang.reflect.*; +import java.security.AccessControlContext; +import java.security.AccessController; +import javax.management.InstanceNotFoundException; +import javax.management.MBeanServer; +import javax.management.ObjectName; +import javax.security.auth.Subject; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Provides a proxy interface to the platform's MBeanServer instance to perform minimal authorization and prevent + * certain known security issues. In Cassandra 3.11+, this goes even further to include resource-based authorization + * controls. + * + * Certain operations are never allowed for users and these are recorded in a deny list so that we can short circuit + * authorization process if one is attempted by a remote subject. + */ +public class AuthorizationProxy implements InvocationHandler +{ +private static final Logger logger = LoggerFactory.getLogger(AuthorizationProxy.class); + +private MBeanServer mbs; + +@Override +public Object invoke(Object proxy, Method method, Object[] args) +throws Throwable +{ +String methodName = method.getName(); + +if ("getMBeanServer".equals(methodName)) +throw new SecurityException("Access denied"); + +// Corresponds to MBeanServer.invoke +if (methodName.equals("invoke") && args.length == 4) +checkVulnerableMethods(args); + +// Retrieve Subject from current AccessControlContext +AccessControlContext acc =
[cassandra] branch cassandra-4.0 updated (a124f099e0 -> 9a24fa81e5)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from a124f099e0 Merge branch 'cassandra-3.11' into cassandra-4.0 new b2660bcf78 Fix JMX security vulnerabilities new 95d0a936f9 Merge branch 'cassandra-3.0' into cassandra-3.11 new 9a24fa81e5 Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 9a24fa81e5f44476c9994b9d9a7aabf9b89f3f8b Merge: a124f099e0 95d0a936f9 Author: Mick Semb Wever AuthorDate: Tue Oct 18 22:53:05 2022 +0200 Merge branch 'cassandra-3.11' into cassandra-4.0 * cassandra-3.11: Fix JMX security vulnerabilities CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index d85f0c5357,3e0ab807ec..19fe614a29 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -13,7 -3,11 +13,8 @@@ Merged from 3.11 * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) - * Document usage of closed token intervals in manual compaction (CASSANDRA-17575) - * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) - * Only use statically defined subcolumns when determining column definition for supercolumn cell (CASSANDRA-14113) Merged from 3.0: + * Harden JMX by resolving beanshooter issues (CASSANDRA-17921) * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) diff --cc src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java index 68cff0c12d,f2665085f3..36c552c700 --- a/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java +++ b/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java @@@ -23,10 -23,10 +23,11 @@@ import java.security.AccessControlConte import java.security.AccessController; import java.security.Principal; import java.util.Set; +import java.util.function.BooleanSupplier; import java.util.function.Function; -import java.util.function.Supplier; +import java.util.function.Predicate; import java.util.stream.Collectors; + import javax.management.InstanceNotFoundException; import javax.management.MBeanServer; import javax.management.MalformedObjectNameException; import javax.management.ObjectName; - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (0aa4ef1a8e -> fbb3079144)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 0aa4ef1a8e Merge branch 'cassandra-4.0' into cassandra-4.1 new b2660bcf78 Fix JMX security vulnerabilities new 95d0a936f9 Merge branch 'cassandra-3.0' into cassandra-3.11 new 9a24fa81e5 Merge branch 'cassandra-3.11' into cassandra-4.0 new fbb3079144 Merge branch 'cassandra-4.0' into cassandra-4.1 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 95d0a936f9611e6c43b79f6e4ba470c27d384567 Merge: 6b0cd7db04 b2660bcf78 Author: Mick Semb Wever AuthorDate: Tue Oct 18 22:49:07 2022 +0200 Merge branch 'cassandra-3.0' into cassandra-3.11 * cassandra-3.0: Fix JMX security vulnerabilities CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 830dca3b50,799d0b11d9..3e0ab807ec --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,12 -1,5 +1,13 @@@ -3.0.28 +3.11.14 + * Suppress CVE-2022-42003 and CVE-2022-42004 (CASSANDRA-17966) + * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) + * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) + * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) + * Document usage of closed token intervals in manual compaction (CASSANDRA-17575) + * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) + * Only use statically defined subcolumns when determining column definition for supercolumn cell (CASSANDRA-14113) +Merged from 3.0: + * Harden JMX by resolving beanshooter issues (CASSANDRA-17921) * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) diff --cc ide/idea/workspace.xml index 6c6eb69e68,a3fda6ac5d..f98c858f72 --- a/ide/idea/workspace.xml +++ b/ide/idea/workspace.xml @@@ -186,7 -188,7 +186,7 @@@ - ++ diff --cc src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java index ebc1763cce,65f7d20202..f2665085f3 --- a/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java +++ b/src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java @@@ -21,13 -21,8 +21,14 @@@ package org.apache.cassandra.auth.jmx import java.lang.reflect.*; import java.security.AccessControlContext; import java.security.AccessController; +import java.security.Principal; +import java.util.Set; +import java.util.function.Function; +import java.util.function.Supplier; +import java.util.stream.Collectors; + import javax.management.InstanceNotFoundException; import javax.management.MBeanServer; +import javax.management.MalformedObjectNameException; import javax.management.ObjectName; import javax.security.auth.Subject; @@@ -457,37 -103,68 +462,102 @@@ public class AuthorizationProxy impleme } } +/** + * Query the configured IAuthorizer for the set of all permissions granted on JMXResources to a specific subject + * @param subject + * @return All permissions granted to the specfied subject (including those transitively inherited from + * any roles the subject has been granted), filtered to include only permissions granted on + * JMXResources + */ +private static Set loadPermissions(RoleResource subject) +{ +// get all permissions for the specified subject. We'll cache them as it's likely +// we'll receive multiple lookups for the same subject (but for different resources +// and permissions) in quick succession +return DatabaseDescriptor.getAuthorizer().list(AuthenticatedUser.SYSTEM_USER, Permission.ALL, null, subject) + .stream() + .filter(details -> details.resource instanceof JMXResource) + .collect(Collectors.toSet()); +} + + private void checkVulnerableMethods(Object args[]) + { + assert args.length == 4; + ObjectName name; + String operationName; + Object[] params; + String[] signature; + try + { + name = (ObjectName) args[0]; + operationName = (String) args[1]; + params = (Object[]) args[2]; + signature = (String[]) args[3]; + } + catch (ClassCastException cce) + { + logger.warn("Could not interpret arguments to check vulnerable MBean invocations; did the MBeanServer interface change?", cce); + return; + } + + // When adding compiler directives from a file, most JDKs will log the file contents if invalid, which + // leads to an arbitrary file read vulnerability + checkCompilerDirectiveAddMethods(name, operationName); + + // Loading arbitrary (JVM
[cassandra] branch trunk updated (a62f618b08 -> b0ae3de1c9)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from a62f618b08 Merge branch 'cassandra-4.1' into trunk new b2660bcf78 Fix JMX security vulnerabilities new 95d0a936f9 Merge branch 'cassandra-3.0' into cassandra-3.11 new 9a24fa81e5 Merge branch 'cassandra-3.11' into cassandra-4.0 new fbb3079144 Merge branch 'cassandra-4.0' into cassandra-4.1 new b0ae3de1c9 Merge branch 'cassandra-4.1' into trunk The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + ide/idea/workspace.xml | 2 +- .../cassandra/auth/jmx/AuthorizationProxy.java | 70 ++ 3 files changed, 72 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619799#comment-17619799 ] Ekaterina Dimitrova commented on CASSANDRA-17928: - [~bereng] I didn't have the chance to work on this one, I only pushed repeated runs before I went off so we can see on which branches it fails, wether it is regression, etc. That is why I also didn't assign it as I am not actively working on it or familiar with the test. With that said I wouldn't advocate for closing it as environmental issue without explanation just because it is hard to reproduce. We have a bunch of examples of legitimate bugs fixed from tests that were super rarely failing. But as I said, I don't know the details in this case so I will leave the decision to whoever assigns it and spends the time to figure out the details. Whether this is a beta/rc blocker I don't know. I think it was Josh assigning version here when opening the ticket. > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-beta > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[ https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619799#comment-17619799 ] Ekaterina Dimitrova edited comment on CASSANDRA-17928 at 10/18/22 9:24 PM: --- [~bereng] I didn't have the chance to work on this one, I only pushed repeated runs before I went off so we can see on which branches it fails, whether it is regression, etc. That is why I also didn't assign it as I am not actively working on it or familiar with the test. With that said I wouldn't advocate for closing it as environmental issue without explanation just because it is hard to reproduce. We have a bunch of examples of legitimate bugs fixed from tests that were super rarely failing. But as I said, I don't know the details in this case so I will leave the decision to whoever assigns it and spends the time to figure out the details. Whether this is a beta/rc blocker I don't know. I think it was Josh assigning version here when opening the ticket. was (Author: e.dimitrova): [~bereng] I didn't have the chance to work on this one, I only pushed repeated runs before I went off so we can see on which branches it fails, wether it is regression, etc. That is why I also didn't assign it as I am not actively working on it or familiar with the test. With that said I wouldn't advocate for closing it as environmental issue without explanation just because it is hard to reproduce. We have a bunch of examples of legitimate bugs fixed from tests that were super rarely failing. But as I said, I don't know the details in this case so I will leave the decision to whoever assigns it and spends the time to figure out the details. Whether this is a beta/rc blocker I don't know. I think it was Josh assigning version here when opening the ticket. > Test Failure: > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression > - > > Key: CASSANDRA-17928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17928 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.1-beta > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/] > Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92% > Stacktrace > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > {code:java} > Standard Output > INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took > 1221 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took > 907 ms to scan 8 urls, producing 1756 keys and 6922 values > INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 - > Configuration location: > file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml > DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader > ...[truncated 35568 chars]... > .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155) > at > org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17962) Test Failure: UnavailableSocketErrors: Local socket binding errors showing up intermittently in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619794#comment-17619794 ] Josh McKenzie commented on CASSANDRA-17962: --- Not looking to block any releases on this, just get a ticket so if it gets worse we have a bit of a trail. > Test Failure: UnavailableSocketErrors: Local socket binding errors showing up > intermittently in tests > - > > Key: CASSANDRA-17962 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17962 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Josh McKenzie >Priority: Normal > > {code} > ccmlib.common.UnavailableSocketError: Inet address 127.0.0.2:7000 is not > available: [Errno 98] Address already in use; a cluster may already be > running or you may need to add the loopback alias > {code} > This keeps popping up in a variety of tests: > [https://ci-cassandra.apache.org/job/Cassandra-4.1/181/testReport/dtest-offheap.paging_test/TestPagingData/test_paging_with_filtering_on_partition_key_on_static_columns/] > [https://ci-cassandra.apache.org/job/Cassandra-4.1/181/testReport/dtest-offheap.seed_test/TestGossiper/test_startup_after_ring_delay/] > [https://ci-cassandra.apache.org/job/Cassandra-4.1/181/testReport/dtest-offheap.replication_test/TestSnitchConfigurationUpdate/test_rf_collapse_property_file_snitch/] > This stems from ccm in common.py: > {code:java} > itf = ('127.0.0.2', 7000) > def assert_socket_available(itf): > info = socket.getaddrinfo(itf[0], itf[1], socket.AF_UNSPEC, > socket.SOCK_STREAM) > if not info: > raise UnavailableSocketError("Failed to get address info for > [%s]:%s" % itf) > > (family, socktype, proto, canonname, sockaddr) = info[0] > s = socket.socket(family, socktype) > s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) > > try: > > s.bind(sockaddr) > E OSError: [Errno 98] Address already in use {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17961) Bad format for JMX metrics page in documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-17961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie reassigned CASSANDRA-17961: - Assignee: Jerome BAROTIN > Bad format for JMX metrics page in documentation > - > > Key: CASSANDRA-17961 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17961 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Jerome BAROTIN >Assignee: Jerome BAROTIN >Priority: Normal > > Hi, > The page metrics in documentation is pretty hard to read : > [https://cassandra.apache.org/doc/4.1/cassandra/operating/metrics.html] > > Here it is the PR that correct that : > [https://github.com/apache/cassandra/pull/1909] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17753) Include GitSHA in nodetool version output
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619787#comment-17619787 ] Stefan Miklosovic commented on CASSANDRA-17753: --- hi [~aratnofsky] , if you dont mind I might take a look. Could you brief me about where we are ? I guess pretty close? > Include GitSHA in nodetool version output > - > > Key: CASSANDRA-17753 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17753 > Project: Cassandra > Issue Type: New Feature > Components: Tool/nodetool >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.x > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It can be useful to see specifically which Git SHA a running instance of > Cassandra was built with, especially when running clusters in development for > soak testing. > > I have a patch ready for this, and am preparing it now. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17753) Include GitSHA in nodetool version output
[ https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17753: -- Reviewers: Brandon Williams, Caleb Rackliffe, Michael Semb Wever, Stefan Miklosovic (was: Brandon Williams, Caleb Rackliffe, Michael Semb Wever) > Include GitSHA in nodetool version output > - > > Key: CASSANDRA-17753 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17753 > Project: Cassandra > Issue Type: New Feature > Components: Tool/nodetool >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.x > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It can be useful to see specifically which Git SHA a running instance of > Cassandra was built with, especially when running clusters in development for > soak testing. > > I have a patch ready for this, and am preparing it now. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17921) Harden JMX by resolving beanshooter issues
[ https://issues.apache.org/jira/browse/CASSANDRA-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17921: --- Test and Documentation Plan: circleci and jenkins Status: Patch Available (was: In Progress) > Harden JMX by resolving beanshooter issues > -- > > Key: CASSANDRA-17921 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17921 > Project: Cassandra > Issue Type: Bug > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17921) Harden JMX by resolving beanshooter issues
[ https://issues.apache.org/jira/browse/CASSANDRA-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17921: --- Reviewers: Jon Meredith, Michael Semb Wever, Sam Tunnicliffe, Michael Semb Wever (was: Jon Meredith, Michael Semb Wever, Sam Tunnicliffe) Jon Meredith, Michael Semb Wever, Sam Tunnicliffe, Michael Semb Wever (was: Jon Meredith, Michael Semb Wever, Sam Tunnicliffe) Status: Review In Progress (was: Patch Available) > Harden JMX by resolving beanshooter issues > -- > > Key: CASSANDRA-17921 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17921 > Project: Cassandra > Issue Type: Bug > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17921) Harden JMX by resolving beanshooter issues
[ https://issues.apache.org/jira/browse/CASSANDRA-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17921: --- Status: Ready to Commit (was: Review In Progress) > Harden JMX by resolving beanshooter issues > -- > > Key: CASSANDRA-17921 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17921 > Project: Cassandra > Issue Type: Bug > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17921) Harden JMX by resolving beanshooter issues
[ https://issues.apache.org/jira/browse/CASSANDRA-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17921: --- Fix Version/s: 3.0.x 3.11.x 4.0.x 4.1.x 4.x > Harden JMX by resolving beanshooter issues > -- > > Key: CASSANDRA-17921 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17921 > Project: Cassandra > Issue Type: Bug > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17971: Fix Version/s: 5.x > Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra > > > Key: CASSANDRA-17971 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17971 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we > need to revise it again before we switch fro jdk8&11 to jdk11&17 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17971: Component/s: Feature/UDF > Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra > > > Key: CASSANDRA-17971 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17971 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Priority: Normal > > In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we > need to revise it again before we switch fro jdk8&11 to jdk11&17 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17971: Change Category: Operability Complexity: Normal Component/s: Build Dependencies Status: Open (was: Triage Needed) > Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra > > > Key: CASSANDRA-17971 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17971 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies >Reporter: Ekaterina Dimitrova >Priority: Normal > > In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we > need to revise it again before we switch fro jdk8&11 to jdk11&17 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
Ekaterina Dimitrova created CASSANDRA-17971: --- Summary: Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra Key: CASSANDRA-17971 URL: https://issues.apache.org/jira/browse/CASSANDRA-17971 Project: Cassandra Issue Type: Task Reporter: Ekaterina Dimitrova In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we need to revise it again before we switch fro jdk8&11 to jdk11&17 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17921) Harden JMX by resolving beanshooter issues
[ https://issues.apache.org/jira/browse/CASSANDRA-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17921: --- Description: (was: …) > Harden JMX by resolving beanshooter issues > -- > > Key: CASSANDRA-17921 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17921 > Project: Cassandra > Issue Type: Bug > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Abe Ratnofsky >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619772#comment-17619772 ] Ekaterina Dimitrova commented on CASSANDRA-17873: - Pushed rebased all branches to CI: ||Branch||CI run|| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/tree/17873-4.0]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-4.0] #1977 is the full CI run| |[4.1|https://github.com/ekaterinadimitrova2/cassandra/tree/17873-4.1]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-4.1] #1978 is the full CI run| |[trunk|https://github.com/ekaterinadimitrova2/cassandra/tree/17873-trunk]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-trunk] #1979 is the full CI run| Commit pending CI results > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (823fdde6a -> bcc156d72)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 823fdde6a generate docs for e5cbbab6 new bcc156d72 generate docs for e5cbbab6 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (823fdde6a) \ N -- N -- N refs/heads/asf-staging (bcc156d72) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../configuration/cass_logback_xml_file.html | 40 - .../configuration/cass_logback_xml_file.html | 40 - site-ui/build/ui-bundle.zip| Bin 4746711 -> 4746711 bytes 3 files changed, 78 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17934) Add --resolve-ip option on 'nodetool gossipinfo'
[ https://issues.apache.org/jira/browse/CASSANDRA-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17934: -- Fix Version/s: 4.x > Add --resolve-ip option on 'nodetool gossipinfo' > > > Key: CASSANDRA-17934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17934 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Maxim Chanturiay >Priority: Normal > Labels: lhf > Fix For: 4.x > > > Give nodetool gossipinfo the option of either displaying IPs or hostnames for > the nodes in a ring. > Note: this option is already present for "nodetool status" and "nodetool ring" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619707#comment-17619707 ] Ekaterina Dimitrova edited comment on CASSANDRA-17873 at 10/18/22 5:07 PM: --- {quote}I don't have a mental map of ASM version to Java version unfortunately, just wanted to check it had been confirmed. {quote} Same here and I looked into this like almost two months ago, appreciate you chiming in here! I am struggling to find official doc now on the opcodes and the Javadoc was not helpful but looking back into the Opcodes interface itself what I remembered is [ASM7 corresponds to minimum required ASM version|https://github.com/consulo/objectweb-asm/blob/master/asm/src/main/java/org/objectweb/asm/Opcodes.java#L44] which will support the jdk versions we need and 11 started official support in ASM7 as per the [changelog|https://asm.ow2.io/versions.html]. If we want to provide opcode for particular JDK then we use the [V* opcodes|https://github.com/consulo/objectweb-asm/blob/master/asm/src/main/java/org/objectweb/asm/Opcodes.java#L268]. I hope I didn't somehow misunderstood this. Also, we will need to bump this further when we commit the JDK17 support bits, I keep a note on that myself. Which reminds me I might have to talk to you [~benedict] about the jdk17 and the simulator so I do not miss anything there but I am not there yet. {quote}In that case it's fine, yes :) {quote} Thanks for confirming, I will add you both reviewers then :) I will rebase and rerun CI pre-commit as it has been a while. was (Author: e.dimitrova): {quote}I don't have a mental map of ASM version to Java version unfortunately, just wanted to check it had been confirmed. {quote} Same here and I looked into this like almost two months ago, appreciate you chiming in here! I am struggling to find official doc now on the opcodes and the Javadoc was not helpful but looking back into the Opcodes interface itself what I remembered is [ASM7 corresponds to minimum required ASM version|https://github.com/consulo/objectweb-asm/blob/master/asm/src/main/java/org/objectweb/asm/Opcodes.java#L44] which will support the jdk versions we need and 11 started official support in ASM7 as per the [changelog|https://asm.ow2.io/versions.html]. If we want to provide opcode for particular JDK then we use the V* opcodes. I hope I didn't somehow misunderstood this. Also, we will need to bump this further when we commit the JDK17 support bits, I keep a note on that myself. Which reminds me I might have to talk to you [~benedict] about the jdk17 and the simulator so I do not miss anything there but I am not there yet. {quote}In that case it's fine, yes :) {quote} Thanks for confirming, I will add you both reviewers then :) I will rebase and rerun CI pre-commit as it has been a while. > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17934) Add --resolve-ip option on 'nodetool gossipinfo'
[ https://issues.apache.org/jira/browse/CASSANDRA-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17934: -- Reviewers: Stefan Miklosovic Status: Review In Progress (was: Patch Available) > Add --resolve-ip option on 'nodetool gossipinfo' > > > Key: CASSANDRA-17934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17934 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Maxim Chanturiay >Priority: Normal > Labels: lhf > > Give nodetool gossipinfo the option of either displaying IPs or hostnames for > the nodes in a ring. > Note: this option is already present for "nodetool status" and "nodetool ring" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17873: Authors: Benedict Elliott Smith, Berenguer Blasi (was: Ekaterina Dimitrova) > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619707#comment-17619707 ] Ekaterina Dimitrova commented on CASSANDRA-17873: - {quote}I don't have a mental map of ASM version to Java version unfortunately, just wanted to check it had been confirmed. {quote} Same here and I looked into this like almost two months ago, appreciate you chiming in here! I am struggling to find official doc now on the opcodes and the Javadoc was not helpful but looking back into the Opcodes interface itself what I remembered is [ASM7 corresponds to minimum required ASM version|https://github.com/consulo/objectweb-asm/blob/master/asm/src/main/java/org/objectweb/asm/Opcodes.java#L44] which will support the jdk versions we need and 11 started official support in ASM7 as per the [changelog|https://asm.ow2.io/versions.html]. If we want to provide opcode for particular JDK then we use the V* opcodes. I hope I didn't somehow misunderstood this. Also, we will need to bump this further when we commit the JDK17 support bits, I keep a note on that myself. Which reminds me I might have to talk to you [~benedict] about the jdk17 and the simulator so I do not miss anything there but I am not there yet. {quote}In that case it's fine, yes :) {quote} Thanks for confirming, I will add you both reviewers then :) I will rebase and rerun CI pre-commit as it has been a while. > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17873: Status: Review In Progress (was: Needs Committer) > Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11 > --- > > Key: CASSANDRA-17873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17873 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x > > > In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to > provide Opcodes.ASM7 but only in 1 of 3 places. > We need to update that for 4.0, 4.1 and trunk where we support JDK11. > Also, I think it will be good to add one place where we update that when we > add new JDK support as now I see we will have to update it at 4 places at > least already (also for the simulator where currently it is Opcodes.ASM7 > there, correctly added). Also, we can add a note in build.xml for people > updating ASM. I think many people practice updating Opcodes.ASM* with the > update of ASM version but in our case with update of JDK, from what I see. We > will need to switch to ASM9 when we add the JDK 17 support. One stop place > for that and adding a note for maintainers sounds like the right way to move > forward at least on trunk. > But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I > can tell. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17240) CEP-19: Trie memtable implementation
[ https://issues.apache.org/jira/browse/CASSANDRA-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619706#comment-17619706 ] Andres de la Peña commented on CASSANDRA-17240: --- {quote}The flakes in the memtable size test are now fixed. [~adelapena], you can rerun the above if you wish; I have already run both flaky ones, {{MemtableSizeOffheapObjectsTest}} and {{{}MemtableSizeOffheapBuffersTest{}}}, thousands of times. {quote} CASSANDRA-17939 has just been merged. It will create conflicts with the new job for tries that this patch adds. The changes on CircleCI config should be adapted to also add an associated job for repeatedly run any new, modified or manually specify unit tests with memtable tries. [The previously mentioned commit|https://github.com/adelapena/cassandra/commit/23fe8743f185ad1b93cce37383d6d4807ea14e36] does exactly that. It was meant to help with the rebase pains. > CEP-19: Trie memtable implementation > > > Key: CASSANDRA-17240 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17240 > Project: Cassandra > Issue Type: Improvement > Components: Local/Memtable >Reporter: Branimir Lambov >Assignee: Branimir Lambov >Priority: Normal > Attachments: SkipListMemtable-OSS.png, TrieMemtable-OSS.png, > density_SG.html.gz, density_test_with_sharding.html.gz, latency-1_1-95.png, > latency-9_1-95.png, throughput_SG.png, throughput_apache.png > > Time Spent: 13h 20m > Remaining Estimate: 0h > > Trie-based memtable implementation as described in CEP-19, built on top of > CASSANDRA-17034 and CASSANDRA-6936. > The implementation is available in this > [branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17240]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17969) Keep sstable level when streaming for decommission and move
[ https://issues.apache.org/jira/browse/CASSANDRA-17969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17969: -- Status: Ready to Commit (was: Review In Progress) > Keep sstable level when streaming for decommission and move > --- > > Key: CASSANDRA-17969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17969 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > We currently keep the sstable level when streaming for bootstrap and rebuild, > we should do the same for decommission and move -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17969) Keep sstable level when streaming for decommission and move
[ https://issues.apache.org/jira/browse/CASSANDRA-17969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619700#comment-17619700 ] David Capwell commented on CASSANDRA-17969: --- +1 > Keep sstable level when streaming for decommission and move > --- > > Key: CASSANDRA-17969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17969 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > We currently keep the sstable level when streaming for bootstrap and rebuild, > we should do the same for decommission and move -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17969) Keep sstable level when streaming for decommission and move
[ https://issues.apache.org/jira/browse/CASSANDRA-17969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17969: -- Test and Documentation Plan: added tests Status: Patch Available (was: Open) > Keep sstable level when streaming for decommission and move > --- > > Key: CASSANDRA-17969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17969 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > We currently keep the sstable level when streaming for bootstrap and rebuild, > we should do the same for decommission and move -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17969) Keep sstable level when streaming for decommission and move
[ https://issues.apache.org/jira/browse/CASSANDRA-17969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17969: -- Status: Review In Progress (was: Patch Available) > Keep sstable level when streaming for decommission and move > --- > > Key: CASSANDRA-17969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17969 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > We currently keep the sstable level when streaming for bootstrap and rebuild, > we should do the same for decommission and move -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16640) Round out cqlsh completion test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619695#comment-17619695 ] Stefan Miklosovic edited comment on CASSANDRA-16640 at 10/18/22 4:40 PM: - It would be nice we spent more time on this and covered more tab completions with tests when applicable. For example I do not think we have tests for completion for CASSANDRA-13985. -There is not tab completion implemented for SHOW REPLICAS- (plus test). was (Author: smiklosovic): It would be nice we spent more time on this and covered more tab completions with tests when applicable. For example I do not think we have tests for completion for CASSANDRA-13985. There is not tab completion implemented for SHOW REPLICAS (plus test). > Round out cqlsh completion test coverage > > > Key: CASSANDRA-16640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16640 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter, Test/unit >Reporter: Adam Holmberg >Assignee: Brad Schoening >Priority: Low > Fix For: 4.0.x > > > There are some missing tests in cqlsh completion. Some highlighted > [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824]. > There might be more needing coverage that are not enumerated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16640) Round out cqlsh completion test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-16640: -- Status: Changes Suggested (was: Review In Progress) > Round out cqlsh completion test coverage > > > Key: CASSANDRA-16640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16640 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter, Test/unit >Reporter: Adam Holmberg >Assignee: Brad Schoening >Priority: Low > Fix For: 4.0.x > > > There are some missing tests in cqlsh completion. Some highlighted > [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824]. > There might be more needing coverage that are not enumerated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16640) Round out cqlsh completion test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619695#comment-17619695 ] Stefan Miklosovic commented on CASSANDRA-16640: --- It would be nice we spent more time on this and covered more tab completions with tests when applicable. For example I do not think we have tests for completion for CASSANDRA-13985. There is not tab completion implemented for SHOW REPLICAS (plus test). > Round out cqlsh completion test coverage > > > Key: CASSANDRA-16640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16640 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter, Test/unit >Reporter: Adam Holmberg >Assignee: Brad Schoening >Priority: Low > Fix For: 4.0.x > > > There are some missing tests in cqlsh completion. Some highlighted > [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824]. > There might be more needing coverage that are not enumerated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17240) CEP-19: Trie memtable implementation
[ https://issues.apache.org/jira/browse/CASSANDRA-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619692#comment-17619692 ] Branimir Lambov commented on CASSANDRA-17240: - {quote}It has been recently agreed that new or modified tests should be run 500 times before commit... {quote} The flakes in the memtable size test are now fixed. [~adelapena], you can rerun the above if you wish; I have already run both flaky ones, {{MemtableSizeOffheapObjectsTest}} and {{{}MemtableSizeOffheapBuffersTest{}}}, thousands of times. {quote}It seems like there are things that we're now ignoring (Owner, MemtableAllocator, and initial comparator in AbstractAllocatorMemtable; empty clusterings; and the measureDeepOmitShared()) and would push flush frequency down a bit, but then the changes in Columns potentially pushing flush frequency up. Do we have an idea of where that nets out? {quote} The {{Unmetered}} annotations only really affect the calculation the memtable size test does. The flush frequency can increase due to the columns objects, possibly by up to 10% in key-value workloads with a small amount of data per column. I will leave the memtable precision parts in a separate commit so that, if we are unhappy with the effect, they can be independently rolled back and held off until a major release. > CEP-19: Trie memtable implementation > > > Key: CASSANDRA-17240 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17240 > Project: Cassandra > Issue Type: Improvement > Components: Local/Memtable >Reporter: Branimir Lambov >Assignee: Branimir Lambov >Priority: Normal > Attachments: SkipListMemtable-OSS.png, TrieMemtable-OSS.png, > density_SG.html.gz, density_test_with_sharding.html.gz, latency-1_1-95.png, > latency-9_1-95.png, throughput_SG.png, throughput_apache.png > > Time Spent: 13h 20m > Remaining Estimate: 0h > > Trie-based memtable implementation as described in CEP-19, built on top of > CASSANDRA-17034 and CASSANDRA-6936. > The implementation is available in this > [branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17240]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16640) Round out cqlsh completion test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-16640: -- Reviewers: Stefan Miklosovic Status: Review In Progress (was: Patch Available) > Round out cqlsh completion test coverage > > > Key: CASSANDRA-16640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16640 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter, Test/unit >Reporter: Adam Holmberg >Assignee: Brad Schoening >Priority: Low > Fix For: 4.0.x > > > There are some missing tests in cqlsh completion. Some highlighted > [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824]. > There might be more needing coverage that are not enumerated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17965) cassandra-driver-core vulnerability CVE-2019-2684
[ https://issues.apache.org/jira/browse/CASSANDRA-17965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619684#comment-17619684 ] Brandon Williams commented on CASSANDRA-17965: -- Committed, thanks. > cassandra-driver-core vulnerability CVE-2019-2684 > - > > Key: CASSANDRA-17965 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17965 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-beta2, 4.2 > > > As the summary says, CVE-2019-2684 affects cassandra-driver-core including > both versions we use, 3.0.1 and 3.11.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17965) cassandra-driver-core vulnerability CVE-2019-2684
[ https://issues.apache.org/jira/browse/CASSANDRA-17965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17965: - Fix Version/s: 3.0.28 3.11.14 4.0.7 4.2 (was: 3.0.x) (was: 4.x) (was: 3.11.x) (was: 4.0.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra/commit/3d4e6944ef11d96858507779b9280f5b9c198ffa Resolution: Fixed Status: Resolved (was: Ready to Commit) > cassandra-driver-core vulnerability CVE-2019-2684 > - > > Key: CASSANDRA-17965 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17965 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-beta2, 4.2 > > > As the summary says, CVE-2019-2684 affects cassandra-driver-core including > both versions we use, 3.0.1 and 3.11.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17965) cassandra-driver-core vulnerability CVE-2019-2684
[ https://issues.apache.org/jira/browse/CASSANDRA-17965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17965: - Status: Ready to Commit (was: Review In Progress) > cassandra-driver-core vulnerability CVE-2019-2684 > - > > Key: CASSANDRA-17965 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17965 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-beta2, 4.x > > > As the summary says, CVE-2019-2684 affects cassandra-driver-core including > both versions we use, 3.0.1 and 3.11.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a124f099e036a83b7ef2b69975b122dc83ba3e5f Merge: cc622a20e1 6b0cd7db04 Author: Brandon Williams AuthorDate: Tue Oct 18 11:16:20 2022 -0500 Merge branch 'cassandra-3.11' into cassandra-4.0 .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) diff --cc .build/dependency-check-suppressions.xml index a065089feb,6ed01952be..c833fd252b --- a/.build/dependency-check-suppressions.xml +++ b/.build/dependency-check-suppressions.xml @@@ -21,16 -21,9 +21,17 @@@ --> https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd;> - + +^pkg:maven/com\.datastax\.cassandra/cassandra\-driver\-core@.*$ +CVE-2018-8016 ++CVE-2019-2684 +CVE-2020-13946 +CVE-2020-17516 +CVE-2021-44521 + + + ^pkg:maven/org\.yaml/snakeyaml@.*$ -CVE-2017-18640 CVE-2022-25857 CVE-2022-38749 CVE-2022-38750 diff --cc CHANGES.txt index 213c3fb918,830dca3b50..d85f0c5357 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -13,41 -3,17 +13,42 @@@ Merged from 3.11 * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) - * Document usage of closed token intervals in manual compaction (CASSANDRA-17575) - * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) - * Only use statically defined subcolumns when determining column definition for supercolumn cell (CASSANDRA-14113) Merged from 3.0: + * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) + * Fix resetting schema (CASSANDRA-17819) + +4.0.6 + * Fix race condition on updating cdc size and advancing to next segment (CASSANDRA-17792) + * Add 'noboolean' rpm build for older distros like CentOS7 (CASSANDRA-17765) + * Fix default value for compaction_throughput_mb_per_sec in Config class to match the one in cassandra.yaml (CASSANDRA-17790) + * Fix Setting Virtual Table - update after startup config properties gc_log_threshold_in_ms, gc_warn_threshold_in_ms, + conf.index_summary_capacity_in_mb, prepared_statements_cache_size_mb, key_cache_size_in_mb, counter_cache_size_in_mb + (CASSANDRA-17737) + * Fix Settings Virtual Table - index_summary_resize_interval and index_summary_capacity were not updated after startup (CASSANDRA-17735) + * Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests (CASSANDRA-17731) + * Remove extra write to system table for prepared statements (CASSANDRA-17764) +Merged from 3.11: + * Document usage of closed token intervals in manual compaction (CASSANDRA-17575) +Merged from 3.0: * Improve libjemalloc resolution in bin/cassandra (CASSANDRA-15767) * Fix restarting of services on gossipping-only member (CASSANDRA-17752) + +4.0.5 + * Utilise BTree improvements to reduce garbage and improve throughput (CASSANDRA-15511) + * Make sure existing delayed tasks in StreamTransferTask cannot prevent clean shutdown (CASSANDRA-17706) + * SSL storage port in sstableloader is deprecated (CASSANDRA-17602) + * Fix counter write timeouts at ONE (CASSANDRA-17411) + * Fix NPE in getLocalPrimaryRangeForEndpoint (CASSANDRA-17680) + * Remove SSL storage port from sstableloader (CASSANDRA-17602) + * Allow Java 11 to satisfy RPM/Debian packaging (CASSANDRA-17669) + * Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted (CASSANDRA-17663) + * silence benign SslClosedEngineException (CASSANDRA-17565) +Merged from 3.11: + * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) +Merged from 3.0: * Fix writetime and ttl functions forbidden for collections instead of multicell columns (CASSANDRA-17628) - * Supress CVE-2020-7238 (CASSANDRA-17697) * Fix issue where frozen maps may not be serialized in the correct order (CASSANDRA-17623) * Suppress CVE-2022-24823 (CASSANDRA-17633) * fsync TOC and digest files (CASSANDRA-10709) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (36e73bdf55 -> 0aa4ef1a8e)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 36e73bdf55 Merge branch 'cassandra-4.0' into cassandra-4.1 new 3d4e6944ef Suppress CVE-2019-2684 new 6b0cd7db04 Merge branch 'cassandra-3.0' into cassandra-3.11 new a124f099e0 Merge branch 'cassandra-3.11' into cassandra-4.0 new 0aa4ef1a8e Merge branch 'cassandra-4.0' into cassandra-4.1 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0aa4ef1a8e57336fbe5b4ac8584ab0804b0215c6 Merge: 36e73bdf55 a124f099e0 Author: Brandon Williams AuthorDate: Tue Oct 18 11:18:32 2022 -0500 Merge branch 'cassandra-4.0' into cassandra-4.1 .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) diff --cc CHANGES.txt index 39a2129f8d,d85f0c5357..d5a1ce2416 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -7,45 -5,21 +7,46 @@@ Merged from 4.0 Merged from 3.11: * Suppress CVE-2022-42003 and CVE-2022-42004 (CASSANDRA-17966) * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) - * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) - * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) Merged from 3.0: + * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) - * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) - * Fix resetting schema (CASSANDRA-17819) -4.0.6 +4.1-beta1 + * We should not emit deprecation warning on startup for `key_cache_save_period`, `row_cache_save_period`, `counter_cache_save_period` (CASSANDRA-17904) + * upsert with adder support is not consistent with numbers and strings in LWT (CASSANDRA-17857) + * Fix race and return after failing connections (CASSANDRA-17618) + * Speculative execution threshold unit mismatch (CASSANDRA-17877) + * Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle (CASSANDRA-17677) + * Fix a race condition where a keyspace can be oopened while it is being removed (CASSANDRA-17658) + * DatabaseDescriptor will set the default failure detector during client initialization (CASSANDRA-17782) + * Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool (CASSANDRA-17740) + * Improve JMX methods signatures, fix JMX and config backward compatibility (CASSANDRA-17725) + * Fix sstable_preemptive_open_interval disabled value. sstable_preemptive_open_interval = null backward compatible with + sstable_preemptive_open_interval_in_mb = -1 (CASSANDRA-17737) + * Remove usages of Path#toFile() in the snapshot apparatus (CASSANDRA-17769) + * Fix Settings Virtual Table to update paxos_variant after startup and rename enable_uuid_sstable_identifiers to + uuid_sstable_identifiers_enabled as per our config naming conventions (CASSANDRA-17738) + * index_summary_resize_interval_in_minutes = -1 is equivalent to index_summary_resize_interval being set to null or + disabled. JMX MBean IndexSummaryManager, setResizeIntervalInMinutes method still takes resizeIntervalInMinutes = -1 for disabled (CASSANDRA-17735) + * min_tracked_partition_size_bytes parameter from 4.1 alpha1 was renamed to min_tracked_partition_size (CASSANDRA-17733) + * Remove commons-lang dependency during build runtime (CASSANDRA-17724) + * Relax synchronization on StreamSession#onError() to avoid deadlock (CASSANDRA-17706) + * Fix AbstractCell#toString throws MarshalException for cell in collection (CASSANDRA-17695) + * Add new vtable output option to compactionstats (CASSANDRA-17683) + * Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog (CASSANDRA-17587) + * Fix widening to long in getBatchSizeFailThreshold (CASSANDRA-17650) + * Fix widening from mebibytes to bytes in IntMebibytesBound (CASSANDRA-17716) + * Revert breaking change in nodetool clientstats and expose cient options through nodetool clientstats --client-options. (CASSANDRA-17715) + * Fix missed nowInSec values in QueryProcessor (CASSANDRA-17458) + * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Builder class and deprecate it in favor of withBufferSizeInMiB(int size) (CASSANDRA-17675) + * Remove expired snapshots of dropped tables after restart (CASSANDRA-17619) +Merged from 4.0: + * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895) + * Fix repair failure on assertion if two peers have overlapping mismatching ranges (CASSANDRA-17900) + * Better handle null state in Gossip schema migration to avoid NPE (CASSANDRA-17864) + * HintedHandoffAddRemoveNodesTest now accounts for the fact that StorageMetrics.totalHints is not updated synchronously w/ writes (CASSANDRA-16679) + * Avoid getting hanging repairs due to repair message timeouts (CASSANDRA-17613) + * Prevent infinite loop in repair coordinator on FailSession (CASSANDRA-17834) * Fix race condition on updating cdc size and advancing to next segment (CASSANDRA-17792) * Add 'noboolean' rpm build for older distros like CentOS7 (CASSANDRA-17765) * Fix default value for compaction_throughput_mb_per_sec in Config
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a62f618b08fd2aa2f07b23a64e89bbe7165ea243 Merge: 0ab2aa25d4 0aa4ef1a8e Author: Brandon Williams AuthorDate: Tue Oct 18 11:19:38 2022 -0500 Merge branch 'cassandra-4.1' into trunk .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) diff --cc CHANGES.txt index d32083e7eb,d5a1ce2416..96e3702566 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -124,7 -68,6 +124,8 @@@ Merged from 3.11 * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) Merged from 3.0: ++ * Suppress CVE-2019-2684 (CASSANDRA-17965) + * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Improve libjemalloc resolution in bin/cassandra (CASSANDRA-15767) * Fix restarting of services on gossipping-only member (CASSANDRA-17752) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (cc622a20e1 -> a124f099e0)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from cc622a20e1 Merge branch 'cassandra-3.11' into cassandra-4.0 new 3d4e6944ef Suppress CVE-2019-2684 new 6b0cd7db04 Merge branch 'cassandra-3.0' into cassandra-3.11 new a124f099e0 Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (0ab2aa25d4 -> a62f618b08)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 0ab2aa25d4 Merge branch 'cassandra-4.1' into trunk new 3d4e6944ef Suppress CVE-2019-2684 new 6b0cd7db04 Merge branch 'cassandra-3.0' into cassandra-3.11 new a124f099e0 Merge branch 'cassandra-3.11' into cassandra-4.0 new 0aa4ef1a8e Merge branch 'cassandra-4.0' into cassandra-4.1 new a62f618b08 Merge branch 'cassandra-4.1' into trunk The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 6b0cd7db043095904c500660a36ae27826f693a7 Merge: f13cdddcad 3d4e6944ef Author: Brandon Williams AuthorDate: Tue Oct 18 11:08:02 2022 -0500 Merge branch 'cassandra-3.0' into cassandra-3.11 .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) diff --cc CHANGES.txt index cbe38d02b3,7dd28c8a84..830dca3b50 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,12 -1,5 +1,13 @@@ -3.0.28 +3.11.14 + * Suppress CVE-2022-42003 and CVE-2022-42004 (CASSANDRA-17966) + * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) + * Suppress CVE-2022-25857 and other snakeyaml CVEs (CASSANDRA-17907) + * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) + * Document usage of closed token intervals in manual compaction (CASSANDRA-17575) + * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) + * Only use statically defined subcolumns when determining column definition for supercolumn cell (CASSANDRA-14113) +Merged from 3.0: + * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) * Improve libjemalloc resolution in bin/cassandra (CASSANDRA-15767) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (f13cdddcad -> 6b0cd7db04)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from f13cdddcad Merge branch 'cassandra-3.0' into cassandra-3.11 new 3d4e6944ef Suppress CVE-2019-2684 new 6b0cd7db04 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Suppress CVE-2019-2684
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-3.0 by this push: new 3d4e6944ef Suppress CVE-2019-2684 3d4e6944ef is described below commit 3d4e6944ef11d96858507779b9280f5b9c198ffa Author: Brandon Williams AuthorDate: Mon Oct 17 10:49:22 2022 -0500 Suppress CVE-2019-2684 Patch by brandonwilliams; reviewed by smiklosovic for CASSANDRA-17965 --- .build/dependency-check-suppressions.xml | 1 + CHANGES.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/.build/dependency-check-suppressions.xml b/.build/dependency-check-suppressions.xml index e0fd8c3a55..11bc87a552 100644 --- a/.build/dependency-check-suppressions.xml +++ b/.build/dependency-check-suppressions.xml @@ -55,6 +55,7 @@ ^pkg:maven/com\.datastax\.cassandra/cassandra\-driver\-core@.*$ +CVE-2019-2684 CVE-2020-13946 CVE-2020-17516 CVE-2021-44521 diff --git a/CHANGES.txt b/CHANGES.txt index 14efe64814..7dd28c8a84 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0.28 + * Suppress CVE-2019-2684 (CASSANDRA-17965) * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) * Fix scrubber falling into infinite loop when the last partition is broken (CASSANDRA-17862) * Improve libjemalloc resolution in bin/cassandra (CASSANDRA-15767) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17938) CircleCI: Allow to specify multiple tests in the test multiplexer
[ https://issues.apache.org/jira/browse/CASSANDRA-17938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-17938: -- Resolution: Duplicate Status: Resolved (was: Open) > CircleCI: Allow to specify multiple tests in the test multiplexer > - > > Key: CASSANDRA-17938 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17938 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > > As recently [discussed on the mail > list|https://lists.apache.org/thread/o166v7nr9lxnzdy5511tv40rr9t6zbrw], it > would be useful if we were able to run multiple test classes on the test > multiplexer with a single push: > {quote}The multiplexer only allows to run a single test class per push. This > is ok > for fixing existing flakies (its original purpose), and for most minor > changes, but it can be quite inconvenient for testing large patches that > add or modify many tests. For example, the patch for CEP-19 directly > modifies 31 test classes, which means 31 CircleCI config pushes. This > number can be somewhat reduced with some wildcards on the class names, but > the process is still quite inconvenient. I guess that other large patches > will find the same problem. > {quote} > The purpose of this ticket is replacing the {{REPEATED_UTEST_CLASS}} > environment var by a new {{REPEATED_UTEST_CLASSES}} var that accepts a list > of classes, or an equivalent solution. > The same should be done for the analogous > {{REPEATED_JVM_UPGRADE_DTEST_CLASS}} and possibly {{{}REPEATED_DTEST_NAME{}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org