[
https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619707#comment-17619707
]
Ekaterina Dimitrova commented on CASSANDRA-17873:
-------------------------------------------------
{quote}I don't have a mental map of ASM version to Java version unfortunately,
just wanted to check it had been confirmed.
{quote}
Same here and I looked into this like almost two months ago, appreciate you
chiming in here!
I am struggling to find official doc now on the opcodes and the Javadoc was not
helpful but looking back into the Opcodes interface itself what I remembered is
[ASM7 corresponds to minimum required ASM
version|https://github.com/consulo/objectweb-asm/blob/master/asm/src/main/java/org/objectweb/asm/Opcodes.java#L44]
which will support the jdk versions we need and 11 started official support in
ASM7 as per the [changelog|https://asm.ow2.io/versions.html]. If we want to
provide opcode for particular JDK then we use the V* opcodes. I hope I didn't
somehow misunderstood this. Also, we will need to bump this further when we
commit the JDK17 support bits, I keep a note on that myself. Which reminds me I
might have to talk to you [~benedict] about the jdk17 and the simulator so I
do not miss anything there but I am not there yet.
{quote}In that case it's fine, yes :)
{quote}
Thanks for confirming, I will add you both reviewers then :) I will rebase and
rerun CI pre-commit as it has been a while.
> Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17873
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17873
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Dependencies, Feature/UDF
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to
> provide Opcodes.ASM7 but only in 1 of 3 places.
> We need to update that for 4.0, 4.1 and trunk where we support JDK11.
> Also, I think it will be good to add one place where we update that when we
> add new JDK support as now I see we will have to update it at 4 places at
> least already (also for the simulator where currently it is Opcodes.ASM7
> there, correctly added). Also, we can add a note in build.xml for people
> updating ASM. I think many people practice updating Opcodes.ASM* with the
> update of ASM version but in our case with update of JDK, from what I see. We
> will need to switch to ASM9 when we add the JDK 17 support. One stop place
> for that and adding a note for maintainers sounds like the right way to move
> forward at least on trunk.
> But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I
> can tell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
