[cassandra-website] branch asf-staging updated (c7878328 -> 04e3d24f)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard c7878328 generate docs for 5dd84ab2 new 04e3d24f generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c7878328) \ N -- N -- N refs/heads/asf-staging (04e3d24f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18155) Coordinator level metrics for read response and mutation row and column counts
[
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680102#comment-17680102
]
Berenguer Blasi commented on CASSANDRA-18155:
-
No rush, I have just done a first cursory pass though. Let me see if I can
finish it today...
> Coordinator level metrics for read response and mutation row and column counts
> --
>
> Key: CASSANDRA-18155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18150) Prefer snakeyaml's SafeConstructor over Constructor
[ https://issues.apache.org/jira/browse/CASSANDRA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680096#comment-17680096 ] Berenguer Blasi edited comment on CASSANDRA-18150 at 1/24/23 5:39 AM: -- Right icwym. Yes let's ship that first batch of PRs ASAP. +1 was (Author: bereng): Right icwym. Yes let's ship that bit ASAP. +1 > Prefer snakeyaml's SafeConstructor over Constructor > --- > > Key: CASSANDRA-18150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18150 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > CVE-2022-1471 allows RCE through the Constructor class. While this isn't a > concern since yaml is only used for configuration, it is simple enough to > switch to SafeConstructor and harden the server a little more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18150) Prefer snakeyaml's SafeConstructor over Constructor
[ https://issues.apache.org/jira/browse/CASSANDRA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18150: Status: Review In Progress (was: Patch Available) > Prefer snakeyaml's SafeConstructor over Constructor > --- > > Key: CASSANDRA-18150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18150 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > CVE-2022-1471 allows RCE through the Constructor class. While this isn't a > concern since yaml is only used for configuration, it is simple enough to > switch to SafeConstructor and harden the server a little more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18150) Prefer snakeyaml's SafeConstructor over Constructor
[ https://issues.apache.org/jira/browse/CASSANDRA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18150: Status: Patch Available (was: In Progress) > Prefer snakeyaml's SafeConstructor over Constructor > --- > > Key: CASSANDRA-18150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18150 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > CVE-2022-1471 allows RCE through the Constructor class. While this isn't a > concern since yaml is only used for configuration, it is simple enough to > switch to SafeConstructor and harden the server a little more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18150) Prefer snakeyaml's SafeConstructor over Constructor
[ https://issues.apache.org/jira/browse/CASSANDRA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680096#comment-17680096 ] Berenguer Blasi commented on CASSANDRA-18150: - Right icwym. Yes let's ship that bit ASAP. +1 > Prefer snakeyaml's SafeConstructor over Constructor > --- > > Key: CASSANDRA-18150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18150 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > CVE-2022-1471 allows RCE through the Constructor class. While this isn't a > concern since yaml is only used for configuration, it is simple enough to > switch to SafeConstructor and harden the server a little more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18188:
-
Fix Version/s: 3.0.29
3.11.15
4.0.8
4.1.1
4.2
(was: 4.x)
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra-builds/commit/36924a2c2193fe0e27000ada9308ebf79a0aee98
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Everything passed there, committed.
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18188:
-
Reviewers: Michael Semb Wever (was: Brandon Williams, Michael Semb Wever)
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18188:
-
Status: Ready to Commit (was: Review In Progress)
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18188:
-
Reviewers: Michael Semb Wever, Brandon Williams (was: Michael Semb Wever)
Michael Semb Wever, Brandon Williams (was: Brandon Williams,
Michael Semb Wever)
Status: Review In Progress (was: Patch Available)
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: Lock dtest venv to python 3.8
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git The following commit(s) were added to refs/heads/trunk by this push: new 36924a2 Lock dtest venv to python 3.8 36924a2 is described below commit 36924a2c2193fe0e27000ada9308ebf79a0aee98 Author: Brandon Williams AuthorDate: Mon Jan 23 16:07:02 2023 -0600 Lock dtest venv to python 3.8 Patch by brandonwilliams; reviewed by mck for CASSANDRA-18188 --- build-scripts/cassandra-dtest-pytest.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-scripts/cassandra-dtest-pytest.sh b/build-scripts/cassandra-dtest-pytest.sh index db6f998..27a8c9e 100755 --- a/build-scripts/cassandra-dtest-pytest.sh +++ b/build-scripts/cassandra-dtest-pytest.sh @@ -63,7 +63,7 @@ fi # Set up venv with dtest dependencies set -e # enable immediate exit if venv setup fails -virtualenv --python=python3 venv +virtualenv --python=python3.8 venv source venv/bin/activate pip3 install --exists-action w -r cassandra-dtest/requirements.txt pip3 freeze - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (db65a190 -> c7878328)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard db65a190 generate docs for 5dd84ab2 new c7878328 generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (db65a190) \ N -- N -- N refs/heads/asf-staging (c7878328) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (c68f8f004 -> db65a190c)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard c68f8f004 generate docs for 5dd84ab2 new db65a190c generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c68f8f004) \ N -- N -- N refs/heads/asf-staging (db65a190c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680066#comment-17680066
]
Ekaterina Dimitrova edited comment on CASSANDRA-18144 at 1/24/23 1:23 AM:
--
-CI is running
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2218/]-
New link -
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2189/workflows/49ac872c-a5bd-4547-be04-ea991e11afad]
NOTE: I pushed the tests in a loop with the free tier as it is a unit test fix
and those can be run by anyone with free CircleCI access. Higher resources not
needed
was (Author: e.dimitrova):
-CI is running
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2218/]-
New link -
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2189/workflows/49ac872c-a5bd-4547-be04-ea991e11afad
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680066#comment-17680066
]
Ekaterina Dimitrova edited comment on CASSANDRA-18144 at 1/24/23 1:20 AM:
--
-CI is running
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2218/]-
New link -
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2189/workflows/49ac872c-a5bd-4547-be04-ea991e11afad
was (Author: e.dimitrova):
CI is running
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2218/]
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680066#comment-17680066
]
Ekaterina Dimitrova commented on CASSANDRA-18144:
-
CI is running
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2218/]
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680062#comment-17680062
]
Kamalesh Palanisamy commented on CASSANDRA-18144:
-
Oh okay thanks for letting me know :) .
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (fdec73b35 -> c68f8f004)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard fdec73b35 generate docs for 5dd84ab2 new c68f8f004 generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (fdec73b35) \ N -- N -- N refs/heads/asf-staging (c68f8f004) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18133) In-tree build scripts
[ https://issues.apache.org/jira/browse/CASSANDRA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680056#comment-17680056 ] Michael Semb Wever commented on CASSANDRA-18133: Patches updated. - trunk: https://github.com/michaelsembwever/cassandra/compare/mck/18179/trunk...thelastpickle:cassandra:mck/18133/trunk - cassandra-builds: https://github.com/thelastpickle/cassandra-builds/compare/mck/17869...thelastpickle:cassandra-builds:mck/18133 In-tree CI (just 8+11) - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/77/workflows/7fa43d02-b01a-4e55-b67b-dc189926d42d - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/77/workflows/cbc6bcb8-25c6-4530-a8c5-6041cc9cd96b > In-tree build scripts > - > > Key: CASSANDRA-18133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18133 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To simplify the introduction of JDK17 (and removal of JDK8), bring the > artifact/deb/rpm build scripts (and associated docker images) from > cassandra-builds repo to the .build directory. > The declarative Jenkinsfile can then directly declare the artifacts jobs in > its pipeline. And the packaging jobs can be separated and run in parallel. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16418) Unsafe to run nodetool cleanup during bootstrap or decommission
[ https://issues.apache.org/jira/browse/CASSANDRA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16418: Fix Version/s: 4.0.8 4.1.1 4.2 (was: 4.0.x) Since Version: 3.0.0 Source Control Link: https://github.com/apache/cassandra/commit/8bb9c72f582de6bcc39522ba9ade91fd5bc22f67 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Unsafe to run nodetool cleanup during bootstrap or decommission > --- > > Key: CASSANDRA-16418 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16418 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: James Baker >Assignee: Lindsey Zurovchak >Priority: Normal > Fix For: 4.0.8, 4.1.1, 4.2 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > What we expected: Running a cleanup is a safe operation; the result of > running a query after a cleanup should be the same as the result of running a > query before a cleanup. > What actually happened: We ran a cleanup during a decommission. All the > streamed data was silently deleted, the bootstrap did not fail, the cluster's > data after the decommission was very different to the state before. > Why: Cleanups do not take into account pending ranges and so the cleanup > thought that all the data that had just been streamed was redundant and so > deleted it. We think that this is symmetric with bootstraps, though have not > verified. > Not sure if this is technically a bug but it was very surprising (and > seemingly undocumented) behaviour. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16418) Unsafe to run nodetool cleanup during bootstrap or decommission
[ https://issues.apache.org/jira/browse/CASSANDRA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16418: Status: Ready to Commit (was: Changes Suggested) > Unsafe to run nodetool cleanup during bootstrap or decommission > --- > > Key: CASSANDRA-16418 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16418 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: James Baker >Assignee: Lindsey Zurovchak >Priority: Normal > Fix For: 4.0.x > > Time Spent: 3h 10m > Remaining Estimate: 0h > > What we expected: Running a cleanup is a safe operation; the result of > running a query after a cleanup should be the same as the result of running a > query before a cleanup. > What actually happened: We ran a cleanup during a decommission. All the > streamed data was silently deleted, the bootstrap did not fail, the cluster's > data after the decommission was very different to the state before. > Why: Cleanups do not take into account pending ranges and so the cleanup > thought that all the data that had just been streamed was redundant and so > deleted it. We think that this is symmetric with bootstraps, though have not > verified. > Not sure if this is technically a bug but it was very surprising (and > seemingly undocumented) behaviour. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Add safeguard so cleanup fails when node has pending ranges
This is an automated email from the ASF dual-hosted git repository.
paulo pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 8bb9c72f58 Add safeguard so cleanup fails when node has pending ranges
8bb9c72f58 is described below
commit 8bb9c72f582de6bcc39522ba9ade91fd5bc22f67
Author: lzurovchak1
AuthorDate: Wed Dec 21 13:34:18 2022 -0500
Add safeguard so cleanup fails when node has pending ranges
Patch by Lindsey Zurovchak; Reviewed by Paulo Motta, Stefan Miklosovic for
CASSANDRA-16418
Closes #2061
---
CHANGES.txt| 1 +
.../cassandra/db/compaction/CompactionManager.java | 6 +-
.../apache/cassandra/service/StorageService.java | 4 +
.../cassandra/distributed/action/GossipHelper.java | 12 +++
.../distributed/test/ring/CleanupFailureTest.java | 111 +
test/unit/org/apache/cassandra/db/CleanupTest.java | 6 +-
6 files changed, 133 insertions(+), 7 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index a75ee17128..789d8f7fa8 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0.8
+ * Add safeguard so cleanup fails when node has pending ranges
(CASSANDRA-16418)
* Fix legacy clustering serialization for paging with compact storage
(CASSANDRA-17507)
* Add support for python 3.11 (CASSANDRA-18088)
* Fix formatting of duration in cqlsh (CASSANDRA-18141)
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
index 799eed3d0d..a5277356de 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
@@ -515,11 +515,7 @@ public class CompactionManager implements
CompactionManagerMBean
{
assert !cfStore.isIndex();
Keyspace keyspace = cfStore.keyspace;
-if (!StorageService.instance.isJoined())
-{
-logger.info("Cleanup cannot run before a node has joined the
ring");
-return AllSSTableOpStatus.ABORTED;
-}
+
// if local ranges is empty, it means no data should remain
final RangesAtEndpoint replicas =
StorageService.instance.getLocalReplicas(keyspace.getName());
final Set> allRanges = replicas.ranges();
diff --git a/src/java/org/apache/cassandra/service/StorageService.java
b/src/java/org/apache/cassandra/service/StorageService.java
index b70347a301..343f435f11 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -132,6 +132,7 @@ import static
org.apache.cassandra.index.SecondaryIndexManager.isIndexColumnFami
import static org.apache.cassandra.net.NoPayload.noPayload;
import static org.apache.cassandra.net.Verb.REPLICATION_DONE_REQ;
import static
org.apache.cassandra.schema.MigrationManager.evolveSystemKeyspace;
+import static
org.apache.cassandra.utils.FBUtilities.getBroadcastAddressAndPort;
/**
* This abstraction contains the token/identifier of this node
@@ -3634,6 +3635,9 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
if (SchemaConstants.isLocalSystemKeyspace(keyspaceName))
throw new RuntimeException("Cleanup of the system keyspace is
neither necessary nor wise");
+if (tokenMetadata.getPendingRanges(keyspaceName,
getBroadcastAddressAndPort()).size() > 0)
+throw new RuntimeException("Node is involved in cluster membership
changes. Not safe to run cleanup.");
+
CompactionManager.AllSSTableOpStatus status =
CompactionManager.AllSSTableOpStatus.SUCCESSFUL;
for (ColumnFamilyStore cfStore : getValidColumnFamilies(false, false,
keyspaceName, tables))
{
diff --git
a/test/distributed/org/apache/cassandra/distributed/action/GossipHelper.java
b/test/distributed/org/apache/cassandra/distributed/action/GossipHelper.java
index f4b5838a86..4f0d343f7b 100644
--- a/test/distributed/org/apache/cassandra/distributed/action/GossipHelper.java
+++ b/test/distributed/org/apache/cassandra/distributed/action/GossipHelper.java
@@ -66,6 +66,18 @@ public class GossipHelper
};
}
+public static InstanceAction statusToDecommission(IInvokableInstance
newNode)
+{
+return (instance) ->
+{
+changeGossipState(instance,
+ newNode,
+ Arrays.asList(tokens(newNode),
+statusLeaving(newNode),
+statusWithPortLeaving(newNode)));
+};
+}
+
public static InstanceAction statusToNormal(IInvokableInstance peer)
{
return (target) ->
diff --git
[cassandra] branch trunk updated (035705f494 -> 158875858c)
This is an automated email from the ASF dual-hosted git repository. paulo pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 035705f494 Print friendly error when nodetool attempts to connect to uninitialized server new 8bb9c72f58 Add safeguard so cleanup fails when node has pending ranges new da2dd2bfbc Merge branch 'cassandra-4.0' into cassandra-4.1 new 158875858c Merge branch 'cassandra-4.1' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 2 +- .../cassandra/db/compaction/CompactionManager.java | 6 +- .../apache/cassandra/service/StorageService.java | 4 + .../cassandra/distributed/action/GossipHelper.java | 12 +++ .../distributed/test/ring/CleanupFailureTest.java | 111 + test/unit/org/apache/cassandra/db/CleanupTest.java | 6 +- 6 files changed, 133 insertions(+), 8 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/ring/CleanupFailureTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (5c93731eee -> da2dd2bfbc)
This is an automated email from the ASF dual-hosted git repository. paulo pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 5c93731eee Merge branch 'cassandra-4.0' into cassandra-4.1 new 8bb9c72f58 Add safeguard so cleanup fails when node has pending ranges new da2dd2bfbc Merge branch 'cassandra-4.0' into cassandra-4.1 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../cassandra/db/compaction/CompactionManager.java | 6 +- .../apache/cassandra/service/StorageService.java | 4 + .../cassandra/distributed/action/GossipHelper.java | 12 +++ .../distributed/test/ring/CleanupFailureTest.java | 111 + test/unit/org/apache/cassandra/db/CleanupTest.java | 6 +- 6 files changed, 133 insertions(+), 7 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/ring/CleanupFailureTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. paulo pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 158875858c67a1518c70ce115530bc492df65ce2 Merge: 035705f494 da2dd2bfbc Author: Paulo Motta AuthorDate: Mon Jan 23 17:29:19 2023 -0500 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 2 +- .../cassandra/db/compaction/CompactionManager.java | 6 +- .../apache/cassandra/service/StorageService.java | 4 + .../cassandra/distributed/action/GossipHelper.java | 12 +++ .../distributed/test/ring/CleanupFailureTest.java | 111 + test/unit/org/apache/cassandra/db/CleanupTest.java | 6 +- 6 files changed, 133 insertions(+), 8 deletions(-) diff --cc CHANGES.txt index a1df8fea13,fc8eac05dc..188d1ef5e1 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -157,14 -84,6 +158,13 @@@ Merged from 3.0 * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Builder class and deprecate it in favor of withBufferSizeInMiB(int size) (CASSANDRA-17675) * Remove expired snapshots of dropped tables after restart (CASSANDRA-17619) Merged from 4.0: - * Fix sstable loading of keyspaces named snapshots or backups (CASSANDRA-14013) + * Restore internode custom tracing on 4.0's new messaging system (CASSANDRA-17981) + * Harden parsing of boolean values in CQL in PropertyDefinitions (CASSANDRA-17878) + * Fix possible race condition on repair snapshots (CASSANDRA-17955) + * Fix ASM bytecode version inconsistency (CASSANDRA-17873) + * Remove empty cq4 files in log directory to not fail the startup of BinLog (CASSANDRA-17933) + * Fix multiple BufferPool bugs (CASSANDRA-16681) + * Fix StorageService.getNativeaddress handling of IPv6 addresses (CASSANDRA-17945) * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895) * Fix repair failure on assertion if two peers have overlapping mismatching ranges (CASSANDRA-17900) * Better handle null state in Gossip schema migration to avoid NPE (CASSANDRA-17864) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. paulo pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit da2dd2bfbc977811214c86a04ba9b3ae6dbf0ba3 Merge: 5c93731eee 8bb9c72f58 Author: Paulo Motta AuthorDate: Mon Jan 23 17:27:32 2023 -0500 Merge branch 'cassandra-4.0' into cassandra-4.1 CHANGES.txt| 1 + .../cassandra/db/compaction/CompactionManager.java | 6 +- .../apache/cassandra/service/StorageService.java | 4 + .../cassandra/distributed/action/GossipHelper.java | 12 +++ .../distributed/test/ring/CleanupFailureTest.java | 111 + test/unit/org/apache/cassandra/db/CleanupTest.java | 6 +- 6 files changed, 133 insertions(+), 7 deletions(-) diff --cc CHANGES.txt index 05d2ab8019,789d8f7fa8..fc8eac05dc --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,8 -1,5 +1,9 @@@ -4.0.8 +4.1.1 + * Fix PAXOS2_COMMIT_AND_PREPARE_RSP serialisation AssertionError (CASSANDRA-18164) + * Streaming progress virtual table lock contention can trigger TCP_USER_TIMEOUT and fail streaming (CASSANDRA-18110) + * Fix perpetual load of denylist on read in cases where denylist can never be loaded (CASSANDRA-18116) +Merged from 4.0: + * Add safeguard so cleanup fails when node has pending ranges (CASSANDRA-16418) * Fix legacy clustering serialization for paging with compact storage (CASSANDRA-17507) * Add support for python 3.11 (CASSANDRA-18088) * Fix formatting of duration in cqlsh (CASSANDRA-18141) diff --cc src/java/org/apache/cassandra/service/StorageService.java index b39c049c88,343f435f11..b0aa50caff --- a/src/java/org/apache/cassandra/service/StorageService.java +++ b/src/java/org/apache/cassandra/service/StorageService.java @@@ -161,10 -131,8 +161,11 @@@ import static org.apache.cassandra.inde import static org.apache.cassandra.index.SecondaryIndexManager.isIndexColumnFamily; import static org.apache.cassandra.net.NoPayload.noPayload; import static org.apache.cassandra.net.Verb.REPLICATION_DONE_REQ; -import static org.apache.cassandra.schema.MigrationManager.evolveSystemKeyspace; +import static org.apache.cassandra.service.ActiveRepairService.*; +import static org.apache.cassandra.utils.Clock.Global.currentTimeMillis; +import static org.apache.cassandra.utils.Clock.Global.nanoTime; +import static org.apache.cassandra.utils.FBUtilities.now; + import static org.apache.cassandra.utils.FBUtilities.getBroadcastAddressAndPort; /** * This abstraction contains the token/identifier of this node - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18188:
-
Reviewers: Michael Semb Wever
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680046#comment-17680046
]
Brandon Williams commented on CASSANDRA-18188:
--
Testing
[here|https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade-driftx/1/].
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-11537:
Fix Version/s: 4.2
Source Control Link:
https://github.com/apache/cassandra/commit/035705f49464a4854482e1f1280a7af45f7f0203
(was: https://github.com/apache/cassandra/pull/2060)
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
committed as
[035705f49464a4854482e1f1280a7af45f7f0203|https://github.com/apache/cassandra/commit/035705f49464a4854482e1f1280a7af45f7f0203]
to trunk. Thanks!
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Fix For: 4.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-11537:
Status: Ready to Commit (was: Review In Progress)
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680044#comment-17680044
]
Ekaterina Dimitrova edited comment on CASSANDRA-18188 at 1/23/23 10:19 PM:
---
-Shall we open a ticket to look into CCM too? -
Ignore me, I misread the problem
was (Author: e.dimitrova):
Shall we open a ticket to look into CCM too?
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-11537:
Status: Review In Progress (was: Patch Available)
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680044#comment-17680044
]
Ekaterina Dimitrova edited comment on CASSANDRA-18188 at 1/23/23 10:19 PM:
---
-Shall we open a ticket to look into CCM too?-
Ignore me, I misread the problem
was (Author: e.dimitrova):
-Shall we open a ticket to look into CCM too? -
Ignore me, I misread the problem
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680044#comment-17680044
]
Ekaterina Dimitrova commented on CASSANDRA-18188:
-
Shall we open a ticket to look into CCM too?
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Print friendly error when nodetool attempts to connect to uninitialized server
This is an automated email from the ASF dual-hosted git repository.
paulo pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 035705f494 Print friendly error when nodetool attempts to connect to
uninitialized server
035705f494 is described below
commit 035705f49464a4854482e1f1280a7af45f7f0203
Author: williamvietnguyen
AuthorDate: Wed Dec 21 11:10:35 2022 -0800
Print friendly error when nodetool attempts to connect to uninitialized
server
Patch by William Nguyen; Reviewed by Paulo Motta, Brandon Williams for
CASSANDRA-11537
---
CHANGES.txt| 1 +
.../apache/cassandra/service/StorageService.java | 17 ++--
src/java/org/apache/cassandra/tools/NodeTool.java | 6 +++
.../org/apache/cassandra/tools/NodeProbeTest.java | 1 +
.../tools/nodetool/ClearSnapshotTest.java | 1 +
.../cassandra/tools/nodetool/CompactTest.java | 1 +
.../cassandra/tools/nodetool/GetAuditLogTest.java | 1 +
.../tools/nodetool/GetAuthCacheConfigTest.java | 1 +
.../tools/nodetool/GetFullQueryLogTest.java| 1 +
.../nodetool/InvalidateCredentialsCacheTest.java | 1 +
.../InvalidateJmxPermissionsCacheTest.java | 1 +
.../InvalidateNetworkPermissionsCacheTest.java | 1 +
.../nodetool/InvalidatePermissionsCacheTest.java | 1 +
.../tools/nodetool/InvalidateRolesCacheTest.java | 1 +
.../tools/nodetool/SetAuthCacheConfigTest.java | 1 +
.../tools/nodetool/SetGetColumnIndexSizeTest.java | 1 +
.../nodetool/SetGetCompactionThroughputTest.java | 1 +
...etEntireSSTableInterDCStreamThroughputTest.java | 1 +
.../SetGetEntireSSTableStreamThroughputTest.java | 1 +
.../SetGetInterDCStreamThroughputTest.java | 1 +
.../tools/nodetool/SetGetStreamThroughputTest.java | 1 +
.../cassandra/tools/nodetool/SnapshotTest.java | 1 +
.../tools/nodetool/UninitializedServerTest.java| 46 ++
23 files changed, 86 insertions(+), 3 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 881f9c2d5d..a1df8fea13 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.2
+ * Print friendly error when nodetool attempts to connect to uninitialized
server (CASSANDRA-11537)
* Use G1GC by default, and update default G1GC settings (CASSANDRA-18027)
* SimpleSeedProvider can resolve multiple IP addresses per DNS record
(CASSANDRA-14361)
* Remove mocking in InternalNodeProbe spying on StorageServiceMBean
(CASSANDRA-18152)
diff --git a/src/java/org/apache/cassandra/service/StorageService.java
b/src/java/org/apache/cassandra/service/StorageService.java
index 170dade2d5..47014536fb 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -381,12 +381,16 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
super(JMXBroadcastExecutor.executor);
jmxObjectName = "org.apache.cassandra.db:type=StorageService";
-MBeanWrapper.instance.registerMBean(this, jmxObjectName);
-MBeanWrapper.instance.registerMBean(StreamManager.instance,
StreamManager.OBJECT_NAME);
sstablesTracker = new
SSTablesGlobalTracker(SSTableFormat.Type.current());
}
+private void registerMBeans()
+{
+MBeanWrapper.instance.registerMBean(this, jmxObjectName);
+MBeanWrapper.instance.registerMBean(StreamManager.instance,
StreamManager.OBJECT_NAME);
+}
+
public void registerDaemon(CassandraDaemon daemon)
{
this.daemon = daemon;
@@ -844,7 +848,7 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
if (!Boolean.parseBoolean(System.getProperty("cassandra.start_gossip",
"true")))
{
logger.info("Not starting gossip as requested.");
-initialized = true;
+completeInitialization();
return;
}
@@ -882,6 +886,13 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
logger.info("Not joining ring as requested. Use JMX
(StorageService->joinRing()) to initiate ring joining");
}
+completeInitialization();
+}
+
+private void completeInitialization()
+{
+if (!initialized)
+registerMBeans();
initialized = true;
}
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index 5dca8eda73..5500240477 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -45,6 +45,8 @@ import java.util.Map.Entry;
import java.util.Scanner;
import java.util.SortedMap;
+import javax.management.InstanceNotFoundException;
+
import com.google.common.base.Joiner;
import
[jira] [Commented] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680041#comment-17680041
]
Ekaterina Dimitrova commented on CASSANDRA-18144:
-
Thank you for the patch, I just tried to push the patch to CI but I cannot
access Jenkins in the moment. I will post CI run later
Also, normally whoever submits a patch moves the ticket to patch available to
signal that it's ready for review. I almost missed your message in Slack.
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680039#comment-17680039
]
Michael Semb Wever commented on CASSANDRA-18188:
+1
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18188:
-
Test and Documentation Plan: fix ci
Status: Patch Available (was: Open)
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680038#comment-17680038
]
Brandon Williams commented on CASSANDRA-18188:
--
This is actually a problem w/3.11 and ccm, so the best solution is going back
to running everything on 3.8 like before. I have a patch for that
[here|https://github.com/driftx/cassandra-builds/commit/291154198efbc8e95129a9a520b70e56379394e3].
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18144:
Test and Documentation Plan: [https://github.com/apache/cassandra/pull/2107]
Status: Patch Available (was: In Progress)
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18190) ECJ upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18190: Change Category: Operability Complexity: Normal Component/s: Feature/UDF Status: Open (was: Triage Needed) > ECJ upgrade > --- > > Key: CASSANDRA-18190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18190 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Priority: Normal > > During testing it was identified that we will need to update ECJ for the Java > UDF functions in order to bring Java 17 in. > It seems the compiler artifacts are moved from > [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ] > to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is > change of license from EPL1.0 to EPL2.0 too. But if I read correctly > [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that > should not affect us > Further testing and review of all changes between artifacts to be done. > ECJ is used for the eclipse-warnings and Java UDFs -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18190) ECJ upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18190: Fix Version/s: 4.x > ECJ upgrade > --- > > Key: CASSANDRA-18190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18190 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > During testing it was identified that we will need to update ECJ for the Java > UDF functions in order to bring Java 17 in. > It seems the compiler artifacts are moved from > [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ] > to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is > change of license from EPL1.0 to EPL2.0 too. But if I read correctly > [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that > should not affect us > Further testing and review of all changes between artifacts to be done. > ECJ is used for the eclipse-warnings and Java UDFs -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18190) ECJ upgrade
Ekaterina Dimitrova created CASSANDRA-18190: --- Summary: ECJ upgrade Key: CASSANDRA-18190 URL: https://issues.apache.org/jira/browse/CASSANDRA-18190 Project: Cassandra Issue Type: Task Reporter: Ekaterina Dimitrova During testing it was identified that we will need to update ECJ for the Java UDF functions in order to bring Java 17 in. It seems the compiler artifacts are moved from [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ] to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is change of license from EPL1.0 to EPL2.0 too. But if I read correctly [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that should not affect us Further testing and review of all changes between artifacts to be done. ECJ is used for the eclipse-warnings and Java UDFs -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18189) Test failure in cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
[
https://issues.apache.org/jira/browse/CASSANDRA-18189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18189:
Labels: cqlsh dtest python test (was: )
> Test failure in
> cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
>
>
> Key: CASSANDRA-18189
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18189
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Labels: cqlsh, dtest, python, test
> Fix For: 4.0.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-4.0/523/testReport/dtest.cqlsh_tests.test_cqlsh_copy/TestCqlshCopy/test_bulk_round_trip_with_timeouts/
> {noformat}
> assert 10 == 94764
> + where 10 = sum( TestCqlshCopy._test_bulk_round_trip.. at 0x7f8b21987b90>)
> + and 94764 = sum( TestCqlshCopy._test_bulk_round_trip.. at 0x7f8b21986dc0>)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18189) Test failure in cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
[
https://issues.apache.org/jira/browse/CASSANDRA-18189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18189:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: DTest
Fix Version/s: 4.0.x
Severity: Normal
Status: Open (was: Triage Needed)
> Test failure in
> cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
>
>
> Key: CASSANDRA-18189
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18189
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-4.0/523/testReport/dtest.cqlsh_tests.test_cqlsh_copy/TestCqlshCopy/test_bulk_round_trip_with_timeouts/
> {noformat}
> assert 10 == 94764
> + where 10 = sum( TestCqlshCopy._test_bulk_round_trip.. at 0x7f8b21987b90>)
> + and 94764 = sum( TestCqlshCopy._test_bulk_round_trip.. at 0x7f8b21986dc0>)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18189) Test failure in cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
Caleb Rackliffe created CASSANDRA-18189:
---
Summary: Test failure in
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
Key: CASSANDRA-18189
URL: https://issues.apache.org/jira/browse/CASSANDRA-18189
Project: Cassandra
Issue Type: Bug
Components: Test/dtest/python
Reporter: Caleb Rackliffe
https://ci-cassandra.apache.org/job/Cassandra-4.0/523/testReport/dtest.cqlsh_tests.test_cqlsh_copy/TestCqlshCopy/test_bulk_round_trip_with_timeouts/
{noformat}
assert 10 == 94764
+ where 10 = sum(. at 0x7f8b21987b90>)
+ and 94764 = sum(. at 0x7f8b21986dc0>)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18150) Prefer snakeyaml's SafeConstructor over Constructor
[ https://issues.apache.org/jira/browse/CASSANDRA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680035#comment-17680035 ] Brandon Williams edited comment on CASSANDRA-18150 at 1/23/23 9:55 PM: --- I think we should punt jmxtool for now. It doesn't pose an RCE threat to the server process so I think it's a very low priority and perhaps not worth the effort. We are planning minor releases soon however, and I think it's in our best interest to close the RCE possibility there before doing so. WDYT? was (Author: brandon.williams): I think we should punt in jmxtool for now. It doesn't pose an RCE threat to the server process so I think it's a very low priority and perhaps not worth the effort. We are planning minor releases soon however, and I think it's in our best interest to close the RCE possibility there before doing so. WDYT? > Prefer snakeyaml's SafeConstructor over Constructor > --- > > Key: CASSANDRA-18150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18150 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > CVE-2022-1471 allows RCE through the Constructor class. While this isn't a > concern since yaml is only used for configuration, it is simple enough to > switch to SafeConstructor and harden the server a little more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18150) Prefer snakeyaml's SafeConstructor over Constructor
[ https://issues.apache.org/jira/browse/CASSANDRA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680035#comment-17680035 ] Brandon Williams commented on CASSANDRA-18150: -- I think we should punt in jmxtool for now. It doesn't pose an RCE threat to the server process so I think it's a very low priority and perhaps not worth the effort. We are planning minor releases soon however, and I think it's in our best interest to close the RCE possibility there before doing so. WDYT? > Prefer snakeyaml's SafeConstructor over Constructor > --- > > Key: CASSANDRA-18150 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18150 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > CVE-2022-1471 allows RCE through the Constructor class. While this isn't a > concern since yaml is only used for configuration, it is simple enough to > switch to SafeConstructor and harden the server a little more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680032#comment-17680032
]
Brandon Williams commented on CASSANDRA-18188:
--
This looks like fallout from CASSANDRA-18088, I'll look into it. I am a bit
surprised that jenkins decided to run all the tests under 3.11, though.
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-18188:
Assignee: Brandon Williams
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Assignee: Brandon Williams
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18188:
Labels: dtest python test upgrade-dtest (was: )
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Labels: dtest, python, test, upgrade-dtest
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18188:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: Test/dtest/python
Discovered By: DTest
Fix Version/s: 4.x
Severity: Normal
Status: Open (was: Triage Needed)
> Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
> -
>
> Key: CASSANDRA-18188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
> {noformat}
> self = 0x7f27f9268e10>
> def test_limit_ranges(self):
> """ Validate LIMIT option for 'range queries' in SELECT statements """
> cursor = self.prepare(ordered=True)
>
> cursor.execute("""
> CREATE TABLE clicks (
> userid int,
> url text,
> time bigint,
> PRIMARY KEY (userid, url)
> ) WITH COMPACT STORAGE;
> """)
>
> > for is_upgraded, cursor in self.do_upgrade(cursor):
> upgrade_tests/cql_tests.py:318:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_base.py:197: in do_upgrade
> node1.start(wait_for_binary_proto=True)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
> time.sleep(1)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> title = 'Timeout'
> stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
> sep = '+'
> def write_title(title, stream=None, sep="~"):
> """Write a section title.
>
> If *stream* is None sys.stderr will be used, *sep* is used to
> draw the line.
> """
> if stream is None:
> stream = sys.stderr
> > width = py.io.get_terminal_width()
> E AttributeError: module 'py' has no attribute 'io'
> ../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18188) Test failure in upgrade_tests.cql_tests.cls.test_limit_ranges
Caleb Rackliffe created CASSANDRA-18188:
---
Summary: Test failure in
upgrade_tests.cql_tests.cls.test_limit_ranges
Key: CASSANDRA-18188
URL: https://issues.apache.org/jira/browse/CASSANDRA-18188
Project: Cassandra
Issue Type: Bug
Reporter: Caleb Rackliffe
https://ci-cassandra.apache.org/job/Cassandra-trunk/1434/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_limit_ranges/
{noformat}
self =
def test_limit_ranges(self):
""" Validate LIMIT option for 'range queries' in SELECT statements """
cursor = self.prepare(ordered=True)
cursor.execute("""
CREATE TABLE clicks (
userid int,
url text,
time bigint,
PRIMARY KEY (userid, url)
) WITH COMPACT STORAGE;
""")
> for is_upgraded, cursor in self.do_upgrade(cursor):
upgrade_tests/cql_tests.py:318:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
upgrade_tests/upgrade_base.py:197: in do_upgrade
node1.start(wait_for_binary_proto=True)
../venv/lib/python3.11/site-packages/ccmlib/node.py:896: in start
node.watch_log_for_alive(self, from_mark=mark)
../venv/lib/python3.11/site-packages/ccmlib/node.py:665: in watch_log_for_alive
self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
filename=filename)
../venv/lib/python3.11/site-packages/ccmlib/node.py:584: in watch_log_for
time.sleep(1)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
title = 'Timeout'
stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
sep = '+'
def write_title(title, stream=None, sep="~"):
"""Write a section title.
If *stream* is None sys.stderr will be used, *sep* is used to
draw the line.
"""
if stream is None:
stream = sys.stderr
> width = py.io.get_terminal_width()
E AttributeError: module 'py' has no attribute 'io'
../venv/lib/python3.11/site-packages/pytest_timeout.py:444: AttributeError
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18179) Update build.xml for experimental JDK17 use
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680031#comment-17680031 ] Ekaterina Dimitrova edited comment on CASSANDRA-18179 at 1/23/23 9:34 PM: -- Note: we have CASSANDRA_USE_JDK11 documented , so I guess we will need also to update the docs for trunk when we remove it. Could be separate ticket if we want in general to add some additional info around JDK. Just mentioning so we do not forget about it and confuse people. I am referring to this page - [https://cassandra.apache.org/doc/latest/cassandra/getting_started/java11.html] I looked at the CI runs and nothing stood me as an issue related to this work. Seems to me almost all failures already have associated tickets (I can open tickets for those that don't have yet when we are done here) Pulled your change to my J17 branch and locally things seemed fine, I also pushed some preliminary [run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2188/workflows/1ac46d21-56cf-4041-88b3-ac70577f898c] of a few jobs with J17 with that branch, just for a sanity check Applied your hack to CASSANDRA_USE_JDK17 too until we work out the CCM patch Also, I think we should change the commit message as I think it is too early to say that we add support for J17 in this ticket. I would say - "in preparation for" so that someone doesn't get confused. Considering the amount of work around the project someone can easily miss the actual status of things. was (Author: e.dimitrova): Note: we have CASSANDRA_USE_JDK11 documented , so I guess we will need also to update the docs for trunk when we remove it. Could be separate ticket if we want in general to add some additional info around JDK. Just mentioning so we do not forget about it and confuse people. I am referring to this page - [https://cassandra.apache.org/doc/latest/cassandra/getting_started/java11.html] I looked at the CI runs and nothing stood me as an issue related to this work. Seems to me almost all failures already have associated tickets (I can open tickets for those that don't have yet when we are done here) Pulled your change to my J17 branch and locally things seemed fine, I also pushed some preliminary run of a few jobs with J17 with that branch, just for a sanity check Applied your hack to CASSANDRA_USE_JDK17 too until we work out the CCM patch Also, I think we should change the commit message as I think it is too early to say that we add support for J17 in this ticket. I would say - "in preparation for" so that someone doesn't get confused. Considering the amount of work around the project someone can easily miss the actual status of things. > Update build.xml for experimental JDK17 use > --- > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18179) Update build.xml for experimental JDK17 use
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680031#comment-17680031 ] Ekaterina Dimitrova commented on CASSANDRA-18179: - Note: we have CASSANDRA_USE_JDK11 documented , so I guess we will need also to update the docs for trunk when we remove it. Could be separate ticket if we want in general to add some additional info around JDK. Just mentioning so we do not forget about it and confuse people. I am referring to this page - [https://cassandra.apache.org/doc/latest/cassandra/getting_started/java11.html] I looked at the CI runs and nothing stood me as an issue related to this work. Seems to me almost all failures already have associated tickets (I can open tickets for those that don't have yet when we are done here) Pulled your change to my J17 branch and locally things seemed fine, I also pushed some preliminary run of a few jobs with J17 with that branch, just for a sanity check Applied your hack to CASSANDRA_USE_JDK17 too until we work out the CCM patch Also, I think we should change the commit message as I think it is too early to say that we add support for J17 in this ticket. I would say - "in preparation for" so that someone doesn't get confused. Considering the amount of work around the project someone can easily miss the actual status of things. > Update build.xml for experimental JDK17 use > --- > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (d5b15633b -> fdec73b35)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d5b15633b generate docs for 5dd84ab2 new fdec73b35 generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d5b15633b) \ N -- N -- N refs/heads/asf-staging (fdec73b35) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18050) Update JNA
[ https://issues.apache.org/jira/browse/CASSANDRA-18050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680023#comment-17680023 ] Brandon Williams edited comment on CASSANDRA-18050 at 1/23/23 8:57 PM: --- JNA now starts a "JNA Cleaner" thread that tools tests need to account for, [here|https://github.com/driftx/cassandra/commit/f4f5a04f1f2fb830aeb6e00d312f45c1625cb07d] and [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/807/workflows/aa0575ff-13cb-442a-b32f-92e43b555667]. was (Author: brandon.williams): JNA now starts a "JNA Cleaner" thread that tools tests need to account for, [here|https://github.com/driftx/cassandra/commit/f4f5a04f1f2fb830aeb6e00d312f45c1625cb07d]] and [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/807/workflows/aa0575ff-13cb-442a-b32f-92e43b555667]. > Update JNA > -- > > Key: CASSANDRA-18050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18050 > Project: Cassandra > Issue Type: Task >Reporter: Ekaterina Dimitrova >Priority: Normal > > JNA needs to be updated for JDK 17 support. There was an update pre-4.0 but > not to the latest version (confirmed with the people involved, there was no > particular reason not to update to the latest version, just missed on rebase > of older PR) > More details to come, opening this as a placeholder for now -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18050) Update JNA
[ https://issues.apache.org/jira/browse/CASSANDRA-18050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680023#comment-17680023 ] Brandon Williams commented on CASSANDRA-18050: -- JNA now starts a "JNA Cleaner" thread that tools tests need to account for, [here|https://github.com/driftx/cassandra/commit/f4f5a04f1f2fb830aeb6e00d312f45c1625cb07d]] and [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/807/workflows/aa0575ff-13cb-442a-b32f-92e43b555667]. > Update JNA > -- > > Key: CASSANDRA-18050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18050 > Project: Cassandra > Issue Type: Task >Reporter: Ekaterina Dimitrova >Priority: Normal > > JNA needs to be updated for JDK 17 support. There was an update pre-4.0 but > not to the latest version (confirmed with the people involved, there was no > particular reason not to update to the latest version, just missed on rebase > of older PR) > More details to come, opening this as a placeholder for now -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16418) Unsafe to run nodetool cleanup during bootstrap or decommission
[ https://issues.apache.org/jira/browse/CASSANDRA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680021#comment-17680021 ] Stefan Miklosovic commented on CASSANDRA-16418: --- +1. thanks! > Unsafe to run nodetool cleanup during bootstrap or decommission > --- > > Key: CASSANDRA-16418 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16418 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: James Baker >Assignee: Lindsey Zurovchak >Priority: Normal > Fix For: 4.0.x > > Time Spent: 3h > Remaining Estimate: 0h > > What we expected: Running a cleanup is a safe operation; the result of > running a query after a cleanup should be the same as the result of running a > query before a cleanup. > What actually happened: We ran a cleanup during a decommission. All the > streamed data was silently deleted, the bootstrap did not fail, the cluster's > data after the decommission was very different to the state before. > Why: Cleanups do not take into account pending ranges and so the cleanup > thought that all the data that had just been streamed was redundant and so > deleted it. We think that this is symmetric with bootstraps, though have not > verified. > Not sure if this is technically a bug but it was very surprising (and > seemingly undocumented) behaviour. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (4b891a24f -> d5b15633b)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 4b891a24f generate docs for 5dd84ab2 new d5b15633b generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4b891a24f) \ N -- N -- N refs/heads/asf-staging (d5b15633b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17112) CEP-15: (C*) Strict Serializability verification
[ https://issues.apache.org/jira/browse/CASSANDRA-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17112: -- Fix Version/s: (was: 4.x) 5.x Source Control Link: https://github.com/apache/cassandra/commit/0ddfbbdeee813a9d16980ad0f80e183eaf919b50 Resolution: Fixed Status: Resolved (was: Ready to Commit) > CEP-15: (C*) Strict Serializability verification > > > Key: CASSANDRA-17112 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17112 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Benedict Elliott Smith >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 5.x > > Time Spent: 7h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated: CASSANDRA-18154: CEP-15: Enhance returning SELECT to allow partition and clustering IN clauses to return multiple partitions/rows
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cep-15-accord by this push:
new 0ddfbbdeee CASSANDRA-18154: CEP-15: Enhance returning SELECT to allow
partition and clustering IN clauses to return multiple partitions/rows
0ddfbbdeee is described below
commit 0ddfbbdeee813a9d16980ad0f80e183eaf919b50
Author: David Capwell
AuthorDate: Thu Jan 12 12:07:54 2023 -0800
CASSANDRA-18154: CEP-15: Enhance returning SELECT to allow partition and
clustering IN clauses to return multiple partitions/rows
---
.build/cassandra-build-deps-template.xml | 5 +
.build/include-accord.sh | 2 +-
.build/parent-pom-template.xml | 21 +
build.xml | 6 +-
ide/idea-iml-file.xml | 1 +
ide/idea/workspace.xml | 35 +-
.../metrics/AccordClientRequestMetrics.java| 37 +-
.../cassandra/service/accord/AccordCommand.java| 2 +
.../cassandra/service/accord/AccordService.java| 27 +
.../cassandra/utils/logging/ClassNameFilter.java | 38 +-
test/conf/logback-simulator.xml| 14 +
.../org/apache/cassandra/distributed/api/Row.java | 160 ++
.../apache/cassandra/distributed/impl/Query.java | 12 +-
.../distributed/util/QueryResultUtil.java | 2 +
.../org/apache/cassandra/simulator/ActionList.java | 4 +
.../AbstractPairOfSequencesPaxosSimulation.java| 201 +++
.../cassandra/simulator/paxos/HistoryChecker.java | 32 +-
.../{Observation.java => HistoryValidator.java}| 41 +-
.../simulator/paxos/LinearizabilityValidator.java | 83 +++
.../simulator/paxos/LoggingHistoryValidator.java | 73 +++
.../cassandra/simulator/paxos/Observation.java | 16 +-
.../paxos/PairOfSequencesAccordSimulation.java | 310 +--
.../paxos/PairOfSequencesPaxosSimulation.java | 165 +-
.../cassandra/simulator/paxos/PaxosSimulation.java | 53 +-
.../paxos/StrictSerializabilityValidator.java | 112
.../simulator/systems/SimulatedQuery.java | 5 +-
.../simulator/paxos/HistoryValidatorTest.java | 592 +
.../cassandra/service/accord/AccordTestUtils.java | 14 +-
.../org/apache/cassandra/utils/AssertionUtils.java | 46 +-
29 files changed, 1727 insertions(+), 382 deletions(-)
diff --git a/.build/cassandra-build-deps-template.xml
b/.build/cassandra-build-deps-template.xml
index 727da9179a..23e00b1986 100644
--- a/.build/cassandra-build-deps-template.xml
+++ b/.build/cassandra-build-deps-template.xml
@@ -123,5 +123,10 @@
com.fasterxml.jackson.dataformat
jackson-dataformat-yaml
+
+ accord
+ accord
+ tests
+
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 2144e80b17..eabe4d204b 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -25,7 +25,7 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='ad326d5df8d99d4799fa87de81482e3cb1fb92de'
+accord_branch='5626c7c11400d4cf6d01a8e22517b53a83f5c512'
accord_src="$bin/cassandra-accord"
checkout() {
diff --git a/.build/parent-pom-template.xml b/.build/parent-pom-template.xml
index b57beb2d93..2ce7d5bb51 100644
--- a/.build/parent-pom-template.xml
+++ b/.build/parent-pom-template.xml
@@ -673,6 +673,27 @@
accord
1.0-SNAPSHOT
+
+accord
+accord
+1.0-SNAPSHOT
+tests
+test
+
+
+org.junit.jupiter
+junit-jupiter-api
+
+
+org.junit.jupiter
+junit-jupiter-engine
+
+
+ch.qos.logback
+logback-classic
+
+
+
io.airlift
airline
diff --git a/build.xml b/build.xml
index 8628de5e8f..fc42dfa30a 100644
--- a/build.xml
+++ b/build.xml
@@ -1063,7 +1063,7 @@
-
+
+
+
./build/test/logs/simulator/${run_start}-${run_seed}/history.log
+
+ %msg%n
+
+true
+
+
org.apache.cassandra.simulator.paxos.LoggingHistoryValidator
+ ACCEPT
+ DENY
+
+
+
./build/test/logs/simulator/${run_start}-${run_seed}/${instance_id}/system.log
@@ -56,6 +69,7 @@
+
diff --git a/test/distributed/org/apache/cassandra/distributed/api/Row.java
b/test/distributed/org/apache/cassandra/distributed/api/Row.java
index 33272ed3d5..556a5716c0 100644
--- a/test/distributed/org/apache/cassandra/distributed/api/Row.java
+++ b/test/distributed/org/apache/cassandra/distributed/api/Row.java
@@ -21,6 +21,7 @@ package
[jira] [Updated] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18187: - Status: Open (was: Patch Available) > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680017#comment-17680017 ] Brandon Williams commented on CASSANDRA-18187: -- Unfortunately it looks like there is flakiness in testWriteWithTtl. Can you take a look? > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated: Ninja fix DatabaseDescriptorRefTest
This is an automated email from the ASF dual-hosted git repository. aweisberg pushed a commit to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cep-15-accord by this push: new 56d7e69143 Ninja fix DatabaseDescriptorRefTest 56d7e69143 is described below commit 56d7e6914399f35ccdc47cb4cfc4891c81f6 Author: Ariel Weisberg AuthorDate: Mon Jan 23 15:06:05 2023 -0500 Ninja fix DatabaseDescriptorRefTest --- test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java b/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java index 3ee05cf96f..9ef418b492 100644 --- a/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java +++ b/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java @@ -81,6 +81,7 @@ public class DatabaseDescriptorRefTest "org.apache.cassandra.config.Config$DiskOptimizationStrategy", "org.apache.cassandra.config.Config$FlushCompression", "org.apache.cassandra.config.Config$InternodeCompression", +"org.apache.cassandra.config.Config$LegacyPaxosStrategy", "org.apache.cassandra.config.Config$MemtableAllocationType", "org.apache.cassandra.config.Config$PaxosOnLinearizabilityViolation", "org.apache.cassandra.config.Config$PaxosStatePurging", - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17427) Improve unit tests performance
[ https://issues.apache.org/jira/browse/CASSANDRA-17427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680013#comment-17680013 ] Josh McKenzie edited comment on CASSANDRA-17427 at 1/23/23 8:04 PM: +1 w/the latest changes. was (Author: jmckenzie): 1 w/the latest changes. > Improve unit tests performance > -- > > Key: CASSANDRA-17427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17427 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Attachments: screenshot-1.png > > Time Spent: 4h 20m > Remaining Estimate: 0h > > There a couple of small improvements to run unit tests a bit faster -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17427) Improve unit tests performance
[ https://issues.apache.org/jira/browse/CASSANDRA-17427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680013#comment-17680013 ] Josh McKenzie commented on CASSANDRA-17427: --- 1 w/the latest changes. > Improve unit tests performance > -- > > Key: CASSANDRA-17427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17427 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Attachments: screenshot-1.png > > Time Spent: 4h 20m > Remaining Estimate: 0h > > There a couple of small improvements to run unit tests a bit faster -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-accord] branch trunk updated: CASSANDRA-17112: Publish StrictSerializabilityVerifier so Cassandra may use, and fixed bugs found with the integration (#18)
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5626c7c CASSANDRA-17112: Publish StrictSerializabilityVerifier so
Cassandra may use, and fixed bugs found with the integration (#18)
5626c7c is described below
commit 5626c7c11400d4cf6d01a8e22517b53a83f5c512
Author: dcapwell
AuthorDate: Mon Jan 23 11:45:13 2023 -0800
CASSANDRA-17112: Publish StrictSerializabilityVerifier so Cassandra may
use, and fixed bugs found with the integration (#18)
---
accord-core/build.gradle | 9 +
.../main/java/accord/impl/SimpleProgressLog.java | 9 +-
.../test/java/accord/verify/HistoryViolation.java | 4 +
.../verify/StrictSerializabilityVerifier.java | 153 ++-
.../verify/StrictSerializabilityVerifierTest.java | 216 -
5 files changed, 330 insertions(+), 61 deletions(-)
diff --git a/accord-core/build.gradle b/accord-core/build.gradle
index 7db65e9..146f9fa 100644
--- a/accord-core/build.gradle
+++ b/accord-core/build.gradle
@@ -48,6 +48,10 @@ task burn(type: JavaExec) {
// the team is used to 'install' so make sure that still publishes locally
task install(dependsOn: publishToMavenLocal)
+task testJar(type: Jar, dependsOn: testClasses) {
+ archiveClassifier = 'tests'
+ from sourceSets.test.output
+}
publishing {
publications {
@@ -58,6 +62,11 @@ publishing {
}
from components.java
}
+
+test(MavenPublication) {
+ artifactId = 'accord'
+ artifact testJar
+}
}
}
diff --git a/accord-core/src/main/java/accord/impl/SimpleProgressLog.java
b/accord-core/src/main/java/accord/impl/SimpleProgressLog.java
index 7fff500..e27553f 100644
--- a/accord-core/src/main/java/accord/impl/SimpleProgressLog.java
+++ b/accord-core/src/main/java/accord/impl/SimpleProgressLog.java
@@ -126,11 +126,12 @@ public class SimpleProgressLog implements
ProgressLog.Factory
{
switch (progress)
{
-default: throw new AssertionError();
+default: throw new AssertionError("Unexpected
progress: " + progress);
case NoneExpected:
case Done:
+return false;
case Investigating:
-throw new IllegalStateException();
+throw new IllegalStateException("Unexpected
progress: " + progress);
case Expected:
Invariants.paranoid(!isFree());
progress = NoProgress;
@@ -209,11 +210,11 @@ public class SimpleProgressLog implements
ProgressLog.Factory
setProgress(Investigating);
switch (status)
{
-default: throw new AssertionError();
+default: throw new AssertionError("Unexpected status:
" + status);
case NotWitnessed: // can't make progress if we
haven't witnessed it yet
case Committed: // can't make progress if we aren't
yet ReadyToExecute
case Done: // shouldn't be trying to make progress, as
we're done
-throw new IllegalStateException();
+throw new IllegalStateException("Unexpected
status: " + status);
case Uncommitted:
case ReadyToExecute:
diff --git a/accord-core/src/test/java/accord/verify/HistoryViolation.java
b/accord-core/src/test/java/accord/verify/HistoryViolation.java
index 5df0573..6e31ceb 100644
--- a/accord-core/src/test/java/accord/verify/HistoryViolation.java
+++ b/accord-core/src/test/java/accord/verify/HistoryViolation.java
@@ -27,4 +27,8 @@ public class HistoryViolation extends AssertionError
super(detailMessage);
this.primaryKey = primaryKey;
}
+
+public int primaryKey() {
+return primaryKey;
+}
}
diff --git
a/accord-core/src/test/java/accord/verify/StrictSerializabilityVerifier.java
b/accord-core/src/test/java/accord/verify/StrictSerializabilityVerifier.java
index 44374c1..98e6217 100644
--- a/accord-core/src/test/java/accord/verify/StrictSerializabilityVerifier.java
+++ b/accord-core/src/test/java/accord/verify/StrictSerializabilityVerifier.java
@@ -30,7 +30,9 @@ import java.util.TreeSet;
import java.util.function.Consumer;
import java.util.stream.IntStream;
-import accord.utils.Invariants;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import static java.util.stream.Collectors.joining;
/**
* Nomenclature:
@@ -43,34 +45,36 @@ import accord.utils.Invariants;
* two kinds: 1) those values for keys [B,C..)
[jira] [Commented] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679990#comment-17679990 ] Brandon Williams commented on CASSANDRA-18187: -- This looks good to me. Circle is running with the tests multiplexed here: [j8|https://app.circleci.com/pipelines/github/driftx/cassandra/806/workflows/6ed083b5-b272-45f5-b480-1af6aa3c365f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/806/workflows/62b47429-4516-4da7-a784-e03e431340c6]. > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18187: - Fix Version/s: 4.x (was: NA) > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18187: - Reviewers: Brandon Williams > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17941) CQL data masking functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679988#comment-17679988
]
Andres de la Peña commented on CASSANDRA-17941:
---
Following the discussion on the PR about the return data types and the progress
on CASSANDRA-18068 (almost ready!), I have done some changes on the behaviour
of the functions:
* {{mask_inner}} and {{mask_default}} only accept string-based values (text,
ascii and varchar). The return value will be always be of the same type as the
masked input.
* {{mask_replace}} requires that the replaced value and its replacement have
the same type, so the return value will be always be of the same type as the
masked input.
These restrictions make that all the functions but {{mask_hash}} return values
of the same value as their input. It also allows to make the functions a bit
smarter when dealing with compatible types, like masking a {{text}} value by
replacing it with an {{ascii}} value, so we don't need type hints in most cases.
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1892]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2580/workflows/85776fef-728c-407f-94af-cfbf0ddc6f87]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2580/workflows/03d1ee80-5c95-44f5-ba17-4343c5f143b1]|
> CQL data masking functions
> --
>
> Key: CASSANDRA-17941
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17941
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add native CQL functions to mask the contents of a column, as described in
> [CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Rohrer updated CASSANDRA-18187: Change Category: Quality Assurance Complexity: Low Hanging Fruit Component/s: Test/unit Fix Version/s: NA Priority: Low (was: Normal) Status: Open (was: Triage Needed) > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679981#comment-17679981 ] Doug Rohrer commented on CASSANDRA-18187: - Trunk PR: [https://github.com/apache/cassandra/pull/2109] > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Rohrer updated CASSANDRA-18187: Test and Documentation Plan: This change just adds new tests - see [https://github.com/apache/cassandra/pull/2109] Status: Patch Available (was: Open) > Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter > -- > > Key: CASSANDRA-18187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Low > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > CQLSSTableWriter supports per-row setting of both timestamp and TTL values, > but it’s not tested or documented today. Add tests to cover setting both TTL > and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18187) Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter
Doug Rohrer created CASSANDRA-18187: --- Summary: Add unit tests for per-row TTL and Timestamp usage in CQLSSTableWriter Key: CASSANDRA-18187 URL: https://issues.apache.org/jira/browse/CASSANDRA-18187 Project: Cassandra Issue Type: Improvement Reporter: Doug Rohrer Assignee: Doug Rohrer CQLSSTableWriter supports per-row setting of both timestamp and TTL values, but it’s not tested or documented today. Add tests to cover setting both TTL and Timestamp values for rows using the CQLSSTableWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17925:
Test and Documentation Plan:
The documentation must be updated once an agreement on this issue will be
reached.
To test do the following:
{code:java}
$ git fetch upstream pull/2108/head:cassandra-17925
$ ant checkstyle
$ ant checkstyle-test{code}
Status: Patch Available (was: In Progress)
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17925:
Fix Version/s: 4.x
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679968#comment-17679968
]
Maxim Muzafarov commented on CASSANDRA-17925:
-
This is the discussion on the dev-list about the classes import order
[https://lists.apache.org/thread/d7wgg5hf4khzkwyd3hgnooowxl5b8dg1]
While preparing the code style configuration for the Eclipse IDE, I discovered
that there was no easy way to have complex grouping options for the set of
packages. So we need to add extra blank lines between each group of packages so
that all the configurations for Eclipse, NetBeans, IntelliJ IDEA and checkstyle
are aligned. I should have checked this earlier for sure, but I only did it for
static imports and some groups, my bad. The resultant configuration looks like
this:
{code:java}
java.*
[blank line]
javax.*
[blank line]
com.*
[blank line]
net.*
[blank line]
org.*
[blank line]
org.apache.cassandra.*
[blank line]
all other imports
[blank line]
static all other imports
{code}
The changes include:
* The AvoidStarImport and ImportOrder rules were added to checkstyle.xml and
checkstyle_test.xml;
* The codeStyleSettings.xml migrated to a new IntelliJ IDEA format. This
configuration file is deprecated since IntelliJ IDEA 2017.3 and is not used
anymore. All code style settings are located under
/.idea/codeStyles directory and consist of the following files:
codeStyleConfig.xml, Project.xml;
* The Eclipse code style configuration was added from the link mentioned in
the documentation pages: [https://github.com/tjake/cassandra-style-eclipse]
The pull request is here:
[GitHub PullRequest: 2108|https://github.com/apache/cassandra/pull/2108]
The configuration-related changes are placed in a dedicated commit, so it
should be easy to make a review:
[84e292ddc9671a0be76ceb9304b2b9a051c2d52a|https://github.com/apache/cassandra/pull/2108/commits/84e292ddc9671a0be76ceb9304b2b9a051c2d52a]
The Jenkins build is here:
[https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2215/]
Another important thing to mention is that the total amount of changes for
organising imports is really big (more than 2000 files!), so we need to decide
the right time to merge this PR. Although rebasing or merging changes to
development branches should become much easier ("Accept local" + "Organize
imports"), we still need to pay extra attention here to minimise the impact on
major patches for the next release.
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale:
[jira] [Comment Edited] (CASSANDRA-18050) Update JNA
[ https://issues.apache.org/jira/browse/CASSANDRA-18050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679932#comment-17679932 ] Brandon Williams edited comment on CASSANDRA-18050 at 1/23/23 6:04 PM: --- As a first step, lets see what shakes out from CI with 5.13: [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/805/workflows/0bd79f51-771f-43e5-abf8-2bd666c760f7], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2217/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2217/pipeline]. was (Author: brandon.williams): As a first step, lets see what shakes out from CI with 5.13: [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/804/workflows/b9c730e3-5aa7-4e0e-9aaa-2b6cbd6d35c0], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2217/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2217/pipeline]. > Update JNA > -- > > Key: CASSANDRA-18050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18050 > Project: Cassandra > Issue Type: Task >Reporter: Ekaterina Dimitrova >Priority: Normal > > JNA needs to be updated for JDK 17 support. There was an update pre-4.0 but > not to the latest version (confirmed with the people involved, there was no > particular reason not to update to the latest version, just missed on rebase > of older PR) > More details to come, opening this as a placeholder for now -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14598) [dtest] flakey test: test_decommissioned_node_cant_rejoin - topology_test.TestTopology
[
https://issues.apache.org/jira/browse/CASSANDRA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679937#comment-17679937
]
Caleb Rackliffe edited comment on CASSANDRA-14598 at 1/23/23 5:43 PM:
--
This seems to have reappeared in a 4.0 run here:
[https://ci-cassandra.apache.org/job/Cassandra-4.1/250/testReport/dtest.topology_test/TestTopology/test_decommissioned_node_cant_rejoin/]
was (Author: maedhroz):
This seems to have reappeared in
[https://ci-cassandra.apache.org/job/Cassandra-4.1/250/testReport/dtest.topology_test/TestTopology/test_decommissioned_node_cant_rejoin/]
> [dtest] flakey test: test_decommissioned_node_cant_rejoin -
> topology_test.TestTopology
> --
>
> Key: CASSANDRA-14598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14598
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Jason Brown
>Priority: Low
> Labels: dtest
>
> Only saw this fail on 3.0, but looks like a problem with the dtest itself
> (ubder some failure scenario). Output from pytest error:
> {noformat}
> > assert re.search(rejoin_err,
> '\n'.join(['\n'.join(err_list) for err_list in
> node3.grep_log_for_errors()]), re.MULTILINE)
> E AssertionError: assert None
> E + where None = ('This node was
> decommissioned and will not rejoin the ring', '', )
> E + where = re.search
> E + and '' = ([])
> E + where = '\n'.join
> E + and = re.MULTILINE
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14598) [dtest] flakey test: test_decommissioned_node_cant_rejoin - topology_test.TestTopology
[
https://issues.apache.org/jira/browse/CASSANDRA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-14598:
Resolution: (was: Auto Closed)
Status: Open (was: Resolved)
This seems to have reappeared in
[https://ci-cassandra.apache.org/job/Cassandra-4.1/250/testReport/dtest.topology_test/TestTopology/test_decommissioned_node_cant_rejoin/]
> [dtest] flakey test: test_decommissioned_node_cant_rejoin -
> topology_test.TestTopology
> --
>
> Key: CASSANDRA-14598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14598
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Jason Brown
>Priority: Low
> Labels: dtest
>
> Only saw this fail on 3.0, but looks like a problem with the dtest itself
> (ubder some failure scenario). Output from pytest error:
> {noformat}
> > assert re.search(rejoin_err,
> '\n'.join(['\n'.join(err_list) for err_list in
> node3.grep_log_for_errors()]), re.MULTILINE)
> E AssertionError: assert None
> E + where None = ('This node was
> decommissioned and will not rejoin the ring', '', )
> E + where = re.search
> E + and '' = ([])
> E + where = '\n'.join
> E + and = re.MULTILINE
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18050) Update JNA
[ https://issues.apache.org/jira/browse/CASSANDRA-18050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679932#comment-17679932 ] Brandon Williams edited comment on CASSANDRA-18050 at 1/23/23 5:42 PM: --- As a first step, lets see what shakes out from CI with 5.13: [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/804/workflows/b9c730e3-5aa7-4e0e-9aaa-2b6cbd6d35c0], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2217/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2217/pipeline]. was (Author: brandon.williams): As a first step, lets see what shakes out from CI: [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/804/workflows/b9c730e3-5aa7-4e0e-9aaa-2b6cbd6d35c0], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2217/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2217/pipeline]. > Update JNA > -- > > Key: CASSANDRA-18050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18050 > Project: Cassandra > Issue Type: Task >Reporter: Ekaterina Dimitrova >Priority: Normal > > JNA needs to be updated for JDK 17 support. There was an update pre-4.0 but > not to the latest version (confirmed with the people involved, there was no > particular reason not to update to the latest version, just missed on rebase > of older PR) > More details to come, opening this as a placeholder for now -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18159) Test Failure: repair_tests.repair_test.TestRepair.test_*dc_repair
[
https://issues.apache.org/jira/browse/CASSANDRA-18159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679936#comment-17679936
]
Caleb Rackliffe commented on CASSANDRA-18159:
-
Saw this again in
[https://ci-cassandra.apache.org/job/Cassandra-4.1/250/testReport/dtest-offheap.repair_tests.repair_test/TestRepair/test_dc_parallel_repair/]
> Test Failure: repair_tests.repair_test.TestRepair.test_*dc_repair
> -
>
> Key: CASSANDRA-18159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18159
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
>
> Flaky.
> {noformat}
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[node3] 'ERROR [MemtableReclaimMemory:1] 2023-01-13 04:23:38,762
> CassandraDaemon.java:581 - Exception in thread
> Thread[MemtableReclaimMemory:1,5,main]java.lang.AssertionError: null
> at
> org.apache.cassandra.utils.memory.MemtablePool$SubPool.released(MemtablePool.java:193)
> at
> org.apache.cassandra.utils.memory.MemtableAllocator$SubAllocator.releaseAll(MemtableAllocator.java:151)
> at
> org.apache.cassandra.utils.memory.MemtableAllocator$SubAllocator.setDiscarded(MemtableAllocator.java:142)
> at
> org.apache.cassandra.utils.memory.MemtableAllocator.setDiscarded(MemtableAllocator.java:93)
> at
> org.apache.cassandra.utils.memory.NativeAllocator.setDiscarded(NativeAllocator.java:203)
> at org.apache.cassandra.db.Memtable.setDiscarded(Memtable.java:212)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush$1.runMayThrow(ColumnFamilyStore.java:1216)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:750)']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18050) Update JNA
[ https://issues.apache.org/jira/browse/CASSANDRA-18050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679932#comment-17679932 ] Brandon Williams commented on CASSANDRA-18050: -- As a first step, lets see what shakes out from CI: [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/804/workflows/b9c730e3-5aa7-4e0e-9aaa-2b6cbd6d35c0], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2217/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2217/pipeline]. > Update JNA > -- > > Key: CASSANDRA-18050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18050 > Project: Cassandra > Issue Type: Task >Reporter: Ekaterina Dimitrova >Priority: Normal > > JNA needs to be updated for JDK 17 support. There was an update pre-4.0 but > not to the latest version (confirmed with the people involved, there was no > particular reason not to update to the latest version, just missed on rebase > of older PR) > More details to come, opening this as a placeholder for now -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18179) Update build.xml for experimental JDK17 use
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679931#comment-17679931 ] Michael Semb Wever commented on CASSANDRA-18179: CI (just builds 8+11) - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/78/workflows/19c945d8-0fe7-4e91-a626-eae18910d338 - https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/78/workflows/c88fdd5e-70ce-4e95-a8be-a2fab5f93e14 - https://ci-cassandra.apache.org/job/Cassandra-devbranch/2216 > Update build.xml for experimental JDK17 use > --- > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18169) Warning at startup in 3.11.11 or above version of Cassandra
[
https://issues.apache.org/jira/browse/CASSANDRA-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679929#comment-17679929
]
Alberto Bortolan commented on CASSANDRA-18169:
--
The latest comment just added to CASSANDRA-18153 indicates that the fix for it
will also cover the case described in this Jira. As Brandon wrote, it can now
be seen as a duplicate of CASSANDRA-18153
> Warning at startup in 3.11.11 or above version of Cassandra
> ---
>
> Key: CASSANDRA-18169
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18169
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
>Reporter: Mohammad Aburadeh
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 3.11.x
>
>
> We are seeing the following warning in Cassandra 3.11.11/14 at startup :
> {code:java}
> WARN [main] 2022-12-27 16:41:28,016 CommitLogReplayer.java:253 - Origin of 2
> sstables is unknown or doesn't match the local node; commitLogIntervals for
> them were ignored
> DEBUG [main] 2022-12-27 16:41:28,016 CommitLogReplayer.java:254 - Ignored
> commitLogIntervals from the following sstables:
> [/data/cassandra/data/system/local-7ad54392bcdd35a684174e047860b377/me-65-big-Data.db,
>
> /data/cassandra/data/system/local-7ad54392bcdd35a684174e047860b377/me-64-big-Data.db]
> {code}
> It looks like HostID metadata is missing at startup in the system.local
> table.
> We noticed that this issue does not exist in the 4.0.X version of Cassandra.
> Could you please fix it in 3.11.X Cassandra?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18147) netty-all vulnerability: CVE-2022-41915
[ https://issues.apache.org/jira/browse/CASSANDRA-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18147: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > netty-all vulnerability: CVE-2022-41915 > --- > > Key: CASSANDRA-18147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18147 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > This is being reported by the OWASP scan. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18155) Coordinator level metrics for read response and mutation row and column counts
[
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679924#comment-17679924
]
Caleb Rackliffe commented on CASSANDRA-18155:
-
[~bereng] Thanks for taking a look! I'll hopefully be able to address your
comments soon...
> Coordinator level metrics for read response and mutation row and column counts
> --
>
> Key: CASSANDRA-18155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679897#comment-17679897
]
Adriano Bonacin commented on CASSANDRA-18153:
-
Hi. It's just another scenario where we have this issue but this patch will
address both.
Always we have a memtable being flushed before StorageService initialization,
SSTable are created without HostUUID.
SSTables are flushed during CommigLogReplay (Keyspaces with mutations on
CommitLog). But specifically for system.local, we also have flushes before
StorageService initialization.
This Patch will correct HostUUID returned by MetadataCollector before
StorageService initialization.
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679892#comment-17679892
]
Stefan Miklosovic commented on CASSANDRA-18153:
---
Hi [~abonacin], to comment your last comment: _In fact there are some
SYSTEM.LOCAL's memtables flushed before Storage service got initialized. These
SSTables also have missing Host UUID information._
Do you think this is something which could be included in this patch? Or does
your patch solves this already?
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679892#comment-17679892
]
Stefan Miklosovic edited comment on CASSANDRA-18153 at 1/23/23 4:54 PM:
Hi [~abonacin], to comment on your last comment: _In fact there are some
SYSTEM.LOCAL's memtables flushed before Storage service got initialized. These
SSTables also have missing Host UUID information._
Do you think this is something which could be included in this patch? Or does
your patch solves this already?
was (Author: smiklosovic):
Hi [~abonacin], to comment your last comment: _In fact there are some
SYSTEM.LOCAL's memtables flushed before Storage service got initialized. These
SSTables also have missing Host UUID information._
Do you think this is something which could be included in this patch? Or does
your patch solves this already?
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18153:
--
Test and Documentation Plan: unit / ci
Status: Patch Available (was: In Progress)
https://github.com/apache/cassandra/pull/2096/files
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18153:
--
Reviewers: Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic)
Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic)
Status: Review In Progress (was: Patch Available)
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18153:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Recoverable
Corruption / Loss(12986)
Complexity: Normal
Component/s: Local/SSTable
Discovered By: User Report
Reviewers: Stefan Miklosovic
Severity: Normal
Status: Open (was: Triage Needed)
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18185) Accumulate all the `docs` PR from GitHub into a single patch
[ https://issues.apache.org/jira/browse/CASSANDRA-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679839#comment-17679839 ] Stefan Miklosovic commented on CASSANDRA-18185: --- [~neshkeev] could you please prepare the patch in such a way that it consists of 1 commit only? (all commits are squashed). Please preserve Co-authored-by when squashing, there should be as many Co-authored- by lines as many collaborators there are. > Accumulate all the `docs` PR from GitHub into a single patch > > > Key: CASSANDRA-18185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18185 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Nikita Eshkeev >Assignee: Nikita Eshkeev >Priority: Low > Fix For: 4.x > > Time Spent: 5h > Remaining Estimate: 0h > > In order to make it easier to review the `docs` labeled pull-requests all of > them should be accumulated into a single commit as per the > [request|https://github.com/apache/cassandra/pull/2062#issuecomment-1385002289] > from [~smiklosovic] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18185) Accumulate all the `docs` PR from GitHub into a single patch
[ https://issues.apache.org/jira/browse/CASSANDRA-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18185: -- Test and Documentation Plan: docs rendered correctly Status: Patch Available (was: In Progress) > Accumulate all the `docs` PR from GitHub into a single patch > > > Key: CASSANDRA-18185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18185 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Nikita Eshkeev >Assignee: Nikita Eshkeev >Priority: Low > Fix For: 4.x > > Time Spent: 5h > Remaining Estimate: 0h > > In order to make it easier to review the `docs` labeled pull-requests all of > them should be accumulated into a single commit as per the > [request|https://github.com/apache/cassandra/pull/2062#issuecomment-1385002289] > from [~smiklosovic] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18185) Accumulate all the `docs` PR from GitHub into a single patch
[ https://issues.apache.org/jira/browse/CASSANDRA-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18185: -- Change Category: Semantic Complexity: Low Hanging Fruit Component/s: Documentation Fix Version/s: 4.x Reviewers: Stefan Miklosovic Priority: Low (was: Normal) Status: Open (was: Triage Needed) > Accumulate all the `docs` PR from GitHub into a single patch > > > Key: CASSANDRA-18185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18185 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Nikita Eshkeev >Assignee: Nikita Eshkeev >Priority: Low > Fix For: 4.x > > Time Spent: 5h > Remaining Estimate: 0h > > In order to make it easier to review the `docs` labeled pull-requests all of > them should be accumulated into a single commit as per the > [request|https://github.com/apache/cassandra/pull/2062#issuecomment-1385002289] > from [~smiklosovic] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18183) rat targets do not adhere to build.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18183:
--
Fix Version/s: 3.0.29
3.11.15
4.0.8
4.1.1
4.2
(was: 3.0.x)
(was: 4.x)
(was: 3.11.x)
(was: 4.0.x)
(was: 4.1.x)
Since Version: 3.0.25
Source Control Link:
https://github.com/apache/cassandra/commit/357c0d5a896ca79065b0b3e18b4e6f33a87bd021
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> rat targets do not adhere to build.dir property
> ---
>
> Key: CASSANDRA-18183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18183
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I detected this when I was trying to put my build dir to ramdisk. I have
> plenty of RAM available on my workstation (64GB) and I was thinking about
> moving "build" dir to ramdisk so I could make it faster a little bit and also
> spare some write cycles to ssd. It can look like irrelevant improvement but I
> think that if devs are building the project repeatedly times and times again,
> this can easily add up.
> {code:java}
> mkdir /tmp/cassandra
> # in /etc/fstab
> tmpfs /tmp/cassandra tmpfs defaults,noatime,size=2048M,x-gvfs-show,mode=1777
> 0 0
> # then sudo mount -a
> # I have worktree setup so the build for each branch will end up in different
> dir:
> # mkdir -p
> /tmp/cassandra/{trunk,cassandra-4.1,cassandra-4.0,cassandra-3.11,cassandra-3.0}
> {code}
> Then in build.properties for each respective branch:
> {code:java}
> ant.gen-doc.skip: true
> build.dir: /tmp/cassandra/trunk/build
> build.dir.lib: /tmp/cassandra/trunk/build/lib
> {code}
> The problem with this is that it fails on rat, because there is not
> "build.dir" property used, it is hardcoded to "build" but there is not
> anything to rat on so it will hang.
> To have the very same experience, I am also creating a symlink
>
> {code}
> ln -s /tmp/cassandra/trunk/build build
> {code}
> so "cd build / ls build" in the root of the repository will take me to
> ramdisk. The problem with this is that there is "build/" in .gitignore but
> not "build" (as file) so the repository is in dirty state. I suggest to add
> "build" to .gitignore as part of this PR as that is just an opportunistic fix
> really.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18183) rat targets do not adhere to build.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18183:
--
Status: Ready to Commit (was: Review In Progress)
> rat targets do not adhere to build.dir property
> ---
>
> Key: CASSANDRA-18183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18183
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I detected this when I was trying to put my build dir to ramdisk. I have
> plenty of RAM available on my workstation (64GB) and I was thinking about
> moving "build" dir to ramdisk so I could make it faster a little bit and also
> spare some write cycles to ssd. It can look like irrelevant improvement but I
> think that if devs are building the project repeatedly times and times again,
> this can easily add up.
> {code:java}
> mkdir /tmp/cassandra
> # in /etc/fstab
> tmpfs /tmp/cassandra tmpfs defaults,noatime,size=2048M,x-gvfs-show,mode=1777
> 0 0
> # then sudo mount -a
> # I have worktree setup so the build for each branch will end up in different
> dir:
> # mkdir -p
> /tmp/cassandra/{trunk,cassandra-4.1,cassandra-4.0,cassandra-3.11,cassandra-3.0}
> {code}
> Then in build.properties for each respective branch:
> {code:java}
> ant.gen-doc.skip: true
> build.dir: /tmp/cassandra/trunk/build
> build.dir.lib: /tmp/cassandra/trunk/build/lib
> {code}
> The problem with this is that it fails on rat, because there is not
> "build.dir" property used, it is hardcoded to "build" but there is not
> anything to rat on so it will hang.
> To have the very same experience, I am also creating a symlink
>
> {code}
> ln -s /tmp/cassandra/trunk/build build
> {code}
> so "cd build / ls build" in the root of the repository will take me to
> ramdisk. The problem with this is that there is "build/" in .gitignore but
> not "build" (as file) so the repository is in dirty state. I suggest to add
> "build" to .gitignore as part of this PR as that is just an opportunistic fix
> really.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
