[
https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680031#comment-17680031
]
Ekaterina Dimitrova edited comment on CASSANDRA-18179 at 1/23/23 9:34 PM:
--------------------------------------------------------------------------
Note: we have CASSANDRA_USE_JDK11 documented , so I guess we will need also to
update the docs for trunk when we remove it. Could be separate ticket if we
want in general to add some additional info around JDK. Just mentioning so we
do not forget about it and confuse people. I am referring to this page -
[https://cassandra.apache.org/doc/latest/cassandra/getting_started/java11.html]
I looked at the CI runs and nothing stood me as an issue related to this work.
Seems to me almost all failures already have associated tickets (I can open
tickets for those that don't have yet when we are done here)
Pulled your change to my J17 branch and locally things seemed fine, I also
pushed some preliminary
[run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2188/workflows/1ac46d21-56cf-4041-88b3-ac70577f898c]
of a few jobs with J17 with that branch, just for a sanity check
Applied your hack to CASSANDRA_USE_JDK17 too until we work out the CCM patch
Also, I think we should change the commit message as I think it is too early to
say that we add support for J17 in this ticket. I would say - "in preparation
for" so that someone doesn't get confused. Considering the amount of work
around the project someone can easily miss the actual status of things.
was (Author: e.dimitrova):
Note: we have CASSANDRA_USE_JDK11 documented , so I guess we will need also to
update the docs for trunk when we remove it. Could be separate ticket if we
want in general to add some additional info around JDK. Just mentioning so we
do not forget about it and confuse people. I am referring to this page -
[https://cassandra.apache.org/doc/latest/cassandra/getting_started/java11.html]
I looked at the CI runs and nothing stood me as an issue related to this work.
Seems to me almost all failures already have associated tickets (I can open
tickets for those that don't have yet when we are done here)
Pulled your change to my J17 branch and locally things seemed fine, I also
pushed some preliminary run of a few jobs with J17 with that branch, just for a
sanity check
Applied your hack to CASSANDRA_USE_JDK17 too until we work out the CCM patch
Also, I think we should change the commit message as I think it is too early to
say that we add support for J17 in this ticket. I would say - "in preparation
for" so that someone doesn't get confused. Considering the amount of work
around the project someone can easily miss the actual status of things.
> Update build.xml for experimental JDK17 use
> -------------------------------------------
>
> Key: CASSANDRA-18179
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18179
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 4.x
>
>
> To support JDK17 we need to make changes to build.xml and our scripts. There
> is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17
> but it will need a change considering CASSANDRA-18133
> CC [~mck]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
