[jira] [Commented] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905662#comment-16905662
]
Andrew Prudhomme commented on CASSANDRA-15210:
--
For some more context, this is causing us problems in the case where a CDC
tracked table has large partitions. Since the streaming bootstrap is played
through the commit log, the stream will fail because of the (0.5 * commit log)
mutation size limit. This issue means that streaming will fail even when CDC is
disabled at the node level.
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905658#comment-16905658
]
Andrew Prudhomme commented on CASSANDRA-15210:
--
||Branch||Tests||
|[trunk|https://github.com/apache/cassandra/compare/trunk...aprudhomme:15210-trunk]|[cci|https://circleci.com/workflow-run/184e2de1-8893-481a-91f1-910ed4ac246a]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...aprudhomme:15210-3.11]|[cci|https://circleci.com/workflow-run/f5fcba5a-e940-4cc7-b02d-540d8887c258]|
I did not have the circleci resources for dtests, so I ran them locally.
[trunk|https://pastebin.com/8aLbh7GF] - The 3 failed tests passed on retry. The
rebuild_test error also occurred on the base branch.
[3.11|https://pastebin.com/bE9GBCm8] - The counter_test, largecolumn_test,
offline_tools_test, and replace_address_test failures also occurred on the base
branch. All other failures passed on retry.
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Prudhomme reassigned CASSANDRA-15210:
Assignee: Andrew Prudhomme
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
Andrew Prudhomme created CASSANDRA-15210:
Summary: Streaming with CDC does not honor cdc_enabled
Key: CASSANDRA-15210
URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
Project: Cassandra
Issue Type: Bug
Components: Consistency/Streaming, Feature/Change Data Capture
Reporter: Andrew Prudhomme
When SSTables are streamed for a CDC enabled table, the updates are processed
through the write path to ensure they are made available through the commit
log. However, currently only the CDC state of the table is checked. Since CDC
is enabled at both the node and table level, a node with CDC disabled (with
cdc_enabled: false) will unnecessarily send updates through the write path if
CDC is enabled on the table. This seems like an oversight.
I'd imagine the fix would be something like
{code:java}
- hasCDC = cfs.metadata.params.cdc;
+ hasCDC = cfs.metadata.params.cdc && DatabaseDescriptor.isCDCEnabled();{code}
in
org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
org.apache.cassandra.streaming.StreamReceiveTask (3.11)
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15310) Fix flakey - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934136#comment-16934136
]
Andrew Prudhomme edited comment on CASSANDRA-15310 at 9/21/19 8:39 PM:
---
Looks like the measured time interval does not entirely cover the timeout. The
tests in java 11 were sometime falling a few ms short. Adding a fudge factor
should help.
edit: On second thought, it is probably better to just refresh the timeout,
like in testIdleDisconnectProlonged.
[15310-trunk|https://github.com/aprudhomme/cassandra/commit/bf279fd16960827bb64c39c9d6dc0fe68b067852]
[cci_8|https://circleci.com/workflow-run/fc2e076c-fca3-497a-b9aa-db66aa2905f3]
[cci_11|https://circleci.com/workflow-run/97c01d17-2ef6-494f-afea-35eba3395350]
was (Author: aprudhomme):
Looks like the measured time interval does not entirely cover the timeout. The
tests in java 11 were sometime falling a few ms short. Adding a fudge factor
should help.
[15310-trunk|https://github.com/aprudhomme/cassandra/commit/36c9637d7ace8e8ba37db186efe1226e42814c9e]
[cci_8|https://circleci.com/workflow-run/5b28d0ed-004a-4823-93ba-aacaf00ff362]
[cci_11|https://circleci.com/workflow-run/54c70d11-f45e-44d6-a2c7-3c5948c38939]
> Fix flakey - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTest
> ---
>
> Key: CASSANDRA-15310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Joseph Lynch
>Assignee: Andrew Prudhomme
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example run:
> [https://circleci.com/gh/jolynch/cassandra/561#tests/containers/86]
>
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTestjunit.framework.AssertionFailedError
> at
> org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15310) Fix flakey - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Prudhomme reassigned CASSANDRA-15310:
Assignee: Andrew Prudhomme
> Fix flakey - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTest
> ---
>
> Key: CASSANDRA-15310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Joseph Lynch
>Assignee: Andrew Prudhomme
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example run:
> [https://circleci.com/gh/jolynch/cassandra/561#tests/containers/86]
>
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTestjunit.framework.AssertionFailedError
> at
> org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15310) Fix flakey - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934136#comment-16934136
]
Andrew Prudhomme commented on CASSANDRA-15310:
--
Looks like the measured time interval does not entirely cover the timeout. The
tests in java 11 were sometime falling a few ms short. Adding a fudge factor
should help.
[15310-trunk|https://github.com/aprudhomme/cassandra/commit/36c9637d7ace8e8ba37db186efe1226e42814c9e]
[cci_8|https://circleci.com/workflow-run/5b28d0ed-004a-4823-93ba-aacaf00ff362]
[cci_11|https://circleci.com/workflow-run/54c70d11-f45e-44d6-a2c7-3c5948c38939]
> Fix flakey - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTest
> ---
>
> Key: CASSANDRA-15310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Joseph Lynch
>Assignee: Andrew Prudhomme
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example run:
> [https://circleci.com/gh/jolynch/cassandra/561#tests/containers/86]
>
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTestjunit.framework.AssertionFailedError
> at
> org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15382) Fix flaky unit test - testIdleDisconnect::org.apache.cassandra.transport.IdleDisconnectTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961365#comment-16961365
]
Andrew Prudhomme commented on CASSANDRA-15382:
--
I think this is a duplicate of
https://issues.apache.org/jira/browse/CASSANDRA-15310
> Fix flaky unit test -
> testIdleDisconnect::org.apache.cassandra.transport.IdleDisconnectTest
> ---
>
> Key: CASSANDRA-15382
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15382
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Vinay Chella
>Priority: Normal
>
> As part of Apache Cassandra 4.0-alpha2, it is found out that
> "testIdleDisconnect::org.apache.cassandra.transport.IdleDisconnectTest" is
> flaky.
>
> +Failing test:+
> *testIdleDisconnect::org.apache.cassandra.transport.IdleDisconnectTest*
> {code:java}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
> +Sample failed runs:+
> *
> [https://circleci.com/gh/vinaykumarchella/cassandra/527#tests/containers/37]
> *
> [https://circleci.com/gh/vinaykumarchella/cassandra/535#tests/containers/37]
> * [https://circleci.com/gh/vinaykumarchella/cassandra/489#tests/containers/7]
> *
> [https://circleci.com/gh/vinaykumarchella/cassandra/512#tests/containers/37]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15310) Fix flakey - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027027#comment-17027027
]
Andrew Prudhomme commented on CASSANDRA-15310:
--
Thanks [~e.dimitrova]. This test is flakey in alpha1/2, but seems fine on the
current trunk. Doing some digging, it looks like it got fixed as part of a
different commit
[https://github.com/apache/cassandra/commit/3a8300e0b86c4acfb7b7702197d36cc39ebe94bc#diff-0da71200299fb3393ea8f95eae9124ea]
If no one is seeing this anymore, the ticket can probably be closed.
> Fix flakey - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTest
> ---
>
> Key: CASSANDRA-15310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Joey Lynch
>Assignee: Andrew Prudhomme
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example run:
> [https://circleci.com/gh/jolynch/cassandra/561#tests/containers/86]
>
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTestjunit.framework.AssertionFailedError
> at
> org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15310) Fix flakey - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027117#comment-17027117
]
Andrew Prudhomme commented on CASSANDRA-15310:
--
[~e.dimitrova] I am seeing the same with local testing. On alpha2 it fails most
every time. On trunk it hasn't failed in 100+ runs.
I don't think this is a problem anymore.
> Fix flakey - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTest
> ---
>
> Key: CASSANDRA-15310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Joey Lynch
>Assignee: Andrew Prudhomme
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example run:
> [https://circleci.com/gh/jolynch/cassandra/561#tests/containers/86]
>
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testIdleDisconnect -
> org.apache.cassandra.transport.IdleDisconnectTestjunit.framework.AssertionFailedError
> at
> org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004427#comment-17004427
]
Andrew Prudhomme commented on CASSANDRA-15210:
--
Thanks, I'm still learning this workflow.
Since it has been a while, I did a rebase and retest. It doesn't look like much
has changed.
||Branch||Tests||Local dtest||
|[trunk|https://github.com/apache/cassandra/compare/trunk...aprudhomme:15210-trunk]|[cci|https://circleci.com/workflow-run/11fbfb4e-fa3d-4dda-b08e-6850a539a335]|[pb|https://pastebin.com/dN6cpH9C]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...aprudhomme:15210-3.11]|[cci|https://circleci.com/workflow-run/c378d858-0ca1-4d11-aa95-50cabfef6897]|[pb|https://pastebin.com/U5Mqy4WY]|
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Prudhomme updated CASSANDRA-15210:
-
Test and Documentation Plan: See cci and dtest output
Status: Patch Available (was: Open)
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380142#comment-17380142
]
Andrew Prudhomme commented on CASSANDRA-15210:
--
Thank you for looking at this. It has been quite a while and I will need to
rebuild some context, but since it doesn't seem urgent I would be happy to take
a shot at finishing this.
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15210) Streaming with CDC does not honor cdc_enabled
[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565212#comment-17565212
]
Andrew Prudhomme commented on CASSANDRA-15210:
--
[~e.dimitrova] Thank you for the ping. I'll carve out some time to work on this.
> Streaming with CDC does not honor cdc_enabled
> -
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
>Reporter: Andrew Prudhomme
>Assignee: Andrew Prudhomme
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.x
>
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
