[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124103#comment-16124103 ] Joel Knighton commented on CASSANDRA-11483: --- The dtest fix was committed in [CASSANDRA-13755] - thanks everyone. > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121238#comment-16121238 ] Marcus Eriksson commented on CASSANDRA-11483: - I ran the dtests but it seems they have been rotated out now - I must have missed this failure > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120624#comment-16120624 ] Chris Lohfink commented on CASSANDRA-11483: --- your safe to commit it, thanks! > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120382#comment-16120382
]
Joel Knighton commented on CASSANDRA-11483:
---
Is there a branch of dtest changes for this ticket anywhere? While working on
an unrelated ticket, I noticed this commit broke
{{repair_tests.incremental_repair_test.TestIncRepair.consistent_repair_test}}.
I've pushed a trivial fix
[here|https://github.com/jkni/cassandra-dtest/commit/f55f78b093fc668dc5cc9d1fc72f66dc5a9bf3a6],
but I don't want to commit it and create conflicts if there's already an
existing dtest branch. I didn't notice any other tests that needed fixing.
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 4.0
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen
> Shot 2016-04-03 at 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097088#comment-16097088 ] Chris Lohfink commented on CASSANDRA-11483: --- pushed changes + a fix to prevent sstable leaks and their warning messages > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096627#comment-16096627
]
Marcus Eriksson commented on CASSANDRA-11483:
-
Pushed a code style fixup here:
https://github.com/krummas/cassandra/commits/clohfink/11483
comments:
* the TimeUnit for printing out min/max timestamps are not guaranteed to be
micros, maybe the user should be able to override the TimeUnit.MICROSECONDS
from the command line?
* should we collect the
{{widestPartitions}}/{{largestPartitions}}/{{mostTombstones}} during
compaction/flush and always show them? Would be quite useful to not have to
scan the sstable for this info. We should probably do that in a new ticket
though
* {{SSTable min local deletion time}} and {{SSTable max local deletion time}}
needs to special-case Long.MAX_VALUE I think - if we don't have a deletion, we
should probably indicate that in the output instead of outputting "01/18/2038
19:14:07"
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 4.0
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen
> Shot 2016-04-03 at 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080597#comment-16080597 ] Chris Lohfink commented on CASSANDRA-11483: --- conflicts with trunk resolved again fwiw > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954200#comment-15954200 ] Chris Lohfink commented on CASSANDRA-11483: --- Is there anything outstanding on this issue to get in? > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692158#comment-15692158 ] Chris Lohfink commented on CASSANDRA-11483: --- new patch attached and updated PR > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen > Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611409#comment-15611409
]
Romain Hardouin commented on CASSANDRA-11483:
-
Having human readable data is very nice.
What about using ISO 8601 to format the date? {{MM/dd}} is misleading in many
countries and can be understood as {{dd/MM}} when the day is below 13 e.g.
02/03/2016 -> Is it {{March, 2nd}} or {{Feb, 3rd}}?
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 3.x
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at
> 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609658#comment-15609658
]
Chris Lohfink commented on CASSANDRA-11483:
---
It does
{{SimpleDateFormat("MM/dd/ HH:mm:ss").format(new
java.util.Date(unit.toMillis(time)));}}
which will use the machines local time zone. Adding a X to the format to
include offset would probably be good idea incase distributing the results.
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 3.x
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at
> 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609601#comment-15609601
]
Jonathan Owens commented on CASSANDRA-11483:
This looks rad, and its existence saved me a lot of time code diving.
How does it handle converting seconds since epoch to time in a zone? This
output for example:
{code}
Minimum timestamp: 1456554952195298 (02/27/2016 00:35:52)
{code}
Is that parenthesized timestamp UTC or something else?
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 3.x
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at
> 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335624#comment-15335624 ] Stefania commented on CASSANDRA-11483: -- I've opened CASSANDRA-12020 as I could not see any tests specific to sstablemetadata. > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at > 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289694#comment-15289694 ] Jeremiah Jordan commented on CASSANDRA-11483: - +1 for defaulting the colors and unicode to off. > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at > 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288459#comment-15288459 ] Chris Lohfink commented on CASSANDRA-11483: --- so, the dtests were really just failing because the ansi sequences threw it off. Since colors/unicode have to be disabled for windows by default anyway I pushed a change just to make them disabled (which then makes the -c/-u options make more sense). Seems to fix the dtests as well and will decreases chance that anyone using this (id be surprised honestly) in parsed format would be effected. > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at > 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271404#comment-15271404 ] Yuki Morishita commented on CASSANDRA-11483: Alright, let's just fix dtest. Looks like adding backward compatibility isn't worth the effort at all. > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at > 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270049#comment-15270049 ] Chris Lohfink commented on CASSANDRA-11483: --- I went down path a little of having old and new output... it gets kinda ugly. To the point it may be less horrible code wise to just make this a new tool. Its already pretty bad with the colors and unicode being either or. I guess I am more in favor currently of updating the dtests instead. Which would be good anyway to test all the new flags. If thats Ok I can make the dtest patch. If we really want to support the old format (in which I assume would be default), Id rather just see this pushed to 4.0 or whatever version it would be Ok to change the output of the tool. > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at > 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265034#comment-15265034 ] Yuki Morishita commented on CASSANDRA-11483: On windows, this runs without problems. I fixed some styling and ran tests. ||branch||testall||dtest|| |[11483|https://github.com/yukim/cassandra/tree/11483]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11483-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11483-dtest/lastCompletedBuild/testReport/]| As you can see in dtest, some of them rely on the output of sstablemetadata, so we either fix those dtests as well, or support old output format. Between those two, I prefer supporting old output format, since it can be least suprise for user who rely on output of the tool as well. WDYT? > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, Screen Shot 2016-04-03 at > 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227529#comment-15227529
]
Chris Lohfink commented on CASSANDRA-11483:
---
> I like to have just command line option without arg. All options right now
> are boolean, and doing like -s true to activate them is verbose
I like that too but since they default to true (for all but windows) it was a
little awkward to have "disable ___" options, and then other options to enable
for powershell users (colors/unicode work in powershell but not cmd.exe). Any
ideas to what it should look like?
> some users may be using it for just number
All the numbers are still there, is it just more complex with the {{(human
readables)}} ?
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 3.x
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, Screen Shot 2016-04-03 at 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227220#comment-15227220
]
Yuki Morishita commented on CASSANDRA-11483:
Thanks for the update.
Couple of comments:
* I think you can just move CommandLine / Options and static block to
initialize those inside {{main}}.
* I like to have just command line option without arg. All options right now
are boolean, and doing like {{-s true}} to activate them is verbose.
* I really like new presentation but some users may be using it for just
numbers. If you can create API for display and put new representation and old
one there, that would be great. In the future, we can plugin more presentation
style (like beloved json).
* Some fields like "repaired at" or "deletion time" have default or special
value to indicate certain state. For example "Repaired at" == 0 means SSTable
is never repaired. I think displaying date string to such field can mislead
user. WDYT?
* Can you clean up import statements and unused variables? Also, some fields
are using {{System.out}} and others are using instance variable {{out}}.
> Enhance sstablemetadata
> ---
>
> Key: CASSANDRA-11483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Fix For: 3.x
>
> Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt,
> CASSANDRA-11483v3.txt, Screen Shot 2016-04-03 at 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in
> micros, millis, seconds as durations and timestamps from epoch. But there is
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226942#comment-15226942 ] Chris Lohfink commented on CASSANDRA-11483: --- added v3 tested with windows. Default to worst case (cmd.exe) with no colors/unicode. Although colors do work with powershell they can enable it with -c > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, > CASSANDRA-11483v3.txt, Screen Shot 2016-04-03 at 11.40.32 PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226464#comment-15226464 ] Chris Lohfink commented on CASSANDRA-11483: --- Updated branch on PR https://github.com/clohfink/cassandra/pull/1/files > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, Screen Shot 2016-04-03 at 11.40.32 > PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226422#comment-15226422 ] Yuki Morishita commented on CASSANDRA-11483: The new tool doesn't support pre-3.0 SSTable. Since, current trunk version supports it, it feels like it is one step backward. Can you skip all new feature that require CFMetaData for pre-3.0 SSTable and just not error out? > Enhance sstablemetadata > --- > > Key: CASSANDRA-11483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11483 > Project: Cassandra > Issue Type: Improvement > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-11483.txt, Screen Shot 2016-04-03 at 11.40.32 > PM.png > > > sstablemetadata provides quite a bit of useful information but theres a few > hiccups I would like to see addressed: > * Does not use client mode > * Units are not provided (or anything for that matter). There is data in > micros, millis, seconds as durations and timestamps from epoch. But there is > no way to tell what one is without a non-trival code dive > * in general pretty frustrating to parse -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11483) Enhance sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223655#comment-15223655
]
Chris Lohfink commented on CASSANDRA-11483:
---
While at it, included ansi colors and some extra info
!Screen Shot 2016-04-03 at 11.40.32 PM.png|width=500!
Boring example:
{code}
SSTable: /Users/clohfink/git/sstable-tools/src/test/resources/ma-2-big
Partitions: 1
Rows: 1
Tombstones: 0
Cells: 4
Widest Partitions:
[frodo] 1
Largest Partitions:
[frodo] 104
Partitioner: org.apache.cassandra.dht.Murmur3Partitioner
Bloom Filter FP chance: 0.01
Minimum timestamp: 1455937221199050 (02/19/2016 21:00:21)
Maximum timestamp: 1455937221199050 (02/19/2016 21:00:21)
SSTable min local deletion time: 2147483647 (01/18/2038 21:14:07)
SSTable max local deletion time: 2147483647 (01/18/2038 21:14:07)
Compressor: org.apache.cassandra.io.compress.LZ4Compressor
Compression ratio: -1.0
TTL min: 0 (0 milliseconds)
TTL max: 0 (0 milliseconds)
First token: 6564497868996989420 (frodo)
Last token: 6564497868996989420 (frodo)
minClustringValues: []
maxClustringValues: []
Estimated droppable tombstones: 0.0
SSTable Level: 0
Repaired at: 0 (12/31/1969 18:00:00)
ReplayPosition(segmentId=1455937219425, position=41561)
totalColumnsSet: 4
totalRows: 1
Estimated tombstone drop times:
Drop Time| Count (%) Histogram
2147483647 (01/18/2038 21:14:07) | 4 (100) ██
Percentiles
50th 2395318855 (11/26/2045 08:20:55)
75th 2395318855 (11/26/2045 08:20:55)
95th 2395318855 (11/26/2045 08:20:55)
98th 2395318855 (11/26/2045 08:20:55)
99th 2395318855 (11/26/2045 08:20:55)
Min 1996099047 (04/02/2033 18:57:27)
Max 2395318855 (11/26/2045 08:20:55)
Partition Size:
Size (bytes) | Count (%) Histogram
50 (50 B)| 1 (100) ██
Percentiles
50th 50 (50 B)
75th 50 (50 B)
95th 50 (50 B)
98th 50 (50 B)
99th 50 (50 B)
Min 43 (43 B)
Max 50 (50 B)
Column Count:
Columns | Count (%) Histogram
4 | 1 (100) ██
Percentiles
50th 4
75th 4
95th 4
98th 4
99th 4
Min 4
Max 4
Estimated cardinality: 1
EncodingStats minTTL: 0 (0 milliseconds)
EncodingStats minLocalDeletionTime: 144288 (01/17/1970 10:48:00)
EncodingStats minTimestamp: 1455937221199050 (02/19/2016 21:00:21)
KeyType: org.apache.cassandra.db.marshal.UTF8Type
ClusteringTypes: []
StaticColumns:
RegularColumns: password:org.apache.cassandra.db.marshal.UTF8Type,
gender:org.apache.cassandra.db.marshal.UTF8Type,
state:org.apache.cassandra.db.marshal.UTF8Type,
birth_year:org.apache.cassandra.db.marshal.LongType
{code}
Slightly more interesting:
{code}
SSTable: /Users/clohfink/git/sstable-tools/ma-119-big
Partitions: 22515
Rows: 13579337
Tombstones: 0
Cells: 13579337
Widest Partitions:
[12345] 99
[99049] 62664
[99007] 60437
[99017] 59728
[99010] 59555
Largest Partitions:
[12345] 189888705
[99049] 2965017
[99007] 2860391
[99017] 2826094
[99010] 2818038
Partitioner: org.apache.cassandra.dht.Murmur3Partitioner
Bloom Filter FP chance: 0.01
Minimum timestamp: 1456554952195298 (02/27/2016 00:35:52)
Maximum timestamp: 1456594562846756 (02/27/2016 11:36:02)
SSTable min local deletion time: 2147483647 (01/18/2038 21:14:07)
SSTable max local deletion time: 2147483647 (01/18/2038 21:14:07)
Compressor: org.apache.cassandra.io.compress.LZ4Compressor
Compression ratio: 0.3068105022732033
TTL min: 0 (0 milliseconds)
TTL max: 0 (0 milliseconds)
First token: 286432166153517 (21139)
Last token: 9223106912315136675 (21299)
minClustringValues: [1]
maxClustringValues: [99]
Estimated droppable tombstones: 0.0
SSTable Level: 0
Repaired at: 0 (12/31/1969 18:00:00)
ReplayPosition(segmentId=1456414025108, position=16709244)
totalColumnsSet: 13579337
totalRows: 13579337
Estimated tombstone drop times:
Drop Time| Count (%) Histogram
2147483647 (01/18/2038 21:14:07) | 27158674 (100)
██
Percentiles
50th 2395318855 (11/26/2045 08:20:55)
75th 2395318855 (11/26/2045 08:20:55)
95th 2395318855 (11/26/2045 08:20:55)
98th 2395318855 (11/26/2045 08:20:55)
99th 2395318855 (11/26/2045 08:20:55)
Min 1996099047 (04/02/2033 18:57:27)
Max 2395318855 (11/26/2045 08:20:55)
Partition Size:
Size (bytes) | Count (%) Histogram
258 (258 B) | 6 ( 0)
310 (310 B) |20 ( 0) ▏
372 (372 B) |50 ( 0) ▍
446 (446 B) |45 ( 0) ▍
535 (535 B) |66 ( 0) ▌
642
