[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-05-18 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288655#comment-15288655
 ] 

Benjamin Lerer commented on CASSANDRA-11613:


Thanks. :-)

The patch look good to me. Just 2 nits that can be fixed on commit:
* The {{AbstractType::freezeNestedMulticellTypes}} comment seems to be missing 
something.
* In the {{freezeNestedMulticellTypes}} methods of {{ListType}} and {{SetType}} 
the {{else}} can be removed as all the branches ends with a {{return}} 
statement.

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Russ Hatch
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.6
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-05-17 Thread Tyler Hobbs (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287038#comment-15287038
 ] 

Tyler Hobbs commented on CASSANDRA-11613:
-

I think your suggestions are good, so I've created a new patch and started new 
test runs.  The new patch doesn't freeze UDTs/collections that are nested 
inside of already frozen collections/UDTs.  However, I did add explicit 
freezing of collections that are nested within non-frozen UDTs/collections to 
ensure CASSANDRA-7826 doesn't have any upgrade problems.

Here's an example schema after upgrading:

Table created in 2.2:
{noformat}
CREATE TABLE foo (a int primary key, b frozen, c set, d 
frozen, e set>);
{noformat}

{{system_schema.columns}} after upgrading to 3.6:
{noformat}
 keyspace_name | table_name | column_name | clustering_order | 
column_name_bytes | kind  | position | type
---++-+--+---+---+--+--
   ks1 |foo |   a | none |  
0x61 | partition_key |0 |  int
   ks1 |foo |   b | none |  
0x62 |   regular |   -1 |   frozen
   ks1 |foo |   c | none |  
0x63 |   regular |   -1 |  set
   ks1 |foo |   d | none |  
0x64 |   regular |   -1 |  frozen
   ks1 |foo |   e | none |  
0x65 |   regular |   -1 | set>
{noformat}

||branch||testall||dtest||
|[CASSANDRA-11613-3.6|https://github.com/thobbs/cassandra/tree/CASSANDRA-11613-3.6]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-3.6-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-3.6-dtest]|
|[CASSANDRA-11613-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-11613-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-trunk-dtest]|

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Russ Hatch
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.6
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-05-17 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286495#comment-15286495
 ] 

Benjamin Lerer commented on CASSANDRA-11613:


Effectively, in {{2.2}} even if the UDT was created with the Frozen keyword, it 
appears in the {{schema_columns}} without the {{FrozenType}}.

If my understanding is correct, we should only froze the top level as 
everything nested is then also frozen. In which case, I think the code should 
be:
{code}
if (validator.isUDT() && validator.isMultiCell())
{
validator = validator.freeze();
}
else
{
   validator = validator.freezeNestedUDTs();
}
{code}

CASSANDRA-11609 froze UDTs even if they are nested within a frozen collection 
but I find it a bit confusing. It will be probably clearer if it was not the 
case. What do you think?

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Russ Hatch
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.x
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-05-12 Thread Tyler Hobbs (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281992#comment-15281992
 ] 

Tyler Hobbs commented on CASSANDRA-11613:
-

I'm not sure why I didn't observe this in CASSANDRA-11609 (I guess we didn't 
try to use the column in that test), but simply explicitly freezing the 
top-level UDT fixes the problem and makes this test pass for me locally.

In case it's easier for re-rolling the 3.6 release, I've created a trunk patch 
as well as a patch off of 3.6-tentative.

Patch and pending CI runs:

||branch||testall||dtest||
|[CASSANDRA-11613|https://github.com/thobbs/cassandra/tree/CASSANDRA-11613]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-dtest]|
|[CASSANDRA-11613-3.6|https://github.com/thobbs/cassandra/tree/CASSANDRA-11613-3.6]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-3.6-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11613-3.6-dtest]|

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Russ Hatch
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.x
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-05-12 Thread Tyler Hobbs (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281984#comment-15281984
 ] 

Tyler Hobbs commented on CASSANDRA-11613:
-

Confirmed, and it appears that CASSANDRA-11760 has the same cause.

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Russ Hatch
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.x
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-05-12 Thread Tyler Hobbs (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281962#comment-15281962
 ] 

Tyler Hobbs commented on CASSANDRA-11613:
-

At first glance it looks like this is caused by a frozen UDT being considered 
non-frozen after the upgrade.

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Russ Hatch
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.x
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11613) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test

2016-04-19 Thread Russ Hatch (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248736#comment-15248736
 ] 

Russ Hatch commented on CASSANDRA-11613:


Based on the stack trace, I'm thinking this is not likely to be a test issue:
{noformat}
ERROR [MessagingService-Incoming-/127.0.0.2] 2016-04-19 00:59:15,353 
CassandraDaemon.java:195 - Exception in thread 
Thread[MessagingService-Incoming-/127.0.0.2,5,main]
java.lang.AssertionError: null
at org.apache.cassandra.db.rows.BufferCell.(BufferCell.java:42) 
~[main/:na]
at 
org.apache.cassandra.db.LegacyLayout$CellGrouper.addCell(LegacyLayout.java:1190)
 ~[main/:na]
at 
org.apache.cassandra.db.LegacyLayout$CellGrouper.addAtom(LegacyLayout.java:1144)
 ~[main/:na]
at 
org.apache.cassandra.db.LegacyLayout.getNextRow(LegacyLayout.java:646) 
~[main/:na]
at 
org.apache.cassandra.db.LegacyLayout.access$300(LegacyLayout.java:50) 
~[main/:na]
at 
org.apache.cassandra.db.LegacyLayout$2.computeNext(LegacyLayout.java:669) 
~[main/:na]
at 
org.apache.cassandra.db.LegacyLayout$2.computeNext(LegacyLayout.java:663) 
~[main/:na]
at 
org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
~[main/:na]
at 
org.apache.cassandra.db.rows.RowAndDeletionMergeIterator.updateNextRow(RowAndDeletionMergeIterator.java:117)
 ~[main/:na]
at 
org.apache.cassandra.db.rows.RowAndDeletionMergeIterator.computeNext(RowAndDeletionMergeIterator.java:77)
 ~[main/:na]
at 
org.apache.cassandra.db.rows.RowAndDeletionMergeIterator.computeNext(RowAndDeletionMergeIterator.java:35)
 ~[main/:na]
at 
org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
~[main/:na]
at 
org.apache.cassandra.db.partitions.AbstractBTreePartition.build(AbstractBTreePartition.java:283)
 ~[main/:na]
at 
org.apache.cassandra.db.partitions.PartitionUpdate.fromIterator(PartitionUpdate.java:207)
 ~[main/:na]
at 
org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserializePre30(PartitionUpdate.java:704)
 ~[main/:na]
at 
org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize(PartitionUpdate.java:647)
 ~[main/:na]
at 
org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:331)
 ~[main/:na]
at 
org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:350)
 ~[main/:na]
at 
org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:287)
 ~[main/:na]
at org.apache.cassandra.net.MessageIn.read(MessageIn.java:114) 
~[main/:na]
at 
org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:190)
 ~[main/:na]
at 
org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:178)
 ~[main/:na]
at 
org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:92)
 ~[main/:na]
{noformat}

Also wondering if this could have some relation to CASSANDRA-11609, both 
involve upgrading udt's and both failures look to be pretty new.

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --
>
> Key: CASSANDRA-11613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
> Project: Cassandra
>  Issue Type: Test
>Reporter: Russ Hatch
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)