[jira] [Commented] (CASSANDRA-14621) Refactor CompactionStrategyManager

2018-08-23 Thread Marcus Eriksson (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589934#comment-16589934 ] Marcus Eriksson commented on CASSANDRA-14621: - +1 seems you didn't push the latest fix

[jira] [Commented] (CASSANDRA-14621) Refactor CompactionStrategyManager

2018-08-22 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589064#comment-16589064 ] Blake Eggleston commented on CASSANDRA-14621: - pulled in your changes and pushed up some

[jira] [Commented] (CASSANDRA-14621) Refactor CompactionStrategyManager

2018-08-16 Thread Marcus Eriksson (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582254#comment-16582254 ] Marcus Eriksson commented on CASSANDRA-14621: - this lgtm in general, just a few comments

[jira] [Commented] (CASSANDRA-14621) Refactor CompactionStrategyManager

2018-08-14 Thread Marcus Eriksson (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580044#comment-16580044 ] Marcus Eriksson commented on CASSANDRA-14621: - [~aweisberg] yeah I'll review this week

[jira] [Commented] (CASSANDRA-14621) Refactor CompactionStrategyManager

2018-08-14 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579943#comment-16579943 ] Ariel Weisberg commented on CASSANDRA-14621: Fix version listed here is 4.x, but this is