[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741192#comment-17741192
]
Marcus Eriksson commented on CASSANDRA-18639:
-
sure, +1
> Add duration and partition
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741190#comment-17741190
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741187#comment-17741187
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Actually, there is a bug, it was
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741182#comment-17741182
]
Marcus Eriksson commented on CASSANDRA-18639:
-
If we're changing the output back I think
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741177#comment-17741177
]
Brandon Williams commented on CASSANDRA-18639:
--
LGTM, I am +1 but let's wait for Marcus
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741176#comment-17741176
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Based on this thread (1), how I got
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741157#comment-17741157
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
-1 on changing it back. We need to
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741155#comment-17741155
]
Marcus Eriksson commented on CASSANDRA-18639:
-
bq. make a new ticket to add
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741078#comment-17741078
]
Brandon Williams commented on CASSANDRA-18639:
--
bq. Regardless of whether we eventually
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741073#comment-17741073
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Regardless of whether we eventually
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741070#comment-17741070
]
Brandon Williams commented on CASSANDRA-18639:
--
All the display logic stays. We would
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741067#comment-17741067
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Could you please show me concrete
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741065#comment-17741065
]
Brandon Williams commented on CASSANDRA-18639:
--
bq. but we would need to completely
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741064#comment-17741064
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Frankly speaking, I think we are
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741063#comment-17741063
]
Brad Schoening commented on CASSANDRA-18639:
A JSON output option could be a good idea.
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741060#comment-17741060
]
Brandon Williams commented on CASSANDRA-18639:
--
Json, yaml, whatever.
> Add duration
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741059#comment-17741059
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I dont understand what you mean by
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741058#comment-17741058
]
Brandon Williams commented on CASSANDRA-18639:
--
I can understand and get behind both
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741043#comment-17741043
]
Brad Schoening commented on CASSANDRA-18639:
> Feels unnecessary potentially breaking
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741035#comment-17741035
]
Marcus Eriksson commented on CASSANDRA-18639:
-
bq. Since this goes to 5.0 I think we can
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741034#comment-17741034
]
Timothy Tu commented on CASSANDRA-18639:
Total Partitions is just the Counts all summed
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741029#comment-17741029
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I ll do that as I am just on in, no
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741027#comment-17741027
]
Brad Schoening commented on CASSANDRA-18639:
[~timothytu] we should document these
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741023#comment-17741023
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741020#comment-17741020
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Since this goes to 5.0 I think we can
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741019#comment-17741019
]
Marcus Eriksson commented on CASSANDRA-18639:
-
we should probably keep them for
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741017#comment-17741017
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I would keep it there because that
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741013#comment-17741013
]
Brandon Williams commented on CASSANDRA-18639:
--
We are already printing
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741011#comment-17741011
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Hah really, damn, where have we been
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741010#comment-17741010
]
Marcus Eriksson commented on CASSANDRA-18639:
-
yeah, we have the {{-s/--scan}} option to
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741006#comment-17741006
]
Brandon Williams commented on CASSANDRA-18639:
--
Yes, we should probably reopen and fix
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741005#comment-17741005
]
Brad Schoening commented on CASSANDRA-18639:
This tool, sstablemetadata is a utility
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741002#comment-17741002
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Why is that a problem? It just takes
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740999#comment-17740999
]
Marcus Eriksson commented on CASSANDRA-18639:
-
Looks like this iterates over all the
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740931#comment-17740931
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
+1 too, I added some minor fixes on
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740790#comment-17740790
]
Brandon Williams commented on CASSANDRA-18639:
--
Totally clean, +1 from me.
> Add
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740760#comment-17740760
]
Brandon Williams commented on CASSANDRA-18639:
--
Third time's the charm, we hope.
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740755#comment-17740755
]
Timothy Tu commented on CASSANDRA-18639:
I have updated the commit with the try statement
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740750#comment-17740750
]
Brandon Williams commented on CASSANDRA-18639:
--
Ekaterina pointed out we use this
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740737#comment-17740737
]
Brandon Williams commented on CASSANDRA-18639:
--
I think we probably need to add
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740727#comment-17740727
]
Brandon Williams commented on CASSANDRA-18639:
--
I have your
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740702#comment-17740702
]
Brandon Williams commented on CASSANDRA-18639:
--
||Branch||CI||
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740701#comment-17740701
]
Brandon Williams commented on CASSANDRA-18639:
--
||Branch||CI||
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740697#comment-17740697
]
Timothy Tu commented on CASSANDRA-18639:
[~brandon.williams] I added the close() should be
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740325#comment-17740325
]
Brandon Williams commented on CASSANDRA-18639:
--
eclipse-warnings is mad about the
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740316#comment-17740316
]
Brandon Williams commented on CASSANDRA-18639:
--
The nits can also be fixed on commit,
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740315#comment-17740315
]
Brad Schoening commented on CASSANDRA-18639:
[~brandon.williams] I've review it and it
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740310#comment-17740310
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I commented few nits on the PR. Might
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740309#comment-17740309
]
Brandon Williams commented on CASSANDRA-18639:
--
If this looks good to you [~bschoeni]
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739190#comment-17739190
]
Brandon Williams commented on CASSANDRA-18639:
--
Sounds good to me.
> Add duration and
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739188#comment-17739188
]
Brad Schoening commented on CASSANDRA-18639:
[~brandon.williams] to improve readability,
51 matches
Mail list logo
