[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Fix Version/s: 3.11.17
4.0.12
4.1.4
5.0-alpha2
5.1
Source Control Link: https://github.com/apache/cassandra/pull/2656
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Commited
([3.11|https://github.com/apache/cassandra/commit/87c2af85c1305c130af7d66f83dec03a1c4a8bb2]
[4.0|https://github.com/apache/cassandra/commit/c6385ac3ddccabdc7cb650b090fa69c0523274e8]
[4.1|https://github.com/apache/cassandra/commit/db6641fbb6fd0c439e14f94caecdeee999311c62]
[5.0|https://github.com/apache/cassandra/commit/a23f4c0b15c684240ef0bcd55875610e8bd7179b]
[trunk|https://github.com/apache/cassandra/commit/970ec2d1db5770c13a42e1f2862ea398317d0f15])
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Fix For: 3.11.17, 4.0.12, 4.1.4, 5.0-alpha2, 5.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Status: Review In Progress (was: Needs Committer)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Status: Ready to Commit (was: Review In Progress)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Status: Needs Committer (was: Patch Available)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Status: Patch Available (was: Requires Testing)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Status: Requires Testing (was: Review In Progress)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Reviewers: Branimir Lambov, Michael Semb Wever (was: Michael Semb Wever)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Reviewers: Branimir Lambov, Michael Semb Wever, Branimir Lambov (was:
Branimir Lambov, Michael Semb Wever)
Branimir Lambov, Michael Semb Wever, Branimir Lambov (was:
Branimir Lambov, Michael Semb Wever)
Status: Review In Progress (was: Patch Available)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Test and Documentation Plan: CI
Status: Patch Available (was: In Progress)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18756:
---
Reviewers: Michael Semb Wever
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Status: Open (was: Triage Needed)
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18756) TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references
[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18756:
Bug Category: Parent values: Degradation(12984)Level 1 values: Resource
Management(12995)
Complexity: Low Hanging Fruit
Discovered By: User Report
Severity: Normal
Since Version: 3.11.1
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> --
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Priority: Normal
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
