[GitHub] resmo commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

2018-02-20 Thread GitBox
resmo commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169546207 ## File path: ui/scripts/network.js ## @@ -3537,28 +3535,28 @@

[GitHub] resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

2018-02-20 Thread GitBox
resmo commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367228908 @rafaelweingartner changed the base to 4.11

[cloudstack-docs-admin] 01/01: Merge pull request #48 from andrijapanic/patch-2

2018-02-20 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-admin.git commit 3b5efe4ec60e50e313a7f3fc86c74b8abad4c959 Merge: 8060765 bb12969 Author: Rafael Weingärtner AuthorDate: Tu

[cloudstack-docs-admin] branch master updated (8060765 -> 3b5efe4)

2018-02-20 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-admin.git. from 8060765 Merge pull request #47 from andrijapanic/patch-1 add bb12969 Update code with proper sy

[GitHub] rafaelweingartner commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464#issuecomment-367160909 @resmo thanks for the contributions, but I have a doubt. You say it (the PR) is aimed at 4.11, bu

[GitHub] rafaelweingartner commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode

2018-02-20 Thread GitBox
rafaelweingartner commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169496341 ## File path: ui/scripts/network.js ## @@ -3537,28 +3535,28 @@

[cloudstack-docs-admin] branch master updated (079eac0 -> 8060765)

2018-02-20 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-admin.git. from 079eac0 accounts: update docs on dynamic roles add b4553d3 Updated KVM live storage migration a

[cloudstack-docs-admin] 01/01: Merge pull request #47 from andrijapanic/patch-1

2018-02-20 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-admin.git commit 8060765b5a7325d26c3144f2cc407052e5bd5275 Merge: 079eac0 b4553d3 Author: Rafael Weingärtner AuthorDate: Tu

[GitHub] rafaelweingartner commented on issue #2463: [CLOUDSTACK-10302] Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2463: [CLOUDSTACK-10302] Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463#issuecomment-367009994 @rhtyd I have no arguments against or pro Jira tickets for this specific case. I can create one t

[GitHub] rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-367116851 Ok, thanks! This is an automated message from the Apache Git Ser

[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

2018-02-20 Thread GitBox
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-367112605 @rafaelweingartner I already rebased today after I saw your comment, but the thing is this PR is really in WIP and I haven't completed it ye

[GitHub] rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-367100909 @khos2ow can you rebase this PR to latest master commit, and then we can check Jenkins and Travis status again. Let's make sure b

[GitHub] khos2ow commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

2018-02-20 Thread GitBox
khos2ow commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-367047666 @rafaelweingartner I'm still in favor of proceeding with that PR, because it will make build jobs immutable and reprod

[GitHub] resmo opened a new pull request #2464: CLOUDSTACK-10299: UI: fix error in network listing in project mode

2018-02-20 Thread GitBox
resmo opened a new pull request #2464: CLOUDSTACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464 Statically passing account (and domainid) results in a conflict when in project view because projectid and account can not be used t

[GitHub] blueorangutan commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
blueorangutan commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463#issuecomment-367017620 Packaging result: ?centos6 ?centos7 ?debian. JID-1727 T

[GitHub] rafaelweingartner commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463#issuecomment-367009994 @rhtyd I have no arguments against or pro Jira tickets for this specific case. I can create to use here if we decide

[GitHub] rhtyd commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
rhtyd commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463#issuecomment-367004938 @rafaelweingartner another comment - should this have a JIRA id, or just a general thought for several administrative-ish work s

[GitHub] blueorangutan commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
blueorangutan commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463#issuecomment-367004892 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
rhtyd commented on issue #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463#issuecomment-367004703 @blueorangutan package This is an automated message from the Ap

[GitHub] rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-366997501 Never mind, I found the problem. It is caused due to maven version [1]. Now I see the need for PR #2343.

[GitHub] rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-366989635 @DaanHoogland I pulled your branch and I tried to compile it here, but I got the following error: > F

[GitHub] dmytro-shevchenko commented on issue #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates

2018-02-20 Thread GitBox
dmytro-shevchenko commented on issue #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates URL: https://github.com/apache/cloudstack/pull/2457#issuecomment-366989305 Here is result from our test. As testdata['templates']['builtin'] we using password enabled Ubuntu 14.0

[GitHub] rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-366975836 I restarted travis job, if it turns out green I will proceed and merge this one ---

[GitHub] rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-366975011 @marcaurele would you mind separating the removal of those empty classes from the commit that introd

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-366974604 Thansk @khos2ow! Are we waiting for something else here? Everything seems to be in order. -

[GitHub] rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-20 Thread GitBox
rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-366973883 @borisstoyanov and @DaanHoogland I asked about the use of disabled clusters by root admins, because when

[GitHub] krissterckx commented on a change in pull request #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network

2018-02-20 Thread GitBox
krissterckx commented on a change in pull request #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network URL: https://github.com/apache/cloudstack/pull/2460#discussion_r169284527 ## File path: test/integration/plugins/nuagevsp/test_nuage_vsp_mngd_sub

[GitHub] rafaelweingartner opened a new pull request #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0

2018-02-20 Thread GitBox
rafaelweingartner opened a new pull request #2463: Create database path upgrade from 4.11.0.0 to 4.12.0.0 URL: https://github.com/apache/cloudstack/pull/2463 This is an automated message from the Apache Git Service. To respo

[GitHub] smeetsr commented on issue #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network

2018-02-20 Thread GitBox
smeetsr commented on issue #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network URL: https://github.com/apache/cloudstack/pull/2460#issuecomment-366939907 Executed full nuage acs regression and added extra tests into test/integration/plugins/nuage/test_nu

[GitHub] smeetsr commented on issue #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network

2018-02-20 Thread GitBox
smeetsr commented on issue #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network URL: https://github.com/apache/cloudstack/pull/2460#issuecomment-366939907 Executed full nuage acs regression and added extra tests into test/integration/plugins/nuage/test_nu

[GitHub] smeetsr commented on issue #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network

2018-02-20 Thread GitBox
smeetsr commented on issue #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network URL: https://github.com/apache/cloudstack/pull/2460#issuecomment-366939907 Executed full nuage acs regression and added extra tests into test/integration/plugins/nuage/test_nu