[GitHub] blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372904377 Trillian test result (tid-2355) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

2018-03-13 Thread GitBox
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-372901867 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

2018-03-13 Thread GitBox
rhtyd commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-372901758 @blueorangutan test matrix This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372881724 Trillian test result (tid-2354) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25459 seconds

[GitHub] rafaelweingartner opened a new pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-13 Thread GitBox
rafaelweingartner opened a new pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486 This is a continuation of work developed on PR #2425 (CLOUDSTACK-10240), which provided root admins an override

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

2018-03-13 Thread GitBox
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-372853935 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1776 This is an automated

[GitHub] blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372852794 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] DaanHoogland commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372852781 @blueorangutan test This is an

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372852585 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

2018-03-13 Thread GitBox
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-372845594 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

2018-03-13 Thread GitBox
rhtyd commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-372845365 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] rafaelweingartner commented on issue #2480: CLOUDSTACK-10319: Prefer TLSv1.2, deprecate TLSv1.0,1.1

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2480: CLOUDSTACK-10319: Prefer TLSv1.2, deprecate TLSv1.0,1.1 URL: https://github.com/apache/cloudstack/pull/2480#issuecomment-372824276 @rhtyd have you tested this one against XenServer 6.5?

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372804499 Packaging result: ?centos6 ?centos7 ?debian. JID-1775 This

[GitHub] blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372804066 Packaging result: ?centos6 ?centos7 ?debian. JID-1774

[GitHub] rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372797423 I actually meant unit tests. I think they would fit better the method extraction. They would also be

[GitHub] Slair1 commented on issue #2472: CLOUDSTACK-10310 Fix KVM reboot on storage issue

2018-03-13 Thread GitBox
Slair1 commented on issue #2472: CLOUDSTACK-10310 Fix KVM reboot on storage issue URL: https://github.com/apache/cloudstack/pull/2472#issuecomment-372797350 @wido My opinion is that the ability to start a VM on two hosts in the cluster is a bigger issue. We run KVM and just enabled

[GitHub] Slair1 commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox
Slair1 commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372796545 I've never created a Marvin Test before, but can look at test_vm_life_cycle.py to try and figure it out

[GitHub] Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox
Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#discussion_r174262477 ## File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java

[GitHub] Slair1 commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

2018-03-13 Thread GitBox
Slair1 commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-372795650 Since this is the same as #2429, should we just back-merge that?

[GitHub] Slair1 commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

2018-03-13 Thread GitBox
Slair1 commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-372794000 Yea, i can work to modularize this, i unfortunately don't have the time at the moment, but can later. On the tests, do you mean

[GitHub] Slair1 commented on a change in pull request #2472: CLOUDSTACK-10310 Fix KVM reboot on storage issue

2018-03-13 Thread GitBox
Slair1 commented on a change in pull request #2472: CLOUDSTACK-10310 Fix KVM reboot on storage issue URL: https://github.com/apache/cloudstack/pull/2472#discussion_r174260156 ## File path: scripts/vm/hypervisor/kvm/kvmheartbeat.sh ## @@ -155,10 +155,10 @@ then exit 0

[GitHub] DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174258066 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174258152 ## File path:

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372790381 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372790077 I'm afraid this is not public and the error is a git clone/fetch problem in this case; ERROR: Timeout after 10 minutes

[GitHub] rafaelweingartner commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372788605 Yes! This is an automated message from the Apache Git Service. To

[GitHub] rafaelweingartner commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174255133 ## File path:

[GitHub] DaanHoogland commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372787909 @rafaelweingartner is this lgty? This is an automated message from the Apache

[GitHub] rafaelweingartner commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174254978 ## File path:

[GitHub] DaanHoogland commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372787156 @blueorangutan package This is an

[GitHub] blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
blueorangutan commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372787213 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174253018 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174252867 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#discussion_r174251431 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#discussion_r174250100 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#discussion_r174248061 ## File path:

[GitHub] blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372774844 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] nvazquez commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
nvazquez commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372774591 @blueorangutan test This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372770183 Packaging result: ?centos6 ?centos7 ?debian. JID-1773 This is an automated

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372766474 @DaanHoogland is there a way to see the error of packaging? I believe this is related to #2485

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-13 Thread GitBox
blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-372764753 Trillian test result (tid-2352) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372756966 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] nvazquez commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
nvazquez commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372756801 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372756188 Packaging result: ?centos6 ?centos7 ?debian. JID-1772 This

[GitHub] blueorangutan commented on issue #2483: CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator

2018-03-13 Thread GitBox
blueorangutan commented on issue #2483: CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator URL: https://github.com/apache/cloudstack/pull/2483#issuecomment-372756102 Packaging result: ?centos6 ?centos7 ?debian. JID-1771

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372748378 @DaanHoogland I see, good to know! This is an automated message

[GitHub] DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-37273 Hihi, mister Writer pulled into the discussion here once again ;)

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372742443 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372742295 @khos2ow you can do packaging, only test is restricted to us due to resource scheduling/limitations @blueorangutan package

[GitHub] blueorangutan commented on issue #2483: CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator

2018-03-13 Thread GitBox
blueorangutan commented on issue #2483: CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator URL: https://github.com/apache/cloudstack/pull/2483#issuecomment-372741730 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I

[GitHub] DaanHoogland commented on issue #2483: CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2483: CLOUDSTACK-10303 : test data to nuage_test_data.py + run all tests against simulator URL: https://github.com/apache/cloudstack/pull/2483#issuecomment-372741426 @blueorangutan package

[GitHub] glennwagner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-03-13 Thread GitBox
glennwagner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372739879 LGTM , Thanks guys for the work. This is

[GitHub] rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-372736483 @DaanHoogland done.

[GitHub] DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-372735409 nice find, dirty hack, though maybe justified. Isn't the proper solution to put both queries in a

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

2018-03-13 Thread GitBox
khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-372735305 @rafaelweingartner I will. The reason for it's not done yet was that we wanted to partially upgrade Xen cluster and do

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372734572 @borisstoyanov it might be failing because the last packaging happened long time ago and some part of the PR has been changed since

[GitHub] rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372734014 It is ok the code as is. However, it might have been interesting to see the feedback of the author.

[GitHub] DaanHoogland commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-372733816 @rafaelweingartner sorry for sickness and ?dayjob preventing me to review again, can you

[GitHub] DaanHoogland commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372732335 @Slair1 @rafaelweingartner , can you come to agreement (maybe Rafael's sugestion here or in a separate

[cloudstack] branch master updated: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's. Added code to skip disabled clusters when selecting a host (#2442)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c3488a5 CLOUDSTACK-10147 Disabled

[GitHub] rafaelweingartner closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-03-13 Thread GitBox
rafaelweingartner closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372728437 I will merge then. Thanks @DaanHoogland, @borisroman and @houthuis

[GitHub] DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372727944 @houthuis @rafaelweingartner I am fine with this.

[GitHub] rafaelweingartner closed pull request #2484: createNetworkACL: number has the wrong doc

2018-03-13 Thread GitBox
rafaelweingartner closed pull request #2484: createNetworkACL: number has the wrong doc URL: https://github.com/apache/cloudstack/pull/2484 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[cloudstack] branch master updated: createNetworkACL: number has the wrong doc (#2484)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 521e71f createNetworkACL: number has the

[GitHub] rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372679976 @DaanHoogland are you ok with this one? The tests passed, and everything seems to be fine. The

[GitHub] rafaelweingartner commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl URL: https://github.com/apache/cloudstack/pull/2438#issuecomment-372678649 @borisstoyanov are these errors persistent ones, or should I take a look into them?

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-372677945 @khos2ow as soon as you have some final results with these tests, please tell us, so we can evaluate the

[GitHub] blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372677845 Trillian test result (tid-2350) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27672 seconds

[GitHub] rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-372677147 I am going to leave it as is. If we change the "reason" field name, I would need to change all references (JS, CSS, and

[GitHub] rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-372653103 @DaanHoogland I managed to separate the formatting from the code change itself. Now it should be

[GitHub] rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-372647841 I am still thinking about the change you mentioned. As soon as I have some feedback I tell you guys.

[GitHub] marcaurele commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

2018-03-13 Thread GitBox
marcaurele commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-372647342 Yeah, it wasn't aimed to this PR, more as a general idea. I'm ok with this change. If you think `description` is better

[GitHub] rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-372645391 What do you mean? Add the same thing to those rules/configurations? Well, that is interesting but it is not a

[GitHub] marcaurele commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

2018-03-13 Thread GitBox
marcaurele commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-372644992 It would be helpful for SG rules too for example, for IP aliases, snapshots...

[GitHub] rafaelweingartner commented on issue #2484: createNetworkACL: number has the wrong doc

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2484: createNetworkACL: number has the wrong doc URL: https://github.com/apache/cloudstack/pull/2484#issuecomment-372628239 This one is only a description change. It does not require integration tests to be run. The smoke tests executed by Travis

[GitHub] blueorangutan commented on issue #2468: [4.11] VR: minor fixes

2018-03-13 Thread GitBox
blueorangutan commented on issue #2468: [4.11] VR: minor fixes URL: https://github.com/apache/cloudstack/pull/2468#issuecomment-372622480 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2468: [4.11] VR: minor fixes

2018-03-13 Thread GitBox
rhtyd commented on issue #2468: [4.11] VR: minor fixes URL: https://github.com/apache/cloudstack/pull/2468#issuecomment-372622399 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-13 Thread GitBox
blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-372622468 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-13 Thread GitBox
rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-372622417 @blueorangutan test This is an automated message from the

[cloudstack] branch 4.6.2.1-RC20160525T1218 deleted (was bc2e2cf)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.6.2.1-RC20160525T1218 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was bc2e2cf Updating pom.xml version numbers for release 4.6.2.1 The revisions that were on this

[cloudstack] branch 4.6.2-RC20151213T1914 deleted (was 10e0130)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.6.2-RC20151213T1914 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 10e0130 Updating pom.xml version numbers for release 4.6.2 The revisions that were on this

[cloudstack] branch 4.6.1-RC20151130T2258 deleted (was beb840f)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.6.1-RC20151130T2258 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was beb840f Updating pom.xml version numbers for release 4.6.1 The revisions that were on this

[cloudstack] branch 4.6.1-RC20151130T2246 deleted (was 3913fc8)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.6.1-RC20151130T2246 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 3913fc8 Updating pom.xml version numbers for release 4.6.1 This change permanently discards the

[cloudstack] branch 4.6.0-RC20151104T1522 deleted (was b0ebe68e)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.6.0-RC20151104T1522 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was b0ebe68e Updating pom.xml version numbers for release 4.6.0 This change permanently discards the

[cloudstack] branch 4.6.0-RC20151110T1545 deleted (was e31ade0)

2018-03-13 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.6.0-RC20151110T1545 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was e31ade0 Updating pom.xml version numbers for release 4.6.0 The revisions that were on this

[GitHub] rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

2018-03-13 Thread GitBox
rafaelweingartner commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-372613094 That is an interesting suggestion. I have not thought about "description" to name that field.

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-13 Thread GitBox
blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-372610958 Packaging result: ?centos6 ?centos7 ?debian. JID-1769

[GitHub] blueorangutan commented on issue #2468: [4.11] VR: minor fixes

2018-03-13 Thread GitBox
blueorangutan commented on issue #2468: [4.11] VR: minor fixes URL: https://github.com/apache/cloudstack/pull/2468#issuecomment-372611122 Packaging result: ?centos6 ?centos7 ?debian. JID-1770 This is an automated message from

[GitHub] blueorangutan commented on issue #2468: [4.11] VR: minor fixes

2018-03-13 Thread GitBox
blueorangutan commented on issue #2468: [4.11] VR: minor fixes URL: https://github.com/apache/cloudstack/pull/2468#issuecomment-372599351 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2468: [4.11] VR: minor fixes

2018-03-13 Thread GitBox
rhtyd commented on issue #2468: [4.11] VR: minor fixes URL: https://github.com/apache/cloudstack/pull/2468#issuecomment-372599185 @blueorangutan package This is an automated message from the Apache Git Service. To respond to

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-13 Thread GitBox
blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-372599074 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-13 Thread GitBox
rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-372598940 @blueorangutan package This is an automated message from

[GitHub] rhtyd commented on issue #2485: Bump the version of Debian net-installer to 9.4.0

2018-03-13 Thread GitBox
rhtyd commented on issue #2485: Bump the version of Debian net-installer to 9.4.0 URL: https://github.com/apache/cloudstack/pull/2485#issuecomment-372589740 Built and tested locally. For 4.11, we're not going to change the systemvmtemplate for just this change. However, there are some PRs

[GitHub] rhtyd commented on issue #2485: Bump the version of Debian net-installer to 9.4.0

2018-03-13 Thread GitBox
rhtyd commented on issue #2485: Bump the version of Debian net-installer to 9.4.0 URL: https://github.com/apache/cloudstack/pull/2485#issuecomment-372589740 Built and tested locally. For 4.11, we're not going to change the systemvmtemplate for just this change. However, there are some PRs

[cloudstack] branch 4.11 updated: Bump the version of Debian net-installer to 9.4.0 (#2485)

2018-03-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 7112aff Bump the version of Debian

[GitHub] rhtyd closed pull request #2485: Bump the version of Debian net-installer to 9.4.0

2018-03-13 Thread GitBox
rhtyd closed pull request #2485: Bump the version of Debian net-installer to 9.4.0 URL: https://github.com/apache/cloudstack/pull/2485 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372556770 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
borisstoyanov commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372556713 @rafaelweingartner the environment has failed, let me re-run it. @blueorangutan test

[GitHub] blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM

2018-03-13 Thread GitBox
blueorangutan commented on issue #2482: CLOUDSTACK-10321: CPU Cap for KVM URL: https://github.com/apache/cloudstack/pull/2482#issuecomment-372555880 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

  1   2   >