[GitHub] [cloudstack] Pearl1594 commented on issue #4814: GSoC 2021 Idea: Synchronization of network devices on newly added hosts for Persistent Networks

2021-04-09 Thread GitBox
Pearl1594 commented on issue #4814: URL: https://github.com/apache/cloudstack/issues/4814#issuecomment-817086978 Hi @JushwanthGV , thanks for your interest! To start off, you can work on drafting your application / project proposal and may use https://google.github.io/gsocguides/student/

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817086412 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 378 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
nvazquez commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817084115 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817084175 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] JushwanthGV commented on issue #4814: GSoC 2021 Idea: Synchronization of network devices on newly added hosts for Persistent Networks

2021-04-09 Thread GitBox
JushwanthGV commented on issue #4814: URL: https://github.com/apache/cloudstack/issues/4814#issuecomment-817083982 Hi, I'm interested in this project, and I'm new to open source I would like to include this project for gsoc. Can anyone help me with how to start? I would like to kno

[GitHub] [cloudstack] bickrombishsass commented on issue #4813: GSoC 2021 Idea: Support Multiple SSH Keys for VMs

2021-04-09 Thread GitBox
bickrombishsass commented on issue #4813: URL: https://github.com/apache/cloudstack/issues/4813#issuecomment-817081199 @rhtyd @davidjumani pls let me know if more changes needed on the proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
nvazquez commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817078455 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-817077285 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

2021-04-09 Thread GitBox
nvazquez commented on pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-817077173 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817053508 Trillian test result (tid-398) Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39249 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4898: VM Snapshot: Prevent vm snapshots being indefinitely stuck in Expunging state on deletion failure

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4898: URL: https://github.com/apache/cloudstack/pull/4898#issuecomment-817040538 Trillian test result (tid-389) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 63989 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4904: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4904: URL: https://github.com/apache/cloudstack/pull/4904#issuecomment-817039788 Trillian test result (tid-397) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35329 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-817018742 Trillian test result (tid-396) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44246 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4706: Improve logs on KVMHostActivityChecker

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4706: URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-817004431 Trillian test result (tid-393) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49324 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4900: Fixed hosts not displaying with incompatible locale

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4900: URL: https://github.com/apache/cloudstack/pull/4900#issuecomment-816996047 Trillian test result (tid-394) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46613 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4722: Externalize config to set min memory/cpu with division by overprovisiā€¦

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4722: URL: https://github.com/apache/cloudstack/pull/4722#issuecomment-816979798 Trillian test result (tid-391) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49114 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4573: Add support to StartTLS on Quota's mailing

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4573: URL: https://github.com/apache/cloudstack/pull/4573#issuecomment-816916124 Trillian test result (tid-390) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42094 seconds Marvin logs: https://github

[GitHub] [cloudstack] abhi005 commented on issue #4844: UI should show IPv6 addresses of Instance

2021-04-09 Thread GitBox
abhi005 commented on issue #4844: URL: https://github.com/apache/cloudstack/issues/4844#issuecomment-816823918 @utchoang yes, already started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816797384 Trillian test result (tid-388) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35738 seconds Marvin logs: https://github

[GitHub] [cloudstack] ggoodrich-ipp edited a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
ggoodrich-ipp edited a comment on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816766158 > @dhansenippathways can you help test #4595 We tested this, and have been running these changes in our Production environment for around one year (4.11.3)

[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
ggoodrich-ipp commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816766158 > @dhansenippathways can you help test #4595 We tested this, and have been running these changes in our Production environment for around one year (4.11.3). We re

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816761477 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 377 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
andrijapanicsb commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816761164 This needs some serious testing by someone who has been playing and/or suffering with VPNs. Let's make sure we don't break anything. I like the PR in general. 4

[GitHub] [cloudstack] andrijapanicsb commented on issue #4757: issues with live migration on centos (was: Trillian test failures)

2021-04-09 Thread GitBox
andrijapanicsb commented on issue #4757: URL: https://github.com/apache/cloudstack/issues/4757#issuecomment-816753703 For the purpose of this issue, just ask @davidjumani to revert the change (done by whoever...) that made these test suddenly run, instead of being skipped, as they had been

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4717: Added recursive fetch of child domains for listUsageRecords API call

2021-04-09 Thread GitBox
andrijapanicsb commented on pull request #4717: URL: https://github.com/apache/cloudstack/pull/4717#issuecomment-816752121 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4801: skip livemigration for centos

2021-04-09 Thread GitBox
andrijapanicsb commented on pull request #4801: URL: https://github.com/apache/cloudstack/pull/4801#issuecomment-816751303 No, we want to keep the old behaviour of SKIPPING these, David knows the root cause why these are now run, by mistake (previously were "overriden" not to run).

[GitHub] [cloudstack] skattoju4 commented on issue #4874: CLOUDSTACK-9341 volume import and export when using swift as secondary storage

2021-04-09 Thread GitBox
skattoju4 commented on issue #4874: URL: https://github.com/apache/cloudstack/issues/4874#issuecomment-816750209 Yes template upload works, however download progress is not reported... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816747164 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

2021-04-09 Thread GitBox
nvazquez commented on pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816746778 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816733835 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 376 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
nvazquez commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816718182 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4738: URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816718775 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] blueorangutan commented on pull request #4572: fix of detach volume while OS is in boot state

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4572: URL: https://github.com/apache/cloudstack/pull/4572#issuecomment-816706076 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 374 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #4904: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4904: URL: https://github.com/apache/cloudstack/pull/4904#issuecomment-816706115 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 375 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4706: Improve logs on KVMHostActivityChecker

2021-04-09 Thread GitBox
GabrielBrascher commented on pull request #4706: URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-816659039 This one looks ready for merge. Travis and Jenkins's tests have passed and the code has 2 LGTMs. Maybe we can spawn @blueorangutan for testing. -- This is an automa

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4878: Support vm dynamic scaling with kvm

2021-04-09 Thread GitBox
GabrielBrascher commented on a change in pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#discussion_r609057901 ## File path: server/src/main/java/com/cloud/hypervisor/KVMGuru.java ## @@ -112,32 +121,147 @@ public VirtualMachineTO implement(VirtualMachine

[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
DaanHoogland commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816655461 @dhansenippathways can you help test #4595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
DaanHoogland commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816654906 @rhtyd @soreana @ggoodrich-ipp, I backported to 4.15 branch in #4904 please have a look and a spin. cc @borisstoyanov @weizhouapache -- This is an automated mes

[GitHub] [cloudstack] DaanHoogland opened a new pull request #4904: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
DaanHoogland opened a new pull request #4904: URL: https://github.com/apache/cloudstack/pull/4904 IKE version allows selecting ike (autoselect), ikev1, or ikev2. Split connections gives an option of separating the first right subnet from the rest, and kicking out individual statements fo

[cloudstack] 01/01: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch split-connections in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 01bf0c5784826a2997be4825c5534fe0391f2603 Author: Greg Goodrich AuthorDate: Wed Mar 18 10:15:20 2020 -0500

[cloudstack] branch split-connections created (now 01bf0c5)

2021-04-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch split-connections in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 01bf0c5 Adding VPN options for IKE version and IKE split connections. This branch includes the followi

[GitHub] [cloudstack] borisstoyanov removed a comment on pull request #4899: Fix orphan entry on ldap trust map after account removal

2021-04-09 Thread GitBox
borisstoyanov removed a comment on pull request #4899: URL: https://github.com/apache/cloudstack/pull/4899#issuecomment-816653172 LGTM, manually verified this ``` (localcloud) SBCM5> > link accounttoldap account=dom-admin domainid=3bdaff06-4a44-45a0-a644-50f563c1b3e2 accounttype=

[GitHub] [cloudstack] borisstoyanov commented on pull request #4899: Fix orphan entry on ldap trust map after account removal

2021-04-09 Thread GitBox
borisstoyanov commented on pull request #4899: URL: https://github.com/apache/cloudstack/pull/4899#issuecomment-816653172 LGTM, manually verified this ``` (localcloud) SBCM5> > link accounttoldap account=dom-admin domainid=3bdaff06-4a44-45a0-a644-50f563c1b3e2 accounttype=2 ldapdo

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4895: vmware: fix inter-cluster stopped vm and volume migration

2021-04-09 Thread GitBox
shwstppr commented on a change in pull request #4895: URL: https://github.com/apache/cloudstack/pull/4895#discussion_r610590349 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ## @@ -2211,4 +2253,36 @@ public static void create

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4638: server: fix root disk size on vm reset

2021-04-09 Thread GitBox
shwstppr commented on a change in pull request #4638: URL: https://github.com/apache/cloudstack/pull/4638#discussion_r610589014 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -6678,6 +6678,12 @@ public UserVm restoreVirtualMachine(final Account ca

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4638: server: fix root disk size on vm reset

2021-04-09 Thread GitBox
shwstppr commented on a change in pull request #4638: URL: https://github.com/apache/cloudstack/pull/4638#discussion_r610588460 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -6678,6 +6678,12 @@ public UserVm restoreVirtualMachine(final Account ca

[GitHub] [cloudstack] soreana commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
soreana commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816640402 @rhtyd @ggoodrich-ipp How I can help to test this pr? Could you provide some test scenario? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on pull request #4493: Recover VM not able to attach the data disks which were attached before destroy

2021-04-09 Thread GitBox
rhtyd commented on pull request #4493: URL: https://github.com/apache/cloudstack/pull/4493#issuecomment-816635690 Thanks @harikrishna-patnala @DaanHoogland @sureshanaparti for the comments and raising that as an issue - let's address the corrective behaviour as a separate task. Do we need

[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816633424 @weizhouapache @GabrielBrascher @wido @kiwiflyer @ravening @soreana @svenvogel @DaanHoogland @andrijapanicsb @shwstppr @Pearl1594 @Spaceman1984 - this is an enhancement that ma

[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-04-09 Thread GitBox
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816621133 @ggoodrich-ipp can you fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] shatoboar opened a new pull request #4903: changed variable name to avoid collision in python3

2021-04-09 Thread GitBox
shatoboar opened a new pull request #4903: URL: https://github.com/apache/cloudstack/pull/4903 ### Description This PR... cloudstack/tools/apidocs/gen_toc.py changed variable name to avoid namecollision with reserved name. ###

[cloudstack] branch marvin3 updated (c550b0f -> 104e161)

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch marvin3 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c550b0f Merge branch 'master' into marvin3 add 104e161 test pyenv2 to install No new revisions were added

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4638: server: fix root disk size on vm reset

2021-04-09 Thread GitBox
sureshanaparti commented on a change in pull request #4638: URL: https://github.com/apache/cloudstack/pull/4638#discussion_r610544957 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -6678,6 +6678,12 @@ public UserVm restoreVirtualMachine(final Accou

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4638: server: fix root disk size on vm reset

2021-04-09 Thread GitBox
sureshanaparti commented on a change in pull request #4638: URL: https://github.com/apache/cloudstack/pull/4638#discussion_r610543254 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -6678,6 +6678,12 @@ public UserVm restoreVirtualMachine(final Accou

[GitHub] [cloudstack] lujiefsi commented on a change in pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
lujiefsi commented on a change in pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#discussion_r610542641 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1994,6 +1997,10 @@ private void validateRootVolumeDetachAttach(V

[GitHub] [cloudstack] lujiefsi commented on a change in pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
lujiefsi commented on a change in pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#discussion_r610542641 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1994,6 +1997,10 @@ private void validateRootVolumeDetachAttach(V

[GitHub] [cloudstack] lujiefsi commented on a change in pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
lujiefsi commented on a change in pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#discussion_r610542641 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1994,6 +1997,10 @@ private void validateRootVolumeDetachAttach(V

[GitHub] [cloudstack] lujiefsi commented on a change in pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
lujiefsi commented on a change in pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#discussion_r610539467 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1994,6 +1997,10 @@ private void validateRootVolumeDetachAttach(V

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
sureshanaparti commented on a change in pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#discussion_r610533407 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1994,6 +1997,10 @@ private void validateRootVolumeDetachAt

[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-816584604 @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] sureshanaparti commented on pull request #4135: Remove use of blacklist/whitelist terms

2021-04-09 Thread GitBox
sureshanaparti commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-816584223 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4493: Recover VM not able to attach the data disks which were attached before destroy

2021-04-09 Thread GitBox
harikrishna-patnala commented on pull request #4493: URL: https://github.com/apache/cloudstack/pull/4493#issuecomment-816583851 I've created an improvement ticket for 4.16 here https://github.com/apache/cloudstack/issues/4902 -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] harikrishna-patnala opened a new issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again

2021-04-09 Thread GitBox
harikrishna-patnala opened a new issue #4902: URL: https://github.com/apache/cloudstack/issues/4902 This is an improvement ticket in which volumes of a VM which are not intended to be deleted (when VM is tried to destroy) are going to be detached from VM during destroy VM operation

[GitHub] [cloudstack] soreana commented on issue #4093: Centralised logging via rsyslog

2021-04-09 Thread GitBox
soreana commented on issue #4093: URL: https://github.com/apache/cloudstack/issues/4093#issuecomment-816576844 I asked our PO. We made a story to work on that. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [cloudstack] DaanHoogland commented on issue #4093: Centralised logging via rsyslog

2021-04-09 Thread GitBox
DaanHoogland commented on issue #4093: URL: https://github.com/apache/cloudstack/issues/4093#issuecomment-816569188 this summer somewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [cloudstack] DaanHoogland commented on pull request #3712: [WORK IN PROGRES - do NOT merge] Replace builtin CentOS 5.x with 8.0 templates

2021-04-09 Thread GitBox
DaanHoogland commented on pull request #3712: URL: https://github.com/apache/cloudstack/pull/3712#issuecomment-81656 are we abandonning this as it is centos8, @andrijapanicsb @rhtyd @GabrielBrascher ? And will we plan a new implementation for #3700? -- This is an automated message

[GitHub] [cloudstack] soreana commented on issue #4093: Centralised logging via rsyslog

2021-04-09 Thread GitBox
soreana commented on issue #4093: URL: https://github.com/apache/cloudstack/issues/4093#issuecomment-816562328 @DaanHoogland When do you planned for 4.16 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [cloudstack] DaanHoogland commented on issue #4093: Centralised logging via rsyslog

2021-04-09 Thread GitBox
DaanHoogland commented on issue #4093: URL: https://github.com/apache/cloudstack/issues/4093#issuecomment-816560515 @soreana should/can we mark this for 4.16? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack] wido commented on issue #4757: issues with live migration on centos (was: Trillian test failures)

2021-04-09 Thread GitBox
wido commented on issue #4757: URL: https://github.com/apache/cloudstack/issues/4757#issuecomment-816554754 > @andrijapanicsb we can ignore CentOS6, which has reached EOL, in the current release/context of CloudStack. > > Given the limitations should we be promoting using Ubuntu now

[GitHub] [cloudstack] staySober commented on issue #4876: why new ui just have advanced network and not have the basic network zone option?

2021-04-09 Thread GitBox
staySober commented on issue #4876: URL: https://github.com/apache/cloudstack/issues/4876#issuecomment-816551271 thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-816545057 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 373 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#issuecomment-816544530 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 372 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] DaanHoogland closed issue #4865: No "data-server" DNS record for VPC router

2021-04-09 Thread GitBox
DaanHoogland closed issue #4865: URL: https://github.com/apache/cloudstack/issues/4865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [cloudstack] DaanHoogland commented on issue #4865: No "data-server" DNS record for VPC router

2021-04-09 Thread GitBox
DaanHoogland commented on issue #4865: URL: https://github.com/apache/cloudstack/issues/4865#issuecomment-816531105 closing as #4873 is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-816522675 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on pull request #4135: Remove use of blacklist/whitelist terms

2021-04-09 Thread GitBox
sureshanaparti commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-816521957 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
blueorangutan removed a comment on pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#issuecomment-816518379 Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 370 -- This is an automated message from the A

[GitHub] [cloudstack] DaanHoogland commented on pull request #4493: Recover VM not able to attach the data disks which were attached before destroy

2021-04-09 Thread GitBox
DaanHoogland commented on pull request #4493: URL: https://github.com/apache/cloudstack/pull/4493#issuecomment-816520958 I think trying to attach disk during discovery is a bug. It can give serious errors if the disks were attached to another VM before recovery. We should document that thi

[GitHub] [cloudstack] blueorangutan commented on pull request #4638: server: fix root disk size on vm reset

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4638: URL: https://github.com/apache/cloudstack/pull/4638#issuecomment-816520740 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 371 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] blueorangutan commented on pull request #4900: Fixed hosts not displaying with incompatible locale

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4900: URL: https://github.com/apache/cloudstack/pull/4900#issuecomment-816520006 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #4900: Fixed hosts not displaying with incompatible locale

2021-04-09 Thread GitBox
shwstppr commented on pull request #4900: URL: https://github.com/apache/cloudstack/pull/4900#issuecomment-816519611 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] Pearl1594 commented on issue #4808: CloudStack uses 1st cdrom of VM to mount ConfigDrive ISO

2021-04-09 Thread GitBox
Pearl1594 commented on issue #4808: URL: https://github.com/apache/cloudstack/issues/4808#issuecomment-816518800 @aleskxyz attaching configdrive ISO to the 2nd drive would involve considerable design changes on vmware end which is something we can target for the next major release - 4.16.

[GitHub] [cloudstack] blueorangutan commented on pull request #4859: CLOUDSTACK-10434:Some APIs should have access check

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#issuecomment-816518379 Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 370 -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4493: Recover VM not able to attach the data disks which were attached before destroy

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4493: URL: https://github.com/apache/cloudstack/pull/4493#issuecomment-816518380 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 369 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #4900: Fixed hosts not displaying with incompatible locale

2021-04-09 Thread GitBox
blueorangutan commented on pull request #4900: URL: https://github.com/apache/cloudstack/pull/4900#issuecomment-816517499 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 368 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] DaanHoogland commented on pull request #4796: db, server: refactor host_view to prevent duplicate entries

2021-04-09 Thread GitBox
DaanHoogland commented on pull request #4796: URL: https://github.com/apache/cloudstack/pull/4796#issuecomment-816512423 The code and your test output look like a great cleanup @shwstppr! Can you describe testing a bit further? It looks scary in terms of API output and UI consequences ;)

[GitHub] [cloudstack] rhtyd closed pull request #4900: Fixed hosts not displaying with incompatible locale

2021-04-09 Thread GitBox
rhtyd closed pull request #4900: URL: https://github.com/apache/cloudstack/pull/4900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15'

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 22f6c19248408385007d9e56f357630f5abea6f8 Merge: 6d0d701 ca8920d Author: Rohit Yadav AuthorDate: Fri Apr 9 13:21:07 20

[GitHub] [cloudstack] rhtyd closed issue #4517: VPC deployment - failure to retry other host in a cluster after the choosen host not having enough capacities

2021-04-09 Thread GitBox
rhtyd closed issue #4517: URL: https://github.com/apache/cloudstack/issues/4517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[cloudstack] branch master updated (6d0d701 -> 22f6c19)

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 6d0d701 api,engine/schema,server: vm readonly details rename (#4671) add cd38519 tests: Fix k8s test failur

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4901: [Vmware] Make deploy-as-is optional

2021-04-09 Thread GitBox
harikrishna-patnala commented on a change in pull request #4901: URL: https://github.com/apache/cloudstack/pull/4901#discussion_r610421532 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java ## @@ -162,6 +162,11 @@

[cloudstack-documentation] branch master updated: vm: note about read-only details (#206)

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/master by this push: new 68210ce vm: note about read-on

[cloudstack] branch master updated (ecc1816 -> 6d0d701)

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ecc1816 Merge remote-tracking branch 'origin/4.15' add 6d0d701 api,engine/schema,server: vm readonly detail

[GitHub] [cloudstack] rhtyd merged pull request #4671: api,engine/schema,server: vm readonly details rename

2021-04-09 Thread GitBox
rhtyd merged pull request #4671: URL: https://github.com/apache/cloudstack/pull/4671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14' into 4.15

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ca8920dd36c145086d2ea0b242a6e3d85c278f83 Merge: d8c6e00 cd60b8d Author: Rohit Yadav AuthorDate: Fri Apr 9 13:17:39 2021

[cloudstack] branch 4.15 updated (d8c6e00 -> ca8920d)

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from d8c6e00 hypervisor: XCP-ng 8.2 support (#4672) add cd60b8d host-allocator: check capacity for suitable hosts

[GitHub] [cloudstack] harikrishna-patnala commented on issue #4825: GSoC 2021 Idea: Mapping existing configuration parameters to the APIs

2021-04-09 Thread GitBox
harikrishna-patnala commented on issue #4825: URL: https://github.com/apache/cloudstack/issues/4825#issuecomment-816488628 Hi @damanBirSingh, It's great to hear from you and your interest on this project. I'm happy to mentor and work with you. Like we already discussed please go throu

[GitHub] [cloudstack] rhtyd commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

2021-04-09 Thread GitBox
rhtyd commented on pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816486678 @nvazquez please fix conflicts and re-run a round of smoketests against vmware7 and vmware 6.7 -- This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch 4.15 updated: hypervisor: XCP-ng 8.2 support (#4672)

2021-04-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.15 by this push: new d8c6e00 hypervisor: XCP-ng 8.2 support (#4672) d

[GitHub] [cloudstack] rhtyd merged pull request #4672: hypervisor: XCP-ng 8.2 support

2021-04-09 Thread GitBox
rhtyd merged pull request #4672: URL: https://github.com/apache/cloudstack/pull/4672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

  1   2   >