[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
DaanHoogland commented on code in PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082200976 ## python/lib/cloudutils/syscfg.py: ## @@ -222,6 +224,18 @@ def __init__(self, glbEnv): nfsConfig(self),

[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398026354 @DaanHoogland a Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398025675 @blueorangutan test ubuntu22 kvm-ubuntu22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] weizhouapache commented on issue #6765: Using API's created instances gives error Permission denied (publickey) under the VPC network

2023-01-19 Thread GitBox
weizhouapache commented on issue #6765: URL: https://github.com/apache/cloudstack/issues/6765#issuecomment-1398003021 @satishglondhe can you test #7103 if possible ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1397909624 Trillian test result (tid-5908) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 53963 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1397856211 Trillian test result (tid-5909) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47821 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers

2023-01-19 Thread GitBox
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1397815878 Trillian test result (tid-5906) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46574 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7104: CKS: remove details when delete a cks cluster

2023-01-19 Thread GitBox
blueorangutan commented on PR #7104: URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1397768436 Trillian test result (tid-5907) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39610 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-19 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1397747277 Trillian test result (tid-5904) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server u20 Total time taken: 51800 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP

2023-01-19 Thread GitBox
blueorangutan commented on PR #7103: URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1397715235 Trillian test result (tid-5905) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43696 seconds Marvin logs:

[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7116: Network in allocated state - VLAN isoltation

2023-01-19 Thread GitBox
boring-cyborg[bot] commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1397688400 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] jaghabalayev opened a new issue, #7116: Network in allocated state - VLAN isoltation

2023-01-19 Thread GitBox
jaghabalayev opened a new issue, #7116: URL: https://github.com/apache/cloudstack/issues/7116 ISSUE TYPE * Bug Report COMPONENT NAME * Physical Network/Guest Network CLOUDSTACK VERSION CloudStack 4.17.2.0 CONFIGURATION Advanced

[GitHub] [cloudstack] blueorangutan commented on pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
blueorangutan commented on PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1397502162 Trillian test result (tid-5901) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47871 seconds Marvin logs:

[GitHub] [cloudstack] weizhouapache commented on issue #4238: uefi vm creation fail

2023-01-19 Thread GitBox
weizhouapache commented on issue #4238: URL: https://github.com/apache/cloudstack/issues/4238#issuecomment-1397424979 It seems not be a bug should we close this ? @DaanHoogland @rohityadavcloud -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] weizhouapache commented on issue #6987: Project User kubeadmin is not working with project k8s clusters

2023-01-19 Thread GitBox
weizhouapache commented on issue #6987: URL: https://github.com/apache/cloudstack/issues/6987#issuecomment-1397280996 @davidjumani are you working on this ? If not, I will have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
rohityadavcloud commented on code in PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#discussion_r1081518250 ## tools/marvin/setup.py: ## @@ -46,7 +46,7 @@ "marvin.sandbox.basic"], license="LICENSE.txt", install_requires=[ -

[GitHub] [cloudstack] vladimirpetrov commented on pull request #6005: Support to resize uploaded volume during attach

2023-01-19 Thread GitBox
vladimirpetrov commented on PR #6005: URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1397231963 Please note that this change is only on the API level - no UI. There is a new parameter 'size' to the 'upload volume' command and you're able to customize the volume size

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1397213676 @DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8`. Supported hypervisors are:

[GitHub] [cloudstack] DaanHoogland commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1397212926 @blueorangutan test centos7 vmware-70u3' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] DaanHoogland commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1397211190 testing el7 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1397086755 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1397079059 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5331 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1397054924 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5330 -- This is an

[GitHub] [cloudstack] sbrueseke opened a new issue, #7115: Unable to deploy VM using Template and custom disk offering

2023-01-19 Thread GitBox
sbrueseke opened a new issue, #7115: URL: https://github.com/apache/cloudstack/issues/7115 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VM ~~~ # CLOUDSTACK VERSION ~~~ 4.17.2.0 ~~~ # CONFIGURATION

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1397031867 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
weizhouapache commented on code in PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#discussion_r1081271434 ## tools/marvin/setup.py: ## @@ -46,7 +46,7 @@ "marvin.sandbox.basic"], license="LICENSE.txt", install_requires=[ -

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
weizhouapache commented on code in PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1081267991 ## python/lib/cloudutils/serviceConfig.py: ## @@ -617,11 +617,8 @@ def config(self): cfo.addEntry("LIBVIRTD_ARGS", "-l") cfo.save()

[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396985551 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
weizhouapache commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396984497 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396980807 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396979433 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
rohityadavcloud commented on code in PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#discussion_r1081260629 ## tools/marvin/setup.py: ## @@ -46,7 +46,7 @@ "marvin.sandbox.basic"], license="LICENSE.txt", install_requires=[ -

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1396972479 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
rohityadavcloud commented on code in PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1081254700 ## python/lib/cloudutils/syscfg.py: ## @@ -45,6 +45,8 @@ def getAgent(glbEnv): return sysConfigRedhat7(glbEnv) elif distribution ==

[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #7114: cloudstack-setup-agent: mask libvirt non-monolithic services

2023-01-19 Thread GitBox
rohityadavcloud opened a new pull request, #7114: URL: https://github.com/apache/cloudstack/pull/7114 This masks sockets such as virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket, and services virtqemud virtnetworkd virtstoraged that block libvirtd to be used a monolithic

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396957344 Mentioned briefly in the description; I was trying to deploy Vmware 7 and 8 on an EL8 mgmt server when the routing-8.ova won't extract as "tar" pkg was missing on the mgmt

[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-19 Thread GitBox
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1396944865 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1396936726 @BryanMLima did you already test this? (I didnĀ“t yet) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1396935692 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1396935128 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396933455 @rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396932430 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy

2023-01-19 Thread GitBox
DaanHoogland commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396926484 tnx @nvazquez > It was code review sorry @DaanHoogland, let me test it this week -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1396927362 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5329 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7104: CKS: remove details when delete a cks cluster

2023-01-19 Thread GitBox
blueorangutan commented on PR #7104: URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396924891 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #7104: CKS: remove details when delete a cks cluster

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7104: URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396924496 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396923759 @blueorangutan rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396922866 @rohityadavcloud I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] Mgmt OS options:

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
DaanHoogland commented on code in PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#discussion_r1081214802 ## tools/marvin/setup.py: ## @@ -46,7 +46,7 @@ "marvin.sandbox.basic"], license="LICENSE.txt", install_requires=[ -

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396921973 @blueorangutan help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396921716 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
DaanHoogland commented on code in PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#discussion_r1081212167 ## tools/marvin/setup.py: ## @@ -46,7 +46,7 @@ "marvin.sandbox.basic"], license="LICENSE.txt", install_requires=[ -

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
DaanHoogland commented on code in PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#discussion_r1081210993 ## tools/marvin/setup.py: ## @@ -46,7 +46,7 @@ "marvin.sandbox.basic"], license="LICENSE.txt", install_requires=[ -

[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396911454 > > @weizhouapache should I rebase on 4.17? > > @DaanHoogland > > it will be complicated ... > > you need to > (1) add upgrade path 4.17.2.0->4.17.3.0

[cloudstack] branch 4.17 updated: api/server: add project id/name in ssh keypair response (#7100)

2023-01-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.17 by this push: new 37b2a4826d api/server: add project id/name in ssh

[GitHub] [cloudstack] DaanHoogland merged pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-19 Thread GitBox
DaanHoogland merged PR #7100: URL: https://github.com/apache/cloudstack/pull/7100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers

2023-01-19 Thread GitBox
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1396878706 @DaanHoogland a Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #7094: Handle console session in multiple management servers

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1396876795 @blueorangutan test rocky8 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
weizhouapache commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396870521 > @weizhouapache should I rebase on 4.17? it will be complicated ... you need to (1) add upgrade path 4.17.2.0->4.17.3.0 (2) move everything to

[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396865838 > LGTM @DaanHoogland would we need to do that with every release? Basically, no. Only because the mapping code was broken between 4.16.1 and 4.18 we need to redo the

[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1396858058 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2023-01-19 Thread GitBox
weizhouapache commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1396856375 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
DaanHoogland commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396845044 @weizhouapache should I rebase on 4.17? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #7112: Make display elements optional

2023-01-19 Thread GitBox
blueorangutan commented on PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396842932 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-34) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] nvazquez commented on pull request #6909: KVM support of iothreads and IO driver policy

2023-01-19 Thread GitBox
nvazquez commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396840715 > @nvazquez @wido has either of you tested this? It was code review sorry @DaanHoogland, let me test it this week -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #7112: Make display elements optional

2023-01-19 Thread GitBox
blueorangutan commented on PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396836732 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7112: Make display elements optional

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396836283 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6809: Reserve memory for host

2023-01-19 Thread GitBox
weizhouapache commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081135154 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -990,7 +992,16 @@ public boolean

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6809: Reserve memory for host

2023-01-19 Thread GitBox
weizhouapache commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081135154 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -990,7 +992,16 @@ public boolean

[GitHub] [cloudstack] blueorangutan commented on pull request #7104: CKS: remove details when delete a cks cluster

2023-01-19 Thread GitBox
blueorangutan commented on PR #7104: URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396829993 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5327 -- This is an

[GitHub] [cloudstack] weizhouapache commented on pull request #6809: Reserve memory for host

2023-01-19 Thread GitBox
weizhouapache commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1396829906 > @wido That in my view > > > Overall it is looking good. > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6809: Reserve memory for host

2023-01-19 Thread GitBox
weizhouapache commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081127968 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -990,7 +992,16 @@ public boolean

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6809: Reserve memory for host

2023-01-19 Thread GitBox
weizhouapache commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081127968 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -990,7 +992,16 @@ public boolean

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396821169 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5326 -- This is an

[GitHub] [cloudstack] rohityadavcloud closed issue #7110: Latest main can't create networks

2023-01-19 Thread GitBox
rohityadavcloud closed issue #7110: Latest main can't create networks URL: https://github.com/apache/cloudstack/issues/7110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rohityadavcloud commented on issue #7110: Latest main can't create networks

2023-01-19 Thread GitBox
rohityadavcloud commented on issue #7110: URL: https://github.com/apache/cloudstack/issues/7110#issuecomment-1396817333 Can't reproduce with latest main, closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396813896 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396809891 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5325 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396799969 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5324 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy

2023-01-19 Thread GitBox
blueorangutan commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396786476 Trillian test result (tid-5900) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43178 seconds Marvin logs:

[GitHub] [cloudstack] soreana commented on pull request #6809: Reserve memory for host

2023-01-19 Thread GitBox
soreana commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1396762393 @wido That in my view > Overall it is looking good. > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or example. Do

[GitHub] [cloudstack] blueorangutan commented on pull request #7104: CKS: remove details when delete a cks cluster

2023-01-19 Thread GitBox
blueorangutan commented on PR #7104: URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396761093 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7104: CKS: remove details when delete a cks cluster

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7104: URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396759920 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
weizhouapache commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396759510 > LGTM @DaanHoogland would we need to do that with every release? if we will do another 4.17 minor release (4.17.3.0), we need to fix in 4.17 as well. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396757072 LGTM @DaanHoogland would we need to do that with every release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396744169 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
weizhouapache commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396743437 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP

2023-01-19 Thread GitBox
blueorangutan commented on PR #7103: URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1396742968 @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396743024 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with` is not the last line of your comment (e.g. blank/empty line after that).

[GitHub] [cloudstack] weizhouapache commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
weizhouapache commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396742721 @rohityadavcloud systemvm templates are not bundled if `@blueorangutan package` is not the last line of your comment (e.g. blank/empty line after that). @blueorangutan

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7103: URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1396741980 LGTM, didn't test it. @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396740681 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: debian. SL-JID 5323 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] weizhouapache commented on pull request #7111: marvin: install mysql-connector-python version 8.0.20

2023-01-19 Thread GitBox
weizhouapache commented on PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1396739920 looks good. ``` [root@pr7111-t5901-kvm-centos7-marvin ~]# pip3 list |grep mysql mysql-connector-python 8.0.20 [root@pr7111-t5901-kvm-centos7-marvin ~]# pip list |grep

[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396736932 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server

2023-01-19 Thread GitBox
rohityadavcloud commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396735680 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7112: Make display elements optional

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396735586 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] codecov[bot] commented on pull request #7112: Make display elements optional

2023-01-19 Thread GitBox
codecov[bot] commented on PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396732596 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7112?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] weizhouapache commented on pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-19 Thread GitBox
weizhouapache commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1396712676 > Tested, fixes the issue good thanks @davidjumani for testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] weizhouapache closed pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-19 Thread GitBox
weizhouapache closed pull request #7100: api/server: add project id/name in ssh keypair response URL: https://github.com/apache/cloudstack/pull/7100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7112: Make display elements optional

2023-01-19 Thread GitBox
blueorangutan commented on PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396695014 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-33) -- This is an automated message from the Apache Git Service. To respond

  1   2   >