[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1359251776 > @DaanHoogland @GutoVeronezi I couldn't finish my review yet but it looks good so far! I would like to double check the agent.properties refactor so we don't miss any existing

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-12-19 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1357383938 @GutoVeronezi @JoaoJandre @nvazquez are we alright with this now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-12-16 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1354707479 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-12-16 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1354706981 thanks for the explanation @GutoVeronezi! @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-15 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1315502195 ``` Tue 15 Nov 2022 08:15:53 AM UTC Starting guest services for kvm Tue 15 Nov 2022 08:15:54 AM UTC acpiphp and pci_hotplug module already compiled in Tue 15 Nov 2022

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-14 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1314923689 > Although the script problem, the main situation is that the secondary storage is not being mounted in the SSVM. Would it be possible for you to share the SSVM logs? This way we

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-10 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1310020312 @GutoVeronezi the ssvm still won't come up with this message: ![image](https://user-images.githubusercontent.com/2486961/201054698-ebe706ce-6d50-415a-bc6a-737b526b56d0.png)

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-10 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1309964102 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-09 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1309107884 Sorry @GutoVeronezi conflicts again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-07 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1305342641 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-07 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1305285795 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-04 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1303610480 @GutoVeronezi , with this pr I see consisten failures to stat the ssvm. It tries to mount the nfs server with address 255.255.240.0 (not really usefull as address) I haven´t

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-03 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1302280431 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-02 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1300409353 @GutoVeronezi the builds fail with ``` [ERROR]

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-11-02 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1299786163 Looks generally good @GutoVeronezi , I will retest the latest version. @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-09-27 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1259436250 @paulazomig can you look at the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-09-01 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1233884808 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-08-31 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1232564605 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-08-15 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1215078863 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-08-15 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1214840888 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-07-05 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1174783149 > SonarCloud Quality Gate failed.[![Quality Gate

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-06-27 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1167375540 > SonarCloud Quality Gate failed.[![Quality Gate

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-05-16 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1127359235 @paulazomig youĺl need to solve a conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL