[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1221160969 ## test/integration/smoke/test_kubernetes_clusters.py: ## @@ -622,11 +704,10 @@ def createKubernetesCluster(self, name, version_id, size=1, control_nodes=1):

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1218936584 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/RemoveVirtualMachinesFromKubernetesClusterCmd.java:

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1218934298 ## test/integration/smoke/test_kubernetes_clusters.py: ## @@ -610,7 +615,84 @@ def test_10_vpc_tier_kubernetes_cluster(self): k8s_cluster = None

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1218932926 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -607,8 +622,58 @@ private void

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1217825410 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1342,6 +1507,71 @@ public boolean

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1217750718 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1342,6 +1507,71 @@ public boolean

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1213611667 ## ui/src/config/section/compute.js: ## @@ -458,10 +458,10 @@ export default { return fields }, filters: () => { -const filters =

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205416033 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -783,15 +843,16 @@ public void

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205408466 ## engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql: ## @@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS UPDATE

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205058477 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/StartKubernetesClusterCmd.java: ## @@ -99,6

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1203554020 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/StartKubernetesClusterCmd.java: ## @@ -99,6

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1202176251 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/StartKubernetesClusterCmd.java: ## @@ -99,6

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191907394 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/AddVmsToKubernetesClusterCmd.java: ## @@ -0,0

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191723460 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -600,8 +609,66 @@ private void