[GitHub] [cloudstack] weizhouapache commented on pull request #7063: server: do not deploy or upgrade vm with inactive service offering

weizhouapache commented on PR #7063: URL: https://github.com/apache/cloudstack/pull/7063#issuecomment-1414320588 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] weizhouapache commented on pull request #7063: server: do not deploy or upgrade vm with inactive service offering

weizhouapache commented on PR #7063: URL: https://github.com/apache/cloudstack/pull/7063#issuecomment-1413327161 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] weizhouapache commented on pull request #7063: server: do not deploy or upgrade vm with inactive service offering

weizhouapache commented on PR #7063: URL: https://github.com/apache/cloudstack/pull/7063#issuecomment-1413282065 > Is this bugfix good for 4.18 cc @weizhouapache @DaanHoogland ? @blueorangutan package @rohityadavcloud cc @DaanHoogland yes but it has low priority -- This is an

[GitHub] [cloudstack] weizhouapache commented on pull request #7063: server: do not deploy or upgrade vm with inactive service offering

weizhouapache commented on PR #7063: URL: https://github.com/apache/cloudstack/pull/7063#issuecomment-1375625207 > Hi @weizhouapache, can you extract the inactive check to a method and reuse it in both scenarios to avoid code duplication? @stephankruggg suggested changes are