[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332750768 @rhtyd: I already did? I added a if-statement around the check in case libvirt doesn't return anything. Which is highly unlikely

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332746879 I personally think we can merge it. But hey, it's my PR, I can't make that decision.

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-22 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-331414999 Understood! It was my only explanation I could give for this error. Right now I don't know anything else.

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-21 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-331139737 Is virtio-scsi supported in CentOS 6 by libvirt? I doubt it. This

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-18 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-330206218 @rhtyd: I did and it seems a different thing: ==

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329461735 Ok, thanks! I added the label so that it can be merged. This is

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329418016 Thanks @rhtyd I addressed @GaborApatiNagy his comment, the XML parser now skips the entry if the model is null or empty. We