[GitHub] rhtyd commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762

2017-12-20 Thread GitBox
rhtyd commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762 URL: https://github.com/apache/cloudstack/pull/2370#discussion_r157983244 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -936,8 +942,8 @@

[GitHub] rafaelweingartner commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762

2017-12-20 Thread GitBox
rafaelweingartner commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762 URL: https://github.com/apache/cloudstack/pull/2370#discussion_r157983028 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -936,8

[GitHub] blueorangutan commented on issue #2370: CLOUDSTACK-9595: Fix regression introduced in #1762

2017-12-20 Thread GitBox
blueorangutan commented on issue #2370: CLOUDSTACK-9595: Fix regression introduced in #1762 URL: https://github.com/apache/cloudstack/pull/2370#issuecomment-353021534 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd opened a new pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762

2017-12-20 Thread GitBox
rhtyd opened a new pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762 URL: https://github.com/apache/cloudstack/pull/2370 The `assignDedicateIpAddress` previously had marked the newly fetched IP as allocated but now it does not do that. This fails for VPCs where

[GitHub] rhtyd commented on a change in pull request #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?

2017-12-20 Thread GitBox
rhtyd commented on a change in pull request #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#discussion_r157976364 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@

[GitHub] rhtyd commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?

2017-12-20 Thread GitBox
rhtyd commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-353012327 @yvsubhash given this has introduced a regressions in snat IP allocation I'm consider this for a revert unless

[GitHub] blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-12-20 Thread GitBox
blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-353011065 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-353010895 @blueorangutan test centos7 kvm-centos7 component/test_*.py This is

[GitHub] blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-12-20 Thread GitBox
blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-353009956 Packaging result: ?centos6 ?centos7 ?debian. JID-1435 This is an

[GitHub] rhtyd commented on a change in pull request #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?

2017-12-20 Thread GitBox
rhtyd commented on a change in pull request #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#discussion_r157970919 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@

[GitHub] blueorangutan commented on issue #2367: Fix ACL_INBOUND/OUTBOUND rules for PrivateGateway

2017-12-20 Thread GitBox
blueorangutan commented on issue #2367: Fix ACL_INBOUND/OUTBOUND rules for PrivateGateway URL: https://github.com/apache/cloudstack/pull/2367#issuecomment-353008201 Packaging result: ?centos6 ?centos7 ?debian. JID-1434 This

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-12-20 Thread GitBox
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-353006797 Packaging result: ?centos6 ?centos7 ?debian. JID-1433

[GitHub] borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration support

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2259: CLOUDSTACK-10024: Network migration support URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353005252 @krissterckx sure I can kick the marvin tests, have you managed to add the default network provider tests?

[GitHub] krissterckx commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support

2017-12-20 Thread GitBox
krissterckx commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353004576 Hi @rhtyd i see you removed 4.11 label from the PR. See discussion thread with @wido. At Nuage we see lots of

[GitHub] blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-12-20 Thread GitBox
blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-353004045 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-353003839 @blueorangutan package This is an automated message from the Apache

[GitHub] krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration support

2017-12-20 Thread GitBox
krissterckx commented on issue #2259: CLOUDSTACK-10024: Network migration support URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-353003052 @borisstoyanov this PR adds MigrateNetworkCmd.class and MigrateVPCCmd.class as new commands, which just causes git not to know in

[GitHub] blueorangutan commented on issue #2367: Fix ACL_INBOUND/OUTBOUND rules for PrivateGateway

2017-12-20 Thread GitBox
blueorangutan commented on issue #2367: Fix ACL_INBOUND/OUTBOUND rules for PrivateGateway URL: https://github.com/apache/cloudstack/pull/2367#issuecomment-353001946 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2367: Fix ACL_INBOUND/OUTBOUND rules for PrivateGateway

2017-12-20 Thread GitBox
rhtyd commented on issue #2367: Fix ACL_INBOUND/OUTBOUND rules for PrivateGateway URL: https://github.com/apache/cloudstack/pull/2367#issuecomment-353001860 This may cause regressions in other cases with the stated assumption, additional review is requested. I'll run some tests.

[GitHub] rhtyd commented on a change in pull request #2366: CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name

2017-12-20 Thread GitBox
rhtyd commented on a change in pull request #2366: CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name URL: https://github.com/apache/cloudstack/pull/2366#discussion_r157964380 ## File path: systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py ##

[GitHub] rhtyd commented on issue #2366: CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name

2017-12-20 Thread GitBox
rhtyd commented on issue #2366: CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name URL: https://github.com/apache/cloudstack/pull/2366#issuecomment-353000641 @blueorangutan test This is an automated

[GitHub] blueorangutan commented on issue #2366: CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name

2017-12-20 Thread GitBox
blueorangutan commented on issue #2366: CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name URL: https://github.com/apache/cloudstack/pull/2366#issuecomment-353000660 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data

2017-12-20 Thread GitBox
DaanHoogland commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-35326 Yes @rhtyd I will rebase one last time.

[GitHub] blueorangutan commented on issue #2117: CLOUDSTACK-8735:Browser Based Volume and Template Upload Test Automat?

2017-12-20 Thread GitBox
blueorangutan commented on issue #2117: CLOUDSTACK-8735:Browser Based Volume and Template Upload Test Automat? URL: https://github.com/apache/cloudstack/pull/2117#issuecomment-35329 Packaging result: ?centos6 ?centos7 ?debian. JID-1432

[GitHub] borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-352999756 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-12-20 Thread GitBox
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-352999798 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland closed pull request #2363: 4.8.0.1 rc20160525 t1247

2017-12-20 Thread GitBox
DaanHoogland closed pull request #2363: 4.8.0.1 rc20160525 t1247 URL: https://github.com/apache/cloudstack/pull/2363 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] DaanHoogland commented on issue #2363: 4.8.0.1 rc20160525 t1247

2017-12-20 Thread GitBox
DaanHoogland commented on issue #2363: 4.8.0.1 rc20160525 t1247 URL: https://github.com/apache/cloudstack/pull/2363#issuecomment-352999702 not a vaild pr This is an automated message from the Apache Git Service. To respond to

[GitHub] borisstoyanov commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-352999454 @nvazquez it appears this one has conflicts, can you please resolve them and I'll run tests on it.

[cloudstack] branch master updated: CLOUDSTACK-9880: Expansion of Management IP Range. (#2048)

2017-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 8acb090 CLOUDSTACK-9880: Expansion of

[GitHub] DaanHoogland closed pull request #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-12-20 Thread GitBox
DaanHoogland closed pull request #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] DaanHoogland closed pull request #2299: WIP: CLOUDSTACK-10118 Domain level settings

2017-12-20 Thread GitBox
DaanHoogland closed pull request #2299: WIP: CLOUDSTACK-10118 Domain level settings URL: https://github.com/apache/cloudstack/pull/2299 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] DaanHoogland commented on issue #2299: WIP: CLOUDSTACK-10118 Domain level settings

2017-12-20 Thread GitBox
DaanHoogland commented on issue #2299: WIP: CLOUDSTACK-10118 Domain level settings URL: https://github.com/apache/cloudstack/pull/2299#issuecomment-352998391 closing in favour of #2369 This is an automated message from the

[GitHub] DaanHoogland opened a new pull request #2369: CLOUDSTACK-10117 Domain level ldap configuration

2017-12-20 Thread GitBox
DaanHoogland opened a new pull request #2369: CLOUDSTACK-10117 Domain level ldap configuration URL: https://github.com/apache/cloudstack/pull/2369 This contains fixes and implementation of CLOUDSTACK-10117 and CLOUDSTACK-10118, enabling the operator to configure an ldap server per domain.

[GitHub] borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-352997966 I think this looks good now, the failures are not related

[GitHub] blueorangutan commented on issue #2117: CLOUDSTACK-8735:Browser Based Volume and Template Upload Test Automat?

2017-12-20 Thread GitBox
blueorangutan commented on issue #2117: CLOUDSTACK-8735:Browser Based Volume and Template Upload Test Automat? URL: https://github.com/apache/cloudstack/pull/2117#issuecomment-352994952 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] borisstoyanov commented on issue #2117: CLOUDSTACK-8735:Browser Based Volume and Template Upload Test Automat?

2017-12-20 Thread GitBox
borisstoyanov commented on issue #2117: CLOUDSTACK-8735:Browser Based Volume and Template Upload Test Automat? URL: https://github.com/apache/cloudstack/pull/2117#issuecomment-352994807 @blueorangutan package This is an

<    1   2   3