[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472238769 Trillian test result (tid-3419) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time t

[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472114945 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472114567 @GabrielBrascher okay I'll move that to logging tomorrow. @blueorangutan test -

[GitHub] [cloudstack] GabrielBrascher closed pull request #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
GabrielBrascher closed pull request #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack] GabrielBrascher commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-472093475 Closing this in favor of #3210 This is an automated message from

[GitHub] [cloudstack] onitake opened a new issue #3221: Proposal: Specify INVOKER security on table views to avoid DB user dependency

2019-03-12 Thread GitBox
onitake opened a new issue #3221: Proposal: Specify INVOKER security on table views to avoid DB user dependency URL: https://github.com/apache/cloudstack/issues/3221 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ DB ~~~ # CLOUD

[GitHub] [cloudstack] blueorangutan commented on issue #3209: server: make snapshotting on KVM non-blocking

2019-03-12 Thread GitBox
blueorangutan commented on issue #3209: server: make snapshotting on KVM non-blocking URL: https://github.com/apache/cloudstack/pull/3209#issuecomment-472017557 Trillian test result (tid-3417) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 2437

[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-472008746 Trillian test result (tid-3418) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time t

[GitHub] [cloudstack] blueorangutan commented on issue #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
blueorangutan commented on issue #3220: ui: allow user template sharing through UI URL: https://github.com/apache/cloudstack/pull/3220#issuecomment-472000124 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2629 This is an au

[GitHub] [cloudstack] blueorangutan commented on issue #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
blueorangutan commented on issue #3220: ui: allow user template sharing through UI URL: https://github.com/apache/cloudstack/pull/3220#issuecomment-471992436 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] dhlaluku commented on issue #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
dhlaluku commented on issue #3220: ui: allow user template sharing through UI URL: https://github.com/apache/cloudstack/pull/3220#issuecomment-471992282 @blueorangutan package This is an automated message from the Apache Git S

[GitHub] [cloudstack] dhlaluku opened a new pull request #3220: ui: allow user template sharing through UI

2019-03-12 Thread GitBox
dhlaluku opened a new pull request #3220: ui: allow user template sharing through UI URL: https://github.com/apache/cloudstack/pull/3220 updateTemplate permissions API ## Description UI integration of the updateTemplatePermissions API. This will allow users to share templates

[GitHub] [cloudstack] rafaelweingartner commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
rafaelweingartner commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471986861 @DaanHoogland I selected the wrong label. Thanks Daan. This is an automate

[GitHub] [cloudstack] DaanHoogland commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
DaanHoogland commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471986489 @NicoWohlfarth Can you explain what these pictures are making clear? not all of them are selfevident. @rafaelweingartner aren't these bugfixe

[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher edited a comment on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471977036 @rhtyd it looks good. Thanks! Can you please also remove the lines that are silencing the exception? I

[GitHub] [cloudstack] GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471977036 @rhtyd it looks good. Thanks! Can you please also remove the lines that are silencing the exception? https:

[GitHub] [cloudstack] andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471973804 Cool - let's LGTM this one and close if you are OK with it @GabrielBrascher ? --

[GitHub] [cloudstack] GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471973377 @rhtyd @andrijapanic nevermind, my mistake when updating the script at this time. Due to the /bin/sh -ec '' it works

[GitHub] [cloudstack] andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471972723 yes, Centos7 let me build Ubuntu lab - 18.04 sounds fine ?

[GitHub] [cloudstack] GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
GabrielBrascher commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471972171 @rhtyd @andrijapanic are you testing it with CentOS? On Ubuntu I still get error. Now the exception is: `java.lang.Nu

[GitHub] [cloudstack] andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471961003 LGTM Tested and the job does kick in as expected. -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
andrijapanicsb commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-471960744 I did not review this one (test it), but already had env for https://github.com/apache/cloudstack/pull/3210 and confirm it works fi

[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471950676 https://user-images.githubusercontent.com/5433844/54194494-ae47eb00-44bc-11e9-9e9b-3d96ed082a7d.png";> ![fix4](https://user-images.githubuse

[GitHub] [cloudstack] rhtyd commented on issue #3211: ui: remove CA certificate button from UI

2019-03-12 Thread GitBox
rhtyd commented on issue #3211: ui: remove CA certificate button from UI URL: https://github.com/apache/cloudstack/pull/3211#issuecomment-471949805 @svenvogel in 4.11+ if you notice there is a button on right/top side that downloads the CA certificate. This is not used at all and confuses

[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471949268 https://user-images.githubusercontent.com/5433844/54194297-2e218580-44bc-11e9-8f65-3bf176459d6c.png";> ![fix3](https://user-images.githubuse

[GitHub] [cloudstack] svenvogel edited a comment on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel edited a comment on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471948361 this pr fixes the following problems. https://user-images.githubusercontent.com/5433844/54194040-a0459a80-44bb-11e9-9b24-aeb89541a6b6.

[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471948361 this pr fixes the following problems. https://user-images.githubusercontent.com/5433844/54194040-a0459a80-44bb-11e9-9b24-aeb89541a6b6.png";>

[GitHub] [cloudstack] svenvogel commented on issue #3211: ui: remove CA certificate button from UI

2019-03-12 Thread GitBox
svenvogel commented on issue #3211: ui: remove CA certificate button from UI URL: https://github.com/apache/cloudstack/pull/3211#issuecomment-471947467 @rhtyd what was the use case before? This is an automated message from the

[GitHub] [cloudstack] rhtyd opened a new pull request #3219: server: publish volume resize event for volumes

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3219: server: publish volume resize event for volumes URL: https://github.com/apache/cloudstack/pull/3219 This fixes the issue that the disk offering change is not reflected in the cloud_usage table. Moves the method that published events for volum

[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-03-12 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-471945164 @wido @GabrielBrascher @borisstoyanov @rhtyd @rafaelweingartner can anybody add a ui symbol and review it? ---

[GitHub] [cloudstack] rhtyd opened a new pull request #3218: vmware: don't use redundant worker VM to extract volume

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218 This fixes the issue that VM with VMsnapshots fails to start after extract volume is done on a stopped VM, on VMware. ## Types of chan

[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for NIC

2019-03-12 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-471943632 @wido can you check again? @rhtyd @borisstoyanov @rafaelweingartner can you check this? -

[GitHub] [cloudstack] svenvogel commented on issue #3198: Set service offering unique name over api and gui

2019-03-12 Thread GitBox
svenvogel commented on issue #3198: Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-471943215 @rhtyd @GabrielBrascher @rafaelweingartner @borisroman can you add a ui icon and check these? --

[GitHub] [cloudstack] rhtyd opened a new pull request #3217: ui: introduce new UI config file

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3217: ui: introduce new UI config file URL: https://github.com/apache/cloudstack/pull/3217 This introduces a new UI `config.js` file using which the UI could be configured by the admin from a single config/js file. In the first commit this allows fo

[GitHub] [cloudstack] rhtyd opened a new pull request #3216: api: include tags in listvmsnapshots response

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3216: api: include tags in listvmsnapshots response URL: https://github.com/apache/cloudstack/pull/3216 This ensures that tags of a VM snapshot are listed in the UI, available in the list vmsnapshots API response. ## Types of changes - [ ] B

[GitHub] [cloudstack] rhtyd opened a new pull request #3215: storage: post process locally uploaded multi-disk ova template

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3215: storage: post process locally uploaded multi-disk ova template URL: https://github.com/apache/cloudstack/pull/3215 This processes and handles multi-disk ova templates, checks and creates data disk templates on image storage pool and in DB. Te

[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471933312 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2628

[GitHub] [cloudstack] rhtyd opened a new pull request #3214: ui: use executable template filter for users

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3214: ui: use executable template filter for users URL: https://github.com/apache/cloudstack/pull/3214 This uses the `executable` tempalte filter for fetching templates in reinstall VM form, otherwise not all allowable templates were being listed.

[GitHub] [cloudstack] rhtyd opened a new pull request #3213: server: allow admins to blacklist vm details that users should not see

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3213: server: allow admins to blacklist vm details that users should not see URL: https://github.com/apache/cloudstack/pull/3213 This introduces a new global setting `user.vm.blacklisted.details` that allows admins to blacklist VM details that non-admin u

[GitHub] [cloudstack] blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
blueorangutan commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471925386 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471925187 @blueorangutan package This is an automated message from the A

[GitHub] [cloudstack] rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471920817 @GabrielBrascher fixed the issue, it was systemd variable referencing/syntax issue which per following docs should be `${VAR}`

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3210: systemd: Fix -Dpid arg passing to systemd usage service

2019-03-12 Thread GitBox
rhtyd commented on a change in pull request #3210: systemd: Fix -Dpid arg passing to systemd usage service URL: https://github.com/apache/cloudstack/pull/3210#discussion_r264584537 ## File path: packaging/systemd/cloudstack-usage.service ## @@ -24,7 +24,8 @@ After=network.

[GitHub] [cloudstack] blueorangutan commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12

2019-03-12 Thread GitBox
blueorangutan commented on issue #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#issuecomment-471903860 Trillian test result (tid-3416) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28344 s

[GitHub] [cloudstack] rhtyd opened a new pull request #3212: storage: publish delete usage event for snapshot deletion

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3212: storage: publish delete usage event for snapshot deletion URL: https://github.com/apache/cloudstack/pull/3212 This publishes VM snapshot delete event after a snapshot is removed, this will ensure that usage records are not generated for deleted s

[GitHub] [cloudstack] rhtyd opened a new pull request #3211: ui: remove CA certificate button from UI

2019-03-12 Thread GitBox
rhtyd opened a new pull request #3211: ui: remove CA certificate button from UI URL: https://github.com/apache/cloudstack/pull/3211 This removes CA certificate button from UI as this is not used and confuses both admin and users how to use it. This may be re-introduced in future when a