[GitHub] [cloudstack] anuragaw removed a comment on issue #3295: listPublicIPAddresses return not filtered for current network

[GitBox]

anuragaw removed a comment on issue #3295: listPublicIPAddresses return not 
filtered for current network
URL: https://github.com/apache/cloudstack/issues/3295#issuecomment-496844753
 
 
   Working on this


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel removed a comment on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel removed a comment on issue #3346: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-496723084
 
 
   @DennisKonrad @ustcweizhou @syed ready to merge now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] PaulAngus opened a new issue #3369: MTU for storage interface on SSVM is not honored

[GitBox]

PaulAngus opened a new issue #3369: MTU for storage interface on SSVM is not 
honored
URL: https://github.com/apache/cloudstack/issues/3369
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   SSVM
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11.2
   ~~~
   
   # CONFIGURATION
   
   NA
   
   # OS / ENVIRONMENT
   
   
   NA
   
   # SUMMARY
   
   
   The global setting  **secstorage.vm.mtu.size**  does not get applied to the 
SSVM
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Set the global setting  **secstorage.vm.mtu.size** to a jumbo frames value 
ie 4500 or 9000, then destroy the existing SSVM(s),
   
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   New SSVM should have the new MTU allied to the storage interface
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   No change in the MTU of the SSVM.
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates

[GitBox]

rhtyd commented on issue #3075: WIP: Prevent regenerating keystore and add 
background task to upload certificates
URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498214559
 
 
   ping @nvazquez is it ready yet?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: srx: Fix removing static NAT rules with Juniper SRX (#3310)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 2484527  srx: Fix removing static NAT rules with Juniper SRX (#3310)
2484527 is described below

commit 2484527cae9e810203eea8850d493737fa2336a4
Author: Richard Lawley 
AuthorDate: Mon Jun 3 12:21:23 2019 +0100

srx: Fix removing static NAT rules with Juniper SRX (#3310)

Fixed the logic for deleting static NAT rules on a Juniper SRX device. 
Previously the private (trust) rule was not being removed.

Fixes #3309
---
 .../src/com/cloud/network/resource/JuniperSrxResource.java   | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
 
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
index 20031e3..8ada819 100644
--- 
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
+++ 
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
@@ -2078,11 +2078,11 @@ public class JuniperSrxResource implements 
ServerResource {
 xml = replaceXmlValue(xml, "rule-set", _privateZone);
 xml = replaceXmlValue(xml, "from-zone", _privateZone);
 xml = replaceXmlValue(xml, "rule-name", 
ruleName_private);
-}
 
-if (!sendRequestAndCheckResponse(command, xml, "name", 
ruleName_private))
-{
-throw new ExecutionException("Failed to delete trust 
static NAT rule from public IP " + publicIp + " to private IP " + privateIp);
+if (!sendRequestAndCheckResponse(command, xml, "name", 
ruleName_private))
+{
+throw new ExecutionException("Failed to delete 
trust static NAT rule from public IP " + publicIp + " to private IP " + 
privateIp);
+}
 }
 return true;
 }
@@ -3568,6 +3568,7 @@ public class JuniperSrxResource implements ServerResource 
{
 
 case CHECK_IF_EXISTS:
 case CHECK_IF_IN_USE:
+case CHECK_PRIVATE_IF_EXISTS:
 assert (keyAndValue != null && keyAndValue.length == 2) : "If 
the SrxCommand is " + command + ", both a key and value must be specified.";
 
 key = keyAndValue[0];

[GitHub] [cloudstack] rhtyd merged pull request #3310: Fix removing static NAT rules with Juniper SRX

[GitBox]

rhtyd merged pull request #3310: Fix removing static NAT rules with Juniper SRX
URL: https://github.com/apache/cloudstack/pull/3310
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command

[GitBox]

DaanHoogland commented on issue #3297: [WIP DO NOT MERGE] Support copy tags 
from template/iso image to VM from deploy vm command
URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-498219734
 
 
   @anuragaw travis shows a failure in  test_15_project_tag. Can you take a 
look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates

[GitBox]

nvazquez commented on issue #3075: WIP: Prevent regenerating keystore and add 
background task to upload certificates
URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498224009
 
 
   @rhtyd yes but it needs to rebase #2995 and address the few comments above


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.12 updated (fb555b1 -> b2b99ca)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.12
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from fb555b1  Merge remote-tracking branch 'origin/4.11' into 4.12
 add 2484527  srx: Fix removing static NAT rules with Juniper SRX (#3310)
 add c9ce3e2  router: Persistent DHCP leases file on VRs and cleanup 
/etc/hosts on VM deletion (#3351)
 new b2b99ca  Merge remote-tracking branch 'origin/4.11' into 4.12

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/network/element/DhcpServiceProvider.java |  2 ++
 .../cloud/agent/api/routing/DhcpEntryCommand.java  |  9 ++
 .../virtualnetwork/facade/DhcpEntryConfigItem.java |  2 +-
 .../virtualnetwork/model/VmDhcpConfig.java | 14 -
 .../service/NetworkOrchestrationService.java   |  4 +++
 .../engine/orchestration/NetworkOrchestrator.java  | 28 +
 .../networkservice/BaremetalDhcpElement.java   |  5 
 .../contrail/management/ContrailElementImpl.java   |  5 
 .../cloud/network/resource/JuniperSrxResource.java |  9 +++---
 .../com/cloud/network/element/NuageVspElement.java |  5 
 .../network/element/VirtualRouterElement.java  | 28 +
 .../cloud/network/router/CommandSetupHelper.java   |  5 ++--
 .../com/cloud/network/rules/DhcpEntryRules.java| 10 +++
 .../main/java/com/cloud/vm/UserVmManagerImpl.java  | 14 ++---
 .../network/topology/AdvancedNetworkTopology.java  | 15 ++
 .../network/topology/AdvancedNetworkVisitor.java   |  3 +-
 .../network/topology/BasicNetworkTopology.java | 21 +
 .../network/topology/BasicNetworkVisitor.java  |  3 +-
 .../network/topology/NetworkTopology.java  |  2 ++
 .../java/com/cloud/vpc/MockNetworkManagerImpl.java |  4 +++
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py | 35 ++
 systemvm/debian/opt/cloud/bin/cs_dhcp.py   |  4 +++
 22 files changed, 208 insertions(+), 19 deletions(-)

[GitHub] [cloudstack] rhtyd commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498228298
 
 
   @svenvogel @DennisKonrad sorry guys, the change fails environment deployment 
across KVM, VMware and XenServer so I had to revert the commit on master to 
unblock other PRs from testing. Kindly re-submit the change in a PR and ping 
me, I'll help review and test it. Thanks. cc @PaulAngus @borisstoyanov 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (1c5244a -> cd6e846)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 1c5244a  Merge remote-tracking branch 'origin/4.12'
 add cd6e846  Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"

No new revisions were added by this update.

Summary of changes:
 scripts/storage/secondary/cloud-install-sys-tmplt | 298 +++---
 scripts/storage/secondary/createtmplt.sh  | 184 +++--
 2 files changed, 264 insertions(+), 218 deletions(-)

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3367: [WIP DO NOT MERGE] ui: added missing hypervisor options for upload template

[GitBox]

DaanHoogland commented on a change in pull request #3367: [WIP DO NOT MERGE] 
ui: added missing hypervisor options for upload template
URL: https://github.com/apache/cloudstack/pull/3367#discussion_r289812342
 
 

 ##
 File path: ui/scripts/templates.js
 ##
 @@ -311,6 +311,7 @@
 },
 // Direct Download - End
 
+//XenServer only (starts here)
 
 Review comment:
   what do you mean 'XenServer *only*'?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3234: [WIP DO NOT MERGE] api: Set network name as part of the network usage response

[GitBox]

DaanHoogland commented on issue #3234: [WIP DO NOT MERGE] api: Set network name 
as part of the network usage response
URL: https://github.com/apache/cloudstack/pull/3234#issuecomment-498172268
 
 
   @rhtyd I think this is ready to merge (still tagged [WIP])


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3351: Have persistent DHCP leases file on VRs and cleanup /etc/hosts on VM deletion

[GitBox]

rhtyd commented on issue #3351: Have persistent DHCP leases file on VRs and 
cleanup /etc/hosts on VM deletion
URL: https://github.com/apache/cloudstack/pull/3351#issuecomment-498212860
 
 
   Let's do #3273 in a separate PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3240: [WIP DO NOT MERGE] api: instance and template details are free text

[GitBox]

DaanHoogland commented on a change in pull request #3240: [WIP DO NOT MERGE] 
api: instance and template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#discussion_r289804069
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -3399,6 +3407,50 @@ else if (!template.isPublicTemplate() && 
caller.getType() != Account.ACCOUNT_TYP
 hypervisorType, true, cmd.listInReadyState(), 
permittedAccounts, caller, listProjectResourcesCriteria, tags, showRemovedISO, 
null, null);
 }
 
+@Override
+public DetailOptionsResponse listDetailOptions(final ListDetailOptionsCmd 
cmd) {
+final ResourceObjectType type = cmd.getResourceType();
+final String resourceUuid = cmd.getResourceId();
+final Map> options = new HashMap<>();
+switch (type) {
+case Template:
+case UserVm:
+HypervisorType hypervisorType = HypervisorType.None;
+if (!Strings.isNullOrEmpty(resourceUuid) && 
ResourceObjectType.Template.equals(type)) {
+hypervisorType = 
_templateDao.findByUuid(resourceUuid).getHypervisorType();
+}
+if (!Strings.isNullOrEmpty(resourceUuid) && 
ResourceObjectType.UserVm.equals(type)) {
+hypervisorType = 
_vmInstanceDao.findByUuid(resourceUuid).getHypervisorType();
+}
+fillVMOrTemplateDetailOptions(options, hypervisorType);
+break;
+default:
+throw new CloudRuntimeException("Resource type not 
supported.");
+}
+return new DetailOptionsResponse(options);
+}
+
+private void fillVMOrTemplateDetailOptions(final Map> 
options, final HypervisorType hypervisorType) {
+if (options == null) {
+throw new CloudRuntimeException("Invalid/null detail-options 
response object passed");
+}
+
+options.put(VmDetailConstants.KEYBOARD, Arrays.asList("uk", "us", 
"jp", "fr"));
 
 Review comment:
   I don't think we should maintain the possible values in the queryService. 
Rather ask them from the VO?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3240: [WIP DO NOT MERGE] api: instance and template details are free text

[GitBox]

DaanHoogland commented on a change in pull request #3240: [WIP DO NOT MERGE] 
api: instance and template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#discussion_r289803515
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -3399,6 +3407,50 @@ else if (!template.isPublicTemplate() && 
caller.getType() != Account.ACCOUNT_TYP
 hypervisorType, true, cmd.listInReadyState(), 
permittedAccounts, caller, listProjectResourcesCriteria, tags, showRemovedISO, 
null, null);
 }
 
+@Override
+public DetailOptionsResponse listDetailOptions(final ListDetailOptionsCmd 
cmd) {
+final ResourceObjectType type = cmd.getResourceType();
+final String resourceUuid = cmd.getResourceId();
+final Map> options = new HashMap<>();
+switch (type) {
+case Template:
+case UserVm:
+HypervisorType hypervisorType = HypervisorType.None;
+if (!Strings.isNullOrEmpty(resourceUuid) && 
ResourceObjectType.Template.equals(type)) {
 
 Review comment:
   shouldn't resourceUuid be validated in the cmd already? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3295: listPublicIPAddresses return not filtered for current network

[GitBox]

rhtyd commented on issue #3295: listPublicIPAddresses return not filtered for 
current network
URL: https://github.com/apache/cloudstack/issues/3295#issuecomment-498142613
 
 
   Fixed in https://github.com/apache/cloudstack/pull/3368


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: server: fix for public IP addresses filtering (#3368)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 6c6f40f  server: fix for public IP addresses filtering (#3368)
6c6f40f is described below

commit 6c6f40fd4d9874fc098ae41fcffb2be4a99f830d
Author: Abhishek Kumar 
AuthorDate: Mon Jun 3 12:52:19 2019 +0530

server: fix for public IP addresses filtering (#3368)

Added missing parameter in listPublicIpAddresses API.

Signed-off-by: Abhishek Kumar 
---
 .../api/command/user/address/ListPublicIpAddressesCmd.java | 11 +++
 .../main/java/com/cloud/server/ManagementServerImpl.java   | 14 ++
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
index d590081..d25d167 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
@@ -86,6 +86,13 @@ public class ListPublicIpAddressesCmd extends 
BaseListTaggedResourcesCmd {
description = "lists all public IP addresses associated to the 
network specified")
 private Long associatedNetworkId;
 
+@Parameter(name = ApiConstants.NETWORK_ID,
+type = CommandType.UUID,
+entityType = NetworkResponse.class,
+description = "lists all public IP addresses by source network ID",
+since = "4.13.0")
+private Long networkId;
+
 @Parameter(name = ApiConstants.IS_SOURCE_NAT, type = CommandType.BOOLEAN, 
description = "list only source NAT IP addresses")
 private Boolean isSourceNat;
 
@@ -133,6 +140,10 @@ public class ListPublicIpAddressesCmd extends 
BaseListTaggedResourcesCmd {
 return associatedNetworkId;
 }
 
+public Long getNetworkId() {
+return networkId;
+}
+
 public Boolean isSourceNat() {
 return isSourceNat;
 }
diff --git a/server/src/main/java/com/cloud/server/ManagementServerImpl.java 
b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
index b211cab..af2c6c8 100644
--- a/server/src/main/java/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
@@ -37,7 +37,6 @@ import javax.crypto.spec.SecretKeySpec;
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
-import com.cloud.storage.ScopeType;
 import org.apache.cloudstack.acl.ControlledEntity;
 import org.apache.cloudstack.affinity.AffinityGroupProcessor;
 import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
@@ -217,10 +216,10 @@ import 
org.apache.cloudstack.api.command.admin.usage.AddTrafficTypeCmd;
 import org.apache.cloudstack.api.command.admin.usage.DeleteTrafficMonitorCmd;
 import org.apache.cloudstack.api.command.admin.usage.DeleteTrafficTypeCmd;
 import org.apache.cloudstack.api.command.admin.usage.GenerateUsageRecordsCmd;
-import org.apache.cloudstack.api.command.admin.usage.ListUsageRecordsCmd;
 import org.apache.cloudstack.api.command.admin.usage.ListTrafficMonitorsCmd;
 import 
org.apache.cloudstack.api.command.admin.usage.ListTrafficTypeImplementorsCmd;
 import org.apache.cloudstack.api.command.admin.usage.ListTrafficTypesCmd;
+import org.apache.cloudstack.api.command.admin.usage.ListUsageRecordsCmd;
 import org.apache.cloudstack.api.command.admin.usage.ListUsageTypesCmd;
 import org.apache.cloudstack.api.command.admin.usage.RemoveRawUsageRecordsCmd;
 import org.apache.cloudstack.api.command.admin.usage.UpdateTrafficTypeCmd;
@@ -634,6 +633,7 @@ import com.cloud.storage.GuestOSHypervisor;
 import com.cloud.storage.GuestOSHypervisorVO;
 import com.cloud.storage.GuestOSVO;
 import com.cloud.storage.GuestOsCategory;
+import com.cloud.storage.ScopeType;
 import com.cloud.storage.StorageManager;
 import com.cloud.storage.StoragePool;
 import com.cloud.storage.Volume;
@@ -1848,6 +1848,7 @@ public class ManagementServerImpl extends ManagerBase 
implements ManagementServe
 final Object keyword = cmd.getKeyword();
 final Long physicalNetworkId = cmd.getPhysicalNetworkId();
 final Long associatedNetworkId = cmd.getAssociatedNetworkId();
+final Long sourceNetworkId = cmd.getNetworkId();
 final Long zone = cmd.getZoneId();
 final String address = cmd.getIpAddress();
 final Long vlan = cmd.getVlanId();
@@ -1893,7 +1894,8 @@ public class ManagementServerImpl extends ManagerBase 
implements ManagementServe
 sb.and("vlanDbId", sb.entity().getVlanId(), SearchCriteria.Op.EQ);
 sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
 sb.and("physicalNetworkId", 

[GitHub] [cloudstack] blueorangutan commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates

[GitBox]

blueorangutan commented on issue #3075: WIP: Prevent regenerating keystore and 
add background task to upload certificates
URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498143224
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498146887
 
 
   @DennisKonrad there are no smoketests on this PR to confirm that this PR 
will not add any regression(s). The merge guildelines are:
   - Two LGTMs from non-authors
   - Smoketests on against at least one hypervisor such a KVM, and across KVM, 
VMware, XenServer when changes are not hypervisor agnostic.
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: router: Persistent DHCP leases file on VRs and cleanup /etc/hosts on VM deletion (#3351)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new c9ce3e2  router: Persistent DHCP leases file on VRs and cleanup 
/etc/hosts on VM deletion (#3351)
c9ce3e2 is described below

commit c9ce3e2344ab863dae09e63bf783331097a660cb
Author: Nicolas Vazquez 
AuthorDate: Mon Jun 3 08:34:16 2019 -0300

router: Persistent DHCP leases file on VRs and cleanup /etc/hosts on VM 
deletion (#3351)

Since the CloudStack virtual router was redesigned on version 4.6 it has 
been observed that the DHCP leases file is not persistent across network 
operations. This causes conflicts on guest VMs static IPs, causing these static 
IPs to not be renewed by the DHCP server running on isolated and VPC networks' 
virtual routers (dnsmasq). On stopping or destroying a VM, its dhcp/dns records 
are not removed from the virtual router causing ghost effects.

Fixes #3272
Fixes #3354

Signed-off-by: Rohit Yadav 
---
 .../cloud/network/element/DhcpServiceProvider.java |  2 ++
 .../cloud/agent/api/routing/DhcpEntryCommand.java  |  9 ++
 .../agent/resource/virtualnetwork/VRScripts.java   |  1 -
 .../virtualnetwork/VirtualRoutingResource.java |  2 +-
 .../virtualnetwork/facade/DhcpEntryConfigItem.java |  2 +-
 .../virtualnetwork/model/VmDhcpConfig.java | 14 -
 .../service/NetworkOrchestrationService.java   |  4 +++
 .../engine/orchestration/NetworkOrchestrator.java  | 28 +
 .../networkservice/BaremetalDhcpElement.java   |  5 
 .../contrail/management/ContrailElementImpl.java   |  5 
 .../com/cloud/network/element/NuageVspElement.java |  5 
 .../network/element/VirtualRouterElement.java  | 28 +
 .../cloud/network/router/CommandSetupHelper.java   |  5 ++--
 .../com/cloud/network/rules/DhcpEntryRules.java| 10 +++
 server/src/com/cloud/vm/UserVmManagerImpl.java | 15 +++---
 .../network/topology/AdvancedNetworkTopology.java  | 15 ++
 .../network/topology/AdvancedNetworkVisitor.java   |  3 +-
 .../network/topology/BasicNetworkTopology.java | 21 +
 .../network/topology/BasicNetworkVisitor.java  |  3 +-
 .../network/topology/NetworkTopology.java  |  2 ++
 .../test/com/cloud/vpc/MockNetworkManagerImpl.java |  4 +++
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py | 35 ++
 systemvm/debian/opt/cloud/bin/cs_dhcp.py   |  4 +++
 23 files changed, 205 insertions(+), 17 deletions(-)

diff --git a/api/src/com/cloud/network/element/DhcpServiceProvider.java 
b/api/src/com/cloud/network/element/DhcpServiceProvider.java
index 12830f8..3f530c2 100644
--- a/api/src/com/cloud/network/element/DhcpServiceProvider.java
+++ b/api/src/com/cloud/network/element/DhcpServiceProvider.java
@@ -37,4 +37,6 @@ public interface DhcpServiceProvider extends NetworkElement {
 boolean removeDhcpSupportForSubnet(Network network) throws 
ResourceUnavailableException;
 
 boolean setExtraDhcpOptions(Network network, long nicId, Map dhcpOptions);
+
+boolean removeDhcpEntry(Network network, NicProfile nic, 
VirtualMachineProfile vmProfile) throws ResourceUnavailableException;
 }
diff --git a/core/src/com/cloud/agent/api/routing/DhcpEntryCommand.java 
b/core/src/com/cloud/agent/api/routing/DhcpEntryCommand.java
index b942806..7fb65fe 100644
--- a/core/src/com/cloud/agent/api/routing/DhcpEntryCommand.java
+++ b/core/src/com/cloud/agent/api/routing/DhcpEntryCommand.java
@@ -35,6 +35,15 @@ public class DhcpEntryCommand extends NetworkElementCommand {
 String duid;
 private boolean isDefault;
 boolean executeInSequence = false;
+boolean remove;
+
+public boolean isRemove() {
+return remove;
+}
+
+public void setRemove(boolean remove) {
+this.remove = remove;
+}
 
 protected DhcpEntryCommand() {
 
diff --git a/core/src/com/cloud/agent/resource/virtualnetwork/VRScripts.java 
b/core/src/com/cloud/agent/resource/virtualnetwork/VRScripts.java
index 838f087..bd108a9 100644
--- a/core/src/com/cloud/agent/resource/virtualnetwork/VRScripts.java
+++ b/core/src/com/cloud/agent/resource/virtualnetwork/VRScripts.java
@@ -68,5 +68,4 @@ public class VRScripts {
 public static final String UPDATE_HOST_PASSWD = "update_host_passwd.sh";
 
 public static final String VR_CFG = "vr_cfg.sh";
-
 }
\ No newline at end of file
diff --git 
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
index 1367218..8dd0620 100644
--- 
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
+++ 
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
@@ -22,7 +22,6 @@ package com.cloud.agent.resource.virtualnetwork;
 import 

[GitHub] [cloudstack] rhtyd merged pull request #3351: Have persistent DHCP leases file on VRs and cleanup /etc/hosts on VM deletion

[GitBox]

rhtyd merged pull request #3351: Have persistent DHCP leases file on VRs and 
cleanup /etc/hosts on VM deletion
URL: https://github.com/apache/cloudstack/pull/3351
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch revert-3346-template_rewrite deleted (was a11dc46)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch revert-3346-template_rewrite
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was a11dc46  Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"

This change permanently discards the following revisions:

 discard a11dc46  Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"

[GitHub] [cloudstack] rhtyd merged pull request #3368: [WIP DO NOT MERGE] server: fix public IP addresses filtering

[GitBox]

rhtyd merged pull request #3368: [WIP DO NOT MERGE] server: fix public IP 
addresses filtering
URL: https://github.com/apache/cloudstack/pull/3368
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd closed issue #3295: listPublicIPAddresses return not filtered for current network

[GitBox]

rhtyd closed issue #3295: listPublicIPAddresses return not filtered for current 
network
URL: https://github.com/apache/cloudstack/issues/3295
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498147553
 
 
   Potential regression maker merged without tests.
   Note - to kick tests after packaging is OK cc @PaulAngus @borisstoyanov 
@nvazquez and others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498147172
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498153311
 
 
   @DennisKonrad you can run it manually on your local env using some nested 
env such as https://github.com/rhtyd/monkeybox, otherwise one can also setup 
Trillian https://github.com/shapeblue/Trillian
   
   I'll kick the tests using the blueorangutan bot that kicks tests with our 
Trillian env.
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498153511
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3268: Support sort_key for vpc_offerings table

[GitBox]

DaanHoogland commented on a change in pull request #3268: Support sort_key for 
vpc_offerings table
URL: https://github.com/apache/cloudstack/pull/3268#discussion_r289751284
 
 

 ##
 File path: api/src/main/java/com/cloud/network/vpc/VpcProvisioningService.java
 ##
 @@ -41,12 +43,9 @@ public VpcOffering createVpcOffering(String name, String 
displayText, List

[GitHub] [cloudstack] rhtyd commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

[GitBox]

rhtyd commented on issue #3194: Suspending a VM before snapshot deletion (see 
PR #3193)
URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-498221026
 
 
   @melnik13 perhaps you can send a PR towards cloudstack-documentation 
https://github.com/apache/cloudstack-documentation and in CloudStack UI, when 
we see the create/delete vm snapshot form/dialog it can say the operation will 
pause the guest VM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

[GitBox]

ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion 
(see PR #3193)
URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-498222616
 
 
   @melnik13 
   Beside what @rhtyd said, you can change the description in 
CreateVMSnapshotCmd.java and DeleteVMSnapshotCmd.java
   
   We already have some message in ui/l10n/ to warn users that "Please notice 
that the instance will be paused during the snapshoting, and resumed after 
snapshotting, if it runs on KVM." when create a vm snapshot.
   It is better to add similar warning when delete a vm snapshot.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch revert-3346-template_rewrite created (now a11dc46)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch revert-3346-template_rewrite
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at a11dc46  Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"

This branch includes the following new commits:

 new a11dc46  Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[cloudstack] 01/01: Revert "Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh (#3346)"

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch revert-3346-template_rewrite
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit a11dc4662702b27c6f306ec12eddf9491c50c3fc
Author: Rohit Yadav 
AuthorDate: Mon Jun 3 17:28:01 2019 +0530

Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"

This reverts commit 6946f41784423788e71441255e67c2b9b1c3633d.
---
 scripts/storage/secondary/cloud-install-sys-tmplt | 298 +++---
 scripts/storage/secondary/createtmplt.sh  | 184 +++--
 2 files changed, 264 insertions(+), 218 deletions(-)

diff --git a/scripts/storage/secondary/cloud-install-sys-tmplt 
b/scripts/storage/secondary/cloud-install-sys-tmplt
index 6bb8d20..91b3a7c 100755
--- a/scripts/storage/secondary/cloud-install-sys-tmplt
+++ b/scripts/storage/secondary/cloud-install-sys-tmplt
@@ -1,4 +1,5 @@
 #!/bin/bash
+# $Id: installrtng.sh 11251 2010-07-23 23:40:44Z abhishek $ $HeadURL: 
svn://svn.lab.vmops.com/repos/vmdev/java/scripts/storage/secondary/installrtng.sh
 $
 
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
@@ -19,35 +20,19 @@
 
 
 usage() {
-  printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-f system vm 
template file\n\t-h hypervisor name: kvm|vmware|xenserver|hyperv|ovm3\n\t-s 
mgmt server secret key, if you specified any when running 
cloudstack-setup-database, default is password\n\t-u Url to system vm 
template\n\t-F clean up system templates of specified hypervisor\n\t-e Template 
suffix, e.g vhd, ova, qcow2\n\t-o Database server hostname or ip, e.g 
localhost\n\t-r Database user name, e.g root\n\t-p mysql databa [...]
-  printf "\tor\n"
-  printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-u http url for 
system vm template\n\t-h hypervisor name: 
kvm|vmware|xenserver|hyperv|ovm3\n\t-s mgmt server secret key\n\n" $(basename 
$0) >&2
+  printf "Usage: %s: -m  -f  [-h  ] [ -s ][-u ] [-F ] [-e ] 
[-o ] [-r ] [-p &2
+  printf "%s: -m  -u  [-h  ] [ -s ]\n" $(basename $0) >&2
 }
 
-# Usage: e.g. failed $? "this is an error"
 failed() {
-  local returnval=$1
-  local returnmsg=$2
-  
-  # check for an message, if there is no one dont print anything
-  if [[ -z $returnmsg ]]; then
-:
-  else
-echo -e $returnmsg
-  fi
-  if [[ $returnval -eq 0 ]]; then
-return 0
-  else
-echo "Installation failed"
-exit $returnval
-  fi
+  echo "Installation failed"
+  exit $1
 }
-
 #set -x
 mflag=
 fflag=
 ext="vhd"
-hvm=false
 templateId=
 hyper=
 msKey=password
@@ -57,15 +42,6 @@ dbUser="root"
 dbPassword=
 dbPort=3306
 jasypt='/usr/share/cloudstack-common/lib/jasypt-1.9.2.jar'
-tmpldescr='SystemVM Template'
-
-# check if first parameter is not a dash (-) then print the usage block
-if [[ ! $@ =~ ^\-.+ ]]; then
-   usage
-   exit 0
-fi
-
-OPTERR=0
 while getopts 'm:h:f:u:Ft:e:s:o:r:d:p:'# OPTION
 do
   case $OPTION in
@@ -86,9 +62,6 @@ do
 ;;
   h)hyper="$OPTARG"
 ;;
-  H)Hflag=1
-hvm="true"
-;;
   s)sflag=1
 msKey="$OPTARG"
 ;;
@@ -105,98 +78,121 @@ do
 dbPort="$OPTARG"
 ;;
   ?)usage
-exit 0
-;;
-  *)usage
-exit 0
+failed 2
 ;;
   esac
 done
 
-if [[ "$mflag$fflag" != "11" && "$mflag$uflag" != "11" ]]; then
-  failed 2 "Please add a mount point and a system vm template file"
+if [[ "$mflag$fflag" != "11"  && "$mflag$uflag" != "11" ]]
+then
+  usage
+  failed 2
 fi
 
-if [[ -z "$hyper" ]]; then
-  failed 2 "Please add a correct hypervisor name like: 
kvm|vmware|xenserver|hyperv|ovm3"
+if [ -z "$hyper" ]
+then
+  usage
+  failed 2
 fi
 
-if [[ ! -d $mntpoint ]]; then
-  failed 2 "mount point $mntpoint doesn't exist\n"
+if [ ! -d $mntpoint ]
+then
+  echo "mount point $mntpoint doesn't exist\n"
+  failed 4
 fi
 
-if [[ "$fflag" == "1" && ! -f $tmpltimg ]]; then
-  failed 2 "template image file $tmpltimg doesn't exist"
+if [[ "$fflag" == "1" && ! -f $tmpltimg ]]
+then
+  echo "template image file $tmpltimg doesn't exist"
+  failed 3
 fi
 
-if [[ -f /etc/cloudstack/management/db.properties ]]; then
-  if [[ "$pflag" != 1 ]]; then
-dbPort=$(sed '/^\#/d' /etc/cloudstack/management/db.properties | grep 
'db.cloud.port'  | tail -n 1 | cut -d "=" -f2- | sed 
's/^[[:space:]]*//;s/[[:space:]]*$//')
-  fi
-
-  if [[ "$oflag" != 1 ]]; then
-dbHost=$(sed '/^\#/d' /etc/cloudstack/management/db.properties | grep 
'db.cloud.host'  | tail -n 1 | cut -d "=" -f2- | sed 
's/^[[:space:]]*//;s/[[:space:]]*$//')
-  fi
-
-  if [[ "$rflag" != 1 ]]; then
-dbUser=$(sed '/^\#/d' /etc/cloudstack/management/db.properties | grep 
'db.cloud.username'  | tail -n 1 | cut -d "=" -f2- | sed 
's/^[[:space:]]*//;s/[[:space:]]*$//')
-  fi
+if [ -f /etc/cloudstack/management/db.properties ]
+then
+if [ "$pflag" != 1 ]
+

[cloudstack] branch master updated: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh (#3346)

[dkonrad]

This is an automated email from the ASF dual-hosted git repository.

dkonrad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 6946f41  Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)
6946f41 is described below

commit 6946f41784423788e71441255e67c2b9b1c3633d
Author: Sven Vogel 
AuthorDate: Mon Jun 3 09:30:45 2019 +0200

Fix template size for managed storage / refactor cloud-install-sys-tmplt 
and createtmplt.sh (#3346)

* refactor cloud-install-sys-tmplt and createtmplt.sh

* move qemu-img check to kvm / add more comments if qemu-img not available 
/ set virtual size only for qcow2

* add comments to the failed and get options block / rename vars in failed 
block / typo Fix

*  add comments to the failed and get options block / rename vars in failed 
block / typo Fix to cloudtmplt.sh
---
 scripts/storage/secondary/cloud-install-sys-tmplt | 298 +++---
 scripts/storage/secondary/createtmplt.sh  | 184 ++---
 2 files changed, 218 insertions(+), 264 deletions(-)

diff --git a/scripts/storage/secondary/cloud-install-sys-tmplt 
b/scripts/storage/secondary/cloud-install-sys-tmplt
index 91b3a7c..6bb8d20 100755
--- a/scripts/storage/secondary/cloud-install-sys-tmplt
+++ b/scripts/storage/secondary/cloud-install-sys-tmplt
@@ -1,5 +1,4 @@
 #!/bin/bash
-# $Id: installrtng.sh 11251 2010-07-23 23:40:44Z abhishek $ $HeadURL: 
svn://svn.lab.vmops.com/repos/vmdev/java/scripts/storage/secondary/installrtng.sh
 $
 
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
@@ -20,19 +19,35 @@
 
 
 usage() {
-  printf "Usage: %s: -m  -f  [-h  ] [ -s ][-u ] [-F ] [-e ] 
[-o ] [-r ] [-p &2
-  printf "%s: -m  -u  [-h  ] [ -s ]\n" $(basename $0) >&2
+  printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-f system vm 
template file\n\t-h hypervisor name: kvm|vmware|xenserver|hyperv|ovm3\n\t-s 
mgmt server secret key, if you specified any when running 
cloudstack-setup-database, default is password\n\t-u Url to system vm 
template\n\t-F clean up system templates of specified hypervisor\n\t-e Template 
suffix, e.g vhd, ova, qcow2\n\t-o Database server hostname or ip, e.g 
localhost\n\t-r Database user name, e.g root\n\t-p mysql databa [...]
+  printf "\tor\n"
+  printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-u http url for 
system vm template\n\t-h hypervisor name: 
kvm|vmware|xenserver|hyperv|ovm3\n\t-s mgmt server secret key\n\n" $(basename 
$0) >&2
 }
 
+# Usage: e.g. failed $? "this is an error"
 failed() {
-  echo "Installation failed"
-  exit $1
+  local returnval=$1
+  local returnmsg=$2
+  
+  # check for an message, if there is no one dont print anything
+  if [[ -z $returnmsg ]]; then
+:
+  else
+echo -e $returnmsg
+  fi
+  if [[ $returnval -eq 0 ]]; then
+return 0
+  else
+echo "Installation failed"
+exit $returnval
+  fi
 }
+
 #set -x
 mflag=
 fflag=
 ext="vhd"
+hvm=false
 templateId=
 hyper=
 msKey=password
@@ -42,6 +57,15 @@ dbUser="root"
 dbPassword=
 dbPort=3306
 jasypt='/usr/share/cloudstack-common/lib/jasypt-1.9.2.jar'
+tmpldescr='SystemVM Template'
+
+# check if first parameter is not a dash (-) then print the usage block
+if [[ ! $@ =~ ^\-.+ ]]; then
+   usage
+   exit 0
+fi
+
+OPTERR=0
 while getopts 'm:h:f:u:Ft:e:s:o:r:d:p:'# OPTION
 do
   case $OPTION in
@@ -62,6 +86,9 @@ do
 ;;
   h)hyper="$OPTARG"
 ;;
+  H)Hflag=1
+hvm="true"
+;;
   s)sflag=1
 msKey="$OPTARG"
 ;;
@@ -78,121 +105,98 @@ do
 dbPort="$OPTARG"
 ;;
   ?)usage
-failed 2
+exit 0
+;;
+  *)usage
+exit 0
 ;;
   esac
 done
 
-if [[ "$mflag$fflag" != "11"  && "$mflag$uflag" != "11" ]]
-then
-  usage
-  failed 2
+if [[ "$mflag$fflag" != "11" && "$mflag$uflag" != "11" ]]; then
+  failed 2 "Please add a mount point and a system vm template file"
 fi
 
-if [ -z "$hyper" ]
-then
-  usage
-  failed 2
+if [[ -z "$hyper" ]]; then
+  failed 2 "Please add a correct hypervisor name like: 
kvm|vmware|xenserver|hyperv|ovm3"
 fi
 
-if [ ! -d $mntpoint ]
-then
-  echo "mount point $mntpoint doesn't exist\n"
-  failed 4
+if [[ ! -d $mntpoint ]]; then
+  failed 2 "mount point $mntpoint doesn't exist\n"
 fi
 
-if [[ "$fflag" == "1" && ! -f $tmpltimg ]]
-then
-  echo "template image file $tmpltimg doesn't exist"
-  failed 3
+if [[ "$fflag" == "1" && ! -f $tmpltimg ]]; then
+  failed 2 "template image file $tmpltimg doesn't exist"
 fi
 
-if [ -f /etc/cloudstack/management/db.properties ]
-then
-if [ "$pflag" != 1 ]
-then
-dbPort=$(sed '/^\#/d' /etc/cloudstack/management/db.properties | grep 
'db.cloud.port'  | tail -n 1 | cut -d "=" -f2- | sed 

[GitHub] [cloudstack] DennisKonrad merged pull request #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad merged pull request #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498153113
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2829


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3310: Fix removing static NAT rules with Juniper SRX

[GitBox]

anuragaw commented on a change in pull request #3310: Fix removing static NAT 
rules with Juniper SRX
URL: https://github.com/apache/cloudstack/pull/3310#discussion_r289797663
 
 

 ##
 File path: 
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
 ##
 @@ -2078,11 +2078,11 @@ private boolean manageStaticNatRule(SrxCommand 
command, String publicIp, String
 xml = replaceXmlValue(xml, "rule-set", _privateZone);
 xml = replaceXmlValue(xml, "from-zone", _privateZone);
 xml = replaceXmlValue(xml, "rule-name", 
ruleName_private);
-}
 
-if (!sendRequestAndCheckResponse(command, xml, "name", 
ruleName_private))
-{
-throw new ExecutionException("Failed to delete trust 
static NAT rule from public IP " + publicIp + " to private IP " + privateIp);
+if (!sendRequestAndCheckResponse(command, xml, "name", 
ruleName_private))
+{
+throw new ExecutionException("Failed to delete 
trust static NAT rule from public IP " + publicIp + " to private IP " + 
privateIp);
+}
 
 Review comment:
   nit- This is one confusing else block :/ I don't think we need the else at 
all. Essentially it's about sending command and post that checking if private 
rules delete exists and execute that. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd closed issue #3309: SRX Plugin Fails to Delete Static NAT Rules

[GitBox]

rhtyd closed issue #3309: SRX Plugin Fails to Delete Static NAT Rules
URL: https://github.com/apache/cloudstack/issues/3309
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd closed issue #3354: Upon VM removal, VM records not removed from /etc/hosts

[GitBox]

rhtyd closed issue #3354: Upon VM removal, VM records not removed from 
/etc/hosts
URL: https://github.com/apache/cloudstack/issues/3354
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (6946f41 -> 1c5244a)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 6946f41  Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)
 add 2484527  srx: Fix removing static NAT rules with Juniper SRX (#3310)
 add c9ce3e2  router: Persistent DHCP leases file on VRs and cleanup 
/etc/hosts on VM deletion (#3351)
 add b2b99ca  Merge remote-tracking branch 'origin/4.11' into 4.12
 new 1c5244a  Merge remote-tracking branch 'origin/4.12'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/network/element/DhcpServiceProvider.java |  2 ++
 .../cloud/agent/api/routing/DhcpEntryCommand.java  |  9 ++
 .../virtualnetwork/facade/DhcpEntryConfigItem.java |  2 +-
 .../virtualnetwork/model/VmDhcpConfig.java | 14 -
 .../service/NetworkOrchestrationService.java   |  4 +++
 .../engine/orchestration/NetworkOrchestrator.java  | 28 +
 .../networkservice/BaremetalDhcpElement.java   |  5 
 .../contrail/management/ContrailElementImpl.java   |  5 
 .../cloud/network/resource/JuniperSrxResource.java |  9 +++---
 .../network/element/VirtualRouterElement.java  | 28 +
 .../cloud/network/router/CommandSetupHelper.java   |  5 ++--
 .../com/cloud/network/rules/DhcpEntryRules.java| 10 +++
 .../main/java/com/cloud/vm/UserVmManagerImpl.java  | 14 ++---
 .../network/topology/AdvancedNetworkTopology.java  | 15 ++
 .../network/topology/AdvancedNetworkVisitor.java   |  3 +-
 .../network/topology/BasicNetworkTopology.java | 21 +
 .../network/topology/BasicNetworkVisitor.java  |  3 +-
 .../network/topology/NetworkTopology.java  |  2 ++
 .../java/com/cloud/vpc/MockNetworkManagerImpl.java |  4 +++
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py | 35 ++
 systemvm/debian/opt/cloud/bin/cs_dhcp.py   |  4 +++
 21 files changed, 203 insertions(+), 19 deletions(-)

[GitHub] [cloudstack] rhtyd closed issue #3272: VR DHCP lease file not persistent

[GitBox]

rhtyd closed issue #3272: VR DHCP lease file not persistent
URL: https://github.com/apache/cloudstack/issues/3272
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.12'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 1c5244a0c58510c467707d5d9f2c4fbc72d784d0
Merge: 6946f41 b2b99ca
Author: Rohit Yadav 
AuthorDate: Mon Jun 3 17:17:51 2019 +0530

Merge remote-tracking branch 'origin/4.12'

 .../cloud/network/element/DhcpServiceProvider.java |  2 ++
 .../cloud/agent/api/routing/DhcpEntryCommand.java  |  9 ++
 .../virtualnetwork/facade/DhcpEntryConfigItem.java |  2 +-
 .../virtualnetwork/model/VmDhcpConfig.java | 14 -
 .../service/NetworkOrchestrationService.java   |  4 +++
 .../engine/orchestration/NetworkOrchestrator.java  | 28 +
 .../networkservice/BaremetalDhcpElement.java   |  5 
 .../contrail/management/ContrailElementImpl.java   |  5 
 .../cloud/network/resource/JuniperSrxResource.java |  9 +++---
 .../network/element/VirtualRouterElement.java  | 28 +
 .../cloud/network/router/CommandSetupHelper.java   |  5 ++--
 .../com/cloud/network/rules/DhcpEntryRules.java| 10 +++
 .../main/java/com/cloud/vm/UserVmManagerImpl.java  | 14 ++---
 .../network/topology/AdvancedNetworkTopology.java  | 15 ++
 .../network/topology/AdvancedNetworkVisitor.java   |  3 +-
 .../network/topology/BasicNetworkTopology.java | 21 +
 .../network/topology/BasicNetworkVisitor.java  |  3 +-
 .../network/topology/NetworkTopology.java  |  2 ++
 .../java/com/cloud/vpc/MockNetworkManagerImpl.java |  4 +++
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py | 35 ++
 systemvm/debian/opt/cloud/bin/cs_dhcp.py   |  4 +++
 21 files changed, 203 insertions(+), 19 deletions(-)

Build failed in Jenkins: cloudstack-apidocs-master #3126

[Apache Jenkins Server]

See 


Changes:

[rohit.yadav] srx: Fix removing static NAT rules with Juniper SRX (#3310)

[rohityadav89] router: Persistent DHCP leases file on VRs and cleanup 
/etc/hosts on VM

--
[...truncated 203.11 KB...]
[INFO] Apache CloudStack Core  SUCCESS [15.089s]
[INFO] Apache CloudStack Agents .. SUCCESS [9.833s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [7.748s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [3.995s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [7.136s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [5.557s]
[INFO] Apache CloudStack Agent Management Servers Load Balancer  SUCCESS 
[4.069s]
[INFO] Apache CloudStack Framework - Storage Config Drive Component  SUCCESS 
[17.496s]
[INFO] Apache CloudStack Server .. FAILURE [27.418s]
[INFO] Apache CloudStack Framework - Quota ... SKIPPED
[INFO] Apache CloudStack Usage Server  SKIPPED
[INFO] Apache CloudStack Cloud Engine API  SKIPPED
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SKIPPED
[INFO] Apache CloudStack Cloud Services .. SKIPPED
[INFO] Apache CloudStack Secondary Storage ... SKIPPED
[INFO] Apache CloudStack Secondary Storage Service ... SKIPPED
[INFO] Apache CloudStack Engine Storage Component  SKIPPED
[INFO] Apache CloudStack Cloud Engine Service  SKIPPED
[INFO] Apache CloudStack Engine Storage Cache Component .. SKIPPED
[INFO] Apache CloudStack Engine Storage Image Component .. SKIPPED
[INFO] Apache CloudStack Engine Storage Volume Component . SKIPPED
[INFO] Apache CloudStack Engine Storage Data Motion Component  SKIPPED
[INFO] Apache CloudStack Engine Storage Snapshot Component  SKIPPED
[INFO] Apache CloudStack Plugin POM .. SKIPPED
[INFO] Apache CloudStack Plugin - ACL Dynamic Role Based . SKIPPED
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SKIPPED
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor  SKIPPED
[INFO] Apache CloudStack Plugin - Host Affinity Processor  SKIPPED
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SKIPPED
[INFO] Apache CloudStack Plugin - SNMP Alerts  SKIPPED
[INFO] Apache CloudStack Plugin - Syslog Alerts .. SKIPPED
[INFO] Apache CloudStack Plugin - API Discovery .. SKIPPED
[INFO] Apache CloudStack Plugin - API Rate Limit . SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SKIPPED
[INFO] Apache CloudStack Plugin - API SolidFire Integration Testing  SKIPPED
[INFO] Apache CloudStack Plugin - Inbuilt Root Certificate Authority  SKIPPED
[INFO] Apache CloudStack Plugin - Quota Service .. SKIPPED
[INFO] Apache CloudStack Plugin - Dedicated Resources  SKIPPED
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner  SKIPPED
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner  
SKIPPED
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner  SKIPPED
[INFO] Apache CloudStack Plugin - In Memory Event Bus  SKIPPED
[INFO] Apache CloudStack Plugin - Kafka Event Bus  SKIPPED
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus . SKIPPED
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner  SKIPPED
[INFO] Apache CloudStack Plugin - Host Allocator Random .. SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor Baremetal ... SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor Hyper-V . SKIPPED
[INFO] Apache CloudStack Plugin - Open vSwitch ... SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor KVM . SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM3 ... SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM  SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor UCS . SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SKIPPED
[INFO] Apache CloudStack Plugin - Cloudian Connector . SKIPPED
[INFO] Apache CloudStack Plugin - Prometheus Exporter  SKIPPED
[INFO] Apache CloudStack Plugin - Metrics  SKIPPED
[INFO] Apache CloudStack Plugin - BigSwitch Virtual Network Segment  SKIPPED
[INFO] Apache CloudStack Plugin - Dns Notifier Example ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Internal Load Balancer  SKIPPED
[INFO] Apache CloudStack Framework - Spring Life Cycle ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Juniper Contrail  SKIPPED
[INFO] Apache CloudStack Plugin - Network Elastic Load Balancer  SKIPPED
[INFO] Apache CloudStack Plugin - GloboDNS ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Netscaler .. SKIPPED
[INFO] 

[GitHub] [cloudstack] rhtyd commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates

[GitBox]

rhtyd commented on issue #3075: WIP: Prevent regenerating keystore and add 
background task to upload certificates
URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498143142
 
 
   @blueorangutan test
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DennisKonrad commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498147682
 
 
   @rhtyd How can I run the smoketests?
   
   The second LGTM is from me ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498242573
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2831


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3370: ssvm: apply MTU value on storage/management nic if available

[GitBox]

blueorangutan commented on issue #3370: ssvm: apply MTU value on 
storage/management nic if available
URL: https://github.com/apache/cloudstack/pull/3370#issuecomment-498242574
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2830


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498256252
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498271674
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2833


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289896196
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   @rhtyd yes maybe. can you see how/where the createtmplt.sh will called? can 
you see wich options are important?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DaanHoogland commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498233799
 
 
   > I don't think we use the `createtmpl` script directly as end users. We use 
the `cloud-install-sys-tmplt` which invokes other scripts. So as long as that 
is up-to-date we should be good
   
   I think it is irrelevant if we have an extension or not. The issue is if it 
*might* be used by admions of clouds around the world we must not change it 
without clear migration path. consistency is not an objective, as much as 
backwards compatibility!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498246953
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2832


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan removed a comment on issue #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498246953
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2832


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan removed a comment on issue #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498244641
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #2995: KVM: Improvements on upload direct download certificates

[GitBox]

nvazquez commented on issue #2995: KVM: Improvements on upload direct download 
certificates
URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-498276016
 
 
   @rafaelweingartner are you ok with this one after comments addressed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498280740
 
 
   @DennisKonrad master needs stabilisation, which is why you're seeing 
intermittent errors. The jenkins job is not reliable, I'm not sure how to 
manage that, I usually ignore that like most people. I check Travis test 
results and smoketests via BO.
   
   4.11 for example is most stable branch where Travis mostly passes along with 
smoketests. We'll need to put some effort on master to ensure Travis test runs 
are reliable, this would require either fixing the failing tests or the code 
that caused that regression. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289896196
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   @rhtyd yes maybe. can you see how/where the createtmplt.sh will called? can 
you see wich options are important?
   
   maybe -d flag? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289903978
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   @rhtyd if i could know which are important for check i can put them back.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel edited a comment on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel edited a comment on issue #3346: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498234290
 
 
   @DaanHoogland @rhtyd ok. i will create new PR and i hope you can take a look 
whats wrong in your test. do you have a error log whats wrong with KVM, VMware 
and XenServer? normal cloudstack installation should not be affected by this.
   
   which command will used to check this in trillian or jenkins?
   
   @DaanHoogland the main command "cloud-install-sys-tmplt" is not changed from 
the options. (only we add -H) 
   we need more information about your trillian and jenkins error 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498236394
 
 
   @rhtyd please run your check again so that we can find the problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates

[GitBox]

blueorangutan commented on issue #2995: KVM: Improvements on upload direct 
download certificates
URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-498240892
 
 
   Trillian test result (tid-3633)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32669 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2995-t3633-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 69 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3370: ssvm: apply MTU value on storage/management nic if available

[GitBox]

blueorangutan commented on issue #3370: ssvm: apply MTU value on 
storage/management nic if available
URL: https://github.com/apache/cloudstack/pull/3370#issuecomment-498243972
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289845382
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   @svenvogel @DennisKonrad several flags/opts are removed from the script, do 
you think it will cause regression in case the script is evoked via mgmt server 
or ssvm agent?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : cloudstack-apidocs-master #3128

[Apache Jenkins Server]

See 

[GitHub] [cloudstack] DennisKonrad commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498272513
 
 
   @rhtyd Ok, that clears up things a lot. But what about those two. How can 
one make sense of the test result there?
   
   https://builds.apache.org/job/cloudstack-pr-analysis
   https://travis-ci.org/apache/cloudstack
   
   The jenkins fails with some code that doesnt even belong to the PR and the 
Travis tests mostly seem to pass this time even though they didn't with the 
same code before??


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd opened a new pull request #3370: ssvm: apply MTU value on storage/management nic if available

[GitBox]

rhtyd opened a new pull request #3370: ssvm: apply MTU value on 
storage/management nic if available
URL: https://github.com/apache/cloudstack/pull/3370
 
 
   If mtu= value is defined in the parameters received by the SSVM agent
   per the secstorage.vm.mtu.size setting, it applies the MTU setting on
   eth1 which is the storage/management nic.
   
   Fixes #3369
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3369: MTU for storage interface on SSVM is not honored

[GitBox]

rhtyd commented on issue #3369: MTU for storage interface on SSVM is not honored
URL: https://github.com/apache/cloudstack/issues/3369#issuecomment-498234764
 
 
   @PaulAngus  please test and review 
https://github.com/apache/cloudstack/pull/3370


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3370: ssvm: apply MTU value on storage/management nic if available

[GitBox]

rhtyd commented on issue #3370: ssvm: apply MTU value on storage/management nic 
if available
URL: https://github.com/apache/cloudstack/pull/3370#issuecomment-498234625
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3370: ssvm: apply MTU value on storage/management nic if available

[GitBox]

blueorangutan commented on issue #3370: ssvm: apply MTU value on 
storage/management nic if available
URL: https://github.com/apache/cloudstack/pull/3370#issuecomment-498234719
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498237471
 
 
   Thanks
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3370: ssvm: apply MTU value on storage/management nic if available

[GitBox]

rhtyd commented on issue #3370: ssvm: apply MTU value on storage/management nic 
if available
URL: https://github.com/apache/cloudstack/pull/3370#issuecomment-498243723
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498263837
 
 
   @DennisKonrad yes, but Trillian requires a lot of effort to setup and 
manage, and can span multiple hosts/machines. Monkeybox is aimed for developers 
who can setup a nested kvm based dev-test env on a single machine. Marvin based 
smoketests can run on both env.
   The merge guideline require that smoketests should pass and the 
author/CI-runner to prove that no regressions were seen, irrespective of 
whether the tests were run manually or via a script/job.
   
   BO is a github bot account that triggers jobs in our internal Jenkins which 
uses Trillian to deploy and run tests against an env.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498273148
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2835


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498278359
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: cloudstack-apidocs-master #3127

[Apache Jenkins Server]

See 


Changes:

[rohit.yadav] Revert "Fix template size for managed storage / refactor

--
[...truncated 240.73 KB...]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [3.661s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [6.469s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [5.092s]
[INFO] Apache CloudStack Agent Management Servers Load Balancer  SUCCESS 
[3.122s]
[INFO] Apache CloudStack Framework - Storage Config Drive Component  SUCCESS 
[17.022s]
[INFO] Apache CloudStack Server .. FAILURE [21.041s]
[INFO] Apache CloudStack Framework - Quota ... SKIPPED
[INFO] Apache CloudStack Usage Server  SKIPPED
[INFO] Apache CloudStack Cloud Engine API  SKIPPED
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SKIPPED
[INFO] Apache CloudStack Cloud Services .. SKIPPED
[INFO] Apache CloudStack Secondary Storage ... SKIPPED
[INFO] Apache CloudStack Secondary Storage Service ... SKIPPED
[INFO] Apache CloudStack Engine Storage Component  SKIPPED
[INFO] Apache CloudStack Cloud Engine Service  SKIPPED
[INFO] Apache CloudStack Engine Storage Cache Component .. SKIPPED
[INFO] Apache CloudStack Engine Storage Image Component .. SKIPPED
[INFO] Apache CloudStack Engine Storage Volume Component . SKIPPED
[INFO] Apache CloudStack Engine Storage Data Motion Component  SKIPPED
[INFO] Apache CloudStack Engine Storage Snapshot Component  SKIPPED
[INFO] Apache CloudStack Plugin POM .. SKIPPED
[INFO] Apache CloudStack Plugin - ACL Dynamic Role Based . SKIPPED
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SKIPPED
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor  SKIPPED
[INFO] Apache CloudStack Plugin - Host Affinity Processor  SKIPPED
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SKIPPED
[INFO] Apache CloudStack Plugin - SNMP Alerts  SKIPPED
[INFO] Apache CloudStack Plugin - Syslog Alerts .. SKIPPED
[INFO] Apache CloudStack Plugin - API Discovery .. SKIPPED
[INFO] Apache CloudStack Plugin - API Rate Limit . SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SKIPPED
[INFO] Apache CloudStack Plugin - API SolidFire Integration Testing  SKIPPED
[INFO] Apache CloudStack Plugin - Inbuilt Root Certificate Authority  SKIPPED
[INFO] Apache CloudStack Plugin - Quota Service .. SKIPPED
[INFO] Apache CloudStack Plugin - Dedicated Resources  SKIPPED
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner  SKIPPED
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner  
SKIPPED
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner  SKIPPED
[INFO] Apache CloudStack Plugin - In Memory Event Bus  SKIPPED
[INFO] Apache CloudStack Plugin - Kafka Event Bus  SKIPPED
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus . SKIPPED
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner  SKIPPED
[INFO] Apache CloudStack Plugin - Host Allocator Random .. SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor Baremetal ... SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor Hyper-V . SKIPPED
[INFO] Apache CloudStack Plugin - Open vSwitch ... SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor KVM . SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM3 ... SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM  SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor UCS . SKIPPED
[INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SKIPPED
[INFO] Apache CloudStack Plugin - Cloudian Connector . SKIPPED
[INFO] Apache CloudStack Plugin - Prometheus Exporter  SKIPPED
[INFO] Apache CloudStack Plugin - Metrics  SKIPPED
[INFO] Apache CloudStack Plugin - BigSwitch Virtual Network Segment  SKIPPED
[INFO] Apache CloudStack Plugin - Dns Notifier Example ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Internal Load Balancer  SKIPPED
[INFO] Apache CloudStack Framework - Spring Life Cycle ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Juniper Contrail  SKIPPED
[INFO] Apache CloudStack Plugin - Network Elastic Load Balancer  SKIPPED
[INFO] Apache CloudStack Plugin - GloboDNS ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Netscaler .. SKIPPED
[INFO] Apache CloudStack Plugin - Network Nicira NVP . SKIPPED
[INFO] Apache CloudStack Plugin - Network Opendaylight ... SKIPPED
[INFO] Apache CloudStack Plugin - Palo Alto .. SKIPPED
[INFO] Apache CloudStack Plugin - Stratosphere SSP ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Brocade VCS  

[GitHub] [cloudstack] svenvogel opened a new pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel opened a new pull request #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371
 
 
   ## Description
   
   * remove unused old vars and functions e.g. today, chksum...
   * add function to calculate the virtual size of template for managed storage 
(netapp solidfire) so that the copy process is working from NFS to iSCSI 
correctly
   * refactor cloud-install-sys-tmplt creates all settings of 
template.properties
   * refactor createtmplt.sh shall create only the templates e.g. uncompress 
and install ...
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   tested manually in our production environment with different files like vhd, 
qcow2 and ova
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498278122
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on issue #3346: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-498234290
 
 
   @DaanHoogland @rhtyd ok. i will create new PR and i hope you can take a look 
whats wrong in your test. do you have a error log whats wrong with KVM, VMware 
and XenServer? normal cloudstack installation should not be affected by this.
   
   which command will used to check this in trillian or jenkins?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498237841
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-49823
 
 
   I'll have to review if the flags have changed. From a users point of view, 
the command should be backward compatible. Trillian is working OK with other 
PRs so likely the issue is in the PR, or the script was changed such that the 
usage is not backward compatible. 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DennisKonrad commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498244337
 
 
   https://github.com/shapeblue/Trillian
   
   Is the code here up to date? There's no way to set something like this up in 
a few days but if we would choose to do it: Would an installation using the 
code below behave (more or less) the same as blueorangutan?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DennisKonrad edited a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad edited a comment on issue #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498244337
 
 
   https://github.com/shapeblue/Trillian
   
   Is the code here up to date? There's no way to set something like this up in 
a few days but if we would choose to do it: Would an installation using the 
code in the repo above behave (more or less) the same as blueorangutan?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DennisKonrad commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498261593
 
 
   > @DennisKonrad you can test against a local kvm based nested env in few 
hours: https://github.com/rhtyd/monkeybox
   > @blueorangutan package
   
   Isn't the whole use case of Trillian to spin up an cloudstack env on the fly 
to run the smoke tests? Also you pointed out the merge guideline states the 
smoketests should pass. So it seems to me there's not much use in manually 
setting up monkey box to test. 
   
   Maybe I don't understand the difference between Monkeybox and Trillian. 
Could you elaborate on this?
   
   Also the question would be of importance to me: Can one use the trillian 
repo to get (more or less) the same results (as blueorangutan)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DennisKonrad commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498242874
 
 
   @rhtyd From my point of view the code from sven is a cleanup/improvement. 
How can one see now what causes the problem?
   
   For me the problem is now, how can I decide if there's a problem with svens 
code or is there something that should change in Trillian?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498244641
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan removed a comment on issue #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498237841
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan removed a comment on issue #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498242573
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2831


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd removed a comment on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498237471
 
 
   Thanks
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.12 updated: server: Fix forward merge missing import causing build failure

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.12
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.12 by this push:
 new 3f2399f  server: Fix forward merge missing import causing build failure
3f2399f is described below

commit 3f2399f107f25e0bc0240becb64d24467eadbdb5
Author: Rohit Yadav 
AuthorDate: Mon Jun 3 18:55:25 2019 +0530

server: Fix forward merge missing import causing build failure

This fixes forward merge regression that missed an import and causes
build failure in b2b99ca63eecab6c0be40015ee54c37b55e07bac

Signed-off-by: Rohit Yadav 
---
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
index e6ba5e7..5caa059 100644
--- a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -302,7 +302,7 @@ import com.cloud.vm.dao.VMInstanceDao;
 import com.cloud.vm.snapshot.VMSnapshotManager;
 import com.cloud.vm.snapshot.VMSnapshotVO;
 import com.cloud.vm.snapshot.dao.VMSnapshotDao;
-
+import com.google.common.base.Strings;
 
 public class UserVmManagerImpl extends ManagerBase implements UserVmManager, 
VirtualMachineGuru, UserVmService, Configurable {
 private static final Logger s_logger = 
Logger.getLogger(UserVmManagerImpl.class);

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.12'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 3e4c55c424a4f58d690cc3d88208db24110cf14b
Merge: cd6e846 3f2399f
Author: Rohit Yadav 
AuthorDate: Mon Jun 3 18:56:54 2019 +0530

Merge remote-tracking branch 'origin/4.12'

 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498256104
 
 
   @DennisKonrad you can test against a local kvm based nested env in few 
hours: https://github.com/rhtyd/monkeybox
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (cd6e846 -> 3e4c55c)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from cd6e846  Revert "Fix template size for managed storage / refactor 
cloud-install-sys-tmplt and createtmplt.sh (#3346)"
 add 3f2399f  server: Fix forward merge missing import causing build failure
 new 3e4c55c  Merge remote-tracking branch 'origin/4.12'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

blueorangutan commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498262009
 
 
   @DennisKonrad a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289896196
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   @rhtyd yes maybe. can you see how/where the createtmplt.sh will called? can 
you see which options are really used?
   
   maybe -d flag? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3240: [WIP DO NOT MERGE] api: instance and template details are free text

[GitBox]

nvazquez commented on a change in pull request #3240: [WIP DO NOT MERGE] api: 
instance and template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#discussion_r289920549
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -3399,6 +3407,50 @@ else if (!template.isPublicTemplate() && 
caller.getType() != Account.ACCOUNT_TYP
 hypervisorType, true, cmd.listInReadyState(), 
permittedAccounts, caller, listProjectResourcesCriteria, tags, showRemovedISO, 
null, null);
 }
 
+@Override
+public DetailOptionsResponse listDetailOptions(final ListDetailOptionsCmd 
cmd) {
+final ResourceObjectType type = cmd.getResourceType();
+final String resourceUuid = cmd.getResourceId();
+final Map> options = new HashMap<>();
+switch (type) {
+case Template:
+case UserVm:
+HypervisorType hypervisorType = HypervisorType.None;
+if (!Strings.isNullOrEmpty(resourceUuid) && 
ResourceObjectType.Template.equals(type)) {
+hypervisorType = 
_templateDao.findByUuid(resourceUuid).getHypervisorType();
+}
+if (!Strings.isNullOrEmpty(resourceUuid) && 
ResourceObjectType.UserVm.equals(type)) {
+hypervisorType = 
_vmInstanceDao.findByUuid(resourceUuid).getHypervisorType();
+}
+fillVMOrTemplateDetailOptions(options, hypervisorType);
+break;
+default:
+throw new CloudRuntimeException("Resource type not 
supported.");
+}
+return new DetailOptionsResponse(options);
+}
+
+private void fillVMOrTemplateDetailOptions(final Map> 
options, final HypervisorType hypervisorType) {
+if (options == null) {
+throw new CloudRuntimeException("Invalid/null detail-options 
response object passed");
+}
+
+options.put(VmDetailConstants.KEYBOARD, Arrays.asList("uk", "us", 
"jp", "fr"));
+options.put(VmDetailConstants.CPU_CORE_PER_SOCKET, 
Collections.emptyList());
+
+if (HypervisorType.KVM.equals(hypervisorType)) {
+options.put(VmDetailConstants.ROOT_DISK_CONTROLLER, 
Arrays.asList("ide", "scsi", "virtio"));
+}
+
+if (HypervisorType.VMware.equals(hypervisorType)) {
+options.put(VmDetailConstants.NIC_ADAPTER, Arrays.asList("E1000", 
"PCNet32", "Vmxnet2", "Vmxnet3"));
 
 Review comment:
   Similar as @DaanHoogland points out, what if we move these to a place in 
which we can read them and also perform validation?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

svenvogel commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289927484
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   @rhtyd thank you for help. you investigation will help to find a good 
solution. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

rhtyd commented on a change in pull request #3371: Fix template size for 
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289916241
 
 

 ##
 File path: scripts/storage/secondary/createtmplt.sh
 ##
 @@ -131,92 +123,66 @@ do
   f)   fflag=1
tmpltimg="$OPTARG"
;;
-  s)   sflag=1
-   ;;
-  d)   dflag=1
-   descr="$OPTARG"
-   ;;
-  S)   Sflag=1
-   size=$OPTARG
-let "size>>=10"
-   ulimit -f $size
-   ;;
-  h)   hflag=1
-   hvm="true"
-   ;;
-  u)   cleanup="true"
-   ;;
-  v)   verbose="true"
-   ;;
 
 Review comment:
   Let me review the results, do code investigation and get back to you 
tomorrow. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DennisKonrad commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox]

DennisKonrad commented on issue #3371: Fix template size for managed storage / 
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498315832
 
 
   @rhtyd So to resolve this issue can you provide the calls to those scripts 
to @svenvogel so he can maybe adapt this PR to work with the BO that's 
currently in place?
   
   I see no other way to resolve this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates

[GitBox]

blueorangutan commented on issue #3075: [WIP]: Prevent regenerating keystore 
and add background task to upload certificates
URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498381146
 
 
   Trillian test result (tid-3634)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39609 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3075-t3634-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 66 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_stop_ssvm | `Error` | 950.79 | test_ssvm.py
   test_06_stop_cpvm | `Error` | 954.76 | test_ssvm.py
   test_07_reboot_ssvm | `Error` | 913.08 | test_ssvm.py
   test_08_reboot_cpvm | `Error` | 913.10 | test_ssvm.py
   test_05_rvpc_multi_tiers | `Failure` | 407.31 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 430.55 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services