[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498977346 Trillian test result (tid-3645) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41854 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3075-t3645-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_stop_ssvm | `Error` | 961.34 | test_ssvm.py test_06_stop_cpvm | `Error` | 955.20 | test_ssvm.py test_07_reboot_ssvm | `Error` | 911.84 | test_ssvm.py test_08_reboot_cpvm | `Error` | 910.82 | test_ssvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
ustcweizhou commented on issue #3371: Fix template size for managed storage /
refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498966613
@rhtyd
qemu-img is needed to get the virtual size of systemvm template in QCOW2
format.
In the past systemvm template can still be installed even qemu-img is not
installed on management server. With this PR it will not continue.
It breaks some deployment indeed, However I think this change makes sense.
Is it possible to install qemu-img (centos6/centos7) or qemu-utils (ubuntu)
when set up a Trillian testing environment ?
> @svenvogel @DennisKonrad here are bunch of issues with this PR:
>
> * It breaks the cloud-install-sys-tmplt usage which is not backward
compatible anymore, to simply setup/seed the initial systemvmtemplate before
deploying a zone fails (it should not need to check if qemu-img etc is
available). Trillian logs for reference:
>
> ```
> 20:08:11 TASK [cloudstack-config : Install System VM templates]
*
> 20:08:12 failed: [pr3371-t3639-kvm-centos7-mgmt1] (item=-u
http://staging.yadav.xyz/systemvmtemplate/custom/4113/systemvmtemplate-4.11.3-kvm.qcow2.bz2
-h kvm -F) => {"changed": false, "cmd":
["/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt",
"-m", "/mnt/secstoragetmp", "-u",
"http://staging.yadav.xyz/systemvmtemplate/custom/4113/systemvmtemplate-4.11.3-kvm.qcow2.bz2;,
"-h", "kvm", "-F"], "delta": "0:00:00.195024", "end": "2019-06-03
14:38:29.618615", "failed": true, "item": "-u
http://staging.yadav.xyz/systemvmtemplate/custom/4113/systemvmtemplate-4.11.3-kvm.qcow2.bz2
-h kvm -F", "rc": 2, "start": "2019-06-03 14:38:29.423591", "stderr": "which:
no qemu-img in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin)",
"stderr_lines": ["which: no qemu-img in
(/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin)"], "stdout": "Please
install qemu-img: command\non CentOS run \"yum install qemu-img\"\non
Ubuntu/Debian run \"apt-get install qemu-utils\"\nInstallation failed",
"stdout_lines": ["Please install qemu-img: command", "on CentOS run \"yum
install qemu-img\"", "on Ubuntu/Debian run \"apt-get install qemu-utils\"",
"Installation failed"]}
> ```
>
> * You can find usage of the second script using `git grep createtmplt.sh`,
I found that the script is used both the ssvm agent and kvm to process
templates. By removing flags that once were passed, it breaks the usage of the
script:
>
https://github.com/apache/cloudstack/blob/master/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java#L723
>
> Given this is a refactoring/cleanup PR, this ought to be backward
compatible wrt script execution usages, i.e. don't remove flags and don't
replace old flags, without proper documentation don't change how script is used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3364: LDAP users with similar permissions do not see each other's networks
PaulAngus commented on issue #3364: LDAP users with similar permissions do not see each other's networks URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-498974903 Are these the same root admin account or two accounts which both have root admin privileges? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PPisz commented on issue #3364: LDAP users with similar permissions do not see each other's networks
PPisz commented on issue #3364: LDAP users with similar permissions do not see each other's networks URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-498977807 Two accounts with root admin privileges: ppisz | Root Admin | Admin | ROOT | enabled tome | Root Admin | Admin | ROOT | enabled This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating keystore on provisionCertificate API
rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating
keystore on provisionCertificate API
URL: https://github.com/apache/cloudstack/pull/3075#discussion_r290627597
##
File path: scripts/util/keystore-setup
##
@@ -35,18 +35,19 @@ if [ -f "$PROPS_FILE" ]; then
fi
fi
-# Generate keystore
-rm -f "$KS_FILE"
-CN=$(hostname --fqdn)
-keytool -genkey -storepass "$KS_PASS" -keypass "$KS_PASS" -alias "$ALIAS"
-keyalg RSA -validity "$KS_VALIDITY" -dname
cn="$CN",ou="cloudstack",o="cloudstack",c="cloudstack" -keystore "$KS_FILE" >
/dev/null 2>&1
+# Generate keystore if it does not exist
+if [ ! -f "$KS_FILE" ]; then
+CN=$(hostname --fqdn)
+keytool -genkey -storepass "$KS_PASS" -keypass "$KS_PASS" -alias "$ALIAS"
-keyalg RSA -validity "$KS_VALIDITY" -dname
cn="$CN",ou="cloudstack",o="cloudstack",c="cloudstack" -keystore "$KS_FILE" >
/dev/null 2>&1
-# Generate CSR
-rm -f "$CSR_FILE"
-addresses=$(ip address | grep inet | awk '{print $2}' | sed 's/\/.*//g' | grep
-v '^169.254.' | grep -v '^127.0.0.1' | grep -v '^::1' | sed 's/^/ip:/g' | tr
'\r\n' ',')
-keytool -certreq -storepass "$KS_PASS" -alias "$ALIAS" -file $CSR_FILE
-keystore "$KS_FILE" -ext san="$addresses" > /dev/null 2>&1
-cat "$CSR_FILE"
+# Generate CSR
+rm -f "$CSR_FILE"
+addresses=$(ip address | grep inet | awk '{print $2}' | sed 's/\/.*//g' |
grep -v '^169.254.' | grep -v '^127.0.0.1' | grep -v '^::1' | sed 's/^/ip:/g' |
tr '\r\n' ',')
+keytool -certreq -storepass "$KS_PASS" -alias "$ALIAS" -file $CSR_FILE
-keystore "$KS_FILE" -ext san="$addresses" > /dev/null 2>&1
+cat "$CSR_FILE"
Review comment:
This does not generate a CSR file, we'll need to add an else block to handle
if keystore already exists; per the renewal CSR must be regenerated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3364: LDAP users with similar permissions do not see each other's networks
PaulAngus commented on issue #3364: LDAP users with similar permissions do not see each other's networks URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-499008220 Is the other network visible through the API (when you use listall=true) ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project
ustcweizhou commented on issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project URL: https://github.com/apache/cloudstack/issues/3375#issuecomment-499008012 @PaulAngus can this be fixed by #3306 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499019433 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3195: Python 3 compatibility
PaulAngus commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-499026614 There are also knock-on effects, ie I suspect that the chances of running Python3 on XenServer 6.x is near zero. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] wido commented on issue #3195: Python 3 compatibility
wido commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-499014403 Although I agree with @rhtyd that a lot can be done in Java, it's not always the easiest. Python is sometimes a lot easier to develop and talk directly with the system for executing commands. We haven't started on this @falcon78921 , but any help is welcome! Just pick a Python script and start working on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3376: [4.11] Smoketest Health Check
rhtyd commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499019130 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499018682 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] wido commented on issue #3195: Python 3 compatibility
wido commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-499021289 @rhtyd Python 3 is available on ALL distros. It has been for a very long time. It's on RHEL, CentOS, Debian and Ubuntu. No need to install anything :) We can always talk about this, but the fact is that per January Python 2 is EOL and it's not so super difficult to write things in Python 3. I'm not against an Agent in the VR for example, sounds like a good thing! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3376: [4.11] Smoketest Health Check
rhtyd opened a new pull request #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376 Dummy PR just to kick smoketests on 4.11 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499009203 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499020476 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499020707 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2913: Deactivate ehcache
rhtyd commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-499037189 All in agreement, let's merge this! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #2913: Deactivate ehcache
rhtyd merged pull request #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: deactivate ehcache (#2913)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c5f0844 server: deactivate ehcache (#2913) c5f0844 is described below commit c5f0844f804c5ac1da6e5802013fcb6513b4084d Author: Marc-Aurèle Brothier AuthorDate: Wed Jun 5 12:58:18 2019 +0200 server: deactivate ehcache (#2913) This PR is for deactivating Ehcache in CloudStack since it is not usable. The first commit remove the default RMI cache peering configured for multicast which most of the time cannot work. It also requires to have an interface up which is not always the case while developing offline. The second commits remove the configuration to activate caching on some DAOs. Problems The code in CS does not seem to fit any caching mechanism especially due to the homemade DAO code. The main 3 flaws are the following: Entities are not expected to be shared There is quite a lot of code with method calls passing entity IDs value as long, which does some object fetching. Without caching, this behavior will create distinct objects each time an entity with the same ID is fetched. With the cache enabled, the same object will be shared among those methods. It has been seen that it does generate some side effects where code still expected unchanged entity attributes after calling different methods thus generating exception/bugs. DAO update operations are using search queries Some part of the code are updating entities based on a search query, therefore the whole cache must be invalidated (see GenericDaoBase: public int update(UpdateBuilder ub, final SearchCriteria sc, Integer rows);). Entities based on views joining multiple tables There are quite a lot of entities based on SQL views joining multiple entities in a same object. Enabling caching on those would require a mechanism to link and cross-remove related objects whenever one of the sub-entity is changed. Final word Based on the previously discussed points, the best approach IMHO would be to move out of the custom DAO framework in CS and use a well known one (out of scope of this change of course). It will handle caching well and the joins made by the views in the code. It's not an easy change, but it will fix along a lot of issues and add a proven / robust framework to an important part of the code. --- client/conf/ehcache.xml.in | 11 --- .../spring-engine-schema-core-daos-context.xml | 92 +++--- 2 files changed, 9 insertions(+), 94 deletions(-) diff --git a/client/conf/ehcache.xml.in b/client/conf/ehcache.xml.in index 19bfd0f..4f25978 100755 --- a/client/conf/ehcache.xml.in +++ b/client/conf/ehcache.xml.in @@ -163,14 +163,6 @@ under the License. used. --> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + +
[GitHub] [cloudstack] PaulAngus opened a new issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project
PaulAngus opened a new issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project URL: https://github.com/apache/cloudstack/issues/3375 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY listProjects API command returns same tags as many times as there are accounts in the Project # STEPS TO REPRODUCE ~~~ Create a project with n accounts in it (where n is more than 1) Add some tags with any values View the project's tags via UI or listProjects API (as an account in that project) ~~~ # EXPECTED RESULTS ~~~ The user/admin should see each tag/value combination once ~~~ # ACTUAL RESULTS ~~~ Each tag/value combination is returned n times (where n is the number of accounts in the project). ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499006631 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499008830 Okay @ustcweizhou, I'll try again: https://github.com/shapeblue/Trillian/commit/2f53242aeb9c8e2926b8ef129b6754e5348edc97 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus edited a comment on issue #3364: LDAP users with similar permissions do not see each other's networks
PaulAngus edited a comment on issue #3364: LDAP users with similar permissions do not see each other's networks URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-499008220 Is the other network visible through the API (when you use listall=true) ? and can the 'Real' root admin account see them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3195: Python 3 compatibility
rhtyd commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-499020206 @wido changing the env dependency is a big step, python3.x is not available on all distros by default. I think it's better to discuss on dev@ for future steps. In my proposal, for the VR for example I've proposed that we move to a lightweight agent and as PoC I've shared a Go-Java approach based on grpc. I think the best time would be to discuss/start doing things after 4.13, as we've decided to deprecate CentOS6 after 4.13. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499019851 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
rhtyd commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499036565 @nvazquez LGTM, I reviewed and fixed few issues around certificate renewal @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499036623 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland edited a comment on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499041866 Yes, @svanharmelen. I agree a real live environment behaves different, but the premise is that adding a static NAT address to an unimplemented network would not work anyway as the IP would be used for source-NAT. Hence the solution in #3125 containing the line https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java#L1433 . It may be that this fix would have only be needed on some hypervisors/network configurations in which case it is only half a fix. Updating offerings is a poor solution as you say, unless we do it in an automated way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499042242 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new issue #3377: project tags test fails in all travis runs
DaanHoogland opened a new issue #3377: project tags test fails in all travis runs URL: https://github.com/apache/cloudstack/issues/3377 test_15_project_tag in component/test_tags fails consistently in travis jobv 17 # ISSUE TYPE * Bug Report * Other - test failure # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE go to the travis test job page and then to job 17. restart it if needed. ~~~ ~~~ # EXPECTED RESULTS job passes ~~~ ~~~ # ACTUAL RESULTS the mentioned test lists tags which return NONE insted of the epected list of one. ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499050230 @ustcweizhou , I am not sure. Would it make sense to ever set it to true? usually the source nat address is the one automatically added. Not sure if the use-case where the next one is specifically for source nat as well is really useful. I have been thinking about this kind of solution as well. Of course we then need to handle the value as well; This is somewhat I meant with "refactoring the way IpAddressManager works". Another solution I was thinking of is to check whether there already is an address on the interface and first add an extra one if there is non yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499041866 Yes, @svanharmelen. I agree a real live environment behaves different, but the premise is that adding a static NAT address to an unimplemented network would not work anyway as the IP would be used for source-NAT. Hence the solution in #3125 containing the line https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java#L1433 . It may be that this fix would have only be needed on some hypervisors/network configurations in which case it is only half a fix. Updating offerings is a porr solution as you say, unless we do it in an automated way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
rhtyd commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499043153 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499043263 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
ustcweizhou commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499044707 @DaanHoogland if we add a new parameter issourcenat in AssociateIPAddrCmd to indicate whether the ip is used for source nat (default value is false), will the issue be solved ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3323: User allowed to tag project created by him
DaanHoogland commented on issue #3323: User allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3323#issuecomment-499044493 It seems this causes #3377 . we may have to revert :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499052571 > Another solution I was thinking of is to check whether there already is an address on the interface and first add an extra one if there is none yet. That could also work. In the Terraform network resource I added a [source_nat_ip](https://github.com/terraform-providers/terraform-provider-cloudstack/blob/master/cloudstack/resource_cloudstack_network.go#L115) option that adds the NAT IP right after creating the network. This abstracts the problem for our users a little, but now fails with 4.12.x.x This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499073936 @svenvogel have patience please, a typical test takes 6-10hours to complete. What I can confirm is that initial deployment seems to be working. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499038556 @DaanHoogland as already mentioned, option 1 works and allows me to test all the logic using the simulator. So that is good news! But my remaining issue (worry) is that when people are using the updated code against a real environment they will encounter the same issue. And then asking everyone to update their network offerings seems like as poor solution for them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland edited a comment on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499050230 @ustcweizhou , I am not sure. Would it make sense to ever set it to true? usually the source nat address is the one automatically added. Not sure if the use-case where the next one is specifically for source nat as well is really useful. I have been thinking about this kind of solution as well. Of course we then need to handle the value as well; This is somewhat I meant with "refactoring the way IpAddressManager works". Another solution I was thinking of is to check whether there already is an address on the interface and first add an extra one if there is none yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3377: project tags test fails in all travis runs
ustcweizhou commented on issue #3377: project tags test fails in all travis runs
URL: https://github.com/apache/cloudstack/issues/3377#issuecomment-499056300
@DaanHoogland
in test_tags.py, projectid needs to be added.
```
diff --git a/test/integration/component/test_tags.py
b/test/integration/component/test_tags.py
index 9180e7b..be4c6e2 100644
--- a/test/integration/component/test_tags.py
+++ b/test/integration/component/test_tags.py
@@ -1756,6 +1756,7 @@ class TestResourceTags(cloudstackTestCase):
listall=True,
resourceType='project',
resourceIds=project.id,
+projectid=project.id,
key=tag_key,
)
self.debug("tags = %s" % tags)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499068119 @rhtyd are the checks ok now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] wido commented on issue #3195: Python 3 compatibility
wido commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-499069461 @PaulAngus Python 2 is EOL in 2020, so any plans on what Xen is going to do? But this doesn't stop us to fix other Python code before that time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3365: KVM: DPDK live migrations
borisstoyanov commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-499070913 @nvazquez can you address the merge conflicts pls. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: storage: post process locally uploaded multi-disk ova template (#3215)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new bbc0ae8 storage: post process locally uploaded multi-disk ova
template (#3215)
bbc0ae8 is described below
commit bbc0ae873d5a2cb94b5adafb326c836513175203
Author: Rohit Yadav
AuthorDate: Wed Jun 5 23:07:40 2019 +0530
storage: post process locally uploaded multi-disk ova template (#3215)
Problem: When a multi-disk OVA template is uploaded, only the root disk is
recognized and VMs deployed using such template only get the root disk
provisioned.
Root Cause: The template processor for multi-disk OVA was not used in the
template upload processor.
Solution: Added support for local multi-disk OVA template upload. After a
multi-disk OVA template is
uploaded, the mechanism that worked on multi-disk OVA templates registered
using URL is now also used to discovers and creates data-disk templates in
cloud.vm_template table and on the secondary storage.
To enable SSL on SSVMs :
• Upload the certificates like you usually do via the API or
UI->Infrastructure tab
• Set the global settings secstorage.encrypt.copy,
secstorage.ssl.cert.domain to appropriate values
along with the CPVM ones
• Restart management server (no need to destroy/restart SSVM (or the ssvm
agent))
Test cases:
- Upload template and check it creates multi-disk folders on secondary
storage and entries in cloud.vm_template table
- Upload template and kill/shutdown management server. Then restart MS
to check if template sync works
- Copy template across zone of an uploaded template
Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com
---
.../subsystem/api/storage/TemplateService.java | 2 ++
.../storage/image/TemplateServiceImpl.java | 15 +++---
.../datastore/ObjectInDataStoreManagerImpl.java| 1 +
.../cloud/storage/ImageStoreUploadMonitorImpl.java | 35 ++
4 files changed, 43 insertions(+), 10 deletions(-)
diff --git
a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java
b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java
index fc8a769..f70a781 100644
---
a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java
+++
b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java
@@ -47,6 +47,8 @@ public interface TemplateService {
AsyncCallFuture
createTemplateFromVolumeAsync(VolumeInfo volume, TemplateInfo template,
DataStore store);
+boolean createOvaDataDiskTemplates(TemplateInfo parentTemplate);
+
AsyncCallFuture deleteTemplateAsync(TemplateInfo
template);
AsyncCallFuture copyTemplate(TemplateInfo srcTemplate,
DataStore destStore);
diff --git
a/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
b/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
index 45e3941..097b854 100644
---
a/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
+++
b/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
@@ -409,8 +409,15 @@ public class TemplateServiceImpl implements
TemplateService {
_templateDao.update(tmplt.getId(), tmlpt);
if (tmplt.getState() ==
VirtualMachineTemplate.State.NotUploaded || tmplt.getState() ==
VirtualMachineTemplate.State.UploadInProgress) {
+VirtualMachineTemplate.Event event =
VirtualMachineTemplate.Event.OperationSucceeded;
+// For multi-disk OVA, check and
create data disk templates
+if
(tmplt.getFormat().equals(ImageFormat.OVA)) {
+if
(!createOvaDataDiskTemplates(_templateFactory.getTemplate(tmlpt.getId(),
store))) {
+event =
VirtualMachineTemplate.Event.OperationFailed;
+}
+}
try {
-stateMachine.transitTo(tmplt,
VirtualMachineTemplate.Event.OperationSucceeded, null, _templateDao);
+stateMachine.transitTo(tmplt,
event, null, _templateDao);
} catch (NoTransitionException e) {
s_logger.error("Unexpected state
transition exception for template " + tmplt.getName() + ". Details: " +
[GitHub] [cloudstack] rhtyd merged pull request #3215: [WIP DO NOT MERGE] storage: post process locally uploaded multi-disk ova template
rhtyd merged pull request #3215: [WIP DO NOT MERGE] storage: post process locally uploaded multi-disk ova template URL: https://github.com/apache/cloudstack/pull/3215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499129265 Trillian test result (tid-3647) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 17483 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3376-t3647-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 48 look OK, 21 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=Test03SecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.18 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.18 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.37 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.10 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.25 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals | `Failure`
[GitHub] [cloudstack] rhtyd commented on issue #3376: [4.11] Smoketest Health Check
rhtyd commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499129588 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3376: [4.11] Smoketest Health Check
blueorangutan removed a comment on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499129265 Trillian test result (tid-3647) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 17483 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3376-t3647-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 48 look OK, 21 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=Test03SecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.18 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.18 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.37 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.10 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.25 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals |
[GitHub] [cloudstack] PaulAngus commented on issue #3215: [WIP DO NOT MERGE] storage: post process locally uploaded multi-disk ova template
PaulAngus commented on issue #3215: [WIP DO NOT MERGE] storage: post process locally uploaded multi-disk ova template URL: https://github.com/apache/cloudstack/pull/3215#issuecomment-499137953 LGTM - tested with a centos template with 1 data disk and a Windows template with 1 data disk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (bbc0ae8 -> 7247c5e)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from bbc0ae8 storage: post process locally uploaded multi-disk ova
template (#3215)
add 7247c5e server: add local ISO upload via UI (#3251)
No new revisions were added by this update.
Summary of changes:
.../com/cloud/template/TemplateApiService.java | 5 +-
.../command/user/iso/GetUploadParamsForIsoCmd.java | 158 ++
.../manager/BareMetalTemplateAdapter.java | 6 +
.../com/cloud/server/ManagementServerImpl.java | 2 +
.../upload/params/IsoUploadParams.java}| 25 +--
.../upload/params/TemplateUploadParams.java| 38
.../cloud/storage/upload/params/UploadParams.java | 62 +++---
.../storage/upload/params/UploadParamsBase.java| 240 +
.../cloud/template/HypervisorTemplateAdapter.java | 10 +
.../java/com/cloud/template/TemplateAdapter.java | 25 ++-
.../com/cloud/template/TemplateAdapterBase.java| 55 +++--
.../com/cloud/template/TemplateManagerImpl.java| 29 ++-
ui/l10n/en.js | 1 +
ui/l10n/es.js | 1 +
ui/scripts/templates.js| 174 +++
ui/scripts/ui/dialog.js| 17 +-
16 files changed, 764 insertions(+), 84 deletions(-)
create mode 100644
api/src/main/java/org/apache/cloudstack/api/command/user/iso/GetUploadParamsForIsoCmd.java
copy
server/src/main/java/com/cloud/{hypervisor/kvm/discoverer/KvmServerDiscoverer.java
=> storage/upload/params/IsoUploadParams.java} (56%)
create mode 100644
server/src/main/java/com/cloud/storage/upload/params/TemplateUploadParams.java
copy api/src/main/java/com/cloud/projects/Project.java =>
server/src/main/java/com/cloud/storage/upload/params/UploadParams.java (52%)
create mode 100644
server/src/main/java/com/cloud/storage/upload/params/UploadParamsBase.java
[GitHub] [cloudstack] rhtyd merged pull request #3251: Add local ISO upload via UI
rhtyd merged pull request #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3251: Add local ISO upload via UI
rhtyd commented on issue #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-499183816 Merging based on last smoketests and reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley opened a new issue #3379: SRX Plugin Cannot add Port Forwarding Rule
richardlawley opened a new issue #3379: SRX Plugin Cannot add Port Forwarding Rule URL: https://github.com/apache/cloudstack/issues/3379 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ SRX Plugin ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2 ~~~ # CONFIGURATION Advanced Networking # OS / ENVIRONMENT Model: srx345-dual-ac Junos: 15.1X49-D110.4 JUNOS Software Release [15.1X49-D110.4] # SUMMARY When trying to add a port forwarding rule, it fails with a syntax error. If this ever worked, then I suspect the syntax of the API command has changed since JunOS 10, which from the hardware compatibility list may be what worked. # STEPS TO REPRODUCE Add a port forwarding rule # EXPECTED RESULTS Port Forwarding rule should be added, creating a destination nat rule on the SRX # ACTUAL RESULTS ~~~ 2019-06-05 16:44:44,452 DEBUG [c.c.n.r.JuniperSrxResource] (DirectAgent-287:ctx-8a4e6665) (logid:be9407ed) Sending request: untrust untrust destnatrule-1798423542 XX.XX.XX.XX (XX-XX-XX-XX..net)80 10-9-160-193-80
[GitHub] [cloudstack] richardlawley commented on issue #3379: SRX Plugin Cannot add Port Forwarding Rule
richardlawley commented on issue #3379: SRX Plugin Cannot add Port Forwarding Rule URL: https://github.com/apache/cloudstack/issues/3379#issuecomment-499187289 I will attempt to fix this, hopefully in time for 4.11.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499222382 Trillian test result (tid-3650) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27669 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3075-t3650-kvm-centos7.zip Smoke tests completed. 69 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499236228 Trillian test result (tid-3649) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34385 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3371-t3649-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermittent failure detected: /marvin/tests/smoke/test_async_job.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py Intermittent failure detected: /marvin/tests/smoke/test_network.py Intermittent failure detected: /marvin/tests/smoke/test_password_server.py Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_projects.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 33 look OK, 38 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py test_DeleteDomain | `Error` | 1.66 | test_accounts.py test_forceDeleteDomain | `Error` | 1.72 | test_accounts.py ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 6.08 | test_accounts.py ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1593.91 | test_accounts.py ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_query_async_job_result | `Error` | 0.00 | test_async_job.py test_01_create_iso_with_checksum_sha1 | `Error` | 5.34 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 5.20 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 5.18 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 5.21 | test_iso.py test_01_create_iso | `Failure` | 1515.93 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3033.18 | test_iso.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py test_list_vms_metrics | `Error` | 0.21 | test_metrics_api.py
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499129778 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3365: KVM: DPDK live migrations
borisstoyanov commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-499355357 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: KVM: DPDK live migrations
blueorangutan commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-499359837 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3378: project id added in test
ustcweizhou commented on issue #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#issuecomment-499244966 I saved test_15_project_tag in a seperated python file, and run it in marvin test it failed without this change, and succeed with this change. so this is ok for me. @DaanHoogland @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499250758 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499245932 @rhtyd it still failed. might qemu-img not be installed ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499325867 Trillian test result (tid-3653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38652 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3376-t3653-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 68 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 425.64 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 450.88 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3376: [4.11] Smoketest Health Check
nvazquez commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499243603 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499243987 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley commented on issue #3379: SRX Plugin Cannot add Port Forwarding Rule
richardlawley commented on issue #3379: SRX Plugin Cannot add Port Forwarding Rule URL: https://github.com/apache/cloudstack/issues/3379#issuecomment-499254029 This was fixable by changing the script template at `scripts/network/juniper/dest-nat-rule-add.xml` - replacing with . Before submitting this as a PR, I would welcome thoughts on whether this is ever likely to have worked in the past - if so it may turn out that the fix for more modern JunOS breaks older versions. However, the version on the supported hardware list (JunOS 10) went EOL in 2014. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez merged pull request #3075: KVM: Prevent regenerating keystore on provisionCertificate API
nvazquez merged pull request #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: KVM: Prevent regenerating keystore on provisionCertificate API (#3075)
This is an automated email from the ASF dual-hosted git repository.
nvazquez pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new d108f32 KVM: Prevent regenerating keystore on provisionCertificate
API (#3075)
d108f32 is described below
commit d108f322e382e6d20673b2d6122271bd3a6bba2d
Author: Nicolas Vazquez
AuthorDate: Wed Jun 5 17:29:31 2019 -0300
KVM: Prevent regenerating keystore on provisionCertificate API (#3075)
* Prevent regenerating keystore and add background task to upload
certificates
* Remove background task to upload certificates
* keystore-setup: delete old key in jks
Signed-off-by: Rohit Yadav
* also don't allow ca-cert alias
Signed-off-by: Rohit Yadav
---
...UploadTemplateDirectDownloadCertificateCmd.java | 9 ++---
scripts/util/keystore-cert-import | 23 +-
scripts/util/keystore-setup| 8 +---
.../direct/download/DirectDownloadManagerImpl.java | 20 +--
4 files changed, 30 insertions(+), 30 deletions(-)
diff --git
a/api/src/org/apache/cloudstack/api/command/admin/direct/download/UploadTemplateDirectDownloadCertificateCmd.java
b/api/src/org/apache/cloudstack/api/command/admin/direct/download/UploadTemplateDirectDownloadCertificateCmd.java
index 416d264..c93fca2 100755
---
a/api/src/org/apache/cloudstack/api/command/admin/direct/download/UploadTemplateDirectDownloadCertificateCmd.java
+++
b/api/src/org/apache/cloudstack/api/command/admin/direct/download/UploadTemplateDirectDownloadCertificateCmd.java
@@ -16,11 +16,6 @@
// under the License.
package org.apache.cloudstack.api.command.admin.direct.download;
-import com.cloud.exception.ConcurrentOperationException;
-import com.cloud.exception.InsufficientCapacityException;
-import com.cloud.exception.ResourceAllocationException;
-import com.cloud.exception.ResourceUnavailableException;
-import com.cloud.exception.NetworkRuleConflictException;
import org.apache.cloudstack.acl.RoleType;
import org.apache.cloudstack.api.APICommand;
import org.apache.cloudstack.api.ApiConstants;
@@ -62,15 +57,15 @@ public class UploadTemplateDirectDownloadCertificateCmd
extends BaseCmd {
private String hypervisor;
@Override
-public void execute() throws ResourceUnavailableException,
InsufficientCapacityException, ServerApiException,
ConcurrentOperationException, ResourceAllocationException,
NetworkRuleConflictException {
+public void execute() {
if (!hypervisor.equalsIgnoreCase("kvm")) {
throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Currently
supporting KVM hosts only");
}
-SuccessResponse response = new SuccessResponse(getCommandName());
try {
LOG.debug("Uploading certificate " + name + " to agents for Direct
Download");
boolean result =
directDownloadManager.uploadCertificateToHosts(certificate, name, hypervisor);
+SuccessResponse response = new SuccessResponse(getCommandName());
response.setSuccess(result);
setResponseObject(response);
} catch (Exception e) {
diff --git a/scripts/util/keystore-cert-import
b/scripts/util/keystore-cert-import
index 424ab4a..459f836 100755
--- a/scripts/util/keystore-cert-import
+++ b/scripts/util/keystore-cert-import
@@ -38,9 +38,6 @@ if [ -z "${KS_PASS// }" ]; then
exit 1
fi
-# Use a new keystore file
-NEW_KS_FILE="$KS_FILE.new"
-
# Import certificate
if [ ! -z "${CERT// }" ]; then
echo "$CERT" > "$CERT_FILE"
@@ -54,8 +51,8 @@ fi
# Import cacerts into the keystore
awk '/-BEGIN CERTIFICATE-?/{n++}{print > "cloudca." n }' "$CACERT_FILE"
for caChain in $(ls cloudca.*); do
-keytool -delete -noprompt -alias "$caChain" -keystore "$NEW_KS_FILE"
-storepass "$KS_PASS" > /dev/null 2>&1 || true
-keytool -import -noprompt -storepass "$KS_PASS" -trustcacerts -alias
"$caChain" -file "$caChain" -keystore "$NEW_KS_FILE" > /dev/null 2>&1
+keytool -delete -noprompt -alias "$caChain" -keystore "$KS_FILE"
-storepass "$KS_PASS" > /dev/null 2>&1 || true
+keytool -import -noprompt -storepass "$KS_PASS" -trustcacerts -alias
"$caChain" -file "$caChain" -keystore "$KS_FILE" > /dev/null 2>&1
done
rm -f cloudca.*
@@ -63,21 +60,19 @@ rm -f cloudca.*
if [ ! -z "${PRIVKEY// }" ]; then
echo "$PRIVKEY" > "$PRIVKEY_FILE"
# Re-initialize keystore when private key is provided
-keytool -delete -noprompt -alias "$ALIAS" -keystore "$NEW_KS_FILE"
-storepass "$KS_PASS" 2>/dev/null || true
-openssl pkcs12 -export -name "$ALIAS" -in "$CERT_FILE" -inkey
"$PRIVKEY_FILE" -out "$NEW_KS_FILE.p12" -password pass:"$KS_PASS" > /dev/null
2>&1
-keytool -importkeystore -srckeystore "$NEW_KS_FILE.p12" -destkeystore
"$NEW_KS_FILE" -srcstoretype PKCS12 -alias "$ALIAS"
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499243101 Trillian test result (tid-3646) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36194 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3376-t3646-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Smoke tests completed. 68 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Error` | 25.74 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
nvazquez commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-499242616 Thanks for the last fix @rhtyd Merging after test results and reviews This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499261332 Trillian test result (tid-3648) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39592 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3376-t3648-vmware-65u2.zip Smoke tests completed. 69 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: KVM: DPDK live migrations
blueorangutan commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-49933 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499102726 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: added missing hypervisor options for upload template (#3367)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new f7af27c ui: added missing hypervisor options for upload template
(#3367)
f7af27c is described below
commit f7af27c3c87442e3a0df0f91e36d03c316434078
Author: Abhishek Kumar
AuthorDate: Wed Jun 5 18:44:37 2019 +0530
ui: added missing hypervisor options for upload template (#3367)
Upload template form was missing some hypervisor specific options which can
be seen on Register template form.
For XenServer, XenServer tool version added
For VMware, Root disk controller, NIC adapter type, Keyboard type added and
HVM is hidden
For KVM, Root disk controller added
Fixes #3363
Signed-off-by: Abhishek Kumar
---
ui/scripts/templates.js | 273
1 file changed, 250 insertions(+), 23 deletions(-)
diff --git a/ui/scripts/templates.js b/ui/scripts/templates.js
index f3bed8b..43b83b2 100755
--- a/ui/scripts/templates.js
+++ b/ui/scripts/templates.js
@@ -296,21 +296,8 @@
}
},
-// For KVM only: Direct Download
-directdownload : {
-label: 'label.direct.download',
-docID:
'helpRegisterTemplateDirectDownload',
-isBoolean: true,
-dependsOn: 'hypervisor',
-isHidden: true
-},
-checksum: {
-label: 'label.checksum',
-dependsOn: 'directdownload',
-isHidden: true
-},
-// Direct Download - End
+// fields for hypervisor == XenServer
(starts here)
xenserverToolsVersion61plus: {
label:
'label.xenserver.tools.version.61.plus',
isBoolean: true,
@@ -334,8 +321,23 @@
},
isHidden: true
},
+// fields for hypervisor == XenServer
(ends here)
-//fields for hypervisor == "KVM" (starts
here)
+// fields for hypervisor == "KVM" (starts
here)
+// Direct Download
+directdownload : {
+label: 'label.direct.download',
+docID:
'helpRegisterTemplateDirectDownload',
+isBoolean: true,
+dependsOn: 'hypervisor',
+isHidden: true
+},
+checksum: {
+label: 'label.checksum',
+dependsOn: 'directdownload',
+isHidden: true
+},
+// Direct Download - End
rootDiskControllerTypeKVM: {
label: 'label.root.disk.controller',
isHidden: true,
@@ -366,8 +368,9 @@
});
}
},
+// fields for hypervisor == "KVM" (ends
here)
-//fields for hypervisor == "VMware"
(starts here)
+// fields for hypervisor == "VMware"
(starts here)
rootDiskControllerType: {
label: 'label.root.disk.controller',
isHidden: true,
@@ -460,7 +463,7 @@
});
}
},
-//fields for hypervisor == "VMware" (ends
here)
+// fields for hypervisor == "VMware" (ends
here)
format: {
label: 'label.format',
@@ -641,15 +644,15 @@
[GitHub] [cloudstack] rhtyd closed issue #3363: Upload template from local does not allow/show various fields/options for VMware
rhtyd closed issue #3363: Upload template from local does not allow/show various fields/options for VMware URL: https://github.com/apache/cloudstack/issues/3363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3367: ui: added missing hypervisor options for upload template
rhtyd commented on issue #3367: ui: added missing hypervisor options for upload template URL: https://github.com/apache/cloudstack/pull/3367#issuecomment-499077879 Purely JS/UI change, merged based on screenshots and reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3367: ui: added missing hypervisor options for upload template
rhtyd merged pull request #3367: ui: added missing hypervisor options for upload template URL: https://github.com/apache/cloudstack/pull/3367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3365: KVM: DPDK live migrations
nvazquez commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-499081443 Sure done @borisstoyanov This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. The global settings are just used to check if there is already an offering with the given id existing in the database. There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced. There is no need for a migration path with this PR. There will be no changes which will break existing functionality. After my analysis the global default settings is doing close to nothing in the current state of the software and we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. https://github.com/apache/cloudstack/blob/f7af27c3c87442e3a0df0f91e36d03c316434078/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java#L1302-L1330 The global settings are just used to check if there is already an offering with the given id existing in the database. There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced. There is no need for a migration path with this PR. There will be no changes which will break existing functionality. After my analysis the global default settings is doing close to nothing in the current state of the software and we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-499094224 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. https://github.com/apache/cloudstack/blob/f7af27c3c87442e3a0df0f91e36d03c316434078/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java#L1302-L1330 The global settings are just used to check if there is already an offering with the given "id/uuid" existing in the database.  There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced. There is no need for a migration path with this PR. There will be no changes which will break existing functionality. After my analysis the global default settings is doing close to nothing in the current state of the software and we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. https://github.com/apache/cloudstack/blob/f7af27c3c87442e3a0df0f91e36d03c316434078/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java#L1302-L1330 The global settings are just used to check if there is already an offering with the given "ID/UUID" existing in the database. (please look the picture below)  **There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced.** There is no need for a migration path with this PR. There will be no changes which will break existing functionality. 1. users using this global settings will not be impacted by this changes because they do not set a default offering 2. its now possible to set default offering over the UI/API instead of manipulating the database directly for SSVM, CSVM, LB and VR  After my analysis the global default settings is doing close to nothing in the current state of the software and we can remove them and set this PR to the "standard". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3195: Python 3 compatibility
rhtyd commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-499082479 I think we'll need to deprecate all the XS 6.x, which we can discuss and aim to do in 4.14 and onwards. XS7 or xcp-ng 7.x with CentOS7 based dom0 may be more easy to support python3. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch DaanHoogland-patch-2 created (now 10a29c5)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 10a29c5 project id added in test This branch includes the following new commits: new 10a29c5 project id added in test The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3378: project id added in test
DaanHoogland opened a new pull request #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378 as per @ustcweizhou's comment: https://github.com/apache/cloudstack/issues/3377#issuecomment-499056300 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: project id added in test
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch DaanHoogland-patch-2
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 10a29c5d0735409ce793ad628ce7b7017410aa14
Author: dahn
AuthorDate: Wed Jun 5 15:38:17 2019 +0200
project id added in test
as per @ustcweizhou's comment:
https://github.com/apache/cloudstack/issues/3377#issuecomment-499056300
---
test/integration/component/test_tags.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/integration/component/test_tags.py
b/test/integration/component/test_tags.py
index 9180e7b..be4c6e2 100644
--- a/test/integration/component/test_tags.py
+++ b/test/integration/component/test_tags.py
@@ -1756,6 +1756,7 @@ class TestResourceTags(cloudstackTestCase):
listall=True,
resourceType='project',
resourceIds=project.id,
+projectid=project.id,
key=tag_key,
)
self.debug("tags = %s" % tags)
[GitHub] [cloudstack] rhtyd closed pull request #3376: [4.11] Smoketest Health Check
rhtyd closed pull request #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3376: [4.11] Smoketest Health Check
rhtyd opened a new pull request #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376 Dummy PR just to kick smoketests on 4.11 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. https://github.com/apache/cloudstack/blob/f7af27c3c87442e3a0df0f91e36d03c316434078/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java#L1302-L1330 The global settings are just used to check if there is already an offering with the given "id/uuid" existing in the database.  **There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced.** There is no need for a migration path with this PR. There will be no changes which will break existing functionality. After my analysis the global default settings is doing close to nothing in the current state of the software and we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. https://github.com/apache/cloudstack/blob/f7af27c3c87442e3a0df0f91e36d03c316434078/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java#L1302-L1330 The global settings are just used to check if there is already an offering with the given "id/uuid" existing in the database. (please look the picture below)  **There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced.** There is no need for a migration path with this PR. There will be no changes which will break existing functionality. 1. users using this global settings will not be impacted by this changes because they do not set a default offering 2. its now possible to set default offering over the UI/API instead of manipulating the database directly for SSVM, CSVM, LB and VR  After my analysis the global default settings is doing close to nothing in the current state of the software and we can remove them and set this PR to the "standard". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
