[GitHub] [cloudstack] borisstoyanov commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
borisstoyanov commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-503902682 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-503902874 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3410: Add Datera storage plugin
rhtyd commented on issue #3410: Add Datera storage plugin URL: https://github.com/apache/cloudstack/pull/3410#issuecomment-503910212 @swill it depends. Is this PR code complete and ready for review. If this is ready for review we can kick regression smoke tests and merge this on master as soon as this meets our merging guideline (2 lgtms, no regressions). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-503891527 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-503941861 Last change is UI only change to show all possible drop down options while editing an existing detail. No smoketests needed.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-documentation] 01/01: usage: update usage docs wrt description format changes to use UUIDs
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch usage-format-docs-fix in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit 83bb1beb3dc9c6416c46b5769b93de1c1b637395 Author: Rohit Yadav AuthorDate: Thu Jun 20 14:48:13 2019 +0530 usage: update usage docs wrt description format changes to use UUIDs Signed-off-by: Rohit Yadav --- source/adminguide/usage.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source/adminguide/usage.rst b/source/adminguide/usage.rst index 3e05ed8..654faea 100644 --- a/source/adminguide/usage.rst +++ b/source/adminguide/usage.rst @@ -22,7 +22,11 @@ The Usage Server is an optional, separately-installed part of CloudStack that provides aggregated usage records which you can use to create billing integration for CloudStack. The Usage Server works by taking data from the events log and creating summary usage records that you can -access using the listUsageRecords API call. +access using the listUsageRecords API call. Starting version 4.13 and above, +the usage records description returned by the listUsageRecords API call +will use CloudStack resource UUIDs instead of internal database IDs. To get +description in the old format, an API parameter "oldformat" is introduced +which is false by default. The usage records show the amount of resources, such as VM run time or template storage space, consumed by guest instances.
[cloudstack-documentation] branch usage-format-docs-fix created (now 83bb1be)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch usage-format-docs-fix in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at 83bb1be usage: update usage docs wrt description format changes to use UUIDs This branch includes the following new commits: new 83bb1be usage: update usage docs wrt description format changes to use UUIDs The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [cloudstack] rhtyd commented on issue #3268: Support sort_key for vpc_offerings table
rhtyd commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-503955242 @anuragaw fixed conflict, fyi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-503974205 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-2908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.12'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit c2812b4675bacdbed63b17fff138d0c5605de0c3 Merge: 90cd8aa 3c431bb Author: Rohit Yadav AuthorDate: Thu Jun 20 14:34:38 2019 +0530 Merge remote-tracking branch 'origin/4.12' Signed-off-by: Rohit Yadav .gitignore | 1 + 1 file changed, 1 insertion(+) diff --cc .gitignore index 9ce1ff0,0e50a95..66ce1c2 --- a/.gitignore +++ b/.gitignore @@@ -101,4 -99,4 +101,5 @@@ scripts/.pydevprojec *.qcow2 *.raw venv +node_modules + .vscode
[cloudstack] branch master updated (90cd8aa -> c2812b4)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 90cd8aa server: add support for sorting zones in UI/API (#3242) add 3425506 .gitignore: add .vscode to ignore (#3384) add 3c431bb Merge remote-tracking branch 'origin/4.11' into 4.12 new c2812b4 Merge remote-tracking branch 'origin/4.12' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore | 1 + 1 file changed, 1 insertion(+)
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
rhtyd commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#discussion_r295715227 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java ## @@ -81,6 +82,10 @@ @Parameter(name = ApiConstants.INCLUDE_TAGS, type = CommandType.BOOLEAN, description = "Flag to enable display of Tags for a resource") private Boolean includeTags; +@Parameter(name = ApiConstants.OLD_FORMAT, type = CommandType.BOOLEAN, description = "Flag to enable description rendered in old format with no processing") Review comment: I'll update the docs. Will fix description. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
rhtyd commented on a change in pull request #3344: [WIP DO NOT MERGE] server:
return usage description with resource names and UUIDs
URL: https://github.com/apache/cloudstack/pull/3344#discussion_r295715023
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
##
@@ -145,6 +150,9 @@ public void setUsageId(String usageId) {
this.usageId = usageId;
}
+public boolean getOldFormat() {
+return oldFormat != null && oldFormat;
Review comment:
Will fix description.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-503950448 @DaanHoogland @andrijapanic I've sent the docs PR https://github.com/apache/cloudstack-documentation/pulls And updated the API doc description This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-cloudmonkey] branch master updated: cmd: fix bug around required params check
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git
The following commit(s) were added to refs/heads/master by this push:
new 365e10e cmd: fix bug around required params check
365e10e is described below
commit 365e10eae61f9135bf1a61aca4ce9087b2870e10
Author: Rohit Yadav
AuthorDate: Thu Jun 20 15:23:48 2019 +0530
cmd: fix bug around required params check
This fixes issue for map type of required parameters as seen in the
createTags API where previously an API request would fail when
tags[0]. was passed.
Signed-off-by: Rohit Yadav
---
cmd/api.go | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmd/api.go b/cmd/api.go
index b84f919..01ed2c3 100644
--- a/cmd/api.go
+++ b/cmd/api.go
@@ -60,6 +60,7 @@ func init() {
var missingArgs []string
for _, required := range api.RequiredArgs {
+ required = strings.ReplaceAll(required, "=", "")
provided := false
for _, arg := range apiArgs {
if strings.Contains(arg, "=") &&
strings.HasPrefix(arg, required) {
[cloudstack-documentation] 01/01: Merge pull request #47 from apache/usage-format-docs-fix
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit d82a72823463435b8de8a9bc0992f839d856a71f Merge: 16db7fa 83bb1be Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Thu Jun 20 13:22:18 2019 +0200 Merge pull request #47 from apache/usage-format-docs-fix usage: update usage docs wrt description format changes to use UUIDs source/adminguide/usage.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
[cloudstack-documentation] branch master updated (16db7fa -> d82a728)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 16db7fa Merge pull request #42 from shapeblue/fix_reported_errors add 83bb1be usage: update usage docs wrt description format changes to use UUIDs new d82a728 Merge pull request #47 from apache/usage-format-docs-fix The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: source/adminguide/usage.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] nvazquez commented on issue #3365: KVM: DPDK live migrations
nvazquez commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-503990002 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-503990105 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
rhtyd commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-503954231 @anuragaw can you fix the conflicts? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
anuragaw commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-503956037 Sure @rhtyd - there is some more work to be done and I'll rebase with new code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3268: Support sort_key for vpc_offerings table
anuragaw commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-503956317 Thank you @rhtyd ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature
rhtyd commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-503959055 Fixed merge conflict please check @nvazquez This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3234: [WIP DO NOT MERGE] api: Set network name as part of the network usage response
andrijapanicsb commented on issue #3234: [WIP DO NOT MERGE] api: Set network name as part of the network usage response URL: https://github.com/apache/cloudstack/pull/3234#issuecomment-503988900 I don't like the "name" being used. Why not "network", to be consistent with i.e. "project" and "projectid" or "domain" and "domainid" ? Can we please change it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-503990292 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: KVM: DPDK live migrations
blueorangutan commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-503990298 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11' into 4.12
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 3c431bb8e486fb3962223a9db2d48c4782cdfc3c Merge: ef1506b 3425506 Author: Rohit Yadav AuthorDate: Thu Jun 20 14:32:57 2019 +0530 Merge remote-tracking branch 'origin/4.11' into 4.12 .gitignore | 1 + 1 file changed, 1 insertion(+)
[cloudstack] branch 4.12 updated (ef1506b -> 3c431bb)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ef1506b Merge remote-tracking branch 'origin/4.11' into 4.12 add 3425506 .gitignore: add .vscode to ignore (#3384) new 3c431bb Merge remote-tracking branch 'origin/4.11' into 4.12 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore | 1 + 1 file changed, 1 insertion(+)
[GitHub] [cloudstack] rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-503954058 Fixed conflicts @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-503954069 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-503956886 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-503956691 Fixed merge conflict, please check @shwstppr @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3324: [WIP] Add Datera storage plugin
rhtyd commented on issue #3324: [WIP] Add Datera storage plugin URL: https://github.com/apache/cloudstack/pull/3324#issuecomment-503957017 Can we close this @jcsdatera @swill in favour of https://github.com/apache/cloudstack/pull/3410 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-503958494 Fixed merge conflict, please check @nvazquez - please also address outstanding issues and comments, thanks. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-503958647 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-503977397 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-503977398 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE]
server: return usage description with resource names and UUIDs
URL: https://github.com/apache/cloudstack/pull/3344#discussion_r295759813
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
##
@@ -145,6 +150,9 @@ public void setUsageId(String usageId) {
this.usageId = usageId;
}
+public boolean getOldFormat() {
+return oldFormat != null && oldFormat;
Review comment:
I agree that this default is sensible and I don't think the backwards
incompatibility of not using internal ids anymore is going to be very hurtful
as the processing of such ids is more intensive than processing uuids using the
api. maybe a point of discussion for some, so let's be extra cautious.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-504002292 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-504002232 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: KVM: DPDK live migrations
blueorangutan commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-504002336 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-504008279 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: KVM: DPDK live migrations
blueorangutan commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-504014787 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504001945 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3365: KVM: DPDK live migrations
nvazquez commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-504014484 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-504058755 Trillian test result (tid-3711) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26945 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3228-t3711-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Smoke tests completed. 71 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
andrijapanicsb commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-504103292 LGTM Possible consideration is the performance penalty due to API having to query the main "cloud" DB. If no crazy JOINs, than it should be fine. @rhtyd @DaanHoogland ^^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3402: VPC RVR: Delete first tier with Private GW - Both VRs become MASTER
rhtyd commented on issue #3402: VPC RVR: Delete first tier with Private GW - Both VRs become MASTER URL: https://github.com/apache/cloudstack/issues/3402#issuecomment-504114604 Related https://github.com/apache/cloudstack/pull/2128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3305: SSL SSVM not working when configured to use a URL instead of a domain
rhtyd commented on issue #3305: SSL SSVM not working when configured to use a URL instead of a domain URL: https://github.com/apache/cloudstack/issues/3305#issuecomment-504128371 The settings clearly ask to enter the domain and not the URL. @fpaillot you may use a service such as xip.io or sslip.io for dynamic resolution of domain-address. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
andrijapanicsb commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-504144559 Sounds good @rhtyd LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie opened a new pull request #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off
kioie opened a new pull request #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off URL: https://github.com/apache/cloudstack/pull/3412 ## Description This is a feature that allows end users to be able to change the hostname of their VM and the, if the vm.instancename.flag under the Global Settings is set to true ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate):  ## How Has This Been Tested? Changed the vm.instancename.flag under the Global Settings to false to see if the VM hostname would still change Changed the vm.instancename.flag under the Global Settings to true to see if the VM hostname would change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-504169206 Packaging result: ✖centos6 ✔centos7 ✖debian. JID-2917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3283: [4.11.2/DO NOT MERGE] noVNC console
rhtyd closed pull request #3283: [4.11.2/DO NOT MERGE] noVNC console URL: https://github.com/apache/cloudstack/pull/3283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3283: [4.11.2/DO NOT MERGE] noVNC console
rhtyd commented on issue #3283: [4.11.2/DO NOT MERGE] noVNC console URL: https://github.com/apache/cloudstack/pull/3283#issuecomment-504117695 Closing this in favour of https://github.com/apache/cloudstack/pull/3296 which is the same feature/PR against master branch. Let's continue testing/reviewing against the master based PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3331: api/server: Add option 'details' to listProjects and listAccounts
ustcweizhou commented on a change in pull request #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#discussion_r295975253 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java ## @@ -55,6 +61,12 @@ @Parameter(name = ApiConstants.STATE, type = CommandType.STRING, description = "list accounts by state. Valid states are enabled, disabled, and locked.") private String state; +@Parameter(name = ApiConstants.DETAILS, + type = CommandType.LIST, + collectionType = CommandType.STRING, + description = "comma separated list of account details requested, value can be a list of [ all, resource, min]") +private List viewDetails; Review comment: @DaanHoogland good > @ustcweizhou can you fix the merge conflict? Thanks. @rhtyd rebased with latest master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-504119230 @ustcweizhou can you fix the merge conflict? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3274: Service offerings too small
rhtyd commented on issue #3274: Service offerings too small URL: https://github.com/apache/cloudstack/issues/3274#issuecomment-504127487 Due to backward compatibility issues, we cannot change the default setting for the Small offering. However, we can introduced a Large (L) and Extra Large (XL) offering. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3344: server: return usage description with resource names and UUIDs
rhtyd closed pull request #3344: server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3344: server: return usage description with resource names and UUIDs
rhtyd opened a new pull request #3344: server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344 The usage record descriptions have CloudStack's internal integer IDs which makes it difficult for users to read their usages. This PRs introduces a new API boolean flag `oldformat` which when set to true would return the older description format, otherwise by default listUsageRecords will process and return description with names and UUIDs of resources. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3296: [WIP/master] noVNC Console Integration
rhtyd commented on issue #3296: [WIP/master] noVNC Console Integration URL: https://github.com/apache/cloudstack/pull/3296#issuecomment-504118013 @ustcweizhou can you fix build failure, see https://travis-ci.org/apache/cloudstack/jobs/524837786 Likely the new noVNC assets need to be removed from license and lint related checks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-504118491 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3312: 'sed -i' need postfix on mac
rhtyd commented on issue #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#issuecomment-504118725 @DaanHoogland fails on linux with: ``` Warning, API Cmd class com.cloud.api.commands.SimulatorAddSecondaryAgent has no APICommand annotation Scanned and found 607 APIs sed: -e expression #1, char 1: unknown command: `.' [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project cloud-apidoc: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3378: project id added in test
rhtyd commented on issue #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#issuecomment-504123196 @DaanHoogland failed following marvin test: (not sure if it's related to the PR) ``` test_15_project_tag | marvin.cloudstackExcept | 1.249 | test_tags | | | ion.CloudstackAPIExcept | | | | | ion | | ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-504117042 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-504116932 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2604: No volume name and virtualmachine ID in volume usagerecord
rhtyd commented on issue #2604: No volume name and virtualmachine ID in volume usagerecord URL: https://github.com/apache/cloudstack/issues/2604#issuecomment-504124890 This is now fixed under https://github.com/apache/cloudstack/pull/3344 which will export both vm and volume name and UUIDs wherever applicable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #2604: No volume name and virtualmachine ID in volume usagerecord
rhtyd closed issue #2604: No volume name and virtualmachine ID in volume usagerecord URL: https://github.com/apache/cloudstack/issues/2604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3411: management database corrupted missing ibdata1
rhtyd closed issue #3411: management database corrupted missing ibdata1 URL: https://github.com/apache/cloudstack/issues/3411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3411: management database corrupted missing ibdata1
rhtyd commented on issue #3411: management database corrupted missing ibdata1 URL: https://github.com/apache/cloudstack/issues/3411#issuecomment-504129202 @udee297 kindly join the users list and ask questions there: http://cloudstack.apache.org/mailing-lists.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-504129043 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
ustcweizhou edited a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-504163543 @svenvogel this script is used to generate template.properties in secondary storage vm when we register a template and it is downloaded successfully. The command I mentioned is just used for testing . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-504100453 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC
rhtyd commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-504117163 @gmueller-ewerk can you merge/rebase against latest master and fix the conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-504121817 @andrijapanic thanks, sounds good to me. This is a given that using UUIDs in the description will incur some processing. In large environments this will make the list API slightly slower than before, however all the UUID translation logic makes individual listing (select * query) so no crazy joins but multiple select queries may be executed depending on the type of the record. In few cases I've optimised not querying for a VM/volume/template resource which is already queried in the beginning on the block. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-504122307 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3376: [4.11] Smoketest Health Check
rhtyd closed pull request #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3376: [4.11] Smoketest Health Check
rhtyd commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-504122161 4.11.3.0 RC1 lgtm, closing this dummy PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3409: RvR Services should be provided on VIP instead of VR IP
rhtyd commented on issue #3409: RvR Services should be provided on VIP instead of VR IP URL: https://github.com/apache/cloudstack/issues/3409#issuecomment-504129020 @ustcweizhou can you share the diff/patch or send a PR in case you've solve this issue in your tree? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-504163543 @svenvogel this script is used to generate template.properties in secondary storage vm when we register a template and it is downloaded successfully. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3409: RvR Services should be provided on VIP instead of VR IP
ustcweizhou commented on issue #3409: RvR Services should be provided on VIP instead of VR IP URL: https://github.com/apache/cloudstack/issues/3409#issuecomment-504179201 @rhtyd I have checked all my code. it seems very difficult to port our changes to 4.11 or 4.13 as there are big difference between our branch and 4.11/4.13. Anyone who is interested in the fixes please feel free to pick it up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3378: project id added in test
ustcweizhou commented on a change in pull request #3378: project id added in
test
URL: https://github.com/apache/cloudstack/pull/3378#discussion_r295999443
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -646,7 +646,16 @@
Ternary
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-_accountMgr.buildACLSearchParameters(caller, null,
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts,
domainIdRecursiveListProject, listAll, false);
+Long projectId = cmd.getProjectId();
+if (resourceType.equalsIgnoreCase("project") && projectId == null) {
+try {
+projectId = Long.parseLong(resourceId);
+} catch (NumberFormatException e) {
+projectId = _projectDao.findByUuid(resourceId).getId();
Review comment:
What if the uuid is invalid ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3413: vmware: add support for VMware 6.7
rhtyd commented on issue #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413#issuecomment-504211823 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3413: vmware: add support for VMware 6.7
blueorangutan commented on issue #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413#issuecomment-504217356 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3413: vmware: add support for VMware 6.7
rhtyd commented on issue #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413#issuecomment-504217143 @blueorangutan test centos7 vmware-65u2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: KVM: DPDK live migrations
blueorangutan commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-504231490 Trillian test result (tid-3712) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35287 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3365-t3712-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 69 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 404.25 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 430.53 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 268.41 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez removed a comment on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez removed a comment on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504290580 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan removed a comment on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504290718 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504295665 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504291673 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504291581 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3413: vmware: add support for VMware 6.7
blueorangutan commented on issue #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413#issuecomment-504211923 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: return usage description with resource names and UUIDs (#3344)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 2c32d60 server: return usage description with resource names and
UUIDs (#3344)
2c32d60 is described below
commit 2c32d60e444b3c9e0ad0e53d3593220351b4337b
Author: Rohit Yadav
AuthorDate: Fri Jun 21 03:48:33 2019 +0530
server: return usage description with resource names and UUIDs (#3344)
The usage record descriptions have CloudStack's internal integer IDs
which makes it difficult for users to read their usages. This PRs
introduces a new API boolean flag `oldformat` which when set to true
would return the older description format, otherwise by default
listUsageRecords will process and return description with names and
UUIDs of resources.
Signed-off-by: Rohit Yadav
---
.../org/apache/cloudstack/api/ApiConstants.java| 1 +
.../apache/cloudstack/api/ResponseGenerator.java | 2 +-
.../command/admin/usage/ListUsageRecordsCmd.java | 8 +-
.../org/apache/cloudstack/usage/UsageTypes.java| 1 +
.../cloudstack/quota/constant/QuotaTypes.java | 1 +
.../main/java/com/cloud/api/ApiResponseHelper.java | 233 ++---
6 files changed, 214 insertions(+), 32 deletions(-)
diff --git a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
index 99efafc..7502b18 100644
--- a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
@@ -219,6 +219,7 @@ public class ApiConstants {
public static final String OFFER_HA = "offerha";
public static final String IS_SYSTEM_OFFERING = "issystem";
public static final String IS_DEFAULT_USE = "defaultuse";
+public static final String OLD_FORMAT = "oldformat";
public static final String OP = "op";
public static final String OS_CATEGORY_ID = "oscategoryid";
public static final String OS_TYPE_ID = "ostypeid";
diff --git a/api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java
b/api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java
index 80d6d4b..740ee46 100644
--- a/api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java
+++ b/api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java
@@ -435,7 +435,7 @@ public interface ResponseGenerator {
UsageRecordResponse createUsageResponse(Usage usageRecord);
-UsageRecordResponse createUsageResponse(Usage usageRecord, Map> resourceTagResponseMap);
+UsageRecordResponse createUsageResponse(Usage usageRecord, Map> resourceTagResponseMap, boolean oldFormat);
public Map> getUsageResourceTags();
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
index 2698c81..a5199ec 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
@@ -82,6 +82,9 @@ public class ListUsageRecordsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.INCLUDE_TAGS, type = CommandType.BOOLEAN,
description = "Flag to enable display of Tags for a resource")
private Boolean includeTags;
+@Parameter(name = ApiConstants.OLD_FORMAT, type = CommandType.BOOLEAN,
description = "Flag to enable description rendered in old format which uses
internal database IDs instead of UUIDs. False by default.")
+private Boolean oldFormat;
+
/
/// Accessors ///
/
@@ -146,6 +149,9 @@ public class ListUsageRecordsCmd extends BaseListCmd {
this.usageId = usageId;
}
+public boolean getOldFormat() {
+return oldFormat != null && oldFormat;
+}
/
/// API Implementation///
@@ -168,7 +174,7 @@ public class ListUsageRecordsCmd extends BaseListCmd {
resourceTagResponseMap =
_responseGenerator.getUsageResourceTags();
}
for (Usage usageRecord : usageRecords.first()) {
-UsageRecordResponse usageResponse =
_responseGenerator.createUsageResponse(usageRecord, resourceTagResponseMap);
+UsageRecordResponse usageResponse =
_responseGenerator.createUsageResponse(usageRecord, resourceTagResponseMap,
getOldFormat());
if (usageResponse != null) {
usageResponse.setObjectName("usagerecord");
usageResponses.add(usageResponse);
diff --git
[GitHub] [cloudstack] rhtyd merged pull request #3344: server: return usage description with resource names and UUIDs
rhtyd merged pull request #3344: server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3413: vmware: add support for VMware 6.7
rhtyd opened a new pull request #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413 This adds support for VMware 6.7 Fixes #2700 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): Was able to deploy an advanced zone with VMware vCenter/ESXi 6.7 and see systemvms come up:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3413: vmware: add support for VMware 6.7
blueorangutan commented on issue #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413#issuecomment-504217014 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504290580 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-504290718 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off
blueorangutan commented on issue #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off URL: https://github.com/apache/cloudstack/pull/3412#issuecomment-504232543 @kioie a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie commented on issue #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off
kioie commented on issue #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off URL: https://github.com/apache/cloudstack/pull/3412#issuecomment-504232500 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3409: RvR Services should be provided on VIP instead of VR IP
rhtyd commented on issue #3409: RvR Services should be provided on VIP instead of VR IP URL: https://github.com/apache/cloudstack/issues/3409#issuecomment-504214783 Okay is your tree public/accessible somewhere @ustcweizhou ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
