[GitHub] [cloudstack] weizhouapache commented on pull request #7066: UI: remove max value (8) of maxsnaps because it might be greater than 8

2023-01-09 Thread GitBox
weizhouapache commented on PR #7066: URL: https://github.com/apache/cloudstack/pull/7066#issuecomment-1375226078 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] blueorangutan commented on pull request #7066: UI: remove max value (8) of maxsnaps because it might be greater than 8

2023-01-09 Thread GitBox
blueorangutan commented on PR #7066: URL: https://github.com/apache/cloudstack/pull/7066#issuecomment-1375226790 @weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] blueorangutan commented on pull request #7066: UI: remove max value (8) of maxsnaps because it might be greater than 8

2023-01-09 Thread GitBox
blueorangutan commented on PR #7066: URL: https://github.com/apache/cloudstack/pull/7066#issuecomment-1375238232 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7066 (QA-JID-25) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] weizhouapache commented on pull request #7066: UI: remove max value (8) of maxsnaps because it might be greater than 8

2023-01-09 Thread GitBox
weizhouapache commented on PR #7066: URL: https://github.com/apache/cloudstack/pull/7066#issuecomment-1375239889 > LGTM. Max value seems to be controlled by global settings for different intervals exactly, @shwstppr -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1375287376 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on pull request #4828: Feat/global vm search

2023-01-09 Thread GitBox
DaanHoogland commented on PR #4828: URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1375302320 @DK101010 I would like to release 4.18 this month and you have conflicts. Can you have a look, or shall I move this to 4.19? -- This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
DaanHoogland commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375304593 @skattoju4 can you look at the unused import? If you don´t have time now we can move this to 4.18.1 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1375308023 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7059: guestos: add el9 distros

2023-01-09 Thread GitBox
shwstppr commented on code in PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#discussion_r1064415963 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -997,3 +997,15 @@ BEGIN DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl =

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7059: guestos: add el9 distros

2023-01-09 Thread GitBox
shwstppr commented on code in PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#discussion_r1064415963 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -997,3 +997,15 @@ BEGIN DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl =

[GitHub] [cloudstack] shwstppr commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
shwstppr commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375315673 @DaanHoogland That unused import might be my doing while addressing review comments. Will fix that. But since we don't have hw and setup to test this I don't think can make it to 4.18

[GitHub] [cloudstack] github-actions[bot] commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
github-actions[bot] commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375321033 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] shwstppr commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
shwstppr commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375323930 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] blueorangutan commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
blueorangutan commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375325081 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
harikrishna-patnala commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375337555 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] weizhouapache commented on issue #6765: Using API's created instances gives error Permission denied (publickey) under the VPC network

2023-01-09 Thread GitBox
weizhouapache commented on issue #6765: URL: https://github.com/apache/cloudstack/issues/6765#issuecomment-1375337564 @satishglondhe the ssh key are saved in CloudStack virtual router. The vm instance gets the ssh key only if cloud-init is installed or a script is executed in startup.

[GitHub] [cloudstack] blueorangutan commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
blueorangutan commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375338071 @harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

[GitHub] [cloudstack] DaanHoogland merged pull request #7024: server: correctly list suitable hosts for migration with uefi capability

2023-01-09 Thread GitBox
DaanHoogland merged PR #7024: URL: https://github.com/apache/cloudstack/pull/7024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch 4.17 updated: server: correctly list suitable hosts for migration with uefi capability (#7024)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.17 by this push: new eb5c8a5a8c server: correctly list suitable hosts f

[GitHub] [cloudstack] DaanHoogland commented on issue #7019: Unable to migrate UEFI instances with XCP-NG

2023-01-09 Thread GitBox
DaanHoogland commented on issue #7019: URL: https://github.com/apache/cloudstack/issues/7019#issuecomment-1375366091 fixed in #7024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7059: guestos: add el9 distros

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#issuecomment-1375387846 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] blueorangutan commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
blueorangutan commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375393218 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5203 -- This is an automated

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-1375394613 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
blueorangutan commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375407134 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5204 -- This is an automated

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375415012 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland merged pull request #7047: fix merge diff display

2023-01-09 Thread GitBox
DaanHoogland merged PR #7047: URL: https://github.com/apache/cloudstack/pull/7047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch main updated: fix merge diff display (#7047)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 6790371fe2 fix merge diff display (#7047) 6790371f

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7045: kvm: get vm disk stats for ceph disks

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #7045: URL: https://github.com/apache/cloudstack/pull/7045#issuecomment-1375430684 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
harikrishna-patnala commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375431324 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
blueorangutan commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375432563 @harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This

[GitHub] [cloudstack] rohityadavcloud merged pull request #7066: UI: remove max value (8) of maxsnaps because it might be greater than 8

2023-01-09 Thread GitBox
rohityadavcloud merged PR #7066: URL: https://github.com/apache/cloudstack/pull/7066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[cloudstack] branch 4.17 updated (eb5c8a5a8c -> 76ec980c76)

2023-01-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from eb5c8a5a8c server: correctly list suitable hosts for migration with uefi capability (#7024) add 76ec980c76 ui:

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7054: UI: support serviceofferingid when create vpc offering

2023-01-09 Thread GitBox
rohityadavcloud commented on PR #7054: URL: https://github.com/apache/cloudstack/pull/7054#issuecomment-1375496269 @weizhouapache is this root-admin only, or for anybody? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7046: Add support for vSphere 8.0

2023-01-09 Thread GitBox
rohityadavcloud commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1375497574 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-09 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1375497825 @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] weizhouapache commented on pull request #7054: UI: support serviceofferingid when create vpc offering

2023-01-09 Thread GitBox
weizhouapache commented on PR #7054: URL: https://github.com/apache/cloudstack/pull/7054#issuecomment-1375501683 > @weizhouapache is this root-admin only, or for anybody? @rohityadavcloud this is root-admin only. non-root users can only create service and disk offerings.

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-09 Thread GitBox
weizhouapache opened a new pull request, #7067: URL: https://github.com/apache/cloudstack/pull/7067 ### Description This PR fixes #6293 Some other changes: - disable 'Create network' button for non-admin users in advanced zone with SG - disable 'L2 network' tab for advan

[cloudstack] branch main updated (6790371fe2 -> 2d1d2944e5)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 6790371fe2 fix merge diff display (#7047) add eb5c8a5a8c server: correctly list suitable hosts for migration with

[cloudstack] 01/01: merge release branch 4.17 into main

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 2d1d2944e5314a3bb03c2e0a9813ef70ef70c65d Merge: 6790371fe2 eb5c8a5a8c Author: Daan Hoogland AuthorDate: Mon Jan 9 12:57:

[GitHub] [cloudstack] GutoVeronezi commented on pull request #6869: Support for parameter `cidrlist` added to the UI

2023-01-09 Thread GitBox
GutoVeronezi commented on PR #6869: URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1375517356 > @GutoVeronezi @JoaoJandre @stephankruggg Do you have QA engineer or mutually review/testing process ? @weizhouapache, yes, we have a process; however, as you may know by p

[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1375518748 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6979: Guest os mappings improvements

2023-01-09 Thread GitBox
github-actions[bot] commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1375518831 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[cloudstack] branch healthcheck-main updated (189a49c60e -> 715275d297)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 189a49c60e healthcheck hack, please don't merge this add bf5cacb3bb gha(linters): enable 7 more Pytho

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6561: Guest OS hypervisor mapping improvements

2023-01-09 Thread GitBox
github-actions[bot] commented on PR #6561: URL: https://github.com/apache/cloudstack/pull/6561#issuecomment-1375518771 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6803: ui,server,api: resource metrics improvements

2023-01-09 Thread GitBox
github-actions[bot] commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1375518801 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-09 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1375519142 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[cloudstack] branch healthcheck-main updated (715275d297 -> c6fd85e2ec)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-main in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 715275d297 Merge branch 'main' into healthcheck-main omit 189a49c60e healthcheck hack, please don't me

[cloudstack] 01/01: update owasp dep checker for 'column width bug'

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch owaspDepCheckUpdate in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit b454728d217522b10af32b9c053154322d2ea11d Author: Daan Hoogland AuthorDate: Mon Jan 9 13:27:43 2023 +0100

[cloudstack] branch owaspDepCheckUpdate created (now b454728d21)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch owaspDepCheckUpdate in repository https://gitbox.apache.org/repos/asf/cloudstack.git at b454728d21 update owasp dep checker for 'column width bug' This branch includes the following new comm

[GitHub] [cloudstack] shwstppr commented on pull request #6840: infra: edge zones

2023-01-09 Thread GitBox
shwstppr commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-137102 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones

2023-01-09 Thread GitBox
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1375556853 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7068: update owasp dep checker for 'column width bug'

2023-01-09 Thread GitBox
DaanHoogland opened a new pull request, #7068: URL: https://github.com/apache/cloudstack/pull/7068 ### Description This PR fixes an issue in the owasp dependency checker. See https://github.com/jeremylong/DependencyCheck/issues/5220

[GitHub] [cloudstack] shwstppr closed issue #7051: UI Recurring snapshots wizard Keep-field issue

2023-01-09 Thread GitBox
shwstppr closed issue #7051: UI Recurring snapshots wizard Keep-field issue URL: https://github.com/apache/cloudstack/issues/7051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[cloudstack] branch main updated (2d1d2944e5 -> a3289f8ac0)

2023-01-09 Thread shwstppr
This is an automated email from the ASF dual-hosted git repository. shwstppr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 2d1d2944e5 merge release branch 4.17 into main add 76ec980c76 ui: remove max value (8) of maxsnaps because it

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7063: server: do not deploy or upgrade vm with inactive service offering

2023-01-09 Thread GitBox
stephankruggg commented on code in PR #7063: URL: https://github.com/apache/cloudstack/pull/7063#discussion_r1064595901 ## engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java: ## @@ -3741,6 +3741,10 @@ public void checkIfCanUpgrade(final VirtualMachine

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6978: simulator: use ubuntu 22.04 in Dockerfile

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6978: URL: https://github.com/apache/cloudstack/pull/6978#issuecomment-1375577898 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-09 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1375578211 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5205 -- This is an automated

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1375584681 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1375585350 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-09 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1375585564 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1375589747 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[cloudstack] branch ldapInjection created (now 9b022358cd)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch ldapInjection in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 9b022358cd escapes for injection prtection This branch includes the following new commits: new 9b02235

[cloudstack] 01/01: escapes for injection prtection

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch ldapInjection in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9b022358cd9002b635fc9ca5502e4aa0a33a3fe8 Author: Daan Hoogland AuthorDate: Mon Jan 9 11:08:06 2023 +0100 e

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7069: escapes for injection protection

2023-01-09 Thread GitBox
DaanHoogland opened a new pull request, #7069: URL: https://github.com/apache/cloudstack/pull/7069 ### Description This PR fixes a theoretical issue n the ldap authentication plugin ### Types of changes - [ ] Breaking ch

[GitHub] [cloudstack] DaanHoogland commented on pull request #7069: escapes for injection protection

2023-01-09 Thread GitBox
DaanHoogland commented on PR #7069: URL: https://github.com/apache/cloudstack/pull/7069#issuecomment-1375596736 @blueorangutan build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones

2023-01-09 Thread GitBox
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1375615707 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5206 -- This is an automated

[GitHub] [cloudstack] weizhouapache commented on pull request #7063: server: do not deploy or upgrade vm with inactive service offering

2023-01-09 Thread GitBox
weizhouapache commented on PR #7063: URL: https://github.com/apache/cloudstack/pull/7063#issuecomment-1375625207 > Hi @weizhouapache, can you extract the inactive check to a method and reuse it in both scenarios to avoid code duplication? @stephankruggg suggested changes are commi

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1375626946 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7068: update owasp dep checker for 'column width bug'

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #7068: URL: https://github.com/apache/cloudstack/pull/7068#issuecomment-1375632353 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6803: ui,server,api: resource metrics improvements

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1375669902 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6803: ui,server,api: resource metrics improvements

2023-01-09 Thread GitBox
DaanHoogland commented on code in PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#discussion_r1064681067 ## engine/schema/src/main/java/com/cloud/storage/dao/VolumeStatsDaoImpl.java: ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [cloudstack] DaanHoogland commented on pull request #7023: delete F5 and SRX plugins

2023-01-09 Thread GitBox
DaanHoogland commented on PR #7023: URL: https://github.com/apache/cloudstack/pull/7023#issuecomment-1375713953 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7023: delete F5 and SRX plugins

2023-01-09 Thread GitBox
blueorangutan commented on PR #7023: URL: https://github.com/apache/cloudstack/pull/7023#issuecomment-1375714271 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1375718856 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2023-01-09 Thread GitBox
blueorangutan commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1375720457 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #6924: [Draft] User two factor authentication

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1375722536 @harikrishna-patnala is this one still in focus for 4.18? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] DaanHoogland commented on pull request #6282: [Veeam] restored VMs without NICs

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6282: URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1375726393 @SadiJr can you look at the merge conflicts, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] DaanHoogland commented on pull request #6589: [Veeam] disable jobs but keep backups

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1375728350 @SadiJr , can you look at the conflicts here as well, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

commits@cloudstack.apache.org

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6550: URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1375730617 As I saw the error on the jacoco build in another PR on the apache jenkins as well, I am going to merge. -- This is an automated message from the Apache Git Service. To respond

commits@cloudstack.apache.org

2023-01-09 Thread GitBox
DaanHoogland merged PR #6550: URL: https://github.com/apache/cloudstack/pull/6550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7023: delete F5 and SRX plugins

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #7023: URL: https://github.com/apache/cloudstack/pull/7023#issuecomment-1375749672 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7057: server/UI: fix some issues with network offering details

2023-01-09 Thread GitBox
DaanHoogland commented on code in PR #7057: URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1064743445 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final Transact

[GitHub] [cloudstack] blueorangutan commented on pull request #7069: escapes for injection protection

2023-01-09 Thread GitBox
blueorangutan commented on PR #7069: URL: https://github.com/apache/cloudstack/pull/7069#issuecomment-1375777042 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5207 -- This is an automated

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7057: server/UI: fix some issues with network offering details

2023-01-09 Thread GitBox
weizhouapache commented on code in PR #7057: URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1064764531 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -6769,6 +6771,7 @@ public boolean deleteNetworkOffering(final DeleteNetwo

[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2023-01-09 Thread GitBox
blueorangutan commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1375797993 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5209 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7023: delete F5 and SRX plugins

2023-01-09 Thread GitBox
blueorangutan commented on PR #7023: URL: https://github.com/apache/cloudstack/pull/7023#issuecomment-1375797995 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5208 -- This is an automated

[GitHub] [cloudstack] DaanHoogland commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6957: URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1375804626 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1375805414 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

2023-01-09 Thread GitBox
blueorangutan commented on PR #6957: URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1375805297 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #7052: Allow domain admins to inform tags when creating offerings

2023-01-09 Thread GitBox
DaanHoogland commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375820386 it could do with an integration test though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] DaanHoogland commented on pull request #7052: Allow domain admins to inform tags when creating offerings

2023-01-09 Thread GitBox
DaanHoogland commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375821075 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7052: Allow domain admins to inform tags when creating offerings

2023-01-09 Thread GitBox
blueorangutan commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1375822748 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] codecov[bot] commented on pull request #7068: update owasp dep checker for 'column width bug'

2023-01-09 Thread GitBox
codecov[bot] commented on PR #7068: URL: https://github.com/apache/cloudstack/pull/7068#issuecomment-1375835983 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7068?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

2023-01-09 Thread GitBox
blueorangutan commented on PR #6957: URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1375836962 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5

[GitHub] [cloudstack] DaanHoogland merged pull request #7032: Allow users to inform timezones on APIs that have the date parameter

2023-01-09 Thread GitBox
DaanHoogland merged PR #7032: URL: https://github.com/apache/cloudstack/pull/7032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch main updated: Allow users to inform timezones on APIs that have the date parameter (#7032)

2023-01-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new cc527523fa Allow users to inform timezones on APIs

[GitHub] [cloudstack] DaanHoogland commented on pull request #7069: escapes for injection protection

2023-01-09 Thread GitBox
DaanHoogland commented on PR #7069: URL: https://github.com/apache/cloudstack/pull/7069#issuecomment-1375848219 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #7069: escapes for injection protection

2023-01-09 Thread GitBox
blueorangutan commented on PR #7069: URL: https://github.com/apache/cloudstack/pull/7069#issuecomment-1375848791 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] DaanHoogland commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2023-01-09 Thread GitBox
DaanHoogland commented on PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1375864207 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2023-01-09 Thread GitBox
blueorangutan commented on PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1375865647 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

  1   2   >