[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1399175982 Trillian test result (tid-5932) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40855 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6924-t5932-kvm-centos7.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_2FA_enabled | `Failure` | 2.92 | test_2fa.py test_2FA_setup | `Failure` | 2.91 | test_2fa.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1399161267 Trillian test result (tid-5929) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43845 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7015-t5929-kvm-centos7.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 567.45 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings
blueorangutan commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1399157407 Trillian test result (tid-5928) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44332 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6748-t5928-kvm-centos7.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399157080 Trillian test result (tid-5924) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 50877 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5924-vmware-67u3.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rahulbcn27 commented on a diff in pull request #7112: Make display elements optional
rahulbcn27 commented on code in PR #7112: URL: https://github.com/apache/cloudstack/pull/7112#discussion_r1083228833 ## ui/src/views/network/CreateIsolatedNetworkForm.vue: ## @@ -40,7 +40,7 @@
[GitHub] [cloudstack] blueorangutan commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings
blueorangutan commented on PR #6581: URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1399150046 Trillian test result (tid-5926) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48476 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6581-t5926-vmware-70u3.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
blueorangutan commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1399143682 Trillian test result (tid-5927) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40954 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5927-kvm-centos7.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1399108212 Trillian test result (tid-5919) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46051 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7089-t5919-kvm-centos7.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_07_deploy_kubernetes_ha_cluster | `Failure` | 3617.28 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 76.85 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev closed issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev closed issue #7116: Network in allocated state - VLAN isoltation URL: https://github.com/apache/cloudstack/issues/7116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1399107870 Thank you for information @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7111: marvin: install mysql-connector-python version 8.0.31
blueorangutan commented on PR #7111: URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1399105992 Trillian test result (tid-5922) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44165 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7111-t5922-kvm-centos7.zip Smoke tests completed. 89 look OK, 18 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_snapshot_root_disk | `Error` | 3.31 | test_snapshots.py test_CreateTemplateWithDuplicateName | `Error` | 20.66 | test_templates.py test_01_register_template_direct_download_flag | `Error` | 0.17 | test_templates.py test_query_async_job_result | `Error` | 82.83 | test_async_job.py test_01_vpc_privategw_acl | `Error` | 104.11 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Error` | 307.52 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 300.96 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Error` | 523.33 | test_privategw_acl.py test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py test_role_account_acls_multiple_mgmt_servers | `Error` | 2.06 | test_dynamicroles.py test_01_deployVMInSharedNetwork | `Error` | 67.05 | test_network.py test_03_destroySharedNetwork | `Failure` | 1.06 | test_network.py ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.16 | test_network.py test_02_edit_primary_storage_tags | `Error` | 0.02 | test_primary_storage.py test_01_vpc_privategw_acl | `Error` | 0.03 | test_privategw_acl_ovs_gre.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 0.02 | test_privategw_acl_ovs_gre.py test_05_vpc_privategw_check_interface | `Error` | 0.02 | test_privategw_acl_ovs_gre.py test_oobm_background_powerstate_sync | `Failure` | 21.64 | test_outofbandmanagement.py test_oobm_background_powerstate_sync | `Error` | 21.64 | test_outofbandmanagement.py test_oobm_configure_default_driver | `Error` | 0.06 | test_outofbandmanagement.py test_oobm_configure_invalid_driver | `Error` | 0.05 | test_outofbandmanagement.py test_oobm_disable_feature_invalid | `Error` | 0.06 | test_outofbandmanagement.py test_oobm_disable_feature_valid | `Error` | 1.13 | test_outofbandmanagement.py test_oobm_enable_feature_invalid | `Error` | 0.07 | test_outofbandmanagement.py test_oobm_enable_feature_valid | `Error` | 1.11 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 6.72 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 6.72 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 4.33 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 4.33 | test_outofbandmanagement.py test_oobm_issue_power_off | `Error` | 3.31 | test_outofbandmanagement.py test_oobm_issue_power_off | `Error` | 3.31 | test_outofbandmanagement.py test_oobm_issue_power_on | `Error` | 4.30 | test_outofbandmanagement.py test_oobm_issue_power_on | `Error` | 4.30 | test_outofbandmanagement.py test_oobm_issue_power_reset | `Error` | 3.29 | test_outofbandmanagement.py test_oobm_issue_power_reset | `Error` | 3.29 | test_outofbandmanagement.py test_oobm_issue_power_soft | `Error` | 4.29 | test_outofbandmanagement.py test_oobm_issue_power_soft | `Error` | 4.29 | test_outofbandmanagement.py test_oobm_issue_power_status | `Error` | 3.28 | test_outofbandmanagement.py test_oobm_issue_power_status | `Error` | 3.28 | test_outofbandmanagement.py test_oobm_multiple_mgmt_server_ownership | `Error` | 1.13 | test_outofbandmanagement.py test_oobm_multiple_mgmt_server_ownership | `Error` | 1.13 | test_outofbandmanagement.py test_oobm_zchange_password | `Error` | 0.18 | test_outofbandmanagement.py test_oobm_zchange_password | `Error` | 0.18 | test_outofbandmanagement.py test_01_ISO_usage | `Error` | 1.08 | test_usage.py test_01_lb_usage | `Error` | 4.22 | test_usage.py test_01_nat_usage | `Error` | 7.28 | test_usage.py test_01_public_ip_usage | `Error` | 1.08 | test_usage.py test_01_snapshot_usage | `Error` | 22.66 | test_usage.py test_01_template_usage | `Error` | 12.44 | test_usage.py test_01_vm_usage | `Error` | 132.97 | test_usage.py test_01_volume_usage | `Error` | 126.11 | test_usage.py test_01_vpn_usage | `Error` | 9.44 | test_usage.py test_01_positive_tests_usage | `Error` | 8.16 | test_usage_events.py test_oobm_issue_power_cycle | `Error` | 2.21 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_cycle | `Error` | 2.21 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_off | `Error` | 2.20 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_off | `Error` | 2.21 |
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1399097588 Trillian test result (tid-5918) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44135 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7089-t5918-vmware-67u3.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399085736 Trillian test result (tid-5925) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41056 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5925-kvm-centos7.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399083543 Trillian test result (tid-5923) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40799 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5923-xenserver-71.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1399074075 Trillian test result (tid-5917) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41074 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7089-t5917-xenserver-71.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1399055769 Trillian test result (tid-5914) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51394 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7006-t5914-vmware-67u3.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_iso_with_checksum_md5 | `Error` | 66.66 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 66.65 | test_iso.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7113: Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt server
blueorangutan commented on PR #7113: URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1399032653 Trillian test result (tid-5916) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49017 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7113-t5916-vmware-70u3.zip Smoke tests completed. 105 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_create_pvlan_network | `Error` | 0.06 | test_pvlan.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 672.98 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7116: Network in allocated state - VLAN isoltation
weizhouapache commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1399013381 > @weizhouapache for now i install from scratch Management Server and KVM node - and it works fine. However what i noticed that during changing confugration over GUI physical networks and VLAN range the Database not updated. Old rows still remaning in the DB. I attached screen before reinstalling appliance and it shows old networks and VLAN which have already been deleted. So the DB is not updated during deleting VLAN pools from physical networks  056ecc.jpg) @jaghabalayev in some database tables which have the 'removed' column, the records are not deleted, cloudstack just updates the 'removed' to the datetime when the resource becomes unavailable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1399005031 Trillian Build Failed (tid-5938) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1398994630 Trillian test result (tid-5921) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34309 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6442-t5921-kvm-centos7.zip Smoke tests completed. 79 look OK, 28 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_verify_ipv6_network | `Error` | 0.14 | test_network_ipv6.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py test_01_nic | `Error` | 22.62 | test_nic.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestL2Networks>:setup | `Error` | 168.61 | test_network.py ContextSuite context=TestPublicIP>:setup | `Error` | 2.97 | test_network.py ContextSuite context=TestSharedNetwork>:setup | `Error` | 44.36 | test_network.py ContextSuite context=TestNetworkMigration>:setup | `Error` | 0.00 | test_migration.py ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestL2PersistentNetworks>:setup | `Error` | 0.00 | test_persistent_network.py test_01_vpc_privategw_acl | `Failure` | 105.47 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 198.51 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 200.38 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 403.44 | test_privategw_acl.py ContextSuite context=TestPortablePublicIPAcquire>:setup | `Error` | 0.00 | test_portable_publicip.py ContextSuite context=TestDirectDownloadTemplates>:setup | `Error` | 0.00 | test_direct_download.py ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py ContextSuite context=TestNetworkPermissions>:setup | `Error` | 0.00 | test_network_permissions.py ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | test_nonstrict_affinity_group.py test_01_create_network_offering | `Error` | 0.03 | test_domain_network_offerings.py ContextSuite context=TestDomainsNetworkOfferings>:setup | `Error` | 3.40 | test_domain_network_offerings.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 2.25 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 3.25 | test_internal_lb.py test_01_create_ipv6_network_offering | `Error` | 0.07 | test_ipv6_infra.py test_01_events_resource | `Error` | 0.16 | test_events_resource.py test_CRUD_operations_userdata | `Error` | 1.65 | test_register_userdata.py test_deploy_vm_with_registered_userdata | `Error` | 1.48 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 1.54 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 1.49 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 1.63 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_params | `Error` | 1.55 | test_register_userdata.py test_link_and_unlink_userdata_to_template | `Error` | 1.52 | test_register_userdata.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.03 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.02 | test_routers_network_ops.py test_01_single_VPC_iptables_policies | `Error` | 102.87 | test_routers_iptables_default_policy.py ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py test_01_verify_ipv6_vpc | `Error` | 95.78 | test_vpc_ipv6.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 207.79 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 205.97 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 208.00 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 203.75 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 202.70 | test_vpc_redundant.py test_01_VPC_nics_after_destroy | `Failure` | 104.21 | test_vpc_router_nics.py test_02_VPC_default_routes | `Failure` | 106.36 | test_vpc_router_nics.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` |
[GitHub] [cloudstack] blueorangutan commented on pull request #7118: CKS: fix upgrade of HA cluster
blueorangutan commented on PR #7118: URL: https://github.com/apache/cloudstack/pull/7118#issuecomment-1398980972 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7118: CKS: fix upgrade of HA cluster
weizhouapache commented on PR #7118: URL: https://github.com/apache/cloudstack/pull/7118#issuecomment-1398980751 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398978249 @weizhouapache for now i install from scratch Management Server and KVM node - and it works fine. However what i noticed that during changing confugration over GUI physical networks and VLAN range the Database not updated. Old rows still remaning in the DB. I attached screen before reinstalling appliance and it shows old networks and VLAN which have already been deleted. So the DB is not updated during deleting VLAN pools from physical networks  056ecc.jpg) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398974738 Trillian test result (tid-5912) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 47637 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7114-t5912-kvm-ubuntu22.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_upgrade_kubernetes_cluster | `Failure` | 551.86 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 625.06 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398949128 Trillian Build Failed (tid-5935) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7118: CKS: fix upgrade of HA cluster
sonarcloud[bot] commented on PR #7118: URL: https://github.com/apache/cloudstack/pull/7118#issuecomment-1398941309 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7118) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7118=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7118=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7118=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack=7118=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7118=new_coverage=list) [15.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7118=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7118=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7118=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1398935654 Trillian test result (tid-5913) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44205 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7006-t5913-xenserver-71.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7118: CKS: fix upgrade of HA cluster
blueorangutan commented on PR #7118: URL: https://github.com/apache/cloudstack/pull/7118#issuecomment-1398932398 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398921930 Trillian Build Failed (tid-5934) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency
stephankruggg commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1083031782
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 6; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 6;
-protected long _heartBeatUpdateFreq = 6;
+protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
The intention of this PR is to allow the increase (or the decrease) of the
frequency of the KVM HA heartbeat checks, which is currently not possible. For
example, if one wants to guarantee that a critical host is down for the least
amount of time possible, one can increase the frequency of the heartbeat with
the changes proposed.
Even though not necessarily related to the same use case, the
externalization of other properties would achieve the same general goal of
increasing the flexibility of the system. Since everyone benefits from this,
and they are all related to the same topic (KVM HA), I am open to work on the
externalization of them in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398902220 Trillian Build Failed (tid-5933) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7118: CKS: fix upgrade of HA cluster
blueorangutan commented on PR #7118: URL: https://github.com/apache/cloudstack/pull/7118#issuecomment-1398879294 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7118: CKS: fix upgrade of HA cluster
weizhouapache commented on PR #7118: URL: https://github.com/apache/cloudstack/pull/7118#issuecomment-1398878961 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7118: CKS: fix upgrade of HA cluster
weizhouapache opened a new pull request, #7118:
URL: https://github.com/apache/cloudstack/pull/7118
### Description
This PR fixes the smoke test failure test_08_upgrade_kubernetes_ha_cluster
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2
blueorangutan commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1398875981 Trillian test result (tid-5915) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40609 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7006-t5915-kvm-centos7.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] kiwiflyer commented on pull request #7065: Tungsten integration
kiwiflyer commented on PR #7065: URL: https://github.com/apache/cloudstack/pull/7065#issuecomment-1398857494 Here's the TF API JAR forked repo - https://github.com/kiwiflyer/tf-java-api/ JAR is here - https://github.com/kiwiflyer/tf-java-api/blob/master/target/juniper-tungsten-api-2.0.jar I took the work that Huy and Radu completed, reforked the original TF repo with the original license (APL2) and applied the patches. Original Repo is reference in plugins/network-elements/tungsten/pom.xml- juniper-tungsten-api https://github.com/radu-todirica/tungsten-api/raw/master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7116: Network in allocated state - VLAN isoltation
weizhouapache commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398852709 > @weizhouapache I tried to created VM and use the created network (allocated), but VM creation failed with error - couldn't assign network in allocated mode @jaghabalayev any logs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398851038 @weizhouapache I tried to created VM and use the created network (allocated), but VM creation failed with error - couldn't assign network in allocated mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398842680 @weizhouapache DefaultIsolatedNetworkOfferingForVpcNetworks - i used this offering also, the result is same. The network created successfully, but in allocated state. When i add network with VLAN ID manually it created with success. Looks like management server couldn't fetch the information from VLAN pool for guest networks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7116: Network in allocated state - VLAN isoltation
weizhouapache commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398830695 @jaghabalayev I had a quick check on your logs You have created multiple network offering for testing. These error seem to be caused by the new created network offering ``` 2023-01-20 10:59:54,655 INFO [c.c.a.ApiServer] (qtp1750498848-20:ctx-ce91bf25 ctx-087bfc02) (logid:7395e1a3) Service/provider combination Lb/VpcVirtualRouter is not supported by VPC [VPC [3-PoC-4] 2023-01-20 11:02:32,861 INFO [c.c.a.ApiServer] (qtp1750498848-19:ctx-e39130d0 ctx-59297ccb) (logid:4c8302da) Vlan has to be specified; corresponding offering says specifyVlan=true 2023-01-20 11:03:08,151 INFO [c.c.a.ApiServer] (qtp1750498848-22:ctx-b82299fc ctx-dd6d38d8) (logid:b1d23c82) Network cidr 10.4.1.0/24 is not within vpc [VPC [2-PoC-VPC-GLOBAL] cidr 2023-01-20 11:03:44,095 INFO [c.c.a.ApiServer] (qtp1750498848-412:ctx-47e20858 ctx-3b5e1bee) (logid:ced3123c) Vlan has to be specified; corresponding offering says specifyVlan=true 2023-01-20 11:24:08,485 INFO [c.c.a.ApiServer] (qtp1750498848-20:ctx-e6869a22 ctx-d8aad01f) (logid:9589158c) Service/provider combination Lb/VpcVirtualRouter is not supported by VPC [VPC [5-PoC-New] 2023-01-20 11:31:11,940 INFO [c.c.a.ApiServer] (qtp1750498848-19:ctx-e11fc791 ctx-af6d7f55) (logid:f72ba405) More than one physical networks exist in zone id=1 and no tags are specified in order to make a choice 2023-01-20 11:32:19,677 ERROR [c.c.a.ApiServer] (qtp1750498848-17:ctx-ed35b8a9 ctx-6a0ad51d) (logid:42b75c2e) unhandled exception executing api command: [Ljava.lang.String;@771a8053 com.cloud.exception.UnsupportedServiceException: Provider Ovs is either not enabled or doesn't support service Connectivity in physical network id=202 2023-01-20 11:33:17,509 ERROR [c.c.a.ApiServer] (qtp1750498848-16:ctx-820a4651 ctx-06fb4dba) (logid:65f2a9f5) unhandled exception executing api command: [Ljava.lang.String;@3b371888 com.cloud.exception.UnsupportedServiceException: Provider VpcVirtualRouter is either not enabled or doesn't support service Dhcp in physical network id=202 2023-01-20 11:34:58,195 ERROR [c.c.a.ApiServer] (qtp1750498848-19:ctx-2724bf6d ctx-6a805c8d) (logid:ac52a8ce) unhandled exception executing api command: [Ljava.lang.String;@295500ac com.cloud.exception.UnsupportedServiceException: Provider VpcVirtualRouter is either not enabled or doesn't support service Dhcp in physical network id=202 ``` some networks have been created successfully ``` 2023-01-20 10:54:33,664 DEBUG [c.c.r.ResourceLimitManagerImpl] (qtp1750498848-21:ctx-554b62c6 ctx-fe5bdbd8) (logid:b25c28fd) Updating resource Type = network count for Account = 2 Operation = increasing Amount = 1 2023-01-20 11:09:51,367 DEBUG [c.c.r.ResourceLimitManagerImpl] (qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Updating resource Type = network count for Account = 2 Operation = increasing Amount = 1 2023-01-20 11:26:04,085 DEBUG [c.c.r.ResourceLimitManagerImpl] (qtp1750498848-403:ctx-1e2fa873 ctx-0f1d6863) (logid:9c95e1f6) Updating resource Type = network count for Account = 2 Operation = increasing Amount = 1 2023-01-20 11:51:13,474 DEBUG [c.c.r.ResourceLimitManagerImpl] (qtp1750498848-412:ctx-7d124df9 ctx-32c95c2a) (logid:9fcaf791) Updating resource Type = network count for Account = 2 Operation = increasing Amount = 1 ``` I did not see anything wrong. can you use the default offering `DefaultIsolatedNetworkOfferingForVpcNetworks` to create vpc tiers ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6938: Create API to reassign volume
sonarcloud[bot] commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1398771193 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6938) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_coverage=list) [29.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #6938: Create API to reassign volume
JoaoJandre commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1398709354 @DaanHoogland No problem :) done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7083: Add three more `pre-commit` checks
github-actions[bot] commented on PR #7083: URL: https://github.com/apache/cloudstack/pull/7083#issuecomment-1398708032 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398704817 [screenshoot.zip](https://github.com/apache/cloudstack/files/10468637/screenshoot.zip) Screenshoots from physical network menu added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7117: UI: fix podid is not passed when add ip ranges to basic network
sonarcloud[bot] commented on PR #7117: URL: https://github.com/apache/cloudstack/pull/7117#issuecomment-1398704015 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7117) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7117=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7117=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7117=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7117=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7117=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7117=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398694794 [management-logs.zip](https://github.com/apache/cloudstack/files/10468585/management-logs.zip) @weizhouapache The log file was attached -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398679457 I can see the vlan range under detail tab, however can not see the vlan range in the list of physical networks. Is it normal behaviour ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398669217 Hello @weizhouapache I have already check vlan range under physical network. and it specified there. i will upload the full logs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398662632 @rohityadavcloud a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu20) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398662944 @blueorangutan suse15 kvm-suse15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398661854 @blueorangutan test ubuntu20 kvm-ubuntu20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398661554 @rohityadavcloud a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu22) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660948 @blueorangutan test ubuntu20 kvm-ubuntu22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660645 @blueorangutan test ubuntu20 kvm-ubuntu20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660483 @rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398660121 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
blueorangutan commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398659401 @rohityadavcloud I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] Mgmt OS options: ['centos7', 'centos6', 'suse15', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'rocky8'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82'] Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu. Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates. Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'rahulbcn27', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'weizhouapache', 'NuxRo', 'mlsorensen'] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7116: Network in allocated state - VLAN isoltation
weizhouapache commented on issue #7116: URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398659354 @jaghabalayev I cannot find any clue from your management server log. From what I get in the description, it looks like a UI bug which causes vlan range to be lost when you create the zone. The UI bug has been fixed by https://github.com/apache/cloudstack/pull/6895 can you please go to the physical networks and check if vlan range is empty ? If yes, you need to update the physical network with a vlan range. If not, can you please upload the full log ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
rohityadavcloud commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398658967 @blueorangutan help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1398657080 Trillian Build Failed (tid-5931) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Hudratronium commented on issue #4238: uefi vm creation fail
Hudratronium commented on issue #4238: URL: https://github.com/apache/cloudstack/issues/4238#issuecomment-1398642903 Regarding the 'uefi.properties' file i guess everything is said and done. As always it would be nice to see some more information in the docs for this as the only offical source of information is the above mentioned wiki entry. As far as i have seen, there have been some changes and fixes regarding that feature during the last versions of CS. So i can't say that the infos given in the wiki are still up to date as it has been modified at 10/2019. With Windows Server 2022 we have a major OS which is actively checking secure boot / needing it to match some security baselines. The same goes for several certifications and stuff when you are using CS in more security sensitive environments.If the project wants to give the opertunity to use Cloudstack with KVM hosts in such environments, it might be nice thinking about updateing the docs wiki and maybe publish some more infos regarding the whole depolyment / usage of the feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7117: UI: fix podid is not passed when add ip ranges to basic network
weizhouapache opened a new pull request, #7117:
URL: https://github.com/apache/cloudstack/pull/7117
### Description
This fixes #6872
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1398623938 Trillian Build Failed (tid-5930) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] jaghabalayev commented on issue #7116: Network in allocated state - VLAN isoltation
jaghabalayev commented on issue #7116:
URL: https://github.com/apache/cloudstack/issues/7116#issuecomment-1398615308
@weizhouapache
i have the exact error on my logs. On the network offering i didn't use
BigSw services and BigSw services disabled.
I tried with Linux bridge and with OVS - the result is the same. It is my
first Cloudstack installation, sorry for any incorrect information. If this not
a bug, could you please provide little bit more information how can i create
networks ?
The logs in my case look like:
"name": "admin", "uuid": "923dd6d0-90c5-11ed-8d55-000c29ae2b73"} to [Network
Offering [23-Guest-PoCNetworkOffering-1] by AffinityGroupAccessChecker
2023-01-20 11:09:51,250 DEBUG [c.c.n.v.VpcManagerImpl]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Releasing lock
for [VPC [4-PoC-11]
2023-01-20 11:09:51,285 DEBUG [c.c.n.g.BigSwitchBcfGuestNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network, the physical isolation type is not BCF_SEGMENT
2023-01-20 11:09:51,289 DEBUG [o.a.c.n.c.m.ContrailGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,292 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,295 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,299 DEBUG [c.c.n.g.OvsGuestNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,303 INFO [c.c.n.g.DirectNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,308 DEBUG [c.c.n.g.DirectNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) GRE: VLAN
2023-01-20 11:09:51,308 DEBUG [c.c.n.g.DirectNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) GRE: VXLAN
2023-01-20 11:09:51,308 INFO [c.c.n.g.DirectNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,353 DEBUG [o.a.c.n.g.SspGuestNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) SSP not
configured to be active
2023-01-20 11:09:51,356 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Refusing to
design this network
2023-01-20 11:09:51,360 DEBUG [o.a.c.e.o.NetworkOrchestrator]
(qtp1750498848-17:ctx-9841c0fe ctx-82941bca) (logid:a9e3faa6) Releasing lock
for Acct[923dd6d0-90c5-11ed-8d55-000c29ae2b73-admin] -- Account {"id": 2,
"name": "admin", "uuid": "923dd6d0-90c5-11ed-8d55-000c29ae2b73"}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7050: VR: fix warning Expected X answers while executing SetXXXCommand but Y
blueorangutan commented on PR #7050: URL: https://github.com/apache/cloudstack/pull/7050#issuecomment-1398607351 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7050: VR: fix warning Expected X answers while executing SetXXXCommand but Y
DaanHoogland commented on PR #7050: URL: https://github.com/apache/cloudstack/pull/7050#issuecomment-1398606657 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398606105 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
DaanHoogland commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398605510 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7050: VR: fix warning Expected X answers while executing SetXXXCommand but Y
blueorangutan commented on PR #7050: URL: https://github.com/apache/cloudstack/pull/7050#issuecomment-1398604934 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6924: [Draft] User two factor authentication
DaanHoogland commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1398604312 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1398604770 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398562220 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1398558072 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6924: [Draft] User two factor authentication
sonarcloud[bot] commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1398545952 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6924) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6924=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6924=false=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6924=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_coverage=list) [35.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_duplicated_lines_density=list) [3.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge release branch 4.17 to main
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 07e4debeabc58b815078a3882264cd23278fd0ac Merge: 911f951e2a 536a387326 Author: Daan Hoogland AuthorDate: Fri Jan 20 16:16:14 2023 +0100 Merge release branch 4.17 to main * 4.17: api: fix new password is applied on host when update host password with update_passwd_on_host=false (#7092) CKS: remove details when delete a cks cluster (#7104) api/server: add project id/name in ssh keypair response (#7100) .../api/command/admin/host/UpdateHostPasswordCmd.java| 3 ++- .../cloudstack/api/response/SSHKeyPairResponse.java | 16 .../api/command/test/UpdateHostPasswordCmdTest.java | 14 +- .../actionworkers/KubernetesClusterDestroyWorker.java| 1 + .../src/main/java/com/cloud/api/ApiResponseHelper.java | 8 +++- ui/src/config/section/compute.js | 12 +--- 6 files changed, 48 insertions(+), 6 deletions(-)
[cloudstack] branch main updated (911f951e2a -> 07e4debeab)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 911f951e2a Handle console session in multiple management servers (#7094) add 37b2a4826d api/server: add project id/name in ssh keypair response (#7100) add 9366c4ea01 CKS: remove details when delete a cks cluster (#7104) add 536a387326 api: fix new password is applied on host when update host password with update_passwd_on_host=false (#7092) new 07e4debeab Merge release branch 4.17 to main The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../api/command/admin/host/UpdateHostPasswordCmd.java| 3 ++- .../cloudstack/api/response/SSHKeyPairResponse.java | 16 .../api/command/test/UpdateHostPasswordCmdTest.java | 14 +- .../actionworkers/KubernetesClusterDestroyWorker.java| 1 + .../src/main/java/com/cloud/api/ApiResponseHelper.java | 8 +++- ui/src/config/section/compute.js | 12 +--- 6 files changed, 48 insertions(+), 6 deletions(-)
[cloudstack] branch 4.17 updated: api: fix new password is applied on host when update host password with update_passwd_on_host=false (#7092)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.17
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.17 by this push:
new 536a387326 api: fix new password is applied on host when update host
password with update_passwd_on_host=false (#7092)
536a387326 is described below
commit 536a387326f3e6ae341b40b180d8ef221d20ceb9
Author: Wei Zhou
AuthorDate: Fri Jan 20 16:11:55 2023 +0100
api: fix new password is applied on host when update host password with
update_passwd_on_host=false (#7092)
---
.../api/command/admin/host/UpdateHostPasswordCmd.java | 3 ++-
.../api/command/test/UpdateHostPasswordCmdTest.java| 14 +-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java
index 5a884cf72a..8f191bd432 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java
@@ -23,6 +23,7 @@ import org.apache.cloudstack.api.Parameter;
import org.apache.cloudstack.api.response.ClusterResponse;
import org.apache.cloudstack.api.response.HostResponse;
import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.commons.lang3.BooleanUtils;
import org.apache.log4j.Logger;
import com.cloud.user.Account;
@@ -67,7 +68,7 @@ public class UpdateHostPasswordCmd extends BaseCmd {
}
public Boolean getUpdatePasswdOnHost() {
-return updatePasswdOnHost == null ? false : true;
+return BooleanUtils.isTrue(updatePasswdOnHost);
}
public String getPassword() {
diff --git
a/api/src/test/java/org/apache/cloudstack/api/command/test/UpdateHostPasswordCmdTest.java
b/api/src/test/java/org/apache/cloudstack/api/command/test/UpdateHostPasswordCmdTest.java
index 12f9da3a40..9b130b060b 100644
---
a/api/src/test/java/org/apache/cloudstack/api/command/test/UpdateHostPasswordCmdTest.java
+++
b/api/src/test/java/org/apache/cloudstack/api/command/test/UpdateHostPasswordCmdTest.java
@@ -27,6 +27,7 @@ import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
+import org.springframework.test.util.ReflectionTestUtils;
import com.cloud.exception.InvalidParameterValueException;
import com.cloud.resource.ResourceService;
@@ -94,4 +95,15 @@ public class UpdateHostPasswordCmdTest extends TestCase {
assertFalse("The attribute updatePasswdOnHost should be false, but it
isn't.", updateHostPasswordCmd.getUpdatePasswdOnHost());
verify(managementServer,
times(1)).updateHostPassword(updateHostPasswordCmd);
}
-}
\ No newline at end of file
+
+@Test
+public void testGetUpdatePasswdOnHostValues() {
+assertFalse(updateHostPasswordCmd.getUpdatePasswdOnHost());
+
+ReflectionTestUtils.setField(updateHostPasswordCmd,
"updatePasswdOnHost", false);
+assertFalse(updateHostPasswordCmd.getUpdatePasswdOnHost());
+
+ReflectionTestUtils.setField(updateHostPasswordCmd,
"updatePasswdOnHost", true);
+assertTrue(updateHostPasswordCmd.getUpdatePasswdOnHost());
+}
+}
[GitHub] [cloudstack] DaanHoogland merged pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
DaanHoogland merged PR #7092: URL: https://github.com/apache/cloudstack/pull/7092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed issue #7096: Unable to delete SSH Key as User within a project
DaanHoogland closed issue #7096: Unable to delete SSH Key as User within a project URL: https://github.com/apache/cloudstack/issues/7096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7096: Unable to delete SSH Key as User within a project
DaanHoogland commented on issue #7096: URL: https://github.com/apache/cloudstack/issues/7096#issuecomment-1398509741 fixed in #7100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1398471435 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
DaanHoogland commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1398470127 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398465431 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce
DaanHoogland commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1398464415 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1398459855 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6924: [Draft] User two factor authentication
DaanHoogland commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1398458747 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6840: infra: edge zones
DaanHoogland commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1082594654
##
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##
@@ -1251,6 +1256,12 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume)
throws ResourceAllocationExc
SnapshotInfo snapshotOnPrimary =
snapshotStrategy.takeSnapshot(snapshot);
boolean backupSnapToSecondary =
SnapshotInfo.BackupSnapshotAfterTakingSnapshot.value() == null ||
SnapshotInfo.BackupSnapshotAfterTakingSnapshot.value();
+if (backupSnapToSecondary) {
+DataCenterVO zone =
dataCenterDao.findById(snapshot.getDataCenterId());
+if (DataCenter.Type.Edge.equals(zone.getType())) {
+backupSnapToSecondary = false;
+}
+}
Review Comment:
@shwstppr can you put this in a separate method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6840: infra: edge zones
DaanHoogland commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1082592597
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -2164,46 +2167,56 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_POD_CREATE, eventDescription =
"creating pod", async = false)
Review Comment:
@shwstppr can you disect this method in smaller parts?
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -1402,54 +1402,56 @@ protected void checkIfPodIsDeletable(final long podId) {
}
}
-private void checkPodAttributes(final long podId, final String podName,
final long zoneId, final String gateway, final String cidr, final String
startIp, final String endIp, final String allocationStateStr,
Review Comment:
@shwstppr can you disect this method in smaller parts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6840: infra: edge zones
DaanHoogland commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1082575583
##
plugins/hypervisors/simulator/src/main/java/com/cloud/agent/manager/MockAgentManagerImpl.java:
##
@@ -106,7 +111,13 @@ public class MockAgentManagerImpl extends ManagerBase
implements MockAgentManage
private Pair getPodCidr(long podId, long dcId) {
try {
-
+DataCenterVO zone = dcDao.findById(dcId);
+if (DataCenter.Type.Edge.equals(zone.getType())) {
+SecureRandom random = new SecureRandom();
Review Comment:
will you apply this @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings
blueorangutan commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1398436875 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings
DaanHoogland commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1398435724 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
blueorangutan commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398434500 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC
weizhouapache commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1082554632
##
api/src/main/java/com/cloud/network/Network.java:
##
@@ -268,6 +268,7 @@ public static class Capability {
public static final Capability LoadBalancingSupportedIps = new
Capability("LoadBalancingSupportedIps");
public static final Capability AllowDnsSuffixModification = new
Capability("AllowDnsSuffixModification");
public static final Capability RedundantRouter = new
Capability("RedundantRouter");
+public static final Capability SelectSnatIpAllowed = new
Capability("SelectSnatIpAllowed");
Review Comment:
The capability name seems inconsistent with other capabilities.
Maybe better to use AllowSpecificSourceNatIp or just SpecifySourceNatIp
##
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##
@@ -931,6 +931,7 @@ public class ApiConstants {
public static final String LOGIN = "login";
public static final String LOGOUT = "logout";
public static final String LIST_IDPS = "listIdps";
+public static final String IS_SELECTION_OF_STATIC_NAT_ALLOWED =
"selectsnatipallowed";
Review Comment:
I think it is Source Nat IP, not Static Nat Ip, right ?
##
api/src/main/java/org/apache/cloudstack/api/response/NetworkOfferingResponse.java:
##
@@ -143,6 +143,10 @@ public class NetworkOfferingResponse extends
BaseResponseWithAnnotations {
@Param(description = "the internet protocol of the network offering")
private String internetProtocol;
+@SerializedName(ApiConstants.IS_SELECTION_OF_STATIC_NAT_ALLOWED)
Review Comment:
Better to use SourceNat instead of Snat
##
engine/schema/src/main/java/com/cloud/offerings/NetworkOfferingVO.java:
##
@@ -165,6 +165,17 @@ public String getDisplayText() {
@Column(name="service_package_id")
String servicePackageUuid = null;
+@Column(name = "select_snat_address_allowed")
Review Comment:
Can we use network offering details instead of a new column ?
well, it means lots of changes maybe
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -1462,12 +1480,12 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
}
}
-if (ntwkOff.getGuestType() != GuestType.Shared &&
(!StringUtils.isAllBlank(routerIp, routerIpv6))) {
-throw new InvalidParameterValueException("Router IP can be
specified only for Shared networks");
+if (ntwkOff.getGuestType() == GuestType.L2 &&
(!StringUtils.isAllBlank(cmd.getRouterIPv4(), cmd.getRouterIPv6( {
Review Comment:
Is there a validation for isolated networks source
nat support and capabilities here ?
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -1289,15 +1289,12 @@ private void checkSharedNetworkCidrOverlap(Long zoneId,
long physicalNetworkId,
}
}
-private void validateRouterIps(String routerIp, String routerIpv6, String
startIp, String endIp, String gateway,
- String netmask, String startIpv6, String
endIpv6, String ip6Cidr) {
+private void validateSharedRouterIPv4(String routerIp, String startIp,
String endIp, String gateway, String netmask) {
Review Comment:
SharedNetwork instead of only Shared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
DaanHoogland commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398434261 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings
sonarcloud[bot] commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1398392072 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6748) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6748=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6748=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6748=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6748=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6748=new_coverage=list) [5.9% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6748=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6748=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6748=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC
DaanHoogland commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1398386037 @weizhouapache please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings
blueorangutan commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1398376595 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7114: cloudstack-setup-agent: mask libvirt non-monolithic services
codecov[bot] commented on PR #7114: URL: https://github.com/apache/cloudstack/pull/7114#issuecomment-1398370670 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7114](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f622506) into [main](https://codecov.io/gh/apache/cloudstack/commit/e8c32d68fcb03c0fd695aa72fb6a22de63c96db4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e8c32d6) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main#7114 +/- ## - Coverage 11.78% 11.77% -0.01% + Complexity 7668 7667 -1 Files 2503 2505 +2 Lines245981 246153 +172 Branches 3838038429 +49 + Hits 2898828994 +6 - Misses 213222 213387 +165 - Partials 3771 3772 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...com/cloud/agent/manager/ConnectedAgentAttache.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvbWFuYWdlci9Db25uZWN0ZWRBZ2VudEF0dGFjaGUuamF2YQ==) | `25.00% <0.00%> (-12.50%)` | :arrow_down: | | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: | | [...ain/java/com/cloud/consoleproxy/AgentHookBase.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbnNvbGVwcm94eS9BZ2VudEhvb2tCYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...a/src/main/java/com/cloud/vm/ConsoleSessionVO.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9Db25zb2xlU2Vzc2lvblZPLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...n/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vQ29uc29sZVNlc3Npb25EYW9JbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...om/cloud/deploy/DeploymentPlanningManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5pbmdNYW5hZ2VySW1wbC5qYXZh) | `28.92% <0.00%> (+0.75%)` | :arrow_up: | | [...udstack/consoleproxy/ConsoleAccessManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7114?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2NvbnNvbGVwcm94eS9Db25zb2xlQWNjZXNzTWFuYWdlckltcGwuamF2YQ==) | `6.32% <0.00%> (+0.77%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1398358906 > @wido That in my view > > > Overall it is looking good. > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or example. Do we maybe need to set some lower and upper limits? > > @wido That is a good idea, but I'm not sure if there is a good way to validate the settings. Do you have any suggestion, where I can run those validations? @soreana can you add a setting for that? @wido @weizhouapache is this really needed? this is an operator action anyway, isn´t it? they should know how to tune their cloud!?! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
DaanHoogland commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1398354946 @borisstoyanov , you approved based on manual testing, am i right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
