[GitHub] anshul1886 closed pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator?

2017-07-24 Thread git
anshul1886 closed pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator? URL: https://github.com/apache/cloudstack/pull/1835 This is an automated message from the Apache Git Service. To

[GitHub] anshul1886 opened a new pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator?

2017-07-24 Thread git
anshul1886 opened a new pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator? URL: https://github.com/apache/cloudstack/pull/1835 ? so that appropraite checks are made Also, make detached disk to go through findStoragePoolsForMigration API from

[GitHub] cloudmonger commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

2017-07-24 Thread git
cloudmonger commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-317132565 ### ACS CI BVT Run **Sumarry:** Build Number 994 Hypervisor xenserver NetworkType Advanced

[GitHub] cloudmonger commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

2017-07-24 Thread git
cloudmonger commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-317631490 ### ACS CI BVT Run **Sumarry:** Build Number 1007 Hypervisor xenserver NetworkType Advanced

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-07-24 Thread git
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-317627617 Trillian test result (tid-1244) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #2039: rbd: Use libvirt to create new volumes and not rados-java

2017-07-24 Thread git
blueorangutan commented on issue #2039: rbd: Use libvirt to create new volumes and not rados-java URL: https://github.com/apache/cloudstack/pull/2039#issuecomment-317613085 Trillian test result (tid-1247) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] blueorangutan commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console

2017-07-24 Thread git
blueorangutan commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-317604669 Trillian test result (tid-1243) Environment: kvm-centos7 (x2), Advanced

[GitHub] blueorangutan commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy

2017-07-24 Thread git
blueorangutan commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy URL: https://github.com/apache/cloudstack/pull/2177#issuecomment-317596193 Trillian test result (tid-1242) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] cloudmonger commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
cloudmonger commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317584046 ### ACS CI BVT Run **Sumarry:** Build Number 1006 Hypervisor xenserver NetworkType

[GitHub] cloudmonger commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
cloudmonger commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-316453921 ### ACS CI BVT Run **Sumarry:** Build Number 985 Hypervisor xenserver NetworkType

[GitHub] Slair1 opened a new pull request #2201: CLOUDSTACK-10016: VPC VR doesn't respond to DNS requests from remote access vpn clients

2017-07-24 Thread git
Slair1 opened a new pull request #2201: CLOUDSTACK-10016: VPC VR doesn't respond to DNS requests from remote access vpn clients URL: https://github.com/apache/cloudstack/pull/2201 When enabling remote access VPN, a new interface is created upon client connecting via VPN. The DNS service

[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

2017-07-24 Thread git
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-317539514 @borisstoyanov and @rhtyd, can you please kick off the test suite again now that we have added more comprehensive

[GitHub] resmo commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
resmo commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#discussion_r129118274 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh

[GitHub] resmo commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
resmo commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#discussion_r129118274 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh

[GitHub] rhtyd commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check

2017-07-24 Thread git
rhtyd commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check URL: https://github.com/apache/cloudstack/pull/2199#issuecomment-317512799 LGTM, @borisstoyanov Travis failed for some reason. This

[GitHub] rhtyd commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check

2017-07-24 Thread git
rhtyd commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check URL: https://github.com/apache/cloudstack/pull/2199#issuecomment-317512799 LGTM, @borisstoyanov Travis failed for some reason - I'll rekick it.

[GitHub] rhtyd commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
rhtyd commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#discussion_r129116498 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh

[GitHub] cloudmonger commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage'

2017-07-24 Thread git
cloudmonger commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage' URL: https://github.com/apache/cloudstack/pull/2188#issuecomment-317059440 ### ACS CI BVT Run

[GitHub] cloudmonger commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage'

2017-07-24 Thread git
cloudmonger commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage' URL: https://github.com/apache/cloudstack/pull/2188#issuecomment-317495958 ### ACS CI BVT Run

[GitHub] blueorangutan commented on issue #2182: CLOUDSTACK-10000: FIX remote access vpn does not work due to '#' in password

2017-07-24 Thread git
blueorangutan commented on issue #2182: CLOUDSTACK-1: FIX remote access vpn does not work due to '#' in password URL: https://github.com/apache/cloudstack/pull/2182#issuecomment-317495704 Trillian test result (tid-1240) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt

[GitHub] blueorangutan commented on issue #2052: [4.9] Backported fixes for 4.9.3.0 release effort

2017-07-24 Thread git
blueorangutan commented on issue #2052: [4.9] Backported fixes for 4.9.3.0 release effort URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-317494015 Trillian test result (tid-1236) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time

[GitHub] blueorangutan commented on issue #2052: [4.9] Backported fixes for 4.9.3.0 release effort

2017-07-24 Thread git
blueorangutan commented on issue #2052: [4.9] Backported fixes for 4.9.3.0 release effort URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-317490447 Trillian test result (tid-1238) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] DaanHoogland commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317480494 @fmaximus thanks for the review. good quality improvements arose ;) This is

[GitHub] blueorangutan commented on issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygroupnames must be given

2017-07-24 Thread git
blueorangutan commented on issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygroupnames must be given URL: https://github.com/apache/cloudstack/pull/1798#issuecomment-317472400 Trillian test result (tid-1241) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt

[GitHub] resmo commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
resmo commented on a change in pull request #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#discussion_r129078779 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh

[GitHub] DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129075655 ## File path: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java

[GitHub] DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129075275 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129075115 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129069064 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129068941 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] borisstoyanov commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check

2017-07-24 Thread git
borisstoyanov commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check URL: https://github.com/apache/cloudstack/pull/2199#issuecomment-317453178 @rhtyd done This is an automated message from

[GitHub] syed opened a new pull request #2200: [CLOUDSTACK-10015] Return storage provider with response to list storage pools

2017-07-24 Thread git
syed opened a new pull request #2200: [CLOUDSTACK-10015] Return storage provider with response to list storage pools URL: https://github.com/apache/cloudstack/pull/2200 It would be useful if we return the provider name in the list storage pools response. This will be useful for

[GitHub] borisstoyanov commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check

2017-07-24 Thread git
borisstoyanov commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check URL: https://github.com/apache/cloudstack/pull/2199#issuecomment-317441910 yes @rhtyd, makes sense. This is an automated

[GitHub] borisstoyanov commented on issue #2146: [WIP] multidisk ova import

2017-07-24 Thread git
borisstoyanov commented on issue #2146: [WIP] multidisk ova import URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-317441455 hi bhai, This is one of the assumptions and limitations, you can checkout the spec in the description.

[GitHub] blueorangutan commented on issue #2052: [4.9] Backported fixes for 4.9.3.0 release effort

2017-07-24 Thread git
blueorangutan commented on issue #2052: [4.9] Backported fixes for 4.9.3.0 release effort URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-317440006 Trillian test result (tid-1237) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129041647 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129045100 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129040449 ## File path: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java ##

[GitHub] fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129040157 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129044605 ## File path: api/src/com/cloud/network/PhysicalNetwork.java ## @@ -32,8 +35,82 @@ Disabled,

[GitHub] priyankparihar commented on issue #2146: [WIP] multidisk ova import

2017-07-24 Thread git
priyankparihar commented on issue #2146: [WIP] multidisk ova import URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-317432401 Hi @borisroman Bro, Have you tested the case where OVA(Template) has multiple disks but first disk is not boot disk ?

[GitHub] rhtyd commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check

2017-07-24 Thread git
rhtyd commented on issue #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check URL: https://github.com/apache/cloudstack/pull/2199#issuecomment-317432177 @borisstoyanov can you instead call the other API (getUserKeys from https://github.com/apache/cloudstack/pull/1996) to do

[GitHub] borisstoyanov opened a new pull request #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check

2017-07-24 Thread git
borisstoyanov opened a new pull request #2199: CLOUDSTACK-10014: Fix test accounts remove secret key check URL: https://github.com/apache/cloudstack/pull/2199 ?_same_account: remove secret key checks since it was removed from the API response Removing secret key as it's not part of the

[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

2017-07-24 Thread git
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-317427843 I will be adding S2S VPN tests to this PR because even though the community tests are passing, we have CI tests that

[GitHub] blueorangutan commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy

2017-07-24 Thread git
blueorangutan commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy URL: https://github.com/apache/cloudstack/pull/2177#issuecomment-317423317 Packaging result: ?centos6 ?centos7 ?debian. JID-857

[GitHub] blueorangutan commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
blueorangutan commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317420451 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
borisstoyanov commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317420412 @blueorangutan test This is an automated message from the Apache Git

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317418952 @wido still failing, please do a clean rebuild, check Travis?

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317418744 Packaging result: ?centos6 ?centos7 ?debian. JID-856

[GitHub] rhtyd commented on issue #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack

2017-07-24 Thread git
rhtyd commented on issue #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack URL: https://github.com/apache/cloudstack/pull/2197#issuecomment-317417322 @wido thanks, this does not work as of now and needs some further changes. I wanted to start and do this in open to gather some initial

[GitHub] rhtyd commented on issue #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
rhtyd commented on issue #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#issuecomment-317417055 @wido not yet, still in progress. I'm unable to get partitioning work right, I've asked veewee authors to help with a base

[GitHub] blueorangutan commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy

2017-07-24 Thread git
blueorangutan commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy URL: https://github.com/apache/cloudstack/pull/2177#issuecomment-317417047 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy

2017-07-24 Thread git
rhtyd commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy URL: https://github.com/apache/cloudstack/pull/2177#issuecomment-317416826 @blueorangutan package This is an automated message from

[GitHub] wido commented on a change in pull request #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack

2017-07-24 Thread git
wido commented on a change in pull request #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack URL: https://github.com/apache/cloudstack/pull/2197#discussion_r129029235 ## File path: packaging/cloud-management.sh ## @@ -0,0 +1,58 @@ +#!/bin/bash + + .

[GitHub] wido commented on a change in pull request #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack

2017-07-24 Thread git
wido commented on a change in pull request #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack URL: https://github.com/apache/cloudstack/pull/2197#discussion_r129028390 ## File path: packaging/cloud-management.sh ## @@ -0,0 +1,58 @@ +#!/bin/bash + + .

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317415251 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317415031 @blueorangutan package This is an

[GitHub] wido commented on issue #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
wido commented on issue #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#issuecomment-317415030 Looking good! We will probably need a few systemd services with the type OneShot as well, for cloud-early-config and such.

[GitHub] wido commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy

2017-07-24 Thread git
wido commented on issue #2177: CLOUDSTACK-9977: Enhance SSL protocol used by Console Proxy URL: https://github.com/apache/cloudstack/pull/2177#issuecomment-317414631 LGTM! I think that any client that doesn't support TLSv1.2 shouldn't be out there anyway.

[GitHub] wido commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
wido commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317402497 Fixed @rhtyd [INFO]

[GitHub] rhtyd commented on issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on agent disconnect

2017-07-24 Thread git
rhtyd commented on issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on agent disconnect URL: https://github.com/apache/cloudstack/pull/1640#issuecomment-317399420 @marcaurele okay I read the commentary, given the original bug was seen in 4.4x environment and in 4.9+ codebase,

[GitHub] cloudmonger commented on issue #2196: python-version: use system default python version

2017-07-24 Thread git
cloudmonger commented on issue #2196: python-version: use system default python version URL: https://github.com/apache/cloudstack/pull/2196#issuecomment-317398588 ### ACS CI BVT Run **Sumarry:** Build Number 1004 Hypervisor xenserver NetworkType Advanced Passed=106

[GitHub] blueorangutan commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
blueorangutan commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317389509 Packaging result: ?centos6 ?centos7 ?debian. JID-855 This is an automated

[GitHub] niteshsarda commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage'

2017-07-24 Thread git
niteshsarda commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage' URL: https://github.com/apache/cloudstack/pull/2188#issuecomment-317388768 @SudharmaJain : I have removed

[cloudstack] 01/02: Merge branch '4.9' into 4.10

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 83e9de4bfd51f0dea4cf02aa390fbf3148515e30 Merge: c1e5cb3 de0d1c7 Author: Rohit Yadav

[cloudstack] branch master updated (bef5c17 -> c384239)

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from bef5c17 CLOUDSTACK-9982: Introduce new response parameter: PhysicalSize in listTemplates API response

[cloudstack] branch 4.10 updated (c1e5cb3 -> 83e9de4)

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch 4.10 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c1e5cb3 Merge remote-tracking branch 'origin/4.9' into 4.10 add 90e7cab FIX3: Consider overcommit ratios

[cloudstack] 02/02: Merge branch '4.10'

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit c384239a058fc658081ac7334465b65704028b9a Merge: bef5c17 83e9de4 Author: Rohit Yadav

[cloudstack] branch 4.9 updated: CLOUDSTACK-9985: Allow creation of roles with names of deleted roles

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch 4.9 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.9 by this push: new de0d1c7 CLOUDSTACK-9985: Allow creation of

[GitHub] rhtyd closed pull request #2167: CLOUDSTACK-9985: Allow creation of roles with names of deleted roles

2017-07-24 Thread git
rhtyd closed pull request #2167: CLOUDSTACK-9985: Allow creation of roles with names of deleted roles URL: https://github.com/apache/cloudstack/pull/2167 This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd closed pull request #2168: CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values

2017-07-24 Thread git
rhtyd closed pull request #2168: CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values URL: https://github.com/apache/cloudstack/pull/2168 This is an automated message from the Apache Git Service. To

[cloudstack] branch 4.9 updated: FIX3: Consider overcommit ratios with total/threshold values for host metrics

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch 4.9 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.9 by this push: new 90e7cab FIX3: Consider overcommit ratios with

[GitHub] rhtyd commented on issue #2167: CLOUDSTACK-9985: Allow creation of roles with names of deleted roles

2017-07-24 Thread git
rhtyd commented on issue #2167: CLOUDSTACK-9985: Allow creation of roles with names of deleted roles URL: https://github.com/apache/cloudstack/pull/2167#issuecomment-317385142 Test LGTM. This is an automated message from

[GitHub] blueorangutan commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
blueorangutan commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317384711 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
borisstoyanov commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317384610 @blueorangutan package This is an automated message from the Apache Git

[GitHub] DaanHoogland commented on issue #2193: CLOUDSTACK-10007 Isolation methods

2017-07-24 Thread git
DaanHoogland commented on issue #2193: CLOUDSTACK-10007 Isolation methods URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-317373805 @fmaximus don't forget to rigorously look at this in terms of nuage's plugin ;)

[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-07-24 Thread git
blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-317372074 Packaging result: ?centos6 ?centos7 ?debian. JID-854

[GitHub] rashmidixit commented on issue #1848: CLOUDSTACK-9693 Cluster View - Status symbol does not change based on Cluster state

2017-07-24 Thread git
rashmidixit commented on issue #1848: CLOUDSTACK-9693 Cluster View - Status symbol does not change based on Cluster state URL: https://github.com/apache/cloudstack/pull/1848#issuecomment-317363734 @rhtyd I have been a little busy. Will check and get back to @karuturi on her question.

[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-07-24 Thread git
blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-317361789 Packaging result: ?centos6 ?centos7 ?debian. JID-853

[GitHub] marcaurele commented on issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on agent disconnect

2017-07-24 Thread git
marcaurele commented on issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on agent disconnect URL: https://github.com/apache/cloudstack/pull/1640#issuecomment-317360356 @rhtyd I think this PR is in need of a judge ? to merge or close it ;-) To be honest I won't be pushing hard

[GitHub] anshul1886 opened a new pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator?

2017-07-24 Thread git
anshul1886 opened a new pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator? URL: https://github.com/apache/cloudstack/pull/1835 ? so that appropraite checks are made Also, make detached disk to go through findStoragePoolsForMigration API from

[GitHub] anshul1886 closed pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator?

2017-07-24 Thread git
anshul1886 closed pull request #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator? URL: https://github.com/apache/cloudstack/pull/1835 This is an automated message from the Apache Git Service. To

[GitHub] rhtyd commented on issue #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate

2017-07-24 Thread git
rhtyd commented on issue #2198: CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate URL: https://github.com/apache/cloudstack/pull/2198#issuecomment-317358413 Linked request: https://github.com/jedi4ever/veewee/issues/1106

[GitHub] rhtyd commented on issue #2168: CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values

2017-07-24 Thread git
rhtyd commented on issue #2168: CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values URL: https://github.com/apache/cloudstack/pull/2168#issuecomment-317358142 Test LGTM, no new failures, existing failures are known intermittent failures.

[GitHub] rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-07-24 Thread git
rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-317357967 @wido just a suggestion, we can move it possibly in some utils? (in the cloud-utils module?)

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317357479 @wido it's a build failure issue, please see travis (job#1) failure: ``` [INFO] Compiling 45

[GitHub] rhtyd commented on issue #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack

2017-07-24 Thread git
rhtyd commented on issue #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack URL: https://github.com/apache/cloudstack/pull/2197#issuecomment-317356916 @marcaurele thanks, any help would be great. The important goal is to move away from distro provided tomcat, I'm open to all possible

[GitHub] marcaurele commented on issue #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack

2017-07-24 Thread git
marcaurele commented on issue #2197: CLOUDSTACK-10012: Embedded Jetty for CloudStack URL: https://github.com/apache/cloudstack/pull/2197#issuecomment-317355444 @rhtyd What's the reason to create another (sub)module of the client, instead of adding a profile to the client module to either

[GitHub] wido commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-07-24 Thread git
wido commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-317353668 @rhtyd We could do that maybe, but I don't know where RULE_COMMAND_SEPARATOR would need to be defined globally?

[GitHub] wido commented on a change in pull request #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-07-24 Thread git
wido commented on a change in pull request #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#discussion_r128976219 ## File path: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ## @@

[GitHub] wido commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-07-24 Thread git
wido commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-317346657 @rhtyd: I went through the logs, but there is nothing that I can find that points to this PR. What I

[GitHub] blueorangutan commented on issue #2168: CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values

2017-07-24 Thread git
blueorangutan commented on issue #2168: CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values URL: https://github.com/apache/cloudstack/pull/2168#issuecomment-317344796 Trillian test result (tid-1235) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server

[GitHub] blueorangutan commented on issue #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway

2017-07-24 Thread git
blueorangutan commented on issue #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway URL: https://github.com/apache/cloudstack/pull/2157#issuecomment-317342922 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway

2017-07-24 Thread git
rhtyd commented on issue #2157: CLOUDSTACK-9961: Fixed adding domain in vpn customer gateway URL: https://github.com/apache/cloudstack/pull/2157#issuecomment-317342724 @blueorangutan test This is an automated message from

[GitHub] rhtyd commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible

2017-07-24 Thread git
rhtyd commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible URL: https://github.com/apache/cloudstack/pull/2047#issuecomment-317342622 LGTM based on tests, @DaanHoogland @borisstoyanov ? This is an

[GitHub] rhtyd closed pull request #2164: CLOUDSTACK-9982: Introduce PhysicalSize as response in listTemplates API

2017-07-24 Thread git
rhtyd closed pull request #2164: CLOUDSTACK-9982: Introduce PhysicalSize as response in listTemplates API URL: https://github.com/apache/cloudstack/pull/2164 This is an automated message from the Apache Git Service. To

[cloudstack] branch master updated: CLOUDSTACK-9982: Introduce new response parameter: PhysicalSize in listTemplates API response

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new bef5c17 CLOUDSTACK-9982: Introduce new

[GitHub] rhtyd commented on issue #2164: CLOUDSTACK-9982: Introduce PhysicalSize as response in listTemplates API

2017-07-24 Thread git
rhtyd commented on issue #2164: CLOUDSTACK-9982: Introduce PhysicalSize as response in listTemplates API URL: https://github.com/apache/cloudstack/pull/2164#issuecomment-317340850 One travis failure is not caused by this PR, but by the PR which removed secret key from user response.

[GitHub] rhtyd commented on issue #2164: CLOUDSTACK-9982: Introduce PhysicalSize as response in listTemplates API

2017-07-24 Thread git
rhtyd commented on issue #2164: CLOUDSTACK-9982: Introduce PhysicalSize as response in listTemplates API URL: https://github.com/apache/cloudstack/pull/2164#issuecomment-317340715 LGTM. This is an automated message from the

[cloudstack] branch master updated: CLOUDSTACK-9667 Enable resourcecount.check.interval by default

2017-07-24 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new d98520a CLOUDSTACK-9667 Enable

  1   2   >