[GitHub] GabrielBrascher commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

[git]

GabrielBrascher commented on issue #1448: CLOUDSTACK-9315: Removed unused 
Classes 
URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-320151622
 
 
   Rebased against latest master. Thanks @rhtyd.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2182: CLOUDSTACK-10000: FIX remote access vpn does not work due to '#' in password

[git]

GabrielBrascher commented on issue #2182: CLOUDSTACK-1: FIX remote access 
vpn does not work due to '#' in password
URL: https://github.com/apache/cloudstack/pull/2182#issuecomment-320144723
 
 
   Thanks @ustcweizhou, code LGTM. Please check the test failure as pointed by 
@rhtyd.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on a change in pull request #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

[git]

GabrielBrascher commented on a change in pull request #2185: CLOUDSTACK-9976: 
Redirect saml2 failed login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#discussion_r131302156
 
 

 ##
 File path: setup/db/db/schema-41000to41100.sql
 ##
 @@ -18,3 +18,6 @@
 --;
 -- Schema upgrade from 4.10.0.0 to 4.11.0.0
 --;
+
+-- CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL
 
 Review comment:
   Thanks for the hint @rhtyd !
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher opened a new pull request #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains

[git]

GabrielBrascher opened a new pull request #: CLOUDSTACK-10022: Allow domain 
admin to create and delete subdomains
URL: https://github.com/apache/cloudstack/pull/
 
 
   This change allows a domain admin to create and delete subdomains; the 
domain admin cannot delete its own domain.
   
   To do that, two files have been changed:
   (i) _schema-41000to41100.sql:_ two rows were added in table 
_role_permissions_, allowing the Domain Admin role (id: 3) to execute API 
commands 'createDomain' and 'deleteDomain';
   (ii) _domains.js:_ enable buttons for creating and deleting domain in the 
CloudStack UI.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290782
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/vnc/VncClient.java
 ##
 @@ -16,6 +16,16 @@
 // under the License.
 package com.cloud.consoleproxy.vnc;
 
+import com.cloud.consoleproxy.ConsoleProxyClientListener;
 
 Review comment:
   Nothing changed in this file, just rearranged a bunch of stuff. Can you 
revert this file back, we don't need it.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290366
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/WebSocketHandlerForNovnc.java
 ##
 @@ -0,0 +1,505 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.consoleproxy;
+
+import com.cloud.consoleproxy.vnc.RfbConstants;
+import org.apache.log4j.Logger;
+import org.eclipse.jetty.server.Request;
+import org.eclipse.jetty.websocket.api.Session;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketConnect;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketClose;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketFrame;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketError;
+import org.eclipse.jetty.websocket.api.annotations.WebSocket;
+import org.eclipse.jetty.websocket.api.extensions.Frame;
+import org.eclipse.jetty.websocket.common.WebSocketSession;
+import org.eclipse.jetty.websocket.server.WebSocketHandler;
+import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+
+import javax.crypto.Cipher;
+import javax.crypto.SecretKey;
+import javax.crypto.SecretKeyFactory;
+import javax.crypto.spec.DESKeySpec;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.net.Socket;
+import java.nio.ByteBuffer;
+import java.security.spec.KeySpec;
+import java.util.Map;
+
+/**
+ * Created by root on 18/6/17.
+ */
+
+@WebSocket
+public class WebSocketHandlerForNovnc extends WebSocketHandler {
+
+
+public static final Logger s_logger = 
Logger.getLogger(WebSocketHandlerForNovnc.class.getSimpleName());
+private Socket vncSocket;
+private DataInputStream is;
+private DataOutputStream os;
+private Session session;
+private boolean isConnectionStart = false;
+private int frameCount;
+private String hostPassword;
+private int authType;
+
+private static enum VncState {
+SERVER_VERSION_SENT, AUTH_TYPES_SENT, AUTH_RESULT_SENT, UNKNOWN
+}
+private static final byte[] M_VNC_AUTH_OK = new byte[]{0, 0, 0, 0};
+private static final byte[] M_VNC_AUTH_TYE_NOAUTH = new byte[]{01, 01};
+private VncState clientState;
+
+/**
+ * Reverse bits in byte, so least significant bit will be most significant
+ * bit. E.g. 01001100 will become 00110010.
+ * 
+ * See also: http://www.vidarholen.net/contents/junk/vnc.html ,
+ * http://bytecrafter
+ * .blogspot.com/2010/09/des-encryption-as-used-in-vnc.html
+ *
+ * @param b a byte
+ * @return byte in reverse order
+ */
+private static byte flipByte(byte b) {
+int b1_8 = (b & 0x1) << 7;
+int b2_7 = (b & 0x2) << 5;
+int b3_6 = (b & 0x4) << 3;
+int b4_5 = (b & 0x8) << 1;
+int b5_4 = (b & 0x10) >>> 1;
+int b6_3 = (b & 0x20) >>> 3;
+int b7_2 = (b & 0x40) >>> 5;
+int b8_1 = (b & 0x80) >>> 7;
+byte c = (byte) (b1_8 | b2_7 | b3_6 | b4_5 | b5_4 | b6_3 | b7_2 | 
b8_1);
+return c;
+}
+
+@Override
+public void configure(WebSocketServletFactory webSocketServletFactory) {
+webSocketServletFactory.register(WebSocketHandlerForNovnc.class);
+}
+
+@Override
+public void handle(String target, Request baseRequest, HttpServletRequest 
request, HttpServletResponse response) throws IOException, ServletException {
+if (this.getWebSocketFactory().isUpgradeRequest(request, response)) {
+response.addHeader("Sec-WebSocket-Protocol", "binary");
+if (this.getWebSocketFactory().acceptWebSocket(request, response)) 
{
+baseRequest.setHandled(true);
+return;
+}
+
+if (response.isCommitted()) {
+return;
+}
+}
+}
+
+@OnWebSocketConnect
+public void onConnect(final Session session) throws IOException, 
InterruptedException {
+
+

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290552
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/WebSocketHandlerForNovnc.java
 ##
 @@ -0,0 +1,505 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.consoleproxy;
+
+import com.cloud.consoleproxy.vnc.RfbConstants;
+import org.apache.log4j.Logger;
+import org.eclipse.jetty.server.Request;
+import org.eclipse.jetty.websocket.api.Session;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketConnect;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketClose;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketFrame;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketError;
+import org.eclipse.jetty.websocket.api.annotations.WebSocket;
+import org.eclipse.jetty.websocket.api.extensions.Frame;
+import org.eclipse.jetty.websocket.common.WebSocketSession;
+import org.eclipse.jetty.websocket.server.WebSocketHandler;
+import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+
+import javax.crypto.Cipher;
+import javax.crypto.SecretKey;
+import javax.crypto.SecretKeyFactory;
+import javax.crypto.spec.DESKeySpec;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.net.Socket;
+import java.nio.ByteBuffer;
+import java.security.spec.KeySpec;
+import java.util.Map;
+
+/**
+ * Created by root on 18/6/17.
+ */
+
+@WebSocket
+public class WebSocketHandlerForNovnc extends WebSocketHandler {
+
+
+public static final Logger s_logger = 
Logger.getLogger(WebSocketHandlerForNovnc.class.getSimpleName());
+private Socket vncSocket;
+private DataInputStream is;
+private DataOutputStream os;
+private Session session;
+private boolean isConnectionStart = false;
+private int frameCount;
+private String hostPassword;
+private int authType;
+
+private static enum VncState {
+SERVER_VERSION_SENT, AUTH_TYPES_SENT, AUTH_RESULT_SENT, UNKNOWN
+}
+private static final byte[] M_VNC_AUTH_OK = new byte[]{0, 0, 0, 0};
+private static final byte[] M_VNC_AUTH_TYE_NOAUTH = new byte[]{01, 01};
+private VncState clientState;
+
+/**
+ * Reverse bits in byte, so least significant bit will be most significant
+ * bit. E.g. 01001100 will become 00110010.
+ * 
+ * See also: http://www.vidarholen.net/contents/junk/vnc.html ,
+ * http://bytecrafter
+ * .blogspot.com/2010/09/des-encryption-as-used-in-vnc.html
+ *
+ * @param b a byte
+ * @return byte in reverse order
+ */
+private static byte flipByte(byte b) {
+int b1_8 = (b & 0x1) << 7;
+int b2_7 = (b & 0x2) << 5;
+int b3_6 = (b & 0x4) << 3;
+int b4_5 = (b & 0x8) << 1;
+int b5_4 = (b & 0x10) >>> 1;
+int b6_3 = (b & 0x20) >>> 3;
+int b7_2 = (b & 0x40) >>> 5;
+int b8_1 = (b & 0x80) >>> 7;
+byte c = (byte) (b1_8 | b2_7 | b3_6 | b4_5 | b5_4 | b6_3 | b7_2 | 
b8_1);
+return c;
+}
+
+@Override
+public void configure(WebSocketServletFactory webSocketServletFactory) {
+webSocketServletFactory.register(WebSocketHandlerForNovnc.class);
+}
+
+@Override
+public void handle(String target, Request baseRequest, HttpServletRequest 
request, HttpServletResponse response) throws IOException, ServletException {
+if (this.getWebSocketFactory().isUpgradeRequest(request, response)) {
+response.addHeader("Sec-WebSocket-Protocol", "binary");
+if (this.getWebSocketFactory().acceptWebSocket(request, response)) 
{
+baseRequest.setHandled(true);
+return;
+}
+
+if (response.isCommitted()) {
+return;
+}
+}
+}
+
+@OnWebSocketConnect
+public void onConnect(final Session session) throws IOException, 
InterruptedException {
+
+

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131289911
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyBaseServerFactoryImpl.java
 ##
 @@ -33,10 +32,50 @@ public void init(byte[] ksBits, String ksPassword) {
 }
 
 @Override
-public HttpServer createHttpServerInstance(int port) throws IOException {
-if (s_logger.isInfoEnabled())
-s_logger.info("create HTTP server instance at port: " + port);
-return HttpServer.create(new InetSocketAddress(port), 5);
+public Server createHttpServerInstance(int port) throws IOException {
+Server webServer = new Server(port);
+Handler[] handlerList =  new Handler[6];
+
+// new context handler for get screen
+ContextHandler contextHandlerForScreen = new ContextHandler();
 
 Review comment:
   Move all the `ContextHandlers` to `startupHttpMain` function 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290482
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/WebSocketHandlerForNovnc.java
 ##
 @@ -0,0 +1,505 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.consoleproxy;
+
+import com.cloud.consoleproxy.vnc.RfbConstants;
+import org.apache.log4j.Logger;
+import org.eclipse.jetty.server.Request;
+import org.eclipse.jetty.websocket.api.Session;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketConnect;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketClose;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketFrame;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketError;
+import org.eclipse.jetty.websocket.api.annotations.WebSocket;
+import org.eclipse.jetty.websocket.api.extensions.Frame;
+import org.eclipse.jetty.websocket.common.WebSocketSession;
+import org.eclipse.jetty.websocket.server.WebSocketHandler;
+import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+
+import javax.crypto.Cipher;
+import javax.crypto.SecretKey;
+import javax.crypto.SecretKeyFactory;
+import javax.crypto.spec.DESKeySpec;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.net.Socket;
+import java.nio.ByteBuffer;
+import java.security.spec.KeySpec;
+import java.util.Map;
+
+/**
+ * Created by root on 18/6/17.
+ */
+
+@WebSocket
+public class WebSocketHandlerForNovnc extends WebSocketHandler {
+
+
+public static final Logger s_logger = 
Logger.getLogger(WebSocketHandlerForNovnc.class.getSimpleName());
+private Socket vncSocket;
+private DataInputStream is;
+private DataOutputStream os;
+private Session session;
+private boolean isConnectionStart = false;
+private int frameCount;
+private String hostPassword;
+private int authType;
+
+private static enum VncState {
+SERVER_VERSION_SENT, AUTH_TYPES_SENT, AUTH_RESULT_SENT, UNKNOWN
+}
+private static final byte[] M_VNC_AUTH_OK = new byte[]{0, 0, 0, 0};
+private static final byte[] M_VNC_AUTH_TYE_NOAUTH = new byte[]{01, 01};
+private VncState clientState;
+
+/**
+ * Reverse bits in byte, so least significant bit will be most significant
+ * bit. E.g. 01001100 will become 00110010.
+ * 
+ * See also: http://www.vidarholen.net/contents/junk/vnc.html ,
+ * http://bytecrafter
+ * .blogspot.com/2010/09/des-encryption-as-used-in-vnc.html
+ *
+ * @param b a byte
+ * @return byte in reverse order
+ */
+private static byte flipByte(byte b) {
+int b1_8 = (b & 0x1) << 7;
+int b2_7 = (b & 0x2) << 5;
+int b3_6 = (b & 0x4) << 3;
+int b4_5 = (b & 0x8) << 1;
+int b5_4 = (b & 0x10) >>> 1;
+int b6_3 = (b & 0x20) >>> 3;
+int b7_2 = (b & 0x40) >>> 5;
+int b8_1 = (b & 0x80) >>> 7;
+byte c = (byte) (b1_8 | b2_7 | b3_6 | b4_5 | b5_4 | b6_3 | b7_2 | 
b8_1);
+return c;
+}
+
+@Override
+public void configure(WebSocketServletFactory webSocketServletFactory) {
+webSocketServletFactory.register(WebSocketHandlerForNovnc.class);
+}
+
+@Override
+public void handle(String target, Request baseRequest, HttpServletRequest 
request, HttpServletResponse response) throws IOException, ServletException {
+if (this.getWebSocketFactory().isUpgradeRequest(request, response)) {
+response.addHeader("Sec-WebSocket-Protocol", "binary");
+if (this.getWebSocketFactory().acceptWebSocket(request, response)) 
{
+baseRequest.setHandled(true);
+return;
+}
+
+if (response.isCommitted()) {
+return;
+}
+}
+}
+
+@OnWebSocketConnect
+public void onConnect(final Session session) throws IOException, 
InterruptedException {
+
+

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290300
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/WebSocketHandlerForNovnc.java
 ##
 @@ -0,0 +1,505 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.consoleproxy;
+
+import com.cloud.consoleproxy.vnc.RfbConstants;
+import org.apache.log4j.Logger;
+import org.eclipse.jetty.server.Request;
+import org.eclipse.jetty.websocket.api.Session;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketConnect;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketClose;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketFrame;
+import org.eclipse.jetty.websocket.api.annotations.OnWebSocketError;
+import org.eclipse.jetty.websocket.api.annotations.WebSocket;
+import org.eclipse.jetty.websocket.api.extensions.Frame;
+import org.eclipse.jetty.websocket.common.WebSocketSession;
+import org.eclipse.jetty.websocket.server.WebSocketHandler;
+import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+
+import javax.crypto.Cipher;
+import javax.crypto.SecretKey;
+import javax.crypto.SecretKeyFactory;
+import javax.crypto.spec.DESKeySpec;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.net.Socket;
+import java.nio.ByteBuffer;
+import java.security.spec.KeySpec;
+import java.util.Map;
+
+/**
 
 Review comment:
   Remove all the comments that say "created by root"
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290155
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java
 ##
 @@ -76,34 +86,83 @@ public void init(byte[] ksBits, String ksPassword) {
 }
 
 @Override
-public HttpServer createHttpServerInstance(int port) throws IOException {
-try {
-HttpsServer server = HttpsServer.create(new 
InetSocketAddress(port), 5);
-server.setHttpsConfigurator(new HttpsConfigurator(sslContext) {
-@Override
-public void configure(HttpsParameters params) {
-
-// get the remote address if needed
-InetSocketAddress remote = params.getClientAddress();
-SSLContext c = getSSLContext();
-
-// get the default parameters
-SSLParameters sslparams = c.getDefaultSSLParameters();
-
-params.setSSLParameters(sslparams);
-params.setProtocols(SSLUtils.getRecommendedProtocols());
-params.setCipherSuites(SSLUtils.getRecommendedCiphers());
-// statement above could throw IAE if any params invalid.
-// eg. if app has a UI and parameters supplied by a user.
-}
-});
-
-s_logger.info("create HTTPS server instance on port: " + port);
-return server;
-} catch (Exception ioe) {
-s_logger.error(ioe.toString(), ioe);
-}
-return null;
+public Server createHttpServerInstance(int port) throws IOException {
+Server server = getServerWithContext(port);
+
+/**
+ * add all context here
+ **/
+
+// HTTP Configuration
+HttpConfiguration http = new HttpConfiguration();
+http.addCustomizer(new SecureRequestCustomizer());
+
+// Configuration for HTTPS redirect
+http.setSecurePort(port);
+http.setSecureScheme("https");
+ServerConnector connector = new ServerConnector(server);
+connector.addConnectionFactory(new HttpConnectionFactory(http));
+// Setting HTTP port
+connector.setPort(80);
+
+// HTTPS configuration
+HttpConfiguration https = new HttpConfiguration();
+https.addCustomizer(new SecureRequestCustomizer());
+
+// Configuring the connector
+ServerConnector sslConnector = new ServerConnector(server,
+new SslConnectionFactory(sslContextFactory, "http/1.1"), new 
HttpConnectionFactory(https));
+sslConnector.setPort(port);
+
+// Setting HTTP and HTTPS connectors
+server.setConnectors(new Connector[]{connector, sslConnector});
+return server;
+}
+
+private Server getServerWithContext(int port) {
 
 Review comment:
   Same here, the context will be set in `startHttpMain` for both HTTP and SSL 
connections
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding 
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131290099
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java
 ##
 @@ -76,34 +86,83 @@ public void init(byte[] ksBits, String ksPassword) {
 }
 
 @Override
-public HttpServer createHttpServerInstance(int port) throws IOException {
-try {
-HttpsServer server = HttpsServer.create(new 
InetSocketAddress(port), 5);
-server.setHttpsConfigurator(new HttpsConfigurator(sslContext) {
-@Override
-public void configure(HttpsParameters params) {
-
-// get the remote address if needed
-InetSocketAddress remote = params.getClientAddress();
-SSLContext c = getSSLContext();
-
-// get the default parameters
-SSLParameters sslparams = c.getDefaultSSLParameters();
-
-params.setSSLParameters(sslparams);
-params.setProtocols(SSLUtils.getRecommendedProtocols());
-params.setCipherSuites(SSLUtils.getRecommendedCiphers());
-// statement above could throw IAE if any params invalid.
-// eg. if app has a UI and parameters supplied by a user.
-}
-});
-
-s_logger.info("create HTTPS server instance on port: " + port);
-return server;
-} catch (Exception ioe) {
-s_logger.error(ioe.toString(), ioe);
-}
-return null;
+public Server createHttpServerInstance(int port) throws IOException {
+Server server = getServerWithContext(port);
+
+/**
+ * add all context here
+ **/
+
+// HTTP Configuration
+HttpConfiguration http = new HttpConfiguration();
+http.addCustomizer(new SecureRequestCustomizer());
+
+// Configuration for HTTPS redirect
+http.setSecurePort(port);
+http.setSecureScheme("https");
+ServerConnector connector = new ServerConnector(server);
+connector.addConnectionFactory(new HttpConnectionFactory(http));
+// Setting HTTP port
+connector.setPort(80);
 
 Review comment:
   hardcoded value. Can you move this to a constant or get it some other way?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-320110561
 
 
   Trillian test result (tid-1309)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44834 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2220-t1309-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 51 look OK, 3 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_redundant_VPC_default_routes | `Failure` | 1080.63 | 
test_vpc_redundant.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
433.62 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
442.58 | test_routers_network_ops.py
   test_04_rvpc_privategw_static_routes | `Failure` | 681.03 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 370.03 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 241.60 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 641.31 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 310.93 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 692.53 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 599.19 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1472.41 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 675.37 | test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1159.18 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 30.71 | test_volumes.py
   test_06_download_detached_volume | Success | 55.51 | test_volumes.py
   test_05_detach_volume | Success | 100.22 | test_volumes.py
   test_04_delete_attached_volume | Success | 10.13 | test_volumes.py
   test_03_download_attached_volume | Success | 20.24 | test_volumes.py
   test_02_attach_volume | Success | 59.09 | test_volumes.py
   test_01_create_volume | Success | 441.93 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.16 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 188.91 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 128.88 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 297.15 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.69 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.15 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 55.73 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.14 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 10.12 | test_vm_life_cycle.py
   test_02_start_vm | Success | 30.21 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.12 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 10.12 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 346.90 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.03 | test_templates.py
   test_05_template_permissions | Success | 0.05 | test_templates.py
   test_04_extract_template | Success | 35.40 | test_templates.py
   test_03_delete_template | Success | 5.08 | test_templates.py
   test_02_edit_template | Success | 90.10 | test_templates.py
   test_01_create_template | Success | 100.67 | test_templates.py
   test_10_destroy_cpvm | Success | 261.53 | test_ssvm.py
   test_09_destroy_ssvm | Success | 263.52 | test_ssvm.py
   test_08_reboot_cpvm | Success | 186.30 | test_ssvm.py
   test_07_reboot_ssvm | Success | 157.90 | test_ssvm.py
   test_06_stop_cpvm | Success | 201.60 | test_ssvm.py
   test_05_stop_ssvm | Success | 173.09 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.07 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.04 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 183.87 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 76.16 | test_snapshots.py
   test_04_change_offering_small | Success | 98.35 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
   test_01_create_service_offering | Success | 0.07 | 

[GitHub] rhtyd commented on issue #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.

[git]

rhtyd commented on issue #1870: CLOUDSTACK-9708: Router deployment failed due 
to two threads start VR simultaneously.
URL: https://github.com/apache/cloudstack/pull/1870#issuecomment-320100903
 
 
   @nitin-maharana This is from a test env running tests with the revert on 
#2220. Based on the results, I'll proceed with reverting of the change and fwd 
merge the reverts on 4.9, 4.10, master branches. Kindly re-submit the fix 
consider my comment above. Thanks.
   
   [root@pr2220-t1309-vmware-55u3-marvin marvin]# python tools/xunit-reader.py 
MarvinLogs/ 
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_09_reboot_router | Success | 160.79 | test_routers.py
   test_08_start_router | Success | 135.70 | test_routers.py
   test_07_stop_router | Success | 25.17 | test_routers.py
   test_06_router_advanced | Success | 0.04 | test_routers.py
   test_05_router_basic | Success | 0.03 | test_routers.py
   test_04_restart_network_wo_cleanup | Success | 5.54 | test_routers.py
   test_03_restart_network_cleanup | Success | 180.90 | test_routers.py
   test_02_router_internal_adv | Success | 0.85 | test_routers.py
   test_01_router_internal_basic | Success | 0.42 | test_routers.py
   test_router_dns_guestipquery | Success | 76.72 | test_router_dns.py
   test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
   test_router_dhcphosts | Success | 135.51 | test_router_dhcphosts.py
   test_router_dhcp_opts | Success | 21.36 | test_router_dhcphosts.py
   test_01_nic | Success | 534.47 | test_nic.py
   test_reboot_router | Success | 618.97 | test_network.py
   test_nic_secondaryip_add_remove | Success | 242.11 | 
test_multipleips_per_nic.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.

[git]

rhtyd commented on a change in pull request #1870: CLOUDSTACK-9708: Router 
deployment failed due to two threads start VR simultaneously.
URL: https://github.com/apache/cloudstack/pull/1870#discussion_r131269487
 
 

 ##
 File path: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
 ##
 @@ -192,6 +192,18 @@ void init() {
 JoinBuilder.JoinType.INNER);
 AccountDataCenterVirtualSearch.done();
 
+SearchBuilder nicSearchByNetwork = 
_nicDao.createSearchBuilder();
 
 Review comment:
   @nitin-maharana while your fix may be valid, it seems to be breaking some 
test_nic and test_routers test cases. The issue seems to be another `nicSearch` 
on line 184 which perhaps is used in most cases. You may remove 
`nicSearchByNetwork` which is not useful or used at all depending on the 
original code when UserVmSearch is null or not, when calling the method 
`listByNetworkIdAndStates`.  Depending on the test results, I may revert your 
original fix, but kindly re-submit a newer change and I can help run tests for 
you. Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320097975
 
 
   @swill I'm re-kicking the test, however we can ignore other test failures 
and but the test you've added, i.e. 
`test_01_vpc_site2site_vpn_multiple_options`. Did you make an effort to look at 
the last failure and try to find a suitable fix. There was no commit change 
since the last run and I suspect kicking another round may only fail the 
test(s) again.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation 
of S2S VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320097241
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-911
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-320083774
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM 
HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-320083734
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation 
of S2S VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320083782
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320083615
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9749: Disable password service on ilb systemvm (#1912)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 1414d20  CLOUDSTACK-9749: Disable password service on ilb systemvm 
(#1912)
1414d20 is described below

commit 1414d20852f9df190189152dd73d81e5980ed839
Author: Frank Maximus 
AuthorDate: Thu Aug 3 22:38:25 2017 +0200

CLOUDSTACK-9749: Disable password service on ilb systemvm (#1912)

Fix cloud-password-srvr correctly.
Made sure it runs on VPC VR, but not on Internal LB
---
 systemvm/patches/debian/config/etc/init.d/cloud-early-config  | 1 +
 systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/patches/debian/config/etc/init.d/cloud-early-config 
b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
index ac54ebf..3bdebdb 100755
--- a/systemvm/patches/debian/config/etc/init.d/cloud-early-config
+++ b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
@@ -1032,6 +1032,7 @@ EOF
   enable_irqbalance 1
   enable_vpc_rpsrfs 1
   enable_svc cloud 0
+  enable_svc cloud-passwd-srvr 1
   disable_rpfilter
   enable_fwding 1
   cp /etc/iptables/iptables-vpcrouter /etc/iptables/rules.v4
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip 
b/systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip
index a408a1e..5e15a19 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip
+++ b/systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip
@@ -18,7 +18,6 @@
 
 . /etc/default/cloud-passwd-srvr
 addr=$1;
-ENABLED=1
 while [ "$ENABLED" == "1" ]
 do
 python /opt/cloud/bin/passwd_server_ip.py $addr >/dev/null 2>/dev/null

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

[git]

rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on 
ilb systemvm
URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-320083343
 
 
   LGTM, some of the failing tests are know failures and not related to this PR.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

[git]

rhtyd closed pull request #1912: CLOUDSTACK-9749: Disable password service on 
ilb systemvm
URL: https://github.com/apache/cloudstack/pull/1912
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320082795
 
 
   @rhtyd can you kick off the tests again.  This issue looks like an 
environment issue.  There are a lot of tests failing in this case unrelated to 
my code.  It looks like there was issues cleaning up other tests or something 
like that because my test failed because it was unable to acquire a public IP. 
   
   Given the scale of the failures in this run, I am pretty sure the cause is 
an environment problem.  Can we test again so we see if we get different 
results?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

[git]

rhtyd closed pull request #2138: CLOUDSTACK-9944 In Cluster Management Server, 
Sometimes hosts stays i?
URL: https://github.com/apache/cloudstack/pull/2138
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9944: In Cluster Management Server, Sometimes hosts stays in disconnected state (#2138)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 9fe5630  CLOUDSTACK-9944: In Cluster Management Server, Sometimes 
hosts stays in disconnected state (#2138)
9fe5630 is described below

commit 9fe5630c711ca8659698ca32a4fec715105ef5cc
Author: SowjanyaPatha 
AuthorDate: Fri Aug 4 02:04:23 2017 +0530

CLOUDSTACK-9944: In Cluster Management Server, Sometimes hosts stays in 
disconnected state (#2138)

In clustered management server setup on simultaneous restart of management 
server, sometimes hosts stays in disconnected state.
---
 .../src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java   | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
 
b/engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
index a89988c..b69ca5b 100644
--- 
a/engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
+++ 
b/engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
@@ -167,6 +167,7 @@ public class ClusteredAgentManagerImpl extends 
AgentManagerImpl implements Clust
 
 // Schedule tasks for agent rebalancing
 if (isAgentRebalanceEnabled()) {
+cleanupTransferMap(_nodeId);
 
s_transferExecutor.scheduleAtFixedRate(getAgentRebalanceScanTask(), 6, 
6, TimeUnit.MILLISECONDS);
 s_transferExecutor.scheduleAtFixedRate(getTransferScanTask(), 
6, ClusteredAgentRebalanceService.DEFAULT_TRANSFER_CHECK_INTERVAL, 
TimeUnit.MILLISECONDS);
 }

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

[git]

rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, 
Sometimes hosts stays i?
URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-320082322
 
 
   LGTM, some of the failing tests are known issues not related to this PR and 
being fixed in separate PRs. Merging based on that.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

[git]

blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management 
Server, Sometimes hosts stays i?
URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-320081740
 
 
   Trillian test result (tid-1310)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35462 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2138-t1310-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Test completed. 52 look OK, 5 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_VPC_nics_after_destroy | `Failure` | 321.05 | test_vpc_router_nics.py
   test_04_rvpc_privategw_static_routes | `Failure` | 398.30 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 341.59 | 
test_privategw_acl.py
   test_01_nic | `Error` | 137.78 | test_nic.py
   test_reboot_router | `Error` | 278.37 | test_network.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 178.11 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 193.53 | 
test_internal_lb.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.03 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.04 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.05 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.07 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

[git]

blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password 
service on ilb systemvm
URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-320060173
 
 
   Trillian test result (tid-1307)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34952 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1912-t1307-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Test completed. 53 look OK, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_VPC_nics_after_destroy | `Failure` | 371.48 | test_vpc_router_nics.py
   test_04_rvpc_privategw_static_routes | `Failure` | 396.77 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 361.21 | 
test_privategw_acl.py
   test_01_nic | `Error` | 243.58 | test_nic.py
   test_reboot_router | `Error` | 232.65 | test_network.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.05 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.05 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed opened a new pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC

[git]

syed opened a new pull request #2221: [CLOUDSTACK-10030] - Make publicips 
reachable inside VPC
URL: https://github.com/apache/cloudstack/pull/2221
 
 
   If a public IP is assigned to a VPC, a VM running inside that VPC cannot 
ping that public IP. This is due to the IPtables Nat rules set in such a way 
that drop any requests to the public IP from internal interfaces. I am fixing 
this so that internal hosts can also reach the public IP.
   
   Reproduction:
   
   Create a VPC
   Create a network inside the VPC
   Allocate a public IP
   Create a VM in the network
   Create a port forwarding rule enabling ICMP
   ping the public IP inside the VM (this will fail)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131189574
 
 

 ##
 File path: systemvm/systemvm-descriptor.xml
 ##
 @@ -16,7 +16,7 @@
   specific language governing permissions and limitations
   under the License.
 -->
-http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+http://maven.apache.org/lugins/maven-assembly-plugin/assembly/1.1.2;
 
 Review comment:
   yeah sure
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131185869
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/vnc/VncClientPacketSender.java
 ##
 @@ -99,7 +99,7 @@ public void closeConnection() {
 connectionAlive = false;
 }
 
-public void requestFullScreenUpdate() {
+public void requestFullScreenUpdate() {
 
 Review comment:
   +1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131185869
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/vnc/VncClientPacketSender.java
 ##
 @@ -99,7 +99,7 @@ public void closeConnection() {
 connectionAlive = false;
 }
 
-public void requestFullScreenUpdate() {
+public void requestFullScreenUpdate() {
 
 Review comment:
   +1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131185245
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java
 ##
 @@ -379,7 +359,23 @@ private static void startupHttpCmdPort() {
 }
 }
 
-public static void main(String[] argv) {
+private static void startServerForNoVNC() {
+try {
+ConsoleProxyServerFactory factory = getHttpServerFactory();
+if (factory == null) {
+s_logger.error("Unable to load HTTP server factory");
+System.exit(1);
+}
+Server webServer = factory.
+createConsoleProxyServer(443);
 
 Review comment:
   fine wil reuse them
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131185245
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java
 ##
 @@ -379,7 +359,23 @@ private static void startupHttpCmdPort() {
 }
 }
 
-public static void main(String[] argv) {
+private static void startServerForNoVNC() {
+try {
+ConsoleProxyServerFactory factory = getHttpServerFactory();
+if (factory == null) {
+s_logger.error("Unable to load HTTP server factory");
+System.exit(1);
+}
+Server webServer = factory.
+createConsoleProxyServer(443);
 
 Review comment:
   fine wil reuse them
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131184835
 
 

 ##
 File path: server/src/com/cloud/servlet/ConsoleProxyServlet.java
 ##
 @@ -16,35 +16,6 @@
 // under the License.
 package com.cloud.servlet;
 
-import java.io.IOException;
 
 Review comment:
   Yeah Sure
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

[git]

sachinnitw1317 commented on a change in pull request #2204: [CLOUDSTACK-10025] 
Adding Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r131185094
 
 

 ##
 File path: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java
 ##
 @@ -328,7 +329,7 @@ public static void start(Properties conf) {
 }
 
 if (httpListenPort != 0) {
-startupHttpMain();
+startServerForNoVNC();
 
 Review comment:
   cool! will change it to startupHttpMain
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] konstantintrushin commented on issue #2203: All private, public, and guest interfaceses are marked as untagged ca?

[git]

konstantintrushin commented on issue #2203: All private, public, and guest 
interfaceses are marked as untagged ca?
URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-319993404
 
 
   I have created JIRA issue CLOUDSTACK-10029. If you need more details please 
contact me.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-319943789
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-910
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-319933607
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM 
HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-319933558
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319930143
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment 
failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319930071
 
 
   @blueorangutan test centos7 vmware-55u3
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319929963
 
 
   @rhtyd unsupported parameters provided. Supported mgmt server os are: 
`centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-ubuntu, xenserver-65sp1, xenserver-62sp1, vmware-60u2, 
vmware-55u3, vmware-51u1, vmware-50u1`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2193: CLOUDSTACK-10007 Isolation methods

[git]

rhtyd closed pull request #2193: CLOUDSTACK-10007 Isolation methods
URL: https://github.com/apache/cloudstack/pull/2193
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment 
failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319929794
 
 
   @blueorangutan test centos7 vmware55-u3
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (98dc4eb -> 597df24)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 98dc4eb  CLOUDSTACK-9782: New Background Polling Task Manager (#2218)
 add 597df24  CLOUDSTACK-10007: Isolation methods (#2193)

No new revisions were added by this update.

Summary of changes:
 api/src/com/cloud/network/PhysicalNetwork.java | 107 -
 .../com/cloud/network/IsolationMethodTest.java |  89 +
 .../network/guru/BigSwitchBcfGuestNetworkGuru.java |   2 +-
 .../network/guru/BrocadeVcsGuestNetworkGuru.java   |  11 +--
 .../network/guru/MidoNetGuestNetworkGuru.java  |  11 ++-
 .../network/guru/NiciraNvpGuestNetworkGuru.java|   2 +-
 .../com/cloud/network/element/NuageVspElement.java |   3 +-
 .../network/guru/NuageVspGuestNetworkGuru.java |   4 +-
 .../cloud/network/manager/NuageVspManagerImpl.java |   2 +-
 .../cloud/network/element/NuageVspElementTest.java |   3 +-
 .../opendaylight/OpendaylightGuestNetworkGuru.java |  39 
 .../cloud/network/guru/OvsGuestNetworkGuru.java|  19 ++--
 .../network/guru/SspGuestNetworkGuru.java  |  14 ++-
 .../cloud/network/guru/VxlanGuestNetworkGuru.java  |  10 +-
 .../network/guru/ExternalGuestNetworkGuru.java |  15 ++-
 15 files changed, 252 insertions(+), 79 deletions(-)
 create mode 100644 api/test/com/cloud/network/IsolationMethodTest.java

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

[git]

blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling 
Task Manager
URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319929485
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-909
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319929463
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-908
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131103831
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java
 ##
 @@ -0,0 +1,81 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.google.common.base.Preconditions;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.annotation.AnnotationService;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+
+@APICommand(name = AddAnnotationCmd.APINAME, description = "add an 
annotation.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, 
since = "4.11", authorized = {RoleType.Admin})
 
 Review comment:
   We might want to expand certainly for loadbalancers and maybe 
zones/pods/clusters. Not sure about VMs, yet. @PaulAngus has ideas on that as 
well
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2193: CLOUDSTACK-10007 Isolation methods

[git]

rhtyd commented on issue #2193: CLOUDSTACK-10007 Isolation methods
URL: https://github.com/apache/cloudstack/pull/2193#issuecomment-319925703
 
 
   Thanks @DaanHoogland LGTM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data

[git]

rhtyd commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms 
return uniform NIC data
URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-319925139
 
 
   LGTM, no deletions in returned keys just additive changes. @DaanHoogland 
however a minor note, the comments may be indented, or just removed. I 
understand that it notes the sequence of keys, however that's not how the 
params/keys are serialized/returned in the api response. It just makes the code 
look bit weird IMO :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

[git]

blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling 
Task Manager
URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319923958
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2218: CLOUDSTACK-9782: New Background Polling Task Manager

[git]

rhtyd closed pull request #2218: CLOUDSTACK-9782: New Background Polling Task 
Manager
URL: https://github.com/apache/cloudstack/pull/2218
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9782: New Background Polling Task Manager (#2218)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 98dc4eb  CLOUDSTACK-9782: New Background Polling Task Manager (#2218)
98dc4eb is described below

commit 98dc4eb96a3db1bd02f7ea7dab284f0d76b9dfb5
Author: Rohit Yadav 
AuthorDate: Thu Aug 3 11:53:45 2017 +0200

CLOUDSTACK-9782: New Background Polling Task Manager (#2218)

CloudStack has several background polling tasks that are spread across
the codebase, the aim of this work is to provide a single manager to
handle submission, execution and handling of background tasks. With
the framework implemented, existing oobm background task has been
refactored to use this manager.

Signed-off-by: Rohit Yadav 
---
 .../ChangeOutOfBandManagementPasswordCmd.java  |  2 +-
 .../ConfigureOutOfBandManagementCmd.java   |  2 +-
 .../IssueOutOfBandManagementPowerActionCmd.java|  2 +-
 .../OutOfBandManagementService.java|  9 +--
 .../cloudstack/poll/BackgroundPollManager.java | 23 +++
 .../apache/cloudstack/poll/BackgroundPollTask.java | 14 +---
 developer/developer-prefill.sql|  4 --
 .../agent/manager/ClusteredAgentManagerImpl.java   |  5 +-
 .../dao/OutOfBandManagementDao.java|  2 +-
 .../dao/OutOfBandManagementDaoImpl.java|  2 +-
 .../core/spring-server-core-managers-context.xml   |  4 ++
 server/src/com/cloud/server/StatsCollector.java| 54 ++-
 .../OutOfBandManagementServiceImpl.java| 61 ++---
 ...BackgroundTask.java => PowerOperationTask.java} |  8 +--
 .../cloudstack/poll/BackgroundPollManagerImpl.java | 79 ++
 .../poll/BackgroundPollManagerImplTest.java| 79 ++
 setup/dev/advanced.cfg | 13 ++--
 test/integration/smoke/test_outofbandmanagement.py | 72 +++-
 18 files changed, 296 insertions(+), 139 deletions(-)

diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
 
b/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
index ea2e3cd..0499a6e 100644
--- 
a/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
@@ -74,7 +74,7 @@ public class ChangeOutOfBandManagementPasswordCmd extends 
BaseAsyncCmd {
 CallContext.current().setEventDetails("Host Id: " + host.getId() + " 
Password: " + getPassword().charAt(0) + "");
 CallContext.current().putContextParameter(Host.class, host.getUuid());
 
-final OutOfBandManagementResponse response = 
outOfBandManagementService.changeOutOfBandManagementPassword(host, 
getPassword());
+final OutOfBandManagementResponse response = 
outOfBandManagementService.changePassword(host, getPassword());
 response.setResponseName(getCommandName());
 setResponseObject(response);
 }
diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
 
b/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
index db22410..d9c6c9f 100644
--- 
a/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
@@ -83,7 +83,7 @@ public class ConfigureOutOfBandManagementCmd extends BaseCmd {
 throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Unable to 
find host by ID: " + getHostId());
 }
 CallContext.current().putContextParameter(Host.class, host.getUuid());
-final OutOfBandManagementResponse response = 
outOfBandManagementService.configureOutOfBandManagement(host, 
getHostPMOptions());
+final OutOfBandManagementResponse response = 
outOfBandManagementService.configure(host, getHostPMOptions());
 response.setId(host.getUuid());
 response.setResponseName(getCommandName());
 setResponseObject(response);
diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
 
b/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
index 8d6bdd3..7593a3c 100644
--- 
a/api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
+++ 

[GitHub] rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

[git]

rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task 
Manager
URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319923815
 
 
   Thanks @borisstoyanov @DaanHoogland -- yes for now, I'm not moved other 
runnable threads to be handled by this manager, which will be a next step.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment 
failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319922140
 
 
   Failing test reference: https://github.com/apache/cloudstack/pull/2217
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment 
failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319918383
 
 
   @nitin-maharana I backported few PRs to 4.9, that included the specific 
change and in recent smoketest runs we're seeing new nic and router tests 
failing. I'm trying to find and revert the change at least in 4.9 to allow us 
to pass tests and work towards 4.9.3.0.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

borisstoyanov commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319918320
 
 
   we get this issue @nitin-maharana 
https://issues.apache.org/jira/browse/CLOUDSTACK-10028
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

nitin-maharana commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319917149
 
 
   @rhtyd, Thanks for pointing this out. What is the error you are getting?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

[git]

blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management 
Server, Sometimes hosts stays i?
URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319915388
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

[git]

rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, 
Sometimes hosts stays i?
URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319915136
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

[git]

blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password 
service on ilb systemvm
URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319915140
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

[git]

rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on 
ilb systemvm
URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319915095
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

blueorangutan commented on issue #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319914203
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

rhtyd commented on issue #2220: Revert "CLOUDSTACK-9708: Router deployment 
failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220#issuecomment-319913919
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2220: Revert "CLOUDSTACK-9708: Router deployment failed due to two threads ?

[git]

rhtyd opened a new pull request #2220: Revert "CLOUDSTACK-9708: Router 
deployment failed due to two threads ?
URL: https://github.com/apache/cloudstack/pull/2220
 
 
   ?start VR simultaneously."
   
   This reverts commit 42e60ebac6f067e003598447ef75d914b7916734.
   This reverts commit 9e20525e08d8dae7bcf3d568c5a1ccdb793eeb9d.
   
   We're seeing some new errors, the PR was merged without trillian tests: 
https://github.com/apache/cloudstack/pull/1870
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

[git]

rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task 
Manager
URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319906868
 
 
   Test LGTM, some of the failing tests are intemittent and ignore-able. Two 
test are failing on both 4.9 and master branches and can be dealt with 
separately, not related to this PR:
   
   test_01_nic | Error | 193.93 | test_nic.py
   test_reboot_router | Error | 238.47 | test_network.py
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services