date:20170809

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321453615
 
 
   Trillian test result (tid-1348)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39338 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2229-t1348-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Test completed. 52 look OK, 2 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
396.46 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
445.56 | test_routers_network_ops.py
   test_04_rvpc_privategw_static_routes | `Failure` | 934.22 | 
test_privategw_acl.py
   test_08_resize_volume | Skipped | 10.27 | test_volumes.py
   test_07_resize_fail | Skipped | 10.30 | test_volumes.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_01_scale_vm | Skipped | 33.87 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-08-09 Thread git

blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-321422860
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-943
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nathanejohnson commented on issue #2230: CLOUDSTACK-10038 - fix issue with listTemplates API call

2017-08-09 Thread git

nathanejohnson commented on issue #2230: CLOUDSTACK-10038 - fix issue with 
listTemplates API call
URL: https://github.com/apache/cloudstack/pull/2230#issuecomment-321421219
 
 
   Ahh, sorry for the duplicate.  I didn't see the other PR, probably because 
it had already been closed by the time I went looking for it.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nathanejohnson closed pull request #2230: CLOUDSTACK-10038 - fix issue with listTemplates API call

2017-08-09 Thread git

nathanejohnson closed pull request #2230: CLOUDSTACK-10038 - fix issue with 
listTemplates API call
URL: https://github.com/apache/cloudstack/pull/2230
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-08-09 Thread git

blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-321420073
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-08-09 Thread git

rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM 
HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-321420032
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-08-09 Thread git

blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-320504798
 
 
   Trillian test result (tid-1325)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55761 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1960-t1325-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_ha_for_host.py
   Intermitten failure detected: /marvin/tests/smoke/test_ha_kvm_agent.py
   Intermitten failure detected: /marvin/tests/smoke/test_ha_kvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Test completed. 49 look OK, 12 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_VPC_nics_after_destroy | `Failure` | 608.09 | test_vpc_router_nics.py
   test_01_create_volume | `Failure` | 192.97 | test_volumes.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
479.52 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
486.48 | test_routers_network_ops.py
   test_06_router_advanced | `Failure` | 0.01 | test_routers.py
   test_05_router_basic | `Failure` | 0.02 | test_routers.py
   test_04_rvpc_privategw_static_routes | `Failure` | 977.82 | 
test_privategw_acl.py
   ContextSuite context=TestRedundantIsolateNetworks>:teardown | `Error` | 
391.08 | test_routers_network_ops.py
   test_09_reboot_router | `Error` | 5.08 | test_routers.py
   test_08_start_router | `Error` | 155.83 | test_routers.py
   test_04_restart_network_wo_cleanup | `Error` | 150.73 | test_routers.py
   test_03_restart_network_cleanup | `Error` | 180.91 | test_routers.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 770.80 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 811.21 | 
test_privategw_acl.py
   test_reboot_router | `Error` | 548.30 | test_network.py
   test_nested_virtualization_vmware | `Error` | 397.89 | 
test_nested_virtualization.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 231.95 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 252.16 | 
test_internal_lb.py
   test_ha_stop_agent_host_is_degraded | `Error` | 0.19 | test_ha_kvm_agent.py
   test_ha_kill_agent_host_is_degraded | `Error` | 0.24 | test_ha_kvm_agent.py
   test_remove_ha_provider_not_possible | `Error` | 0.10 | test_ha_kvm.py
   test_hostha_enable_ha_when_host_inMaintenance | `Error` | 5.12 | 
test_ha_kvm.py
   test_hostha_enable_ha_when_host_disconected | `Error` | 0.10 | test_ha_kvm.py
   test_hostha_enable_ha_when_host_disabled | `Error` | 0.08 | test_ha_kvm.py
   test_hostha_enable_feature_valid | `Error` | 5.11 | test_ha_kvm.py
   test_hostha_disable_feature_valid | `Error` | 5.11 | test_ha_kvm.py
   test_hostha_configure_default_driver | `Error` | 5.12 | test_ha_kvm.py
   test_enable_ha_when_host_powerstate_on | `Error` | 20.40 | test_ha_kvm.py
   test_disable_oobm_ha_state_ineligible | `Error` | 0.09 | test_ha_kvm.py
   test_configure_ha_provider_valid | `Error` | 0.18 | test_ha_kvm.py
   test_configure_ha_provider_invalid | `Error` | 0.09 | test_ha_kvm.py
   test_list_ha_for_host_valid | `Error` | 0.04 | test_ha_for_host.py
   test_list_ha_for_host_invalid | `Error` | 0.04 | test_ha_for_host.py
   test_list_ha_for_host | `Error` | 0.04 | test_ha_for_host.py
   test_enable_ha_for_host_invalid | `Error` | 0.04 | test_ha_for_host.py
   test_enable_ha_for_host | `Error` | 0.04 | test_ha_for_host.py
   test_disable_ha_for_host_invalid | `Error` | 0.04 | test_ha_for_host.py
   test_disable_ha_for_host | `Error` | 0.05 | test_ha_for_host.py
   test_3d_gpu_support | `Error` | 508.85 | test_deploy_vgpu_enabled_vm.py
   test_08_resize_volume | Skipped | 10.12 | test_volumes.py
   test_07_resize_fail | Skipped | 15.22 | test_volumes.py
   test_09_copy_delete_template | Skipped | 0.01 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 66.64 |

[cloudstack] branch master updated (92b07d4 -> f84728d)

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 92b07d4  CLOUDSTACK-1: Fix vpn_users component test
 add 5645164  CLOUDSTACK-8958: release dedicated ip range in domain removal
 add 542b7e6  CLOUDSTACK-8958: Fix typos introduced
 add d9b7b8c  Merge branch '4.9' into 4.10
 new f84728d  Merge branch '4.10'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/configuration/ConfigurationManager.java  |  14 +++
 engine/schema/src/com/cloud/domain/DomainVO.java   |   8 ++
 .../configuration/ConfigurationManagerImpl.java|  40 ++--
 server/src/com/cloud/user/DomainManagerImpl.java   |  16 ++-
 .../test/com/cloud/user/DomainManagerImplTest.java | 107 +
 .../cloud/vpc/MockConfigurationManagerImpl.java|  11 ++-
 6 files changed, 166 insertions(+), 30 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] 01/01: Merge branch '4.10'

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit f84728d374355590af7954be3b874fedc8ff080e
Merge: 92b07d4 d9b7b8c
Author: Rohit Yadav 
AuthorDate: Thu Aug 10 01:59:34 2017 +0200

Merge branch '4.10'

 .../cloud/configuration/ConfigurationManager.java  |  14 +++
 engine/schema/src/com/cloud/domain/DomainVO.java   |   8 ++
 .../configuration/ConfigurationManagerImpl.java|  40 ++--
 server/src/com/cloud/user/DomainManagerImpl.java   |  16 ++-
 .../test/com/cloud/user/DomainManagerImplTest.java | 107 +
 .../cloud/vpc/MockConfigurationManagerImpl.java|  11 ++-
 6 files changed, 166 insertions(+), 30 deletions(-)


-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] 01/01: Merge branch '4.9' into 4.10

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch 4.10
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit d9b7b8cb6258082d1c0a8050fe1f7f0b3a91b8eb
Merge: cf6c949 542b7e6
Author: Rohit Yadav 
AuthorDate: Thu Aug 10 01:34:20 2017 +0200

Merge branch '4.9' into 4.10

Signed-off-by: Rohit Yadav 

 .../cloud/configuration/ConfigurationManager.java  |  14 +++
 engine/schema/src/com/cloud/domain/DomainVO.java   |   8 ++
 .../configuration/ConfigurationManagerImpl.java|  40 ++--
 server/src/com/cloud/user/DomainManagerImpl.java   |  16 ++-
 .../test/com/cloud/user/DomainManagerImplTest.java | 107 +
 .../cloud/vpc/MockConfigurationManagerImpl.java|  11 ++-
 6 files changed, 166 insertions(+), 30 deletions(-)

diff --cc server/src/com/cloud/configuration/ConfigurationManagerImpl.java
index f6e040f,c85bac9..a936e97
mode 100755,100644..100755
--- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@@ -34,13 -34,8 +34,6 @@@ import java.util.UUID
  import javax.inject.Inject;
  import javax.naming.ConfigurationException;
  
- import com.google.common.base.MoreObjects;
- import org.apache.commons.collections.CollectionUtils;
- import org.apache.commons.collections.MapUtils;
- import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
- import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
--import org.apache.log4j.Logger;
--
  import org.apache.cloudstack.acl.SecurityChecker;
  import org.apache.cloudstack.affinity.AffinityGroup;
  import org.apache.cloudstack.affinity.AffinityGroupService;
@@@ -72,6 -67,6 +65,7 @@@ import org.apache.cloudstack.config.Con
  import org.apache.cloudstack.context.CallContext;
  import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
  import org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager;
++import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
  import org.apache.cloudstack.framework.config.ConfigDepot;
  import org.apache.cloudstack.framework.config.ConfigKey;
  import org.apache.cloudstack.framework.config.Configurable;
@@@ -86,11 -81,10 +80,15 @@@ import org.apache.cloudstack.region.Por
  import org.apache.cloudstack.region.Region;
  import org.apache.cloudstack.region.RegionVO;
  import org.apache.cloudstack.region.dao.RegionDao;
++import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
 +import org.apache.cloudstack.storage.datastore.db.ImageStoreDetailsDao;
 +import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
  import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
  import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
  import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+ import org.apache.commons.collections.CollectionUtils;
++import org.apache.commons.collections.MapUtils;
++import org.apache.log4j.Logger;
  
  import com.cloud.alert.AlertManager;
  import com.cloud.api.ApiDBUtils;
@@@ -221,8 -217,6 +219,8 @@@ import com.cloud.vm.dao.NicIpAliasDao
  import com.cloud.vm.dao.NicIpAliasVO;
  import com.cloud.vm.dao.NicSecondaryIpDao;
  import com.cloud.vm.dao.VMInstanceDao;
- 
++import com.google.common.base.MoreObjects;
 +import com.google.common.base.Preconditions;
  
  public class ConfigurationManagerImpl extends ManagerBase implements 
ConfigurationManager, ConfigurationService, Configurable {
  public static final Logger s_logger = 
Logger.getLogger(ConfigurationManagerImpl.class);
diff --cc server/src/com/cloud/user/DomainManagerImpl.java
index 09c4272,6efa121..60c48fa
--- a/server/src/com/cloud/user/DomainManagerImpl.java
+++ b/server/src/com/cloud/user/DomainManagerImpl.java
@@@ -23,9 -23,9 +23,6 @@@ import java.util.UUID
  
  import javax.inject.Inject;
  
--import org.apache.log4j.Logger;
--import org.springframework.stereotype.Component;
--
  import org.apache.cloudstack.api.command.admin.domain.ListDomainChildrenCmd;
  import org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd;
  import org.apache.cloudstack.api.command.admin.domain.UpdateDomainCmd;
@@@ -34,9 -34,8 +31,12 @@@ import org.apache.cloudstack.engine.orc
  import org.apache.cloudstack.framework.messagebus.MessageBus;
  import org.apache.cloudstack.framework.messagebus.PublishScope;
  import org.apache.cloudstack.region.RegionManager;
 +import org.apache.commons.collections.CollectionUtils;
 +import org.apache.commons.lang.BooleanUtils;
++import org.apache.log4j.Logger;
++import org.springframework.stereotype.Component;
  
+ import com.cloud.configuration.ConfigurationManager;
  import com.cloud.configuration.Resource.ResourceOwnerType;
  import com.cloud.configuration.ResourceLimit;
  import com.cloud.configuration.dao.ResourceCountDao;
@@@ -284,146 -276,89 +286,154 @@@ public class

[cloudstack] branch 4.10 updated (cf6c949 -> d9b7b8c)

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch 4.10
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from cf6c949  Merge branch '4.9' into 4.10
 add 5645164  CLOUDSTACK-8958: release dedicated ip range in domain removal
 add 542b7e6  CLOUDSTACK-8958: Fix typos introduced
 new d9b7b8c  Merge branch '4.9' into 4.10

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/configuration/ConfigurationManager.java  |  14 +++
 engine/schema/src/com/cloud/domain/DomainVO.java   |   8 ++
 .../configuration/ConfigurationManagerImpl.java|  40 ++--
 server/src/com/cloud/user/DomainManagerImpl.java   |  16 ++-
 .../test/com/cloud/user/DomainManagerImplTest.java | 107 +
 .../cloud/vpc/MockConfigurationManagerImpl.java|  11 ++-
 6 files changed, 166 insertions(+), 30 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] branch master updated: CLOUDSTACK-10000: Fix vpn_users component test

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 92b07d4  CLOUDSTACK-1: Fix vpn_users component test
92b07d4 is described below

commit 92b07d453fbca85905888c6acc7e05008d62e406
Author: Rohit Yadav 
AuthorDate: Thu Aug 10 01:31:28 2017 +0200

CLOUDSTACK-1: Fix vpn_users component test

Signed-off-by: Rohit Yadav 
---
 test/integration/component/test_vpn_users.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/integration/component/test_vpn_users.py 
b/test/integration/component/test_vpn_users.py
index 103ff1c..9784904 100644
--- a/test/integration/component/test_vpn_users.py
+++ b/test/integration/component/test_vpn_users.py
@@ -79,7 +79,7 @@ class Services:
 },
  "vpn_user": {
"username": "test",
-   "password": "p@a#s=s.w_o-r+d",
+   "password": "p@as=s.w_o-r+d",
 },
  "natrule": {
"privateport": 1701,

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] branch master updated: CLOUDSTACK-10000: Fix remote access vpn does not work due to '#' in password (#2182)

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new aee3dbb  CLOUDSTACK-1: Fix remote access vpn does not work due to 
'#' in password (#2182)
aee3dbb is described below

commit aee3dbb49a77f4784a72206d54d1fa7c4df0b0ce
Author: ustcweizhou 
AuthorDate: Thu Aug 10 01:30:21 2017 +0200

CLOUDSTACK-1: Fix remote access vpn does not work due to '#' in 
password (#2182)
---
 server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 
b/server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
index 67b1cc0..491fb47 100644
--- a/server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
+++ b/server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
@@ -381,8 +381,8 @@ public class RemoteAccessVpnManagerImpl extends ManagerBase 
implements RemoteAcc
 if (!username.matches("^[a-zA-Z0-9][a-zA-Z0-9@._-]{2,63}$")) {
 throw new InvalidParameterValueException("Username has to be begin 
with an alphabet have 3-64 characters including alphabets, numbers and the set 
'@.-_'");
 }
-if (!password.matches("^[a-zA-Z0-9][a-zA-Z0-9@#+=._-]{2,31}$")) {
-throw new InvalidParameterValueException("Password has to be 3-32 
characters including alphabets, numbers and the set '@#+=.-_'");
+if (!password.matches("^[a-zA-Z0-9][a-zA-Z0-9@+=._-]{2,31}$")) {
+throw new InvalidParameterValueException("Password has to be 3-32 
characters including alphabets, numbers and the set '@+=.-_'");
 }
 
 return Transaction.execute(new TransactionCallback() {

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd closed pull request #2182: CLOUDSTACK-10000: FIX remote access vpn does not work due to '#' in password

2017-08-09 Thread git

rhtyd closed pull request #2182: CLOUDSTACK-1: FIX remote access vpn does 
not work due to '#' in password
URL: https://github.com/apache/cloudstack/pull/2182
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.9 updated: CLOUDSTACK-8958: Fix typos introduced

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch 4.9
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.9 by this push:
 new 542b7e6  CLOUDSTACK-8958: Fix typos introduced
542b7e6 is described below

commit 542b7e660807b32f4a57e06a1040ace23bcdf3e8
Author: Rohit Yadav 
AuthorDate: Thu Aug 10 01:12:59 2017 +0200

CLOUDSTACK-8958: Fix typos introduced

Signed-off-by: Rohit Yadav 
---
 engine/schema/src/com/cloud/domain/DomainVO.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/schema/src/com/cloud/domain/DomainVO.java 
b/engine/schema/src/com/cloud/domain/DomainVO.java
index 6fe7327..34376c7 100644
--- a/engine/schema/src/com/cloud/domain/DomainVO.java
+++ b/engine/schema/src/com/cloud/domain/DomainVO.java
@@ -140,7 +140,7 @@ public class DomainVO implements Domain {
 }
 
 public void setAccountId(long accountId) {
-this. accountId= accountId;
+this.accountId = accountId;
 }
 
 @Override

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] branch 4.9 updated: CLOUDSTACK-8958: release dedicated ip range in domain removal

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch 4.9
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.9 by this push:
 new 5645164  CLOUDSTACK-8958: release dedicated ip range in domain removal
5645164 is described below

commit 5645164dbb44f7f403f372fc8432b6d50a3bd730
Author: Wei Zhou 
AuthorDate: Wed Jan 20 17:21:06 2016 +0100

CLOUDSTACK-8958: release dedicated ip range in domain removal
---
 .../cloud/configuration/ConfigurationManager.java  | 14 +
 engine/schema/src/com/cloud/domain/DomainVO.java   |  8 +++
 .../configuration/ConfigurationManagerImpl.java| 27 
 server/src/com/cloud/user/DomainManagerImpl.java   | 11 
 .../test/com/cloud/user/DomainManagerImplTest.java | 73 ++
 .../cloud/vpc/MockConfigurationManagerImpl.java| 11 +++-
 6 files changed, 143 insertions(+), 1 deletion(-)

diff --git 
a/engine/components-api/src/com/cloud/configuration/ConfigurationManager.java 
b/engine/components-api/src/com/cloud/configuration/ConfigurationManager.java
index ec3df0e..46be654 100644
--- 
a/engine/components-api/src/com/cloud/configuration/ConfigurationManager.java
+++ 
b/engine/components-api/src/com/cloud/configuration/ConfigurationManager.java
@@ -219,6 +219,20 @@ public interface ConfigurationManager {
 
 void createDefaultSystemNetworks(long zoneId) throws 
ConcurrentOperationException;
 
+/**
+ * Release dedicated virtual ip ranges of a domain.
+ *
+ * @param domainId
+ * @return success/failure
+ */
+boolean releaseDomainSpecificVirtualRanges(long domainId);
+
+/**
+ * Release dedicated virtual ip ranges of an account.
+ *
+ * @param accountId
+ * @return success/failure
+ */
 boolean releaseAccountSpecificVirtualRanges(long accountId);
 
 /**
diff --git a/engine/schema/src/com/cloud/domain/DomainVO.java 
b/engine/schema/src/com/cloud/domain/DomainVO.java
index f6494b3..6fe7327 100644
--- a/engine/schema/src/com/cloud/domain/DomainVO.java
+++ b/engine/schema/src/com/cloud/domain/DomainVO.java
@@ -103,6 +103,10 @@ public class DomainVO implements Domain {
 return id;
 }
 
+public void setId(long id) {
+this.id = id;
+}
+
 @Override
 public Long getParent() {
 return parent;
@@ -135,6 +139,10 @@ public class DomainVO implements Domain {
 return accountId;
 }
 
+public void setAccountId(long accountId) {
+this. accountId= accountId;
+}
+
 @Override
 public Date getRemoved() {
 return removed;
diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
index 5b8ba79..c85bac9 100644
--- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -84,6 +84,7 @@ import org.apache.cloudstack.region.dao.RegionDao;
 import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
 import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
 import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.apache.commons.collections.CollectionUtils;
 
 import com.cloud.alert.AlertManager;
 import com.cloud.api.ApiDBUtils;
@@ -4935,6 +4936,32 @@ public class ConfigurationManagerImpl extends 
ManagerBase implements Configurati
 return _networkOfferingDao.search(sc, searchFilter);
 }
 
+ @Override
+ @DB
+ public boolean releaseDomainSpecificVirtualRanges(final long domainId) {
+final List maps = 
_domainVlanMapDao.listDomainVlanMapsByDomain(domainId);
+if (CollectionUtils.isNotEmpty(maps)) {
+try {
+Transaction.execute(new TransactionCallbackNoReturn() {
+@Override
+public void doInTransactionWithoutResult(final 
TransactionStatus status) {
+for (DomainVlanMapVO map : maps) {
+if (!releasePublicIpRange(map.getVlanDbId(), 
_accountMgr.getSystemUser().getId(), 
_accountMgr.getAccount(Account.ACCOUNT_ID_SYSTEM))) {
+throw new CloudRuntimeException("Failed to 
release domain specific virtual ip ranges for domain id=" + domainId);
+}
+}
+}
+});
+} catch (final CloudRuntimeException e) {
+s_logger.error(e);
+return false;
+}
+} else {
+s_logger.trace("Domain id=" + domainId + " has no domain specific 
virtual ip ranges, nothing to release");
+}
+return true;
+}
+
 @Override
 @DB
 public boolean releaseAccountSpecificVirtualRanges(final long accountId) {
diff --git

[GitHub] rhtyd closed pull request #1357: [4.9] CLOUDSTACK-8958: release dedicated ip range in domain removal

2017-08-09 Thread git

rhtyd closed pull request #1357: [4.9] CLOUDSTACK-8958: release dedicated ip 
range in domain removal
URL: https://github.com/apache/cloudstack/pull/1357
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2224: CLOUDSTACK-10032 : Database entries for templates created from snapshots disappear after management-server service restart

2017-08-09 Thread git

blueorangutan commented on issue #2224: CLOUDSTACK-10032 : Database entries for 
templates created from snapshots disappear after management-server service 
restart
URL: https://github.com/apache/cloudstack/pull/2224#issuecomment-321405846
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2224: CLOUDSTACK-10032 : Database entries for templates created from snapshots disappear after management-server service restart

2017-08-09 Thread git

rhtyd commented on issue #2224: CLOUDSTACK-10032 : Database entries for 
templates created from snapshots disappear after management-server service 
restart
URL: https://github.com/apache/cloudstack/pull/2224#issuecomment-321405710
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2230: CLOUDSTACK-10038 - fix issue with listTemplates API call

2017-08-09 Thread git

rhtyd commented on issue #2230: CLOUDSTACK-10038 - fix issue with listTemplates 
API call
URL: https://github.com/apache/cloudstack/pull/2230#issuecomment-321405523
 
 
   @nathanejohnson this looks like a duplicate, please check and close against 
https://github.com/apache/cloudstack/pull/2144/files
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge branch '4.10'

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit d17728dd7e1948a3479d6191fac0ded88499482c
Merge: 18ffd7b cf6c949
Author: Rohit Yadav 
AuthorDate: Thu Aug 10 01:04:54 2017 +0200

Merge branch '4.10'

 ui/scripts/network.js | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --cc ui/scripts/network.js
index 7f27373,72aa3ad..8370106
mode 100644,100755..100644
--- a/ui/scripts/network.js
+++ b/ui/scripts/network.js

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] branch master updated (18ffd7b -> d17728d)

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 18ffd7b  CLOUDSTACK-10036: Decreasing timeout of failing unit test 
(#2228)
 add 86b6050  CLOUDSTACK-10042: Properly show ICMP SecGroup Rules (#2233)
 add cf6c949  Merge branch '4.9' into 4.10
 new d17728d  Merge branch '4.10'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ui/scripts/network.js | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] 01/01: Merge branch '4.9' into 4.10

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch 4.10
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit cf6c949310816ab6cd8f11d6fd5ae6f5da650633
Merge: ddd8462 86b6050
Author: Rohit Yadav 
AuthorDate: Thu Aug 10 01:04:04 2017 +0200

Merge branch '4.9' into 4.10

 ui/scripts/network.js | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)


-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] rhtyd closed pull request #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

rhtyd closed pull request #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup 
Rules
URL: https://github.com/apache/cloudstack/pull/2233
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.10 updated (ddd8462 -> cf6c949)

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch 4.10
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from ddd8462  Merge branch '4.9' into 4.10
 add 86b6050  CLOUDSTACK-10042: Properly show ICMP SecGroup Rules (#2233)
 new cf6c949  Merge branch '4.9' into 4.10

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ui/scripts/network.js | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] branch 4.9 updated: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules (#2233)

2017-08-09 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch 4.9
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.9 by this push:
 new 86b6050  CLOUDSTACK-10042: Properly show ICMP SecGroup Rules (#2233)
86b6050 is described below

commit 86b6050c322aeb881d68e2235ee91fecbd1d974b
Author: Wido den Hollander 
AuthorDate: Thu Aug 10 01:03:35 2017 +0200

CLOUDSTACK-10042: Properly show ICMP SecGroup Rules (#2233)

A simple if-statement would fail if either the type or code were 0
as that if-statement failed them.

By checking if they are defined and casting them to a String afterwards
this makes the if-statement properly resolve and show the rule as it should.

Signed-off-by: Wido den Hollander 
---
 ui/scripts/network.js | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/ui/scripts/network.js b/ui/scripts/network.js
index 569e31d..6b9257a 100755
--- a/ui/scripts/network.js
+++ b/ui/scripts/network.js
@@ -26,11 +26,19 @@
 tags: elem.tags
 };
 
+if (typeof elem.icmptype != 'undefined') {
+ var icmptype = elem.icmptype.toString()
+}
+
+if (typeof elem.icmpcode != 'undefined') {
+ var icmpcode = elem.icmpcode.toString()
+}
+
 if (elemData.startport == 0 && elemData.endport) {
 elemData.startport = '0';
-} else if (elem.icmptype && elem.icmpcode) {
-elemData.startport = elem.icmptype;
-elemData.endport = elem.icmpcode;
+} else if (icmptype && icmpcode) {
+elemData.startport = icmptype;
+elemData.endport = icmpcode;
 }
 
 return elemData;

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

rhtyd commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup 
Rules
URL: https://github.com/apache/cloudstack/pull/2233#issuecomment-321405030
 
 
   Checked manually, LGTM. Merging.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

2017-08-09 Thread git

rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-321398997
 
 
   @sachinnitw1317 can you rebase against latest master and fix failing tests. 
See Travis for any issues.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321338017
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + 
vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

rhtyd commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321337945
 
 
   @blueorangutan test matrix
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash opened a new pull request #2234: CLOUDSTACK-10041: Support to use ikev1 for site-to-site VPN connections

2017-08-09 Thread git

yvsubhash opened a new pull request #2234: CLOUDSTACK-10041: Support to use 
ikev1 for site-to-site VPN connections
URL: https://github.com/apache/cloudstack/pull/2234
 
 
   Currently VR initiates connections using ikev2 by default with strongswan. 
In case, the customer gateway does not support ikev2. The connections would 
result in errors. In order to avoid this, this feature introduces a new 
parameter of ikeversion. Based on that the version with which Virtual Router 
initiates the connection would be decided
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321297196
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-942
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321289920
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

rhtyd commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321289842
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

blueorangutan commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP 
SecGroup Rules
URL: https://github.com/apache/cloudstack/pull/2233#issuecomment-321284292
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-941
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

wido commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup 
Rules
URL: https://github.com/apache/cloudstack/pull/2233#issuecomment-321279474
 
 
   Thanks @rhtyd ! A screenshot to show it works for me :)
   
   ![screenshot from 2017-08-09 
16-51-28](https://user-images.githubusercontent.com/326786/29128053-096e1b66-7d23-11e7-9cee-de57a40bcf85.png)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

blueorangutan commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP 
SecGroup Rules
URL: https://github.com/apache/cloudstack/pull/2233#issuecomment-321278620
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

rhtyd commented on issue #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup 
Rules
URL: https://github.com/apache/cloudstack/pull/2233#issuecomment-321278456
 
 
   @borisstoyanov can you help validate this, thanks.
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido opened a new pull request #2233: CLOUDSTACK-10042: Properly show ICMP SecGroup Rules

2017-08-09 Thread git

wido opened a new pull request #2233: CLOUDSTACK-10042: Properly show ICMP 
SecGroup Rules
URL: https://github.com/apache/cloudstack/pull/2233
 
 
   A simple if-statement would fail if either the type or code were 0
   as that if-statement failed them.
   
   By checking if they are defined and casting them to a String afterwards
   this makes the if-statement properly resolve and show the rule as it should.
   
   Signed-off-by: Wido den Hollander 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SowjanyaPatha commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage'

2017-08-09 Thread git

SowjanyaPatha commented on issue #2188: CLOUDSTACK-10004 : On deletion, Vmware 
volume snapshots are left behind with message 'the snapshot has child, can't 
delete it on the storage'
URL: https://github.com/apache/cloudstack/pull/2188#issuecomment-321241287
 
 
   LGTM for Testing.
   
![2188-after](https://user-images.githubusercontent.com/26593242/29121566-a82d3cce-7d2c-11e7-964f-1f9c3739ad08.png)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321221960
 
 
   Trillian test result (tid-1344)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38450 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2229-t1344-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Test completed. 50 look OK, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
419.05 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
441.37 | test_routers_network_ops.py
   test_04_rvpc_privategw_static_routes | `Failure` | 783.85 | 
test_privategw_acl.py
   test_CreateTemplateWithDuplicateName | `Error` | 5.14 | test_templates.py
   test_01_create_template | `Error` | 20.24 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 279.19 | 
test_templates.py
   ContextSuite context=TestSnapshotRootDisk>:teardown | `Error` | 202.57 | 
test_snapshots.py
   test_08_resize_volume | Skipped | 5.12 | test_volumes.py
   test_07_resize_fail | Skipped | 10.27 | test_volumes.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_01_scale_vm | Skipped | 34.09 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash opened a new pull request #2232: CLOUDSTACK-10040 Upload volume fails when management server can not r?

2017-08-09 Thread git

yvsubhash opened a new pull request #2232: CLOUDSTACK-10040 Upload volume fails 
when management server can not r?
URL: https://github.com/apache/cloudstack/pull/2232
 
 
   Problem
   
   Upload volume from internet fails when the management server cannot reach 
the URL ( internet)
   During the upload volume, we check the validity of the URL through 
management server first and then download the volume to secondary storage 
through SSVM.
   We have customer environments where the management server doesn?t have 
internet access ( possibility in some customer environments as per their 
security policies). This will now cause a failure even though the SSVM has 
internet connection
   
   Solution
   -
   introduced a new global configuration parameter validate.url.existence which 
if true would attempt the validation of provided URL, else the validation would 
be skipped
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

2017-08-09 Thread git

rhtyd commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321207285
 
 
   @borisstoyanov still getting the nic and router errors, can you help 
(re)investigate them
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

43 matches

Mail list logo