[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139068658 ## File path: test/integration/component/test_host.py ##

[GitHub] rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-329688178 I reviewed the code, as @koushik-das mentioned further investigation may be needed to look

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139067324 ## File path: test/integration/component/test_host.py ##

[GitHub] mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139063678 ## File path: test/integration/component/test_host.py

[GitHub] nathanejohnson commented on issue #2248: CLOUDSTACK-10056

2017-09-14 Thread git
nathanejohnson commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329600465 @rthyd that sounds like a better approach. I'll get this updated ASAP This is an automated

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329591545 Trillian test result (tid-1510) Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-14 Thread git
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329473928 Packaging result: ?centos6 ?centos7 ?debian. JID-1084

[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID

2017-09-14 Thread git
blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329473736 Packaging result: ?centos6 ?centos7 ?debian. JID-1083

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879584 ## File path: test/integration/component/test_host.py ##

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879356 ## File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879256 ## File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java

[GitHub] rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-329467492 @harikrishna-patnala why was this PR merged without tests? This affects clustering of

[GitHub] rhtyd commented on issue #2248: CLOUDSTACK-10056

2017-09-14 Thread git
rhtyd commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329466076 @bvbharat @bvbharatk comment please? @nathanejohnson can you change the implementation to restrict the double bye handling code to work only for details keys -

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-14 Thread git
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329465920 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-14 Thread git
rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329465744 @DaanHoogland @borisstoyanov @nvazquez we happy with the review, tests? @blueorangutan package

[cloudstack] branch master updated: CLOUDSTACK-10019: template.properties has hardcoded id (#2243)

2017-09-14 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c7a55eb CLOUDSTACK-10019:

[GitHub] rhtyd closed pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-09-14 Thread git
rhtyd closed pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243 This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID

2017-09-14 Thread git
blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329465465 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-09-14 Thread git
rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-329465479 LGTM. This is an automated message from the Apache Git

[GitHub] rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID

2017-09-14 Thread git
rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329465338 @blueorangutan package This is an automated

[GitHub] rhtyd closed pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?

2017-09-14 Thread git
rhtyd closed pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and? URL: https://github.com/apache/cloudstack/pull/2261 This is an automated message from the Apache Git Service. To

[cloudstack] branch master updated: CLOUDSTACK-10068: Fixing test_iso.py assertions are equating srt and bool instead of the same types (#2261)

2017-09-14 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new d84585f CLOUDSTACK-10068: Fixing

[GitHub] rhtyd commented on issue #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?

2017-09-14 Thread git
rhtyd commented on issue #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and? URL: https://github.com/apache/cloudstack/pull/2261#issuecomment-329465084 @borisstoyanov let's revisit if we've any future issues, merging this now.

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329464938 @wido @GabrielBrascher sure, I've already kicked a final test run with Trillian and centos6 boxes; I can merge as soon as the

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329461735 Ok, thanks! I added the label so that it can be merged. This is

[GitHub] wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git
wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329461603 I find it hard to believe a test failure is related to these changes. It doesn't change anything to the default behavior of the Agent.

[GitHub] larstobi commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system

2017-09-14 Thread git
larstobi commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system URL: https://github.com/apache/cloudstack/pull/2252#issuecomment-329455934 @GabrielBrascher Check! This is an

[GitHub] borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git
borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329442852 How about the load balancer @bwsw ? This is an automated

[GitHub] borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git
borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329442852 How about the internal load balancer @bwsw ? This is an

[GitHub] harikrishna-patnala closed pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git
harikrishna-patnala closed pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054 This is an automated message from

[cloudstack] 01/01: Merge pull request #2054 from Accelerite/cs-51009

2017-09-14 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository. harikrishna pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit b655f9be06cd88383d8b118d818a9a0d113211bf Merge: c4ca420 e894022 Author: harikrishna-patnala

[cloudstack] branch master updated (c4ca420 -> b655f9b)

2017-09-14 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository. harikrishna pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c4ca420 CLOUDSTACK-8969: VPN customer gateway can't be registered with hostname (#955) add e894022

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437500 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437377 @blueorangutan test centos7 kvm-centos6 This is an automated

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437124 Packaging result: ?centos6 ?centos7 ?debian. JID-1082

[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-09-14 Thread git
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329432167 @borisstoyanov okay I've rekicked the failing job, can you compare the test time take for each of the jobs and

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430475 @blueorangutan package This is an automated message from the

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430510 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git
bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329417873 @borisstoyanov ``` sshClient: DEBUG: {Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329418016 Thanks @rhtyd I addressed @GaborApatiNagy his comment, the XML parser now skips the entry if the model is null or empty. We

[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git
bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329417873 @borisstoyanov ``` sshClient: DEBUG: {Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no

[GitHub] wido commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git
wido commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138831591 ## File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java

[GitHub] wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git
wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329413011 LGTM based on the code Interesting idea using 3D-Xpoint SSDs as SWAP :)

[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-09-14 Thread git
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329412375 @rhtyd current travis failure is not related to the changes I've made