rhtyd commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and
improvements
URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-339221690
I've incorporated feedback from code review, given this has enough LGTMs and
test results, I'll merge this as soon as Travis goes
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146759604
##
File path:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##
@@
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146759596
##
File path:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##
@@
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146758445
##
File path:
api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkCmdByAdmin.java
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146758241
##
File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java
##
@@ -138,7 +143,24 @@
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146758494
##
File path: engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java
##
@@ -100,29 +103,43
nitin-maharana commented on a change in pull request #2284: CLOUDSTACK-10103:
Cloudian Connector for CloudStack
URL: https://github.com/apache/cloudstack/pull/2284#discussion_r146757796
##
File path: ui/plugins/cloudian/cloudian.css
##
@@ -0,0 +1,18 @@
+/*
Review
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146757782
##
File path: utils/src/main/java/com/cloud/utils/UriUtils.java
##
@@ -391,4 +391,57 @@ public
rhtyd closed pull request #2284: CLOUDSTACK-10103: Cloudian Connector for
CloudStack
URL: https://github.com/apache/cloudstack/pull/2284
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs.git
The following commit(s) were added to refs/heads/master by this push:
new f86e77e CLOUDSTACK-10103:
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new b6dc40f CLOUDSTACK-10103: Cloudian
rhtyd commented on issue #2284: CLOUDSTACK-10103: Cloudian Connector for
CloudStack
URL: https://github.com/apache/cloudstack/pull/2284#issuecomment-339217436
No regressions are seen, no outstanding issues.
With enough test and code LGTMs, I'll merge this. Thanks.
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new bd953d8 CLOUDSTACK-10107: For VMware VMs
rhtyd closed pull request #2288: CLOUDSTACK-10107: For VMware VMs add devices
without unit number
URL: https://github.com/apache/cloudstack/pull/2288
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-339120005
Although, @syed, now that you mention it, we should probably prohibit
Storage XenMotion when either existing backend
mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-339118036
That is actually snapshots on the storage system (SolidFire snapshots, in
this case). The problem is that we have to copy
syed commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-339102623
> Don?t allow Storage XenMotion on a VM that has any managed-storage volume
with one or more snapshots.
Is this VM snapshots
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-339016274
@nitin-maharana thanks for your review! I'll try addressing your comments
asap, thanks!
nitin-maharana commented on issue #2048: CLOUDSTACK-9880: Expansion of
Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-338936352
@borisstoyanov, Sorry!!
@jayapalu, Can you please merge this one.
borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of
Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-338934337
No, I'm not the right person to do that
This is an
nitin-maharana commented on issue #2048: CLOUDSTACK-9880: Expansion of
Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-338925612
@borisstoyanov, Can you please merge this. Thanks.
This
sgoeminn commented on issue #2259: CLOUDSTACK-10024: Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#issuecomment-338921135
@GabrielBrascher Thanks for reviewing, really appreciate it! We tried to
address all your comments.
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493531
##
File path: server/src/com/cloud/network/NetworkMigrationManager.java
##
@@ -0,0 +1,84 @@
+//
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493484
##
File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
##
@@ -34,5 +34,22 @@
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493509
##
File path: engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java
##
@@ -34,5 +34,22 @@
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493419
##
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -3636,6
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492964
##
File path:
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
##
@@
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493133
##
File path: core/src/com/cloud/agent/api/ReplugNicCommand.java
##
@@ -0,0 +1,67 @@
+///
+//
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146493117
##
File path: core/src/com/cloud/agent/api/ReplugNicAnswer.java
##
@@ -0,0 +1,26 @@
+///
+//
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492979
##
File path:
api/src/org/apache/cloudstack/api/command/admin/network/MigrateVPCCmd.java
##
@@ -0,0
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492848
##
File path:
api/src/org/apache/cloudstack/api/command/admin/network/MigrateNetworkCmd.java
##
@@
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492740
##
File path: api/src/com/cloud/network/NetworkService.java
##
@@ -82,6 +83,28 @@ IpAddress
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492729
##
File path: api/src/com/cloud/network/NetworkService.java
##
@@ -82,6 +83,28 @@ IpAddress
sgoeminn commented on a change in pull request #2259: CLOUDSTACK-10024: Network
migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146492712
##
File path: api/src/com/cloud/network/NetworkService.java
##
@@ -82,6 +83,26 @@ IpAddress
sgoeminn commented on issue #2238: [CLOUDSTACK-10053] Performance improvement:
caching of NuageVsp ID
URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-338892248
CI failure seems not to be related to this PR (known issue).
35 matches
Mail list logo
