[GitHub] wido commented on issue #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x

[GitBox]

wido commented on issue #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x
URL: https://github.com/apache/cloudstack/pull/2328#issuecomment-344841868
 
 
   What would be the easiest way to test? Just create a DEB and run it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2327: CLOUDSTACK-10129: Show account, network info in VR list view

[GitBox]

wido commented on issue #2327: CLOUDSTACK-10129: Show account, network info in 
VR list view
URL: https://github.com/apache/cloudstack/pull/2327#issuecomment-344841684
 
 
   LGTM based on the code


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

marcaurele commented on issue #2324: Remove annotation and "depends-on" 
declaration not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344839965
 
 
   LGTM - the `@Component` cannot work due to the system of spring sub modules 
created for CS. We would need to create a custom annotation to append the 
context name in which the bean should be created.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x

[GitBox]

blueorangutan commented on issue #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x
URL: https://github.com/apache/cloudstack/pull/2328#issuecomment-344834250
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1260


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x

[GitBox]

blueorangutan commented on issue #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x
URL: https://github.com/apache/cloudstack/pull/2328#issuecomment-344830936
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x

[GitBox]

rhtyd opened a new pull request #2328: CLOUDSTACK-10012: Upgrade Jetty to 9.3.x
URL: https://github.com/apache/cloudstack/pull/2328
 
 
   Upgrades Jetty to Java8 compatible version
   
   Pinging for review @marcaurele @nvazquez @borisstoyanov @DaanHoogland @wido 
and others
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-344830504
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1259


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-344826822
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline

[GitBox]

blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline
URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-344826897
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1258


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-344826791
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-344825864
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1257


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline

[GitBox]

blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline
URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-344822612
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (4fda0c0 -> 475aa03)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 4fda0c0  CLOUDSTACK-9998: Fix metrics generation failurein prometheus 
exporter (#2325)
 add 4f1539e  CLOUDSTACK-10135 ACL rules order is not maintained for 
ACL_OUTBOUND in VPC VR (#2313)
 add f250b3a  CLOUDSTACK-10135 ACL rules order is not maintained for 
ACL_OUTBOUND in VPC VR (#2313)
 add 330f241  Merge branch '4.9' into 4.10
 new 475aa03  Merge branch '4.10'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] 01/01: Merge branch '4.10'

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 475aa03bb858d2cf1b6c0d7aaaf35fbb1fb43d1d
Merge: 4fda0c0 330f241
Author: Rohit Yadav 
AuthorDate: Thu Nov 16 11:16:15 2017 +0530

Merge branch '4.10'

Forwards merge 4.9->4.10->master.


-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] rhtyd commented on issue #2318: [4.9] Smoketest health checkrun baseline

[GitBox]

rhtyd commented on issue #2318: [4.9] Smoketest health checkrun baseline
URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-344822536
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge branch '4.9' into 4.10

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch 4.10
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 330f24117cc5c90b85db291981652a2191417d5a
Merge: 4f1539e f250b3a
Author: Rohit Yadav 
AuthorDate: Thu Nov 16 11:15:32 2017 +0530

Merge branch '4.9' into 4.10


-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-344822197
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-344822195
 
 
   Thanks for merging @resmo however, let's wait for tests to come back before 
we merge PRs. I'll kick tests on the master/baseline smoketest PR #2289 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-344822170
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2327: CLOUDSTACK-10129: Show account, network info in VR list view

[GitBox]

rhtyd opened a new pull request #2327: CLOUDSTACK-10129: Show account, network 
info in VR list view
URL: https://github.com/apache/cloudstack/pull/2327
 
 
   This shows the owner account and network of a VR in the VR list view,
   and for VPCs shows the VPC name and redundant state of the VPC rVR.
   
   ![screenshot from 2017-11-16 
10-30-45](https://user-images.githubusercontent.com/95203/32875597-d21915e6-cabe-11e7-8b83-38bf90ee5e0f.png)
   
   Pinging for review @PaulAngus @borisstoyanov @resmo @nvazquez @DaanHoogland 
@wido @ustcweizhou @rafaelweingartner  and others


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

blueorangutan commented on issue #2324: Remove annotation and "depends-on" 
declaration not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344814396
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

rhtyd commented on issue #2324: Remove annotation and "depends-on" declaration 
not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344814303
 
 
   LGTM, thanks for fixing @rafaelweingartner 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

rhtyd closed pull request #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
 
b/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
index a51b2966631..92c128b27fe 100644
--- 
a/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
+++ 
b/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
@@ -114,13 +114,23 @@ private void addHostMetrics(final List metricsList, 
final long dcId, final
 
 final String cpuFactor = 
String.valueOf(CapacityManager.CpuOverprovisioningFactor.valueIn(host.getClusterId()));
 final CapacityVO cpuCapacity = 
capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU);
-metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, USED, 
cpuCapacity.getUsedCapacity()));
-metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, TOTAL, 
cpuCapacity.getTotalCapacity()));
+if (cpuCapacity != null) {
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, USED, 
cpuCapacity.getUsedCapacity()));
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, TOTAL, 
cpuCapacity.getTotalCapacity()));
+} else {
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, USED, 
0L));
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, TOTAL, 
0L));
+}
 
 final String memoryFactor = 
String.valueOf(CapacityManager.MemOverprovisioningFactor.valueIn(host.getClusterId()));
 final CapacityVO memCapacity = 
capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_MEMORY);
-metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, USED, 
memCapacity.getUsedCapacity()));
-metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, 
TOTAL, memCapacity.getTotalCapacity()));
+if (memCapacity != null) {
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, USED, 
memCapacity.getUsedCapacity()));
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, 
TOTAL, memCapacity.getTotalCapacity()));
+} else {
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, USED, 
0L));
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, 
TOTAL, 0L));
+}
 
 metricsList.add(new ItemHostVM(zoneName, zoneUuid, host.getName(), 
host.getUuid(), host.getPrivateIpAddress(), 
vmDao.listByHostId(host.getId()).size()));
 
@@ -128,6 +138,9 @@ private void addHostMetrics(final List metricsList, 
final long dcId, final
 if (coreCapacity != null) {
 metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), USED, 
coreCapacity.getUsedCapacity()));
 metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), TOTAL, 
coreCapacity.getTotalCapacity()));
+} else {
+metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), USED, 0L));
+metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), TOTAL, 0L));
 }
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact 

[cloudstack] branch master updated: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter (#2325)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 4fda0c0  CLOUDSTACK-9998: Fix metrics generation failurein prometheus 
exporter (#2325)
4fda0c0 is described below

commit 4fda0c039e4c24d399b2952b74ded287ec5a576a
Author: Rohit Yadav 
AuthorDate: Thu Nov 16 10:13:53 2017 +0530

CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter 
(#2325)

This fixes metrics generation failures when metrics capacities are null.

Signed-off-by: Rohit Yadav 
---
 .../cloudstack/metrics/PrometheusExporterImpl.java  | 21 +
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git 
a/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
 
b/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
index a51b296..92c128b 100644
--- 
a/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
+++ 
b/plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
@@ -114,13 +114,23 @@ public class PrometheusExporterImpl extends ManagerBase 
implements PrometheusExp
 
 final String cpuFactor = 
String.valueOf(CapacityManager.CpuOverprovisioningFactor.valueIn(host.getClusterId()));
 final CapacityVO cpuCapacity = 
capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU);
-metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, USED, 
cpuCapacity.getUsedCapacity()));
-metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, TOTAL, 
cpuCapacity.getTotalCapacity()));
+if (cpuCapacity != null) {
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, USED, 
cpuCapacity.getUsedCapacity()));
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, TOTAL, 
cpuCapacity.getTotalCapacity()));
+} else {
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, USED, 
0L));
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), cpuFactor, TOTAL, 
0L));
+}
 
 final String memoryFactor = 
String.valueOf(CapacityManager.MemOverprovisioningFactor.valueIn(host.getClusterId()));
 final CapacityVO memCapacity = 
capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_MEMORY);
-metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, USED, 
memCapacity.getUsedCapacity()));
-metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, 
TOTAL, memCapacity.getTotalCapacity()));
+if (memCapacity != null) {
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, USED, 
memCapacity.getUsedCapacity()));
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, 
TOTAL, memCapacity.getTotalCapacity()));
+} else {
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, USED, 
0L));
+metricsList.add(new ItemHostMemory(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), memoryFactor, 
TOTAL, 0L));
+}
 
 metricsList.add(new ItemHostVM(zoneName, zoneUuid, host.getName(), 
host.getUuid(), host.getPrivateIpAddress(), 
vmDao.listByHostId(host.getId()).size()));
 
@@ -128,6 +138,9 @@ public class PrometheusExporterImpl extends ManagerBase 
implements PrometheusExp
 if (coreCapacity != null) {
 metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), USED, 
coreCapacity.getUsedCapacity()));
 metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), TOTAL, 
coreCapacity.getTotalCapacity()));
+} else {
+metricsList.add(new ItemVMCore(zoneName, zoneUuid, 
host.getName(), host.getUuid(), host.getPrivateIpAddress(), USED, 0L));
+

[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-344801052
 
 
   @rhtyd listeners for global settings update and new hosts added. Also 
shuffle is back to "normal" behavior. Lists will be propagated to agents only 
when 'hosts' or 'connected.agent.mslb.algorithm' values change or new hosts 
added, using new command-answer pattern instead of `ReadyCommand`. Please 
kindly review changes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344790167
 
 
   Correct, if the XenServer cluster supports UUID resigning (per the 
cloud.cluster_details supportsResign property), then all hosts in that cluster 
should support UUID resigning.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344774116
 
 
   So, it seems to be safe to take the same assumption. Meaning that, all of 
the hosts will support this feature if the cluster has the flag 
?SupportsResigning? as true.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344772522
 
 
   I?m looking at the logic in StorageSystemSnapshotStrategy.java and it 
actually flows like this:
   
   if (volumeInfo.getFormat() == ImageFormat.VHD) {
   HostVO hostVO = getHost(volumeInfo.getId());
   
   computeClusterSupportsVolumeClone = 
clusterDao.getSupportsResigning(hostVO.getClusterId());
   }
   else if (volumeInfo.getFormat() == ImageFormat.OVA || volumeInfo.getFormat() 
== ImageFormat.QCOW2) {
   computeClusterSupportsVolumeClone = true;
   }
   else {
   throw new CloudRuntimeException("Unsupported format");
   }
   
   
   From: Rafael Weing?rtner 
   Reply-To: apache/cloudstack 
   Date: Wednesday, November 15, 2017 at 2:59 PM
   To: apache/cloudstack 
   Cc: "Tutkowski, Mike" , Mention 

   Subject: Re: [apache/cloudstack] A comprehensive solution for 
#CLOUDSTACK-9025. (#2315)
   
   
   @mike-tutkowski I am now taking into 
consideration if the storage pool is managed or not.
   I first load the storage pool where the volume of the snapshot is storage, 
and then I look for a host that I can use to execute the operation. If the 
storage pool is of managed type, I am going to check the parameter you 
mentioned (?supportsResign?) in the cluster_details table; I am also expecting 
that property to be set as true if the host supports resign UUIDs.
   
   Thanks for your help here ;)
   
   P.S. As you mentioned, this changes only affect snapshots in XenServer 
environments.
   
   ?
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub, 
or mute the 
thread.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

resmo commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344749204
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344742229
 
 
   @mike-tutkowski I am now taking into consideration if the storage pool is 
managed or not.
   I first load the storage pool where the volume of the snapshot is stored, 
and then I look for a host that I can use to execute the operation. If the 
storage pool is of managed type, I am going to check the parameter you 
mentioned (?supportsResign?) in the cluster_details table; I am also expecting 
that property to be set as true if hosts of a cluster support resign UUIDs.
   
   BTW: All of the hosts of the cluster need to support this at the same time? 
Can't we have one or two hosts in a cluster that support this feature?
   
   Thanks for your help here ;)
   
   P.S. As you mentioned, this changes only affect snapshots in XenServer 
environments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344742229
 
 
   @mike-tutkowski I am now taking into consideration if the storage pool is 
managed or not.
   I first load the storage pool where the volume of the snapshot is storage, 
and then I look for a host that I can use to execute the operation. If the 
storage pool is of managed type, I am going to check the parameter you 
mentioned (?supportsResign?) in the cluster_details table; I am also expecting 
that property to be set as true if the host supports resign UUIDs.
   
   Thanks for your help here ;)
   
   P.S. As you mentioned, this changes only affect snapshots in XenServer 
environments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344737721
 
 
   Trillian test result (tid-1654)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33353 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2325-t1654-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 59 look OK, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 60.91 | test_vpc_vpn.py
   test_07_resize_fail | `Failure` | 15.35 | test_volumes.py
   test_04_rvpc_privategw_static_routes | `Failure` | 263.75 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.08 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 117.78 | 
test_privategw_acl.py
   test_01_vpc_privategw_acl | `Failure` | 61.77 | test_privategw_acl.py
   test_05_add_annotation_for_invalid_entityType | `Error` | 0.07 | 
test_host_annotations.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.09 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_03_nic_multiple_vmware | Skipped | 1.09 | test_nic.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_list_ha_for_host_valid | Skipped | 0.03 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | Skipped | 0.04 | test_hostha_simulator.py
   test_list_ha_for_host | Skipped | 0.03 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | Skipped | 0.04 | 
test_hostha_simulator.py
   test_hostha_enable_feature_valid | Skipped | 0.04 | test_hostha_simulator.py
   test_hostha_disable_feature_valid | Skipped | 0.06 | test_hostha_simulator.py
   test_hostha_configure_invalid_provider | Skipped | 0.03 | 
test_hostha_simulator.py
   test_hostha_configure_default_driver | Skipped | 0.06 | 
test_hostha_simulator.py
   test_ha_verify_fsm_recovering | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | Skipped | 0.05 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_verify_fsm_available | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | Skipped | 0.03 | 
test_hostha_simulator.py
   test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_disable_feature_invalid | Skipped | 0.04 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.03 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_configure_ha_provider_invalid | Skipped | 0.03 | 
test_hostha_simulator.py
   test_hostha_kvm_host_degraded | Skipped | 26.11 | test_hostha_kvm.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

blueorangutan commented on issue #2324: Remove annotation and "depends-on" 
declaration not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344731026
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1256


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

blueorangutan commented on issue #2324: Remove annotation and "depends-on" 
declaration not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344724827
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

rhtyd commented on issue #2324: Remove annotation and "depends-on" declaration 
not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344724666
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344724604
 
 
   @rafaelweingartner Yes, you are correct: Use the 'managed' property of the 
storage pool in question.
   
   Also, the supportsResign property is really only relevant for XenServer. All 
versions of ESXi support UUID resigning by default and KVM doesn't require such 
support. (Note: Managed storage is only currently supported for XenServer, 
VMware, and KVM).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344724604
 
 
   @rafaelweingartner Yes, you are correct: Use the 'managed' property of the 
storage pool in question.
   
   Also, the supportsResign property is really only relevant for XenServer. All 
versions of ESXi supports UUID resigning by default and KVM doesn't require 
such support. (Note: Managed storage is only currently supported for XenServer, 
VMware, and KVM).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344723311
 
 
   @mike-tutkowski how can I check if managed storage is enabled/being used?
   
   Per your explanation, in case of managed storage I can take a look at the 
"convenience" property called 'supportsResign' in cloud.cluster_details to look 
for a host to execute the command. However, I did not 
   understand how to check if a storage is managed.
   
   Can I use the 'managed' property at the storage_pool table?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r150219895
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java
 ##
 @@ -167,35 +170,61 @@ public boolean trackVmHostChange() {
 
 @Override
 public Pair getCommandHostDelegation(long hostId, Command 
cmd) {
-LOGGER.debug("getCommandHostDelegation: " + cmd.getClass());
 if (cmd instanceof StorageSubSystemCommand) {
 StorageSubSystemCommand c = (StorageSubSystemCommand)cmd;
 c.setExecuteInSequence(true);
 }
-if (cmd instanceof CopyCommand) {
-CopyCommand cpyCommand = (CopyCommand)cmd;
-DataTO srcData = cpyCommand.getSrcTO();
-DataTO destData = cpyCommand.getDestTO();
-
-if (srcData.getHypervisorType() == HypervisorType.XenServer && 
srcData.getObjectType() == DataObjectType.SNAPSHOT &&
-destData.getObjectType() == DataObjectType.TEMPLATE) {
-DataStoreTO srcStore = srcData.getDataStore();
-DataStoreTO destStore = destData.getDataStore();
-if (srcStore instanceof NfsTO && destStore instanceof NfsTO) {
-HostVO host = hostDao.findById(hostId);
-hostDao.loadDetails(host);
-String hypervisorVersion = host.getHypervisorVersion();
-String snapshotHotFixVersion = 
host.getDetail(XenserverConfigs.XS620HotFix);
-if (hypervisorVersion != null && 
!hypervisorVersion.equalsIgnoreCase("6.1.0")) {
-if (!(hypervisorVersion.equalsIgnoreCase("6.2.0") &&
-!(snapshotHotFixVersion != null && 
snapshotHotFixVersion.equalsIgnoreCase(XenserverConfigs.XSHotFix62ESP1004 {
-return new Pair(Boolean.TRUE, new 
Long(host.getId()));
-}
-}
-}
-}
+boolean isCopyCommand = cmd instanceof CopyCommand;
+Pair defaultHostToExecuteCommands = 
super.getCommandHostDelegation(hostId, cmd);
+if (!isCopyCommand) {
+logger.debug("We are returning the default host to execute 
commands because the command is not of Copy type.");
+return defaultHostToExecuteCommands;
+}
+CopyCommand copyCommand = (CopyCommand)cmd;
+DataTO srcData = copyCommand.getSrcTO();
+DataTO destData = copyCommand.getDestTO();
+
+boolean isSourceDataHypervisorXenServer = srcData.getHypervisorType() 
== HypervisorType.XenServer;
+if (!isSourceDataHypervisorXenServer) {
+logger.debug("We are returning the default host to execute 
commands because the target hypervisor of the source data is not XenServer.");
+return defaultHostToExecuteCommands;
+}
+DataStoreTO srcStore = srcData.getDataStore();
+DataStoreTO destStore = destData.getDataStore();
+boolean isSourceAndDestinationNfsObjects = srcStore instanceof NfsTO 
&& destStore instanceof NfsTO;
+if (!isSourceAndDestinationNfsObjects) {
+logger.debug("We are returning the default host to execute 
commands because the source and destination objects are not NFS type.");
+return defaultHostToExecuteCommands;
+}
+boolean isSourceObjectSnapshotTypeAndDestinationObjectTemplateType = 
srcData.getObjectType() == DataObjectType.SNAPSHOT
+&& destData.getObjectType() == DataObjectType.TEMPLATE;
+if (!isSourceObjectSnapshotTypeAndDestinationObjectTemplateType) {
+logger.debug("We are returning the default host to execute 
commands because the source and destination objects are not snapshot and 
template respectively.");
+return defaultHostToExecuteCommands;
+}
+long snapshotId = srcData.getId();
+HostVO hostCandidateToExecutedCommand = 
hostDao.findHostConnectedToSnapshotStoragePoolToExecuteCommand(snapshotId);
+hostDao.loadDetails(hostCandidateToExecutedCommand);
+String hypervisorVersion = 
hostCandidateToExecutedCommand.getHypervisorVersion();
+if (StringUtils.isBlank(hypervisorVersion)) {
+logger.debug("We are returning the default host to execute 
commands because the hypervisor version is blank.");
+return defaultHostToExecuteCommands;
+}
+boolean isXenServer610 = StringUtils.equals(hypervisorVersion, 
"6.1.0");
+if (isXenServer610) {
+logger.debug("We are returning the default host to execute 
commands because the hypervisor version is 6.1.0.");
+return defaultHostToExecuteCommands;
+}
+String snapshotHotFixVersion = 

[GitHub] rafaelweingartner commented on issue #2324: Remove annotation and "depends-on" declaration not needed at cloud-engine-storage-image

[GitBox]

rafaelweingartner commented on issue #2324: Remove annotation and "depends-on" 
declaration not needed at cloud-engine-storage-image
URL: https://github.com/apache/cloudstack/pull/2324#issuecomment-344720865
 
 
   @DaanHoogland and @rhtyd can we check this PR?
   Travis seems to be broken now for the problem we were discussing in the 
mailing list, and this PR solves it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151244492
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   @mike-tutkowski I will take your comments into consideration. This new 
requirement will change things a bit, but at least we will make a comprehensive 
solution for snapshots in XenServer deployments
   
   As soon as I have an update, I will notify you guys


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151238297
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   "So, this requires that we use a host that has access to the primary storage 
where the snapshot resides?"
   
   Correct, but currently we only support zone-wide managed storage, so all 
hosts in the zone should have access to that primary storage.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151237628
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   On XenServer, making use of a volume snapshot that resides on primary 
storage needs to leverage a XenServer host that supports UUID resigning. UUID 
resigning is available as a patch for XenServer (@syed created it in 2016). 
When the CSMS connects with a XenServer host, it checks to see if this patch is 
installed. The results of the check are stored in cloud.host_details (the 
supportsResign property). If any host in the cluster supports UUID resigning, 
then the "convenience" property, also called supportsResign, in 
cloud.cluster_details is set to true. That being the case, we need to find one 
of these hosts in the zone when leveraging a managed snapshot on XenServer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151236239
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   So, this requires that we use a host that has access to the primary storage 
where the snapshot resides?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151234607
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   One workaround I already have in place, though, is the following (currently 
only supported on XenServer): You can pass in a parameter when taking the 
volume snapshot that tells us to put the volume snapshot on secondary storage 
instead of keeping it on primary storage. If, however, you have already created 
the snapshot on primary storage, then you'd need to create a volume from it and 
then snapshot that volume to secondary storage.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151234003
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   @mike-tutkowski, following @anshul1886 I changed this code to look for any 
host in the zone that is of the same hypervisor type of the cluster where the 
original volume of the snapshot resides on. 
   
   So, what do you guys think? let?s use only hosts of the cluster where the 
volume of the snapshot has been taken resides on? For me, it seems an easy way 
to cope with these different scenarios that we have. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

mike-tutkowski commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151232939
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   Currently managed storage is just supported at the zone level. I do have 
code in mind that would allow it to be confined to cluster scope, though. You 
make a good point that such a configuration (since snapshots for managed 
storage are stored on primary storage) would make the use of snapshots outside 
of that cluster somewhat complicated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)

[GitBox]

blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-344684559
 
 
   Trillian test result (tid-1653)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31143 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1653-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 59 look OK, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 45.89 | test_vpc_vpn.py
   test_04_rvpc_privategw_static_routes | `Failure` | 188.20 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 158.04 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 112.72 | 
test_privategw_acl.py
   test_01_vpc_privategw_acl | `Failure` | 46.69 | test_privategw_acl.py
   test_05_add_annotation_for_invalid_entityType | `Error` | 0.08 | 
test_host_annotations.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.09 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_03_nic_multiple_vmware | Skipped | 1.11 | test_nic.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | Skipped | 0.04 | test_hostha_simulator.py
   test_list_ha_for_host | Skipped | 0.03 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | Skipped | 0.04 | 
test_hostha_simulator.py
   test_hostha_enable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py
   test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_configure_invalid_provider | Skipped | 0.03 | 
test_hostha_simulator.py
   test_hostha_configure_default_driver | Skipped | 0.03 | 
test_hostha_simulator.py
   test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_verify_fsm_available | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | 
test_hostha_simulator.py
   test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_configure_ha_provider_invalid | Skipped | 0.03 | 
test_hostha_simulator.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sgoeminn commented on issue #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

sgoeminn commented on issue #1981: CLOUDSTACK-9806: Nuage domain template 
selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#issuecomment-344641295
 
 
   @rhtyd Thanks for reviewing! I addressed all your comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

nvazquez commented on a change in pull request #2309: CLOUDSTACK-10132: 
Multiple Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151170875
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -265,6 +273,8 @@ public void start() {
 s_logger.info("Attempted to connect to the server, but 
received an unexpected exception, trying again...");
 }
 }
+_shell.updateConnectedHost();
 
 Review comment:
   @rhtyd I decided to take that path as when agent is launched, the next host 
is set on constructor and then from `start()` method we couldn't know which 
host the agent is trying to connect to unless we do the same as in AgentShell 
with `hostToConnect` but on Agent class. Which approach do you think it would 
be best?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fmaximus commented on issue #2005: CLOUDSTACK-9450: Network Offering for VPC based on DB flag

[GitBox]

fmaximus commented on issue #2005: CLOUDSTACK-9450: Network Offering for VPC 
based on DB flag
URL: https://github.com/apache/cloudstack/pull/2005#issuecomment-344617293
 
 
   Our internal CI was OK, and the errors reported by Trillian don't seem 
related to the changes, 
   and the XenServer errors are the same as in the baseline #2289.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on issue #2315: A comprehensive solution for 
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344611386
 
 
   @anshul1886 I changed the methods to reflect your suggestions.
   Thanks for the help here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151139931
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   @anshul1886  Any host at all?
   I mean, if I create a snapshot of a volume that is being used in a VM in a 
XenServer host. Can I use a Vmware ESXi host to transform this snapshot into a 
volume to be used by a XenServer VM?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151139334
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -1194,4 +1178,26 @@ public HostVO findByIp(final String ipAddress) {
 sc.setParameters("type", type);
 return listBy(sc);
 }
-}
+
+String sqlFindHostConnectedToSnapshotStoragePoolToExecuteCommand = "select 
h.id from snapshots s join volumes v on v.id = s.volume_id "
++ "join storage_pool pool on pool.id = v.pool_id join cluster c on 
pool.cluster_id = c.id join host h on h.cluster_id = c.id "
 
 Review comment:
   @anshul1886  I tested this solution here to recover a volume from a snapshot 
of a volume that has been deleted, and it works. As you can see I am not 
filtering the volumes that have been deleted. 
   
   I also tested what you said that we only use the secondary storage to build 
the volume from snapshots, and it is right. This means, any XenServer of the 
Zone can execute this command then. I will update my select to reflect that.
   
   Regarding JPA, I have mixed feeling about the JPA implementation ACS uses. 
It is not a standard one and it requires too much code to achieve the same 
thing we do with SQL. Also, It does not seem to be a standard in ACS to do 
everything with JPA. I would rather use Spring-data with a commercial JPA 
implementation (EclipseLink, Hibernate, OpenJPA), but this requires some 
structural changes.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344577279
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

rhtyd commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344577088
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner opened a new pull request #2326: Re-work method QuotaResponseBuilderImpl.startOfNextDay and its test cases

[GitBox]

rafaelweingartner opened a new pull request #2326: Re-work method 
QuotaResponseBuilderImpl.startOfNextDay and its test cases
URL: https://github.com/apache/cloudstack/pull/2326
 
 
   Changed method 
org.apache.cloudstack.api.response.QuotaResponseBuilderImpl.startOfNextDay(Date)
 to use the Java 8 Date and time API. I also changed the test cases to stop 
using JodaTime, which can cause problems sometimes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

ustcweizhou commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344564483
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344560488
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1255


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anshul1886 commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

anshul1886 commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151093908
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDao.java
 ##
 @@ -103,4 +95,13 @@
 List listByType(Type type);
 
 HostVO findByIp(String ip);
+
+/**
+ * This method will look for a host that is connected to the storage pool 
where the volume of the Snapshot is stored.
+ * 
+ * If the storage pool found for the volume of the snapshotId has more 
than a host, we will choose one randomly;
+ * If no host is found, we throw a runtime exception
+ * 
+ */
+HostVO findHostToOperateOnSnapshot(long snapshotId);
 
 Review comment:
   For unmanaged storage snapshots goes on secondary storage. Secondary storage 
is accessible to all hosts in zone. So any random host in a zone will do. Once 
the snapshot is created for unmanaged storage it's independent of volume and 
storage pool. I believe managed store is zone wide so it is available to all 
and any random host in zone. Also it's handling is bit different. Confirm 
behaviour with @mike-tutkowski.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

blueorangutan commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344554848
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

rhtyd commented on issue #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325#issuecomment-344554782
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2325: CLOUDSTACK-9998: Fix metrics generation failurein prometheus exporter

[GitBox]

rhtyd opened a new pull request #2325: CLOUDSTACK-9998: Fix metrics generation 
failurein prometheus exporter
URL: https://github.com/apache/cloudstack/pull/2325
 
 
   This fixes metrics generation failures when metrics capacities are null.
   
   Pinging for review @ustcweizhou @nvazquez @DaanHoogland @borisstoyanov and 
others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anshul1886 commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

anshul1886 commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151090305
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -1194,4 +1178,26 @@ public HostVO findByIp(final String ipAddress) {
 sc.setParameters("type", type);
 return listBy(sc);
 }
-}
+
+String sqlFindHostConnectedToSnapshotStoragePoolToExecuteCommand = "select 
h.id from snapshots s join volumes v on v.id = s.volume_id "
++ "join storage_pool pool on pool.id = v.pool_id join cluster c on 
pool.cluster_id = c.id join host h on h.cluster_id = c.id "
 
 Review comment:
   Yes, we only use secondary storage to build the template from snapshot. This 
might not be applicable to managed store. But that's also available to all 
hosts in zone so any random host in a zone will do.
   
   Also we can delete volume without deleting its snapshot (backup). We only 
delete VM snapshots when we delete VM.
   
   Yes I meant using JPA queries.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anshul1886 commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

anshul1886 commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151090305
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -1194,4 +1178,26 @@ public HostVO findByIp(final String ipAddress) {
 sc.setParameters("type", type);
 return listBy(sc);
 }
-}
+
+String sqlFindHostConnectedToSnapshotStoragePoolToExecuteCommand = "select 
h.id from snapshots s join volumes v on v.id = s.volume_id "
++ "join storage_pool pool on pool.id = v.pool_id join cluster c on 
pool.cluster_id = c.id join host h on h.cluster_id = c.id "
 
 Review comment:
   Yes, we only use secondary storage to build the template from snapshot. This 
might not be applicable to managed store. But that's also available to all 
hosts in zone so any random host in a zone will do.
   
   Also we can delete volume without deleting its snapshot (backup). We only 
delete VM snapshots when we delete VM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anshul1886 commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025.

[GitBox]

anshul1886 commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151088566
 
 

 ##
 File path: api/src/com/cloud/hypervisor/HypervisorGuru.java
 ##
 @@ -45,7 +45,7 @@
 VirtualMachineTO implement(VirtualMachineProfile vm);
 
 /**
- * Give hypervisor guru opportunity to decide if certain command needs to 
be delegated to other host, mainly to secondary storage VM host
+ * Give hypervisor guru opportunity to decide if certain command needs to 
be delegated to other host, mainly from the secondary storage VM host to a real 
hypervisor host
 
 Review comment:
   This message looks ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)

[GitBox]

blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-344541040
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2281: CLOUDSTACK-10102: New network type (L2)

[GitBox]

borisstoyanov commented on issue #2281: CLOUDSTACK-10102: New network type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-344540920
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.10 updated: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND in VPC VR (#2313)

[resmo]

This is an automated email from the ASF dual-hosted git repository.

resmo pushed a commit to branch 4.10
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.10 by this push:
 new 4f1539e  CLOUDSTACK-10135 ACL rules order is not maintained for 
ACL_OUTBOUND in VPC VR (#2313)
4f1539e is described below

commit 4f1539ee707c2d5cf48b454139b64998ddb484ac
Author: subhash yedugundla 
AuthorDate: Wed Nov 15 14:36:00 2017 +0530

CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND in VPC 
VR (#2313)

(cherry picked from commit 60bec39b9ddb72c9badda49dc39c4105596bcb90)
---
 systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
index 9c6c2e5..035125e 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
@@ -167,7 +167,7 @@ class CsNetfilters(object):
 cpy = cpy.replace('-A', '-I')
 if isinstance(fw[1], int):
 # if the rule is for ACLs, we want to insert them in 
order, right before the DROP all
-if rule_chain.startswith("ACL_INBOUND"):
+if rule_chain.startswith("ACL_INBOUND") or 
rule_chain.startswith("ACL_OUTBOUND"):
 rule_count = self.chain.get_count(rule_chain)
 cpy = cpy.replace("-A %s" % new_rule.get_chain(), '-I 
%s %s' % (new_rule.get_chain(), rule_count))
 else:

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-344530600
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1254


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.9 updated: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND in VPC VR (#2313)

[resmo]

This is an automated email from the ASF dual-hosted git repository.

resmo pushed a commit to branch 4.9
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.9 by this push:
 new f250b3a  CLOUDSTACK-10135 ACL rules order is not maintained for 
ACL_OUTBOUND in VPC VR (#2313)
f250b3a is described below

commit f250b3ae0cf7efeef486f15474b606299d17318e
Author: subhash yedugundla 
AuthorDate: Wed Nov 15 14:36:00 2017 +0530

CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND in VPC 
VR (#2313)

(cherry picked from commit 60bec39b9ddb72c9badda49dc39c4105596bcb90)
---
 systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
index 3ee5174..80b930e 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
@@ -168,7 +168,7 @@ class CsNetfilters(object):
 cpy = cpy.replace('-A', '-I')
 if isinstance(fw[1], int):
 # if the rule is for ACLs, we want to insert them in 
order, right before the DROP all
-if rule_chain.startswith("ACL_INBOUND"):
+if rule_chain.startswith("ACL_INBOUND") or 
rule_chain.startswith("ACL_OUTBOUND"):
 rule_count = self.chain.get_count(rule_chain)
 cpy = cpy.replace("-A %s" % new_rule.get_chain(), '-I 
%s %s' % (new_rule.get_chain(), rule_count))
 else:

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] resmo commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

resmo commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-344529623
 
 
   cherry-picking to 4.9 and 4.10


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND in VPC VR (#2313)

[resmo]

This is an automated email from the ASF dual-hosted git repository.

resmo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 60bec39  CLOUDSTACK-10135 ACL rules order is not maintained for 
ACL_OUTBOUND in VPC VR (#2313)
60bec39 is described below

commit 60bec39b9ddb72c9badda49dc39c4105596bcb90
Author: subhash yedugundla 
AuthorDate: Wed Nov 15 14:36:00 2017 +0530

CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND in VPC 
VR (#2313)
---
 systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
index 9c6c2e5..035125e 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
@@ -167,7 +167,7 @@ class CsNetfilters(object):
 cpy = cpy.replace('-A', '-I')
 if isinstance(fw[1], int):
 # if the rule is for ACLs, we want to insert them in 
order, right before the DROP all
-if rule_chain.startswith("ACL_INBOUND"):
+if rule_chain.startswith("ACL_INBOUND") or 
rule_chain.startswith("ACL_OUTBOUND"):
 rule_count = self.chain.get_count(rule_chain)
 cpy = cpy.replace("-A %s" % new_rule.get_chain(), '-I 
%s %s' % (new_rule.get_chain(), rule_count))
 else:

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] resmo closed pull request #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

resmo closed pull request #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
index 9c6c2e56772..035125e4fea 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
@@ -167,7 +167,7 @@ def compare(self, list):
 cpy = cpy.replace('-A', '-I')
 if isinstance(fw[1], int):
 # if the rule is for ACLs, we want to insert them in 
order, right before the DROP all
-if rule_chain.startswith("ACL_INBOUND"):
+if rule_chain.startswith("ACL_INBOUND") or 
rule_chain.startswith("ACL_OUTBOUND"):
 rule_count = self.chain.get_count(rule_chain)
 cpy = cpy.replace("-A %s" % new_rule.get_chain(), '-I 
%s %s' % (new_rule.get_chain(), rule_count))
 else:


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage 
domain template selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151065954
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDomainTemplatesCmd.java
 ##
 @@ -0,0 +1,118 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.api.response.NuageVspDomainTemplateResponse;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseResponse;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+
+import javax.inject.Inject;
+import java.util.List;
+@APICommand(name = ListNuageVspDomainTemplatesCmd.APINAME, responseObject = 
BaseResponse.class, description = "Lists Nuage VSP domain templates", since = 
"4.11", responseHasSensitiveInfo = false, authorized = {RoleType.Admin, 
RoleType.DomainAdmin, RoleType.User})
+public class ListNuageVspDomainTemplatesCmd extends BaseCmd {
+static final String APINAME = "listNuageVspDomainTemplates";
+
+@Inject
+private NuageVspManager _nuageVspManager;
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class,
+description = "the domain ID")
+private Long domainId;
+
+@Parameter(name = ApiConstants.PHYSICAL_NETWORK_ID, type = 
CommandType.UUID, entityType = PhysicalNetworkResponse.class,
+description = "the physical network ID")
+private Long physicalNetworkId;
+
+@Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID, 
entityType = ZoneResponse.class,
+description = "the zone ID")
+private Long zoneId;
+
+@Parameter(name = ApiConstants.KEYWORD, type = CommandType.STRING,
+description = "filters the domain templates which contain the keyword")
+private String keyword;
+
+/
+/// Accessors ///
+/
+
+public String getKeyword() {
+return keyword;
+}
+
+public Long getDomainId() {
+return domainId;
+}
+
+public Long getPhysicalNetworkId() {
+return physicalNetworkId;
+}
+
+public Long getZoneId() { return zoneId; }
+/
 
 Review comment:
   @sgoeminn fix indents and newlines please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage 
domain template selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151065901
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDomainTemplatesCmd.java
 ##
 @@ -0,0 +1,118 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.api.response.NuageVspDomainTemplateResponse;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseResponse;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+
+import javax.inject.Inject;
+import java.util.List;
 
 Review comment:
   @sgoeminn newline here please, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage 
domain template selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151065868
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDomainTemplatesCmd.java
 ##
 @@ -0,0 +1,118 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.api.response.NuageVspDomainTemplateResponse;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseResponse;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+
+import javax.inject.Inject;
+import java.util.List;
+@APICommand(name = ListNuageVspDomainTemplatesCmd.APINAME, responseObject = 
BaseResponse.class, description = "Lists Nuage VSP domain templates", since = 
"4.11", responseHasSensitiveInfo = false, authorized = {RoleType.Admin, 
RoleType.DomainAdmin, RoleType.User})
+public class ListNuageVspDomainTemplatesCmd extends BaseCmd {
+static final String APINAME = "listNuageVspDomainTemplates";
 
 Review comment:
   @sgoeminn thanks, LGTM. Please follow the same across other Cmd 
implementations.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage 
domain template selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151065651
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AssociateNuageVspDomainTemplateCmd.java
 ##
 @@ -0,0 +1,113 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
 
 Review comment:
   @sgoeminn fix indent please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage 
domain template selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151065766
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AssociateNuageVspDomainTemplateCmd.java
 ##
 @@ -0,0 +1,113 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.VpcResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+
+@APICommand(name = "associateNuageVspDomainTemplate", responseObject = 
SuccessResponse.class, description = "associate a vpc with a domain template", 
authorized = {RoleType.Admin, RoleType.DomainAdmin, RoleType.User})
+public class AssociateNuageVspDomainTemplateCmd extends BaseCmd {
+private static final Logger s_logger = 
Logger.getLogger(AssociateNuageVspDomainTemplateCmd.class.getName());
+private static final String s_name = 
"associatenuagevspdomaintemplateresponse";
 
 Review comment:
   @sgoeminn this still does not declare use `APINAME` as a reference/usage 
pattern as seen in recent/modern API implementations such as ListRolesCmd etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151065113
 
 

 ##
 File path: 
server/src/org/apache/cloudstack/agent/mslb/AgentMSLBServiceImpl.java
 ##
 @@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.agent.mslb;
+
+import com.cloud.agent.AgentManager;
+import com.cloud.host.Host;
+import com.cloud.host.HostVO;
+import com.cloud.hypervisor.Hypervisor;
+import com.cloud.resource.ResourceManager;
+import com.cloud.resource.ResourceState;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import java.util.stream.Collectors;
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.agent.mslb.algorithm.AgentMSLBRoundRobinAlgorithm;
+import org.apache.cloudstack.agent.mslb.algorithm.AgentMSLBShuffleAlgorithm;
+import org.apache.cloudstack.agent.mslb.algorithm.AgentMSLBStaticAlgorithm;
+import org.apache.cloudstack.config.ApiServiceConfiguration;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.component.ComponentLifecycleBase;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.google.common.base.Strings;
+
+public class AgentMSLBServiceImpl extends ComponentLifecycleBase implements 
AgentMSLB, Configurable {
+public static final Logger LOG = 
Logger.getLogger(AgentMSLBServiceImpl.class);
+
+public static final ConfigKey ConnectedAgentLBAlgorithm = new 
ConfigKey<>("Advanced", String.class,
+"connected.agent.mslb.algorithm", "static",
+"The algorithm to applied on the provided 'host' management server 
list that is sent to indirect agents. Allowed values are: static, roundrobin 
and shuffle.",
+true, ConfigKey.Scope.Global);
+
+private static Map algorithmMap = new 
HashMap<>();
+
+@Inject
+ResourceManager resourceManager;
+@Inject
+AgentManager agentManager;
+
+@Override
+public List getManagementServerList(Long hostId, Long dcId) {
+
+final String msServerAddresses = 
ApiServiceConfiguration.ManagementServerAddresses.value();
+if (Strings.isNullOrEmpty(msServerAddresses)) {
+throw new CloudRuntimeException(String.format("No management 
server addresses are defined in '%s' setting",
+ApiServiceConfiguration.ManagementServerAddresses.key()));
+}
+
+List orderedHostIds = getOrderedRunningHostIds(dcId);
+List msList = Arrays.asList(msServerAddresses.replace(" ", 
"").split(","));
+AgentMSLBAlgorithm algorithm = getAgentMSLBAlgorithm();
+return algorithm.getMSList(msList, orderedHostIds, hostId);
+}
+
+protected List getOrderedRunningHostIds(Long dcId) {
+List hosts = 
resourceManager.listAllHostsInOneZoneByType(Host.Type.Routing, dcId);
+if (hosts != null) {
+return hosts.stream()
+.filter(x -> 
x.getHypervisorType().equals(Hypervisor.HypervisorType.KVM) &&
 
 Review comment:
   This should not be restricted just for KVM, but for any connected (indirect) 
agent.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151064254
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -699,16 +721,102 @@ public void processResponse(final Response response, 
final Link link) {
 }
 }
 
-public void processReadyCommand(final Command cmd) {
+/**
+ * Checks if received list is different to actual management server list 
(in order and size)
+ * @param actual actual list
+ * @param received received list
+ * @return true if list is updated, false if not
+ */
+private boolean isReceivedListUpdated(List actual, List 
received) {
+if (actual.size() != received.size()) {
+return true;
+}
+for (int i = 0; i < received.size(); i++) {
+if (!received.get(i).equals(actual.get(i))) {
+return true;
+}
+}
+return false;
+}
+
+/**
+ * Persist newly received management servers list
+ * @param msList management servers list
+ */
+private void persistNewManagementServersList(List msList) {
+final String newHosts = StringUtils.toCSVList(msList);
+_shell.setHosts(newHosts);
+_shell.setPersistentProperty(null, "host", newHosts);
+s_logger.info("Saved new management servers list: " + msList);
+}
+
+/**
+ * Try reconnecting to preferred management server after new list is 
received.
+ * If connection is not performed, host counter is reset
+ */
+private void attemptReconnectionToPrimaryHost() {
+boolean connection = false;
+String preferred = _shell.getNextHost();
+try {
+if (_link != null) {
+boolean isHostUp = true;
+try (final Socket socket = new Socket()) {
+socket.connect(new InetSocketAddress(preferred, 
_shell.getPort()), 5000);
+} catch (final IOException e) {
+isHostUp = false;
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("Preferred host: " + preferred + " is 
not reachable");
+}
+}
+if (isHostUp && _link != null && _inProgress.get() == 0) {
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("Preferred host: " +  preferred + " is 
found to be reachable, trying to reconnect");
+}
+reconnect(_link);
+connection = true;
+_shell.updateConnectedHost();
+}
+}
+} catch (Exception e) {
+s_logger.warn("Couldn't reconnect to preferred host: " + preferred 
+ " received on management servers list");
+} finally {
+if (!connection) {
+_shell.resetHostCounter();
+}
+}
+}
 
+/**
+ * Checks if primary host on received list has changed
+ * @param currentList current hosts list
+ * @param newList new hosts list
+ * @return true if primary host has changed, false if not
+ */
+private boolean hasPrimaryHostChanged(List currentList, 
List newList) {
+return !newList.get(0).equals(currentList.get(0));
+}
+
+public void processReadyCommand(final Command cmd) {
 final ReadyCommand ready = (ReadyCommand)cmd;
 
-s_logger.info("Proccess agent ready command, agent id = " + 
ready.getHostId());
+s_logger.info("Processing agent ready command, agent id = " + 
ready.getHostId());
 if (ready.getHostId() != null) {
 setId(ready.getHostId());
 }
-s_logger.info("Ready command is processed: agent id = " + getId());
 
+final List msList = ready.getMsList();
+if (msList != null && msList.size() > 0) {
+final List hosts = Arrays.asList(_shell.getHosts());
+s_logger.info("Received management servers list: " + msList + ", 
current list: " + hosts);
+if (isReceivedListUpdated(hosts, msList)) {
+persistNewManagementServersList(msList);
+_shell.resetHostCounter();
+if (hasPrimaryHostChanged(hosts, msList)) {
+attemptReconnectionToPrimaryHost();
 
 Review comment:
   @nvazquez this can be removed, the ReadyCommand handler should not be 
responsible for reconnection/switching.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151064321
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -699,16 +721,102 @@ public void processResponse(final Response response, 
final Link link) {
 }
 }
 
-public void processReadyCommand(final Command cmd) {
+/**
+ * Checks if received list is different to actual management server list 
(in order and size)
+ * @param actual actual list
+ * @param received received list
+ * @return true if list is updated, false if not
+ */
+private boolean isReceivedListUpdated(List actual, List 
received) {
+if (actual.size() != received.size()) {
+return true;
+}
+for (int i = 0; i < received.size(); i++) {
+if (!received.get(i).equals(actual.get(i))) {
+return true;
+}
+}
+return false;
+}
+
+/**
+ * Persist newly received management servers list
+ * @param msList management servers list
+ */
+private void persistNewManagementServersList(List msList) {
+final String newHosts = StringUtils.toCSVList(msList);
+_shell.setHosts(newHosts);
+_shell.setPersistentProperty(null, "host", newHosts);
+s_logger.info("Saved new management servers list: " + msList);
+}
+
+/**
+ * Try reconnecting to preferred management server after new list is 
received.
+ * If connection is not performed, host counter is reset
+ */
+private void attemptReconnectionToPrimaryHost() {
 
 Review comment:
   @nvazquez this method duplicates code and is not necessary, may be removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151064002
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -265,6 +273,8 @@ public void start() {
 s_logger.info("Attempted to connect to the server, but 
received an unexpected exception, trying again...");
 }
 }
+_shell.updateConnectedHost();
 
 Review comment:
   @nvazquez to be on safer/deterministic side, can this method accept the 
`host` String and set that instead of `hostToConnect`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151063773
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -216,6 +223,7 @@ public String getPod() {
 }
 
 protected void setLink(final Link link) {
+s_logger.info("Setting up link!");
 
 Review comment:
   I had put this for logging/debugging, may be removed. @nvazquez 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r151063636
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -138,12 +143,14 @@ public int value() {
 private String _keystoreSetupPath;
 private String _keystoreCertImportPath;
 
+private Long connectionTimeout = 12L;
 
 Review comment:
   @nvazquez This is not used anywhere, can be removed. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-344525090
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-344524745
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1253


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

blueorangutan commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-344524902
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not maintained for ACL_OUTBOUND i?

[GitBox]

rhtyd commented on issue #2313: CLOUDSTACK-10135 ACL rules order is not 
maintained for ACL_OUTBOUND i?
URL: https://github.com/apache/cloudstack/pull/2313#issuecomment-344524667
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] smeetsr commented on issue #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

smeetsr commented on issue #1981: CLOUDSTACK-9806: Nuage domain template 
selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#issuecomment-344521891
 
 
   After above commit , again I did a rerun of 
test_nuage_vpc_domain_template.py and all tests were successful.
   Test Nuage VSP Domain Template selection per VPC ... === TestName: 
test_01_nuage_Domain_Template_selection_per_VPC | Status : SUCCESS ===
   ok
   Test Nuage VSP Domain Template selection per VPC as ROOT domain ... === 
TestName: test_02_nuage_Domain_Template_selection_per_VPC_as_ROOT_user | Status 
: SUCCESS ===
   ok
   Test Nuage VSP Domain Template selection per VPC as domain admin ... === 
TestName: test_03_nuage_Domain_Template_selection_per_VPC_as_domain_admin | 
Status : SUCCESS ===
   ok
   Test Nuage VSP Domain Template selection per VPC as domain ... === TestName: 
test_04_nuage_Domain_Template_selection_per_VPC_as_domain_user | Status : 
SUCCESS ===
   ok
   Test Nuage VSP Domain Template selection per VPC as subdomain admin ... === 
TestName: test_05_nuage_Domain_Template_selection_per_VPC_as_subdom_admin | 
Status : SUCCESS ===
   ok
   Test Nuage VSP Domain Template selection per VPC as subdomain ... === 
TestName: test_06_nuage_Domain_Template_selection_per_VPC_as_subdom_user | 
Status : SUCCESS ===
   ok
   Test Nuage VSP Global Domain Template ... === TestName: 
test_07_nuage_Global_Domain_Template | Status : SUCCESS ===
   ok
   Test Nuage VSP Global Domain Template as ROOT domain regular user ... === 
TestName: test_08_nuage_Global_Domain_Template_as_ROOT_user | Status : SUCCESS 
===
   ok
   Test Nuage VSP Global Domain Template as domain admin user ... === TestName: 
test_09_nuage_Global_Domain_Template_as_domain_admin | Status : SUCCESS ===
   ok
   Test Nuage VSP Global Domain Template as domain regular user ... === 
TestName: test_10_nuage_Global_Domain_Template_as_domain_user | Status : 
SUCCESS ===
   ok
   Test Nuage VSP Global Domain Template as subdomain admin user ... === 
TestName: test_11_nuage_Global_Domain_Template_as_subdomain_admin | Status : 
SUCCESS ===
   ok
   Test Nuage VSP Global Domain Template as subdomain regular user ... === 
TestName: test_12_nuage_Global_Domain_Template_as_subdomain_user | Status : 
SUCCESS ===
   ok
   
   --
   Ran 12 tests in 5290.439s
   
   OK


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sgoeminn commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC

[GitBox]

sgoeminn commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage 
domain template selection per VPC
URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151059953
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDomainTemplatesCmd.java
 ##
 @@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.api.response.NuageVspDomainTemplateResponse;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.BaseResponse;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.List;
+
+@APICommand(name = "listNuageVspDomainTemplates", responseObject = 
BaseResponse.class, description = "Lists Nuage VSP domain templates", 
authorized = {RoleType.Admin, RoleType.DomainAdmin, RoleType.User})
+public class ListNuageVspDomainTemplatesCmd extends BaseListCmd {
 
 Review comment:
   @rhtyd I made it aligned with the ListRolesCmd implementation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-344519057
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

borisstoyanov commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-344518981
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on a change in pull request #2120: CLOUDSTACK-9665 List hosts api does not report correct cpu and memory?

[GitBox]

ustcweizhou commented on a change in pull request #2120: CLOUDSTACK-9665 List 
hosts api does not report correct cpu and memory?
URL: https://github.com/apache/cloudstack/pull/2120#discussion_r151056366
 
 

 ##
 File path: server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java
 ##
 @@ -297,8 +299,10 @@ public HostForMigrationResponse 
newHostForMigrationResponse(HostJoinVO host, Enu
 Long mem = host.getMemReservedCapacity() + 
host.getMemUsedCapacity();
 Long cpu = host.getCpuReservedCapacity() + 
host.getCpuReservedCapacity();
 
-hostResponse.setMemoryAllocated(mem);
-hostResponse.setMemoryTotal(host.getTotalMemory());
+hostResponse.setMemoryTotal(mem);
 
 Review comment:
   this also needs to be fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services