[GitHub] rhtyd opened a new pull request #2336: CLOUDSTACK-10153: Introduce string API arg trust validation

2017-11-22 Thread GitBox
rhtyd opened a new pull request #2336: CLOUDSTACK-10153: Introduce string API arg trust validation URL: https://github.com/apache/cloudstack/pull/2336 Adds new API string argument/field validator that validates the string as untrusted HTML using owasp's java-html-sanitizer. This also

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-22 Thread GitBox
blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-346540911 Packaging result: ?centos6 ?centos7 ?debian. JID-1286

[GitHub] yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152729213 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6 +348,53 @@

[GitHub] yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152729068 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6 +348,53 @@

[GitHub] yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152729068 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6 +348,53 @@

[GitHub] yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152728899 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -296,21 +296,9 @@

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-22 Thread GitBox
rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-346538405 @blueorangutan package This is an automated message from

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-22 Thread GitBox
blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-346538443 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-22 Thread GitBox
rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-346538388 @fmaximus I see several failures compared to baseline 4.9 tests results: https://github.com/apache/cloudstack/pull/2318

[cloudstack] branch master updated: CLOUDSTACK-10152: Skip the destination cidr in ipset when 0.0.0.0/0 pa… (#2334)

2017-11-22 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 8832758 CLOUDSTACK-10152: Skip the

[GitHub] rhtyd closed pull request #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa?

2017-11-22 Thread GitBox
rhtyd closed pull request #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa? URL: https://github.com/apache/cloudstack/pull/2334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rhtyd commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa?

2017-11-22 Thread GitBox
rhtyd commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa? URL: https://github.com/apache/cloudstack/pull/2334#issuecomment-346538079 LGTM merging, tests LGTM as well. This is an

[GitHub] rhtyd closed pull request #2332: [CLOUDSTACK-10156] Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rhtyd closed pull request #2332: [CLOUDSTACK-10156] Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[cloudstack] branch master updated: CLOUDSTACK-10156: Fix Coverity new problems CID(1349987, 1349986, 1347248) (#2332)

2017-11-22 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new cb9c7ad CLOUDSTACK-10156: Fix Coverity

[GitHub] rhtyd commented on issue #2332: [CLOUDSTACK-10156] Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rhtyd commented on issue #2332: [CLOUDSTACK-10156] Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346537900 @rafaelweingartner I've fixed a minor spacing/styling issue. LGTM merging.

[GitHub] blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346513448 Trillian test result (tid-1682) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server

[GitHub] rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152687004 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6

[GitHub] rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152688675 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -296,21

[GitHub] rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152689285 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6

[GitHub] rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152687200 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6

[GitHub] rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#discussion_r152687874 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -360,6

[GitHub] blueorangutan commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa?

2017-11-22 Thread GitBox
blueorangutan commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa? URL: https://github.com/apache/cloudstack/pull/2334#issuecomment-346485436 Trillian test result (tid-1681) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] rafaelweingartner commented on issue #2332: [CLOUDSTACK-10156] Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rafaelweingartner commented on issue #2332: [CLOUDSTACK-10156] Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346484103 @rhtyd done! This is an

[GitHub] rhtyd commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
rhtyd commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346480606 The PR author is requested to take suitable actions.

[GitHub] rafaelweingartner commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
rafaelweingartner commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346480119 @rhtyd this PR can be closed as we are all working towards a solution for this problem at #2315 .

[GitHub] blueorangutan commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
blueorangutan commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346479894 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
blueorangutan commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#issuecomment-346479902 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
rhtyd commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346479875 @blueorangutan test This is an automated

[GitHub] rafaelweingartner commented on a change in pull request #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#discussion_r152683908 ## File path:

[GitHub] rhtyd commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rhtyd commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#issuecomment-346479795 @blueorangutan test This is an automated message from the Apache Git

[GitHub] rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-11-22 Thread GitBox
rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-346479692 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-11-22 Thread GitBox
blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-346479711 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rafaelweingartner commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rafaelweingartner commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346479494 @rhtyd sure I can create a Jira ticket. I have some remarks in the code you are introducing. I will create

[GitHub] rhtyd commented on a change in pull request #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rhtyd commented on a change in pull request #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#discussion_r152683630 ## File path: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java

[GitHub] rafaelweingartner commented on a change in pull request #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rafaelweingartner commented on a change in pull request #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#discussion_r152683247 ## File path:

[GitHub] rhtyd commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rhtyd commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346473238 Tests lgtm, fixed redundant logging. @rafaelweingartner can you check and add a jira ID, then we can merge it. Thanks.

[GitHub] rhtyd commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rhtyd commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346473238 Tests lgtm, fixed redundant logging. Will merge. This is an

[GitHub] blueorangutan commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
blueorangutan commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346471610 Trillian test result (tid-1680) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
blueorangutan commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346340473 Packaging result: ?centos6 ?centos7 ?debian. JID-1285

[GitHub] borisstoyanov opened a new pull request #2335: CLOUDSTACK-10154: fixing some smoketests failures

2017-11-22 Thread GitBox
borisstoyanov opened a new pull request #2335: CLOUDSTACK-10154: fixing some smoketests failures URL: https://github.com/apache/cloudstack/pull/2335 ssvm tests: Marvin Init Successful === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === === TestName:

[GitHub] blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346339484 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346339366 thanks @rhtyd @blueorangutan test centos7 kvm-centos7 component/test_affinity_groups_projects.py

[GitHub] resmo closed pull request #2323: CLOUDSTACK-10043: fix restore default drop for egress rules in ACL

2017-11-22 Thread GitBox
resmo closed pull request #2323: CLOUDSTACK-10043: fix restore default drop for egress rules in ACL URL: https://github.com/apache/cloudstack/pull/2323 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] resmo commented on issue #2323: CLOUDSTACK-10043: fix restore default drop for egress rules in ACL

2017-11-22 Thread GitBox
resmo commented on issue #2323: CLOUDSTACK-10043: fix restore default drop for egress rules in ACL URL: https://github.com/apache/cloudstack/pull/2323#issuecomment-346337695 I would say, close this PR and I am going for the option 3.

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-11-22 Thread GitBox
blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-346337404 Packaging result: ?centos6 ?centos7 ?debian. JID-1283

[GitHub] blueorangutan commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
blueorangutan commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#issuecomment-346337407 Packaging result: ?centos6 ?centos7 ?debian. JID-1284 This is

[GitHub] blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346337371 Packaging result: ?centos6 ?centos7 ?debian. JID-1282

[GitHub] marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-22 Thread GitBox
marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346335644 @rhtyd My goal was to align all projects, all poms to follow one standard, a cleanup process thing. Currently there are 3 types of project: the

[GitHub] rhtyd closed pull request #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-11-22 Thread GitBox
rhtyd closed pull request #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[cloudstack] branch master updated: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets (#2028)

2017-11-22 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 632479d CLOUDSTACK-9853: Add support for

[GitHub] blueorangutan commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
blueorangutan commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346330340 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

2017-11-22 Thread GitBox
rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-346330345 LGTM, the failing tests are known intermittent issues. I'll merge this, thanks @wido

[GitHub] rhtyd commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ?

2017-11-22 Thread GitBox
rhtyd commented on issue #2317: CLOUDSTACK-9025: Fixed Unable to deploy VM instance from template if ? URL: https://github.com/apache/cloudstack/pull/2317#issuecomment-346330181 @blueorangutan package This is an

[GitHub] rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2017-11-22 Thread GitBox
rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-346329819 @PranaliM are you adding a marvin (or unit) test?

[GitHub] rhtyd commented on issue #2131: CLOUDSTACK-9929: Do not gather statistics for CDROM or FLOPPY devices

2017-11-22 Thread GitBox
rhtyd commented on issue #2131: CLOUDSTACK-9929: Do not gather statistics for CDROM or FLOPPY devices URL: https://github.com/apache/cloudstack/pull/2131#issuecomment-346329884 @wido checked, this was forward merged on master. The changes are on both 4.10 and master.

[GitHub] blueorangutan commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
blueorangutan commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#issuecomment-346329683 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-11-22 Thread GitBox
rhtyd commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#issuecomment-346329566 LGTM, pending travis results. @blueorangutan package This is an

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-11-22 Thread GitBox
blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-346329259 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346329050 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-11-22 Thread GitBox
rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-346329069 LGTM, pending testing. @blueorangutan package This is

[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346328960 @blueorangutan package This is an

[cloudstack] branch master updated: CLOUDSTACK-10133: Local storage overprovisioning for ext file system (#2310)

2017-11-22 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 421517f CLOUDSTACK-10133: Local storage

[GitHub] rhtyd closed pull request #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system

2017-11-22 Thread GitBox
rhtyd closed pull request #2310: CLOUDSTACK-10133 Local storage overprovisioning for ext file system URL: https://github.com/apache/cloudstack/pull/2310 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rhtyd commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2017-11-22 Thread GitBox
rhtyd commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-346328788 @yvsubhash please check errors This is an automated

[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-22 Thread GitBox
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-346328093 LGTM @borisstoyanov, I've remove duplicates from .travis.yml and re-sorted them. Can you re-run tests on

[GitHub] rhtyd closed pull request #2219: CLOUDSTACK-9989: Extend smoketests suite

2017-11-22 Thread GitBox
rhtyd closed pull request #2219: CLOUDSTACK-9989: Extend smoketests suite URL: https://github.com/apache/cloudstack/pull/2219 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[cloudstack] branch master updated: CLOUDSTACK-9989: Extend smoketests suite (#2219)

2017-11-22 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new fd7eeb4 CLOUDSTACK-9989: Extend

[GitHub] rhtyd commented on issue #2219: CLOUDSTACK-9989: Extend smoketests suite

2017-11-22 Thread GitBox
rhtyd commented on issue #2219: CLOUDSTACK-9989: Extend smoketests suite URL: https://github.com/apache/cloudstack/pull/2219#issuecomment-346325140 LGTM, the travis job `TestStorageTags:tearDown` failure is known intermittent failure.

[GitHub] rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

2017-11-22 Thread GitBox
rhtyd commented on a change in pull request #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ? URL: https://github.com/apache/cloudstack/pull/2312#discussion_r152537685 ## File path: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ##

[GitHub] rhtyd commented on issue #2323: CLOUDSTACK-10043: fix restore default drop for egress rules in ACL

2017-11-22 Thread GitBox
rhtyd commented on issue #2323: CLOUDSTACK-10043: fix restore default drop for egress rules in ACL URL: https://github.com/apache/cloudstack/pull/2323#issuecomment-346322490 @resmo are you planning to work on option 3 (from dev@ ML) or go with this change (drop by default) ?

[GitHub] rhtyd commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-22 Thread GitBox
rhtyd commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346321448 It will be difficult to accept this at this point with more than 150 PRs pending review/merge, as this will potentially cause merge conflicts on all

[GitHub] rhtyd commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-22 Thread GitBox
rhtyd commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346321448 It will be difficult to accept this at this point with more than 150 PRs pending review/merge, as this will potentially cause merge conflicts on all

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-22 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346314723 @marcaurele from me you have an LGTM This is an automated message from

[GitHub] blueorangutan commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa?

2017-11-22 Thread GitBox
blueorangutan commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa? URL: https://github.com/apache/cloudstack/pull/2334#issuecomment-346290200 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
blueorangutan commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346290194 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248)

2017-11-22 Thread GitBox
rhtyd commented on issue #2332: Fix Coverity new problems CID(1349987, 1349986, 1347248) URL: https://github.com/apache/cloudstack/pull/2332#issuecomment-346290049 @blueorangutan test This is an automated message from the

[GitHub] rhtyd commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa?

2017-11-22 Thread GitBox
rhtyd commented on issue #2334: CLOUDSTACK-10152:Skip the destination cidr in ipset when 0.0.0.0/0 pa? URL: https://github.com/apache/cloudstack/pull/2334#issuecomment-346290021 @blueorangutan test This is an automated

[GitHub] marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-22 Thread GitBox
marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346286289 @rhtyd @rafaelweingartner @wido this PR to move all projects structure to maven standard is passing all the tests. I'm ready to fix the conflict

[GitHub] blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline

2017-11-22 Thread GitBox
blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-346285073 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been

[GitHub] borisstoyanov commented on issue #2318: [4.9] Smoketest health checkrun baseline

2017-11-22 Thread GitBox
borisstoyanov commented on issue #2318: [4.9] Smoketest health checkrun baseline URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-346284870 @blueorangutan test matrix This is an automated message from the

[GitHub] bwsw commented on a change in pull request #2319: CLOUDSTACK-10138: Load br_netfilter in security_group management script

2017-11-22 Thread GitBox
bwsw commented on a change in pull request #2319: CLOUDSTACK-10138: Load br_netfilter in security_group management script URL: https://github.com/apache/cloudstack/pull/2319#discussion_r152493705 ## File path: scripts/vm/network/security_group.py ## @@ -61,6 +64,15 @@ def

[GitHub] bwsw commented on a change in pull request #2319: CLOUDSTACK-10138: Load br_netfilter in security_group management script

2017-11-22 Thread GitBox
bwsw commented on a change in pull request #2319: CLOUDSTACK-10138: Load br_netfilter in security_group management script URL: https://github.com/apache/cloudstack/pull/2319#discussion_r152493705 ## File path: scripts/vm/network/security_group.py ## @@ -61,6 +64,15 @@ def