[GitHub] blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-371019688
 
 
   Trillian test result (tid-2328)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 21963 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2474-t2328-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 52 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 329.18 | 
test_privategw_acl.py
   test_02_edit_iso | `Failure` | 0.04 | test_iso.py
   test_05_iso_permissions | `Failure` | 0.05 | test_iso.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-371014155
 
 
   Trillian test result (tid-2327)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28075 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2387-t2327-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 128.29 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 137.84 | test_volumes.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 324.51 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

[GitBox]

blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to 
each ACL Rule
URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-370998663
 
 
   Trillian test result (tid-2326)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22170 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2475-t2326-kvm-centos7.zip
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370973833
 
 
   Trillian test result (tid-2324)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26230 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2476-t2324-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

[GitBox]

blueorangutan commented on issue #2477: Smaller systemvm images using sparse 
disks.
URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-370950244
 
 
   Trillian test result (tid-2320)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36673 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2477-t2320-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 187.68 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.69 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 277.73 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.53 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 141.07 | test_volumes.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.40 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.72 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370944019
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370943779
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370917680
 
 
   Trillian test result (tid-2319)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33265 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2465-t2319-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 128.39 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 141.78 | test_volumes.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.39 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370913368
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1762


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370900817
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

[GitBox]

blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to 
each ACL Rule
URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-370900482
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-370900489
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370900571
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

[GitBox]

borisstoyanov commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to 
each ACL Rule
URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-370900354
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

borisstoyanov commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-370900271
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

[GitBox]

blueorangutan commented on issue #2477: Smaller systemvm images using sparse 
disks.
URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-370885988
 
 
   Trillian test result (tid-2321)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23970 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2477-t2321-vmware-65.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370881992
 
 
   Trillian test result (tid-2317)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29943 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2476-t2317-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 186.17 | 
test_privategw_acl.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.75 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370865982
 
 
   @khos2ow would you mind reviewing this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370853345
 
 
   @DaanHoogland this test `test_hostha_enable_ha_when_host_in_maintenance` 
error seems to be persistent in other PRs as well. Can I consider that the 
tests finished successfully?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370844139
 
 
   Please  do the honors and delete it :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package 
script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370843827
 
 
   @rafaelweingartner @DaanHoogland I did consider using 
`CloudstackVersion.java` but wanted to be less disruptive and keep 
`Version.java` alive, although it can easily be deleted in favor of 
CloudstackVersion because there are only a handful of places which use it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370840118
 
 
   @syed awesome, thanks!
   
   @pdion891 yes that's correct, it uses Debian 9 since 4.11. Would you say 
there will be a lot of difference - in terms of performance - between Debian 7 
and 9? In terms of functionality should be fine though.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370836797
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370836631
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370833080
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1761


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370819917
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1759


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-370819925
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1760


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[GitBox]

blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate 
variable replace bug
URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-370819910
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1757


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

[GitBox]

blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to 
each ACL Rule
URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-370819912
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1758


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DagSonsteboSB commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

DagSonsteboSB commented on a change in pull request #2476: CLOUDSTACK-10317: 
Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172553658
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   You are right @ustcweizhou - just tested this. Routing happens *after SNAT* 
hence translating all non-static NATed traffic to the source IP address on eth2 
works even if this means a SNAT rule against eth3, eth4, etc.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370818984
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370818736
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT 
rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172553142
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Thanks all for your discussion and testing, I'll test @ustcweizhou 's fix 
now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pdion891 commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

pdion891 commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370807868
 
 
   @rafaelweingartner  for the load test, I want to make sure that on a heavily 
loaded xenserver, will not affect data availability from xenstore at the 
creation of a VR. We are also running some benchmark on the VR between HVM and 
PV to see if moving to HVM will improve VR performance.
   
   @khos2ow,  in 4.11 systemvm is using Debian 9 correct ? if so, it's not what 
we are currently testing, we are currently focusing on the 4.10 template Debian 
7


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix 
SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172535132
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   @DagSonsteboSB yes, I think the outgoing IP for the vms without static nat 
should be the source nat IP, in your example 10.100.1.10
   
   In my point of view, the rules applied on ethernet other than eth2 (for 
example eth3) are not needed at all, however it is not harmful to have them. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DagSonsteboSB commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

DagSonsteboSB commented on a change in pull request #2476: CLOUDSTACK-10317: 
Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172526560
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Hi @ustcweizhou - in your scenario - does this not mean you end up SNATing 
on the wrong interface? So lets say you have eth2/VLAN10/10.100.1.10/24 and 
eth3/VLAN20/10.100.2.20/24. With your method that would SNAT to
   
   - A POSTROUTING -o eth3 -j SNAT --to-source 10.100.1.10
   
   So in other words the IP address would be right for the initial source NAT, 
but it would end up being translated on the wrong interface?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-370791841
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

borisstoyanov commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-370791497
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370791081
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

blueorangutan commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370791279
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370788754
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2477: Smaller systemvm images using sparse disks.

[GitBox]

rhtyd commented on a change in pull request #2477: Smaller systemvm images 
using sparse disks.
URL: https://github.com/apache/cloudstack/pull/2477#discussion_r172523141
 
 

 ##
 File path: tools/appliance/build.sh
 ##
 @@ -271,9 +271,9 @@ function xen_server_export() {
   local result=$?
   set -e
   if [ ${result} == 0 ]; then
-qemu-img convert -f qcow2 -O raw "dist/${appliance}" img.raw
-vhd-util convert -s 0 -t 1 -i img.raw -o stagefixed.vhd
-faketime '2010-01-01' vhd-util convert -s 1 -t 2 -i stagefixed.vhd -o 
"${appliance_build_name}-xen.vhd"
+cp "dist/${appliance}" "dist/${appliance}-xen"
+vhd-util convert -s 0 -t 1 -i "dist/${appliance}-xen" -o stagefixed.vhd
+faketime '2010-01-01' qemu-img convert -S 512 -O vpc -o subformat=dynamic 
stagefixed.vhd "${appliance_build_name}-xen.vhd"
 
 Review comment:
   @PaulAngus the output type `vpc` would create vhd for hyperv, such vhds may 
not boot on xenserver. Have you tested it? Does it fail if we use faketime with 
vhd-util?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error 
Message for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-370789719
 
 
   @borisstoyanov could you run tests here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2477: Smaller systemvm images using sparse disks.

[GitBox]

rhtyd commented on a change in pull request #2477: Smaller systemvm images 
using sparse disks.
URL: https://github.com/apache/cloudstack/pull/2477#discussion_r172523141
 
 

 ##
 File path: tools/appliance/build.sh
 ##
 @@ -271,9 +271,9 @@ function xen_server_export() {
   local result=$?
   set -e
   if [ ${result} == 0 ]; then
-qemu-img convert -f qcow2 -O raw "dist/${appliance}" img.raw
-vhd-util convert -s 0 -t 1 -i img.raw -o stagefixed.vhd
-faketime '2010-01-01' vhd-util convert -s 1 -t 2 -i stagefixed.vhd -o 
"${appliance_build_name}-xen.vhd"
+cp "dist/${appliance}" "dist/${appliance}-xen"
+vhd-util convert -s 0 -t 1 -i "dist/${appliance}-xen" -o stagefixed.vhd
+faketime '2010-01-01' qemu-img convert -S 512 -O vpc -o subformat=dynamic 
stagefixed.vhd "${appliance_build_name}-xen.vhd"
 
 Review comment:
   @PaulAngus the output type `vpc` would create vhd for hyperv, such vhds may 
not boot on xenserver. Have you tested it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2477: Smaller systemvm images using sparse disks.

[GitBox]

rhtyd commented on issue #2477: Smaller systemvm images using sparse disks.
URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-370789380
 
 
   LGTM, @PaulAngus can you change the PR's base branch to 4.11 and rebase your 
branch to 4.11? I tried to do that, but several other commits popped up.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370789130
 
 
   @Slair1 what issues are fixed, do we have marvin tests for them? If not I 
think it'll be good to add them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

[GitBox]

borisstoyanov commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA 
issues
URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-370788754
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network (#2448)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new c0b920f  CLOUDSTACK-10274: L2 network refused to be designed on VXLAN 
physical network (#2448)
c0b920f is described below

commit c0b920f740f5e5ba33f0e210caf4642edb2b7224
Author: Nicolas Vazquez 
AuthorDate: Tue Mar 6 10:56:47 2018 -0300

CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical 
network (#2448)

L2 network refused to be designed on VXLAN physical network. Add fix for 
vxlan issue.
Add condition for L2 networks which do not allow specifying vlan.
---
 .../src/com/cloud/network/guru/VxlanGuestNetworkGuru.java | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git 
a/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
 
b/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
index c065bd1..35f588f 100644
--- 
a/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
+++ 
b/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
@@ -55,11 +55,12 @@ public class VxlanGuestNetworkGuru extends GuestNetworkGuru 
{
 @Override
 protected boolean canHandle(NetworkOffering offering, final NetworkType 
networkType, final PhysicalNetwork physicalNetwork) {
 // This guru handles only Guest Isolated network that supports Source 
nat service
-if (networkType == NetworkType.Advanced && 
isMyTrafficType(offering.getTrafficType()) && offering.getGuestType() == 
Network.GuestType.Isolated &&
-isMyIsolationMethod(physicalNetwork)) {
+if (networkType == NetworkType.Advanced && 
isMyTrafficType(offering.getTrafficType()) &&
+(offering.getGuestType() == Network.GuestType.Isolated || 
offering.getGuestType() == Network.GuestType.L2) &&
+isMyIsolationMethod(physicalNetwork)) {
 return true;
 } else {
-s_logger.trace("We only take care of Guest networks of type   " + 
GuestType.Isolated + " in zone of type " + NetworkType.Advanced);
+s_logger.trace("We only take care of Guest networks of type   " + 
GuestType.Isolated + " or " + GuestType.L2 + " in zone of type " + 
NetworkType.Advanced);
 return false;
 }
 }
@@ -72,6 +73,10 @@ public class VxlanGuestNetworkGuru extends GuestNetworkGuru {
 return null;
 }
 
+if (offering.getGuestType() == GuestType.L2 && 
network.getBroadcastUri() != null) {
+String vxlan = 
BroadcastDomainType.getValue(network.getBroadcastUri());
+network.setBroadcastUri(BroadcastDomainType.Vxlan.toUri(vxlan));
+}
 network.setBroadcastDomainType(BroadcastDomainType.Vxlan);
 
 return network;

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd closed pull request #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

rhtyd closed pull request #2448: CLOUDSTACK-10274: L2 network refused to be 
designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
 
b/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
index c065bd191d0..35f588fd567 100644
--- 
a/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
+++ 
b/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
@@ -55,11 +55,12 @@ public VxlanGuestNetworkGuru() {
 @Override
 protected boolean canHandle(NetworkOffering offering, final NetworkType 
networkType, final PhysicalNetwork physicalNetwork) {
 // This guru handles only Guest Isolated network that supports Source 
nat service
-if (networkType == NetworkType.Advanced && 
isMyTrafficType(offering.getTrafficType()) && offering.getGuestType() == 
Network.GuestType.Isolated &&
-isMyIsolationMethod(physicalNetwork)) {
+if (networkType == NetworkType.Advanced && 
isMyTrafficType(offering.getTrafficType()) &&
+(offering.getGuestType() == Network.GuestType.Isolated || 
offering.getGuestType() == Network.GuestType.L2) &&
+isMyIsolationMethod(physicalNetwork)) {
 return true;
 } else {
-s_logger.trace("We only take care of Guest networks of type   " + 
GuestType.Isolated + " in zone of type " + NetworkType.Advanced);
+s_logger.trace("We only take care of Guest networks of type   " + 
GuestType.Isolated + " or " + GuestType.L2 + " in zone of type " + 
NetworkType.Advanced);
 return false;
 }
 }
@@ -72,6 +73,10 @@ public Network design(NetworkOffering offering, 
DeploymentPlan plan, Network use
 return null;
 }
 
+if (offering.getGuestType() == GuestType.L2 && 
network.getBroadcastUri() != null) {
+String vxlan = 
BroadcastDomainType.getValue(network.getBroadcastUri());
+network.setBroadcastUri(BroadcastDomainType.Vxlan.toUri(vxlan));
+}
 network.setBroadcastDomainType(BroadcastDomainType.Vxlan);
 
 return network;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

[GitBox]

blueorangutan commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to 
each ACL Rule
URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-370788514
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to each ACL Rule

[GitBox]

borisstoyanov commented on issue #2475: [CLOUDSTACK-10314] Add Text-Field to 
each ACL Rule
URL: https://github.com/apache/cloudstack/pull/2475#issuecomment-370788388
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[GitBox]

blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate 
variable replace bug
URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-370788209
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[GitBox]

borisstoyanov commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate 
variable replace bug
URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-370787915
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2408: asserted fixes for direct downloads

[GitBox]

borisstoyanov commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-370787458
 
 
   I'm just running a smoketest against Xen7.1, to confirm these issues are 
there as well and we should be good @nvazquez. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT 
rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172520624
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Thanks for confirming that we indeed need to set the device/interface in the 
rule @ustcweizhou. I think it makes sense to have the default packets routed to 
the default public snat ip. I'll let others comment on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2408: asserted fixes for direct downloads

[GitBox]

nvazquez commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-370785126
 
 
   @borisstoyanov are we ok with test results?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix 
SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172464559
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   @rhtyd what we are using are
   ```
   diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
   index e6aea26..d336e0a 100755
   --- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
   +++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
   @@ -400,7 +400,7 @@ class CsIP:
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" % 
self.address['public_ip']])
self.fw.append(["nat", "",
   -"-A POSTROUTING -o eth2 -j SNAT --to-source %s" 
% self.address['public_ip']])
   +"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.cl.get_eth2_ip())])
self.fw.append(["mangle", "",
"-A PREROUTING -i %s -m state --state NEW " % 
self.dev +
"-j CONNMARK --set-xmark %s/0x" % 
self.dnum])
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

[GitBox]

blueorangutan commented on issue #2477: Smaller systemvm images using sparse 
disks.
URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-370748123
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1756


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome (#2478)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 4412563  [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome 
(#2478)
4412563 is described below

commit 4412563f19ec8b808fe4c79e2baf658507a84873
Author: Rafael Weingärtner 
AuthorDate: Tue Mar 6 07:53:10 2018 -0300

[CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome (#2478)
---
 ui/scripts/vpc.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 9dc8323..a77c4d7 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -1325,7 +1325,7 @@
 
 if(items){
 items.sort(function(a, 
b) {
-return a.number >= 
b.number;
+return a.number - 
b.number;
 }).map(function(acl) {
 if 
(parseInt(acl.protocol)) { // protocol number
 
acl.protocolnumber = acl.protocol;

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner closed pull request #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

[GitBox]

rafaelweingartner closed pull request #2478: [CLOUDSTACK-10318] Bug on sorting 
ACL rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 9dc8323e7cd..a77c4d7b585 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -1325,7 +1325,7 @@
 
 if(items){
 items.sort(function(a, 
b) {
-return a.number >= 
b.number;
+return a.number - 
b.number;
 }).map(function(acl) {
 if 
(parseInt(acl.protocol)) { // protocol number
 
acl.protocolnumber = acl.protocol;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

[GitBox]

rafaelweingartner commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting 
ACL rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478#issuecomment-370742768
 
 
   What happens there is that Google Chrome only sorts blocks of 10 elements 
when the sort function return Boolean values. To fix it, we need to return a 
numeric value indicating if the first object is smaller (-), equal (0), or (+) 
greater than the second one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370741679
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

DaanHoogland commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370741614
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

[GitBox]

rafaelweingartner commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting 
ACL rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478#issuecomment-370741336
 
 
   Ok. there you go.
   Before:
   
![before](https://user-images.githubusercontent.com/4129005/37028279-9eb187ec-2112-11e8-8706-826678975dbe.png)
   
   After:
   
![after](https://user-images.githubusercontent.com/4129005/37028288-a343de4a-2112-11e8-848a-1223214b8d27.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2477: Smaller systemvm images using sparse disks.

[GitBox]

PaulAngus commented on issue #2477: Smaller systemvm images using sparse disks.
URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-370738123
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

[GitBox]

blueorangutan commented on issue #2477: Smaller systemvm images using sparse 
disks.
URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-370738200
 
 
   @PaulAngus a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-370736539
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-370736467
 
 
   @blueorangutan test centos7 xenserver-71


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-370735745
 
 
   @blueorangutan test centos7 xenserver-7


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-370735997
 
 
   @borisstoyanov unsupported parameters provided. Supported mgmt server os 
are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, 
vmware-65, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-370735745
 
 
   @blueorangutan test centos7 xenserver-7


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

[GitBox]

borisstoyanov commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL 
rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478#issuecomment-370735062
 
 
   Thanks @rafaelweingartner, please show us what was the issue and how the fix 
looks. Since we don't require any test results on this, let us have some 
justification as screenshots please. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370733584
 
 
   Regarding the version thing
   @khos2ow what about deleting that `version.java` class and using only the 
"CloudStackVersion"? It is quite confusing having these two objects around.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370732885
 
 
   @khos2ow I will test the package generation in both centoOs7 and CentOs6. I 
see that @DaanHoogland already started some other tests, so this should cover 
if the changes in version check
   
   @DaanHoogland I do think unit-test cases are appreciated. If @khos2ow is 
willing to create them, it would be great.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370729272
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1755


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

[GitBox]

rafaelweingartner commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting 
ACL rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478#issuecomment-370728784
 
 
   I am not adding/removing anything in the UI. I am neither changing/replacing 
anything visible. I am only changing a sort function that was not following the 
standards, and that is why it was not working in chrome.
   
   I mean, the screenshot will not prove much. It is a static image. I can 
provide you with two images, one with the problem and other with the problem 
solved if you really think they are important.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370723713
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

[GitBox]

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370723519
 
 
   @blueorangutan test
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370718248
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

DaanHoogland commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370717962
 
 
   I see enough people have discussed this, so I am going to trust them and 
some tests ;)
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

syed commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM 
on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-370716576
 
 
   Yes I?m sure, unless that logic changed in the time since I last looked
   On Fri, Feb 23, 2018 at 11:10 AM Khosrow Moossavi 
   wrote:
   
   > @syed  are you sure? I don't think with only
   > systemvm.iso, cloud-early-config will be updated with new code.
   >
   > ?
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

[GitBox]

borisstoyanov commented on issue #2478: [CLOUDSTACK-10318] Bug on sorting ACL 
rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478#issuecomment-370716105
 
 
   @rafaelweingartner can you upload some screenshots? Since it's a UI change I 
don't see point of running integration tests. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370715381
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370715104
 
 
   good point @rafaelweingartner! @khos2ow can you add unit tests for the class.
   Please both note that there is a 'new' class called CloudStackVersion as 
well. Not sure if we should consider that in this work.
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be 
designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-370699457
 
 
   @borisstoyanov Yes, I confirm this fixes my issues. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services