[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423718010 Trillian test result (tid-3041) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21491 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2859-t3041-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1096.69 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-423696024 Trillian test result (tid-3040) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32310 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2795-t3040-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 62 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 46.38 | test_multipleips_per_nic.py test_01_add_primary_storage_disabled_host | `Error` | 0.80 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.08 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.16 | test_primary_storage.py test_02_vpc_privategw_static_routes | `Failure` | 202.79 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1239.70 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.11 | test_snapshots.py test_01_secure_vm_migration | `Error` | 134.30 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 133.78 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 18.65 | test_vm_life_cycle.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.09 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.21 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.42 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Failure` | 654.87 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Failure` | 622.49 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423691854 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2859: agent: Fixes #2858 agent LB not working
rhtyd commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423691714 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423691520 Trillian test result (tid-3039) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36370 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2859-t3039-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 61 look OK, 6 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1133.96 | test_privategw_acl.py test_04_extract_template | `Failure` | 128.37 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_secure_vm_migration | `Error` | 133.67 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 132.63 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 133.65 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 132.67 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 15.61 | test_vm_life_cycle.py test_06_download_detached_volume | `Failure` | 137.53 | test_volumes.py test_02_redundant_VPC_default_routes | `Failure` | 170.20 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860#issuecomment-423689426 Trillian test result (tid-3038) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35517 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2860-t3038-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 61 look OK, 6 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1145.02 | test_privategw_acl.py test_04_extract_template | `Failure` | 128.23 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_03_secured_to_nonsecured_vm_migration | `Error` | 3579.23 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 3713.32 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 133.68 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 44.09 | test_vm_life_cycle.py test_06_download_detached_volume | `Failure` | 138.66 | test_volumes.py test_01_redundant_vpc_site2site_vpn | `Failure` | 333.77 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo edited a comment on issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1
resmo edited a comment on issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1 URL: https://github.com/apache/cloudstack/issues/2861#issuecomment-423685270 not a big issue, could be in 4.11.3 or even 4.12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1
resmo commented on issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1 URL: https://github.com/apache/cloudstack/issues/2861#issuecomment-423685270 not a big issue, could be in 4.11.3. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed issue #2854: VR is not reachable from VM on port 8080 to get password
rhtyd closed issue #2854: VR is not reachable from VM on port 8080 to get password URL: https://github.com/apache/cloudstack/issues/2854 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2854: VR is not reachable from VM on port 8080 to get password
rhtyd commented on issue #2854: VR is not reachable from VM on port 8080 to get password URL: https://github.com/apache/cloudstack/issues/2854#issuecomment-423666218 Fixed by #2855, closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2853: LDAP login java.lang.NullPointerException
rhtyd commented on issue #2853: LDAP login java.lang.NullPointerException URL: https://github.com/apache/cloudstack/issues/2853#issuecomment-423666109 /cc @DaanHoogland can you comment? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2856: VR dhcp domain-name-servers
rhtyd commented on issue #2856: VR dhcp domain-name-servers URL: https://github.com/apache/cloudstack/issues/2856#issuecomment-423666004 dnsmasq and dns related code has n't changed between 4.11.0 and 4.11.1. I'll try to reproduce. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1
rhtyd commented on issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1 URL: https://github.com/apache/cloudstack/issues/2861#issuecomment-423665777 Looks like a bug, if it was previously supported/working. However, not a major blocker, I'll try and fix it before RC2. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin
blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin URL: https://github.com/apache/cloudstack/pull/2849#issuecomment-423661444 Trillian test result (tid-3037) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28639 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2849-t3037-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 67 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 39.00 | test_multipleips_per_nic.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1162.14 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-documentation] branch master updated (f317411 -> 6c593b9)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from f317411 Merge pull request #5 from houthuis/destoyvm-also-removes-volumes add 354d496 Add run diagnostics to admin guide and new apis add e416035 Fix link to images and add more details on Extra Arg param new 6c593b9 Merge pull request #4 from dhlaluku/diagnostics-docs The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: source/_static/images/diagnostics-form.png | Bin 0 -> 14520 bytes source/_static/images/run-diagnostics-icon.png | Bin 0 -> 803 bytes source/adminguide/systemvm.rst | 41 + source/releasenotes/api-changes.rst| 3 +- 4 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 source/_static/images/diagnostics-form.png create mode 100644 source/_static/images/run-diagnostics-icon.png
[cloudstack-documentation] 01/01: Merge pull request #4 from dhlaluku/diagnostics-docs
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit 6c593b90498ba7f34acbc152026e1f0e7197e081 Merge: f317411 e416035 Author: Paul Angus AuthorDate: Fri Sep 21 19:40:31 2018 +0100 Merge pull request #4 from dhlaluku/diagnostics-docs Add run diagnostics to admin guide and new apis source/_static/images/diagnostics-form.png | Bin 0 -> 14520 bytes source/_static/images/run-diagnostics-icon.png | Bin 0 -> 803 bytes source/adminguide/systemvm.rst | 41 + source/releasenotes/api-changes.rst| 3 +- 4 files changed, 43 insertions(+), 1 deletion(-)
[cloudstack-documentation] branch master updated (e986df4 -> f317411)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from e986df4 Merge pull request #7 from nvazquez/ignorebuild add 3b5665a documentation for destroyVM also removes volumes add bce3c73 rewording for clarity new f317411 Merge pull request #5 from houthuis/destoyvm-also-removes-volumes The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: source/adminguide/virtual_machines.rst | 2 ++ source/releasenotes/api-changes.rst| 8 2 files changed, 10 insertions(+)
[cloudstack-documentation] 01/01: Merge pull request #5 from houthuis/destoyvm-also-removes-volumes
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit f317411bebf45d31bc09ac500345d5d5eec2a34a Merge: e986df4 bce3c73 Author: Paul Angus AuthorDate: Fri Sep 21 19:39:07 2018 +0100 Merge pull request #5 from houthuis/destoyvm-also-removes-volumes documentation for destroyVM also removes volumes source/adminguide/virtual_machines.rst | 2 ++ source/releasenotes/api-changes.rst| 8 2 files changed, 10 insertions(+)
[GitHub] blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL
blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-423631627 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2320 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL
blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-423622065 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL
rafaelweingartner commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-423621817 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-423618461 @rhtyd all checks have passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes
blueorangutan commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-423576289 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2319 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes
blueorangutan commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-423564220 @houthuis a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis commented on issue #2793: Destroyvm also removes volumes
houthuis commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-423563685 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis commented on a change in pull request #2793: Destroyvm also removes volumes
houthuis commented on a change in pull request #2793: Destroyvm also removes
volumes
URL: https://github.com/apache/cloudstack/pull/2793#discussion_r219527693
##
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##
@@ -2751,27 +2749,55 @@ public UserVm destroyVm(DestroyVMCmd cmd) throws
ResourceUnavailableException, C
// check if VM exists
UserVmVO vm = _vmDao.findById(vmId);
-if (vm == null) {
+if (vm == null || vm.getRemoved() != null) {
throw new InvalidParameterValueException("unable to find a virtual
machine with id " + vmId);
}
+if (vm.getState() == State.Destroyed || vm.getState() ==
State.Expunging) {
+s_logger.trace("Vm id=" + vmId + " is already destroyed");
+return vm;
+}
+
// check if there are active volume snapshots tasks
s_logger.debug("Checking if there are any ongoing snapshots on the
ROOT volumes associated with VM with ID " + vmId);
if (checkStatusOfVolumeSnapshots(vmId, Volume.Type.ROOT)) {
throw new CloudRuntimeException("There is/are unbacked up
snapshot(s) on ROOT volume, vm destroy is not permitted, please try again
later.");
}
s_logger.debug("Found no ongoing snapshots on volume of type ROOT, for
the vm with id " + vmId);
+List volumes = getVolumesFromIds(cmd);
+
+checkForUnattachedVolumes(vmId, volumes);
+validateVolumes(volumes);
+detachVolumesFromVm(volumes);
Review comment:
@wido this change has been made. please give the PR another review
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houthuis closed pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT
houthuis closed pull request #2382: CLOUDSTACK-4045 IP address acquired with
associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
index ec7adfd1057..4c4a9ec7369 100644
--- a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
+++ b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
@@ -1378,16 +1378,7 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
-NetworkOffering offering =
_networkOfferingDao.findById(network.getNetworkOfferingId());
-boolean sharedSourceNat = offering.getSharedSourceNat();
-boolean isSourceNat = false;
-if (!sharedSourceNat) {
-if (getExistingSourceNatInNetwork(owner.getId(), networkId) ==
null) {
-if (network.getGuestType() == GuestType.Isolated &&
network.getVpcId() == null && !ipToAssoc.isPortable()) {
-isSourceNat = true;
-}
-}
-}
+boolean isSourceNat = isSourceNatAvailableForNetwork(owner, ipToAssoc,
network);
s_logger.debug("Associating ip " + ipToAssoc + " to network " +
network);
@@ -1425,6 +1416,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
+protected boolean isSourceNatAvailableForNetwork(Account owner,
IPAddressVO ipToAssoc, Network network) {
+NetworkOffering offering =
_networkOfferingDao.findById(network.getNetworkOfferingId());
+boolean sharedSourceNat = offering.getSharedSourceNat();
+boolean isSourceNat = false;
+if (!sharedSourceNat) {
+if (getExistingSourceNatInNetwork(owner.getId(), network.getId())
== null) {
+if (network.getGuestType() == GuestType.Isolated &&
network.getVpcId() == null && !ipToAssoc.isPortable()) {
+if (network.getState() == Network.State.Allocated) {
+//prevent associating an ip address to an allocated
(unimplemented network).
+//it will cause the ip to become source nat, and it
can't be disassociated later on.
+throw new InvalidParameterValueException("Network is
in allocated state, implement network first before acquiring an IP address");
+}
+isSourceNat = true;
+}
+}
+}
+return isSourceNat;
+}
+
protected boolean isSharedNetworkOfferingWithServices(long
networkOfferingId) {
NetworkOfferingVO networkOffering =
_networkOfferingDao.findById(networkOfferingId);
if ((networkOffering.getGuestType() == Network.GuestType.Shared)
diff --git a/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
b/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
index 2bf989c7c1f..64e8c3419e1 100644
--- a/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
+++ b/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
@@ -17,7 +17,10 @@
package com.cloud.network;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
import static org.mockito.Matchers.anyLong;
+import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@@ -32,12 +35,20 @@
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
+import org.mockito.Spy;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceUnavailableException;
import com.cloud.network.Network.Service;
import com.cloud.network.dao.IPAddressDao;
import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.dao.NetworkDao;
+import com.cloud.network.dao.NetworkVO;
import com.cloud.network.rules.StaticNat;
import com.cloud.network.rules.StaticNatImpl;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.user.AccountVO;
import com.cloud.utils.net.Ip;
public class IpAddressManagerTest {
@@ -45,15 +56,41 @@
@Mock
IPAddressDao _ipAddrDao;
+@Mock
+NetworkDao _networkDao;
+
+@Mock
+NetworkOfferingDao _networkOfferingDao;
+
+@Mock
+NetworkModel _networkModel;
+
+@Spy
@InjectMocks
IpAddressManagerImpl _ipManager;
@InjectMocks
NetworkModelImpl networkModel = Mockito.spy(new NetworkModelImpl());
+IPAddressVO ipAddressVO;
+
+AccountVO account;
+
[GitHub] houthuis opened a new pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT
houthuis opened a new pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382 added a check for network state when determining whether a new IP should be source NAT. this prevents associated IP's to be marked as source NAT when the network is in allocated state, causing disassociateIpAddress to fail later Code will now throw a InvalidParameterValueException in the above scenario. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fmaximus commented on issue #2525: details not in listVirtualMachines response
fmaximus commented on issue #2525: details not in listVirtualMachines response URL: https://github.com/apache/cloudstack/issues/2525#issuecomment-423553238 there is a flag: details=true This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset
DaanHoogland commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset URL: https://github.com/apache/cloudstack/pull/2743#issuecomment-423540429 sorry @PaulAngus my bad. I deducted wrongly from the red cross in combination with your text not being posed as a question. @smeetsr can you look into @PaulAngus ' report, tnx? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-423540137 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2795: kvm: Properly report available memory to Management Server
DaanHoogland commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-423539645 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo opened a new issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1
resmo opened a new issue #2861: SSVM NFS4 does not support minor version setting e.g. 4.1 URL: https://github.com/apache/cloudstack/issues/2861 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ SecondaryStorage VM ~~~ # CLOUDSTACK VERSION ~~~ 4.11.1 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY Debian 9 system VM default NFS version is 4.2. If your NFS server does not support 4.2, the mount may fail (is does in our case). There is a global config `secstorage.nfs.version` to specify the version, but it does only support int values. If you set it to `4` the NFS4 version used is `4.0`. There is currently no way to set a minor version. e.g. `4.1`. :warning: Note that version 3 has no "minor versions". Probably worth considering is to add new configuration field for nfs4 minor versions. e.g. `secstorage.nfs4.minorversion` defaulted to null. NFS4 version shoulld be a combination of `secstorage.nfs.version + '.' + secstorage.nfs4.minorversion`. NFS3 only `secstorage.nfs.version` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] PaulAngus commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset
PaulAngus commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset URL: https://github.com/apache/cloudstack/pull/2743#issuecomment-423512683 I thought that I had requested changes @DaanHoogland :( where does it say that i disapproved? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-423512191 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2318 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
rhtyd commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860#issuecomment-423511636 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423511830 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860#issuecomment-423511822 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2859: agent: Fixes #2858 agent LB not working
rhtyd commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423511548 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin
blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin URL: https://github.com/apache/cloudstack/pull/2849#issuecomment-423507158 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2849: Remove deprecated buildw and wix plugin
DaanHoogland commented on issue #2849: Remove deprecated buildw and wix plugin URL: https://github.com/apache/cloudstack/pull/2849#issuecomment-423506970 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset
DaanHoogland commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset URL: https://github.com/apache/cloudstack/pull/2743#issuecomment-423506302 you disapproved this @PaulAngus , so there is a reason this must not be merged? or did you mean to request for changes? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-423504360 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860#issuecomment-423504237 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2316 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd removed a comment on issue #2795: kvm: Properly report available memory to Management Server
rhtyd removed a comment on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-422345266 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423504238 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2315 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan removed a comment on issue #2795: kvm: Properly report available memory to Management Server
blueorangutan removed a comment on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-422345483 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2795: kvm: Properly report available memory to Management Server
DaanHoogland commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-423504190 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan removed a comment on issue #2795: kvm: Properly report available memory to Management Server
blueorangutan removed a comment on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-422358663 Packaging result: ✔centos6 ✖centos7 ✖debian. JID-2305 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2856: VR dhcp dns server
izenk edited a comment on issue #2856: VR dhcp dns server URL: https://github.com/apache/cloudstack/issues/2856#issuecomment-423237943 Seems, I found the reason of status: REFUSED from dnsmasq Because dns server has public ip from the same network as VR public ip, dnsmasq ignores this dns ~~~ ignoring nameserver x.x.x.x - local interface ~~~ if I add to dnsmasq config second dns server, for example 8.8.8.8 - dns resolv for guest vm works This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk removed a comment on issue #2856: VR dhcp dns server
izenk removed a comment on issue #2856: VR dhcp dns server URL: https://github.com/apache/cloudstack/issues/2856#issuecomment-423237943 Seems, I found the reason of status: REFUSED from dnsmasq Because dns server has public ip from the same network as VR public ip, dnsmasq ignores this dns ~~~ ignoring nameserver x.x.x.x - local interface ~~~ if I add to dnsmasq config second dns server, for example 8.8.8.8 - dns resolv for guest vm works This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
DaanHoogland commented on a change in pull request #2860: packaging: Fixes
#2857 don't overwrite agent logrotate config
URL: https://github.com/apache/cloudstack/pull/2860#discussion_r219467081
##
File path: packaging/centos63/cloud.spec
##
@@ -574,7 +574,7 @@ pip install --upgrade
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
%attr(0755,root,root) %{_bindir}/%{name}-ssh
%attr(0755,root,root) %{_sysconfdir}/init.d/%{name}-agent
%attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}-agent-profile.sh
-%attr(0644,root,root) %{_sysconfdir}/logrotate.d/%{name}-agent
+%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}-agent
Review comment:
yes, I mean the rights those get; will they be (0644, root, root)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #2847: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…
DaanHoogland commented on issue #2847: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to… URL: https://github.com/apache/cloudstack/pull/2847#issuecomment-423501501 @BruceKuiLiu I agree with @rafaelweingartner as I noted in your prior PR, please have some patience with us, we are not the fasted mergers in the world of github. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
rhtyd commented on a change in pull request #2860: packaging: Fixes #2857 don't
overwrite agent logrotate config
URL: https://github.com/apache/cloudstack/pull/2860#discussion_r219465574
##
File path: packaging/centos63/cloud.spec
##
@@ -574,7 +574,7 @@ pip install --upgrade
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
%attr(0755,root,root) %{_bindir}/%{name}-ssh
%attr(0755,root,root) %{_sysconfdir}/init.d/%{name}-agent
%attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}-agent-profile.sh
-%attr(0644,root,root) %{_sysconfdir}/logrotate.d/%{name}-agent
+%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}-agent
Review comment:
on initial install, the new file will be created, then it won't be
touched/changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] borisstoyanov commented on issue #2859: agent: Fixes #2858 agent LB not working
borisstoyanov commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423500250 Thanks for this fix @rhtyd, just tested it manually and it works fine. Let's wait for the smoketests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
DaanHoogland commented on a change in pull request #2860: packaging: Fixes
#2857 don't overwrite agent logrotate config
URL: https://github.com/apache/cloudstack/pull/2860#discussion_r219464475
##
File path: packaging/centos63/cloud.spec
##
@@ -574,7 +574,7 @@ pip install --upgrade
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
%attr(0755,root,root) %{_bindir}/%{name}-ssh
%attr(0755,root,root) %{_sysconfdir}/init.d/%{name}-agent
%attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}-agent-profile.sh
-%attr(0644,root,root) %{_sysconfdir}/logrotate.d/%{name}-agent
+%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}-agent
Review comment:
what happens on the initial install, @rhtyd ? did you check?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
blueorangutan commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860#issuecomment-423497526 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423497544 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2857: Change logrotate to config in packaging
rhtyd commented on issue #2857: Change logrotate to config in packaging URL: https://github.com/apache/cloudstack/issues/2857#issuecomment-423497556 @glennwagner I've fixed it here: https://github.com/apache/cloudstack/pull/2860 /cc @PaulAngus @mlsorensen This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
rhtyd commented on issue #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860#issuecomment-423497465 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2859: agent: Fixes #2858 agent LB not working
borisstoyanov commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423497332 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2860: packaging: Fixes #2857 don't overwrite agent logrotate config
rhtyd opened a new pull request #2860: packaging: Fixes #2857 don't overwrite agent logrotate config URL: https://github.com/apache/cloudstack/pull/2860 This makes the agent logrotate config to `noreplace` so on upgrade any changes to the file are not lost. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs Fixes #2857 ## Checklist: - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd edited a comment on issue #2859: agent: Fixes #2858 agent LB not working
rhtyd edited a comment on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423496079 Fixes #2858 /cc @borisstoyanov This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2859: agent: Fixes #2858 agent LB not working
rhtyd commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423496079 Fixes #2858 /cc @borisstoyanov @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working
blueorangutan commented on issue #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859#issuecomment-423496009 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2859: agent: Fixes #2858 agent LB not working
rhtyd opened a new pull request #2859: agent: Fixes #2858 agent LB not working URL: https://github.com/apache/cloudstack/pull/2859 This fixes the issue that on reconnection, agent LB feature will fail and only the first ms-host will be tried reconnection again and again. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Checklist: - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov opened a new issue #2858: fallback of agent balancing management connection is not working when primary management goes down
borisstoyanov opened a new issue #2858: fallback of agent balancing management connection is not working when primary management goes down URL: https://github.com/apache/cloudstack/issues/2858 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ agent ~~~ # CLOUDSTACK VERSION ~~~ 4.11 ~~~ # OS / ENVIRONMENT CentOS6/7 # SUMMARY When having a list of management servers (ABC), management A is the preferred one. When A goes down, cloudstack-agent will not move to B, but will stay and try reconnecting to A. # STEPS TO REPRODUCE ~~~ Stop Management A and observe the agent logs ~~~ # EXPECTED RESULTS ~~~ Should move to B ~~~ # ACTUAL RESULTS ~~~ Tries to reconnect to A ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] glennwagner opened a new issue #2857: Change logrotate to config in packaging
glennwagner opened a new issue #2857: Change logrotate to config in packaging URL: https://github.com/apache/cloudstack/issues/2857 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ RPM, Packaging, install ~~~ # CLOUDSTACK VERSION ~~~ 4.11.1.0 ~~~ # CONFIGURATION # OS / ENVIRONMENT CentOS # SUMMARY Consider marking logrotate script as config in the RPM packaging https://github.com/apache/cloudstack/blob/master/packaging/centos7/cloud.spec#L519 # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT
houthuis commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-423482258 > can you fix the conflict @houthuis @rohit done, awaiting test results This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin
blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin URL: https://github.com/apache/cloudstack/pull/2849#issuecomment-423479853 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2314 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2660: Macaddresses
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-423470837 I think it can be merged, @rohit, though further work on macaddresses will be needed it is out of scope here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin
blueorangutan commented on issue #2849: Remove deprecated buildw and wix plugin URL: https://github.com/apache/cloudstack/pull/2849#issuecomment-423470615 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2849: Remove deprecated buildw and wix plugin
rhtyd commented on issue #2849: Remove deprecated buildw and wix plugin URL: https://github.com/apache/cloudstack/pull/2849#issuecomment-423470518 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (fcc87d9 -> 9c14059)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from fcc87d9 Merge branch '4.11' add 8da2513 api: Make networkofferingid required in migrateNetwork (#2852) add 70dbfa7 systemvm: export $TYPE before patching ssvm/cpvm (#2855) new 9c14059 Merge remote-tracking branch 'origin/4.11' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../api/command/admin/network/MigrateNetworkCmd.java | 5 ++--- .../main/java/com/cloud/upgrade/dao/Upgrade41110to41120.java | 12 ++-- systemvm/debian/opt/cloud/bin/setup/cloud-early-config | 6 +- systemvm/debian/opt/cloud/bin/setup/postinit.sh | 2 +- .../systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +- 5 files changed, 15 insertions(+), 12 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9c14059d9eb5602a1a68bb02d706dbe2d4e82bb9 Merge: fcc87d9 70dbfa7 Author: Rohit Yadav AuthorDate: Fri Sep 21 14:21:28 2018 +0530 Merge remote-tracking branch 'origin/4.11' .../api/command/admin/network/MigrateNetworkCmd.java | 5 ++--- .../main/java/com/cloud/upgrade/dao/Upgrade41110to41120.java | 12 ++-- systemvm/debian/opt/cloud/bin/setup/cloud-early-config | 6 +- systemvm/debian/opt/cloud/bin/setup/postinit.sh | 2 +- .../systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +- 5 files changed, 15 insertions(+), 12 deletions(-)
[GitHub] rhtyd commented on issue #2855: systemvm: export $TYPE before patching ssvm/cpvm
rhtyd commented on issue #2855: systemvm: export $TYPE before patching ssvm/cpvm URL: https://github.com/apache/cloudstack/pull/2855#issuecomment-423462448 FYI - the 4.11.2 systemvmtemplate for testing are here: http://packages.shapeblue.com/testing/systemvm/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated (8da2513 -> 70dbfa7)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8da2513 api: Make networkofferingid required in migrateNetwork (#2852) add 70dbfa7 systemvm: export $TYPE before patching ssvm/cpvm (#2855) No new revisions were added by this update. Summary of changes: .../src/com/cloud/upgrade/dao/Upgrade41110to41120.java | 12 ++-- systemvm/debian/opt/cloud/bin/setup/cloud-early-config | 6 +- systemvm/debian/opt/cloud/bin/setup/postinit.sh | 2 +- .../systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +- 4 files changed, 13 insertions(+), 9 deletions(-)
[GitHub] rhtyd closed pull request #2855: systemvm: export $TYPE before patching ssvm/cpvm
rhtyd closed pull request #2855: systemvm: export $TYPE before patching
ssvm/cpvm
URL: https://github.com/apache/cloudstack/pull/2855
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41110to41120.java
b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41110to41120.java
index a35be45a8d9..d4bdc13b082 100644
--- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41110to41120.java
+++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41110to41120.java
@@ -135,12 +135,12 @@ private void updateSystemVmTemplates(final Connection
conn) {
final Map newTemplateChecksum = new
HashMap() {
{
-put(Hypervisor.HypervisorType.KVM,
"f44242570ae4a0b16c4c2eb2cb71fe45");
-put(Hypervisor.HypervisorType.XenServer,
"afcc31ab9f7635885cd83600eafbbe7f");
-put(Hypervisor.HypervisorType.VMware,
"54449e31530f14af930c80a3155a308f");
-put(Hypervisor.HypervisorType.Hyperv,
"7785df30fdbbacdead5acbfc15ae2c98");
-put(Hypervisor.HypervisorType.LXC,
"f44242570ae4a0b16c4c2eb2cb71fe45");
-put(Hypervisor.HypervisorType.Ovm3,
"81a6cd8d07fad910824f040f73ce03e3");
+put(Hypervisor.HypervisorType.KVM,
"6d12cc764cd7d64112d8c35d70923eb1");
+put(Hypervisor.HypervisorType.XenServer,
"6e8b3ae84ca8145736d1d7d3f7546e65");
+put(Hypervisor.HypervisorType.VMware,
"e981f8cb951688efd93481913198c9cc");
+put(Hypervisor.HypervisorType.Hyperv,
"e9032635ffba021371780307162551b9");
+put(Hypervisor.HypervisorType.LXC,
"6d12cc764cd7d64112d8c35d70923eb1");
+put(Hypervisor.HypervisorType.Ovm3,
"c4a91f8e52e4531a1c2a9a17c530d5fe");
}
};
diff --git a/systemvm/debian/opt/cloud/bin/setup/cloud-early-config
b/systemvm/debian/opt/cloud/bin/setup/cloud-early-config
index 2c277ae78ed..8ba7701de8a 100755
--- a/systemvm/debian/opt/cloud/bin/setup/cloud-early-config
+++ b/systemvm/debian/opt/cloud/bin/setup/cloud-early-config
@@ -150,6 +150,10 @@ get_boot_params() {
esac
}
+get_systemvm_type() {
+ export TYPE=$(grep -Po 'type=\K[a-zA-Z]*' $CMDLINE)
+}
+
patch() {
local PATCH_MOUNT=/media/cdrom
local patchfile=$PATCH_MOUNT/cloud-scripts.tgz
@@ -216,11 +220,11 @@ start() {
config_guest
get_boot_params
+ get_systemvm_type
patch
sync
sysctl -p
- export TYPE=$(grep -Po 'type=\K[a-zA-Z]*' $CMDLINE)
log_it "Configuring systemvm type=$TYPE"
if [ -f "/opt/cloud/bin/setup/$TYPE.sh" ]; then
diff --git a/systemvm/debian/opt/cloud/bin/setup/postinit.sh
b/systemvm/debian/opt/cloud/bin/setup/postinit.sh
index 5132d5e85d4..f0ae5e89f0c 100755
--- a/systemvm/debian/opt/cloud/bin/setup/postinit.sh
+++ b/systemvm/debian/opt/cloud/bin/setup/postinit.sh
@@ -21,7 +21,7 @@
# Eject cdrom if any
eject || true
-TYPE=$(grep -Po 'type=\K[a-zA-Z]*' $CMDLINE)
+TYPE=$(grep -Po 'type=\K[a-zA-Z]*' /var/cache/cloud/cmdline)
if [ "$TYPE" == "router" ] || [ "$TYPE" == "vpcrouter" ] || [ "$TYPE" ==
"dhcpsrvr" ]
then
if [ -x /opt/cloud/bin/update_config.py ]
diff --git
a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
index 7af9212e343..48695014bd9 100644
--- a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
+++ b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
@@ -19,7 +19,7 @@
set -e
set -x
-CLOUDSTACK_RELEASE=4.11.1
+CLOUDSTACK_RELEASE=4.11.2
function configure_apache2() {
# Enable ssl, rewrite and auth
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2855: systemvm: export $TYPE before patching ssvm/cpvm
rhtyd commented on issue #2855: systemvm: export $TYPE before patching ssvm/cpvm URL: https://github.com/apache/cloudstack/pull/2855#issuecomment-423461985 test LGTM. Will merge based on reviews and testing. This will make into rc2. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland removed a comment on issue #2848: WIP: Vmware offline migration
DaanHoogland removed a comment on issue #2848: WIP: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-423435495 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2848: WIP: Vmware offline migration
DaanHoogland commented on issue #2848: WIP: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-423457195 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2848: WIP: Vmware offline migration
DaanHoogland commented on issue #2848: WIP: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-423435495 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
