[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-434180994
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-434180851
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-434180214
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2392


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-434175624
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-434175527
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges

[GitBox]

blueorangutan commented on issue #2980: [4.11] Fix set initial reservation on 
public IP ranges
URL: https://github.com/apache/cloudstack/pull/2980#issuecomment-434170694
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges

[GitBox]

blueorangutan commented on issue #2980: [4.11] Fix set initial reservation on 
public IP ranges
URL: https://github.com/apache/cloudstack/pull/2980#issuecomment-434170547
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2391


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges

[GitBox]

rhtyd commented on issue #2980: [4.11] Fix set initial reservation on public IP 
ranges
URL: https://github.com/apache/cloudstack/pull/2980#issuecomment-434170646
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs

[GitBox]

rhtyd closed issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate 
VRs
URL: https://github.com/apache/cloudstack/issues/2880
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs

[GitBox]

rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in 
duplicate VRs
URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-434166602
 
 
   I'll close this issue based on confirmation from @resmo, the poweroff PR has 
been merged as well. Please reopen if you can reproduce this issue again in 
future. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

[GitBox]

rhtyd commented on issue #2930: HA for Management Server - roundrobin: 
Certificate ownership
URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-434166435
 
 
   Given this is a setup /env issue, if the advise process fixes your issue and 
you're unable to reproduce the errors please close this issue @DennisKonrad


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges

[GitBox]

blueorangutan commented on issue #2980: [4.11] Fix set initial reservation on 
public IP ranges
URL: https://github.com/apache/cloudstack/pull/2980#issuecomment-434166136
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges

[GitBox]

rhtyd commented on issue #2980: [4.11] Fix set initial reservation on public IP 
ranges
URL: https://github.com/apache/cloudstack/pull/2980#issuecomment-434166014
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] svenvogel commented on issue #2981: Fix set initial reservation on public IP ranges

[GitBox]

svenvogel commented on issue #2981: Fix set initial reservation on public IP 
ranges
URL: https://github.com/apache/cloudstack/pull/2981#issuecomment-434119305
 
 
   Hi @nvazquez wow great.. i will test fastly and done back greets Sven


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2983: KVM live storage migration intra cluster from NFS source and destination

[GitBox]

nvazquez opened a new pull request #2983: KVM live storage migration intra 
cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983
 
 
   ## Description
   Live storage migration on KVM under these conditions:
   - From source and destination hosts within the same cluster
   - From NFS primary storage to NFS cluster-wide primary storage
   - Source NFS and destination NFS storage mounted on hosts
   
   In order to enable this functionality, database should be updated in order 
to enable live storage capacibilty for KVM, if previous conditions are met. 
This is due to existing conflicts between qemu and libvirt versions. This has 
been tested on CentOS 6 hosts.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   Tested on environment having 2 KVM CentOS 6 hosts.
   
   Note: CentOS 7 hosts report an issue around qemu version:
   `org.libvirt.LibvirtException: internal error: unable to execute QEMU 
command 'migrate': this feature or command is not currently supported`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bdonnahue commented on issue #2583: CPU cores per socket setting not functional

[GitBox]

bdonnahue commented on issue #2583: CPU cores per socket setting not functional
URL: https://github.com/apache/cloudstack/issues/2583#issuecomment-434037326
 
 
   Sounds good, is there a scheduled release date @rhtyd ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Overv opened a new issue #2982: Why are passwords encrypted with the SSH public key?

[GitBox]

Overv opened a new issue #2982: Why are passwords encrypted with the SSH public 
key?
URL: https://github.com/apache/cloudstack/issues/2982
 
 
   This function is used to encrypt and store the VM password, but why is this 
done with the SSH public key?
   
   
https://github.com/apache/cloudstack/blob/3101612ad148d8ad77a931ffec692a9b97757d32/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L6360
   
   What is the purpose of this storage and how is it supposed to ever be 
decrypted?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andrijapanic commented on issue #2820: template downloading fails

[GitBox]

andrijapanic commented on issue #2820: template downloading fails
URL: https://github.com/apache/cloudstack/issues/2820#issuecomment-433974616
 
 
   Issue still present in latest 4.11.2 RC3 for RAW - stream closed message.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs

[GitBox]

rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in 
duplicate VRs
URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-433966732
 
 
   Thanks for sharing @resmo, as @PaulAngus replied the power off issue during 
rolling restart has been fixed now as well. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: docker: add compose file for database (#2898)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 3101612  docker: add compose file for database (#2898)
3101612 is described below

commit 3101612ad148d8ad77a931ffec692a9b97757d32
Author: Marc-Aurèle Brothier 
AuthorDate: Mon Oct 29 16:55:48 2018 +0100

docker: add compose file for database (#2898)

A docker-compose file to setup quickly the database for CS. This helps 
during local development and remove the need to install a local MariaDB/MySQL.
---
 tools/docker/docker-compose.yml   | 35 +++
 tools/docker/mariadb-docker/cloudstack-docker.cnf | 24 
 2 files changed, 59 insertions(+)

diff --git a/tools/docker/docker-compose.yml b/tools/docker/docker-compose.yml
new file mode 100644
index 000..86934f6
--- /dev/null
+++ b/tools/docker/docker-compose.yml
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+
+#   http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '2'
+services:
+  db:
+image: mariadb:10.0
+volumes:
+  - ./mariadb-docker:/etc/mysql/conf.d
+  - db:/var/lib/mysql
+environment:
+  MYSQL_DATABASE: cloud
+#  MYSQL_ROOT_PASSWORD: root
+  MYSQL_ALLOW_EMPTY_PASSWORD: 1
+  MYSQL_USER: cloud
+  MYSQL_PASSWORD: cloud
+ports:
+  - "3306:3306"
+
+volumes:
+  db:
diff --git a/tools/docker/mariadb-docker/cloudstack-docker.cnf 
b/tools/docker/mariadb-docker/cloudstack-docker.cnf
new file mode 100644
index 000..771aa86
--- /dev/null
+++ b/tools/docker/mariadb-docker/cloudstack-docker.cnf
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+
+#   http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[mysqld]
+server-id=master-dev
+innodb_rollback_on_timeout=1
+innodb_lock_wait_timeout=600
+max_connections=1000
+log-bin=mysql-bin
+binlog-format = 'ROW'

[GitHub] rhtyd closed pull request #2898: docker: add compose file for database

[GitBox]

rhtyd closed pull request #2898: docker: add compose file for database
URL: https://github.com/apache/cloudstack/pull/2898
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/docker/docker-compose.yml b/tools/docker/docker-compose.yml
new file mode 100644
index 000..86934f6407f
--- /dev/null
+++ b/tools/docker/docker-compose.yml
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+
+#   http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '2'
+services:
+  db:
+image: mariadb:10.0
+volumes:
+  - ./mariadb-docker:/etc/mysql/conf.d
+  - db:/var/lib/mysql
+environment:
+  MYSQL_DATABASE: cloud
+#  MYSQL_ROOT_PASSWORD: root
+  MYSQL_ALLOW_EMPTY_PASSWORD: 1
+  MYSQL_USER: cloud
+  MYSQL_PASSWORD: cloud
+ports:
+  - "3306:3306"
+
+volumes:
+  db:
diff --git a/tools/docker/mariadb-docker/cloudstack-docker.cnf 
b/tools/docker/mariadb-docker/cloudstack-docker.cnf
new file mode 100644
index 000..771aa862044
--- /dev/null
+++ b/tools/docker/mariadb-docker/cloudstack-docker.cnf
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+
+#   http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[mysqld]
+server-id=master-dev
+innodb_rollback_on_timeout=1
+innodb_lock_wait_timeout=600
+max_connections=1000
+log-bin=mysql-bin
+binlog-format = 'ROW'


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2979: vr: defer was broken in VR because of json name change

[GitBox]

rhtyd commented on issue #2979: vr: defer was broken in VR because of json name 
change
URL: https://github.com/apache/cloudstack/pull/2979#issuecomment-433965407
 
 
   Alright, no need of a new PR. In some cases the path may be absolute, but I 
think we've moved to relative paths now in most cases 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2981: Fix set initial reservation on public IP ranges

[GitBox]

nvazquez commented on issue #2981: Fix set initial reservation on public IP 
ranges
URL: https://github.com/apache/cloudstack/pull/2981#issuecomment-433950581
 
 
   Hi @svenvogel can you please test it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2981: Fix set initial reservation on public IP ranges

[GitBox]

nvazquez opened a new pull request #2981: Fix set initial reservation on public 
IP ranges
URL: https://github.com/apache/cloudstack/pull/2981
 
 
   ## Description
   Fix initial reservation on public IP range addition. Also, if the range is 
dedicated for system VMs do not allow dedicating it to any account
   
   Fixes: #2929 
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   - Set reservation to a domain, add range. Verify domain is set to the domain.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2980: Iprangedomainuifix

[GitBox]

nvazquez opened a new pull request #2980: Iprangedomainuifix
URL: https://github.com/apache/cloudstack/pull/2980
 
 
   ## Description
   Fix initial reservation on public IP range addition. Also, if the range is 
dedicated for system VMs do not allow dedicating it to any account
   
   Fixes: #2929 
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   - Set reservation to a domain, add range. Verify domain is set to the domain.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs

[GitBox]

PaulAngus commented on issue #2880: [4.11.2]: rolling upgrade of VR results in 
duplicate VRs
URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-433937889
 
 
   @resmo i believe Rohit corrected that here: 
https://github.com/apache/cloudstack/pull/2926
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2979: vr: defer was broken in VR because of json name change

[GitBox]

wido commented on issue #2979: vr: defer was broken in VR because of json name 
change
URL: https://github.com/apache/cloudstack/pull/2979#issuecomment-433932184
 
 
   I doubt that *startswith* is the best method. We are now just providing a 
filename, but if somebody suddenly decides to change this to a absolute path 
that breaks again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] RPDiep commented on issue #2979: vr: defer was broken in VR because of json name change

[GitBox]

RPDiep commented on issue #2979: vr: defer was broken in VR because of json 
name change
URL: https://github.com/apache/cloudstack/pull/2979#issuecomment-433924280
 
 
   No problem on the new PR.
   I just read that @rhtyd  preferred that the line would use `startswith`?
   I think that's indeed better but this PR is now already merged.
   Shall I prepare a PR to incorporate that?
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo edited a comment on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs

[GitBox]

resmo edited a comment on issue #2880: [4.11.2]: rolling upgrade of VR results 
in duplicate VRs
URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-433921820
 
 
   
   @rhtyd Did set the `force top on destroy` to `true` and was not able to 
reproduce anymore, however, still seeing "initiate guest OS shutdown" on 
vSphere. I wonder, if this setting make any difference, I should see a "Power 
Off virtual machine" on vSphere, right?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs

[GitBox]

resmo commented on issue #2880: [4.11.2]: rolling upgrade of VR results in 
duplicate VRs
URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-433921820
 
 
   * Did set the `force top on destroy` to `true` and was not able to reproduce 
anymore, however, still seeing "initiate guest OS shutdown" on vSphere. I 
wonder, if this setting make any difference, I should see a "Power Off virtual 
machine" on vSphere, right?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available

[GitBox]

somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while 
NFS not available
URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-433911908
 
 
   With NFS not available and since those are hard mounts,  even a "virsh
   destroy" would not work.  Libvirtd will block until the NFS mount issue is
   resolved. I think that ideally the cloudstack-agent would do every task
   in a non-blocking way and not be affected by primary storage hiccups.   For
   instance,  to avoid the thread pool blocking on libvirtd tasks,  why no
   implement a configurable timeout on thosetasks with sensible defaults ?   I
   don't see a good reason a call to libvirtd take more than a few seconds
   (beside known long lasting tasks such as live migration)
   
   As for fencing,  afaik the host HA framework was created for the purpose or
   reliable fencing... but will cause more damage than good if the end result
   is to reboot all KVM hosts via IPMI (compared to just wait for NFS to come
   back)
   
   On Mon, Oct 29, 2018 at 9:18 AM Boris Stoyanov - a.k.a Bobby <
   notificati...@github.com> wrote:
   
   > I think the leanest way to fence the resource would be, prior to setting
   > the host down to iterate all it's VMs and shut them down, only then to
   > proceed and mark the host as 'Down', once were there, there's no issue with
   > VM-HA starting a new instance on a separate host.
   > I guess this needs further investigation and a fix as described.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes

[GitBox]

blueorangutan commented on issue #2793: Destroyvm also removes volumes
URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-433908870
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available

[GitBox]

borisstoyanov commented on issue #2890: KVMHAMonitor thread blocks indefinitely 
while NFS not available
URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-433906239
 
 
   I think the leanest way to fence the resource would be, prior to setting the 
host down to iterate all it's VMs and shut them down, only then to proceed and 
mark the host as 'Down', once were there, there's no issue with VM-HA starting 
a new instance on a separate host. 
   I guess this needs further investigation and a fix as described. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available

[GitBox]

somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while 
NFS not available
URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-433896656
 
 
   Correct.  Only VM-HA enabled would get restarted and create a duplicate
   when the host goes down.  Still,  I don't think this a good behavior to
   fire VM-HA (because of host Up --> Down state) under any scenarios caused
   by transient storage disconnection.   If  the host goes down after 5
   minutes,  VM-HA restarts VM about one minute later, and then if the NFS
   issue gets resolved you have almost 100% probability of root disk
   corruption and you don't know where the 2 VMs are since Cloudstack only
   remembers the last copy it started.
   
   
   On Mon, Oct 29, 2018 at 3:21 AM Boris Stoyanov - a.k.a Bobby <
   notificati...@github.com> wrote:
   
   > hi @csquire  @somejfn
   > , thanks for this issue!
   >
   > I think it's correct that the host goes into 'Down' state after loosing
   > it's grip on the storage, since this is basically making it inoperable.
   > Going into 'Disconnected' state would only mean the connection between
   > management and host is compromised.
   >
   > On the other hand duplicated VMs is definitely something that needs to get
   > addressed, prior marking the host as 'Down' when we have a VM-HA enabled.
   > Just to be sure, can you please confirm you don't see these duplicated VMs
   > on a non VM-ha enabled instances? I'd like to narrow down this issue and
   > make sure it's in the VM-HA logic.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2919: vmware: updateVmwareDc API for updating vmware datacenter details

[GitBox]

DaanHoogland commented on a change in pull request #2919: vmware: 
updateVmwareDc API for updating vmware datacenter details
URL: https://github.com/apache/cloudstack/pull/2919#discussion_r228898339
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -1132,6 +1149,70 @@ public VmwareDatacenterVO 
addVmwareDatacenter(AddVmwareDcCmd cmd) throws Resourc
 return vmwareDc;
 }
 
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_ZONE_EDIT, eventDescription = 
"updating VMware datacenter")
+public VmwareDatacenter updateVmwareDatacenter(UpdateVmwareDcCmd cmd) {
+final Long zoneId = cmd.getZoneId();
+final String userName = cmd.getUsername();
+final String password = cmd.getPassword();
+final String vCenterHost = cmd.getVcenter();
+final String vmwareDcName = cmd.getName();
+final Boolean isRecursive = cmd.isRecursive();
+
+final VmwareDatacenterZoneMap vdcMap = 
vmwareDatacenterZoneMapDao.findByZoneId(zoneId);
+final VmwareDatacenterVO vmwareDc = 
vmwareDcDao.findById(vdcMap.getVmwareDcId());
+if (vmwareDc == null) {
+throw new CloudRuntimeException("VMWare datacenter does not exist 
by provided ID");
+}
+final String oldVCenterHost = vmwareDc.getVcenterHost();
+
+if (!Strings.isNullOrEmpty(userName)) {
+vmwareDc.setUser(userName);
+}
+if (!Strings.isNullOrEmpty(password)) {
+vmwareDc.setPassword(password);
+}
+if (!Strings.isNullOrEmpty(vCenterHost)) {
+vmwareDc.setVcenterHost(vCenterHost);
+}
+if (!Strings.isNullOrEmpty(vmwareDcName)) {
+vmwareDc.setVmwareDatacenterName(vmwareDcName);
+}
+vmwareDc.setGuid(String.format("%s@%s", 
vmwareDc.getVmwareDatacenterName(), vmwareDc.getVcenterHost()));
+
+return Transaction.execute(new TransactionCallback() 
{
+@Override
+public VmwareDatacenter doInTransaction(TransactionStatus status) {
+if (vmwareDcDao.update(vmwareDc.getId(), vmwareDc)) {
+if (isRecursive) {
+for (final Cluster cluster : 
clusterDao.listByDcHyType(zoneId, Hypervisor.HypervisorType.VMware.toString())) 
{
+final Map clusterDetails = 
clusterDetailsDao.findDetails(cluster.getId());
+clusterDetails.put("username", vmwareDc.getUser());
+clusterDetails.put("password", 
vmwareDc.getPassword());
+final String clusterUrl = 
clusterDetails.get("url");
+if (!Strings.isNullOrEmpty(clusterUrl)) {
+clusterDetails.put("url", 
clusterUrl.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
 
 Review comment:
   np, my bad that communication was failing here, I meant for this to be a 
comment or ticket for future solving and approved the PR already.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2919: vmware: updateVmwareDc API for updating vmware datacenter details

[GitBox]

rhtyd commented on a change in pull request #2919: vmware: updateVmwareDc API 
for updating vmware datacenter details
URL: https://github.com/apache/cloudstack/pull/2919#discussion_r228892302
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -1132,6 +1149,70 @@ public VmwareDatacenterVO 
addVmwareDatacenter(AddVmwareDcCmd cmd) throws Resourc
 return vmwareDc;
 }
 
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_ZONE_EDIT, eventDescription = 
"updating VMware datacenter")
+public VmwareDatacenter updateVmwareDatacenter(UpdateVmwareDcCmd cmd) {
+final Long zoneId = cmd.getZoneId();
+final String userName = cmd.getUsername();
+final String password = cmd.getPassword();
+final String vCenterHost = cmd.getVcenter();
+final String vmwareDcName = cmd.getName();
+final Boolean isRecursive = cmd.isRecursive();
+
+final VmwareDatacenterZoneMap vdcMap = 
vmwareDatacenterZoneMapDao.findByZoneId(zoneId);
+final VmwareDatacenterVO vmwareDc = 
vmwareDcDao.findById(vdcMap.getVmwareDcId());
+if (vmwareDc == null) {
+throw new CloudRuntimeException("VMWare datacenter does not exist 
by provided ID");
+}
+final String oldVCenterHost = vmwareDc.getVcenterHost();
+
+if (!Strings.isNullOrEmpty(userName)) {
+vmwareDc.setUser(userName);
+}
+if (!Strings.isNullOrEmpty(password)) {
+vmwareDc.setPassword(password);
+}
+if (!Strings.isNullOrEmpty(vCenterHost)) {
+vmwareDc.setVcenterHost(vCenterHost);
+}
+if (!Strings.isNullOrEmpty(vmwareDcName)) {
+vmwareDc.setVmwareDatacenterName(vmwareDcName);
+}
+vmwareDc.setGuid(String.format("%s@%s", 
vmwareDc.getVmwareDatacenterName(), vmwareDc.getVcenterHost()));
+
+return Transaction.execute(new TransactionCallback() 
{
+@Override
+public VmwareDatacenter doInTransaction(TransactionStatus status) {
+if (vmwareDcDao.update(vmwareDc.getId(), vmwareDc)) {
+if (isRecursive) {
+for (final Cluster cluster : 
clusterDao.listByDcHyType(zoneId, Hypervisor.HypervisorType.VMware.toString())) 
{
+final Map clusterDetails = 
clusterDetailsDao.findDetails(cluster.getId());
+clusterDetails.put("username", vmwareDc.getUser());
+clusterDetails.put("password", 
vmwareDc.getPassword());
+final String clusterUrl = 
clusterDetails.get("url");
+if (!Strings.isNullOrEmpty(clusterUrl)) {
+clusterDetails.put("url", 
clusterUrl.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
 
 Review comment:
   Copy @DaanHoogland, there may be bunch of params required to recreate those 
fields. Replacing substring seemed the easiest option.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7

[GitBox]

rhtyd commented on issue #2896: add exitcode / distribution detection and 
remove export CGROUP_DAEMON for RHEL7/CentOS7
URL: https://github.com/apache/cloudstack/pull/2896#issuecomment-433880394
 
 
   Thanks @svenvogel I'll test this soon (our labs are currently under 
maintenance).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] svenvogel commented on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7

[GitBox]

svenvogel commented on issue #2896: add exitcode / distribution detection and 
remove export CGROUP_DAEMON for RHEL7/CentOS7
URL: https://github.com/apache/cloudstack/pull/2896#issuecomment-433879641
 
 
   @rhtyd look good?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2929: add public IP range to domain fails in the inital setup (UI Problem)

[GitBox]

nvazquez commented on issue #2929: add public IP range to domain fails in the 
inital setup (UI Problem)
URL: https://github.com/apache/cloudstack/issues/2929#issuecomment-433879195
 
 
   @svenvogel @rhtyd sure, I'll be working on this one and will update you soon


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner closed pull request #1448: CLOUDSTACK-9315: Removed unused Classes

[GitBox]

rafaelweingartner closed pull request #1448: CLOUDSTACK-9315: Removed unused 
Classes 
URL: https://github.com/apache/cloudstack/pull/1448
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/main/java/com/cloud/agent/api/CheckStateAnswer.java 
b/core/src/main/java/com/cloud/agent/api/CheckStateAnswer.java
deleted file mode 100644
index 5e3a709bb22..000
--- a/core/src/main/java/com/cloud/agent/api/CheckStateAnswer.java
+++ /dev/null
@@ -1,49 +0,0 @@
-//
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-//
-
-package com.cloud.agent.api;
-
-import com.cloud.vm.VirtualMachine.State;
-
-/**
- */
-public class CheckStateAnswer extends Answer {
-State state;
-
-public CheckStateAnswer() {
-}
-
-public CheckStateAnswer(CheckStateCommand cmd, State state) {
-this(cmd, state, null);
-}
-
-public CheckStateAnswer(CheckStateCommand cmd, String details) {
-super(cmd, false, details);
-this.state = null;
-}
-
-public CheckStateAnswer(CheckStateCommand cmd, State state, String 
details) {
-super(cmd, true, details);
-this.state = state;
-}
-
-public State getState() {
-return state;
-}
-}
diff --git a/core/src/main/java/com/cloud/agent/api/StartupVMMAgentCommand.java 
b/core/src/main/java/com/cloud/agent/api/StartupVMMAgentCommand.java
deleted file mode 100644
index 7c9ad1ab3ff..000
--- a/core/src/main/java/com/cloud/agent/api/StartupVMMAgentCommand.java
+++ /dev/null
@@ -1,86 +0,0 @@
-//
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-//
-
-package com.cloud.agent.api;
-
-import com.cloud.host.Host;
-
-/**
- * Implementation of bootstrap command sent from management server to agent 
running on
- * System Center Virtual Machine Manager host
- **/
-
-public class StartupVMMAgentCommand extends Command {
-Host.Type type;
-long dataCenter;
-Long pod;
-String clusterName;
-String guid;
-String managementServerIP;
-String port;
-String version;
-
-public StartupVMMAgentCommand() {
-
-}
-
-public StartupVMMAgentCommand(long dataCenter, Long pod, String 
clusterName, String guid, String managementServerIP, String port, String 
version) {
-super();
-this.dataCenter = dataCenter;
-this.pod = pod;
-this.clusterName = clusterName;
-this.guid = guid;
-this.type = Host.Type.Routing;
-this.managementServerIP = managementServerIP;
-this.port = port;
-}
-
-public long getDataCenter() {
-return dataCenter;
-}
-
-public Long getPod() {
-return pod;
-}
-
-public String getClusterName() {
-return clusterName;
-}
-
-public String getGuid() {
-return guid;
-}
-
-public String getManagementServerIP() {
-return managementServerIP;
-}
-
-public String getport() {
-return port;
-}
-
-public void setVersion(String version) {
-this.version = version;
-}
-
-@Override
-public boolean executeInSequence() {
-return false;
-}
-}
\ No newline at end of file
diff --git 
a/core/src/main/java/com/cloud/agent/api/routing/UserDataCommand.java 

[cloudstack] branch master updated: CLOUDSTACK-9315: Removed unused Classes (#1448)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new cdc6e6e  CLOUDSTACK-9315: Removed unused Classes  (#1448)
cdc6e6e is described below

commit cdc6e6e50ae6ec400c2a156d9db7200ccbf1979c
Author: Gabriel Beims Bräscher 
AuthorDate: Mon Oct 29 08:27:00 2018 -0300

CLOUDSTACK-9315: Removed unused Classes  (#1448)

* Remove some unused Classes

These classes were deleted because they have no references in our code 
base. They are not in Spring execution flow nor instantiated with "new":
- com.cloud.agent.api.CheckStateAnswer
- com.cloud.agent.api.StartupVMMAgentCommand
- com.cloud.agent.api.routing.UserDataCommand
- remove from description at
com.cloud.configuration.Config.ExecuteInSequenceNetworkElementCommands
enum
- com.cloud.agent.api.storage.UpgradeDiskCommand
- com.cloud.agent.api.storage.CreatePrivateTemplateCommand
- com.cloud.agent.api.storage.DestroyAnswer
- Note: "FIXME: Should have an DestroyAnswer" at
com.cloud.storage.resource.StoragePoolResource
- com.cloud.agent.api.storage.UpgradeDiskAnswer
- com.cloud.agent.api.storage.ManageVolumeAvailabilityAnswer
- com.cloud.agent.api.storage.ManageVolumeAvailabilityCommand
- com.cloud.exception.UsageServerException
- com.cloud.info.SecStorageVmLoadInfo
- com.cloud.serializer.SerializerHelper

* PR#1448 update description of 
'execute.in.sequence.network.element.commands' param

Update description of 
'execute.in.sequence.network.element.commands'parameter to reflect an unused 
command that has been removed. The removed class command is 'UserDataCommand'.

* Add cloud schema to update SQL
---
 .../java/com/cloud/agent/api/CheckStateAnswer.java |  49 --
 .../cloud/agent/api/StartupVMMAgentCommand.java|  86 -
 .../cloud/agent/api/routing/UserDataCommand.java   |  67 ---
 .../api/storage/CreatePrivateTemplateCommand.java  |  95 --
 .../com/cloud/agent/api/storage/DestroyAnswer.java |  34 
 .../storage/ManageVolumeAvailabilityAnswer.java|  35 
 .../storage/ManageVolumeAvailabilityCommand.java   |  56 --
 .../cloud/agent/api/storage/UpgradeDiskAnswer.java |  34 
 .../agent/api/storage/UpgradeDiskCommand.java  |  55 --
 .../com/cloud/exception/UsageServerException.java  |  37 
 .../java/com/cloud/info/SecStorageVmLoadInfo.java  |  51 --
 .../com/cloud/serializer/SerializerHelper.java | 193 -
 .../storage/resource/StoragePoolResource.java  |   1 -
 .../resources/META-INF/db/schema-41120to41200.sql  |   5 +-
 .../main/java/com/cloud/configuration/Config.java  |  14 +-
 15 files changed, 11 insertions(+), 801 deletions(-)

diff --git a/core/src/main/java/com/cloud/agent/api/CheckStateAnswer.java 
b/core/src/main/java/com/cloud/agent/api/CheckStateAnswer.java
deleted file mode 100644
index 5e3a709..000
--- a/core/src/main/java/com/cloud/agent/api/CheckStateAnswer.java
+++ /dev/null
@@ -1,49 +0,0 @@
-//
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-//
-
-package com.cloud.agent.api;
-
-import com.cloud.vm.VirtualMachine.State;
-
-/**
- */
-public class CheckStateAnswer extends Answer {
-State state;
-
-public CheckStateAnswer() {
-}
-
-public CheckStateAnswer(CheckStateCommand cmd, State state) {
-this(cmd, state, null);
-}
-
-public CheckStateAnswer(CheckStateCommand cmd, String details) {
-super(cmd, false, details);
-this.state = null;
-}
-
-public CheckStateAnswer(CheckStateCommand cmd, State state, String 
details) {
-super(cmd, true, details);
-this.state = state;
-}
-
-public State getState() {
-return state;
-}
-}
diff --git a/core/src/main/java/com/cloud/agent/api/StartupVMMAgentCommand.java 
b/core/src/main/java/com/cloud/agent/api/StartupVMMAgentCommand.java
deleted file mode 100644
index 7c9ad1a..000
--- a/core/src/main/java/com/cloud/agent/api/StartupVMMAgentCommand.java
+++ /dev/null
@@ 

[GitHub] rhtyd commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

[GitBox]

rhtyd commented on issue #2930: HA for Management Server - roundrobin: 
Certificate ownership
URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-433872021
 
 
   @DennisKonrad I've already replied to you how cert generation works, tl;dr - 
each mgmt server generates its own cert on startup based on keypair/ca-cert 
from the db, the alt names are obtained by mgmt server by reading ips on 
network interfaces. The certs of mgmt server are only used when they 
peer/cluster with other mgmt servers, if you re-generated core keypair/ca-cert 
then kvm hosts certs will need to be re-provisioned. Please go figure: 
https://github.com/apache/cloudstack/blob/master/plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java#L409


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2905: Fix delete domain button in the UI to update only after deleteDomain job finishes

[GitBox]

rafaelweingartner commented on a change in pull request #2905: Fix delete 
domain button in the UI to update only after deleteDomain job finishes
URL: https://github.com/apache/cloudstack/pull/2905#discussion_r228012074
 
 

 ##
 File path: ui/scripts/domains.js
 ##
 @@ -69,11 +69,23 @@
 async: false,
 success: function(json) {
 var jid = json.deletedomainresponse.jobid;
+var wasDomainDeletedWithSuccess = false;
+$.ajax({
+url: 
createURL("queryAsyncJobResult=" + jid),
+dataType: "json",
+async: false,
 
 Review comment:
   that is a good question. If you take a look, the upper method "deleteDomain" 
(at line 69), it is already an "async=false" call. I could for instance, move 
the code from lines 81-93 to the success function (line 78), but that can cause 
an odd behavior if the user clicks somewhere in the UI before the method 
finishes. That is why I decided to roll with the "standard" and use a "sync" 
call as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2905: Fix delete domain button in the UI to update only after deleteDomain job finishes

[GitBox]

rafaelweingartner commented on a change in pull request #2905: Fix delete 
domain button in the UI to update only after deleteDomain job finishes
URL: https://github.com/apache/cloudstack/pull/2905#discussion_r228012074
 
 

 ##
 File path: ui/scripts/domains.js
 ##
 @@ -69,11 +69,23 @@
 async: false,
 success: function(json) {
 var jid = json.deletedomainresponse.jobid;
+var wasDomainDeletedWithSuccess = false;
+$.ajax({
+url: 
createURL("queryAsyncJobResult=" + jid),
+dataType: "json",
+async: false,
 
 Review comment:
   that is a good question. If you take a look, the upper method "deleteDomain" 
(at line 69), it is already an "async=false" call. I could for instance, move 
the code from lines 81-93 to the success function (line 78), but that can cause 
an odd behavior if the user clicks somewhere in the UI before the method 
finishing. That is why I decided to roll with the "standard" and use a "sync" 
call as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (8738ca7 -> 323d381)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 8738ca7  kvm: use libvirtd as service name for all distributions 
(#2925)
 add 9cf57d2  network: on rolling restart force stop old routers (#2926)
 add a87acf9  kvm: improved performance on creating VM  (#2923)
 add e2ba934  server: fix unwanted txn commit warning messages (#2927)
 add f0491d5  vr: defer was broken in VR because of json name change (#2979)
 add dffb430  kvm: Fix migrating VM from ISO failures (#2928)
 add f7bc580  vr: defer was broken in VR because of json name change
 new 323d381  Merge remote-tracking branch 'origin/4.11'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloudstack/storage/to/TemplateObjectTO.java|   9 ++
 .../engine/orchestration/NetworkOrchestrator.java  |   1 +
 .../kvm/resource/LibvirtComputingResource.java |   4 +-
 scripts/vm/network/vnet/modifyvlan.sh  |  14 +--
 .../java/com/cloud/network/vpc/VpcManagerImpl.java |   1 +
 .../resourcelimit/ResourceLimitManagerImpl.java| 103 +++--
 .../com/cloud/template/TemplateManagerImpl.java|  12 ++-
 systemvm/debian/opt/cloud/bin/update_config.py |   2 +-
 8 files changed, 79 insertions(+), 67 deletions(-)

[GitHub] rafaelweingartner commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes

[GitBox]

rafaelweingartner commented on a change in pull request #1448: CLOUDSTACK-9315: 
Removed unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#discussion_r228880867
 
 

 ##
 File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql
 ##
 @@ -34,4 +34,7 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, 
`rule`, `permission`,
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 3, 'moveNetworkAclItem', 'ALLOW', 
302) ON DUPLICATE KEY UPDATE rule=rule;
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 4, 'moveNetworkAclItem', 'ALLOW', 
260) ON DUPLICATE KEY UPDATE rule=rule;
 
-UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
\ No newline at end of file
+UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
+
+-- PR#1448 update description of 
'execute.in.sequence.network.element.commands' parameter to reflect an unused 
command that has been removed. The removed class command is 'UserDataCommand'.
+update configuration set description = 'If set to true, DhcpEntryCommand, 
SavePasswordCommand, VmDataCommand will be synchronized on the agent side. If 
set to false, these commands become asynchronous. Default value is false.' 
where name = 'execute.in.sequence.network.element.commands'; 
 
 Review comment:
   Ah, sure the schema. Done!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: vr: defer was broken in VR because of json name change

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new f7bc580  vr: defer was broken in VR because of json name change
f7bc580 is described below

commit f7bc5807a3bec9fea104133ebb894dabfc0bd5fc
Author: Rene Diepstraten 
AuthorDate: Mon Oct 29 16:18:25 2018 +0530

vr: defer was broken in VR because of json name change

Committed at f0491d5c72c3161777ca49ae809606a6704df5ff (#2979).

After upgrade from CS 4.10 to CS 4.11, multiple VRs did not start through.
It did not properly defer the finalize config in update_config.py.
Apparently, the json files are now called differently: where it used to
be vm_dhcp_entry.json it now has a uuid added, for example
vm_metadata.json.4d727b6e-2b48-49df-81c3-b8532f3d6745.
The if statement that checks if the finalize can be safely deferred
therefore no longer matches. This PR contains a fix so finalize is
defered again.

Signed-off-by: Rohit Yadav 

[cloudstack] branch 4.11 updated: kvm: Fix migrating VM from ISO failures (#2928)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new dffb430  kvm: Fix migrating VM from ISO failures (#2928)
dffb430 is described below

commit dffb4309750517ced063008ccee7907cb85f86ba
Author: Nicolas Vazquez 
AuthorDate: Mon Oct 29 07:44:20 2018 -0300

kvm: Fix migrating VM from ISO failures (#2928)

Prevents errors while migrating VM from ISO:

Test 1: Deploy VM from ISO -> Live migrate VM to another host -> ERROR
Test 2: Register ISO using Direct Download on KVM -> Deploy VM from ISO -> 
Live migrate VM to another host -> ERROR

- Prevent NullPointerException migrating VM from ISO
- Prevent mount secondary storage on ISO direct downloads on KVM
---
 .../org/apache/cloudstack/storage/to/TemplateObjectTO.java   |  9 +
 .../hypervisor/kvm/resource/LibvirtComputingResource.java|  4 +++-
 server/src/com/cloud/template/TemplateManagerImpl.java   | 12 
 3 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java 
b/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
index 4a3d058..cc2eaad 100644
--- a/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
+++ b/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
@@ -46,6 +46,7 @@ public class TemplateObjectTO implements DataTO {
 private Hypervisor.HypervisorType hypervisorType;
 private boolean bootable;
 private String uniqueName;
+private boolean directDownload;
 
 public TemplateObjectTO() {
 
@@ -235,6 +236,14 @@ public class TemplateObjectTO implements DataTO {
 this.uniqueName = uniqueName;
 }
 
+public boolean isDirectDownload() {
+return directDownload;
+}
+
+public void setDirectDownload(boolean directDownload) {
+this.directDownload = directDownload;
+}
+
 @Override
 public String toString() {
 return new 
StringBuilder("TemplateTO[id=").append(id).append("|origUrl=").append(origUrl).append("|name").append(name).append("]").toString();
diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 8a94b05..652f643 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -49,6 +49,7 @@ import javax.xml.parsers.ParserConfigurationException;
 
 import com.cloud.resource.RequestWrapper;
 import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+import org.apache.cloudstack.storage.to.TemplateObjectTO;
 import org.apache.cloudstack.storage.to.VolumeObjectTO;
 import org.apache.cloudstack.utils.hypervisor.HypervisorUtils;
 import org.apache.cloudstack.utils.linux.CPUStat;
@@ -2209,7 +2210,8 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 final DataTO data = volume.getData();
 final DataStoreTO store = data.getDataStore();
 
-if (volume.getType() == Volume.Type.ISO && data.getPath() != null && 
(store instanceof NfsTO || store instanceof PrimaryDataStoreTO)) {
+if (volume.getType() == Volume.Type.ISO && data.getPath() != null && 
(store instanceof NfsTO ||
+store instanceof PrimaryDataStoreTO && data instanceof 
TemplateObjectTO && !((TemplateObjectTO) data).isDirectDownload())) {
 final String isoPath = store.getUrl().split("\\?")[0] + 
File.separator + data.getPath();
 final int index = isoPath.lastIndexOf("/");
 final String path = isoPath.substring(0, index);
diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java 
b/server/src/com/cloud/template/TemplateManagerImpl.java
index 42bdd72..48cc6f4 100755
--- a/server/src/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -50,6 +50,7 @@ import 
org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
 import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
 import org.apache.cloudstack.utils.imagestore.ImageStoreUtil;
 import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.collections.MapUtils;
 import org.apache.log4j.Logger;
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.ApiConstants;
@@ -557,11 +558,13 @@ public class TemplateManagerImpl extends ManagerBase 
implements TemplateManager,
 if (vm.getIsoId() != null) {
 Map storageForDisks = 
dest.getStorageForDisks();
 Long poolId = null;
-for (StoragePool storagePool : storageForDisks.values()) {
-

[GitHub] rhtyd closed pull request #2928: Migrating VM from ISO failures

[GitBox]

rhtyd closed pull request #2928: Migrating VM from ISO failures
URL: https://github.com/apache/cloudstack/pull/2928
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java 
b/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
index 4a3d058176c..cc2eaadea07 100644
--- a/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
+++ b/core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
@@ -46,6 +46,7 @@
 private Hypervisor.HypervisorType hypervisorType;
 private boolean bootable;
 private String uniqueName;
+private boolean directDownload;
 
 public TemplateObjectTO() {
 
@@ -235,6 +236,14 @@ public void setUniqueName(String uniqueName) {
 this.uniqueName = uniqueName;
 }
 
+public boolean isDirectDownload() {
+return directDownload;
+}
+
+public void setDirectDownload(boolean directDownload) {
+this.directDownload = directDownload;
+}
+
 @Override
 public String toString() {
 return new 
StringBuilder("TemplateTO[id=").append(id).append("|origUrl=").append(origUrl).append("|name").append(name).append("]").toString();
diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 8a94b058655..652f6431f0e 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -49,6 +49,7 @@
 
 import com.cloud.resource.RequestWrapper;
 import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+import org.apache.cloudstack.storage.to.TemplateObjectTO;
 import org.apache.cloudstack.storage.to.VolumeObjectTO;
 import org.apache.cloudstack.utils.hypervisor.HypervisorUtils;
 import org.apache.cloudstack.utils.linux.CPUStat;
@@ -2209,7 +2210,8 @@ public String getVolumePath(final Connect conn, final 
DiskTO volume) throws Libv
 final DataTO data = volume.getData();
 final DataStoreTO store = data.getDataStore();
 
-if (volume.getType() == Volume.Type.ISO && data.getPath() != null && 
(store instanceof NfsTO || store instanceof PrimaryDataStoreTO)) {
+if (volume.getType() == Volume.Type.ISO && data.getPath() != null && 
(store instanceof NfsTO ||
+store instanceof PrimaryDataStoreTO && data instanceof 
TemplateObjectTO && !((TemplateObjectTO) data).isDirectDownload())) {
 final String isoPath = store.getUrl().split("\\?")[0] + 
File.separator + data.getPath();
 final int index = isoPath.lastIndexOf("/");
 final String path = isoPath.substring(0, index);
diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java 
b/server/src/com/cloud/template/TemplateManagerImpl.java
index 42bdd72af63..48cc6f43a95 100755
--- a/server/src/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -50,6 +50,7 @@
 import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
 import org.apache.cloudstack.utils.imagestore.ImageStoreUtil;
 import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.collections.MapUtils;
 import org.apache.log4j.Logger;
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.ApiConstants;
@@ -557,11 +558,13 @@ public void prepareIsoForVmProfile(VirtualMachineProfile 
profile, DeployDestinat
 if (vm.getIsoId() != null) {
 Map storageForDisks = 
dest.getStorageForDisks();
 Long poolId = null;
-for (StoragePool storagePool : storageForDisks.values()) {
-if (poolId != null && storagePool.getId() != poolId) {
-throw new CloudRuntimeException("Cannot determine where to 
download iso");
+if (MapUtils.isNotEmpty(storageForDisks)) {
+for (StoragePool storagePool : storageForDisks.values()) {
+if (poolId != null && storagePool.getId() != poolId) {
+throw new CloudRuntimeException("Cannot determine 
where to download iso");
+}
+poolId = storagePool.getId();
 }
-poolId = storagePool.getId();
 }
 TemplateInfo template = prepareIso(vm.getIsoId(), 
vm.getDataCenterId(), dest.getHost().getId(), poolId);
 if (template == null){
@@ -579,6 +582,7 @@ public void prepareIsoForVmProfile(VirtualMachineProfile 
profile, DeployDestinat
 }
 
 TemplateObjectTO iso = 

[GitHub] rhtyd edited a comment on issue #2978: Router aggregate timeout does not seem to be honored

[GitBox]

rhtyd edited a comment on issue #2978: Router aggregate timeout does not seem 
to be honored
URL: https://github.com/apache/cloudstack/issues/2978#issuecomment-433864165
 
 
   https://github.com/apache/cloudstack/pull/2979 has been merged, closing this 
issue. /cc @wido  please re-open if additional work needs to be done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2978: Router aggregate timeout does not seem to be honored

[GitBox]

rhtyd closed issue #2978: Router aggregate timeout does not seem to be honored
URL: https://github.com/apache/cloudstack/issues/2978
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2978: Router aggregate timeout does not seem to be honored

[GitBox]

rhtyd commented on issue #2978: Router aggregate timeout does not seem to be 
honored
URL: https://github.com/apache/cloudstack/issues/2978#issuecomment-433864165
 
 
   https://github.com/apache/cloudstack/pull/2979 has been merged, closing this 
issue. /cc @wido 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: vr: defer was broken in VR because of json name change (#2979)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new f0491d5  vr: defer was broken in VR because of json name change (#2979)
f0491d5 is described below

commit f0491d5c72c3161777ca49ae809606a6704df5ff
Author: Rohit Yadav 
AuthorDate: Mon Oct 29 16:11:43 2018 +0530

vr: defer was broken in VR because of json name change (#2979)

After upgrade from CS 4.10 to CS 4.11, multiple VRs did not start through.
It did not properly defer the finalize config in update_config.py.
Apparently, the json files are now called differently: where it used to
be vm_dhcp_entry.json it now has a uuid added, for example
vm_metadata.json.4d727b6e-2b48-49df-81c3-b8532f3d6745.
The if statement that checks if the finalize can be safely deferred
therefore no longer matches. This PR contains a fix so finalize is
defered again.

Signed-off-by: Rohit Yadav 
---
 systemvm/debian/opt/cloud/bin/update_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/debian/opt/cloud/bin/update_config.py 
b/systemvm/debian/opt/cloud/bin/update_config.py
index 02161b6..77008af 100755
--- a/systemvm/debian/opt/cloud/bin/update_config.py
+++ b/systemvm/debian/opt/cloud/bin/update_config.py
@@ -52,7 +52,7 @@ def process_file():
 qf.setFile(sys.argv[1])
 qf.load(None)
 # These can be safely deferred, dramatically speeding up loading times
-if not (os.environ.get('DEFER_CONFIG', False) and sys.argv[1] in 
('vm_dhcp_entry.json', 'vm_metadata.json')):
+if not (os.environ.get('DEFER_CONFIG', False) and ('vm_dhcp_entry.json' in 
sys.argv[1] or 'vm_metadata.json' in sys.argv[1])):
 # Converge
 finish_config()
 

[GitHub] rhtyd closed pull request #2979: vr: defer was broken in VR because of json name change

[GitBox]

rhtyd closed pull request #2979: vr: defer was broken in VR because of json 
name change
URL: https://github.com/apache/cloudstack/pull/2979
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/debian/opt/cloud/bin/update_config.py 
b/systemvm/debian/opt/cloud/bin/update_config.py
index 02161b662e5..77008afb794 100755
--- a/systemvm/debian/opt/cloud/bin/update_config.py
+++ b/systemvm/debian/opt/cloud/bin/update_config.py
@@ -52,7 +52,7 @@ def process_file():
 qf.setFile(sys.argv[1])
 qf.load(None)
 # These can be safely deferred, dramatically speeding up loading times
-if not (os.environ.get('DEFER_CONFIG', False) and sys.argv[1] in 
('vm_dhcp_entry.json', 'vm_metadata.json')):
+if not (os.environ.get('DEFER_CONFIG', False) and ('vm_dhcp_entry.json' in 
sys.argv[1] or 'vm_metadata.json' in sys.argv[1])):
 # Converge
 finish_config()
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

[GitBox]

DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: 
Certificate ownership
URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-433863948
 
 
   @rhtyd 
   Ok, so are the certificates regenerated for the primary management server 
when adding a secondary one? Because the alternative name has to be updated, 
right? I dont see how it should work otherwise.
   
   So can we do the cert re-kick safely even when we have already added 
multiple hosts? When we leave the CN at
   CN=ca.cloudstack.apache.org
   I see no problem but maybe you know something I'm not thinking about right 
now.
   
   Can you also tell me which script is doing the issuing of the certificates? 
Then I would be able to check what it's doing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2919: vmware: updateVmwareDc API for updating vmware datacenter details

[GitBox]

DaanHoogland commented on a change in pull request #2919: vmware: 
updateVmwareDc API for updating vmware datacenter details
URL: https://github.com/apache/cloudstack/pull/2919#discussion_r228869910
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -1132,6 +1149,70 @@ public VmwareDatacenterVO 
addVmwareDatacenter(AddVmwareDcCmd cmd) throws Resourc
 return vmwareDc;
 }
 
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_ZONE_EDIT, eventDescription = 
"updating VMware datacenter")
+public VmwareDatacenter updateVmwareDatacenter(UpdateVmwareDcCmd cmd) {
+final Long zoneId = cmd.getZoneId();
+final String userName = cmd.getUsername();
+final String password = cmd.getPassword();
+final String vCenterHost = cmd.getVcenter();
+final String vmwareDcName = cmd.getName();
+final Boolean isRecursive = cmd.isRecursive();
+
+final VmwareDatacenterZoneMap vdcMap = 
vmwareDatacenterZoneMapDao.findByZoneId(zoneId);
+final VmwareDatacenterVO vmwareDc = 
vmwareDcDao.findById(vdcMap.getVmwareDcId());
+if (vmwareDc == null) {
+throw new CloudRuntimeException("VMWare datacenter does not exist 
by provided ID");
+}
+final String oldVCenterHost = vmwareDc.getVcenterHost();
+
+if (!Strings.isNullOrEmpty(userName)) {
+vmwareDc.setUser(userName);
+}
+if (!Strings.isNullOrEmpty(password)) {
+vmwareDc.setPassword(password);
+}
+if (!Strings.isNullOrEmpty(vCenterHost)) {
+vmwareDc.setVcenterHost(vCenterHost);
+}
+if (!Strings.isNullOrEmpty(vmwareDcName)) {
+vmwareDc.setVmwareDatacenterName(vmwareDcName);
+}
+vmwareDc.setGuid(String.format("%s@%s", 
vmwareDc.getVmwareDatacenterName(), vmwareDc.getVcenterHost()));
+
+return Transaction.execute(new TransactionCallback() 
{
+@Override
+public VmwareDatacenter doInTransaction(TransactionStatus status) {
+if (vmwareDcDao.update(vmwareDc.getId(), vmwareDc)) {
+if (isRecursive) {
+for (final Cluster cluster : 
clusterDao.listByDcHyType(zoneId, Hypervisor.HypervisorType.VMware.toString())) 
{
+final Map clusterDetails = 
clusterDetailsDao.findDetails(cluster.getId());
+clusterDetails.put("username", vmwareDc.getUser());
+clusterDetails.put("password", 
vmwareDc.getPassword());
+final String clusterUrl = 
clusterDetails.get("url");
+if (!Strings.isNullOrEmpty(clusterUrl)) {
+clusterDetails.put("url", 
clusterUrl.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
 
 Review comment:
   I think you don't need to do anything but we should not update a string in 
the database but instead recreate it on use. I am not asking you to change but 
want to discuss if this update withe string replace is really the way to go.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2928: Migrating VM from ISO failures

[GitBox]

rhtyd commented on issue #2928: Migrating VM from ISO failures
URL: https://github.com/apache/cloudstack/pull/2928#issuecomment-433855394
 
 
   Yes the second case is indeed around direct download feature, @nvazquez can 
you comment?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats

[GitBox]

rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-433855135
 
 
   @DaanHoogland sorry lab's down, BO queue will be stuck for a while.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

[GitBox]

rhtyd commented on issue #2930: HA for Management Server - roundrobin: 
Certificate ownership
URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-433854973
 
 
   @DennisKonrad thanks. When a new management server starts, it first upgrades 
the DB and then various managers/components start. During this start stage, 
first the `ConfigurationManagerImpl` starts which configures various default 
settings, offerings, accounts (such as system, admin etc). When the CA manager 
starts, it asks the configured/default plugin to initialize which is the RootCA 
plugin by default. This plugin would check db is keypair (private/public 
keypair) exists and uses the CA cert to create and sign a self-signed cert for 
the mgmt server host. If during the initializing process, another mgmt server 
is started it might screw up big time conflicting for operations/default 
created by both ConfigurationManager and CAManager. Therefore, based on the 
output you've shared it's more of an env/setup issue than a bug. Please re-test 
master again, this time making sure that the first/primary mgmt server 
initializes/completes before secondary mgmt servers are added.
   
   For an existing env, to force re-kick of cert generation, shutdown all mgmt 
servers, then in the db and set these global settings in cloud.configurations 
table to null:
   - ca.plugin.root.private.key
   - ca.plugin.root.public.key
   - ca.plugin.root.ca.certificate
   
   And start first mgmt server, let it complete initialization and start other 
mgmt servers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2919: vmware: updateVmwareDc API for updating vmware datacenter details

[GitBox]

rhtyd commented on a change in pull request #2919: vmware: updateVmwareDc API 
for updating vmware datacenter details
URL: https://github.com/apache/cloudstack/pull/2919#discussion_r228861062
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -1132,6 +1149,70 @@ public VmwareDatacenterVO 
addVmwareDatacenter(AddVmwareDcCmd cmd) throws Resourc
 return vmwareDc;
 }
 
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_ZONE_EDIT, eventDescription = 
"updating VMware datacenter")
+public VmwareDatacenter updateVmwareDatacenter(UpdateVmwareDcCmd cmd) {
+final Long zoneId = cmd.getZoneId();
+final String userName = cmd.getUsername();
+final String password = cmd.getPassword();
+final String vCenterHost = cmd.getVcenter();
+final String vmwareDcName = cmd.getName();
+final Boolean isRecursive = cmd.isRecursive();
+
+final VmwareDatacenterZoneMap vdcMap = 
vmwareDatacenterZoneMapDao.findByZoneId(zoneId);
+final VmwareDatacenterVO vmwareDc = 
vmwareDcDao.findById(vdcMap.getVmwareDcId());
+if (vmwareDc == null) {
+throw new CloudRuntimeException("VMWare datacenter does not exist 
by provided ID");
+}
+final String oldVCenterHost = vmwareDc.getVcenterHost();
+
+if (!Strings.isNullOrEmpty(userName)) {
+vmwareDc.setUser(userName);
+}
+if (!Strings.isNullOrEmpty(password)) {
+vmwareDc.setPassword(password);
+}
+if (!Strings.isNullOrEmpty(vCenterHost)) {
+vmwareDc.setVcenterHost(vCenterHost);
+}
+if (!Strings.isNullOrEmpty(vmwareDcName)) {
+vmwareDc.setVmwareDatacenterName(vmwareDcName);
+}
+vmwareDc.setGuid(String.format("%s@%s", 
vmwareDc.getVmwareDatacenterName(), vmwareDc.getVcenterHost()));
+
+return Transaction.execute(new TransactionCallback() 
{
+@Override
+public VmwareDatacenter doInTransaction(TransactionStatus status) {
+if (vmwareDcDao.update(vmwareDc.getId(), vmwareDc)) {
+if (isRecursive) {
+for (final Cluster cluster : 
clusterDao.listByDcHyType(zoneId, Hypervisor.HypervisorType.VMware.toString())) 
{
+final Map clusterDetails = 
clusterDetailsDao.findDetails(cluster.getId());
+clusterDetails.put("username", vmwareDc.getUser());
+clusterDetails.put("password", 
vmwareDc.getPassword());
+final String clusterUrl = 
clusterDetails.get("url");
+if (!Strings.isNullOrEmpty(clusterUrl)) {
+clusterDetails.put("url", 
clusterUrl.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
 
 Review comment:
   @DaanHoogland sorry did not understand the comment. What do I need to do?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2978: Router aggregate timeout does not seem to be honored

[GitBox]

rhtyd commented on issue #2978: Router aggregate timeout does not seem to be 
honored
URL: https://github.com/apache/cloudstack/issues/2978#issuecomment-433849364
 
 
   The fix shared by @RPDiep  LGTM @wido 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2979: vr: defer was broken in VR because of json name change

[GitBox]

rhtyd commented on issue #2979: vr: defer was broken in VR because of json name 
change
URL: https://github.com/apache/cloudstack/pull/2979#issuecomment-433848826
 
 
   Our lab is temporary under maintenance, I'll tested this locally in a 
[monkeybox](https://github.com/rhtyd/monkeybox)+KVM based env and LGTM. Will 
merge this as soon as travis is OK.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2979: vr: defer was broken in VR because of json name change

[GitBox]

rhtyd commented on issue #2979: vr: defer was broken in VR because of json name 
change
URL: https://github.com/apache/cloudstack/pull/2979#issuecomment-433848347
 
 
   For reference, this was authored by @RPDiep and he will not lose his 
authorship on the commit. We can use my review/lgtm from previous PR:
   ![screenshot from 2018-10-29 
15-18-38](https://user-images.githubusercontent.com/95203/47642169-f4478680-db8d-11e8-85e3-f5973170309a.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

rhtyd commented on issue #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433848037
 
 
   @wido sorry, my bad. I was trying to rebase but made a mistake and github 
closed it as I force pushed on his branch (github allows maintainers to push on 
a contributor's PR branch). I've re-submitted his change, he will not lose his 
authorship on the commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2919: vmware: updateVmwareDc API for updating vmware datacenter details

[GitBox]

DaanHoogland commented on a change in pull request #2919: vmware: 
updateVmwareDc API for updating vmware datacenter details
URL: https://github.com/apache/cloudstack/pull/2919#discussion_r228855906
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -1132,6 +1149,70 @@ public VmwareDatacenterVO 
addVmwareDatacenter(AddVmwareDcCmd cmd) throws Resourc
 return vmwareDc;
 }
 
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_ZONE_EDIT, eventDescription = 
"updating VMware datacenter")
+public VmwareDatacenter updateVmwareDatacenter(UpdateVmwareDcCmd cmd) {
+final Long zoneId = cmd.getZoneId();
+final String userName = cmd.getUsername();
+final String password = cmd.getPassword();
+final String vCenterHost = cmd.getVcenter();
+final String vmwareDcName = cmd.getName();
+final Boolean isRecursive = cmd.isRecursive();
+
+final VmwareDatacenterZoneMap vdcMap = 
vmwareDatacenterZoneMapDao.findByZoneId(zoneId);
+final VmwareDatacenterVO vmwareDc = 
vmwareDcDao.findById(vdcMap.getVmwareDcId());
+if (vmwareDc == null) {
+throw new CloudRuntimeException("VMWare datacenter does not exist 
by provided ID");
+}
+final String oldVCenterHost = vmwareDc.getVcenterHost();
+
+if (!Strings.isNullOrEmpty(userName)) {
+vmwareDc.setUser(userName);
+}
+if (!Strings.isNullOrEmpty(password)) {
+vmwareDc.setPassword(password);
+}
+if (!Strings.isNullOrEmpty(vCenterHost)) {
+vmwareDc.setVcenterHost(vCenterHost);
+}
+if (!Strings.isNullOrEmpty(vmwareDcName)) {
+vmwareDc.setVmwareDatacenterName(vmwareDcName);
+}
+vmwareDc.setGuid(String.format("%s@%s", 
vmwareDc.getVmwareDatacenterName(), vmwareDc.getVcenterHost()));
+
+return Transaction.execute(new TransactionCallback() 
{
+@Override
+public VmwareDatacenter doInTransaction(TransactionStatus status) {
+if (vmwareDcDao.update(vmwareDc.getId(), vmwareDc)) {
+if (isRecursive) {
+for (final Cluster cluster : 
clusterDao.listByDcHyType(zoneId, Hypervisor.HypervisorType.VMware.toString())) 
{
+final Map clusterDetails = 
clusterDetailsDao.findDetails(cluster.getId());
+clusterDetails.put("username", vmwareDc.getUser());
+clusterDetails.put("password", 
vmwareDc.getPassword());
+final String clusterUrl = 
clusterDetails.get("url");
+if (!Strings.isNullOrEmpty(clusterUrl)) {
+clusterDetails.put("url", 
clusterUrl.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
+}
+clusterDetailsDao.persist(cluster.getId(), 
clusterDetails);
+}
+for (final Host host : 
hostDao.listAllHostsByZoneAndHypervisorType(zoneId, 
Hypervisor.HypervisorType.VMware)) {
+final Map hostDetails = 
hostDetailsDao.findDetails(host.getId());
+hostDetails.put("username", vmwareDc.getUser());
+hostDetails.put("password", 
vmwareDc.getPassword());
+final String hostGuid = hostDetails.get("guid");
+if (!Strings.isNullOrEmpty(hostGuid)) {
+hostDetails.put("guid", 
hostGuid.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
 
 Review comment:
   todo, same as above


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2919: vmware: updateVmwareDc API for updating vmware datacenter details

[GitBox]

DaanHoogland commented on a change in pull request #2919: vmware: 
updateVmwareDc API for updating vmware datacenter details
URL: https://github.com/apache/cloudstack/pull/2919#discussion_r228855574
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -1132,6 +1149,70 @@ public VmwareDatacenterVO 
addVmwareDatacenter(AddVmwareDcCmd cmd) throws Resourc
 return vmwareDc;
 }
 
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_ZONE_EDIT, eventDescription = 
"updating VMware datacenter")
+public VmwareDatacenter updateVmwareDatacenter(UpdateVmwareDcCmd cmd) {
+final Long zoneId = cmd.getZoneId();
+final String userName = cmd.getUsername();
+final String password = cmd.getPassword();
+final String vCenterHost = cmd.getVcenter();
+final String vmwareDcName = cmd.getName();
+final Boolean isRecursive = cmd.isRecursive();
+
+final VmwareDatacenterZoneMap vdcMap = 
vmwareDatacenterZoneMapDao.findByZoneId(zoneId);
+final VmwareDatacenterVO vmwareDc = 
vmwareDcDao.findById(vdcMap.getVmwareDcId());
+if (vmwareDc == null) {
+throw new CloudRuntimeException("VMWare datacenter does not exist 
by provided ID");
+}
+final String oldVCenterHost = vmwareDc.getVcenterHost();
+
+if (!Strings.isNullOrEmpty(userName)) {
+vmwareDc.setUser(userName);
+}
+if (!Strings.isNullOrEmpty(password)) {
+vmwareDc.setPassword(password);
+}
+if (!Strings.isNullOrEmpty(vCenterHost)) {
+vmwareDc.setVcenterHost(vCenterHost);
+}
+if (!Strings.isNullOrEmpty(vmwareDcName)) {
+vmwareDc.setVmwareDatacenterName(vmwareDcName);
+}
+vmwareDc.setGuid(String.format("%s@%s", 
vmwareDc.getVmwareDatacenterName(), vmwareDc.getVcenterHost()));
+
+return Transaction.execute(new TransactionCallback() 
{
+@Override
+public VmwareDatacenter doInTransaction(TransactionStatus status) {
+if (vmwareDcDao.update(vmwareDc.getId(), vmwareDc)) {
+if (isRecursive) {
+for (final Cluster cluster : 
clusterDao.listByDcHyType(zoneId, Hypervisor.HypervisorType.VMware.toString())) 
{
+final Map clusterDetails = 
clusterDetailsDao.findDetails(cluster.getId());
+clusterDetails.put("username", vmwareDc.getUser());
+clusterDetails.put("password", 
vmwareDc.getPassword());
+final String clusterUrl = 
clusterDetails.get("url");
+if (!Strings.isNullOrEmpty(clusterUrl)) {
+clusterDetails.put("url", 
clusterUrl.replace(oldVCenterHost, vmwareDc.getVcenterHost()));
 
 Review comment:
   TODO: not hardcode the url but dynamically create it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2978: Router aggregate timeout does not seem to be honored

[GitBox]

wido commented on issue #2978: Router aggregate timeout does not seem to be 
honored
URL: https://github.com/apache/cloudstack/issues/2978#issuecomment-433847846
 
 
   Seee #2979 , I was too fast with typing :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

wido commented on issue #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433847602
 
 
   @rhtyd Can you tell me why this PR was closed? It's very valid for 4.11.2, 
the processing of the DHCP data is too slow right now on larger deployments.
   
   Issue #2978 seems to have come to light while we were running into this as 
the VR got killed for being very slow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

rhtyd commented on issue #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433847690
 
 
   oops sorry @RPDiep I was trying to fix the change for you, accidentally 
overwrote to your master branch with latest master. I'll resubmit a PR on your 
behalf: https://github.com/apache/cloudstack/pull/2979


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2979: vr: defer was broken in VR because of json name change

[GitBox]

rhtyd opened a new pull request #2979: vr: defer was broken in VR because of 
json name change
URL: https://github.com/apache/cloudstack/pull/2979
 
 
   After upgrade from CS 4.10 to CS 4.11, multiple VRs did not start through.
   It did not properly defer the finalize config in update_config.py.
   Apparently, the json files are now called differently: where it used to
   be vm_dhcp_entry.json it now has a uuid added, for example
   vm_metadata.json.4d727b6e-2b48-49df-81c3-b8532f3d6745.
   The if statement that checks if the finalize can be safely deferred
   therefore no longer matches. This PR contains a fix so finalize is
   defered again.
   
   Rohit: I made a boo-boo by force pushing and trying to rebash on @RPDiep 's 
repo/branch. Submitting his commit on his behalf against 4.11 branch. Sorry 
@RPDiep /cc @wido.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

rhtyd closed pull request #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):



 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2893: ApiServer: signature v3 to accept more formats

[GitBox]

DaanHoogland commented on issue #2893: ApiServer: signature v3 to accept more 
formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-433844508
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2793: Destroyvm also removes volumes

[GitBox]

DaanHoogland commented on issue #2793: Destroyvm also removes volumes
URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-433843707
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

[GitBox]

DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: 
Certificate ownership
URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-433840933
 
 
   @rhtyd 
   So, unfortunately we are not able to test this on a 4.11 setup.
   
   The setup is kvm. Anything more you want to know?
   
   It is possible that we deployed our management servers at the same time. I 
will try to give the first management server the time to start before starting 
the secondary one. I will try this and report the results.
   
   A question: When are those certificates generated? Is it sufficient to 
restart the management server to newly generate the certificates?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] svenvogel commented on issue #2929: add public IP range to domain fails in the inital setup (UI Problem)

[GitBox]

svenvogel commented on issue #2929: add public IP range to domain fails in the 
inital setup (UI Problem)
URL: https://github.com/apache/cloudstack/issues/2929#issuecomment-433838767
 
 
   @nvazquez Can you check this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] svenvogel edited a comment on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7

[GitBox]

svenvogel edited a comment on issue #2896: add exitcode / distribution 
detection and remove export CGROUP_DAEMON for RHEL7/CentOS7
URL: https://github.com/apache/cloudstack/pull/2896#issuecomment-433834200
 
 
   hi @rhtyd yes i can do that... let me check, normally it should not have no 
value if you follow the if -> unknown...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] svenvogel commented on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7

[GitBox]

svenvogel commented on issue #2896: add exitcode / distribution detection and 
remove export CGROUP_DAEMON for RHEL7/CentOS7
URL: https://github.com/apache/cloudstack/pull/2896#issuecomment-433834200
 
 
   hi @rhtyd yes i can do that... let me check


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido opened a new issue #2978: Router aggregate timeout does not seem to be honored

[GitBox]

wido opened a new issue #2978: Router aggregate timeout does not seem to be 
honored
URL: https://github.com/apache/cloudstack/issues/2978
 
 
   # ISSUE TYPE
* Bug Report
   
   # COMPONENT NAME
   ~~~
   Virtual Router
   ~~~
   
   # CLOUDSTACK VERSION
   ~~~
   4.11.1
   ~~~
   
   # CONFIGURATION
   ~~~
   router.aggregation.command.each.timeout = 6000
   ~~~
   
   # OS / ENVIRONMENT
   Basic Networking
   
   
   # SUMMARY
   Router gets killed on Start due to timeout before configuration has completed
   
   
   # STEPS TO REPRODUCE
   ~~~
   Deploy a Virtual Router with ~600 DHCP entries
   ~~~
   
   # EXPECTED RESULTS
   ~~~
   VR should deploy properly
   ~~~
   
   # ACTUAL RESULTS
   ~~~
   Timeout was reached
   ~~~
   
   
   
   The story is that during a upgrade from 4.10 to 4.11.1 we (PCextreme) 
encountered a problem that Virtual Routers would not start.
   
   During their Start and configuration they ran into a timeout which caused 
the VR to get killed.
   
   For example we saw in the logs:
   
   
   2018-10-29 06:38:07,041 DEBUG 
[resource.virtualnetwork.VirtualRoutingResource] (agentRequest-Handler-6:null) 
(logid:ded92662) Aggregate action timeout in seconds is 665
   2018-10-29 06:38:07,041 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-6:null) (logid:ded92662) Creating file in VR, with ip: 
169.254.3.223, file: VR-d09aa357-27e3-4176-a283-9a7afedbae27.cfg
   2018-10-29 06:38:07,464 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-6:null) (logid:ded92662) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.3.223 -c /var/cache/cloud/VR-d09aa357-27e3-4176-a283-9a7afedbae27.cfg 
   2018-10-29 06:38:07,466 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-6:null) (logid:ded92662) Executing while with timeout : 
665700
   
   
   So in this case the timeout was 665 seconds, about 11 minutes.
   
   We tried to increase *router.aggregation.command.each.timeout* both on the 
Management Server side and in *agent.properties*, but that did not seem to make 
any change.
   
   For each DHCP entry a ~1 second timeout seems to be calculated. This VR has 
*609* DHCP entries:
   
   
   root@r-32727-VM:~# wc -l /etc/dhcphosts.txt 
   609 /etc/dhcphosts.txt
   root@r-32727-VM:~#
   
   
   10 minutes is a long time, that is something that would need improving as 
well, but apart from that I just would not start.
   
   My colleague created PR #2977 as this fixed the issue for us. So we need to 
investigate if his fix is the proper one or that the (default) timeout should 
be increased.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2928: Migrating VM from ISO failures

[GitBox]

wido commented on issue #2928: Migrating VM from ISO failures
URL: https://github.com/apache/cloudstack/pull/2928#issuecomment-433813641
 
 
   If I read the code correctly and what I'm missing in the description is that 
this only happens with VMs which were deployed using Direct Downloaded 
templates, correct?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

wido commented on issue #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433811156
 
 
   @rhtyd At the moment @RPDiep is offline after a long night of debugging this 
issue.
   
   I will ask him to rebase against 4.11 soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov edited a comment on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available

[GitBox]

borisstoyanov edited a comment on issue #2890: KVMHAMonitor thread blocks 
indefinitely while NFS not available
URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-433810696
 
 
   hi @csquire @somejfn, thanks for this issue! 
   
   I think it's correct that the host goes into 'Down' state after loosing it's 
grip on the storage, since this is basically making it non-operative. Going 
into 'Disconnected' state would only mean the connection between management and 
host is compromised. 
   
   On the other hand duplicated VMs is definitely something that needs to get 
addressed, prior marking the host as 'Down' when we have a VM-HA enabled. Just 
to be sure, can you please confirm you don't see these duplicated VMs on a non 
VM-ha enabled instances? I'd like to narrow down this issue and make sure it's 
in the VM-HA logic. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available

[GitBox]

borisstoyanov commented on issue #2890: KVMHAMonitor thread blocks indefinitely 
while NFS not available
URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-433810696
 
 
   hi @csquire @somejfn, thanks for this issue! 
   
   I think it's correct that the host goes into 'Down' state after loosing it's 
grip on the storage, since this is basically making it inoperable. Going into 
'Disconnected' state would only mean the connection between management and host 
is compromised. 
   
   On the other hand duplicated VMs is definitely something that needs to get 
addressed, prior marking the host as 'Down' when we have a VM-HA enabled. Just 
to be sure, can you please confirm you don't see these duplicated VMs on a non 
VM-ha enabled instances? I'd like to narrow down this issue and make sure it's 
in the VM-HA logic. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

rhtyd commented on a change in pull request #2977: Defer was broken in VR 
because of json name change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#discussion_r228817465
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/update_config.py
 ##
 @@ -52,7 +52,7 @@ def process_file():
 qf.setFile(sys.argv[1])
 qf.load(None)
 # These can be safely deferred, dramatically speeding up loading times
-if not (os.environ.get('DEFER_CONFIG', False) and sys.argv[1] in 
('vm_dhcp_entry.json', 'vm_metadata.json')):
+if not (os.environ.get('DEFER_CONFIG', False) and ('vm_dhcp_entry.json' in 
sys.argv[1] or 'vm_metadata.json' in sys.argv[1])):
 
 Review comment:
   I'm okay with this changes, however this can be changed to `startswith`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

rhtyd commented on issue #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433808773
 
 
   Ping @RPDiep @wido @GabrielBrascher we would want to cut RC4 soon, it would 
be great to include this bugfix please send this against 4.11 soon, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2583: CPU cores per socket setting not functional

[GitBox]

rhtyd commented on issue #2583: CPU cores per socket setting not functional
URL: https://github.com/apache/cloudstack/issues/2583#issuecomment-433802974
 
 
   Let's revisit this after 4.11.2.0 gets released. /cc @DagSonsteboSB 
@PaulAngus 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7

[GitBox]

rhtyd commented on issue #2896: add exitcode / distribution detection and 
remove export CGROUP_DAEMON for RHEL7/CentOS7
URL: https://github.com/apache/cloudstack/pull/2896#issuecomment-433802857
 
 
   @svenvogel can you initiate the variable `distro` you're using (perhaps to 
None or negative?), the error was because the variable was not defined in the 
scope.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes

[GitBox]

rhtyd commented on a change in pull request #1448: CLOUDSTACK-9315: Removed 
unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#discussion_r228812528
 
 

 ##
 File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql
 ##
 @@ -34,4 +34,7 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, 
`rule`, `permission`,
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 3, 'moveNetworkAclItem', 'ALLOW', 
302) ON DUPLICATE KEY UPDATE rule=rule;
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 4, 'moveNetworkAclItem', 'ALLOW', 
260) ON DUPLICATE KEY UPDATE rule=rule;
 
-UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
\ No newline at end of file
+UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
+
+-- PR#1448 update description of 
'execute.in.sequence.network.element.commands' parameter to reflect an unused 
command that has been removed. The removed class command is 'UserDataCommand'.
+update configuration set description = 'If set to true, DhcpEntryCommand, 
SavePasswordCommand, VmDataCommand will be synchronized on the agent side. If 
set to false, these commands become asynchronous. Default value is false.' 
where name = 'execute.in.sequence.network.element.commands'; 
 
 Review comment:
   @rafaelweingartner not the comment is to rewrite the update statement as:
   ```
   UPDATE `cloud`.`configuration` SET ...;
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes

[GitBox]

rhtyd commented on a change in pull request #1448: CLOUDSTACK-9315: Removed 
unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#discussion_r228812528
 
 

 ##
 File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql
 ##
 @@ -34,4 +34,7 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, 
`rule`, `permission`,
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 3, 'moveNetworkAclItem', 'ALLOW', 
302) ON DUPLICATE KEY UPDATE rule=rule;
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 4, 'moveNetworkAclItem', 'ALLOW', 
260) ON DUPLICATE KEY UPDATE rule=rule;
 
-UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
\ No newline at end of file
+UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
+
+-- PR#1448 update description of 
'execute.in.sequence.network.element.commands' parameter to reflect an unused 
command that has been removed. The removed class command is 'UserDataCommand'.
+update configuration set description = 'If set to true, DhcpEntryCommand, 
SavePasswordCommand, VmDataCommand will be synchronized on the agent side. If 
set to false, these commands become asynchronous. Default value is false.' 
where name = 'execute.in.sequence.network.element.commands'; 
 
 Review comment:
   @rafaelweingartner not the comment is to rewrite the update statement as 
`UPDATE `cloud`.`configuration` SET ...`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2928: Migrating VM from ISO failures

[GitBox]

rhtyd commented on issue #2928: Migrating VM from ISO failures
URL: https://github.com/apache/cloudstack/pull/2928#issuecomment-433801221
 
 
   Test LGTM, can you review - @rafaelweingartner @wido @GabrielBrascher 
@nvazquez thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

rhtyd commented on issue #2977: Defer was broken in VR because of json name 
change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433800860
 
 
   Thanks @RPDiep can you change the branch to 4.11 and rebase your branch 
against 4.11?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2909: debian does not have libvirt-bin it has libvirt

[GitBox]

rhtyd closed issue #2909: debian does not have libvirt-bin it has libvirt
URL: https://github.com/apache/cloudstack/issues/2909
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: kvm: use libvirtd as service name for all distributions (#2925)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 8738ca7  kvm: use libvirtd as service name for all distributions 
(#2925)
8738ca7 is described below

commit 8738ca75b1a416103ec39533f035598f9d2098db
Author: Rohit Yadav 
AuthorDate: Mon Oct 29 11:55:28 2018 +0530

kvm: use libvirtd as service name for all distributions (#2925)

Since we support only Ubuntu 16.04+ on master/4.12+, we can now use
the libvirt service name `libvirtd` for all distributions. This also
fixes an optional package name for libvirtd installation on Debian 9+.
Fixes #2909

Signed-off-by: Rohit Yadav 
---
 debian/control  | 2 +-
 debian/rules| 3 ---
 .../wrapper/LibvirtPostCertificateRenewalCommandWrapper.java| 6 +-
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/debian/control b/debian/control
index 2fc5af6..7ef3c1e 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@ Description: CloudStack server library
 
 Package: cloudstack-agent
 Architecture: all
-Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | 
java8-runtime | openjdk-9-jre-headless, cloudstack-common (= 
${source:Version}), lsb-base (>= 9), libcommons-daemon-java, openssh-client, 
qemu-kvm (>= 2.5), libvirt-bin (>= 1.3), uuid-runtime, iproute2, ebtables, 
vlan, ipset, python-libvirt, ethtool, iptables, lsb-release, aria2
+Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | 
java8-runtime | openjdk-9-jre-headless, cloudstack-common (= 
${source:Version}), lsb-base (>= 9), libcommons-daemon-java, openssh-client, 
qemu-kvm (>= 2.5), libvirt-bin (>= 1.3) | libvirt-daemon-system (>= 3.0), 
uuid-runtime, iproute2, ebtables, vlan, ipset, python-libvirt, ethtool, 
iptables, lsb-release, aria2
 Recommends: init-system-helpers
 Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps, cloud-agent-scripts
 Description: CloudStack agent
diff --git a/debian/rules b/debian/rules
index 4ac524b..07f5715 100755
--- a/debian/rules
+++ b/debian/rules
@@ -43,9 +43,6 @@ override_dh_auto_install:
install -D plugins/hypervisors/kvm/target/dependencies/* 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
 
install -d -m0755 debian/$(PACKAGE)-agent/lib/systemd/system
-   # Fix libvirt service name for Debian/Ubuntu
-   sed -i 's/Requires=libvirtd.service/Requires=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
-   sed -i 's/After=libvirtd.service/After=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
install -m0644 packaging/systemd/$(PACKAGE)-agent.service 
debian/$(PACKAGE)-agent/lib/systemd/system/$(PACKAGE)-agent.service
install -m0644 packaging/systemd/$(PACKAGE)-agent.default 
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
 
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
index 2802d42..5f8e2ca 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
@@ -38,11 +38,7 @@ public final class 
LibvirtPostCertificateRenewalCommandWrapper extends CommandWr
 if (command != null) {
 final int timeout = 3;
 Script script = new Script(true, "service", timeout, s_logger);
-if ("Ubuntu".equals(serverResource.getHostDistro())) {
-script.add("libvirt-bin");
-} else {
-   script.add("libvirtd");
-}
+script.add("libvirtd");
 script.add("restart");
 script.execute();
 return new SetupCertificateAnswer(true);

[GitHub] rhtyd closed pull request #2925: kvm: use libvirtd as service name for all distributions

[GitBox]

rhtyd closed pull request #2925: kvm: use libvirtd as service name for all 
distributions
URL: https://github.com/apache/cloudstack/pull/2925
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/debian/control b/debian/control
index 2fc5af62749..7ef3c1eab6a 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@ Description: CloudStack server library
 
 Package: cloudstack-agent
 Architecture: all
-Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | 
java8-runtime | openjdk-9-jre-headless, cloudstack-common (= 
${source:Version}), lsb-base (>= 9), libcommons-daemon-java, openssh-client, 
qemu-kvm (>= 2.5), libvirt-bin (>= 1.3), uuid-runtime, iproute2, ebtables, 
vlan, ipset, python-libvirt, ethtool, iptables, lsb-release, aria2
+Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | 
java8-runtime | openjdk-9-jre-headless, cloudstack-common (= 
${source:Version}), lsb-base (>= 9), libcommons-daemon-java, openssh-client, 
qemu-kvm (>= 2.5), libvirt-bin (>= 1.3) | libvirt-daemon-system (>= 3.0), 
uuid-runtime, iproute2, ebtables, vlan, ipset, python-libvirt, ethtool, 
iptables, lsb-release, aria2
 Recommends: init-system-helpers
 Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps, cloud-agent-scripts
 Description: CloudStack agent
diff --git a/debian/rules b/debian/rules
index 4ac524b5f4b..07f5715cbb7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -43,9 +43,6 @@ override_dh_auto_install:
install -D plugins/hypervisors/kvm/target/dependencies/* 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
 
install -d -m0755 debian/$(PACKAGE)-agent/lib/systemd/system
-   # Fix libvirt service name for Debian/Ubuntu
-   sed -i 's/Requires=libvirtd.service/Requires=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
-   sed -i 's/After=libvirtd.service/After=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
install -m0644 packaging/systemd/$(PACKAGE)-agent.service 
debian/$(PACKAGE)-agent/lib/systemd/system/$(PACKAGE)-agent.service
install -m0644 packaging/systemd/$(PACKAGE)-agent.default 
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
 
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
index 2802d42c1c2..5f8e2ca7a4e 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java
@@ -38,11 +38,7 @@ public Answer execute(final PostCertificateRenewalCommand 
command, final Libvirt
 if (command != null) {
 final int timeout = 3;
 Script script = new Script(true, "service", timeout, s_logger);
-if ("Ubuntu".equals(serverResource.getHostDistro())) {
-script.add("libvirt-bin");
-} else {
-   script.add("libvirtd");
-}
+script.add("libvirtd");
 script.add("restart");
 script.execute();
 return new SetupCertificateAnswer(true);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] RPDiep opened a new pull request #2977: Defer was broken in VR because of json name change. Fix if statement.

[GitBox]

RPDiep opened a new pull request #2977: Defer was broken in VR because of json 
name change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977
 
 
   ## Description
   
   After upgrade from CS 4.10 to CS 4.11, multiple VRs did not start through.  
   It did not properly defer the finalize config in `update_config.py`.  
   Apparently, the json files are now called differently: where it used to be 
`vm_dhcp_entry.json` it now has a uuid added, for example 
`vm_metadata.json.4d727b6e-2b48-49df-81c3-b8532f3d6745`.  
   The if statement that checks if the finalize can be safely deferred 
therefore no longer matches.  
   This PR contains a fix so finalize is defered again.
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   We've live patched this on several clusters, which are now running without 
issues.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services