[GitHub] [cloudstack] ustcweizhou commented on issue #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard

2019-05-17 Thread GitBox
ustcweizhou commented on issue #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard URL: https://github.com/apache/cloudstack/pull/3336#issuecomment-493649301 LGTM This is an automated

[GitHub] [cloudstack] smlshn opened a new issue #3337: the toolbar in Instances page not reset to its initial state after any multiSelectAction completed.

2019-05-17 Thread GitBox
smlshn opened a new issue #3337: the toolbar in Instances page not reset to its initial state after any multiSelectAction completed. URL: https://github.com/apache/cloudstack/issues/3337 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ #

[GitHub] [cloudstack] smlshn opened a new pull request #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard

2019-05-17 Thread GitBox
smlshn opened a new pull request #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard URL: https://github.com/apache/cloudstack/pull/3336 ## Description Adds functionality to sort the data that is available on each in the deploy VM wizard's

[GitHub] [cloudstack] smlshn edited a comment on issue #3050: Sort list of templates in the deploy VM wizard

2019-05-17 Thread GitBox
smlshn edited a comment on issue #3050: Sort list of templates in the deploy VM wizard URL: https://github.com/apache/cloudstack/issues/3050#issuecomment-493619732 I write function to sort any array by given key and I made required changes to sort the data available on each step by

[GitHub] [cloudstack] smlshn commented on issue #3050: Sort list of templates in the deploy VM wizard

2019-05-17 Thread GitBox
smlshn commented on issue #3050: Sort list of templates in the deploy VM wizard URL: https://github.com/apache/cloudstack/issues/3050#issuecomment-493619732 I write function to sort any array by given key and I made required changes to sort the data available on each step by their

[GitHub] [cloudstack] ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-17 Thread GitBox
ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493587493 document needs to be updated as well.

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3312: 'sed -i' need postfix on mac

2019-05-17 Thread GitBox
GabrielBrascher commented on a change in pull request #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#discussion_r285275149 ## File path: tools/apidoc/build-apidoc.sh ## @@ -61,8 +60,8 @@ set -e cp "$thisdir"/*.java . cp

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3335: kvm: disable cpu features if feature starts with '-'

2019-05-17 Thread GitBox
ustcweizhou opened a new pull request #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335 When I use SandyBridge as custom cpu in my testing, vm failed to start due to following error: ``` org.libvirt.LibvirtException:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3312: 'sed -i' need postfix on mac

2019-05-17 Thread GitBox
GabrielBrascher commented on a change in pull request #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#discussion_r285273501 ## File path: tools/apidoc/build-apidoc.sh ## @@ -61,8 +60,8 @@ set -e cp "$thisdir"/*.java . cp

[GitHub] [cloudstack] nvazquez opened a new issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers

2019-05-17 Thread GitBox
nvazquez opened a new issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers URL: https://github.com/apache/cloudstack/issues/3334 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Network, VPC ~~~ # CLOUDSTACK VERSION ~~~

[GitHub] [cloudstack] ustcweizhou commented on issue #3296: [4.13] noVNC console

2019-05-17 Thread GitBox
ustcweizhou commented on issue #3296: [4.13] noVNC console URL: https://github.com/apache/cloudstack/pull/3296#issuecomment-493468221 @DennisKonrad do you get error on console ? if so, could you please attach a screenshot ? or do you still see the native console ?

[GitHub] [cloudstack] GabrielBrascher removed a comment on issue #3329: Fix: Migration target has no matching tags

2019-05-17 Thread GitBox
GabrielBrascher removed a comment on issue #3329: Fix: Migration target has no matching tags URL: https://github.com/apache/cloudstack/pull/3329#issuecomment-492644774 @blueoragutan package This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436966 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436754 @blueorangutan test This is an automated message

[GitHub] [cloudstack] rhtyd commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436691 @blueorangutan package This is an automated message

[GitHub] [cloudstack] DennisKonrad commented on issue #3296: [4.13] noVNC console

2019-05-17 Thread GitBox
DennisKonrad commented on issue #3296: [4.13] noVNC console URL: https://github.com/apache/cloudstack/pull/3296#issuecomment-493434409 @ustcweizhou So the steps you provided. We have the setup like you described it already in place. Like i wrote: (1) consoleproxy.url.domain is

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC

2019-05-17 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r285098627 ## File path:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC

2019-05-17 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r285093475 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -487,6 +490,14 @@

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC

2019-05-17 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r285098627 ## File path:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC

2019-05-17 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r285093153 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql ## @@

[GitHub] [cloudstack] blueorangutan commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493420910 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2741

[GitHub] [cloudstack] blueorangutan commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493416072 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493415891 @blueorangutan package This is an automated message

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan removed a comment on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493377182 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd removed a comment on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493377047 @blueorangutan package This is an automated

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan removed a comment on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493381478 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd removed a comment on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493381419 @blueorangutan package This is an automated

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan removed a comment on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493381399 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2739

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan commented on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493381478 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan commented on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493381399 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2739

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
blueorangutan commented on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493377182 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd commented on issue #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493377047 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] rhtyd commented on issue #3330: server: add newline to the SSH key content

2019-05-17 Thread GitBox
rhtyd commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493375746 @ustcweizhou opened a new PR with more explaination here: https://github.com/apache/cloudstack/pull/ I also included a fix to

[GitHub] [cloudstack] rhtyd opened a new pull request #3333: server: save SSH keypair exactly as generated by ssh-keygen

2019-05-17 Thread GitBox
rhtyd opened a new pull request #: server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/ On first startup, the management server creates and saves a random ssh keypair using `ssh-keygen` in the database. The previous code

[GitHub] [cloudstack] rhtyd commented on issue #3330: server: add newline to the SSH key content

2019-05-17 Thread GitBox
rhtyd commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493373298 I've developed a better fix, will send a new PR. This is an automated

[GitHub] [cloudstack] rhtyd closed pull request #3330: server: add newline to the SSH key content

2019-05-17 Thread GitBox
rhtyd closed pull request #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330 This is an automated message from the Apache Git Service. To respond to the message, please log