[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645161483 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645161040 Packaging result: ✖centos7 ✖debian. JID-1406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
rhtyd commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645161070 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-645160865 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-645160556 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645157656 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated (c1fbe9e -> 2792354)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from c1fbe9e dashboard: fix lint issue add 2792354 infra: Adding rolling maintenance (#424) No new revisions were added by this update. Summary of changes: src/config/section/infra/clusters.js | 13 + src/config/section/infra/hosts.js| 16 src/config/section/infra/pods.js | 13 + src/config/section/infra/zones.js| 13 + src/locales/en.json | 1 + 5 files changed, 56 insertions(+)
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
davidjumani commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645157322 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-645156135 Packaging result: ✖centos7 ✖debian. JID-1405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
rhtyd commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645152732 @davidjumani can you merge latest master and try packaging again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645152305 Packaging result: ✖centos7 ✖debian. JID-1404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-645148724 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd opened a new pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd opened a new pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150 Dummy commit to run health checks on 4.14 branch - DO NOT MERGE This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-645148554 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645147165 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
davidjumani commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645146799 @GabrielBrascher @rhtyd comments addressed! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4140: Adding showunique parameter to list templates and isos
davidjumani edited a comment on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645146799 @GabrielBrascher @rhtyd comments addressed! @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645142303 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645142525 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645127316 Packaging result: ✔centos7 ✔debian. JID-1403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645120776 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645120663 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645119340 Packaging result: ✖centos7 ✔debian. JID-1402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-cloudmonkey] branch master updated: Makefile: Statically building the binary to not depend on gcc compiler (#59)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git
The following commit(s) were added to refs/heads/master by this push:
new 43a008c Makefile: Statically building the binary to not depend on gcc
compiler (#59)
43a008c is described below
commit 43a008cdaf012ec4819be7a157027f0680a4f174
Author: Khosrow Moossavi
AuthorDate: Tue Jun 16 22:57:58 2020 -0400
Makefile: Statically building the binary to not depend on gcc compiler (#59)
This is to statically build the cmk binary. It means it doesn't depend on
gcc being present to work. The use case is that the cmk binary without this
won't work in any alpine docker image.
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 36a4205..014dc98 100644
--- a/Makefile
+++ b/Makefile
@@ -26,7 +26,7 @@ PKGS = $(or $(PKG),$(shell $(GO) list ./... | grep -v
"^$(PACKAGE)/vendor/")
TESTPKGS = $(shell $(GO) list -f '{{ if or .TestGoFiles .XTestGoFiles }}{{
.ImportPath }}{{ end }}' $(PKGS))
GIT_SHA = $(shell git rev-parse --short HEAD)
-GO = go
+GO = CGO_ENABLED=0 go
GODOC = godoc
GOFMT = gofmt
TIMEOUT = 15
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645113385 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645113084 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan removed a comment on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645108776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.14 updated: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.14 by this push:
new 0a034da Merge remote-tracking branch 'origin/4.13' into 4.14
0a034da is described below
commit 0a034da81cdcce51d3ea5d0bcaaa0a05d73cab97
Author: Rohit Yadav
AuthorDate: Wed Jun 17 08:06:19 2020 +0530
Merge remote-tracking branch 'origin/4.13' into 4.14
Fixes build failure due to forward merge
Signed-off-by: Rohit Yadav
---
server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java
b/server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java
index 86ac9f5..881c37d 100644
--- a/server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java
+++ b/server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java
@@ -1755,7 +1755,7 @@ public class VpcManagerImpl extends ManagerBase
implements VpcManager, VpcProvis
return true;
}
-restartVPCNetworks(vpcId, callerAccount, callerUser, cleanUp);
+restartVPCNetworks(vpcId, callerAccount, user, cleanUp);
s_logger.debug("Starting VPC " + vpc + " as a part of VPC restart
process without cleanup");
if (!startVpc(vpcId, false)) {
[cloudstack] branch master updated (090cbf4 -> 2a82fb9)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 090cbf4 Merge remote-tracking branch 'origin/4.14' add 0a034da Merge remote-tracking branch 'origin/4.13' into 4.14 add 2a82fb9 Merge remote-tracking branch 'origin/4.14' No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-64502 Packaging result: ✖centos7 ✖debian. JID-1401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
rhtyd commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-645109835 @ggoodrich-ipp could you check if `quiescevm` is true in the `createSnapshot` API? Would that be better than doing it by default? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-645109075 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-645108796 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)
rhtyd commented on pull request #4069: URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-645108680 @weizhouapache can you check and close, we used your commits as reference and included here for consolidated fixes and testing - https://github.com/apache/cloudstack/pull/4068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645108776 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-645108465 @RodrigoDLopez I'm not sure why the packaging failed, I'll kick again @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4085: Fix duplicate user entries for vpn usage
rhtyd closed pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)
rhtyd commented on a change in pull request #4099: URL: https://github.com/apache/cloudstack/pull/4099#discussion_r441244282 ## File path: pom.xml ## @@ -164,7 +164,7 @@ 3.3.3_1 4.0.1 8.5.47 -1.0.0-build222 + trilead-ssh2-build-217-jenkins-17 Review comment: One issue it seems Jenkins forked the build-217 than latest build-222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled
rhtyd commented on a change in pull request #4148:
URL: https://github.com/apache/cloudstack/pull/4148#discussion_r441243375
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -1187,6 +1189,16 @@ private VolumeVO orchestrateResizeVolume(long volumeId,
long currentSize, long n
if (currentSize != newSize &&
_volsDao.getHypervisorType(volume.getId()) == HypervisorType.XenServer &&
!userVm.getState().equals(State.Stopped)) {
throw new InvalidParameterValueException(errorMsg);
}
+
+/* Do not resize volume of running vm on KVM host if host is not
Up or not Enabled */
+if (currentSize != newSize && userVm.getState() == State.Running
&& userVm.getHypervisorType() == HypervisorType.KVM) {
+HostVO host = _hostDao.findById(userVm.getHostId());
+if (host.getStatus() != Status.Up) {
Review comment:
@ustcweizhou should you do a null check, what if the host was removed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-645105666 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4132: Fix delete network with no services
blueorangutan removed a comment on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-645087992 Trillian test result (tid-1738) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 65826 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4132-t1738-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 66 look OK, 11 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 197.45 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 186.36 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 265.79 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py test_04_extract_template | `Failure` | 128.29 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 138.57 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4132: Fix delete network with no services
rhtyd commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-645105352 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 090cbf4a44779e52274783a9f0e194b5a0650552 Merge: a279d5c c943155 Author: Rohit Yadav AuthorDate: Wed Jun 17 07:38:49 2020 +0530 Merge remote-tracking branch 'origin/4.14' .../src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 11 +++ 1 file changed, 11 insertions(+)
[GitHub] [cloudstack] rhtyd closed issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
rhtyd closed issue #3816: URL: https://github.com/apache/cloudstack/issues/3816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (a279d5c -> 090cbf4)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from a279d5c logging: Logging framework to use only log4j (#4003) add 88d51ce server: Restarting all networks that needs a restart in a VPC (#4007) add c943155 Merge remote-tracking branch 'origin/4.13' into 4.14 new 090cbf4 Merge remote-tracking branch 'origin/4.14' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 11 +++ 1 file changed, 11 insertions(+)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit c94315545f1dcb725906290ec6accbc8c10b5b78 Merge: b54d19b 88d51ce Author: Rohit Yadav AuthorDate: Wed Jun 17 07:38:14 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 .../src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 11 +++ 1 file changed, 11 insertions(+)
[cloudstack] branch 4.14 updated (b54d19b -> c943155)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b54d19b server: fix TransactionLegacy DB connection leaks due to DB switching by B thread (#4121) add 88d51ce server: Restarting all networks that needs a restart in a VPC (#4007) new c943155 Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 11 +++ 1 file changed, 11 insertions(+)
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r441239286
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -3423,12 +3432,22 @@ else if (!template.isPublicTemplate() &&
caller.getType() != Account.ACCOUNT_TYP
return uniqueTmplPair;
}
List uniqueTmpls = uniqueTmplPair.first();
-String[] tzIds = new String[uniqueTmpls.size()];
int i = 0;
-for (TemplateJoinVO v : uniqueTmpls) {
-tzIds[i++] = v.getTempZonePair();
+List vrs = null;
+if (showUnique) {
+Long[] tzIds = new Long[uniqueTmpls.size()];
Review comment:
@davidjumani nit - let's refactor and use a more modern form of writing
code, the current code looks less like Java, more like C/C++; can be written as:
```
Long[] templateIds = uniqueTmpls.stream().map(template ->
template.getId()).toArray(Long[]::new);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r441234854
##
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##
@@ -481,4 +488,14 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso)
{
return new Pair, Integer>(objects, count);
}
+@Override
+public List findByDistinctIds(Long... ids) {
+if (ids.length == 0) {
Review comment:
@davidjumani make it defensive, for example do a null check on ids
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-645097436 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin
rhtyd commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-645097148 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated (5054766 -> 88d51ce)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5054766 server: Submitting multiple dynamic VM Scaling API commands for the same instance can result in two usage events in the same second causing a compound key violation in usage service (#3991) add 88d51ce server: Restarting all networks that needs a restart in a VPC (#4007) No new revisions were added by this update. Summary of changes: .../src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 11 +++ 1 file changed, 11 insertions(+)
[GitHub] [cloudstack] rhtyd merged pull request #4003: Logging framework to use only log4j
rhtyd merged pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated: logging: Logging framework to use only log4j (#4003)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new a279d5c logging: Logging framework to use only log4j (#4003) a279d5c is described below commit a279d5c453c6e6f00ab937fa3e6745fdf68e82b2 Author: harikrishna-patnala AuthorDate: Wed Jun 17 07:11:23 2020 +0530 logging: Logging framework to use only log4j (#4003) Currently CloudStack is using logging frameworks as log4j and Java util logging, logging wrappers as slf4j and Apache common logging. Here changes are to made it uniform, using only log4j framework. Removed Java util logging, slf4j and Apache common logging. --- agent/src/main/java/com/cloud/agent/Agent.java | 2 +- .../api/command/admin/account/LockAccountCmd.java | 2 +- .../admin/router/UpgradeRouterTemplateCmd.java | 2 +- .../api/command/admin/user/GetUserKeysCmd.java | 2 +- .../user/vmsnapshot/CreateVMSnapshotCmd.java | 2 +- .../user/vmsnapshot/RevertToVMSnapshotCmd.java | 2 +- .../org/apache/cloudstack/context/LogContext.java | 2 +- client/conf/commons-logging.properties.in | 30 -- .../java/org/apache/cloudstack/ServerDaemon.java | 5 ++-- .../com/cloud/agent/manager/AgentManagerImpl.java | 7 ++--- .../cloud/agent/manager/DirectAgentAttache.java| 2 +- .../framework/jobs/impl/AsyncJobManagerImpl.java | 2 +- framework/managed-context/pom.xml | 5 ++-- .../managed/context/ManagedContextRunnable.java| 5 ++-- .../context/impl/DefaultManagedContext.java| 9 +++ .../managed/threadlocal/ManagedThreadLocal.java| 5 ++-- .../lifecycle/CloudStackExtendedLifeCycle.java | 9 +++ .../spring/lifecycle/registry/DumpRegistry.java| 7 +++-- .../lifecycle/registry/ExtensionRegistry.java | 7 +++-- .../lifecycle/registry/RegistryLifecycle.java | 9 +++ .../module/factory/CloudStackSpringContext.java| 7 +++-- .../model/impl/DefaultModuleDefinitionSet.java | 13 +- .../web/CloudStackContextLoaderListener.java | 5 ++-- packaging/centos7/cloud.spec | 3 +-- pom.xml| 11 usage/pom.xml | 8 -- utils/pom.xml | 8 -- .../utils/backoff/impl/ConstantTimeBackoff.java| 7 ++--- .../java/com/cloud/utils/xmlobject/XmlObject.java | 2 +- .../contrib/ssl/EasySSLProtocolSocketFactory.java | 5 ++-- .../contrib/ssl/EasyX509TrustManager.java | 7 +++-- .../backoff/impl/ConstantTimeBackoffTest.java | 5 ++-- 32 files changed, 62 insertions(+), 135 deletions(-) diff --git a/agent/src/main/java/com/cloud/agent/Agent.java b/agent/src/main/java/com/cloud/agent/Agent.java index 7e5e295..a9da421 100644 --- a/agent/src/main/java/com/cloud/agent/Agent.java +++ b/agent/src/main/java/com/cloud/agent/Agent.java @@ -51,7 +51,7 @@ import org.apache.cloudstack.utils.security.KeyStoreUtils; import org.apache.commons.collections.CollectionUtils; import org.apache.commons.io.FileUtils; import org.apache.log4j.Logger; -import org.slf4j.MDC; +import org.apache.log4j.MDC; import com.cloud.agent.api.AgentControlAnswer; import com.cloud.agent.api.AgentControlCommand; diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java index 05b370a..d02902d 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java @@ -16,7 +16,7 @@ // under the License. package org.apache.cloudstack.api.command.admin.account; -import java.util.logging.Logger; +import org.apache.log4j.Logger; import org.apache.cloudstack.api.APICommand; import org.apache.cloudstack.api.ApiConstants; diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java index 65d26cc..fedc314 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java @@ -17,7 +17,7 @@ package org.apache.cloudstack.api.command.admin.router; import java.util.List; -import java.util.logging.Logger; +import org.apache.log4j.Logger; import org.apache.cloudstack.api.APICommand; import org.apache.cloudstack.api.ApiCommandJobType; diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java
[GitHub] [cloudstack] rhtyd merged pull request #4007: Restarting all networks that needs a restart in a VPC
rhtyd merged pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4132: Fix delete network with no services
rhtyd commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-645096571 @nvazquez you can check yourself: ``` $ cd test/integration/smoke $ grep updateZone -R . ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-645087992 Trillian test result (tid-1738) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 65826 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4132-t1738-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 66 look OK, 11 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 197.45 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 186.36 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 265.79 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py test_04_extract_template | `Failure` | 128.29 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 138.57 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-645075328 Trillian test result (tid-1736) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 63413 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4003-t1736-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-645005027 Trillian test result (tid-1741) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46789 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4071-t1741-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.94 | test_kubernetes_supported_versions.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4132: Fix delete network with no services
nvazquez commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-644928335 @borisstoyanov @andrijapanicsb @rhtyd I've checked the test environment and it ended up with a disabled zone and no system VMs, had to manually enable the zone back. Do you remember which test caused this failure? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4085: Fix duplicate user entries for vpn usage
RodrigoDLopez commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-644924821 Hello guys, this is an interesting one. Can I get some reviews here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: dashboard: fix lint issue
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new c1fbe9e dashboard: fix lint issue
c1fbe9e is described below
commit c1fbe9e30b3a321f119ecd6e4f016ce87d579f0a
Author: Rohit Yadav
AuthorDate: Tue Jun 16 23:38:13 2020 +0530
dashboard: fix lint issue
Signed-off-by: Rohit Yadav
---
src/views/dashboard/CapacityDashboard.vue | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/views/dashboard/CapacityDashboard.vue
b/src/views/dashboard/CapacityDashboard.vue
index 4820d12..593c7a1 100644
--- a/src/views/dashboard/CapacityDashboard.vue
+++ b/src/views/dashboard/CapacityDashboard.vue
@@ -54,16 +54,16 @@
:key="stat.type">
-
- {{ $t(ts[stat.name]) }}
-
-
+
+{{ $t(ts[stat.name]) }}
+
+
{{ displayData(stat.name,
stat.capacityused) }} / {{ displayData(stat.name, stat.capacitytotal)
}}
@@ -96,7 +96,7 @@
-{{ $t('label.view') + ' ' + $t('label.events') }}
+ {{ $t('label.view') + ' ' + $t('label.events') }}
[cloudstack-primate] branch master updated: views: fix dashboard and autogenview css issues
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 89c6745 views: fix dashboard and autogenview css issues
89c6745 is described below
commit 89c674553ec2a3043caf6cafef61a8ef378f0d10
Author: Rohit Yadav
AuthorDate: Tue Jun 16 23:31:41 2020 +0530
views: fix dashboard and autogenview css issues
Signed-off-by: Rohit Yadav
---
src/components/widgets/Breadcrumb.vue | 1 -
src/views/AutogenView.vue | 29 ++---
src/views/compute/InstanceHardware.vue| 2 +-
src/views/dashboard/CapacityDashboard.vue | 16 +---
src/views/dashboard/UsageDashboard.vue| 19 ++-
src/views/infra/InfraSummary.vue | 4 ++--
6 files changed, 36 insertions(+), 35 deletions(-)
diff --git a/src/components/widgets/Breadcrumb.vue
b/src/components/widgets/Breadcrumb.vue
index a6f8e1e..c13c0ea 100644
--- a/src/components/widgets/Breadcrumb.vue
+++ b/src/components/widgets/Breadcrumb.vue
@@ -101,7 +101,6 @@ export default {
.ant-breadcrumb {
vertical-align: text-bottom;
- margin-bottom: 8px;
}
.ant-breadcrumb .anticon {
diff --git a/src/views/AutogenView.vue b/src/views/AutogenView.vue
index 70ef866..452d70b 100644
--- a/src/views/AutogenView.vue
+++ b/src/views/AutogenView.vue
@@ -22,20 +22,15 @@
-
-
- {{ $t('label.refresh') }}
-
-
- {{ $t('label.refresh') }}
-
-
+
+{{ $t('label.refresh') }}
+
{{ $t('label.filterby') }}
@@ -971,7 +966,7 @@ export default {
.breadcrumb-card {
margin-left: -24px;
margin-right: -24px;
- margin-top: -18px;
+ margin-top: -16px;
margin-bottom: 12px;
}
@@ -983,8 +978,4 @@ export default {
.ant-breadcrumb {
vertical-align: text-bottom;
}
-
-.ant-breadcrumb .anticon {
- margin-left: 8px;
-}
diff --git a/src/views/compute/InstanceHardware.vue
b/src/views/compute/InstanceHardware.vue
index 2d0fe93..4d9dacb 100644
--- a/src/views/compute/InstanceHardware.vue
+++ b/src/views/compute/InstanceHardware.vue
@@ -75,7 +75,7 @@
{{ $t('label.physicalsize') }}
{{ (item.physicalsize / (1024 * 1024 *
1024.0)).toFixed(4) }} GB
-
+
{{ $t('label.storagepool') }}
{{ item.storage }} ({{ item.storagetype }})
diff --git a/src/views/dashboard/CapacityDashboard.vue
b/src/views/dashboard/CapacityDashboard.vue
index f717e3d..4820d12 100644
--- a/src/views/dashboard/CapacityDashboard.vue
+++ b/src/views/dashboard/CapacityDashboard.vue
@@ -17,7 +17,7 @@
-
+
+
{{ $t(ts[stat.name]) }}
+
{{ displayData(stat.name,
stat.capacityused) }} / {{ displayData(stat.name, stat.capacitytotal)
}}
-
+
- View Hosts in Alert State
+ {{ $t('label.view') + ' ' + $t('label.host.alerts') }}
@@ -84,7 +86,7 @@
- View Alerts
+ {{ $t('label.view') + ' ' + $t('label.alerts') }}
@@ -94,7 +96,7 @@
- View Events
+{{ $t('label.view') + ' ' + $t('label.events') }}
@@ -227,7 +229,7 @@ export default {
listEvents () {
const params = {
page: 1,
-pagesize: 6,
+pagesize: 7,
listall: true
}
this.loading = true
diff --git a/src/views/dashboard/UsageDashboard.vue
b/src/views/dashboard/UsageDashboard.vue
index f3f8c16..bde8d8c 100644
---
[cloudstack-primate] branch master updated: views: fix dashboard and autogenview css issues
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 89c6745 views: fix dashboard and autogenview css issues
89c6745 is described below
commit 89c674553ec2a3043caf6cafef61a8ef378f0d10
Author: Rohit Yadav
AuthorDate: Tue Jun 16 23:31:41 2020 +0530
views: fix dashboard and autogenview css issues
Signed-off-by: Rohit Yadav
---
src/components/widgets/Breadcrumb.vue | 1 -
src/views/AutogenView.vue | 29 ++---
src/views/compute/InstanceHardware.vue| 2 +-
src/views/dashboard/CapacityDashboard.vue | 16 +---
src/views/dashboard/UsageDashboard.vue| 19 ++-
src/views/infra/InfraSummary.vue | 4 ++--
6 files changed, 36 insertions(+), 35 deletions(-)
diff --git a/src/components/widgets/Breadcrumb.vue
b/src/components/widgets/Breadcrumb.vue
index a6f8e1e..c13c0ea 100644
--- a/src/components/widgets/Breadcrumb.vue
+++ b/src/components/widgets/Breadcrumb.vue
@@ -101,7 +101,6 @@ export default {
.ant-breadcrumb {
vertical-align: text-bottom;
- margin-bottom: 8px;
}
.ant-breadcrumb .anticon {
diff --git a/src/views/AutogenView.vue b/src/views/AutogenView.vue
index 70ef866..452d70b 100644
--- a/src/views/AutogenView.vue
+++ b/src/views/AutogenView.vue
@@ -22,20 +22,15 @@
-
-
- {{ $t('label.refresh') }}
-
-
- {{ $t('label.refresh') }}
-
-
+
+{{ $t('label.refresh') }}
+
{{ $t('label.filterby') }}
@@ -971,7 +966,7 @@ export default {
.breadcrumb-card {
margin-left: -24px;
margin-right: -24px;
- margin-top: -18px;
+ margin-top: -16px;
margin-bottom: 12px;
}
@@ -983,8 +978,4 @@ export default {
.ant-breadcrumb {
vertical-align: text-bottom;
}
-
-.ant-breadcrumb .anticon {
- margin-left: 8px;
-}
diff --git a/src/views/compute/InstanceHardware.vue
b/src/views/compute/InstanceHardware.vue
index 2d0fe93..4d9dacb 100644
--- a/src/views/compute/InstanceHardware.vue
+++ b/src/views/compute/InstanceHardware.vue
@@ -75,7 +75,7 @@
{{ $t('label.physicalsize') }}
{{ (item.physicalsize / (1024 * 1024 *
1024.0)).toFixed(4) }} GB
-
+
{{ $t('label.storagepool') }}
{{ item.storage }} ({{ item.storagetype }})
diff --git a/src/views/dashboard/CapacityDashboard.vue
b/src/views/dashboard/CapacityDashboard.vue
index f717e3d..4820d12 100644
--- a/src/views/dashboard/CapacityDashboard.vue
+++ b/src/views/dashboard/CapacityDashboard.vue
@@ -17,7 +17,7 @@
-
+
+
{{ $t(ts[stat.name]) }}
+
{{ displayData(stat.name,
stat.capacityused) }} / {{ displayData(stat.name, stat.capacitytotal)
}}
-
+
- View Hosts in Alert State
+ {{ $t('label.view') + ' ' + $t('label.host.alerts') }}
@@ -84,7 +86,7 @@
- View Alerts
+ {{ $t('label.view') + ' ' + $t('label.alerts') }}
@@ -94,7 +96,7 @@
- View Events
+{{ $t('label.view') + ' ' + $t('label.events') }}
@@ -227,7 +229,7 @@ export default {
listEvents () {
const params = {
page: 1,
-pagesize: 6,
+pagesize: 7,
listall: true
}
this.loading = true
diff --git a/src/views/dashboard/UsageDashboard.vue
b/src/views/dashboard/UsageDashboard.vue
index f3f8c16..bde8d8c 100644
---
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-644912719 Trillian test result (tid-1739) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37740 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4007-t1739-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 214.57 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 192.31 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 264.21 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644910781 Trillian test result (tid-1740) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36827 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1740-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 214.31 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 247.59 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 268.74 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-644895951 Trillian test result (tid-1734) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39861 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4145-t1734-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 3668.56 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 3670.09 | test_internal_lb.py test_02_vpc_privategw_static_routes | `Failure` | 189.23 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 207.79 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 345.35 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: footer: show Primate version
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 2129074 footer: show Primate version
2129074 is described below
commit 2129074d528e41f0fc3a0f410c2b359789b68a47
Author: Rohit Yadav
AuthorDate: Tue Jun 16 22:06:33 2020 +0530
footer: show Primate version
Show Primate version in footer based on package.json
Signed-off-by: Rohit Yadav
---
packaging/package.sh | 9 +
src/components/page/GlobalFooter.vue | 4 +++-
src/store/getters.js | 1 +
src/store/modules/app.js | 1 +
vue.config.js| 9 -
5 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/packaging/package.sh b/packaging/package.sh
index 2ae2729..1160de4 100644
--- a/packaging/package.sh
+++ b/packaging/package.sh
@@ -22,8 +22,6 @@ set -x
ROOT=$PWD
function package_deb() {
-VERSION=$(cd ../; grep --color=none \"version\" package.json | cut -d '"'
-f4)
-DATE=$(date +"%Y%m%d")
sed -i "s/VERSION/$VERSION-$DATE/g" debian/changelog
dpkg-buildpackage -uc -us
$(cd ../; tar czf cloudstack-primate-$VERSION-$DATE.tar.gz dist
--transform s/dist/primate/)
@@ -33,10 +31,9 @@ function package_rpm() {
CWD=`pwd`
RPMDIR=$CWD/../build
-VERSION=$(cd ../; grep --color=none \"version\" package.json | cut -d '"'
-f4)
REALVER=`echo $VERSION`
DEFVER="-D_ver $REALVER"
-DEFREL="-D_rel $(date +"%Y%m%d")"
+DEFREL="-D_rel $DATE"
echo Preparing to package CloudStack Primate ${VERSION}
@@ -63,6 +60,10 @@ function package_rpm() {
fi
}
+DATE=$(date +"%Y%m%d")
+VERSION=$(grep -Po '"version": "\K[^"]*' ../package.json)
+sed -i "s/\"version\":.*/\"version\": \"$VERSION$DATE\",/g" ../package.json
+
case "$1" in
deb ) package_deb
;;
diff --git a/src/components/page/GlobalFooter.vue
b/src/components/page/GlobalFooter.vue
index 9438494..1df96d4 100644
--- a/src/components/page/GlobalFooter.vue
+++ b/src/components/page/GlobalFooter.vue
@@ -18,7 +18,9 @@
- CloudStack Server {{ $store.getters.features.cloudstackversion }}
+ CloudStack {{ $store.getters.features.cloudstackversion }}
+
+ Primate {{ $store.getters.version }}
https://github.com/apache/cloudstack-primate/issues/new/choose;
target="_blank">
diff --git a/src/store/getters.js b/src/store/getters.js
index fba66a8..97103b4 100644
--- a/src/store/getters.js
+++ b/src/store/getters.js
@@ -17,6 +17,7 @@
const getters = {
device: state => state.app.device,
+ version: state => state.app.version,
theme: state => state.app.theme,
color: state => state.app.color,
token: state => state.user.token,
diff --git a/src/store/modules/app.js b/src/store/modules/app.js
index b71b772..c954ff6 100644
--- a/src/store/modules/app.js
+++ b/src/store/modules/app.js
@@ -31,6 +31,7 @@ import {
const app = {
state: {
+version: process.env.PACKAGE_VERSION || 'master',
sidebar: true,
device: 'desktop',
theme: '',
diff --git a/vue.config.js b/vue.config.js
index 3bb6d87..4421a02 100644
--- a/vue.config.js
+++ b/vue.config.js
@@ -18,6 +18,8 @@
const path = require('path')
const webpack = require('webpack')
const fs = require('fs')
+const packageJson = fs.readFileSync('./package.json')
+const version = JSON.parse(packageJson).version || 'master'
function resolve (dir) {
return path.join(__dirname, dir)
@@ -43,7 +45,12 @@ module.exports = {
configureWebpack: {
plugins: [
// Ignore all locale files of moment.js
- new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/)
+ new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/),
+ new webpack.DefinePlugin({
+'process.env': {
+ PACKAGE_VERSION: '"' + version + '"'
+}
+ })
]
},
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-644865219 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
andrijapanicsb commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-644864610 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644848276 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644847872 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644817491 Packaging result: ✔centos7 ✔debian. JID-1400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644800311 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez removed a comment on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644716044 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644799564 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov removed a comment on pull request #4103: [VMware] Enable unmanaging guest VMs
borisstoyanov removed a comment on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644714557 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan removed a comment on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644743902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan removed a comment on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644715029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez removed a comment on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644743439 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala edited a comment on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
harikrishna-patnala edited a comment on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-644782245 @rhtyd @DaanHoogland This is not related to #3991. While testing that PR I came across with this bug and fixed it here. This PR is required as NPE is not good in any case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
harikrishna-patnala commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-644782245 @rhtyd @DaanHoogland This is not related to #3991. While testing that PR I came across with this bug and fixed it here. This is required PR as NPE is not good in any case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644761151 Packaging result: ✔centos7 ✔debian. JID-1399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
GabrielBrascher commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r440835059
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -3423,12 +3432,22 @@ else if (!template.isPublicTemplate() &&
caller.getType() != Account.ACCOUNT_TYP
return uniqueTmplPair;
}
List uniqueTmpls = uniqueTmplPair.first();
-String[] tzIds = new String[uniqueTmpls.size()];
int i = 0;
-for (TemplateJoinVO v : uniqueTmpls) {
-tzIds[i++] = v.getTempZonePair();
+List vrs = null;
+if (showUnique) {
+Long[] tzIds = new Long[uniqueTmpls.size()];
+for (TemplateJoinVO v : uniqueTmpls) {
+tzIds[i++] = v.getId();
+}
+vrs = _templateJoinDao.findByDistinctIds(tzIds);
+} else {
+String[] tzIds = new String[uniqueTmpls.size()];
+for (TemplateJoinVO v : uniqueTmpls) {
+tzIds[i++] = v.getTempZonePair();
+}
+vrs = _templateJoinDao.searchByTemplateZonePair(showRemovedTmpl,
tzIds);
Review comment:
Unit testing for such a huge/complex method is not easy. However, it
would be great to address small pieces.
With that said, lines 3436 - 3448 could be extracted into a method that
would allow testing this specific piece of code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644743902 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644743439 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
DaanHoogland commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-644741651 code looks good, but i'm not familiar with the use case / bug; +0.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644733122 Packaging result: ✔centos7 ✔debian. JID-1398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4103: [VMware] Enable unmanaging guest VMs
DaanHoogland commented on a change in pull request #4103:
URL: https://github.com/apache/cloudstack/pull/4103#discussion_r440800287
##
File path: api/src/main/java/org/apache/cloudstack/vm/UnmanageVMManager.java
##
@@ -0,0 +1,29 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.vm;
+
+import com.cloud.utils.component.PluggableService;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+
+public interface UnmanageVMManager extends VmImportService, UnmanageVMService,
PluggableService, Configurable {
Review comment:
this should be called `unmanage*d*VMsManager`, it does more than just
unmanage
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-644719127 Trillian test result (tid-1732) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58323 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4117-t1732-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 72 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1519.76 | test_accounts.py test_00_deploy_vm_root_resize | `Failure` | 302.98 | test_deploy_vm_root_resize.py test_13_retrieve_vr_default_files | `Error` | 1.08 | test_diagnostics.py test_14_retrieve_vr_one_file | `Error` | 1.10 | test_diagnostics.py test_15_retrieve_ssvm_default_files | `Error` | 1.11 | test_diagnostics.py test_16_retrieve_ssvm_single_file | `Error` | 1.10 | test_diagnostics.py test_17_retrieve_cpvm_default_files | `Error` | 1.10 | test_diagnostics.py test_18_retrieve_cpvm_single_file | `Error` | 1.14 | test_diagnostics.py test_04_extract_Iso | `Failure` | 1.08 | test_iso.py test_04_extract_template | `Failure` | 36.28 | test_templates.py test_06_download_detached_volume | `Failure` | 101.97 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 598.47 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 490.00 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 490.04 | test_vpc_redundant.py ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 490.08 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644716390 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644716044 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644715029 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4103: [VMware] Enable unmanaging guest VMs
borisstoyanov commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644714557 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4134: cks: fix k8s cluster network deletion
blueorangutan commented on pull request #4134: URL: https://github.com/apache/cloudstack/pull/4134#issuecomment-644701115 Packaging result: ✔centos7 ✔debian. JID-1396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: set python explicit during transistion
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch DaanHoogland-patch-4 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 3884391cf38422b088d6c60f5e4926e63ce99269 Author: dahn AuthorDate: Tue Jun 16 10:58:37 2020 + set python explicit during transistion this will allow for easier switching back and forth during development on python 3 functionality --- .python-version | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.python-version b/.python-version index bec3a35..a616492 100644 --- a/.python-version +++ b/.python-version @@ -1 +1 @@ -system +2.7.18
[cloudstack] branch DaanHoogland-patch-4 created (now 3884391)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-4 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 3884391 set python explicit during transistion This branch includes the following new commits: new 3884391 set python explicit during transistion The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [cloudstack] blueorangutan commented on pull request #4134: cks: fix k8s cluster network deletion
blueorangutan commented on pull request #4134: URL: https://github.com/apache/cloudstack/pull/4134#issuecomment-644673267 Packaging result: ✖centos7 ✖debian. JID-1395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4134: cks: fix k8s cluster network deletion
blueorangutan commented on pull request #4134: URL: https://github.com/apache/cloudstack/pull/4134#issuecomment-644669761 Packaging result: ✖centos7 ✖debian. JID-1394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated (3d9fad8 -> e606fe9)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 3d9fad8 iam: Add user - duplicated password field (#217) add e606fe9 compute: VMware Bootintobios (#313) No new revisions were added by this update. Summary of changes: src/config/section/compute.js | 24 ++-- src/locales/en.json| 1 + src/utils/request.js | 3 ++- src/views/compute/DeployVM.vue | 12 +++- 4 files changed, 36 insertions(+), 4 deletions(-)
