[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
shwstppr commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1188101575 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
shwstppr commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1188101474 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1539303619 Trillian test result (tid-6513) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 57520 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1539293991 Trillian test result (tid-6517) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49876 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1539224292 Trillian test result (tid-6518) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42852 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1539153853 Trillian test result (tid-6516) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36846 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1539141875 Trillian test result (tid-6514) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42310 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1539096481 Trillian test result (tid-6512) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40175 seconds Marvin logs:

[GitHub] [cloudstack] MilanHofmann closed issue #7437: Unable to add host due to networking or authentification error

2023-05-08 Thread via GitHub
MilanHofmann closed issue #7437: Unable to add host due to networking or authentification error URL: https://github.com/apache/cloudstack/issues/7437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] MilanHofmann commented on issue #7437: Unable to add host due to networking or authentification error

2023-05-08 Thread via GitHub
MilanHofmann commented on issue #7437: URL: https://github.com/apache/cloudstack/issues/7437#issuecomment-1538984624 @weizhouapache Actually the issue was gone after another clean install. Hard to tell what the exact issue was, it did not occur anymore. -- This is an automated

[GitHub] [cloudstack] weizhouapache commented on issue #7437: Unable to add host due to networking or authentification error

2023-05-08 Thread via GitHub
weizhouapache commented on issue #7437: URL: https://github.com/apache/cloudstack/issues/7437#issuecomment-1538981890 > @weizhouapache I hope this covers the relevant part. The management server's setup was yesterday so there would be a lot of text. Please let me know if you need the setup

[GitHub] [cloudstack] weizhouapache commented on issue #7437: Unable to add host due to networking or authentification error

2023-05-08 Thread via GitHub
weizhouapache commented on issue #7437: URL: https://github.com/apache/cloudstack/issues/7437#issuecomment-1538980473 > If anyone stumbles across this unable to find the CloudStack ssh public key, I finally found on Ubuntu 20.04 -- it was in `/var/lib/cloudstack/management/.ssh`.

[GitHub] [cloudstack] codecov[bot] commented on pull request #6078: Fix hv_ss_reserve value for volumes on migration

2023-05-08 Thread via GitHub
codecov[bot] commented on PR #6078: URL: https://github.com/apache/cloudstack/pull/6078#issuecomment-1538974708 ##

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
weizhouapache commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1187798269 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] nvazquez commented on pull request #6078: Fix hv_ss_reserve value for volumes on migration

2023-05-08 Thread via GitHub
nvazquez commented on PR #6078: URL: https://github.com/apache/cloudstack/pull/6078#issuecomment-1538886290 @DaanHoogland @rohityadavcloud conflicts fixed, this PR was an attempt to fix the issue but is still not complete -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] boie0025 commented on issue #7437: Unable to add host due to networking or authentification error

2023-05-08 Thread via GitHub
boie0025 commented on issue #7437: URL: https://github.com/apache/cloudstack/issues/7437#issuecomment-1538864622 If anyone stumbles across this unable to find the CloudStack ssh public key, I finally found on Ubuntu 20.04 they were in `/var/lib/cloudstack/management/.ssh`. -- This is

[GitHub] [cloudstack] blueorangutan commented on pull request #7494: Fix direct download certificate check initial delay

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7494: URL: https://github.com/apache/cloudstack/pull/7494#issuecomment-1538841125 Trillian test result (tid-6508) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41508 seconds Marvin logs:

[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
Pearl1594 commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1187752376 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] shwstppr commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-08 Thread via GitHub
shwstppr commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1538793247 @Pearl1594 cluster deployment isn't working as of now that's why in draft. Not sure why, need to debug. Will address your comments alongwith fixes. -- This is an automated message

[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #7479: cks: k8s cluster on vpc tier

2023-05-08 Thread via GitHub
Pearl1594 commented on code in PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#discussion_r1187676054 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -352,56 +352,57 @@ public

[cloudstack-www] branch docusaurus-staging updated (657a17d6 -> 8d82fbb8)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 657a17d6 make download single CTA add 8d82fbb8 banner fix No new revisions were added by

[cloudstack-www] branch docusaurus-staging updated (d9769301 -> 657a17d6)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from d9769301 background img example, we may need a more high-quality bg or svg add 657a17d6 make

[cloudstack-www] branch docusaurus-staging updated (2fba03f9 -> d9769301)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 2fba03f9 Fix blog categories in place of recent posts add d9769301 background img example, we

[cloudstack-www] branch docusaurus-staging updated (7f497b40 -> 2fba03f9)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 7f497b40 make blog single CTA add 2fba03f9 Fix blog categories in place of recent posts No

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-08 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1538342690 Trillian Build Failed (tid-6520) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[cloudstack-www] branch docusaurus-staging updated (4f65584f -> 7f497b40)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 4f65584f cmk update add 7f497b40 make blog single CTA No new revisions were added by this

[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-08 Thread via GitHub
JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1538291223 As requested in the devs mailing list, the following script is the one that I'm using to regenerate changes after merging them with the main branch: https://pastebin.com/zzbyhRNG

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538278112 Trillian Build Failed (tid-6519) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538274100 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
weizhouapache commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538273224 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools

2023-05-08 Thread via GitHub
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1538269766 > @JoaoJandre could a global setting and its use in the deployment planner be enough to make the deployment and related lifecycles are strictly or non-strictly allowed the by

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#discussion_r1187380564 ## systemvm/debian/opt/cloud/bin/cs/CsRedundant.py: ## @@ -282,7 +281,10 @@ def set_backup(self): self._remove_ipv6_guest_gateway() -

[cloudstack] branch 4.18 updated (897dad619b8 -> 88ff77dae10)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 897dad619b8 marvin: replace encodestring for encodebytes (#7027) add 88ff77dae10 ui: fix action notifications

[GitHub] [cloudstack] rohityadavcloud merged pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud merged PR #7499: URL: https://github.com/apache/cloudstack/pull/7499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538263468 It appears there was a disk space issue, thnx for raising this @shwstppr I'll add some monitoring on the community QA server soon. -- This is an automated message from the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6812: Normalize encryption on global configurations values

2023-05-08 Thread via GitHub
DaanHoogland commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1538248291 > @DaanHoogland @shwstppr in my opinion, this seems not to be a bug fix, but an improvement. I'd like to move it to 4.19.0.0 milestone, what do you think ? > > cc

[GitHub] [cloudstack] rohityadavcloud commented on issue #7004: The 'LSI Logic Parallel' controller is not supported on Windows 10

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7004: URL: https://github.com/apache/cloudstack/issues/7004#issuecomment-1538245428 Yes thanks @shwstppr doc PR is all we need. Unless you think this can be address automatically in the code. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1538243147 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] weizhouapache commented on issue #7196: systemvm/VR Volumes left in Destroy state after pool set to maintenance

2023-05-08 Thread via GitHub
weizhouapache commented on issue #7196: URL: https://github.com/apache/cloudstack/issues/7196#issuecomment-1538242840 this cannot be reproduced, closing it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] weizhouapache closed issue #7196: systemvm/VR Volumes left in Destroy state after pool set to maintenance

2023-05-08 Thread via GitHub
weizhouapache closed issue #7196: systemvm/VR Volumes left in Destroy state after pool set to maintenance URL: https://github.com/apache/cloudstack/issues/7196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] DaanHoogland commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
DaanHoogland commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1538242619 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #7288: URL: https://github.com/apache/cloudstack/pull/7288#issuecomment-1538241741 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538241424 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7499 (QA-JID-101) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-08 Thread via GitHub
rohityadavcloud commented on code in PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#discussion_r1187360547 ## plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java: ## @@ -2822,7 +2822,10 @@ private ManagedObjectReference

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538236848 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6043 -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7352: Added HA capability to the VMs during VMware Host alert

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7352: URL: https://github.com/apache/cloudstack/pull/7352#issuecomment-1538232055 ping @harikrishna-patnala any update on this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538227924 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538227235 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538179102 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
weizhouapache commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-153817 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-08 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1538178083 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6042 -- This is an

[cloudstack] branch 4.17 updated: fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml (#7163)

2023-05-08 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.17 by this push: new ea2b5379850 fix tools/build/setnextversion.sh:

[GitHub] [cloudstack] weizhouapache merged pull request #7163: fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml

2023-05-08 Thread via GitHub
weizhouapache merged PR #7163: URL: https://github.com/apache/cloudstack/pull/7163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
weizhouapache commented on code in PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#discussion_r1187302976 ## systemvm/debian/opt/cloud/bin/cs/CsRedundant.py: ## @@ -282,7 +281,10 @@ def set_backup(self): self._remove_ipv6_guest_gateway() -

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

2023-05-08 Thread via GitHub
weizhouapache commented on code in PR #7288: URL: https://github.com/apache/cloudstack/pull/7288#discussion_r1187301681 ## systemvm/agent/scripts/ipfirewall.sh: ## @@ -32,7 +32,7 @@ config_htaccess() { } ips(){ - echo "allow from $1" >> $HTACCESS + grep "^allow from $1$"

[GitHub] [cloudstack] DaanHoogland closed issue #7098: failure in test_affinity_groups_projects

2023-05-08 Thread via GitHub
DaanHoogland closed issue #7098: failure in test_affinity_groups_projects URL: https://github.com/apache/cloudstack/issues/7098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack] shwstppr commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
shwstppr commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538141783 @DaanHoogland A multi-cluster env would be needed. Then the following could be tested: - Deploy a test vm in cluster-1 and stop it - Fill cluster-1 to its capacity. Make sure

[GitHub] [cloudstack] DaanHoogland commented on pull request #7264: ssvm: continue with other secondary storages if fails to program a secondary storage

2023-05-08 Thread via GitHub
DaanHoogland commented on PR #7264: URL: https://github.com/apache/cloudstack/pull/7264#issuecomment-1538120344 @weizhouapache , I like the code but see no funcrtional change. Also, the issue #7244 is closed. I am fine with merging, but please advise. -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538119737 @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] shwstppr commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
shwstppr commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538117044 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#discussion_r1187270808 ## systemvm/debian/opt/cloud/bin/cs/CsRedundant.py: ## @@ -282,7 +281,10 @@ def set_backup(self): self._remove_ipv6_guest_gateway() -

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7288: URL: https://github.com/apache/cloudstack/pull/7288#discussion_r1187265200 ## systemvm/agent/scripts/ipfirewall.sh: ## @@ -32,7 +32,7 @@ config_htaccess() { } ips(){ - echo "allow from $1" >> $HTACCESS + grep "^allow from $1$"

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
shwstppr commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1187264956 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] soreana commented on issue #7260: It is not possible to make network redundant in the UI

2023-05-08 Thread via GitHub
soreana commented on issue #7260: URL: https://github.com/apache/cloudstack/issues/7260#issuecomment-1538106227 Thanks @weizhouapache and @rohityadavcloud for the feedback. I'm totally agree with you that it is not necessary feature. I will discuss it with my team and get back to

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7416: remove supportedOwner from Resource.ResourceType

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#discussion_r1187259257 ## api/src/main/java/com/cloud/configuration/Resource.java: ## @@ -22,55 +22,34 @@ public interface Resource { String UNLIMITED = "Unlimited"; enum

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: errorprone

2023-05-08 Thread via GitHub
DaanHoogland commented on PR #7088: URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1538065912 > @DaanHoogland if codecov, sonar are enough should we drop this? I had proposed this but recently I've found the project backers were let go and this may require more effort

[GitHub] [cloudstack] weizhouapache commented on pull request #7405: Enable defining a network as redundant during restart through the UI

2023-05-08 Thread via GitHub
weizhouapache commented on PR #7405: URL: https://github.com/apache/cloudstack/pull/7405#issuecomment-1538055253 @GaOrtiga it seems difficult to get a consensus. will you consider a new global setting to manage it ? (requires UI, API and service layer changes) -- This is an

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
weizhouapache commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1187234971 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538052557 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6041 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1537972899 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] shwstppr commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
shwstppr commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1537970015 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537965370 UI build failed: :heavy_multiplication_x: (SL-JID-100) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1187176420 ## server/src/main/java/com/cloud/network/IpAddressManagerImpl.java: ## @@ -1476,7 +1476,8 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537963606 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[cloudstack] branch main updated: .asf: grant triaging role access to frequent contributors

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 4243afbf04b .asf: grant triaging role access to

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537958463 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537957029 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] codecov[bot] commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
codecov[bot] commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537955161 ##

[GitHub] [cloudstack] rohityadavcloud commented on issue #7419: Reporting a vulnerability

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7419: URL: https://github.com/apache/cloudstack/issues/7419#issuecomment-1537953843 @igibek This is documented here https://cloudstack.apache.org/security.html Closing as your question has been answered. -- This is an automated message from the

[GitHub] [cloudstack] rohityadavcloud closed issue #7419: Reporting a vulnerability

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7419: Reporting a vulnerability URL: https://github.com/apache/cloudstack/issues/7419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rohityadavcloud commented on issue #7449: Don't run Github Actions jobs on forks and down-stream repos

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7449: URL: https://github.com/apache/cloudstack/issues/7449#issuecomment-1537953218 @DaanHoogland can you help fix this? probably needs some kind of if checks on the workflow yamls? -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-08 Thread via GitHub
shwstppr commented on code in PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#discussion_r1187167772 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -4810,9 +4810,12 @@ protected String validateUserData(String userData, HTTPMethod httpmethod) {

[GitHub] [cloudstack] rohityadavcloud commented on issue #7340: XCP-ng 8.2 - Live migration fails

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7340: URL: https://github.com/apache/cloudstack/issues/7340#issuecomment-1537952073 is this still reproducible @nvazquez @weizhouapache - have we tried mbx as well? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7392: Refactoring StorPool's smoke tests

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #7392: URL: https://github.com/apache/cloudstack/pull/7392#issuecomment-1537950725 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] rohityadavcloud commented on issue #7280: CloudStack should support Selinux

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7280: URL: https://github.com/apache/cloudstack/issues/7280#issuecomment-1537947267 @kiwiflyer we kind of do, but much of the selinux work requires operators/admin to define the rules. Here's an example of te file for cloud-agent pkg (cloudstack-agent

[GitHub] [cloudstack] rohityadavcloud commented on issue #7278: Unable to order the ISO/templates in the UI

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7278: URL: https://github.com/apache/cloudstack/issues/7278#issuecomment-1537946160 @shwstppr we need to check if it's the UI or API that's broken or re-test and close if we can't rperoduce. Certinaly works for me in 4.17.2. -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1537943066 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6040 -- This is an

[GitHub] [cloudstack] rohityadavcloud closed issue #7262: is it possible to add gpu to vm?

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7262: is it possible to add gpu to vm? URL: https://github.com/apache/cloudstack/issues/7262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rohityadavcloud commented on issue #7262: is it possible to add gpu to vm?

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7262: URL: https://github.com/apache/cloudstack/issues/7262#issuecomment-1537938444 Hi @hirayamanawari I think your question has been answered so I'm closing this. We've some option via API to have gpu passthrough for KVM and XenServer/XCP-ng may support

[GitHub] [cloudstack] rohityadavcloud commented on issue #7260: It is not possible to make network redundant in the UI

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7260: URL: https://github.com/apache/cloudstack/issues/7260#issuecomment-1537937028 Please refer to https://github.com/apache/cloudstack/pull/7405#issuecomment-1537850131 and as others have mentioned https://github.com/apache/cloudstack/issues/4052

[GitHub] [cloudstack] rohityadavcloud commented on issue #7251: Events tab is missing for the following sections

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7251: URL: https://github.com/apache/cloudstack/issues/7251#issuecomment-1537933764 @kiranchavala this is a new request, event tab may not be available or applicable for all these places. For example a VM starting on a network could be logged as an event

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-05-08 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1537931056 @DaanHoogland @shwstppr in my opinion, this seems not to be a bug fix, but an improvement. I'd like to move it to 4.19.0.0 milestone, what do you think ? cc

[GitHub] [cloudstack] rohityadavcloud closed issue #7167: UI background colour of warning makes it illegible

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7167: UI background colour of warning makes it illegible URL: https://github.com/apache/cloudstack/issues/7167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on issue #7167: UI background colour of warning makes it illegible

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7167: URL: https://github.com/apache/cloudstack/issues/7167#issuecomment-1537928265 @DaanHoogland we found this to be a build bug (if you build UI again, you may not consistently get this issue), which we hope is fixed via the Ant Design 3 upgrade by

[GitHub] [cloudstack] rohityadavcloud closed issue #7138: No secondary storage VM for downloading template to image store

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7138: No secondary storage VM for downloading template to image store URL: https://github.com/apache/cloudstack/issues/7138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] rohityadavcloud commented on issue #7138: No secondary storage VM for downloading template to image store

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7138: URL: https://github.com/apache/cloudstack/issues/7138#issuecomment-1537924894 @mail2lawi sorry to hear your feedback, could you refer to one of these guides: https://docs.cloudstack.apache.org/en/latest/quickinstallationguide/qig.html

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-05-08 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1537924320 great, thank for the update. @BryanMLima > I got some time to work on this one again, and now I could understand what you meant @weizhouapache. I added the

[GitHub] [cloudstack] blueorangutan commented on pull request #7392: Refactoring StorPool's smoke tests

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7392: URL: https://github.com/apache/cloudstack/pull/7392#issuecomment-1537923939 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6039 -- This is an

[GitHub] [cloudstack] weizhouapache commented on issue #6698: Dedication of public IP ranges broken after upgrade to 4.17.0.1

2023-05-08 Thread via GitHub
weizhouapache commented on issue #6698: URL: https://github.com/apache/cloudstack/issues/6698#issuecomment-1537921865 @rohityadavcloud PR #7144 has been added to 4.18.1.0 milestone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-08 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1537921507 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

  1   2   >