[GitHub] [cloudstack] vishesh92 commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
vishesh92 commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1545183748 @Pearl1594 Thanks for reviewing my PR. I have resolved some of your comments & replied to some. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7506: increase log detail for limit checking, fix getDomainReservation()

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7506: URL: https://github.com/apache/cloudstack/pull/7506#issuecomment-1545166064 Trillian test result (tid-6532) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38999 seconds Marvin logs:

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191907394 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/AddVmsToKubernetesClusterCmd.java: ## @@ -0,0

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191723460 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -600,8 +609,66 @@ private void

[GitHub] [cloudstack] blueorangutan commented on pull request #7506: increase log detail for limit checking, fix getDomainReservation()

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7506: URL: https://github.com/apache/cloudstack/pull/7506#issuecomment-1544986464 Trillian test result (tid-6531) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41857 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1544785346 Trillian test result (tid-6529) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 54843 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1544775965 Trillian test result (tid-6528) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55545 seconds Marvin logs:

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7521: Fix deployDataCenter's cleanup

2023-05-11 Thread via GitHub
vishesh92 opened a new pull request, #7521: URL: https://github.com/apache/cloudstack/pull/7521 ### Description Fixes TypeError. The file is written in a binary format and needs to be read in binary format as well. ``` TypeError: a bytes-like object is required, not 'str' ```

[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1544617823 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6065 -- This is an

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-05-11 Thread via GitHub
sonarcloud[bot] commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1544559380 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1544542182 @JoaoJandre a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-11 Thread via GitHub
JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1544539900 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1544501504 Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 6064 --

[cloudstack] branch main updated (9ddfeac57e8 -> 62fa45aa819)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 9ddfeac57e8 .asf.yaml: Added soreana to the .asf.yml (#7518) add a0eb0aa5f7a api,server: fix VM.CREATE events

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 62fa45aa819464422f010e58dd3d979db48eb509 Merge: 9ddfeac57e8 a0eb0aa5f7a Author: Rohit Yadav AuthorDate: Thu May 11

[GitHub] [cloudstack] rohityadavcloud closed issue #6697: VM.CREATE Completion Action/Async event not Logged

2023-05-11 Thread via GitHub
rohityadavcloud closed issue #6697: VM.CREATE Completion Action/Async event not Logged URL: https://github.com/apache/cloudstack/issues/6697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#issuecomment-1544453491 @shwstppr this seem to have broken the UI build, could you have a look tomorrow? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #7506: increase log detail for limit checking, fix getDomainReservation()

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7506: URL: https://github.com/apache/cloudstack/pull/7506#issuecomment-152535 @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-152486 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-11 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-151353 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7397: Feature: VM Scheduler

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-151260 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7506: increase log detail for limit checking, fix getDomainReservation()

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7506: URL: https://github.com/apache/cloudstack/pull/7506#issuecomment-150370 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7505: build(deps-dev): bump testng from 7.1.0 to 7.5.1

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7505: URL: https://github.com/apache/cloudstack/pull/7505#issuecomment-1544439646 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] dependabot[bot] commented on pull request #7505: build(deps-dev): bump testng from 7.1.0 to 7.5.1

2023-05-11 Thread via GitHub
dependabot[bot] commented on PR #7505: URL: https://github.com/apache/cloudstack/pull/7505#issuecomment-1544439757 OK, I won't notify you about version 7.x.x again, unless you re-open this PR.  -- This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack] branch dependabot/maven/org.testng-testng-7.5.1 deleted (was ecca5f3062b)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch dependabot/maven/org.testng-testng-7.5.1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git was ecca5f3062b build(deps-dev): bump testng from 7.1.0 to 7.5.1 The revisions that

[GitHub] [cloudstack] rohityadavcloud closed pull request #7505: build(deps-dev): bump testng from 7.1.0 to 7.5.1

2023-05-11 Thread via GitHub
rohityadavcloud closed pull request #7505: build(deps-dev): bump testng from 7.1.0 to 7.5.1 URL: https://github.com/apache/cloudstack/pull/7505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] dependabot[bot] commented on pull request #7505: build(deps-dev): bump testng from 7.1.0 to 7.5.1

2023-05-11 Thread via GitHub
dependabot[bot] commented on PR #7505: URL: https://github.com/apache/cloudstack/pull/7505#issuecomment-1544439370 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7505: build(deps-dev): bump testng from 7.1.0 to 7.5.1

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7505: URL: https://github.com/apache/cloudstack/pull/7505#issuecomment-1544439291 What a world we live, one bot raises PR other does code coverage :) only for a human to decide it's not necessary and possibly break a bunch of things. We should certainly

[cloudstack] branch 4.18 updated: api,server: fix VM.CREATE events on vm deploy without start (#7421)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new a0eb0aa5f7a api,server: fix VM.CREATE events on

[GitHub] [cloudstack] rohityadavcloud merged pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7421: URL: https://github.com/apache/cloudstack/pull/7421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#issuecomment-1544437542 @shwstppr my bad, no I didn't mean the event type but only the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[cloudstack] branch main updated (232c86a715a -> 9ddfeac57e8)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 232c86a715a Merge remote-tracking branch 'origin/4.18' add 9ddfeac57e8 .asf.yaml: Added soreana to the .asf.yml

[GitHub] [cloudstack] rohityadavcloud merged pull request #7518: Added soreana to the .asf.yml

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7518: URL: https://github.com/apache/cloudstack/pull/7518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 232c86a715a8951085d9b36c1164779e2708074f Merge: 0af56179a59 8c546bd5a68 Author: Rohit Yadav AuthorDate: Thu May 11

[cloudstack] branch main updated (0af56179a59 -> 232c86a715a)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 0af56179a59 Merge remote-tracking branch 'origin/4.18' add a582b2a5a16 ui: fix sourceIP is not passed when

[GitHub] [cloudstack] rohityadavcloud closed issue #6702: Router displaying error "Failed to start Conntrack Deamon"

2023-05-11 Thread via GitHub
rohityadavcloud closed issue #6702: Router displaying error "Failed to start Conntrack Deamon" URL: https://github.com/apache/cloudstack/issues/6702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1544309899 > > @weizhouapache can you please look into it and make the necessary changes? I'm happy to both close this or if you want make changes in this PR @shwstppr sure,

[GitHub] [cloudstack] shwstppr commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
shwstppr commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1544236350 > > @weizhouapache Currently, we don't link IPs when they are used by a system VM or VR. Without having changes that update IpAddress record for system vm, VRs it would mean querying

[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
Pearl1594 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191250311 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -600,8 +609,66 @@ private void

[cloudstack-www] branch docusaurus-staging updated (c2e89b6c -> be82904c)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from c2e89b6c fix header add be82904c make the /who page same as current one No new revisions

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191318997 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/AddVmsToKubernetesClusterCmd.java: ## @@

[GitHub] [cloudstack] tungntvn23 opened a new issue, #7519: Cloudstack CSI Driver cannot mount pvc after attach volume

2023-05-11 Thread via GitHub
tungntvn23 opened a new issue, #7519: URL: https://github.com/apache/cloudstack/issues/7519 # ISSUE TYPE * Bug Report # COMPONENT NAME * Storage csi driver, Kubernetes Service # CLOUDSTACK VERSION * 4.17.2.0 # CONFIGURATION *

[GitHub] [cloudstack] soreana opened a new pull request, #7518: Added soreana to the .asf.yml

2023-05-11 Thread via GitHub
soreana opened a new pull request, #7518: URL: https://github.com/apache/cloudstack/pull/7518 ### Description Add my username to the .asf.yml file. ### Types of changes - [ ] Breaking change (fix or feature that would cause

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
rohityadavcloud commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191200018 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/AddVmsToKubernetesClusterCmd.java: ## @@

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7506: increase log detail for limit checking, fix getDomainReservation()

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7506: URL: https://github.com/apache/cloudstack/pull/7506#issuecomment-1544025909 Thanks for sharing test results @mlsorensen let me help kick smoketests on this @blueorangutan test -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #7410: ssvm: pass all accessible secondary storage to ssvm

2023-05-11 Thread via GitHub
shwstppr commented on PR #7410: URL: https://github.com/apache/cloudstack/pull/7410#issuecomment-1544008511 @kiranchavala fyi, this is not ready for testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[cloudstack-www] branch docusaurus-staging updated (a08f73b7 -> c2e89b6c)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from a08f73b7 tweak tagline add c2e89b6c fix header No new revisions were added by this update.

[GitHub] [cloudstack] blueorangutan commented on pull request #7424: ui: fix tags for security group rules

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7424: URL: https://github.com/apache/cloudstack/pull/7424#issuecomment-1543990051 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6062 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7410: ssvm: pass all accessible secondary storage to ssvm

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7410: URL: https://github.com/apache/cloudstack/pull/7410#issuecomment-1543979263 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6061 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543976437 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6060 -- This is an

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543936209 > @weizhouapache Currently, we don't link IPs when they are used by a system VM or VR. Without having changes that update IpAddress record for system vm, VRs it would mean

[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1543928546 @JoaoJandre a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-11 Thread via GitHub
JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1543926021 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] shwstppr commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
shwstppr commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543917872 > @shwstppr is automated testing for this a stretch, or feasible? @DaanHoogland not sure but smoke test feels like a bit stretch for verifying some list response parameters.

[GitHub] [cloudstack] shwstppr commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
shwstppr commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543909105 @weizhouapache Currently, we don't link IPs when they are used by a system VM or VR. Without having changes that update IpAddress record for system vm, VRs it would mean querying

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543897200 @shwstppr I had a quick look at the code changes just now. can we fix it without changes in user_ip_address ? from what I understand, we just need to add the vm name

[GitHub] [cloudstack] blueorangutan commented on pull request #7424: ui: fix tags for security group rules

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7424: URL: https://github.com/apache/cloudstack/pull/7424#issuecomment-1543890458 @kiranchavala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] kiranchavala commented on pull request #7424: ui: fix tags for security group rules

2023-05-11 Thread via GitHub
kiranchavala commented on PR #7424: URL: https://github.com/apache/cloudstack/pull/7424#issuecomment-1543888374 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7410: ssvm: pass all accessible secondary storage to ssvm

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7410: URL: https://github.com/apache/cloudstack/pull/7410#issuecomment-1543873974 @kiranchavala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] kiranchavala commented on pull request #7410: ssvm: pass all accessible secondary storage to ssvm

2023-05-11 Thread via GitHub
kiranchavala commented on PR #7410: URL: https://github.com/apache/cloudstack/pull/7410#issuecomment-1543872847 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543867764 @kiranchavala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] kiranchavala commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
kiranchavala commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543866278 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] tuanhoangth1603 opened a new issue, #7517: Traefik return 404 page not found - Kubernetes on Cloudstack 4.17.2.0

2023-05-11 Thread via GitHub
tuanhoangth1603 opened a new issue, #7517: URL: https://github.com/apache/cloudstack/issues/7517 Hello, I created a Kubernetes cluster on Cloudstack and used this guide (https://docs.cloudstack.apache.org/en/latest/plugins/cloudstack-kubernetes-provider.html) to deploy Traefik as an

[GitHub] [cloudstack] weizhouapache commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1543676447 > > great @shwstppr > > can you add a smoke test for it ? > > @weizhouapache should I add a smoke test in the existing

[GitHub] [cloudstack] shwstppr commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-11 Thread via GitHub
shwstppr commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1543603669 > great @shwstppr > > can you add a smoke test for it ? @weizhouapache should I add a smoke test in the existing `test/integration/smoke/test_kubernetes_clusters.py`?

[GitHub] [cloudstack] rohityadavcloud opened a new issue, #7516: Deleting snapshots leaves empty directories

2023-05-11 Thread via GitHub
rohityadavcloud opened a new issue, #7516: URL: https://github.com/apache/cloudstack/issues/7516 CloudStack doesn't delete snapshot directories when snapshots are deleted. This leaves behind empty directories on the secondary storage's `snapshots` directory. As a side-effect of

[GitHub] [cloudstack] codecov[bot] commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
codecov[bot] commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1543559202 ##

[GitHub] [cloudstack] blueorangutan commented on pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7288: URL: https://github.com/apache/cloudstack/pull/7288#issuecomment-1543507568 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6059 -- This is an

[cloudstack] branch 4.18 updated: router: do not restart conntrackd if no guest networks (issue 6702) (#7265)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 8c546bd5a68 router: do not restart conntrackd if

[GitHub] [cloudstack] rohityadavcloud merged pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7265: URL: https://github.com/apache/cloudstack/pull/7265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] rohityadavcloud merged pull request #7448: server: add config for SSVM capacity scan interval

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7448: URL: https://github.com/apache/cloudstack/pull/7448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch 4.18 updated (e613b90feea -> 5e442df5a08)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from e613b90feea ui: set default cpu, memory value for k8s version (#7513) add 5e442df5a08 ssvm: continue with other

[GitHub] [cloudstack] rohityadavcloud merged pull request #7264: ssvm: continue with other secondary storages if fails to program a secondary storage

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7264: URL: https://github.com/apache/cloudstack/pull/7264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch 4.18 updated: server: add config SSVM capacity scan (#7448)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new d9e0a3e6c32 server: add config SSVM capacity

[cloudstack] branch 4.18 updated: ui: set default cpu, memory value for k8s version (#7513)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new e613b90feea ui: set default cpu, memory value

[GitHub] [cloudstack] rohityadavcloud merged pull request #7513: ui: set default cpu, memory value for k8s version

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7513: URL: https://github.com/apache/cloudstack/pull/7513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch 4.18 updated (0e4a5a1fa41 -> a582b2a5a16)

2023-05-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 0e4a5a1fa41 .github: restrict sonar and CI actions to only apache/cloudstack add a582b2a5a16 ui: fix sourceIP

[GitHub] [cloudstack] rohityadavcloud merged pull request #7512: UI: fix sourceIP is not passed when create internal LB

2023-05-11 Thread via GitHub
rohityadavcloud merged PR #7512: URL: https://github.com/apache/cloudstack/pull/7512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] shwstppr commented on pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-11 Thread via GitHub
shwstppr commented on PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#issuecomment-1543472359 @rohityadavcloud Sorry didn't get you completely. This PR or a change in the event description won't create an issue but if we refactor the event type to VM.DEPLOY as you said in

[GitHub] [cloudstack] shwstppr commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-11 Thread via GitHub
shwstppr commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1543445094 @blueorangutan test rocky8 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
vishesh92 opened a new pull request, #7515: URL: https://github.com/apache/cloudstack/pull/7515 ### Description This PR adds the option to add *unmanaged* kubernetes cluster which could be managed by other providers like cluster-api. Two new APIs have also been added: 1.

[GitHub] [cloudstack] blueorangutan commented on pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7288: URL: https://github.com/apache/cloudstack/pull/7288#issuecomment-1543436438 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] shwstppr commented on pull request #7288: SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

2023-05-11 Thread via GitHub
shwstppr commented on PR #7288: URL: https://github.com/apache/cloudstack/pull/7288#issuecomment-1543434584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7455: Fix Tungsten Fabric errors on adding a new zone due to duplicated entries on ntwk_service_map

2023-05-11 Thread via GitHub
shwstppr commented on code in PR #7455: URL: https://github.com/apache/cloudstack/pull/7455#discussion_r1190708512 ## plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ConfigTungstenFabricServiceCmd.java: ## @@ -132,6 +135,21 @@

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#issuecomment-1543421540 If the event is still EventTypes.EVENT_VM_CREATE and we're only changing the description, I don't think so @shwstppr but perhaps we should test? -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-11 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1543420652 @rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-11 Thread via GitHub
rohityadavcloud commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1543420299 @blueorangutan test rocky8 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the