Re: [PR] protect against null-path [cloudstack]

[via GitHub]

sureshanaparti commented on code in PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#discussion_r1566735909


##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##
@@ -2969,7 +2969,10 @@ protected void 
setVAppPropertiesToConfigSpec(VmConfigInfo vAppConfig,
 }
 
 private String appendFileType(String path, String fileType) {
-if (path.toLowerCase().endsWith(fileType.toLowerCase())) {
+if (path == null) {

Review Comment:
   ```suggestion
   if (StringUtils.isBlank(path)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

blueorangutan commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2058271370

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

sureshanaparti commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2058270866

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

blueorangutan commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2058189272

   @sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + 
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

sureshanaparti commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2058187917

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] auto start all VMs on a host using local storage after reboot [cloudstack]

[via GitHub]

eddiewang commented on issue #8687:
URL: https://github.com/apache/cloudstack/issues/8687#issuecomment-2058167411

   i would also like to see this feature implemented!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2058102245

   [SF] Trillian test result (tid-9838)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52231 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t9838-kvm-centos7.zip
   Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 306.31 | test_events_resource.py
   test_01_events_resource | `Error` | 306.32 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 90.42 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.36 | 
test_network_permissions.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 439.87 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2058080569

   [SF] Trillian test result (tid-9839)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 50419 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t9839-kvm-alma9.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 323.90 | test_events_resource.py
   test_01_events_resource | `Error` | 323.91 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 90.35 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.48 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2057985912

   [SF] Trillian test result (tid-9835)
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 47181 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t9835-kvm-rocky8.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 310.81 | test_events_resource.py
   test_01_events_resource | `Error` | 310.82 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 88.69 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.49 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

[via GitHub]

blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2057916275

   [SF] Trillian test result (tid-9832)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 43639 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8790-t9832-kvm-alma9.zip
   Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

blueorangutan commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2057879445

   [SF] Trillian test result (tid-9837)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38030 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8915-t9837-kvm-centos7.zip
   Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 1.18 | 
test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 1.19 | 
test_deploy_vm_extra_config_data.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 1.13 | 
test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 0.14 | 
test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.16 | 
test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.13 | 
test_vm_deployment_planner.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

blueorangutan commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2057843482

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9267


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

blueorangutan commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2057772238

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

blueorangutan commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2057740440

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

sureshanaparti commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2057737007

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 commented on code in PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#discussion_r1566333731


##
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java:
##
@@ -0,0 +1,111 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
+
+/**
+ * Uses a ScheduledExecutorService and config key to execute a runnable,
+ * dynamically rescheduling based on the long value of the config key.
+ * Timing is similar to ScheduledExecutorService.scheduleAtFixedRate(),
+ * but we look up the next runtime dynamically via the config key.
+ * 
+ * If config key is zero, this disables the execution. We skip execution
+ * and check once a minute in order to re-start execution if re-enabled.
+ */
+public class ConfigKeyScheduledExecutionWrapper implements Runnable {
+protected Logger logger = LogManager.getLogger(getClass());
+private final ScheduledExecutorService executorService;
+private final Runnable command;
+private final ConfigKey configKey;
+private final TimeUnit unit;
+private long enableIntervalSeconds = 60;
+
+private void validateArgs(ScheduledExecutorService executorService, 
Runnable command, ConfigKey configKey) {
+if (executorService == null) {
+throw new IllegalArgumentException("ExecutorService cannot be 
null");
+}
+if (command == null) {
+throw new IllegalArgumentException("Command cannot be null");
+}
+if (configKey == null) {
+throw new IllegalArgumentException("ConfigKey cannot be null");
+}
+}
+
+public ConfigKeyScheduledExecutionWrapper(ScheduledExecutorService 
executorService, Runnable command,
+ConfigKey configKey, TimeUnit unit) {
+validateArgs(executorService, command, configKey);
+this.executorService = executorService;
+this.command = command;
+this.configKey = configKey;
+this.unit = unit;
+}
+
+protected ConfigKeyScheduledExecutionWrapper(ScheduledExecutorService 
executorService, Runnable command,
+ConfigKey configKey, int enableIntervalSeconds, TimeUnit unit) {
+validateArgs(executorService, command, configKey);
+this.executorService = executorService;
+this.command = command;
+this.configKey = configKey;
+this.unit = unit;
+this.enableIntervalSeconds = enableIntervalSeconds;
+}
+
+public ScheduledFuture start() {
+long duration = getConfigValue();
+duration = duration < 0 ? 0 : duration;
+return this.executorService.schedule(this, duration, this.unit);
+}
+
+long getConfigValue() {
+if (this.configKey.value() instanceof Long) {
+return (Long) this.configKey.value();
+} else if (this.configKey.value() instanceof Integer) {
+return (Integer) this.configKey.value();
+} else {
+throw new IllegalArgumentException("ConfigKey value must be a Long 
or Integer");

Review Comment:
   This is to allow usage of this class for both integer & long type config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

blueorangutan commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2057653578

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 commented on code in PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#discussion_r1566332101


##
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java:
##
@@ -0,0 +1,111 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
+
+/**
+ * Uses a ScheduledExecutorService and config key to execute a runnable,
+ * dynamically rescheduling based on the long value of the config key.
+ * Timing is similar to ScheduledExecutorService.scheduleAtFixedRate(),
+ * but we look up the next runtime dynamically via the config key.
+ * 
+ * If config key is zero, this disables the execution. We skip execution
+ * and check once a minute in order to re-start execution if re-enabled.
+ */
+public class ConfigKeyScheduledExecutionWrapper implements Runnable {
+protected Logger logger = LogManager.getLogger(getClass());
+private final ScheduledExecutorService executorService;
+private final Runnable command;
+private final ConfigKey configKey;
+private final TimeUnit unit;
+private long enableIntervalSeconds = 60;
+
+private void validateArgs(ScheduledExecutorService executorService, 
Runnable command, ConfigKey configKey) {
+if (executorService == null) {
+throw new IllegalArgumentException("ExecutorService cannot be 
null");
+}
+if (command == null) {
+throw new IllegalArgumentException("Command cannot be null");
+}
+if (configKey == null) {
+throw new IllegalArgumentException("ConfigKey cannot be null");
+}
+}
+
+public ConfigKeyScheduledExecutionWrapper(ScheduledExecutorService 
executorService, Runnable command,
+ConfigKey configKey, TimeUnit unit) {
+validateArgs(executorService, command, configKey);
+this.executorService = executorService;
+this.command = command;
+this.configKey = configKey;
+this.unit = unit;
+}
+
+protected ConfigKeyScheduledExecutionWrapper(ScheduledExecutorService 
executorService, Runnable command,
+ConfigKey configKey, int enableIntervalSeconds, TimeUnit unit) {
+validateArgs(executorService, command, configKey);
+this.executorService = executorService;
+this.command = command;
+this.configKey = configKey;
+this.unit = unit;
+this.enableIntervalSeconds = enableIntervalSeconds;
+}
+
+public ScheduledFuture start() {
+long duration = getConfigValue();
+duration = duration < 0 ? 0 : duration;
+return this.executorService.schedule(this, duration, this.unit);
+}
+
+long getConfigValue() {
+if (this.configKey.value() instanceof Long) {
+return (Long) this.configKey.value();
+} else if (this.configKey.value() instanceof Integer) {
+return (Integer) this.configKey.value();
+} else {
+throw new IllegalArgumentException("ConfigKey value must be a Long 
or Integer");
+}
+}
+
+@Override
+public void run() {
+if (getConfigValue() <= 0) {
+executorService.schedule(this, enableIntervalSeconds, 
TimeUnit.SECONDS);

Review Comment:
   If the value is negative, we use `enableIntervalSeconds` as the duration for 
schedule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2057650775

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update volume's passphrase to null if diskOffering doesn't support encryption [cloudstack]

[via GitHub]

blueorangutan commented on PR #8904:
URL: https://github.com/apache/cloudstack/pull/8904#issuecomment-2057637693

   [SF] Trillian test result (tid-9830)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43078 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8904-t9830-kvm-centos7.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 291.89 | test_events_resource.py
   test_01_events_resource | `Error` | 291.90 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 86.01 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.41 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [UI] Add option to specify account/project while deploying VMs [cloudstack]

[via GitHub]

BryanMLima opened a new pull request, #8919:
URL: https://github.com/apache/cloudstack/pull/8919

   ### Description
   
   This PR adds a new component (`OwnershipSelection`) to specify the 
account/project when creating a VM (can also be used for other resources in the 
future). This component makes it easy for operators with roles Admin and Domain 
Admin to create VMs for any account and/or project that it has permission.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
![image](https://github.com/apache/cloudstack/assets/42067040/df3b6d04-7df5-405f-a846-82a58a4931ec)
   
   ### How Has This Been Tested?
   
   I deployed a number of VMs using different accounts and projects in 
different domains.
   
    How did you try to break this feature and the system with this change?
   I tried to verify that the UI only showed the permissions according to the 
account/project selected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] OOBM Sends Resthe et Command to DRAC if Hypervisor is in powerOff state [cloudstack]

[via GitHub]

boring-cyborg[bot] commented on issue #8918:
URL: https://github.com/apache/cloudstack/issues/8918#issuecomment-2057585549

   Thanks for opening your first issue here! Be sure to follow the issue 
template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] OOBM Sends Resthe et Command to DRAC if Hypervisor is in powerOff state [cloudstack]

[via GitHub]

rahultolearn59 opened a new issue, #8918:
URL: https://github.com/apache/cloudstack/issues/8918

   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   When a hypervisor with RHEL8/9 running on a Dell PowerEdge Server gets into 
the power-off state, the ACS management system cannot fence it to recover the 
VMs on another hypervisor as it keeps sending DRAC a system reset request. 
Still, Drac has Poweron as the only option while its server is in a power-off 
state.
   I waited for 1-2 hours to conclude. 
   As soon as I power on the server manually, VMs are restored on different 
hypervisors immediately.
   
   
   I think the server's power status should be checked first, and a 
power-on/reset command should be sent accordingly. 
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Power off the hypervisor.
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   VMs should be recovered on active hypervisor.
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   VMs were not able to recover
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]

[via GitHub]

DaanHoogland closed pull request #8243: Normalize dates in Usage and Quota APIs
URL: https://github.com/apache/cloudstack/pull/8243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Support ACL based on Domain/URL instead of IP [cloudstack]

[via GitHub]

btzq opened a new issue, #8917:
URL: https://github.com/apache/cloudstack/issues/8917

   
   
   # ISSUE TYPE
   
* Improvement Request
   
   # COMPONENT NAME
   
   ~~~
   Improvement Request (Functionality)
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.19
   ~~~
   
   # CONFIGURATION
   
   N/A
   
   # OS / ENVIRONMENT
   
   N/A
   
   # SUMMARY
   
   Note: This ticket is broken down as requested from the origianl post, 
https://github.com/apache/cloudstack/issues/8841
   
   **Support ACL based on Domain/URL instead of IP**
   
   - As a company, sometimes i would like to block access to specific sites 
(eg. google drive), which is based on domain. 
   - But i am unable to do so because, ACL Rules are based on explicitly 
specifying the IP address.
   - Specifying the IP address/range of the intended website will be tedious 
and non-practical.
   
   # STEPS TO REPRODUCE
   
   N/A
   
   
   ~~~
   N/A
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   To be able to manage ACL Rules more easily for enterprise use cases.
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   Unable to effectively block access to certain sites using URL/Domain
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] CloudStask Add Ldap Account Empty List [cloudstack]

[via GitHub]

DaanHoogland commented on issue #8910:
URL: https://github.com/apache/cloudstack/issues/8910#issuecomment-2057198095

   well, can you configure Apache Directory Studio, just in case it is a java 
issue? (https://directory.apache.org/studio/)
   
   I usually don't use microsoftad, so can't help you there. You can try to 
configure an openldap installation. Or use an online service like jumpcloud.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

(cloudstack-www) branch staging-site updated: no embeded videos (#201)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new a8dfa72c no embeded videos (#201)
a8dfa72c is described below

commit a8dfa72c0739e6f0c10e80c7da00c5013ac99df5
Author: dahn 
AuthorDate: Mon Apr 15 17:47:36 2024 +0200

no embeded videos (#201)
---
 blog/2023-12-07-ccc2023-roundup/index.md   |  72 ++---
 .../youtube/01-StateOfTheUnion.png | Bin 0 -> 879740 bytes
 .../youtube/02-whatsnew4.19.png| Bin 0 -> 892665 bytes
 .../youtube/03-keynote.png | Bin 0 -> 847439 bytes
 .../youtube/04-wesystems.png   | Bin 0 -> 839376 bytes
 .../youtube/05-proIO.png   | Bin 0 -> 865710 bytes
 .../youtube/06-PanelDay1.png   | Bin 0 -> 878672 bytes
 .../youtube/07-KVMsecurity.png | Bin 0 -> 862056 bytes
 .../youtube/08-elevatingprivacy   | Bin 0 -> 887008 bytes
 .../youtube/09-vmware.png  | Bin 0 -> 1816835 bytes
 .../youtube/10-LINSTOR.png | Bin 0 -> 880955 bytes
 .../2023-12-07-ccc2023-roundup/youtube/11-zero.png | Bin 0 -> 910737 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/12-VNF.png | Bin 0 -> 861245 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/13-SDN.png | Bin 0 -> 910718 bytes
 .../youtube/14-backroll.png| Bin 0 -> 892858 bytes
 .../youtube/15-backup.png  | Bin 0 -> 893236 bytes
 .../youtube/16-mitigating.png  | Bin 0 -> 877949 bytes
 .../youtube/17-re-use.png  | Bin 0 -> 1665077 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/18-DRS.png | Bin 0 -> 906380 bytes
 .../youtube/19-makerspace.png  | Bin 0 -> 1775689 bytes
 .../2023-12-07-ccc2023-roundup/youtube/20-DRBD.png | Bin 0 -> 831295 bytes
 .../youtube/21-beginners.png   | Bin 0 -> 859242 bytes
 .../youtube/22-vCloud.png  | Bin 0 -> 894708 bytes
 .../youtube/23-Gitops.png  | Bin 0 -> 2061301 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/24-2FA.png | Bin 0 -> 875852 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/25-ELK.png | Bin 0 -> 1533193 bytes
 .../youtube/26-DraaS.png   | Bin 0 -> 887178 bytes
 .../youtube/27-DIMSI.png   | Bin 0 -> 917968 bytes
 .../youtube/28-UserData.png| Bin 0 -> 837378 bytes
 .../youtube/29-PanelDay2.png   | Bin 0 -> 884468 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/30-DPU.png | Bin 0 -> 896292 bytes
 .../youtube/31-ObjectStorage.png   | Bin 0 -> 861891 bytes
 .../youtube/32-Confidence.png  | Bin 0 -> 847457 bytes
 .../youtube/33-Kubernetes.png  | Bin 0 -> 903537 bytes
 blog/2023-12-07-ccc2023-roundup/youtube/34-KVM.png | Bin 0 -> 871792 bytes
 .../2023-12-07-ccc2023-roundup/youtube/35-Demo.png | Bin 0 -> 893957 bytes
 .../youtube/36-ImportExport.png| Bin 0 -> 1746845 bytes
 37 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/blog/2023-12-07-ccc2023-roundup/index.md 
b/blog/2023-12-07-ccc2023-roundup/index.md
index 28b60674..64cdb980 100644
--- a/blog/2023-12-07-ccc2023-roundup/index.md
+++ b/blog/2023-12-07-ccc2023-roundup/index.md
@@ -43,7 +43,7 @@ year of the project’s collaboration, developments in 
CloudStack and community
 activity. He sets out how he sees the project developing over the next few
 years.
 
-https://www.youtube.com/embed/cCNCmJxxEPA?si=4gDlygRMvxFkKtpf9controls=0;
 title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; 
clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" 
allowfullscreen>
+[![](youtube/01-StateOfTheUnion.png "State of the 
Union")](https://www.youtube.com/watch?v=cCNCmJxxEPA=4gDlygRMvxFkKtpf9)
 
 https://www.slideshare.net/slideshow/embed_code/key/hH2CO8kHcQaCQo?hostedIn=slidesharepage=upload;
 width="640" height="480" frameborder="0" marginwidth="0" marginheight="0" 
scrolling="no" allowfullscreen="allowfullscreen"> 
 
@@ -57,7 +57,7 @@ ingestion, Hypervisor agnostic simple DRS, CAPC aware CKS, 
OAuth2, DRaaS with
 Multi zone disaster recovery, etc and a summary of improvements added since the
 previous major LTS release of the CloudStack, ie, 4.18.0.
 
-https://www.youtube.com/embed/2TOM0oI80fU?si=I4k8FQJ_XGp4gDDK9controls=0;
 title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; 
clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" 
allowfullscreen>
+[![](youtube/02-whatsnew4.19.png "What's New in CloudStack 
4.19")](https://www.youtube.com/watch?v=2TOM0oI80fU=I4k8FQJ_XGp4gDDK9=0)
 
 

Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]

[via GitHub]

winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2057156177

   @DaanHoogland most of the GHI tests are failing due to an error with 
Codecov, which is also happening in other PRs, such as #8890.
   
   ```
   [2024-04-13T09:52:32.198Z] ['error'] There was an error running the 
uploader: Error uploading to https://codecov.io/: Error: There was an error 
fetching the storage URL during POST: 404 - {'detail': 
ErrorDetail(string='Unable to locate build via Github Actions API. Please 
upload with the Codecov repository upload token to resolve issue.', 
code='not_found')}
   ```
   The only exceptions are two failures in `test_network_permissions`, but this 
same test has finished successfully in the last CI run.
   
   ```
   Testing network permissions on project network ... === TestName: 
test_01_network_permission_on_project_network | Status : SUCCESS ===
   ok
   Testing network permissions on user network ... === TestName: 
test_02_network_permission_on_user_network | Status : SUCCESS ===
   ok
   Testing network operations on a create vm owned by other user ... === 
TestName: test_03_network_operations_on_created_vm_of_otheruser | Status : 
SUCCESS ===
   ok
   Deploy VM for other user and test VM operations by vm owner, network owner 
and domain admin ... === TestName: 
test_04_deploy_vm_for_other_user_and_test_vm_operations | Status : SUCCESS ===
   ok
   Testing list networks under a project ... === TestName: 
test_05_list_networks_under_project | Status : SUCCESS ===
   ok
   Testing list networks under a domain admin account and user account ... === 
TestName: test_06_list_networks_under_account | Status : SUCCESS ===
   ok
   
   --
   Ran 6 tests in 348.471s
   
   OK
   ```
   
   And the two tests that failed in the last run are failing in unrelated PRs 
as well: https://github.com/apache/cloudstack/pull/8511#issuecomment-1977729767.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

blueorangutan commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2057118018

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] CloudStask Add Ldap Account Empty List [cloudstack]

[via GitHub]

yuangeqingian commented on issue #8910:
URL: https://github.com/apache/cloudstack/issues/8910#issuecomment-2057006139

   > Do you have a more extensive stacktrace for this error?
   > 
   > From the given in-/output I see that on the cli you use -D 
"dir\Bgc_domain_join" while this is not in the bind principal nor in the 
binddn. Can this be the issue?
   
   Any more trouble shooting suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] CloudStask Add Ldap Account Empty List [cloudstack]

[via GitHub]

yuangeqingian commented on issue #8910:
URL: https://github.com/apache/cloudstack/issues/8910#issuecomment-2056996700

   > Do you have a more extensive stacktrace for this error?
   > 
   > From the given in-/output I see that on the cli you use -D 
"dir\Bgc_domain_join" while this is not in the bind principal nor in the 
binddn. Can this be the issue?
   
   No, the ldapsearch works perfectly:
   
   
![image](https://github.com/apache/cloudstack/assets/9658083/a2a33b53-b043-4d20-8c9b-7e2ec97ee043)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

blueorangutan commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2056970385

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]

[via GitHub]

sureshanaparti commented on PR #8815:
URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2056966865

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] CloudStask Add Ldap Account Empty List [cloudstack]

[via GitHub]

DaanHoogland commented on issue #8910:
URL: https://github.com/apache/cloudstack/issues/8910#issuecomment-2056942043

   Do you have a more extensive stacktrace for this error?
   
   From the given in-/output I see that on the cli you use -D 
"dir\Bgc_domain_join" while this is not in the bind principal nor in the 
binddn. Can this be the issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

DaanHoogland commented on code in PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#discussion_r1565813188


##
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java:
##
@@ -0,0 +1,111 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
+
+/**
+ * Uses a ScheduledExecutorService and config key to execute a runnable,
+ * dynamically rescheduling based on the long value of the config key.
+ * Timing is similar to ScheduledExecutorService.scheduleAtFixedRate(),
+ * but we look up the next runtime dynamically via the config key.
+ * 
+ * If config key is zero, this disables the execution. We skip execution
+ * and check once a minute in order to re-start execution if re-enabled.
+ */
+public class ConfigKeyScheduledExecutionWrapper implements Runnable {
+protected Logger logger = LogManager.getLogger(getClass());
+private final ScheduledExecutorService executorService;
+private final Runnable command;
+private final ConfigKey configKey;
+private final TimeUnit unit;
+private long enableIntervalSeconds = 60;
+
+private void validateArgs(ScheduledExecutorService executorService, 
Runnable command, ConfigKey configKey) {
+if (executorService == null) {
+throw new IllegalArgumentException("ExecutorService cannot be 
null");
+}
+if (command == null) {
+throw new IllegalArgumentException("Command cannot be null");
+}
+if (configKey == null) {
+throw new IllegalArgumentException("ConfigKey cannot be null");
+}
+}
+
+public ConfigKeyScheduledExecutionWrapper(ScheduledExecutorService 
executorService, Runnable command,
+ConfigKey configKey, TimeUnit unit) {
+validateArgs(executorService, command, configKey);
+this.executorService = executorService;
+this.command = command;
+this.configKey = configKey;
+this.unit = unit;
+}
+
+protected ConfigKeyScheduledExecutionWrapper(ScheduledExecutorService 
executorService, Runnable command,
+ConfigKey configKey, int enableIntervalSeconds, TimeUnit unit) {
+validateArgs(executorService, command, configKey);
+this.executorService = executorService;
+this.command = command;
+this.configKey = configKey;
+this.unit = unit;
+this.enableIntervalSeconds = enableIntervalSeconds;
+}
+
+public ScheduledFuture start() {
+long duration = getConfigValue();
+duration = duration < 0 ? 0 : duration;
+return this.executorService.schedule(this, duration, this.unit);
+}
+
+long getConfigValue() {
+if (this.configKey.value() instanceof Long) {
+return (Long) this.configKey.value();
+} else if (this.configKey.value() instanceof Integer) {
+return (Integer) this.configKey.value();
+} else {
+throw new IllegalArgumentException("ConfigKey value must be a Long 
or Integer");
+}
+}
+
+@Override
+public void run() {
+if (getConfigValue() <= 0) {
+executorService.schedule(this, enableIntervalSeconds, 
TimeUnit.SECONDS);

Review Comment:
   what happens if `ResourceCountCheckInterval` was set to a negative value 
before starting the management server? Should we defend against that?



##
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java:
##
@@ -0,0 +1,111 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this 

Re: [I] CloudStask Add Ldap Account Empty List [cloudstack]

[via GitHub]

yuangeqingian commented on issue #8910:
URL: https://github.com/apache/cloudstack/issues/8910#issuecomment-2056809265

   > @yuangeqingian , at first look, the excpetion says that the bind fails. 
This should mean the login is wrong.
   > 
   > By the looks of you cofiguration you are going for the manual import of 
accounts option, is that right?
   > 
   > The bind principal uses DC=DIR in capitals and the basedn uses dc=dir in 
lowercase. Can you check if that makes a difference?
   > 
   > Do you see any other exceptions in your logs or any error on the ldap side?
   
   1: Yes, I tried to use manual login
   2: I tried all capital and all in lowercase, all didn't work
   3: the acs management log showed below:
   DEBUG [o.a.c.l.LdapContextFactory]  initializing ldap with provider url: 
ldap://dir.slb.com:389
   DEBUG [o.a.c.l.LdapManagerImpl]  NamingException while doing an LDAP bind
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2056801997

   > > LGTM, manually tested
   > 
   > @vishesh92 @borisstoyanov could you be more clear about the tests you have 
done?
   
   I have updated the description of the PR with the cases I tested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2056801278

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

blueorangutan commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2056789523

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8911:
URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056789514

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9262


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] feature: webhooks [cloudstack]

[via GitHub]

blueorangutan commented on PR #8674:
URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2056789513

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix migration from local storage to NFS in KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8909:
URL: https://github.com/apache/cloudstack/pull/8909#issuecomment-2056789516

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

GutoVeronezi commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2056780629

   > LGTM, manually tested
   
   @vishesh92 @borisstoyanov could you be more clear about the tests you have 
done? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

blueorangutan commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2056766143

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 commented on PR #8916:
URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2056764879

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Introduce scheduled executor wrapper with dynamic interval [cloudstack]

[via GitHub]

vishesh92 opened a new pull request, #8916:
URL: https://github.com/apache/cloudstack/pull/8916

   ### Description
   
   This PR adds the ability for a Scheduled execution timing to be adjusted 
dynamically. Normally, adjusting the interval that these run requires a restart 
of the management services, which can be problematic for experimenting with 
intervals or just making adjustments without downtime.
   
   Introduces `ConfigKeyScheduledExecutionWrapper` that can read a `Long` from 
a `ConfigKey` and dynamically adjust execution interval. The current 
implementation only supports emulating the behavior of `scheduleAtFixedRate` - 
meaning if the first run is at `N`, the next is at `N + configKey.value()`, 
ignoring the run time of the task itself. If the task takes longer than 
`configKey.value()`, the next run occurs immediately.
   
   This PR also converts `ResourceCountCheckTask` to run on dynamic interval.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   Unit tests and manual testing.
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] VSAN Storage Policy Question [cloudstack]

[via GitHub]

ahmadamirahmadi007 commented on issue #8914:
URL: https://github.com/apache/cloudstack/issues/8914#issuecomment-2056737727

   i can fetch all storage policy in cloudstack but when i create vm from that 
disk offering, policy just apply to DATADISK not to ROOTDISK. i mean when i 
check vm setting on vcenter the datadisk is only configure with that specific 
vsan policy and rootdisk policy stay on default storage policy. 
   
![image](https://github.com/apache/cloudstack/assets/104001728/6f1d7f7c-1351-4dec-b45f-590a763604cf)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8911:
URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056637524

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

[via GitHub]

JoaoJandre commented on PR #8911:
URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056636223

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix migration from local storage to NFS in KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8909:
URL: https://github.com/apache/cloudstack/pull/8909#issuecomment-2056629655

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix migration from local storage to NFS in KVM [cloudstack]

[via GitHub]

JoaoJandre commented on PR #8909:
URL: https://github.com/apache/cloudstack/pull/8909#issuecomment-2056627084

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] feature: webhooks [cloudstack]

[via GitHub]

blueorangutan commented on PR #8674:
URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2056626258

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] feature: webhooks [cloudstack]

[via GitHub]

shwstppr commented on PR #8674:
URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2056624511

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056563022

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056562148

   @blueorangutan test alma9 kvm-alma9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

blueorangutan commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056545808

   @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

vishesh92 commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056544736

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

blueorangutan commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056528922

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056464085

   [SF] Trillian Build Failed (tid-9831)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056420805

   @DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056419457

   @blueorangutan test rocky8 kvm-rocky8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

blueorangutan commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056416921

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056413412

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

vishesh92 commented on code in PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#discussion_r1565495355


##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##
@@ -2969,7 +2969,10 @@ protected void 
setVAppPropertiesToConfigSpec(VmConfigInfo vAppConfig,
 }
 
 private String appendFileType(String path, String fileType) {
-if (path.toLowerCase().endsWith(fileType.toLowerCase())) {
+if (path == null) {
+throw new CloudRuntimeException("No path given, cannot append 
filetype" + fileType);
+}
+if (fileType = null || 
path.toLowerCase().endsWith(fileType.toLowerCase())) {

Review Comment:
   ```suggestion
   if (fileType == null || 
path.toLowerCase().endsWith(fileType.toLowerCase())) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] VSAN Storage Policy Question [cloudstack]

[via GitHub]

harikrishna-patnala commented on issue #8914:
URL: https://github.com/apache/cloudstack/issues/8914#issuecomment-2056414057

   If you have created the storage policy after the zone is created in 
CloudStack you can import the new policies using importVsphereStoragePolicies 
or updateZone APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

vishesh92 commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056413475

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

[via GitHub]

blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2056413246

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

DaanHoogland commented on code in PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#discussion_r1565496039


##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##
@@ -2969,7 +2969,10 @@ protected void 
setVAppPropertiesToConfigSpec(VmConfigInfo vAppConfig,
 }
 
 private String appendFileType(String path, String fileType) {
-if (path.toLowerCase().endsWith(fileType.toLowerCase())) {
+if (path == null) {
+throw new CloudRuntimeException("No path given, cannot append 
filetype" + fileType);
+}
+if (fileType = null || 
path.toLowerCase().endsWith(fileType.toLowerCase())) {

Review Comment:
   :doh:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2056410401

   @blueorangutan test alma9 kvm-alma9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056409514

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056407571

   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] VSAN Storage Policy Question [cloudstack]

[via GitHub]

harikrishna-patnala commented on issue #8914:
URL: https://github.com/apache/cloudstack/issues/8914#issuecomment-2056407214

   @ahmadamirahmadi007  you can select the storage policy while creating the 
service offering and use it for deploying the VM.
   
   ![Screenshot from 2024-04-15 
15-14-29](https://github.com/apache/cloudstack/assets/3348673/b08d383c-60d7-4b37-a744-7c5d9b7e059b)
   
   Have you tried this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

blueorangutan commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056406021

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

[via GitHub]

shwstppr commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1565422034


##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/AbstractPrimaryDataStoreLifeCycleImpl.java:
##
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.storage.datastore.lifecycle;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.ClusterScope;
+import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
+import org.apache.cloudstack.storage.volume.datastore.PrimaryDataStoreHelper;
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.AgentManager;
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.DeleteStoragePoolCommand;
+import com.cloud.host.HostVO;
+import com.cloud.host.dao.HostDao;
+import com.cloud.hypervisor.Hypervisor.HypervisorType;
+import com.cloud.resource.ResourceManager;
+import com.cloud.storage.StorageManager;
+import com.cloud.storage.StoragePool;
+import com.cloud.storage.StoragePoolHostVO;
+import com.cloud.storage.dao.StoragePoolHostDao;
+import com.cloud.utils.Pair;
+
+public class AbstractPrimaryDataStoreLifeCycleImpl {

Review Comment:
   minor: would it make sense to name it BasePrimaryDataStoreLifeCycleImpl 
instead?



##
plugins/storage/volume/sample/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java:
##
@@ -146,4 +146,14 @@ public void enableStoragePool(DataStore store) {
 @Override
 public void disableStoragePool(DataStore store) {
 }
+
+@Override
+public void changeStoragePoolScopeToZone(DataStore store, ClusterScope 
clusterScope, HypervisorType hypervisorType) {
+return;

Review Comment:
   Not sure if these return statement add much value



##
engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java:
##
@@ -841,4 +866,13 @@ public List listByIds(List ids) {
 sc.setParameters("idIN", ids.toArray());
 return listBy(sc, null);
 }
+
+@Override
+public List listByPoolIdVMStatesNotInCluster(long clusterId, 
List states, long poolId) {
+SearchCriteria sc = volumePoolNotInClusterSearch.create();
+sc.setParameters("poolId", poolId);
+sc.setParameters("vmStates", states);

Review Comment:
   Should this use `setJoinParameters`?



##
ui/src/config/section/infra/primaryStorages.js:
##
@@ -133,6 +133,24 @@ export default {
   dataView: true,
   show: (record) => { return ['Maintenance', 'PrepareForMaintenance', 
'ErrorInMaintenance'].includes(record.state) }
 },
+{
+  api: 'changeStoragePoolScope',
+  icon: 'arrow-right-outlined',
+  label: 'label.action.change.primary.storage.scope',
+  dataView: true,
+  popup: true,
+  show: (record) => {
+return (record.state === 'Disabled' &&
+  (record.hypervisor === 'KVM' ||
+   record.hypervisor === 'VMware' ||
+   record.hypervisor === 'HyperV' ||
+   record.hypervisor === 'LXC' ||
+   record.hypervisor === 'Any' ||
+   record.hypervisor === 'Simulator')

Review Comment:
   PR description says feature is supported for KVM, VMware and Simulator only?



##
ui/src/views/infra/changeStoragePoolScope.vue:
##
@@ -0,0 +1,226 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// 

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

blueorangutan commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056328850

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056324404

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] protect against null-path [cloudstack]

[via GitHub]

DaanHoogland commented on PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2056320301

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] protect against null-path [cloudstack]

[via GitHub]

DaanHoogland opened a new pull request, #8915:
URL: https://github.com/apache/cloudstack/pull/8915

   ### Description
   
   This PR...
   
   
   
   
   
   
   
   Fixes: 8747
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Access compute instance(s) even if management server is down. [cloudstack]

[via GitHub]

psyma commented on issue #8913:
URL: https://github.com/apache/cloudstack/issues/8913#issuecomment-2056207028

   @rajujith Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Access compute instance(s) even if management server is down. [cloudstack]

[via GitHub]

psyma closed issue #8913: Access compute instance(s) even if management server 
is down.
URL: https://github.com/apache/cloudstack/issues/8913


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

[via GitHub]

blueorangutan commented on PR #8911:
URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056202812

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9256


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

[via GitHub]

blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2056185207

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9255


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

(cloudstack-docs-rn) branch master updated: Update rnotes.po

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new 05ec924  Update rnotes.po
05ec924 is described below

commit 05ec924c64e7a0d8e94823aceb0c59405bcf6a80
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 14:01:46 2024 +0530

Update rnotes.po
---
 source/locale/ja/LC_MESSAGES/rnotes.po | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/source/locale/ja/LC_MESSAGES/rnotes.po 
b/source/locale/ja/LC_MESSAGES/rnotes.po
index e53f851..813f69c 100644
--- a/source/locale/ja/LC_MESSAGES/rnotes.po
+++ b/source/locale/ja/LC_MESSAGES/rnotes.po
@@ -205,7 +205,7 @@ msgstr ""
 #: ../../source/rnotes.rst:1256 ../../source/rnotes.rst:1674
 #: ../../source/rnotes.rst:2499
 msgid ""
-"URL: http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14;
+"URL: 
http://download.cloudstack.org/templates/4.3/systemvm64template-2014-01-14;
 "-master-xen.vhd.bz2"
 msgstr ""
 
@@ -426,7 +426,7 @@ msgstr ""
 #: ../../source/rnotes.rst:1281 ../../source/rnotes.rst:1700
 #: ../../source/rnotes.rst:2524
 msgid ""
-"URL: http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14;
+"URL: 
http://download.cloudstack.org/templates/4.3/systemvm64template-2014-01-14;
 "-master-kvm.qcow2.bz2"
 msgstr ""
 
@@ -494,7 +494,7 @@ msgstr ""
 #: ../../source/rnotes.rst:1306 ../../source/rnotes.rst:1726
 #: ../../source/rnotes.rst:2549
 msgid ""
-"URL: http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14;
+"URL: 
http://download.cloudstack.org/templates/4.3/systemvm64template-2014-01-14;
 "-master-vmware.ova"
 msgstr ""
 
@@ -2163,7 +2163,7 @@ msgstr ""
 msgid ""
 "If you are using version 2.2.0 - 2.2.13, first upgrade to 2.2.14 by using "
 "the instructions in the `2.2.14 Release Notes "
-"`__."
+"`__."
 msgstr ""
 
 # 43af6a2f821148dc933817dda7004642

(cloudstack-docs-rn) branch master updated: Update upgrade-4.2.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new b512d45  Update upgrade-4.2.rst
b512d45 is described below

commit b512d4529da7d1602eb42ceae8f4ba6760cdb180
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 14:01:06 2024 +0530

Update upgrade-4.2.rst
---
 source/upgrade/upgrade-4.2.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.2.rst b/source/upgrade/upgrade-4.2.rst
index daa5bac..d17ab33 100644
--- a/source/upgrade/upgrade-4.2.rst
+++ b/source/upgrade/upgrade-4.2.rst
@@ -248,13 +248,13 @@ Hypervisor: Xen/XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_ 
+Copy the file `vhd-utils `_ 
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 .. include:: _xenserver_upg.rst
 

(cloudstack-docs-rn) branch master updated: Update upgrade-4.5.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new 65e317b  Update upgrade-4.5.rst
65e317b is described below

commit 65e317be0bcf4e764f4f7c0b586d14e850c69213
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:58:45 2024 +0530

Update upgrade-4.5.rst
---
 source/upgrade/upgrade-4.5.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.5.rst b/source/upgrade/upgrade-4.5.rst
index b8f0038..245dc9c 100644
--- a/source/upgrade/upgrade-4.5.rst
+++ b/source/upgrade/upgrade-4.5.rst
@@ -254,13 +254,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-rn) branch master updated: Update upgrade-4.8.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new 875ad84  Update upgrade-4.8.rst
875ad84 is described below

commit 875ad84850f2fd6b28e1ed5d8a399d2371ff98c4
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:58:24 2024 +0530

Update upgrade-4.8.rst
---
 source/upgrade/upgrade-4.8.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.8.rst b/source/upgrade/upgrade-4.8.rst
index d6e97d6..0561f58 100644
--- a/source/upgrade/upgrade-4.8.rst
+++ b/source/upgrade/upgrade-4.8.rst
@@ -248,13 +248,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-rn) branch master updated: Update upgrade-4.11.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new 0e2ef7f  Update upgrade-4.11.rst
0e2ef7f is described below

commit 0e2ef7f2260a9f6235ceb8464d28d87831dc566d
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:58:07 2024 +0530

Update upgrade-4.11.rst
---
 source/upgrade/upgrade-4.11.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.11.rst b/source/upgrade/upgrade-4.11.rst
index 71946e4..b578b33 100644
--- a/source/upgrade/upgrade-4.11.rst
+++ b/source/upgrade/upgrade-4.11.rst
@@ -247,13 +247,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-rn) branch master updated: Update upgrade-4.6.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new b1fec6c  Update upgrade-4.6.rst
b1fec6c is described below

commit b1fec6c8fcdd911a033133cfda5282d5125669c5
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:57:49 2024 +0530

Update upgrade-4.6.rst
---
 source/upgrade/upgrade-4.6.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.6.rst b/source/upgrade/upgrade-4.6.rst
index cde2160..879cd85 100644
--- a/source/upgrade/upgrade-4.6.rst
+++ b/source/upgrade/upgrade-4.6.rst
@@ -252,13 +252,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-rn) branch master updated: Update upgrade-4.7.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new a96f3e6  Update upgrade-4.7.rst
a96f3e6 is described below

commit a96f3e6169e475d78942dc9f54171cdf848e5142
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:57:05 2024 +0530

Update upgrade-4.7.rst
---
 source/upgrade/upgrade-4.7.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.7.rst b/source/upgrade/upgrade-4.7.rst
index 40f0572..3bc862a 100644
--- a/source/upgrade/upgrade-4.7.rst
+++ b/source/upgrade/upgrade-4.7.rst
@@ -245,13 +245,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-rn) branch master updated: Update upgrade-4.4.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new b561b54  Update upgrade-4.4.rst
b561b54 is described below

commit b561b544534499d9aeecbf5a779ac45e85031067
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:59:05 2024 +0530

Update upgrade-4.4.rst
---
 source/upgrade/upgrade-4.4.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.4.rst b/source/upgrade/upgrade-4.4.rst
index 6289efe..d53ad2d 100644
--- a/source/upgrade/upgrade-4.4.rst
+++ b/source/upgrade/upgrade-4.4.rst
@@ -254,13 +254,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 .. include:: _xenserver_upg.rst
 

(cloudstack-docs-rn) branch master updated: Update upgrade-4.10.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new a47713b  Update upgrade-4.10.rst
a47713b is described below

commit a47713b75ea69cb2f8d0db4d23b5ed7f413f2768
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:57:27 2024 +0530

Update upgrade-4.10.rst
---
 source/upgrade/upgrade-4.10.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.10.rst b/source/upgrade/upgrade-4.10.rst
index 3441a4e..b0f7399 100644
--- a/source/upgrade/upgrade-4.10.rst
+++ b/source/upgrade/upgrade-4.10.rst
@@ -252,13 +252,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-rn) branch master updated: Update upgrade-4.3.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new dcabbf9  Update upgrade-4.3.rst
dcabbf9 is described below

commit dcabbf9b1a8f6568b3390780e014236680cc3041
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:56:38 2024 +0530

Update upgrade-4.3.rst
---
 source/upgrade/upgrade-4.3.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.3.rst b/source/upgrade/upgrade-4.3.rst
index 3843238..bf06177 100644
--- a/source/upgrade/upgrade-4.3.rst
+++ b/source/upgrade/upgrade-4.3.rst
@@ -252,13 +252,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_ 
+Copy the file `vhd-utils `_ 
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 .. include:: _xenserver_upg.rst
 

(cloudstack-docs-rn) branch master updated: Update rnotes.pot

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new 5e29089  Update rnotes.pot
5e29089 is described below

commit 5e2908940460fdcf8528c66f2bd6b4adf918bc82
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:56:03 2024 +0530

Update rnotes.pot
---
 source/locale/pot/rnotes.pot | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/source/locale/pot/rnotes.pot b/source/locale/pot/rnotes.pot
index e1f188b..a2f3f09 100644
--- a/source/locale/pot/rnotes.pot
+++ b/source/locale/pot/rnotes.pot
@@ -213,7 +213,7 @@ msgstr ""
 # a8b209e329fc41ce94ec334acd8dc4d0
 # a26c20ade808412ab062e4a910efcde5
 # bfaf491e156c4f9ab1e381a756900595
-msgid "URL: 
http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14-master-xen.vhd.bz2;
+msgid "URL: 
http://download.cloudstack.org/templates/4.3/systemvm64template-2014-01-14-master-xen.vhd.bz2;
 msgstr ""
 
 #: ../../rnotes.rst:78
@@ -483,7 +483,7 @@ msgstr ""
 # b11d6d74b8e340d2af1246f535bed9e1
 # 9ded492ee518410f88bfa49eab1e31b8
 # 3fb14024946f4d70b472ccc0fa7b876a
-msgid "URL: 
http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14-master-kvm.qcow2.bz2;
+msgid "URL: 
http://download.cloudstack.org/templates/4.3/systemvm64template-2014-01-14-master-kvm.qcow2.bz2;
 msgstr ""
 
 #: ../../rnotes.rst:105
@@ -561,7 +561,7 @@ msgstr ""
 # c5214485e9114e2eb71127c7d7de6965
 # 0c755ceff7c547348ff3a27a613ef83a
 # a56695f39bb84f899e7915122a3c430a
-msgid "URL: 
http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14-master-vmware.ova;
+msgid "URL: 
http://download.cloudstack.org/templates/4.3/systemvm64template-2014-01-14-master-vmware.ova;
 msgstr ""
 
 #: ../../rnotes.rst:130
@@ -2009,7 +2009,7 @@ msgstr ""
 
 #: ../../rnotes.rst:2456
 # 0f112aff5e3a40229d261d3025697c2a
-msgid "If you are using version 2.2.0 - 2.2.13, first upgrade to 2.2.14 by 
using the instructions in the `2.2.14 Release Notes 
`__."
+msgid "If you are using version 2.2.0 - 2.2.13, first upgrade to 2.2.14 by 
using the instructions in the `2.2.14 Release Notes 
`__."
 msgstr ""
 
 #: ../../rnotes.rst:2460

Re: [I] Refine SMBIOS info for KVM or Others [cloudstack]

[via GitHub]

NuxRo commented on issue #8912:
URL: https://github.com/apache/cloudstack/issues/8912#issuecomment-2056142516

   > Just cross checked with cloud-init, it is require this metadata to do 
initialization, seems no solution.
   
   You could instruct cloud-init it's running on CloudStack by means of config 
file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

(cloudstack-docs-rn) branch master updated: Update upgrade-4.9.rst

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/master by this push:
 new 24845f3  Update upgrade-4.9.rst
24845f3 is described below

commit 24845f37b5770cd73dfc29d52275ea739a47c4a6
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:54:03 2024 +0530

Update upgrade-4.9.rst
---
 source/upgrade/upgrade-4.9.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/upgrade/upgrade-4.9.rst b/source/upgrade/upgrade-4.9.rst
index 7f6af71..3f79dd6 100644
--- a/source/upgrade/upgrade-4.9.rst
+++ b/source/upgrade/upgrade-4.9.rst
@@ -248,13 +248,13 @@ Hypervisor: XenServer
 -
 
 **(XenServer only)** Copy vhd-utils file on CloudStack management servers.
-Copy the file `vhd-utils 
`_
+Copy the file `vhd-utils `_
 to ``/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver``.
 
 .. sourcecode:: bash
 
wget -P /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver \
-   http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
+   http://download.cloudstack.org/tools/vhd-util
 
 
 Hypervisor: VMware

(cloudstack-docs-install) branch master updated: Update hypervisor_installation.pot

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git


The following commit(s) were added to refs/heads/master by this push:
 new 2874c93  Update hypervisor_installation.pot
2874c93 is described below

commit 2874c93a2bae452e477870752599d49d6226610c
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:52:14 2024 +0530

Update hypervisor_installation.pot
---
 source/locale/pot/hypervisor_installation.pot | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/source/locale/pot/hypervisor_installation.pot 
b/source/locale/pot/hypervisor_installation.pot
index 180fcff..b904b91 100644
--- a/source/locale/pot/hypervisor_installation.pot
+++ b/source/locale/pot/hypervisor_installation.pot
@@ -1385,7 +1385,7 @@ msgstr ""
 
 #: ../../hypervisor_installation.rst:1181
 # 54880e3acb4945b4ae3d3fb251252130
-msgid 
"`http://download.cloud.com/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz 
`_"
+msgid 
"`http://download.cloudstack.org/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz
 
`_"
 msgstr ""
 
 #: ../../hypervisor_installation.rst:1183
@@ -1395,7 +1395,7 @@ msgstr ""
 
 #: ../../hypervisor_installation.rst:1185
 # b1533b01dec04d8ea37cb07d541d8013
-msgid "`http://download.cloud.com/releases/2.2.0/xenserver-cloud-supp.tgz 
`_"
+msgid "`http://download.cloudstack.org/releases/2.2.0/xenserver-cloud-supp.tgz 
`_"
 msgstr ""
 
 #: ../../hypervisor_installation.rst:1187
@@ -1405,7 +1405,7 @@ msgstr ""
 
 #: ../../hypervisor_installation.rst:1189
 # bc80c4fa363248c292882b511d90808a
-msgid "`http://download.cloud.com/releases/3.0/xenserver-cloud-supp.tgz 
`_"
+msgid "`http://download.cloudstack.org/releases/3.0/xenserver-cloud-supp.tgz 
`_"
 msgstr ""
 
 #: ../../hypervisor_installation.rst:1193

(cloudstack-docs-install) branch master updated: Update hypervisor_installation.po

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git


The following commit(s) were added to refs/heads/master by this push:
 new d579331  Update hypervisor_installation.po
d579331 is described below

commit d579331e26643c2a18be1b5bdac8b4505ec57683
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:51:51 2024 +0530

Update hypervisor_installation.po
---
 .../zh_CN/LC_MESSAGES/hypervisor_installation.po   | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/source/locale/zh_CN/LC_MESSAGES/hypervisor_installation.po 
b/source/locale/zh_CN/LC_MESSAGES/hypervisor_installation.po
index dcbb0b5..946637b 100644
--- a/source/locale/zh_CN/LC_MESSAGES/hypervisor_installation.po
+++ b/source/locale/zh_CN/LC_MESSAGES/hypervisor_installation.po
@@ -1565,10 +1565,10 @@ msgstr "适用于XenServer 6.0.2："
 # 54880e3acb4945b4ae3d3fb251252130
 #: ../../hypervisor_installation.rst:1181
 msgid ""
-"`http://download.cloud.com/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz "
-"`_"
-msgstr 
"`http://download.cloud.com/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz 
`_"
+msgstr 
"`http://download.cloudstack.org/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz
 
`_"
 
 # 4405c659cea34cb2895c0f43693473f1
 #: ../../hypervisor_installation.rst:1183
@@ -1578,9 +1578,9 @@ msgstr "适用于XenServer 5.6 SP2:"
 # b1533b01dec04d8ea37cb07d541d8013
 #: ../../hypervisor_installation.rst:1185
 msgid ""
-"`http://download.cloud.com/releases/2.2.0/xenserver-cloud-supp.tgz "
-"`_"
-msgstr "`http://download.cloud.com/releases/2.2.0/xenserver-cloud-supp.tgz 
`_"
+"`http://download.cloudstack.org/releases/2.2.0/xenserver-cloud-supp.tgz "
+"`_"
+msgstr 
"`http://download.cloudstack.org/releases/2.2.0/xenserver-cloud-supp.tgz 
`_"
 
 # 994df5c8945149b7b8663a2e603fc847
 #: ../../hypervisor_installation.rst:1187
@@ -1590,9 +1590,9 @@ msgstr "适用于XenServer 6.0:"
 # bc80c4fa363248c292882b511d90808a
 #: ../../hypervisor_installation.rst:1189
 msgid ""
-"`http://download.cloud.com/releases/3.0/xenserver-cloud-supp.tgz "
-"`_"
-msgstr "`http://download.cloud.com/releases/3.0/xenserver-cloud-supp.tgz 
`_"
+"`http://download.cloudstack.org/releases/3.0/xenserver-cloud-supp.tgz "
+"`_"
+msgstr "`http://download.cloudstack.org/releases/3.0/xenserver-cloud-supp.tgz 
`_"
 
 # 09db532336c943caa7e4713f7f57deaa
 #: ../../hypervisor_installation.rst:1193

(cloudstack-docs-install) branch master updated: Update building_from_source.po

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git


The following commit(s) were added to refs/heads/master by this push:
 new 527e03d  Update building_from_source.po
527e03d is described below

commit 527e03d30ec7c85b543df62dfa5166463b2e58d6
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:51:22 2024 +0530

Update building_from_source.po
---
 source/locale/zh_CN/LC_MESSAGES/building_from_source.po | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/locale/zh_CN/LC_MESSAGES/building_from_source.po 
b/source/locale/zh_CN/LC_MESSAGES/building_from_source.po
index ce68b1a..10964e3 100644
--- a/source/locale/zh_CN/LC_MESSAGES/building_from_source.po
+++ b/source/locale/zh_CN/LC_MESSAGES/building_from_source.po
@@ -561,10 +561,10 @@ msgstr "由于这些模块需要的依赖项不能和CloudStack一起发行，
 #: ../../building_from_source.rst:446
 msgid ""
 "You may also need to download `vhd-util "
-"`_, which was "
+"`_, which was "
 "removed due to licensing issues. You'll copy vhd-util to the "
 "``scripts/vm/hypervisor/xenserver/`` directory."
-msgstr "你可能还需要下载`vhd-util 
`_, 也是由于授权问题而被移除。 
复制vhd-util到该目录： ``scripts/vm/hypervisor/xenserver/``."
+msgstr "你可能还需要下载`vhd-util `_, 
也是由于授权问题而被移除。 复制vhd-util到该目录： ``scripts/vm/hypervisor/xenserver/``."
 
 # bfbd7215ff0345f183a7946f620b1368
 #: ../../building_from_source.rst:451

(cloudstack-docs-install) branch master updated: Update xenserver.po

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git


The following commit(s) were added to refs/heads/master by this push:
 new 117c28a  Update xenserver.po
117c28a is described below

commit 117c28a65f3972e42f71782797bbd35e79fd3c99
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:50:22 2024 +0530

Update xenserver.po
---
 .../locale/zh_CN/LC_MESSAGES/hypervisor/xenserver.po   | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/source/locale/zh_CN/LC_MESSAGES/hypervisor/xenserver.po 
b/source/locale/zh_CN/LC_MESSAGES/hypervisor/xenserver.po
index d87ecf4..7d5f9dd 100644
--- a/source/locale/zh_CN/LC_MESSAGES/hypervisor/xenserver.po
+++ b/source/locale/zh_CN/LC_MESSAGES/hypervisor/xenserver.po
@@ -302,10 +302,10 @@ msgstr "适用于XenServer 6.0.2："
 # c7d858231a3142109c09bfcc3340078b
 #: ../../hypervisor/xenserver.rst:193
 msgid ""
-"`http://download.cloud.com/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz "
-"`_"
-msgstr 
"`http://download.cloud.com/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz 
`_"
+msgstr 
"`http://download.cloudstack.org/releases/3.0.1/XS-6.0.2/xenserver-cloud-supp.tgz
 
`_"
 
 # 2cbbc4bcdcdd42d0816a6b2df748a0d6
 #: ../../hypervisor/xenserver.rst:196
@@ -315,9 +315,9 @@ msgstr "适用于XenServer 5.6 SP2:"
 # beac106ea20e420cae0ca5acb450646b
 #: ../../hypervisor/xenserver.rst:198
 msgid ""
-"`http://download.cloud.com/releases/2.2.0/xenserver-cloud-supp.tgz "
-"`_"
-msgstr "`http://download.cloud.com/releases/2.2.0/xenserver-cloud-supp.tgz 
`_"
+"`http://download.cloudstack.org/releases/2.2.0/xenserver-cloud-supp.tgz "
+"`_"
+msgstr 
"`http://download.cloudstack.org/releases/2.2.0/xenserver-cloud-supp.tgz 
`_"
 
 # 62cd9713906c45dc96254605c7134b11
 #: ../../hypervisor/xenserver.rst:201
@@ -327,9 +327,9 @@ msgstr "适用于XenServer 6.0:"
 # 998fd323b14c42149cc6633f4df39b83
 #: ../../hypervisor/xenserver.rst:203
 msgid ""
-"`http://download.cloud.com/releases/3.0/xenserver-cloud-supp.tgz "
-"`_"
-msgstr "`http://download.cloud.com/releases/3.0/xenserver-cloud-supp.tgz 
`_"
+"`http://download.cloudstack.org/releases/3.0/xenserver-cloud-supp.tgz "
+"`_"
+msgstr "`http://download.cloudstack.org/releases/3.0/xenserver-cloud-supp.tgz 
`_"
 
 # 50f6122c6c5e42dbb34f5942e788bd76
 #: ../../hypervisor/xenserver.rst:207

(cloudstack-docs-install) branch master updated: Update installation.po

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git


The following commit(s) were added to refs/heads/master by this push:
 new 75ed809  Update installation.po
75ed809 is described below

commit 75ed809ae6bcacf5f22e837c2939c7ad7a364941
Author: Rohit Yadav 
AuthorDate: Mon Apr 15 13:50:55 2024 +0530

Update installation.po
---
 source/locale/zh_CN/LC_MESSAGES/installation.po | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/source/locale/zh_CN/LC_MESSAGES/installation.po 
b/source/locale/zh_CN/LC_MESSAGES/installation.po
index 7ea4ad0..a3d558c 100644
--- a/source/locale/zh_CN/LC_MESSAGES/installation.po
+++ b/source/locale/zh_CN/LC_MESSAGES/installation.po
@@ -591,8 +591,8 @@ msgstr "这个步骤仅适用于安装了XenServer的hypervisor主机。"
 #: ../../installation.rst:358
 msgid ""
 "Before setting up the Management Server, download vhd-util from `vhd-util "
-"`_."
-msgstr "在设置管理服务器前，下载 
`vhd-util`_."
+"`_."
+msgstr "在设置管理服务器前，下载 
`vhd-util`_."
 
 # d4c4d9a792ec46bbacc984b02fa8dd22
 #: ../../installation.rst:361
@@ -1409,8 +1409,8 @@ msgstr "这个步骤仅适用于安装了XenServer的hypervisor主机。"
 #: ../../installation.rst:1085
 msgid ""
 "Download vhd-util from `vhd-util "
-"`_"
-msgstr "下载 `vhd-util 
`_"
+"`_"
+msgstr "下载 `vhd-util `_"
 
 # 3b0ff1adaf804ec4b60b43307747e306
 #: ../../installation.rst:1088