[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-03 Thread via GitHub
harikrishna-patnala commented on code in PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1183283308 ## .github/workflows/ci.yml: ## @@ -79,7 +79,8 @@ jobs: smoke/test_metrics_api smoke/test_migration

[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-04-14 Thread via GitHub
harikrishna-patnala commented on code in PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1166499359 ## server/src/test/java/com/cloud/network/NetworkServiceImplTest.java: ## @@ -770,4 +773,144 @@ public void

[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-04-14 Thread via GitHub
harikrishna-patnala commented on code in PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1166400625 ## api/src/main/java/com/cloud/network/vpc/VpcService.java: ## @@ -34,10 +35,10 @@ import com.cloud.network.IpAddress; import com.cloud.user.User;