[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2018-01-03 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355152887 @rhtyd @borisstoyanov I manually ran `test_public_ip_range.py` and `test_ssvm.py` in a built-from-scratch KVM

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-12-24 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-353800260 @blueorangutan test This is an automated

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-12-24 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-353799204 @blueorangutan package This is an automated

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-12-24 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-353799168 @rhtyd sure, thanks This is an automated

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-12-23 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-353746236 @blueorangutan test This is an automated

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-12-23 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-353745056 @rhtyd this is ready, I have fixed conflicts and pushed, tested again in local environment: Test

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-25 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-339542073 @nitin-maharana thanks for your review and comments! UI screenshots are added on PR description and refactor is

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-25 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-339542073 @nitin-maharana thanks for your review and comments! UI screenshots are added on PR description and refactor is

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-24 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-339016274 @nitin-maharana thanks for your review! I'll try addressing your comments asap, thanks!

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-18 Thread GitBox
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-337573323 @borisstoyanov done. The only main concern for this community PR is fix for `domain_vlan_map`. @ustcweizhou

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336240972 @borisstoyanov @rhtyd @DaanHoogland Guys, one issue while porting this feature to 4.11 which was not

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336218792 @blueorangutan test This is an automated

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336210130 @blueorangutan package This is an automated